GitHub user jasonwilliams200OK opened a pull request:
https://github.com/apache/log4net/pull/32
Implement log4net.Extensions.Logging extension for aspnet core
### Add extension source project - 1ff39f9
Created extension package at:
`extensions/log4net.Extensions.Logging
GitHub user jasonwilliams200OK opened a pull request:
https://github.com/apache/log4net/pull/31
Add packOptions
The package produced by:
```sh
cd log4net/netstandard/log4net
dotnet restore
dotnet pack -c Release
```
at `./bin/Release/log4net
Github user jasonwilliams200OK commented on the issue:
https://github.com/apache/log4net/pull/30
I have rebased it against trunk. To review without whitespace diff, here is
the proper diff link: https://github.com/apache/log4net/pull/30/files?w=1
---
If your project is set up
Github user jasonwilliams200OK commented on the issue:
https://github.com/apache/log4net/pull/16
@bodewig, #30 fixed exactly this issue. Can you try with my branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jasonwilliams200OK commented on the issue:
https://github.com/apache/log4net/pull/16
Fixed the build breakage and feedback in #30.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jasonwilliams200OK opened a pull request:
https://github.com/apache/log4net/pull/30
Misc. fixes for netstandard
This PR:
- fix the failing build by providing `[Read/Write]Async` overloads for
net45 and netstandard TFMs in FileAppender. This was a miss in #16
Github user jasonwilliams200OK closed the pull request at:
https://github.com/apache/log4net/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jasonwilliams200OK commented on the issue:
https://github.com/apache/log4net/pull/26
Ops, it was actually the one in the following method:
https://github.com/apache/log4net/blob/6308def/tests/src/Appender/RollingFileAppenderTest.cs#L1711
which was unused. But now that has
Github user jasonwilliams200OK commented on the issue:
https://github.com/apache/log4net/pull/16
Thanks a lot @bodewig! I am definitely willing to participate. I will test
out the master and try to incorporate the feedback in subsequent PR pronto
(before you start cutting the release
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r74683879
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r73228215
--- Diff: netstandard/log4net/project.json ---
@@ -0,0 +1,94 @@
+{
+ "name": "log4net",
+ "version"
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601430
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601024
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo
info
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70600785
--- Diff: tests/src/Utils.cs ---
@@ -105,7 +114,28 @@ private static Type[] GetTypesArray(object[] args)
internal static void
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70599902
--- Diff: src/Appender/AppenderCollection.cs ---
@@ -26,7 +26,10 @@ namespace log4net.Appender
/// A strongly-typed collection of objects
GitHub user jasonwilliams200OK opened a pull request:
https://github.com/apache/log4net/pull/26
Remove an unused variable
Fixes a warning.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasonwilliams200OK/log4net trunk
16 matches
Mail list logo
