[GitHub] log4net pull request #41: Recursive logging
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/41 Recursive logging Fixes LOG4NET-550 This fix will be needed to implement logging from the AsyncAppender I am working on. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net RecursiveLogging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit ba250994011db8406b1965ff0bd71dfff7f5b771 Author: JJoe2 <jocular...@hotmail.com> Date: 2017-02-01T12:15:44Z Unit test to show that recursive logging from an Appender fails (LockRecursionException thrown and swallowed by log4net core) if NET_4_0 or MONO_4_0 is defined. commit 54048581c2ce7e0c3a5a5143a66dbee8af8e6eca Author: JJoe2 <jocular...@hotmail.com> Date: 2017-02-01T12:19:54Z Fixed LOG4NET-550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #39: Added a unit test for AppSettingPatternConverter
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/39 Added a unit test for AppSettingPatternConverter Unit test for PR #35 as requested. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/AppSettings Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 9dcdfcd5253d05ef3cf9916c64be65bf756c6ed2 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-10-31T17:25:19Z Added a unit test for AppSettingPatternConverter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #38: Fixed log4net.Tests.vs2012.csproj reference to NUn...
Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #38: Fixed log4net.Tests.vs2012.csproj reference to NUn...
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/38 Fixed log4net.Tests.vs2012.csproj reference to NUnit. Previous version included ..\..\..\ibatisnet-3\External-Bin\Net\2.0\nunit.framework.dll Changed this to reference NuGet package NUnit 2.6.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/NUnitReference Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 02817b6136e4e6cf2e649e504517938855a81ea6 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-10-30T10:59:52Z Fixed log4net.Tests.vs2012.csproj reference to NUnit. Previous version included ..\..\..\ibatisnet-3\External-Bin\Net\2.0\nunit.framework.dll Changed this to reference NuGet package NUnit 2.6.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/36 Reopened - fixed breaking change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps
GitHub user JJoe2 reopened a pull request: https://github.com/apache/log4net/pull/36 Use UTC internally to avoid ambiguous timestamps Resubmitting replacement for #24 Rebased to latest trunk and fixed backwards compatibility issue of binary serialization of LoggingEvent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/UseUTC Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit c9513671c62ba22609fd7009f1ef60e0b89bffa5 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-10-30T10:13:09Z Cherry-pick UTC changes commit 5caefe51d999d4ae34bf887c323e27bfdaee7235 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-10-30T10:49:32Z Changed LoggingEvent.TimeStamp from a property back to a field to avoid breaking change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #36: Use UTC internally to avoid ambiguous timestamps
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/36 Closing for now - in its current form it's a breaking change - it changes LoggingEvent.DateTime from a field to a property. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps
Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #35: Wip/app settings
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 Iâll be happy to do the unit tests and possibly the doc. Are suitable XML comments enough? Now this is added, Iâll also be thinking about the next step, which is to allow the PatternString converter to be used in the XML configuration file for properties of types other than strings. So that I can do something like: Should be possible: basically be applying the PatternString conversion before converting to the target type of the property. From: Stefan Bodewig [mailto:notificati...@github.com] Sent: 26 October 2016 20:43 To: apache/log4net Cc: JJoe2; Author Subject: Re: [apache/log4net] Wip/app settings (#35) I've added your converter, many thanks. Tests would be good and we need documentation before we can close LOG4NET-526. â You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/apache/log4net/pull/35#issuecomment-256440366>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFY0uybBZ6IZdXI75BhcToQlNLFlHQY3ks5q359EgaJpZM4KMD7s>. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #35: Wip/app settings
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/35
Hi Stefan,
That's correct, those are the only changes.
Thanks,
From: Stefan Bodewig <notificati...@github.com>
Sent: 23 October 2016 16:33:48
To: apache/log4net
Cc: JJoe2; Author
Subject: Re: [apache/log4net] Wip/app settings (#35)
Am I correct that AppSettingPatternConverter and the few changes in
PatternString are the only relevant code changes (along with adding the new
filte to the solution files)? If so, I can pick up the file myself, no need to
rebase the PR.
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/log4net/pull/35#issuecomment-255598419>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AFY0u5TXDPotVI7EG3bo-VmOs_CBWacwks5q24xsgaJpZM4KMD7s>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Youâre right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 The .gitattributes file you committed doesnât specify line endings for most file types including .cs and .csproj (the most commonly modified ones). However I donât feel competent to say whether itâs really a good idea. Having read the section on âRefreshing the repository after changing line endingsâ, it seems that a number of arcane git incantations may be required to get everything working again after doing so. Which might cause problems for people who have forked but are struggling with git. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Thank you for your patience : Iâve learnt a lot about git this weekend which will stand me in good stead for the future (still hate it though). I subscribed to the dev list this morning, and will try to get involved, albeit on a small scale once my subscription is confirmed. Regarding line endings, I suspect that having a .gitattributes file in the repository would help: https://help.github.com/articles/dealing-with-line-endings/ Did I just volunteer for that job? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #35: Wip/app settings
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/35 I'll rebase this after #36 and #37 have been processed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Replaced by #37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #37: Implement flushing of appenders that buffer data
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/37 Implement flushing of appenders that buffer data Replaces #25 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/Flush Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit f8eb4b49e3bcc38fdc0e8a2bf36c729eb5e70ea4 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-10-15T20:22:32Z Implement flushing of appenders that buffer data --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #25: API to flush appenders that buffer logging data
Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #36: Use UTC internally to avoid ambiguous timestamps
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/36 Use UTC internally to avoid ambiguous timestamps Resubmitting replacement for #24 Rebased to latest trunk and fixed backwards compatibility issue of binary serialization of LoggingEvent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/UseUTC Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 79a68874f04807f162be7749bd8818120f606be2 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-10-15T19:11:57Z Use UTC internally to avoid ambiguous timestamps --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/25
Thanks.
I agree that I should have done a better job of keeping these changes
separate but when I did the initial work I was very much a git novice.
Iâll bite the bullet and separate these changes into two branches with a
rebase on the latest trunk.
I take your point about the binary serialization format. For now Iâll
roll back the change in the serialization / deserialization methods. Users of
RemotingAppender will therefore still be subject to ambiguous timestamps but
itâs no longer a breaking change.
We could also consider implementing serialization as follows (perhaps
enabled by a configuration setting if preserving backwards compatibility is
important):
info.AddValue("TimeStamp", m_data.TimeStampUtc);
// Serialize
m_data.TimeStampUtc = info.GetDateTime("TimeStamp").ToUniversalTime();
// Deserialize
Given that DateTime.ToUniversalTime() is a noop if the Kind property is
already set to Utc, this would give the correct result if both sides have the
new version, and the following result (ignoring .NET 1.x which didnât have a
Kind property) for mixed versions:
1. Old client and new server
Old client serializes as local time; New server converts this to UTC based
on the serverâs timezone. Result unchanged as long as client and server
timezones are the same.
2. New client and old server
New client serializes as UTC. Old server will have a UTC time in the
TimeStamp, and will probably interpret it as local time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 From your remarks I gather you arenât too concerned about line ending inconsistencies. And since I did a bit of research today, and discovered that itâs possible to ignore whitespace / line endings when reviewing differences on github by appending ?w=1 to the url, it doesnât seem so important to me. I've now merged with the latest trunk, rolled back the change to ILoggerRepository, and also added a timeout to the flush method, so that it better handles asynchronous appenders such as RemoteAppender. It still includes #24 though: is it important to separate these pull requests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Some recent commits have changed line endings from LF to CRLF: some of the ones that affect me are listed below. Would it be possible for you to fix these line endings in the trunk? This will make it easier for me to redo my work and eliminate merge conflicts. Appender/DebugAppender.cs core/LoggingEvent.cs Util/LogManager.cs Util/LogLog.cs Util/SystemInfo.cs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #24: Use UTC internally to avoid ambiguous times
Github user JJoe2 closed the pull request at: https://github.com/apache/log4net/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net issue #25: API to flush appenders that buffer logging data
Github user JJoe2 commented on the issue: https://github.com/apache/log4net/pull/25 Hi Stefan, Thanks for the feedback. As youâll have gathered Iâm a novice as far as Git and Github are concerned, though slightly less so than I was when I created this patch. Iâll take a look this weekend and try to produce something better that can be merged directly, and separate the patches for the different pull requests (UTC; Flush; â¦). I suspect the whitespace issues may be caused by different CRLF standards, though Iâm surprised the diff utility doesnât ignore such differences. IIRC Visual Studio popped up a dialog about inconsistent line endings and offered to fix it. If you have any tips on how to handle this Iâm all ears, otherwise Iâm sure Iâll work it out for myself. The LogManager.Flush() method is implemented as: LoggerManager.GetRepository(Assembly.GetCallingAssembly()).Flush(); How would you propose to implement this if the Flush method was moved out of ILoggerRepository? From: Stefan Bodewig [mailto:notificati...@github.com] Sent: 12 October 2016 22:32 To: apache/log4net Cc: JJoe2; Author Subject: Re: [apache/log4net] API to flush appenders that buffer logging data (#25) This PR seems to include #24<https://github.com/apache/log4net/pull/24> as well, could you provide a patch without it? Also, I'm not sure why Flush has been added to ILoggerRepository directly. It would be better if LoggerRepositorySkeleton implemented IFlushable IMHO. The whitespace changes are distracting, it is difficult to see the differences in lots of classes. â You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/apache/log4net/pull/25#issuecomment-253330546>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFY0u7no2CA1aE7ZfZEWE9hxc_YACHeHks5qzUPcgaJpZM4IOSN6>. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request #35: Wip/app settings
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/35 Wip/app settings Implementation for LOG4NET-526 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/AppSettings Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit a66d2fc61c4a1cfd8317aee41385ef6c43373ffc Author: JoeJoe <jocular...@hotmail.com> Date: 2016-04-22T19:21:07Z Use UTC internally to avoid ambiguous times commit 9e9f1759d6a80594cd2d12bd54a9e3af9e7cfaa0 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-04-23T19:58:36Z Implement flushing of appenders that buffer data commit 38fdfbaa7e9cd30e8a84fe90aa0ab12641b4db5f Author: JoeJoe <jocular...@hotmail.com> Date: 2016-10-02T17:12:33Z Added AppSettingPatterConverter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request: API to flush appenders that buffer logging d...
Github user JJoe2 commented on the pull request: https://github.com/apache/log4net/pull/25#issuecomment-214260923 Added two commits including a fix for https://issues.apache.org/jira/browse/LOG4NET-512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request: API to flush appenders that buffer logging d...
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/25 API to flush appenders that buffer logging data Implementation of https://issues.apache.org/jira/browse/LOG4NET-511 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net wip/Flush Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit a66d2fc61c4a1cfd8317aee41385ef6c43373ffc Author: JoeJoe <jocular...@hotmail.com> Date: 2016-04-22T19:21:07Z Use UTC internally to avoid ambiguous times commit 9e9f1759d6a80594cd2d12bd54a9e3af9e7cfaa0 Author: JoeJoe <jocular...@hotmail.com> Date: 2016-04-23T19:58:36Z Implement flushing of appenders that buffer data --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] log4net pull request: Use UTC internally to avoid ambiguous times
GitHub user JJoe2 opened a pull request: https://github.com/apache/log4net/pull/24 Use UTC internally to avoid ambiguous times Currently log4net uses local times internally and converts to UTC on output when needed (e.g. UtcDatePatternConverter). This can result in inaccurate UTC times during one hour each year when local time is ambiguous (DateTime.IsAmbiguous = true) for time zones that use daylight saving time. Also TimeEvaluator uses local time, which means it can trigger too early or too late when local time is ambiguous. This change stores current date/time as UTC internally, converting to local when required. No new unit tests added as to do so would require mocking DateTime.Now / DateTime.UtcNow, which isn't justified for such a simple change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JJoe2/log4net trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/log4net/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit a66d2fc61c4a1cfd8317aee41385ef6c43373ffc Author: JoeJoe <jocular...@hotmail.com> Date: 2016-04-22T19:21:07Z Use UTC internally to avoid ambiguous times --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
