Github user JJoe2 commented on the issue:

    https://github.com/apache/log4net/pull/25
  
    From your remarks I gather you aren’t too concerned about line ending 
inconsistencies.
    
    And since I did a bit of research today, and discovered that it’s 
possible to ignore whitespace / line endings when reviewing differences on 
github by appending ?w=1 to the url, it doesn’t seem so important to me.
    
    I've now merged with the latest trunk, rolled back the change to 
ILoggerRepository, and also added a timeout to the flush method, so that it 
better handles asynchronous appenders such as RemoteAppender.
    
    It still includes #24 though: is it important to separate these pull 
requests?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to