Github user JJoe2 commented on the issue:
Thanks for the feedback.
As youâll have gathered Iâm a novice as far as Git and Github are
concerned, though slightly less so than I was when I created this patch.
Iâll take a look this weekend and try to produce something better that
can be merged directly, and separate the patches for the different pull
requests (UTC; Flush; â¦).
I suspect the whitespace issues may be caused by different CRLF standards,
though Iâm surprised the diff utility doesnât ignore such differences.
IIRC Visual Studio popped up a dialog about inconsistent line endings and
offered to fix it. If you have any tips on how to handle this Iâm all ears,
otherwise Iâm sure Iâll work it out for myself.
The LogManager.Flush() method is implemented as:
How would you propose to implement this if the Flush method was moved out
From: Stefan Bodewig [mailto:notificati...@github.com]
Sent: 12 October 2016 22:32
Cc: JJoe2; Author
Subject: Re: [apache/log4net] API to flush appenders that buffer logging
This PR seems to include #24<https://github.com/apache/log4net/pull/24> as
well, could you provide a patch without it?
Also, I'm not sure why Flush has been added to ILoggerRepository directly.
It would be better if LoggerRepositorySkeleton implemented IFlushable IMHO.
The whitespace changes are distracting, it is difficult to see the
differences in lots of classes.
You are receiving this because you authored the thread.
Reply to this email directly, view it on
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket