[LTP] [PATCH V4 3/4] testscripts/isofs: make it quiet

2014-05-12 Thread Stanislav Kholmanskikh
All pass/fail checks are performed based on the exit value. So we may freely redirect all unused output to /dev/null. And exportfs always returns 0, so there is no point to execute it at all. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testscripts/isofs.sh |9

[LTP] [PATCH V4 2/4] testscripts/isofs.sh: use the new shell interface

2014-05-12 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testscripts/isofs.sh | 105 ++--- 1 files changed, 47 insertions(+), 58 deletions(-) diff --git a/testscripts/isofs.sh b/testscripts/isofs.sh index ec1f2fc..1335327 100755

[LTP] isofs.sh series V4

2014-05-12 Thread Stanislav Kholmanskikh
Hi! Changes since V3: * if umount $MNT_POINT fails we do tst_brkm instead of tst_resm * pass/fail checks are performed basing on exit codes Thanks. -- Accelerate Dev Cycles with Automated Cross-Browser Testing - For

Re: [LTP] isofs.sh series V4

2014-05-12 Thread Stanislav Kholmanskikh
On 05/12/2014 06:43 PM, chru...@suse.cz wrote: Hi! Changes since V3: * if umount $MNT_POINT fails we do tst_brkm instead of tst_resm * pass/fail checks are performed basing on exit codes Acked. Thank you, pushed.

[LTP] [PATCH 1/2] sendmsg, recvmsg: moved MSG_CMSG_COMPAT definition to a header

2014-05-13 Thread Stanislav Kholmanskikh
sendmsg01.c and recvmsg01.c both define MSG_CMSG_COMPAT in a similar way. Moved this definition to a new header file to reduce code duplication. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel/syscalls/recvmsg/Makefile|2 + testcases/kernel

[LTP] [PATCH 2/2] msg_common.h: corrected __sparc64__ definition

2014-05-13 Thread Stanislav Kholmanskikh
__sparc64__ is not defined by cpp. We should use '__sparc__' and '__arch64__' instead. Author: Jose E. Marchesi jose.march...@oracle.com Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel/syscalls/utils/msg_common.h |3 ++- 1 files changed, 2

Re: [LTP] [PATCH 4/4] rt_sigaction*, rt_sigprocmask01, rt_sigsuspend01: SPARC support

2014-05-13 Thread Stanislav Kholmanskikh
On 05/12/2014 05:08 PM, chru...@suse.cz wrote: Hi! Hi! Thank you for review. Added SPARC support for tests: * rt_sigaction01, rt_sigaction02, rt_sigaction03 * rt_sigprocmask01 * rt_sigsuspend01 Author: Jose E. Marchesi jose.march...@oracle.com Co-author: Stanislav Kholmanskikh

Re: [LTP] [PATCH 1/2] syscalls/fstatfs: Cleanup

2014-05-15 Thread Stanislav Kholmanskikh
On 05/15/2014 04:51 PM, chru...@suse.cz wrote: Hi! From: Shuang Qiu shuang@oracle.com * Delete some useless comments * Make variables and functions static Signed-off-by: Shuang Qiu shuang@oracle.com Reviewed-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com Acked

[LTP] [RFC PATCH] A draft of the rt_sigaction syscall wrapper.

2014-05-20 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Hi! I think that instead of an addition of the common syscall preparation to a define, it would be better to implement a wrapper to the rt_sigaction syscall. Like this one. Its basis is a combination of glibc

[LTP] [PATCH 3/3] ltp_rt_sigaction: added SPARC support

2014-05-21 Thread Stanislav Kholmanskikh
Based on patches by Jose E. Marchesi jose.march...@oracle.com. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- include/ltp_signal.h | 59 ++ 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/include

[LTP] [PATCH 1/3] rt_sigaction, rt_sigprocmask, rt_sigsuspend: cleanup

2014-05-21 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- .../kernel/syscalls/rt_sigaction/rt_sigaction01.c | 88 +++--- .../kernel/syscalls/rt_sigaction/rt_sigaction02.c | 85 +++--- .../kernel/syscalls/rt_sigaction/rt_sigaction03.c | 105

[LTP] [PATCH 2/3] rt_sigaction, rt_sigprocmask01, rt_sigsuspend: use rt_sigaction wrapper

2014-05-21 Thread Stanislav Kholmanskikh
is not specific only for x86_64. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- ltp_rt_sigaction is tightly couples with stuff in ltp_signal.h, therefore I put it there. include/ltp_signal.h | 70 ++-- .../kernel/syscalls

Re: [LTP] [PATCH 3/3] ltp_rt_sigaction: added SPARC support

2014-05-21 Thread Stanislav Kholmanskikh
On 05/21/2014 02:24 PM, Stanislav Kholmanskikh wrote: Based on patches by Jose E. Marchesi jose.march...@oracle.com. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com Sorry, I forgot to mention why we are doing this in the commit message. If the patches are ok, I'll

Re: [LTP] [PATCH V3 1/4] testscripts/isofs.sh: cleanup

2014-06-16 Thread Stanislav Kholmanskikh
Hi! On 06/16/2014 10:22 AM, Mike Frysinger wrote: On Thu 27 Mar 2014 18:22:52 Stanislav Kholmanskikh wrote: +MNT_POINT=/tmp/isofs_$$ +COPY_DIR=/etc/ +TEMP_DIR=/tmp/for_isofs_test +MAKE_FILE_SYS_DIR=$TEMP_DIR$COPY_DIR not really a new issue, but scripts really should never hardcode paths

Re: [LTP] [PATCH V3 3/4] testscripts/isofs.sh: removed some unnecessary steps

2014-06-16 Thread Stanislav Kholmanskikh
On 06/16/2014 10:23 AM, Mike Frysinger wrote: On Thu 27 Mar 2014 18:22:54 Stanislav Kholmanskikh wrote: +while /bin/true; do do not hard code paths to tools. if you want a dummy loop, do: while :; do ... -mike Thank you. I think I would change

[LTP] [PATCH V2 3/3] ltp_rt_sigaction.h: added SPARC support

2014-06-17 Thread Stanislav Kholmanskikh
. Marchesi jose.march...@oracle.com. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V1: * Added indentions to ifdefs * Added a more detailed description message include/lapi/rt_sigaction.h | 59 +++ 1 files

[LTP] [PATCH V2 1/3] rt_sigaction, rt_sigprocmask, rt_sigsuspend: cleanup

2014-06-17 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- No changes since V1. .../kernel/syscalls/rt_sigaction/rt_sigaction01.c | 88 +++--- .../kernel/syscalls/rt_sigaction/rt_sigaction02.c | 85 +++--- .../kernel/syscalls/rt_sigaction/rt_sigaction03.c

[LTP] [PATCH V2 2/3] rt_sigaction, rt_sigprocmask01, rt_sigsuspend: use rt_sigaction wrapper

2014-06-17 Thread Stanislav Kholmanskikh
it into 'include/lapi/rt_sigaction.h' * modified the above test cases to use this wrapper Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V1: * Splitted include/ltp_signal.h into two headers include/lapi/rt_sigaction.h| 154

[LTP] [PATCH V3] syscalls: implemented a test for sched_setaffinity() error values

2014-06-17 Thread Stanislav Kholmanskikh
This test verifies sched_setaffinity(2) for all error conditions to occur correctly. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Thank you, Cyril, for review. This patch accomodates changes mentioned by you: * the privileged_pid child uses pause() instead

Re: [LTP] [PATCH V3] syscalls: implemented a test for sched_setaffinity() error values

2014-06-18 Thread Stanislav Kholmanskikh
On 17.06.2014 19:00, chru...@suse.cz wrote: Hi! Hi! This test verifies sched_setaffinity(2) for all error conditions to occur correctly. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Thank you, Cyril, for review. This patch accomodates changes mentioned

Re: [LTP] [PATCH 2/2] msg_common.h: corrected __sparc64__ definition

2014-06-25 Thread Stanislav Kholmanskikh
On 05/15/2014 04:30 PM, chru...@suse.cz wrote: Hi! __sparc64__ is not defined by cpp. We should use '__sparc__' and '__arch64__' instead. Author: Jose E. Marchesi jose.march...@oracle.com Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel

Re: [LTP] [PATCH V2 3/3] ltp_rt_sigaction.h: added SPARC support

2014-06-25 Thread Stanislav Kholmanskikh
On 06/23/2014 07:21 PM, chru...@suse.cz wrote: Hi! Whole patchset looks good to me, acked. Thank you. Pushed. -- Open source business process management suite built on Java and Eclipse Turn processes into business

[LTP] [RFC PATCH] tst_get_unused_pid and system_specific_process_info

2014-06-25 Thread Stanislav Kholmanskikh
coupled with tst_get_free_pids(). I'm going to present pp. 1-3 in one patch, and p. 4 - in a separate patch. What do you think about the general idea? Thanks. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- include/system_specific_process_info.h | 29

Re: [LTP] [RFC PATCH] tst_get_unused_pid and system_specific_process_info

2014-06-25 Thread Stanislav Kholmanskikh
On 06/25/2014 04:14 PM, chru...@suse.cz wrote: Hi! 1. We remove get_max_pids(), because it's used only in one place (get_free_pids()) and can be subsituted with SAFE_FILE_SCANF(cleanup_fn, PID_MAX_PATH, %d, pid); 2. We rename get_free_pids() to tst_get_free_pids() for

[LTP] [PATCH 2/3] Implementation of tst_get_unused_pid()

2014-06-30 Thread Stanislav Kholmanskikh
); Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- include/test.h |8 ++-- lib/tst_pid.c | 46 ++- testcases/kernel/syscalls/ipc/msgctl/msgctl11.c |2 +- 3 files changed, 17

[LTP] tst_get_unused_pid()

2014-06-30 Thread Stanislav Kholmanskikh
Hi! This series introduces tst_get_unused_pid() and makes the testcases use it. Thanks. -- Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita

[LTP] [PATCH 3/3] syscalls: use tst_get_unused_pid()

2014-06-30 Thread Stanislav Kholmanskikh
Modified the testcases to use the tst_get_unused_pid() interface. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel/syscalls/capget/capget02.c|4 +- testcases/kernel/syscalls/cma/process_vm01.c | 11 + .../syscalls

[LTP] [PATCH 1/3] system_specific_process_info changes

2014-06-30 Thread Stanislav Kholmanskikh
For consistency: * removed the content of system_specific_process_info.h to test.h and renamed its functions to start with 'tst_' * renamed system_specific_process_info.c to tst_pid.c Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- include

Re: [LTP] [PATCH 3/3] syscalls: use tst_get_unused_pid()

2014-07-02 Thread Stanislav Kholmanskikh
On 07/01/2014 05:11 PM, chru...@suse.cz wrote: Hi! Hi! The rest of the patchset looks good to me, acked (with these two issues above fixed). Thank you. Pushed with the issues fixed. -- Open source business

[LTP] [PATCH V4] syscalls: implemented a test for sched_setaffinity() error values

2014-07-02 Thread Stanislav Kholmanskikh
This test verifies sched_setaffinity(2) for all error conditions to occur correctly. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V3: * use tst_fork() instead of fork() for privileged_pid * use tst_get_unused_pid() for free_pid runtest/syscalls

[LTP] [PATCH] test-writing-guidelines.txt: added info about tst_get_unused_pid()

2014-07-03 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- doc/test-writing-guidelines.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt index af31d38..ea88126 100644

Re: [LTP] [PATCH V4] syscalls: implemented a test for sched_setaffinity() error values

2014-07-14 Thread Stanislav Kholmanskikh
Hi! On 07/02/2014 11:30 AM, Stanislav Kholmanskikh wrote: This test verifies sched_setaffinity(2) for all error conditions to occur correctly. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V3: * use tst_fork() instead of fork

Re: [LTP] [PATCH V4] syscalls: implemented a test for sched_setaffinity() error values

2014-07-15 Thread Stanislav Kholmanskikh
On 07/14/2014 05:07 PM, Jan Stancek wrote: - Original Message - From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com To: ltp-list@lists.sourceforge.net Cc: vasily isaenko vasily.isae...@oracle.com Sent: Wednesday, 2 July, 2014 9:30:58 AM Subject: [LTP] [PATCH V4

Re: [LTP] Segmentation fault when running sched_setaffinity01 in RHEL5.10GA

2014-07-25 Thread Stanislav Kholmanskikh
On 07/25/2014 11:32 AM, Xiaoguang Wang wrote: Hi, On 07/25/2014 02:39 PM, Stanislav Kholmanskikh wrote: On 07/25/2014 09:38 AM, Xiaoguang Wang wrote: Hi, When we run sched_setaffinity01 in RHEL5.10GA, it occurs a segmentation fault. Below is the possible reason. Hi! I though I'd

Re: [LTP] More observations on HEAD

2014-07-25 Thread Stanislav Kholmanskikh
On 07/19/2014 01:35 AM, Joseph Beckenbach wrote: Hi, all! Hi! Feel free to ignore this -- it's an experience report of a cluster of runs I've just done against 3.12.24 kernels. The default test set runs move_pages* twice. setfsuid04_16 and setregid{02,04,05,07}_16 TFAIL rather than

Re: [LTP] [PATCH] sched_setaffinity01: use ltp_syscall

2014-07-25 Thread Stanislav Kholmanskikh
] != '\0') -- CRASH HERE Call this syscall directly with ltp_syscall(). Reported-by: Xiaoguang Wang wangxg.f...@cn.fujitsu.com Signed-off-by: Jan Stancek jstan...@redhat.com Acked-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- .../sched_setaffinity/sched_setaffinity01.c

Re: [LTP] More observations on HEAD

2014-07-25 Thread Stanislav Kholmanskikh
On 07/25/2014 12:03 PM, Stanislav Kholmanskikh wrote: On 07/19/2014 01:35 AM, Joseph Beckenbach wrote: Hi, all! Hi! Feel free to ignore this -- it's an experience report of a cluster of runs I've just done against 3.12.24 kernels. The default test set runs move_pages* twice

Re: [LTP] More observations on HEAD

2014-07-30 Thread Stanislav Kholmanskikh
On 07/29/2014 02:11 PM, chru...@suse.cz wrote: Hi! Sorry, I overlooked that thread [PATCH v2 1/2] lib/tst_res.c: introduce tst_record_childstatus() already addresses these issues. And it took longer than it should because it require changes in the test library. I've just commited a fix,

Re: [LTP] [PATCH] diotest4/fcntl16: Skip some dio/fcntl cases on NFS

2014-08-11 Thread Stanislav Kholmanskikh
Hi! On 08/11/2014 10:57 AM, Xiong Zhou wrote: According to description of NFS and directIO in open(2), especially The Linux NFS client places no alignment restrictions on O_DIRECT I/O, ignore some FAILs in diotest4. According to nfs(5), NLM supports advisory file locks only. So skip fcntl16

Re: [LTP] [PATCH V2 3/3] ltp_rt_sigaction.h: added SPARC support

2014-08-12 Thread Stanislav Kholmanskikh
On 08/11/2014 07:04 PM, chru...@suse.cz wrote: Hi! Hi! I've started to prepare for release and tried to build LTP on as much arch/distro combination I could, for ia64 the rt_sigaction fails with: In file included from rt_sigaction01.c:42: [ 349s]

[LTP] [PATCH] rt_sigaction.h: define HAVE_SA_RESTORER for most platforms

2014-08-12 Thread Stanislav Kholmanskikh
On some platforms LTP fails to compile, because (struct sigaction) doesn't have .sa_restorer member. For example - ia64. To overcome such failures we employ HAVE_SA_RESTORER define. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Verified on SPARC, x86_64, i386

Re: [LTP] [PATCH] rt_sigaction.h: define HAVE_SA_RESTORER for most platforms

2014-08-12 Thread Stanislav Kholmanskikh
On 08/12/2014 04:24 PM, chru...@suse.cz wrote: Hi! On some platforms LTP fails to compile, because (struct sigaction) doesn't have .sa_restorer member. For example - ia64. To overcome such failures we employ HAVE_SA_RESTORER define. Signed-off-by: Stanislav Kholmanskikh

[LTP] [PATCH] sparc64 syscall definitions' fixes

2014-08-14 Thread Stanislav Kholmanskikh
1. Changed '__sparc64__' to 'defined(__sparc__) defined(__arch64__)' 2. Removed non-implemented syscall numbers from sparc64.in (in accordance to linux-stable/arch/sparc/include/uapi/asm/unistd.h) 2. Re-executed regen.sh Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com

Re: [LTP] [PATCH] sparc64 syscall definitions' fixes

2014-08-14 Thread Stanislav Kholmanskikh
On 08/14/2014 03:50 PM, Jan Stancek wrote: - Original Message - From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com To: ltp-list@lists.sourceforge.net Cc: vasily isaenko vasily.isae...@oracle.com Sent: Thursday, 14 August, 2014 10:30:51 AM Subject: [LTP] [PATCH

Re: [LTP] [PATCH v2] Skip some dio/fcntl cases on NFS

2014-08-20 Thread Stanislav Kholmanskikh
Hi! Sorry for delay. On 08/12/2014 08:37 AM, Xiong Zhou wrote: According to description of NFS and directIO in open(2), especially The Linux NFS client places no alignment restrictions on O_DIRECT I/O, ignore odd count/non-aligned read-write FAILs in diotest4. Some dup code clean up btw. I

[LTP] [RFC/PATCH] ltpstress.sh: added cmdline to set the block device

2014-08-21 Thread Stanislav Kholmanskikh
I think it's not needed to use set_block_device(), create_block_device() from runltp, because their logic is in tst_acquire_device()/tst_release_device() now. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testscripts/ltpstress.sh | 13 +++-- 1 files

Re: [LTP] [PATCH v3 2/3] diotest4: Some code cleanup in diotest4.c

2014-08-21 Thread Stanislav Kholmanskikh
On 08/21/2014 08:14 AM, Xiong Zhou wrote: Split dup code cleanup and function change from v2. I suppose this message is directed to the LTP mailing list subscribers and should not be in `git log` after the patch is applied. Therefore put such messages after '---'. One small comment below.

Re: [LTP] [PATCH v3 3/3] diotest4: Skip some diotest4 cases on NFS

2014-08-21 Thread Stanislav Kholmanskikh
On 08/21/2014 08:17 AM, Xiong Zhou wrote: According to description of NFS and directIO in open(2), especially The Linux NFS client places no alignment restrictions on O_DIRECT I/O, ignore odd count/non-aligned read-write FAILs in diotest4. Signed-off-by: Xiong Zhou xz...@redhat.com ---

Re: [LTP] [PATCH v3 1/3] fcntl16: Skip fcntl16 tests on NFS

2014-08-21 Thread Stanislav Kholmanskikh
Hi! On 08/21/2014 08:12 AM, Xiong Zhou wrote: According to nfs(5), NLM supports advisory file locks only. So skip fcntl16 test if NFS. I've just took a fresh look at fcntl16.c and found that block1 of this test case may be executed on NFS. And, IMHO, this block1 test case is not 100%

Re: [LTP] [PATCH] mmap15: don't fail if mmap returns EINVAL

2014-08-22 Thread Stanislav Kholmanskikh
that both ENOMEM and EINVAL should be considered. Signed-off-by: Jan Stancek jstan...@redhat.com Acked-by: Wanlong Gao gaowanl...@cn.fujitsu.com Modern sparc64 kernels return EINVAL as well. Acked-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel

Re: [LTP] [PATCH v4 3/3] fcntl16: Skip fcntl16 test block2 and block3 on NFS

2014-09-08 Thread Stanislav Kholmanskikh
Hi. Could anybody look at the series? If there are no objections, I'm going to push it tomorrow. Thanks. On 08/25/2014 12:26 PM, Stanislav Kholmanskikh wrote: On 08/22/2014 11:05 AM, Xiong Zhou wrote: According to nfs(5), NLM supports advisory file locks only. So skip fcntl16 test block2

Re: [LTP] [PATCH v4 3/3] fcntl16: Skip fcntl16 test block2 and block3 on NFS

2014-09-09 Thread Stanislav Kholmanskikh
On 09/08/2014 01:12 PM, Stanislav Kholmanskikh wrote: Hi. Could anybody look at the series? If there are no objections, I'm going to push it tomorrow. Pushed. Thanks. On 08/25/2014 12:26 PM, Stanislav Kholmanskikh wrote: On 08/22/2014 11:05 AM, Xiong Zhou wrote: According to nfs

Re: [LTP] [PATCH 1/3] fcntl14: dup code clean up

2014-09-11 Thread Stanislav Kholmanskikh
Hi! On 09/11/2014 02:30 PM, Xiong Zhou wrote: And block3 description message fix from mandatory locking to negative whence. Signed-off-by: Xiong Zhou xz...@redhat.com --- testcases/kernel/syscalls/fcntl/fcntl14.c | 36 +++ 1 file changed, 13 insertions(+),

Re: [LTP] [PATCH 2/3] fcntl14: only skip test block2 on NFS

2014-09-11 Thread Stanislav Kholmanskikh
xz...@redhat.com Reviewed-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com you changed the same skipping logic as: tst_resm(TINFO, Entering block bla) if (NO_NFS) { do_the_tests(); } else { tst_resm(TCONF, NFS does not support mandatory locking); } tst_resm(TINFO

Re: [LTP] [RFC/PATCH] ltpstress.sh: added cmdline to set the block device

2014-09-15 Thread Stanislav Kholmanskikh
Hi! Could anybody help to review this change, please? Thanks. On 21.08.2014 12:44, Stanislav Kholmanskikh wrote: I think it's not needed to use set_block_device(), create_block_device() from runltp, because their logic is in tst_acquire_device()/tst_release_device() now. Signed-off

Re: [LTP] [RFC/PATCH] ltpstress.sh: added cmdline to set the block device

2014-09-22 Thread Stanislav Kholmanskikh
On 09/19/2014 05:20 PM, chru...@suse.cz wrote: Hi! Could anybody help to review this change, please? Sorry, I've read the email but forgot to reply the last time. Looks good, acked. Thank you. Pushed. -- Meet PCI

Re: [LTP] [PATCH v2 3/3] splice01/tee01/utime: test back on NFS

2014-09-23 Thread Stanislav Kholmanskikh
Hi! On 09/19/2014 10:49 AM, Xiong Zhou wrote: Tests splice01 tee01 and utime01/02/03 pass on NFS since 2.6.32 at least. Could you add a kernel version check to the patch, please? I'm sure there are distributions which still use older kernels. For example, with 2.6.18-371.3.1.0.1.el5 and:

Re: [LTP] [PATCH 1/3] fcntl14: dup code clean up

2014-09-23 Thread Stanislav Kholmanskikh
Hi! On 09/19/2014 10:46 AM, Xiong Zhou wrote: - Original Message - From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com To: Xiong Zhou xz...@redhat.com, ltp-list@lists.sourceforge.net Sent: Thursday, September 11, 2014 10:04:32 PM Subject: Re: [LTP] [PATCH 1/3] fcntl14

Re: [LTP] [PATCH v3 1/3] fcntl14: dup code clean up

2014-09-25 Thread Stanislav Kholmanskikh
Hi! On 09/25/2014 11:17 AM, Xiong Zhou wrote: And block3 description message fix from mandatory locking to negative whence. Signed-off-by: Xiong Zhou xz...@redhat.com --- Patch 1 and patch 2 of the series are pushed. Btw, patch 2 didn't apply to index correctly with 'git am', I had to

Re: [LTP] [PATCH v3 1/3] fcntl14: dup code clean up

2014-09-26 Thread Stanislav Kholmanskikh
Hi! On 09/26/2014 07:23 AM, Xiong Zhou wrote: - Original Message - From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com To: Xiong Zhou xz...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Thursday, September 25, 2014 8:07:26 PM Subject: Re: [LTP] [PATCH v3 1/3

Re: [LTP] [PATCH v3 1/3] fcntl14: dup code clean up

2014-09-29 Thread Stanislav Kholmanskikh
Hi! Patch 3 was pushed. Thank you. On 09/28/2014 06:53 AM, Xiong Zhou wrote: Hi! - Original Message - From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com To: Xiong Zhou xz...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Friday, September 26, 2014 8:36:00 PM

[LTP] [PATCH] acl_test01: sync after removal of the loop device

2014-10-22 Thread Stanislav Kholmanskikh
loop device destruction lazy To cope with this test case failure I introduced a 'sync'. And 'losetup -d' seems to be unnecessary, because of 'umount -d' before it Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel/fs/acls/acl_test01 |2 +- 1 files

Re: [LTP] chown and 16 bit syscall testing

2014-11-10 Thread Stanislav Kholmanskikh
Hi! On 10/31/2014 04:39 PM, Han Pingtian wrote: Hey there, I found that looks like all chown test cases will be compiled to 16 bit compat test case, but they just call chown() something like TEST(chown(fname, uid, gid)); which won't test if there is a 16 bit chown() syscall. I think

Re: [LTP] chown and 16 bit syscall testing

2014-11-19 Thread Stanislav Kholmanskikh
On 11/13/2014 10:57 AM, Han Pingtian wrote: On Mon, Nov 10, 2014 at 12:07:20PM +0300, Stanislav Kholmanskikh wrote: Hi! On 10/31/2014 04:39 PM, Han Pingtian wrote: Hey there, I found that looks like all chown test cases will be compiled to 16 bit compat test case, but they just call

Re: [LTP] [PATCH] fix some syscall tests for 16-bit compat testing

2014-11-24 Thread Stanislav Kholmanskikh
at 11:15:54AM +0300, Stanislav Kholmanskikh wrote: Looks like those cases need to be fixed for the 16-bit compat, right? chown0[1-5] fchown0[1-5] lchown03 setresgid0[1-4] setresuid0[1-3,5] Looks so. Sorry for the late response. I have composed a patch, please take a look. Thanks From

Re: [LTP] [PATCH v2] fix some syscall tests for 16-bit compat testing

2014-11-28 Thread Stanislav Kholmanskikh
On 11/28/2014 11:33 AM, Han Pingtian wrote: On Mon, Nov 24, 2014 at 05:53:32PM +0300, Stanislav Kholmanskikh wrote: Hi. In general, it looks good. I have only one comment, that it's possible that the uid/gid values we pass to the syscall may not fit into UID_T/GID_T. For example, when we

Re: [LTP] [PATCH V2] library: add tst_system for wrapper system(3) without SIGCHLD

2014-12-16 Thread Stanislav Kholmanskikh
Hi, George. I've just found that I'm also motivated to have this bug fixed :) Are you planning to send an updated version including Jan's comments? Thanks. PS: I also tested it with access06 test case: without the patch: [root@kholmanskikh access]# LTP_DEV_FS_TYPE=btrfs ./access06 access06

[LTP] [PATCH 1/3] ltp_tbio.c: fix a possible kernel panic

2014-12-19 Thread Stanislav Kholmanskikh
(). Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- .../device-drivers/tbio/tbio_kernel/ltp_tbio.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/testcases/kernel/device-drivers/tbio/tbio_kernel/ltp_tbio.c b/testcases/kernel/device-drivers

[LTP] [PATCH 3/3] tbio: fix cmd_len handling

2014-12-19 Thread Stanislav Kholmanskikh
string, and inter-cmd_len containing the exact number of bytes to store this string. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- .../device-drivers/tbio/tbio_kernel/ltp_tbio.c | 11 --- .../kernel/device-drivers/tbio/tbio_kernel/tbio.h |2

[LTP] tbio fixes

2014-12-19 Thread Stanislav Kholmanskikh
In some of our environments (x86, x86_64, sparc64) tbio fails, and this series fixes the failures. I tried to introduce minimal changes, because, to be honest, I'm not 100% sure that I understand the block layer very well. So I would be more than happy, if anybody will have a chance to

[LTP] [PATCH 2/3] tbio: fixes

2014-12-19 Thread Stanislav Kholmanskikh
* Introduce a sleep() to wait until udev creates /dev/tbio * Fix typos * Clean /dev/tbio after test execution, if /dev/tbio was created manually. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- .../kernel/device-drivers/tbio/tbio_user/tbio.c| 20

Re: [LTP] [PATCH V2] doc: document tst_run_cmd

2015-02-04 Thread Stanislav Kholmanskikh
On 02/03/2015 07:12 PM, Cyril Hrubis wrote: Hi! Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V1: * Applied all comments from V1 * Added one more const to cmd[] in Example Acked. Thank you for review. tst_run_cmd, tst_run_cmd doc

Re: [LTP] [PATCH] doc: document tst_run_cmd

2015-02-03 Thread Stanislav Kholmanskikh
On 02/03/2015 05:35 PM, Cyril Hrubis wrote: Hi! +2.2.20 Executing a file +^^^ Maybe Running executables would be a bit better, as it is the title looks strange to me. I stole it from 'man 3 execvp' :) No problem:) +[source,c]

[LTP] [PATCH] doc: document tst_run_cmd

2015-02-02 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Sorry for late response. doc/test-writing-guidelines.txt | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing

[LTP] [PATCH V2 2/2] tst_module: introduce a timeout to unload modules

2015-02-02 Thread Stanislav Kholmanskikh
It may happen, that the first execution of 'rmmod module_name' may fail for some reason (like the module is in use for some short time). Changed tst_module_unload() to execute 'rmmod module_name' multiple times with the total number limited by a timeout. Signed-off-by: Stanislav Kholmanskikh

Re: [LTP] [PATCH 2/2] tst_module: introduce a timeout to unload modules

2015-02-02 Thread Stanislav Kholmanskikh
On 01/26/2015 04:11 PM, Cyril Hrubis wrote: @@ -100,6 +153,21 @@ void tst_module_load(void (cleanup_fn)(void), void tst_module_unload(void (cleanup_fn)(void), const char *mod_name) { +int i; +int loaded; + const char *const argv[] = { rmmod, mod_name, NULL }; -

[LTP] [PATCH V2] doc: document tst_run_cmd

2015-02-03 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V1: * Applied all comments from V1 * Added one more const to cmd[] in Example doc/test-writing-guidelines.txt | 40 +++ 1 files changed, 40 insertions(+), 0

[LTP] [RFC PATCH] Asynchronous module unloading and tst_run_cmd

2015-01-16 Thread Stanislav Kholmanskikh
. Thanks! Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- include/test.h |8 ++- include/tst_module.h | 11 lib/tst_mkfs.c |2 +- lib/tst_module.c

Re: [LTP] [RFC PATCH] Asynchronous module unloading and tst_run_cmd

2015-01-20 Thread Stanislav Kholmanskikh
Hi, and thank you for review. On 01/19/2015 05:52 PM, Cyril Hrubis wrote: Hi! There is one more issue with tbio. :( Sometimes it may fail with: ltp_tbio0 TINFO : Device opened successfully ltp_tbio1 TPASS : success on LTP_TBIO_ALLOC test ltp_tbio2 TPASS : success on

[LTP] [PATCH V3 2/2] tbio: fixes

2015-01-15 Thread Stanislav Kholmanskikh
* Wait until udev creates /dev/tbio. If udev can not create the node file in a defined timeout, create it manually. * Clean /dev/tbio after test execution, if /dev/tbio was created manually. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V2: * Check

Re: [LTP] [PATCH] doc: fix spelling mistakes in manuals

2015-02-16 Thread Stanislav Kholmanskikh
Hi! On 02/16/2015 12:22 PM, Wei,Jiangang wrote: These mistakes cann't lead to trouble for reading, but the correct spelling is more better for beginners to understand it. Signed-off-by: Wei,Jiangang weijg.f...@cn.fujitsu.com Thank you, pushed.

Re: [LTP] prototyping new library synchronization

2015-02-16 Thread Stanislav Kholmanskikh
Hi! On 02/12/2015 07:59 PM, Cyril Hrubis wrote: Hi! Code prototype follows. It uses mutexes and can be used with up to page_size/sizeof(uint32) pairs. I've checked that it compiles fine and works back to kernel 2.6.11 compiled in year 2005, which should be more than enough. It uses a

[LTP] [PATCH 2/2] tst_module: introduce a timeout to unload modules

2015-01-26 Thread Stanislav Kholmanskikh
It may happen, that the first execution of 'rmmod module_name' may fail for some reason (like the module is in use for some short time). Changed tst_module_unload() to execute 'rmmod module_name' multiple times with the total number limited by a timeout. Signed-off-by: Stanislav Kholmanskikh

[LTP] [PATCH 1/2] tst_run_cmd: add an option to pass the program exit code

2015-01-26 Thread Stanislav Kholmanskikh
Added an option to pass the program exit code to the caller. This may be needed if we want to run a program with tst_run_cmd(), but handle failures manually (i.e. not call cleanup). Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- include/test.h

Re: [LTP] [PATCH 2/3] tbio: fixes

2015-01-13 Thread Stanislav Kholmanskikh
Hi! On 01/06/2015 01:18 PM, Cyril Hrubis wrote: Hi! +/* + * Wait until udev creates the device node. + * If the node is not created, we will create it manually, + * see below. + */ +sleep(5); As usually I do not like adding long sleep() into testcases. What is the

[LTP] [PATCH V2 2/2] tbio: fixes

2015-01-13 Thread Stanislav Kholmanskikh
* Wait until udev creates /dev/tbio. If udev can not create the node file in a defined timeout, create it manually. * Clean /dev/tbio after test execution, if /dev/tbio was created manually. Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- Changes since V1

Re: [LTP] LTP release

2015-04-14 Thread Stanislav Kholmanskikh
On 04/14/2015 12:19 PM, Cyril Hrubis wrote: Hi! We have several issues in our sparc64 environment. Need a day or two to figure out whether they are test case issues or problems with our environment. Ok. Finally, there are only two test case issues: * cpuhotplug04 fails if there is

Re: [LTP] [PATCH v2] containers: semctl replaced with semop in sysvipc/sem_comm.c

2015-04-21 Thread Stanislav Kholmanskikh
Hi. On 04/20/2015 01:28 PM, Matus Marhefka wrote: Hi, please consider pushing this reviewed patch. Thanks, Matus Marhefka - Original Message - From: Jan Stancek jstan...@redhat.com To: Matus Marhefka mmarh...@redhat.com Cc: ltp-list@lists.sourceforge.net Sent: Thursday,

Re: [LTP] [PATCH 0/4 v2] (merged) cpuhotplug fixes

2015-04-29 Thread Stanislav Kholmanskikh
;) Regards, Jan Jan Stancek (1): cpu_hotplug: use hotplug/present cpus functions Stanislav Kholmanskikh (3): cpuhotplug: use cpu states in cleanup cpu_hotplug: add get_hotplug_cpus, get_present_cpus cpuhotplug04.sh: operate only with hotpluggable CPUs .../hotplug/cpu_hotplug

Re: [LTP] [PATCH 2/4] cpu_hotplug: add get_hotplug_cpus, get_present_cpus

2015-04-29 Thread Stanislav Kholmanskikh
On 04/29/2015 02:17 PM, Jan Stancek wrote: From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com Signed-off-by: Jan Stancek jstan...@redhat.com --- .../cpu_hotplug/include/cpuhotplug_hotplug.sh | 73

Re: [LTP] [PATCH 3/4] cpu_hotplug: use hotplug/present cpus functions

2015-04-29 Thread Stanislav Kholmanskikh
On 04/29/2015 02:18 PM, Jan Stancek wrote: Signed-off-by: Jan Stancek jstan...@redhat.com --- testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug01.sh | 6 +++--- testcases/kernel/hotplug/cpu_hotplug/functional/cpuhotplug02.sh | 2 +-

Re: [LTP] [PATCH 0/4 v3] (merged) cpuhotplug fixes

2015-04-30 Thread Stanislav Kholmanskikh
in get_present_cpus + no special treatment for cpu0 in cpuhotplug03 + fix cpuhotplug03 to spawn (number of present cpus)*2 processes + this time whole series has correct version in subject Reviewed-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com Plus tested the series in a 4 vCPU VirtualBox

Re: [LTP] [PATCH 3/4] cpu_hotplug: use hotplug/present cpus functions

2015-04-29 Thread Stanislav Kholmanskikh
On 04/29/2015 05:41 PM, Jan Stancek wrote: - Original Message - From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com To: Jan Stancek jstan...@redhat.com, ltp-list@lists.sourceforge.net Sent: Wednesday, 29 April, 2015 3:09:06 PM Subject: Re: [PATCH 3/4] cpu_hotplug: use

Re: [LTP] [PATCH] max_map_count: tst_fork() instead of fork()

2015-04-15 Thread Stanislav Kholmanskikh
On 04/15/2015 04:13 PM, Jan Stancek wrote: - Original Message - From: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com To: ltp-list@lists.sourceforge.net Cc: vasily isaenko vasily.isae...@oracle.com Sent: Wednesday, 15 April, 2015 11:27:09 AM Subject: [LTP] [PATCH

[LTP] [PATCH 1/2] Keep the definition of union semun in one place

2015-04-13 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- include/lapi/semun.h | 35 .../kernel/ipc/ipc_stress/semaphore_test_01.c | 13 +--- .../kernel/ipc/ipc_stress/semaphore_test_02.c |7

[LTP] [PATCH 2/2] sem_comm: pass a semun union to semctl()

2015-04-13 Thread Stanislav Kholmanskikh
It's required by the semctl() API plus without that the test case may fail on 64-bit Big Endian systems (like sparc64). Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- testcases/kernel/containers/sysvipc/sem_comm.c |9 +++-- 1 files changed, 7 insertions(+), 2

Re: [LTP] LTP release

2015-04-13 Thread Stanislav Kholmanskikh
On 04/07/2015 06:27 PM, Cyril Hrubis wrote: Hi! It's about the time we start to prepare for next release. I will (hopefully) start runing latest git code and look for unexpected failures during this week. Everybody please try to run the latest git code and report any problems. I've seen

Re: [LTP] LTP release

2015-04-07 Thread Stanislav Kholmanskikh
On 04/02/2015 01:09 PM, Cyril Hrubis wrote: Hi! It's about the time we start to prepare for next release. I will (hopefully) start runing latest git code and look for unexpected failures during this week. Everybody please try to run the latest git code and report any problems. I've seen

[LTP] [PATCH 1/3] cpuhotplug: use cpu states in cleanup

2015-04-08 Thread Stanislav Kholmanskikh
-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- .../hotplug/cpu_hotplug/functional/cpuhotplug01.sh | 11 --- .../hotplug/cpu_hotplug/functional/cpuhotplug03.sh | 12 +--- .../hotplug/cpu_hotplug/functional/cpuhotplug04.sh | 18 +- .../cpu_hotplug/include

[LTP] [PATCH 2/3] cpu_hotplug: added get_hotplug_cpus, get_hotplug_cpus_num

2015-04-08 Thread Stanislav Kholmanskikh
Signed-off-by: Stanislav Kholmanskikh stanislav.kholmansk...@oracle.com --- .../cpu_hotplug/include/cpuhotplug_hotplug.sh | 22 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/testcases/kernel/hotplug/cpu_hotplug/include/cpuhotplug_hotplug.sh b

<    1   2   3   4   5   >