Re: [LyX/master] Change "Format" into "Formats"

2016-08-28 Thread Guillaume Munch
Le 29/08/2016 à 00:04, Kornel Benko a écrit : Am Monday 29 August 2016 um 00:23:46, schrieb Guillaume Munch <g...@lyx.org> commit 0779b3c36cb693bdb85aea7a155f4384b49c4902 Author: Guillaume Munch <g...@lyx.org> Date: Sun Aug 28 16:51:15 2016 +0100 Change "Form

Re: Tarballs for LyX 2.2.0 are on FTP

2016-08-28 Thread Guillaume Munch
Le 09/06/2016 à 04:03, Richard Heck a écrit : On 06/08/2016 03:57 PM, Georg Baum wrote: Guillaume Munch wrote: Le 07/06/2016 00:00, Richard Heck a écrit : Our use of git would make it very easy for us to have a branch in which new features not requiring format changes could also be put

Re: [LyX/master] Reset anchor before selecting with S-button1

2016-08-28 Thread Guillaume Munch
Le 23/08/2016 à 11:23, Jean-Marc Lasgouttes a écrit : commit b583fb26e89ccdc242e5c11d5e9d8b0606bee957 Author: Jean-Marc Lasgouttes Date: Tue Aug 23 12:22:35 2016 +0200 Reset anchor before selecting with S-button1 --- src/Text3.cpp |1 + 1 files changed, 1

[patch] On-screen justification: stretch in proportion with the em, up to a limit

2016-08-28 Thread Guillaume Munch
(1.5em) to prevent situations where there are weirdly wide gaps between words (inspired my Kindle). Sincerely Guillaume >From 3895e6e7265f0767259e7c7987281376aaca4bad Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Sat, 13 Aug 2016 19:03:02 +0100 Subject: [PATCH]

Re: Inkscape /LyX integration (working!)

2016-08-28 Thread Guillaume Munch
Le 19/08/2016 à 19:19, Vermeer Martin a écrit : Just noticed that a similar, more extensive and probably allround better project was completed back in 2011 by one Daniel Groger... great minds think alike! http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg169820.html But why is this not

Re: Custom Insets on a Menu

2016-08-28 Thread Guillaume Munch
Le 14/08/2016 à 22:43, Richard Heck a écrit : On 08/14/2016 07:07 AM, Guillaume Munch wrote: Le 04/08/2016 à 02:11, Guillaume Munch a écrit : In the attached patch, I propose to replace the reference with a shared_ptr to avoid copying tens of FuncRequests every time one opens a menu. I

Re: [LyX/2.2.x] Start preparations for 2.2.1.

2016-08-28 Thread Guillaume Munch
Le 30/07/2016 à 21:10, Guillaume Munch a écrit : Le 27/07/2016 à 17:37, Jean-Pierre Chrétien a écrit : After reviewing the various uses of Format in the menus and the translations I made, I eventually agree upon this, as I use Format in French in Preferences->File Formats. Ok so for

Re: [LyX/2.2.x] Start preparations for 2.2.1.

2016-08-28 Thread Guillaume Munch
Le 31/07/2016 à 22:00, Guenter Milde a écrit : On 2016-07-30, Guillaume Munch wrote: Le 26/07/2016 à 09:23, Guenter Milde a écrit : (I have a similar issue with the "source panel": it should really be called "output panel". I cannot follow this argument: the "so

Re: Anonymous functions: replace bind with lambdas

2016-08-28 Thread Guillaume Munch
Le 05/07/2016 à 20:39, Georg Baum a écrit : Guillaume Munch wrote: I have split the patch in two for you, and already committed the part that does not introduce lambda expressions. Attached is the remainder of the patch that replaces all remaining std::bind with lambda expressions. Thanks. I

Re: clang warning in InsetBranch.h

2016-08-28 Thread Guillaume Munch
Le 28/08/2016 à 09:29, Stephan Witt a écrit : This is a problem in the Enchant library - not in LyX. It gets me every time.

Re: [LyX/master] LaTeX highlighter: make at a letter in the user preamble

2016-08-27 Thread Guillaume Munch
Le 15/07/2016 à 17:54, Richard Heck a écrit : On 07/15/2016 12:51 PM, Guillaume Munch wrote: commit 10f6eb2e7eeffc757b7f54059524441e90008240 Author: Guillaume Munch <g...@lyx.org> Date: Fri Jul 15 17:45:47 2016 +0100 LaTeX highlighter: make at a letter in the user preamble

Re: [patch] Experiment with c++11 unicode strings

2016-08-27 Thread Guillaume Munch
Le 25/08/2016 à 20:36, Georg Baum a écrit : Guillaume Munch wrote: Le 22/08/2016 à 20:56, Georg Baum a écrit : Our own facets work, and the implementation is confined to one file which nobody needs to look at (unless he wants to). I made it work with libc++ too, which

Re: clang warning in InsetBranch.h

2016-08-27 Thread Guillaume Munch
Le 24/08/2016 à 14:07, Jean-Marc Lasgouttes a écrit : I get this warning with clang in master: In file included from ../../master/src/InsetList.cpp:21: ../../master/src/insets/InsetBranch.h:106:7: warning: 'lyx::InsetBranch::producesOutput' hides overloaded virtual function

Re: Universal function of backspace key at beginning of paragraph

2016-08-26 Thread Guillaume Munch
Le 26/08/2016 à 20:34, racoon a écrit : Hi devs and users, I still think a more universal function of the backspace key at beginning of paragraphs is a very good idea. http://www.lyx.org/trac/ticket/10156 Summary: The idea is to have backspace at the beginning of a non-default paragraph to

Re: clang warning in InsetBranch.h

2016-08-24 Thread Guillaume Munch
Le 24/08/2016 à 14:07, Jean-Marc Lasgouttes a écrit : I get this warning with clang in master: In file included from ../../master/src/InsetList.cpp:21: ../../master/src/insets/InsetBranch.h:106:7: warning: 'lyx::InsetBranch::producesOutput' hides overloaded virtual function

Re: [LyX/master] Simplify menus when there is only one caption type

2016-08-23 Thread Guillaume Munch
Le 23/08/2016 à 16:13, Guillaume Munch a écrit : Le 23/08/2016 à 14:30, Jean-Marc Lasgouttes a écrit : Le 19/08/2016 à 14:17, Jean-Marc Lasgouttes a écrit : Simplify menus when there is only one caption type This removes the submenu indirection in Insert and the type changer

Re: [LyX/master] Simplify menus when there is only one caption type

2016-08-23 Thread Guillaume Munch
Le 23/08/2016 à 14:30, Jean-Marc Lasgouttes a écrit : Le 19/08/2016 à 14:17, Jean-Marc Lasgouttes a écrit : Simplify menus when there is only one caption type This removes the submenu indirection in Insert and the type changer in contextual menu. Interestingly, the code was there,

Re: [patch] Experiment with c++11 unicode strings

2016-08-22 Thread Guillaume Munch
Le 22/08/2016 à 20:56, Georg Baum a écrit : Guillaume Munch wrote: This is not the final version of the patch however because there is one big disappointment: the C++11 standard does not require several facets (including ctype) that are necessary to use stringstreams of char32_t. So these need

Re: [LyX/master] Introduce "inverted" branch insets: These are branches whose content is output when a branch is NOT activated. Fixes bug #7698.

2016-08-22 Thread Guillaume Munch
Le 20/08/2016 à 15:31, Scott Kostyshak a écrit : On Sat, Aug 20, 2016 at 02:25:16PM +0100, Guillaume Munch wrote: Le 08/08/2016 à 17:40, Richard Heck a écrit : (We did not do a format change for that.) I am worried at the idea of certain commits introducing hidden file format changes

[patch] Experiment with c++11 unicode strings

2016-08-21 Thread Guillaume Munch
Guillaume >From 7ca4a7383c4a77d85996d77dbb3b9f4110a83cc5 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Sat, 20 Aug 2016 16:27:52 +0100 Subject: [PATCH 1/4] typedef char32_t char_type; typedef std::u32string docstring; MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Conten

Re: [LyX/master] Correct comment

2016-08-21 Thread Guillaume Munch
Le 15/08/2016 à 02:24, Enrico Forestieri a écrit : Hopefully, this important issue has been solved at f323a64f. I like your solution. I had to adapt it to make sure there is no unused variable warning.

Re: [LyX/master] Introduce "inverted" branch insets: These are branches whose content is output when a branch is NOT activated. Fixes bug #7698.

2016-08-20 Thread Guillaume Munch
Le 08/08/2016 à 17:40, Richard Heck a écrit : (We did not do a format change for that.) I am worried at the idea of certain commits introducing hidden file format changes. Is there a test somewhere that I could use, to check that lyx writes the files identically as it does in earlier stable

Re: middle-click to open child documents?

2016-08-20 Thread Guillaume Munch
Le 20/08/2016 à 04:06, Scott Kostyshak a écrit : I see, but José seems against it. So it would be nice to see what others think. Subject line sounds intuitive.

Re: Custom Insets on a Menu

2016-08-14 Thread Guillaume Munch
Le 04/08/2016 à 02:11, Guillaume Munch a écrit : In the attached patch, I propose to replace the reference with a shared_ptr to avoid copying tens of FuncRequests every time one opens a menu. I would like to commit this patch to unblock the development of Richard's.

Re: [LyX/master] Correct comment

2016-08-14 Thread Guillaume Munch
Le 13/08/2016 à 16:45, Enrico Forestieri a écrit : commit 7113fb669dcd193295308c44ee2213aa437e38b2 Author: Enrico Forestieri Date: Sat Aug 13 17:43:03 2016 +0200 Correct comment According to C++11 rules, static locals are thread safe for the first-time

Re: workaround to 'git reset --hard' not working because of .gitattributes

2016-08-12 Thread Guillaume Munch
Le 29/07/2016 à 16:16, Guillaume Munch a écrit : Le 28/07/2016 à 23:19, Richard Heck a écrit : I wonder if git rm .gitattributes git add .gitattributes git reset --hard would be enough. I do not understand how this would solve, but I will try next time it happens. git rm

Re: alt+x does not give focus to minibuffer if it is open

2016-08-12 Thread Guillaume Munch
Le 12/08/2016 à 19:44, Scott Kostyshak a écrit : On Fri, Aug 12, 2016 at 07:28:57PM +0100, Guillaume Munch wrote: Le 12/08/2016 à 01:23, Scott Kostyshak a écrit : The change is due to 7ac70092. From what I understand, this is an intended change and there's no easy way to make alt+x work

Re: alt+x does not give focus to minibuffer if it is open

2016-08-12 Thread Guillaume Munch
Le 12/08/2016 à 01:23, Scott Kostyshak a écrit : The change is due to 7ac70092. From what I understand, this is an intended change and there's no easy way to make alt+x work the second time. I'll give up here on this, unless someone gives me an idea for a possible solution. By looking at it,

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-08 Thread Guillaume Munch
Le 08/08/2016 à 17:16, Kornel Benko a écrit : Am Montag, 8. August 2016 um 15:55:15, schrieb Guillaume Munch <g...@lyx.org> Le 07/08/2016 à 04:30, Scott Kostyshak a écrit : On Sat, Aug 06, 2016 at 06:51:54PM +0100, Guillaume Munch wrote: Thanks for the explanations. After a few

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-08 Thread Guillaume Munch
Le 07/08/2016 à 04:30, Scott Kostyshak a écrit : On Sat, Aug 06, 2016 at 06:51:54PM +0100, Guillaume Munch wrote: Thanks for the explanations. After a few tries and turning off the MERGE_FILES flag, I got: ...master/src/frontends/qt4/GuiApplication.cpp:128:21: fatal error: xcb/xcb.h

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-07 Thread Guillaume Munch
Le 07/08/2016 à 17:05, Enrico Forestieri a écrit : On Sun, Aug 07, 2016 at 04:18:13PM +0200, Enrico Forestieri wrote: On Sun, Aug 07, 2016 at 01:10:49PM +0100, Guillaume Munch wrote: That being said, if we want to make any use of the and headers in the future we need the posix version

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-07 Thread Guillaume Munch
Le 07/08/2016 à 04:01, Enrico Forestieri a écrit : On Sat, Aug 06, 2016 at 03:39:19PM +0100, Guillaume Munch wrote: call_once.cpp: #include static std::once_flag flag; int main() { std::call_once(flag, [](){ return; }); return 0; } Thanks for the test case. I used it to fix this issue

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 16:45, Abdelrazak Younes a écrit : On 06/08/2016 17:04, Guillaume Munch wrote: Le 06/08/2016 à 10:16, Abdelrazak Younes a écrit : (1) Do not commit any part of the patch because it is so minor. This is my preference because it doesn't bring anything and it can create

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 02:26, Scott Kostyshak a écrit : On Sat, Aug 06, 2016 at 02:01:00AM +0100, Guillaume Munch wrote: Le 05/08/2016 à 02:35, Enrico Forestieri a écrit : I am simply cross-compiling from cygwin following the usual way: Good to know. configure --host=i686-w64-mingw32 --build

Re: C++ "good practices" regarding constifying a function parameter?

2016-08-06 Thread Guillaume Munch
(For some reason the message did not get through, retrying. That's the second time this happens in the recent days. Anyone else experiences issues with gmane?) Le 06/08/2016 à 10:16, Abdelrazak Younes a écrit : (1) Do not commit any part of the patch because it is so minor. This is my

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 03:44, Enrico Forestieri a écrit : As already said, it should be the same, provided you have the necessary tools and libraries. These can be found in the cygwin distribution with package names such as mingw64-i686-hunspell, mingw64-i686-pkg-config, mingw64-i686-qt5-base,

Re: Pandora's box

2016-08-06 Thread Guillaume Munch
Le 06/08/2016 à 10:31, Abdelrazak Younes a écrit : Hi Guillaume, Just my 2 cents about those recent commits: 1) Switching to C++11 thread is a good thing 2) All these #if (gcc 4.6) are uglyfying the code considerably, you should enter C++11 with 2 steps or just leave it. Thanks, Abdel Hi

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-05 Thread Guillaume Munch
Le 05/08/2016 à 02:35, Enrico Forestieri a écrit : I am simply cross-compiling from cygwin following the usual way: Good to know. configure --host=i686-w64-mingw32 --build=i686-pc-cygwin ... I would be happy to know how to do something similar from Linux. The cygwin cross-compiler is

Re: [LyX/master] Replace static with thread_local when used for caching

2016-08-05 Thread Guillaume Munch
Le 05/08/2016 à 19:25, Richard Heck a écrit : I've suggested it before, but: Why can't we just test for this in configure? The reason is that testing for its availability is not sufficient. Indeed, one also has to have a ready replacement that does something similar enough. Otherwise, every

Re: [LyX/master] Replace static with thread_local when used for caching

2016-08-05 Thread Guillaume Munch
Le 05/08/2016 à 08:39, Stephan Witt a écrit : Am 04.08.2016 um 14:55 schrieb Guillaume Munch <g...@lyx.org>: Le 04/08/2016 à 08:48, Stephan Witt a écrit : On my Mac with clang I cannot compile after this commit :( src/frontends/qt4/GuiFontLoader.cpp:380:2: error: thread-local s

Re: [LyX/master] Use call_once to ensure something is only called once

2016-08-04 Thread Guillaume Munch
Le 04/08/2016 à 10:19, Enrico Forestieri a écrit : This does not compile with mingw (g++ 4.9.2): ../../src/graphics/PreviewLoader.cpp:101:4: error: ‘call_once’ was not declared in this scope }); ^ Finding infos about this was complicated because mingw does not appear to be very

Re: [LyX/master] Replace static with thread_local when used for caching

2016-08-04 Thread Guillaume Munch
Le 04/08/2016 à 08:48, Stephan Witt a écrit : On my Mac with clang I cannot compile after this commit :( src/frontends/qt4/GuiFontLoader.cpp:380:2: error: thread-local storage is not supported for the current target thread_local vector cache_set(NUM_FAMILIES, false);

Re: Custom Insets on a Menu

2016-08-03 Thread Guillaume Munch
lete this Private object. The simplest is to just replace the naked pointer with a unique_ptr so that you do not have to implement a destructor by hand. Guillaume >From ec5409054e4ec402d687509f47681fde06856249 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Wed, 3 Aug 2016 2

Re: Boost Warnings, Again

2016-08-03 Thread Guillaume Munch
Le 02/08/2016 à 21:33, Richard Heck a écrit : Is there anything we can do about all the warnings like this? ./../../3rdparty/boost/boost/function/function_base.hpp:308:13: warning: placement new constructing an object of type

Re: [LyX/master] Simplifications, mainly removal of boost::function and useless std::bind

2016-08-03 Thread Guillaume Munch
Le 03/08/2016 à 19:40, Richard Heck a écrit : Factory factory = boost::any_cast(any_factory); -if (!factory.empty()) +if (!factory) transformer = factory(data); } Surely that should be "if (factory)", not "if (!factory)". Indeed, sorry about this. This means that I have

Re: Weird Selection Bug

2016-08-02 Thread Guillaume Munch
Le 02/08/2016 à 07:39, Stephan Witt a écrit : OTOH starting the selection at the current cursor position after moving the input focus with keyboard is the way it works on Mac - with LyX and with other text editors. +1, not just on Mac

Re: [LyX/master] Replace static with thread_local when used for caching

2016-08-01 Thread Guillaume Munch
Le 02/08/2016 à 00:18, Richard Heck a écrit : On 08/01/2016 06:49 PM, Guillaume Munch wrote: +#if defined(__GNUC__) && (__GNUC__ == 4) && (__GNUC_MINOR__ == 6) I meant to ask before: Even if we're requiring gcc >= 4.6 (right?), is it worth changing this to: (__GNUC_M

Re: Pandora's box

2016-08-01 Thread Guillaume Munch
Le 31/07/2016 à 19:52, Richard Heck a écrit : +++ b/src/frontends/qt4/GuiCitation.cpp Is there some way we could store these per BufferView or something? I'd kind of like to save the last searched string for each document, rather than globally. Yes, I think there must be a better solution.

Re: Pandora's box

2016-08-01 Thread Guillaume Munch
Le 31/07/2016 à 19:52, Richard Heck a écrit : On 07/31/2016 01:38 PM, Guillaume Munch wrote: For other "FIXME thread" issues, either the solution is more complex, or using statics is inappropriate altogether (I think). Is there a plan to get rid of these? It looks to me

Pandora's box

2016-07-31 Thread Guillaume Munch
(see my recent commits and the attached patch). Guillaume >From 7fd53bc44bd278fd1f30400c030e350f2c0a6aa3 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Sun, 31 Jul 2016 00:42:51 +0100 Subject: [PATCH] Replace static with thread_local when used for caching thread_loca

Re: [LyX/2.2.x] Start preparations for 2.2.1.

2016-07-30 Thread Guillaume Munch
Le 27/07/2016 à 17:37, Jean-Pierre Chrétien a écrit : After reviewing the various uses of Format in the menus and the translations I made, I eventually agree upon this, as I use Format in French in Preferences->File Formats. Ok so for now intend to leave it, and backport it to stable again if

Re: [LyX/2.2.x] Start preparations for 2.2.1.

2016-07-30 Thread Guillaume Munch
Le 26/07/2016 à 09:23, Guenter Milde a écrit : (I have a similar issue with the "source panel": it should really be called "output panel". I cannot follow this argument: the "source panel" shows various output formats (TeX/HTML/LyX) in source form - (as opposed to a user agent (browser)

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Guillaume Munch
sometimes excluded zero. This was my original objection after testing your patch. But in the end I think it was entirely unrelated to your bug, it just led me to find the cause. >From 55fe9bf009eb19f9e561816502aae41c1d9dd8ee Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Guillaume Munch
Le 29/07/2016 à 23:32, Jean-Marc Lasgouttes a écrit : Le 29/07/2016 à 19:51, Scott Kostyshak a écrit : I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple

Re: #10310: Session handling does not restore cursor position

2016-07-29 Thread Guillaume Munch
Le 28/07/2016 à 10:46, Jean-Marc Lasgouttes a écrit : I think the limit is useful. I am sure somebody somewhere has a makefile that creates thousand of files... It would be better to make it work IMO. Ok. Added to the bug report with a easyfix tag so that we don't forget.

Re: #10310: Session handling does not restore cursor position

2016-07-29 Thread Guillaume Munch
Le 27/07/2016 à 23:01, Scott Kostyshak a écrit : I imagine it is there for performance reasons? A thousand lines in the file and a thousand entries in the map would be just as fine, probably ten thousands as well. LastFilePosSection::read() is called for every recent file when opening

Re: [patch] Specify the target format for local layout conversion

2016-07-29 Thread Guillaume Munch
Le 28/07/2016 à 17:49, José Abílio Matos a écrit : After a cursory look at your code I have no objection. :-) BTW, the usual rant at this type of code is that equally important would an option that allowed to express what is the stable version that you are interested (the equivalent -V option

Re: workaround to 'git reset --hard' not working because of .gitattributes

2016-07-29 Thread Guillaume Munch
Le 28/07/2016 à 23:19, Richard Heck a écrit : On 07/23/2016 06:30 PM, Guillaume Munch wrote: Since it looks so severe, I wonder whether there is a radical solution, such as rewriting the history of master, provided developers agree that the problem is that annoying. That sounds dangerous

Re: C++ "good practices" regarding constifying a function parameter?

2016-07-29 Thread Guillaume Munch
Le 27/07/2016 à 22:19, Scott Kostyshak a écrit : For the function definition, the difference is in terms of documentation. If you are adding const in the definition because you find it clearer this way, then it is a good reason to change it. Yes this was my intention. To me it has the same

Re: #10310: Session handling does not restore cursor position

2016-07-27 Thread Guillaume Munch
Le 27/07/2016 à 14:05, Davide Anchisi a écrit : Yes, it is written in ~/.lyx/session every time I exit LyX. It seems it is not read back (or used) when opening LyX again. But, even stranger, it does work for some files, apparently those created using LyX versions 2.1. For those files the cursor

Re: C++ "good practices" regarding constifying a function parameter?

2016-07-27 Thread Guillaume Munch
Le 27/07/2016 à 01:54, Scott Kostyshak a écrit : The attached patch constifies a function parameter. My question is whether this patch causes more pain to other developers than it does good to the code. The patch modifies a header that is included in many of our .cpp files, so will cause a

Re: new compilation warning in 2.2.x branch

2016-07-25 Thread Guillaume Munch
Le 26/07/2016 à 00:15, Uwe Stöhr a écrit : I found time to compile today's 2.2.x branch. I get this warning that could and should be avoided: TextMetrics.cpp D:\LyXGit\2.2.x\src\RowPainter.cpp(590): warning C4244: 'initializing': conversion from 'double' to 'int', possible loss of data

Re: [LyX/2.2.x] Start preparations for 2.2.1.

2016-07-25 Thread Guillaume Munch
Le 24/07/2016 à 16:48, Jean-Pierre Chrétien a écrit : Le 22/07/2016 16:21, Guillaume Munch a écrit : Le 22/07/2016 à 14:31, Jean-Pierre Chrétien a écrit : Le 21/07/2016 19:30, Richard Heck a écrit : commit ad72f2b5544bbe42c575a3028f629c810fc0a409 Author: Richard Heck <rgh...@lyx.org>

[patch] Specify the target format for local layout conversion

2016-07-23 Thread Guillaume Munch
for master, the old behaviour is preserved because of the definition LYXFILE_LAYOUT_FORMAT = LAYOUT_FORMAT. Sincerely Guillaume >From ad59b14909cc2add8c48bd3247ad933af02442d3 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Sat, 23 Jul 2016 15:29:40 +0100 Subject: [PATCH 2/2]

Re: [LyX/master] Make the non-drawing cases faster in TextMetrics::drawParagraph

2016-07-23 Thread Guillaume Munch
Le 19/07/2016 à 23:42, Jean-Marc Lasgouttes a écrit : As I understand it, it is a bug in RowPainter::paintOnlyInsets introduced to fix #4889. I pushed a better fix for this bug, which also fixes your use case. Thanks, works well.

Re: workaround to 'git reset --hard' not working because of .gitattributes

2016-07-23 Thread Guillaume Munch
Le 26/06/2016 à 01:21, Scott Kostyshak a écrit : I think this is due to the recent fixes in .gitattributes. In any case, git reset --hard does not fix anything. But the following does work for me: git rm .gitattributes git add -A git reset --hard Thank you very much for this message. I have

Re: [LyX/master] Use a proper test for detecting usable std::regex

2016-07-23 Thread Guillaume Munch
Le 18/07/2016 à 10:55, Jean-Marc Lasgouttes a écrit : Le 08/07/2016 à 22:18, Guillaume Munch a écrit : It takes several seconds each time... Is it better now? Not sure. It went down from 6 seconds to 2 seconds after running autogen. But I do not know whether that is because your changes

Re: \Omega is not displayed correctly

2016-07-22 Thread Guillaume Munch
Le 21/07/2016 à 21:00, L. Han a écrit : After update to 2.2.0, \Omega is not displayed correctly in Lyx. It looks like a bold \neg now. Hope it will be fixed soon. Thanks! It could be that the latest version of the fonts supplied with lyx are not properly installed. See

Re: [LyX/2.2.x] Start preparations for 2.2.1.

2016-07-22 Thread Guillaume Munch
Le 22/07/2016 à 14:31, Jean-Pierre Chrétien a écrit : Le 21/07/2016 19:30, Richard Heck a écrit : commit ad72f2b5544bbe42c575a3028f629c810fc0a409 Author: Richard Heck Date: Thu Jul 21 14:25:32 2016 -0400 Start preparations for 2.2.1. + +- New document parameter "Save

Re: toolbars Lock menu

2016-07-20 Thread Guillaume Munch
Le 12/07/2016 13:30, racoon a écrit : I have attached a first attempt at implementing a toolbar lock. (Unfortunately, it is a bit intermingled with a lfun implementation for changing the icon-size.) Hi, I can have a look. Do you have an updated patch in the meanwhile?

Re: about the new "invert branch feature"

2016-07-18 Thread Guillaume Munch
Le 18/07/2016 21:59, Jean-Marc Lasgouttes a écrit : Le 18/07/2016 à 22:21, Guillaume Munch a écrit : I vote ¬ over striking out, and agree that users will figure it out. But I expect other people will prefer it spelled. Let's wait and see. And shall ✔ mean that the inset is activated

Re: about the new "invert branch feature"

2016-07-18 Thread Guillaume Munch
Le 18/07/2016 16:44, Richard Heck a écrit : I'm not sure how "intuitive" the symbols here need to be. People may not realize immediately what "✔ ¬Branch" means, but I would think they would generally figure it out pretty quickly. Plus of course it can be mentioned in the docs. And I'm not sure

Re: default dir when save for first time is not cwd

2016-07-18 Thread Guillaume Munch
Le 18/07/2016 06:02, Scott Kostyshak a écrit : Attached is a patch with a detailed commit message, and a screenshot of the paths preferences tab with the patch. Any thoughts? Regarding the help text, one could just display the first sentence and have the rest in a tooltip. A "?" icon could

Re: [PATCH] make string breaking faster

2016-07-18 Thread Guillaume Munch
Le 17/07/2016 18:31, Jean-Marc Lasgouttes a écrit : Guillaume, I'd like to have your input wrt this patch and Qt 5.x. I would prefer for cleanness to avoid double caching in this case and keep the patch Qt4 only. Makes sense.

Re: about the new "invert branch feature"

2016-07-18 Thread Guillaume Munch
Le 18/07/2016 15:33, Jean-Marc Lasgouttes a écrit : Le 18/07/2016 à 04:20, Richard Heck a écrit : * "invert inset" and "activate branch" do not belong together, since one is for the whole branch and the other is for only one inset (I understand this is the reason for the name above). Some

Re: [LyX/2.2.x] UI for save_transient_properties

2016-07-13 Thread Guillaume Munch
Le 13/07/2016 17:40, Richard Heck a écrit : Yes, it's probably too short notice. So let me make a proposal. We can revert this change (Output --> Format) in stable for now and talk about it for 2.2.2. Doing this won't cause serious problems with the translations because "Output" is also used in

Re: [LyX/2.2.x] UI for save_transient_properties

2016-07-13 Thread Guillaume Munch
Le 13/07/2016 00:30, Richard Heck a écrit : > On 07/12/2016 07:07 PM, Uwe Stöhr wrote: > >> I could not follow the development the last days but I am opposed in >> renaming the document setting section "Output" to "Format". This >> section is about the output as the UserGuides also explains well:

Re: How to create a patch with git gui

2016-07-12 Thread Guillaume Munch
Le 12/07/2016 07:11, Daniel a écrit : Thanks. I think it worked (patch and screenshot of gitk attached). On 12.07.2016 00:10, Richard Heck wrote: [...] Then right-click on the commit for which you want to make the patch. You will have the option "Make patch". Choose that and then choose where

Re: Icons in menus

2016-07-11 Thread Guillaume Munch
Le 11/07/2016 09:17, racoon a écrit : On 15.06.2016 09:45, racoon wrote: Hi, I could not find a discussion on icons in menus. I tend to believe that they help locating entries when scanning over a menu entry. But maybe that's bogus. I think icons in menus are less popular on macOS [sic] than

Re: Translations for LyX 2.2.1

2016-07-11 Thread Guillaume Munch
Hi, my patch at http://mid.gmane.org/nlokdq$96p$1...@ger.gmane.org includes new translatable strings, still to be reviewed, in case you are ready to accept it for 2.2.1 (probably). Le 11/07/2016 19:15, Richard Heck a écrit : Although 2.2.0 was only released at the beginning of June, the long

Re: [LyX/master] Make the non-drawing cases faster in TextMetrics::drawParagraph

2016-07-10 Thread Guillaume Munch
Le 12/06/2016 18:54, Jean-Marc Lasgouttes a écrit : Le 12/06/2016 19:05, Guillaume Munch a écrit : In some situations, LyX does not recognize that an inset is hovered with the mouse: does not change cursor icon, does not paint the label in a different color, and does not show tooltip. Bisect

Re: Paragraph::id()

2016-07-10 Thread Guillaume Munch
Le 10/07/2016 15:49, Guillaume Munch a écrit : Le 09/07/2016 22:23, Richard Heck a écrit : If I do: onePar.id() == otherPar.id() will that do what I obviously want it to do? I.e., work as a proxy for: onePar == otherPar ?? After reading the code, I think that: onePar.id

Re: Paragraph::id()

2016-07-10 Thread Guillaume Munch
Le 09/07/2016 22:23, Richard Heck a écrit : If I do: onePar.id() == otherPar.id() will that do what I obviously want it to do? I.e., work as a proxy for: onePar == otherPar ?? After reading the code, I think that: onePar.id() == otherPar.id() is equivalent to onePar ==

Re: [LyX/master] Fix thinko in Buffer::preview. It is possible for this routine to be called when we do not have a cloned Buffer, namely, if we do not have EXPORT_in_THREAD defined.

2016-07-10 Thread Guillaume Munch
Le 10/07/2016 14:47, Richard Heck a écrit : On 07/10/2016 07:06 AM, Guillaume Munch wrote: Le 10/07/2016 06:42, Richard Heck a écrit : On 07/10/2016 01:33 AM, Scott Kostyshak wrote: On Sun, Jul 10, 2016 at 07:16:13AM +0200, Richard Heck wrote: commit d8aab4af9e6e72c835f78ba54a46687b870c25fa

Re: [LyX/master] Fix thinko in Buffer::preview. It is possible for this routine to be called when we do not have a cloned Buffer, namely, if we do not have EXPORT_in_THREAD defined.

2016-07-10 Thread Guillaume Munch
Le 10/07/2016 14:56, Richard Heck a écrit : On 07/10/2016 09:53 AM, Guillaume Munch wrote: Le 10/07/2016 14:48, Richard Heck a écrit : On 07/10/2016 05:26 AM, Andrew Parsloe wrote: I ask in near total ignorance, but "my ears pricked up" when I read "EXPORT_in_THREAD

Re: [LyX/master] Fix thinko in Buffer::preview. It is possible for this routine to be called when we do not have a cloned Buffer, namely, if we do not have EXPORT_in_THREAD defined.

2016-07-10 Thread Guillaume Munch
Le 10/07/2016 14:48, Richard Heck a écrit : On 07/10/2016 05:26 AM, Andrew Parsloe wrote: I ask in near total ignorance, but "my ears pricked up" when I read "EXPORT_in_THREAD" and "It's set in the code, but can be manually unset by people who don't want the risks of background export,

Re: Aw: Re: #10199: Non-encodable characters with XeTeX

2016-07-10 Thread Guillaume Munch
Le 10/07/2016 03:30, Scott Kostyshak a écrit : On Fri, Jul 08, 2016 at 10:06:52PM -0400, Scott Kostyshak wrote: On Fri, Jul 08, 2016 at 09:23:32PM +0100, Guillaume Munch wrote: In that case, if you already have everything set up and that does not cost you any more effort, thank you

Re: [LyX/master] Fix thinko in Buffer::preview. It is possible for this routine to be called when we do not have a cloned Buffer, namely, if we do not have EXPORT_in_THREAD defined.

2016-07-10 Thread Guillaume Munch
Le 10/07/2016 06:42, Richard Heck a écrit : On 07/10/2016 01:33 AM, Scott Kostyshak wrote: On Sun, Jul 10, 2016 at 07:16:13AM +0200, Richard Heck wrote: commit d8aab4af9e6e72c835f78ba54a46687b870c25fa Author: Richard Heck Date: Sun Jul 10 01:12:42 2016 -0400 Fix thinko

Re: Anonymous functions: replace bind with lambdas

2016-07-09 Thread Guillaume Munch
Le 06/07/2016 22:37, Stephan Witt a écrit : Am 05.07.2016 um 21:39 schrieb Georg Baum : Thanks. I am currently swamped with work, and this deserves a thorough look so please be patient for a few days for my answer. Sure I’m not familiar with lambda

Re: toolbars Lock menu

2016-07-09 Thread Guillaume Munch
Le 08/07/2016 15:10, racoon a écrit : On 08.07.2016 08:17, racoon wrote: On 07.07.2016 14:41, racoon wrote: Can someone give me a hint where LyX stores the individual toolbars' properties, i.e. position and visibility. Okay, got it (via QSettings). I was just a bit confused because the

Re: Aw: Re: #10199: Non-encodable characters with XeTeX

2016-07-08 Thread Guillaume Munch
Le 08/07/2016 10:10, Scott Kostyshak a écrit : On Thu, Jul 07, 2016 at 12:30:45PM +0200, Guillaume Munch wrote: I can do that. Can somebody tell me (again?) which command line will run the appropriate test? The basics are: # In a new directory (preferably outside of the source), run

Re: [LyX/master] Use a proper test for detecting usable std::regex

2016-07-08 Thread Guillaume Munch
Le 06/07/2016 14:14, Jean-Marc Lasgouttes a écrit : commit 14a6a4723f527f5e7af0321635e7473bbb7da77b Author: Jean-Marc Lasgouttes Date: Wed Jul 6 14:49:18 2016 +0200 Use a proper test for detecting usable std::regex It takes several seconds each time... (but maybe

Re: Weird KDE Bug in LyX

2016-07-08 Thread Guillaume Munch
Le 08/07/2016 21:01, Richard Heck a écrit : On 07/08/2016 03:33 PM, Guillaume Munch wrote: Le 05/07/2016 21:30, Guillaume Munch a écrit : Please try the attached. I'll soon commit the fix to master. This is a delicate code path so even if I tried to be very careful

Re: Weird KDE Bug in LyX

2016-07-08 Thread Guillaume Munch
Le 05/07/2016 21:30, Guillaume Munch a écrit : Please try the attached. I'll soon commit the fix to master. This is a delicate code path so even if I tried to be very careful, there will be no backport without a test. Moreover it would be nice to know if #10119 (issues with Control+M

Re: Save transient properties

2016-07-08 Thread Guillaume Munch
Le 24/06/2016 16:03, Richard Heck a écrit : On 06/23/2016 11:02 AM, Guillaume Munch wrote: Dear list, I am thinking of adding the "Save transient properties" checkbox (disabling the save of \origin, \tracking_changes, \output_changes) to the "document class" panel, for la

Re: Aw: Re: #10199: Non-encodable characters with XeTeX

2016-07-07 Thread Guillaume Munch
Le 07/07/2016 08:53, G. Milde a écrit : - Ursprüngliche Mitteilung - #10199: Non-encodable characters with XeTeX -- Reporter: andnot | Owner: lasgouttes Type: defect | Status: fixedinmaster Priority:

Re: [LyX/master] Gcc 6+ use C++14 as default, so there is no need to enforce C++11

2016-07-06 Thread Guillaume Munch
Le 05/07/2016 18:25, Jean-Marc Lasgouttes a écrit : Le 05/07/2016 à 17:52, Guillaume Munch a écrit : Le 05/07/2016 17:23, Jean-Marc Lasgouttes a écrit : We have compiled for ages in gnu++98 mode forever when not using C++11. And currently gcc 6 uses gnu++14 by default. Do you want me to force

Re: Weird KDE Bug in LyX

2016-07-05 Thread Guillaume Munch
Le 02/07/2016 23:43, Guillaume Munch a écrit : On the other hand, it is possible to prioritise LyX shortcuts by using the shortcut override mechanism. This would solve both bugs http://www.lyx.org/trac/ticket/10261 and http://www.lyx.org/trac/ticket/10119 (probably), and alleviate

Re: compile err

2016-07-05 Thread Guillaume Munch
Le 05/07/2016 18:37, Pavel Sanda a écrit : I figured out that the linking problem disappears when building from clean tree. unistd.h is still needed (configure --enable-build-type=rel , automake 1.15, autoconf 2.69). This unistd.h problem is very strange. I could compile without errors or

Re: [LyX/master] Rationalise includes

2016-07-05 Thread Guillaume Munch
Le 05/07/2016 18:40, Pavel Sanda a écrit : wrote in the other mail, but to be clear i don't expect you to test all possible gcc or auttools variants before commiting stuff, we have to live with bugs like that. p Thank you for your patience.

<    1   2   3   4   5   6   7   8   9   10   >