Re: [LyX/master] Gcc 6+ use C++14 as default, so there is no need to enforce C++11

Le 05/07/2016 17:23, Jean-Marc Lasgouttes a écrit : We have compiled for ages in gnu++98 mode forever when not using C++11. And currently gcc 6 uses gnu++14 by default. Do you want me to force c++14 instead? If this brings the behaviour of gcc closer to that of other compilers, then why not?

Re: [LyX/master] Fix missing TexRow.h include after change 670efa8f646218f2a378f0cc614c4c37a9f6b89a

Le 05/07/2016 00:31, Stephan Witt a écrit : Am 04.07.2016 um 23:55 schrieb Guillaume Munch <g...@lyx.org>: What errors do you get with the attached? Guillaume That works too. Thanks for testing. Guillaume

Re: [LyX/master] Gcc 6+ use C++14 as default, so there is no need to enforce C++11

Le 05/07/2016 12:11, Jean-Marc Lasgouttes a écrit : Le 04/07/2016 à 23:34, Guillaume Munch a écrit : Le 04/07/2016 12:25, Jean-Marc Lasgouttes a écrit : commit 67ac031a33b1621fdadb903422de598595cc08d2 Also, use gnu++11 unconditionnally with gcc as we used to do before 67385e69. Does

Re: [LyX/master] Rationalise includes

Le 05/07/2016 00:33, Stephan Witt a écrit : Am 05.07.2016 um 00:24 schrieb Guillaume Munch <g...@lyx.org>: Le 04/07/2016 12:06, Stephan Witt a écrit : Hi Guillaume, now I’m getting: … Where are we after Pavel's and your changes? I’m able to build LyX again. But as Pavel said a

Re: Compilation problems

Le 05/07/2016 00:55, Stephan Witt a écrit : The enchant C++ header has more serious errors than this one. Look at the method is_added … I’m really surprised it’s so common on Linux. Sorry, I missed the fact that it is not in the LyX source tree.

Re: [LyX/master] Rationalise includes

Le 04/07/2016 12:06, Stephan Witt a écrit : Hi Guillaume, now I’m getting: … Where are we after Pavel's and your changes?

Re: [LyX/master] Fix missing TexRow.h include after change 670efa8f646218f2a378f0cc614c4c37a9f6b89a

Le 04/07/2016 20:37, Stephan Witt a écrit : commit c6ce76c2fbe88c7882935d6c1bf44a6247943b97 Author: Stephan Witt Date: Mon Jul 4 20:37:06 2016 +0200 Fix missing TexRow.h include after change 670efa8f646218f2a378f0cc614c4c37a9f6b89a --- src/mathed/MathStream.h |2 +-

Re: [LyX/master] Match code with comment

Le 04/07/2016 11:50, Jean-Marc Lasgouttes a écrit : Le 04/07/2016 à 01:36, Guillaume Munch a écrit : (Then one would have to fix the problem regarding uneven lines, mentioned in the above commit, in another fashion.) Note that this would lead to irregular dashed lines, at least in Qt4. I

Compilation problems

I tried to reproduce the compilation issues from today by compiling with clang, and also by changing the build type. The result is that I cannot reproduce the issues. Therefore, I am not going to be able adjust my build setup to make sure that I cause fewer such issues in the future. But doing

Re: [LyX/master] Gcc 6+ use C++14 as default, so there is no need to enforce C++11

Le 04/07/2016 12:25, Jean-Marc Lasgouttes a écrit : commit 67ac031a33b1621fdadb903422de598595cc08d2 Also, use gnu++11 unconditionnally with gcc as we used to do before 67385e69. Does this mean more problems that go unnoticed until people on OSX or Windows try to compile? Guillaume

Re: [LyX/master] Fix missing include for file i/o prototypes after header cleanup in change 489dca71cd99bbc78780fa40311a2eb042c0320e

Le 04/07/2016 10:30, Stephan Witt a écrit : commit df73cade2bdbf272f5228ec895d97c21a20242d5 Author: Stephan Witt Date: Mon Jul 4 10:30:19 2016 +0200 Fix missing include for file i/o prototypes after header cleanup in change 489dca71cd99bbc78780fa40311a2eb042c0320e ---

Re: compile err

Le 04/07/2016 02:20, Pavel Sanda a écrit : anyone can reproduce this (gcc 4.9.3): Not with 4.6 nor with 5.3 but there are probably configure switches involved. You can try adding: #ifdef HAVE_UNISTD_H # include #endif to src/ServerSocket.cpp. But TBH I have no further clue about the

Re: Display change tracking cue for InsetText and InsetCollapsible

Le 03/07/2016 17:51, Guillaume Munch a écrit : Dear List Attached is a patch that makes many small decisions regarding how text insets should be displayed under change tracking. You would probably have some comment about these choices. It would be too long to explain and it is hard

Re: Anonymous functions: replace bind with lambdas

Le 03/07/2016 20:52, Richard Heck a écrit : My own view is that our code is undercommented---and I know I'm as bad about this as anyone. That said, I often add comments to code I have to read to fix various bugs, if only for my own benefit later. I agree. I noticed myself doing that as well

Re: Anonymous functions: replace bind with lambdas

rom bd2634b6ae1f92939d8daa65468a8479e4d02385 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Wed, 29 Jun 2016 11:40:28 +0100 Subject: [PATCH] Remove support/functional.h and support/bind.h MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace

Re: Trojan warning from Windows defender

Le 03/07/2016 20:02, Pavel Sanda a écrit : Richard Heck wrote: Man-in-the middle for pgp signature? You stay in the middle and you send me whatever packet you want. However you don't have my secret key for the signature. So what you are going to do to fake it? Sorry, yes, you are right. I

Re: [LyX/master] Show names of debug modes in the debug panel

Le 31/05/2016 17:15, Jean-Marc Lasgouttes a écrit : Le 31/05/2016 à 17:06, Guillaume Munch a écrit : I am tempted to do the same for the loaded modules list in the document preferences. Sometimes when I am looking for a precise module, I have to guess from the translation of the description

Re: [RFC] Canceling Background Export

Le 29/06/2016 00:11, Richard Heck a écrit : I'm attaching a set of patches that allow for cancellation of background processes. When you start a view or update or whatever, you will get an extra menu entry in the Document menu. You can also use "export-cancel" in the minibuffer. It's rough in

Re: [LyX/master] Line breaks in tooltips

Le 03/07/2016 17:40, Guillaume Munch a écrit : commit 059ca0f691d567171e7772c1d56a7f96e7867339 Author: Guillaume Munch <g...@lyx.org> Date: Sun Jun 5 21:35:35 2016 +0200 Line breaks in tooltips * New function formatToolTip(QString): Format text for display as a T

Display change tracking cue for InsetText and InsetCollapsible

(despite the comments I have included). So I suggest instead that I commit it immediately and that you let me know your comments after you have some (hopefully good) experience from it. Sincerely Guillaume >From cbd3628f3df17e19842c1a60921e14f2dabd337a Mon Sep 17 00:00:00 2001 From: Guillaume Munch

Re: ancient history, v 0.10.7 beta

Le 30/06/2016 12:01, Jean-Marc Lasgouttes a écrit : Le 30/06/2016 à 11:57, José Abílio Matos a écrit : On Thursday, June 30, 2016 10:51:09 AM WEST Jean-Marc Lasgouttes wrote: We have a lot of these old thing on our ftp actually: http://www.lyx.org/misc/archaeology/lyx-time.html This web page

Re: default dir when save for first time is not cwd

Le 01/07/2016 03:01, Scott Kostyshak a écrit : On Fri, Jun 17, 2016 at 07:21:32PM -0400, Scott Kostyshak wrote: On Fri, Jun 17, 2016 at 10:33:03AM +0200, Jean-Marc Lasgouttes wrote: Le 17/06/2016 à 10:10, Scott Kostyshak a écrit : I guess the main question is: do you think a user would enter

Re: Weird KDE Bug in LyX

Le 30/06/2016 22:26, Richard Heck a écrit : For anyone running LyX 2.2.0 under KDE (or using a KDE-based window manager, or anything of that sort): There is an annoying new feature, KDE's "accelerator manager", that automatically adds shortcuts. This causes conflicts and so forth in many

Re: 5 more compiler warnings in master

Le 02/07/2016 20:28, Uwe Stöhr a écrit : I understand the compiler warnings but it is not easy for me to decide if a truncation of values was intended or not. I mean if it is intended one should use int().(…) Hi Uwe, you are right, asking somebody to fix a warning when they are not familiar

Re: [LyX/master] Compile fix after change 4b64aaf, replace missing constructor for C-string with docstring variant

Another way to answer your question is to look at the old code. It used to call from_utf8 already, so it appears that you are right. Le 02/07/2016 10:35, Stephan Witt a écrit : Hi Benjamin, I’ve had to change your code to make it compilable again. The constructor for the FuncRequest with

Re: Anonymous functions: replace bind with lambdas

Le 26/06/2016 21:17, Richard Heck a écrit : It would help me if you could explain this new syntax. I'm a philosopher, not a programmer. -theApp()->registerSocketCallback(fd, -bind(::read_ready, this)); +theApp()->registerSocketCallback(fd, [this]() { read_ready();

Re: Anonymous functions: replace bind with lambdas

As a sidenote: a related feature of Qt5 that is absent from Qt4.8 is the possibility to connect signals to arbitrary functions (including anonymous ones such as lambdas). Pros and cons from https://wiki.qt.io/New_Signal_Slot_Syntax: Pros * Compile time check of the existence of the signals and

Anonymous functions: replace bind with lambdas

Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Sat, 4 Jun 2016 11:29:35 +0100 Subject: [PATCH] Remove support/functional.h and support/bind.h Replace std::bind() with lambdas. This provides a much more readable code. --- src/Buffer.cpp | 12

Re: Custom Insets on a Menu

Le 26/06/2016 16:27, Richard Heck a écrit : The attached patch almost works. (Details like the icon are not yet there.) There are some big problems, however, which seem to derive from the fact that the whole menu and toolbar setup is not really designed to be modified on the fly. The problem

Re: workaround to 'git reset --hard' not working because of .gitattributes

Le 26/06/2016 18:08, Georg Baum a écrit : Scott Kostyshak wrote: I think this is due to the recent fixes in .gitattributes. In any case, git reset --hard does not fix anything. But the following does work for me: Yes, this was caused by the introduction of .gitattributes, since these files

Re: Master compile error

Le 26/06/2016 15:04, Jürgen Spitzmüller a écrit : Am Sonntag, den 26.06.2016, 14:30 +0100 schrieb Guillaume Munch: Hi Jürgen, I can have a look. Please send your config.log. Thank you. Log is attached. Thank you. I think the problem is there: configure:8141: checking whether make_unique

Re: Annoying terminal messages: QXcbClipboard: SelectionRequest too old

Le 26/06/2016 04:56, Scott Kostyshak a écrit : Can anyone else reproduce? I can.

Re: Master compile error

Le 26/06/2016 12:55, Jürgen Spitzmüller a écrit : Master does not build for me with autotools and gcc 6.1.1: In file included from ./../support/unicode.h:18:0, from docstream.cpp:15: ./../support/unique_ptr.h:24:28: error: ‘std::make_unique’ has not been declared namespace

Re: Remove \it from math completion?

Le 25/06/2016 21:37, Scott Kostyshak a écrit : I think the patch below is what you mean. Ah thanks that is much better. Now I understand. Please commit your version. Please commit my diff with your commit log :) Do you know (I don't want you to spend time to find out) where we would

Re: Combo Box for Custom Insets

Le 25/06/2016 19:15, Richard Heck a écrit : For now, the branch is here: http://git.lyx.org/?p=developers/rgheck/lyx.git;a=shortlog;h=refs/heads/features/CustomInsets If you are satisfied with it then you could commit it, I think. What is your plan?

Re: using directives in headers

Le 25/06/2016 20:56, Georg Baum a écrit : I recently stumbled upon using std::shared_ptr; or lyx::support::FileName; in header files (e.g. TocBackend.h). The shared_ptr was introduced as part of the lyx::shared_ptr removal (which did either point to boost or std), but there are other hits as

Re: Remove \it from math completion?

Le 25/06/2016 20:03, Scott Kostyshak a écrit : Attached is a patch that removes \it from math completion, since \it has been deprecated for a while, only giving a warning in TL 2015, but an error in 2016. I think the patch is consistent with 24d0 in the concept of removing math completion

Re: Combo Box for Custom Insets

Le 25/06/2016 18:36, Guillaume Munch a écrit : > @@ -328,6 +329,7 @@ public: > delete splitter_; > delete bg_widget_; > delete stack_widget_; > +delete insets_; > } This is incorrect. The pointer is not owned by GuiVi

Re: Combo Box for Custom Insets

Le 25/06/2016 17:01, Richard Heck a écrit : I'd be happy for someone else to make it into a menu, but I do not know enough about Qt to do it myself. I mostly stole this from LayoutBox. Yes, looks like it is not immediate.

Re: Combo Box for Custom Insets

Le 25/06/2016 17:00, Richard Heck a écrit : On 06/25/2016 02:58 AM, Liviu Andronic wrote: On Sat, Jun 25, 2016 at 12:23 AM, Richard Heck wrote: Attached please find a patch that implements a combo box for custom insets, much like the layout box. This is a very simple version.

Re: Joining LyX development team

Le 25/06/2016 12:53, Jean-Marc Lasgouttes a écrit : Le 25/06/2016 10:53, Uwe Stöhr a écrit : Am 24.06.2016 um 08:43 schrieb Dima Ruinskiy: Hi. My name is Dima Ruinskiy, and I would like to join the LyX development team. Hi Dima, welcome on lyx-devel! same For the others on this list:

Save transient properties

Dear list, I am thinking of adding the "Save transient properties" checkbox (disabling the save of \origin, \tracking_changes, \output_changes) to the "document class" panel, for lack of a better place. This panel already contains other settings unrelated to the document class. Can you think of

Re: InPreamble Tag: Bug #10215

Le 18/06/2016 17:42, Richard Heck a écrit : On 06/17/2016 05:16 AM, Jean-Marc Lasgouttes wrote: Le 14/06/2016 à 18:53, Richard Heck a écrit : This seems to me to count as a bug. To fix it, though, we'd obviously have to output the code from the style AFTER the Preamble, which would change the

Re: lyx and dark color schemes

Le 16/06/2016 19:19, Pavel Sanda a écrit : Guillaume Munch wrote: What can be somewhat annoying is to use branches, because you can't set both foreground and background. So if you share document with someone who uses different color set, or even need to use lyx for quick on different machines

Re: 2.2.2-staging Merged to 2.2.x

Le 15/06/2016 22:39, Richard Heck a écrit : I have merged 2.2.2-staging into 2.2.x now, so all commits for stable should now go to 2.2.x. Richard Kudos to Scott for having been meticulous, so that no emergency release was necessary. Guillaume

Re: lyx and dark color schemes

Le 15/06/2016 18:51, Pavel Sanda a écrit : Liviu Andronic wrote: The single most unreadable instance though is blue headings like in Beamer: http://i.imgur.com/zoSqWvX.png Fuuny, I use the same colors but it never occurred to me that this is hard to read :) What can be somewhat annoying is

Re: default dir when save for first time is not cwd

Le 16/06/2016 01:30, Scott Kostyshak a écrit : Currently if you start a new document and save, the default directory in the save dialog is the home directory. This is true even if I start lyx from a different directory. I would prefer for the default directory to be the current working

Re: [LyX/2.2.x] Make latex highlighter colors compatible with dark theme

Le 15/06/2016 20:21, Pavel Sanda a écrit : uillaume Munch wrote: commit 5c13007d925bf77cb9c5bc59fec49915653970af Author: Guillaume Munch <g...@lyx.org> Date: Tue Jun 14 21:45:47 2016 +0100 Make latex highlighter colors compatible with dark theme Partial fix for #8325 stat

Re: lyx and dark color schemes

Le 15/06/2016 17:45, Liviu Andronic a écrit : On Wed, Jun 15, 2016 at 5:52 PM, Guillaume Munch <g...@lyx.org> wrote: Le 15/06/2016 15:47, Liviu Andronic a écrit : On Wed, Jun 15, 2016 at 3:35 PM, Guillaume Munch <g...@lyx.org> wrote: Le 14/06/2016 22:14, Cor Blom a écrit : Op

Re: lyx and dark color schemes

Le 15/06/2016 15:47, Liviu Andronic a écrit : On Wed, Jun 15, 2016 at 3:35 PM, Guillaume Munch <g...@lyx.org> wrote: Le 14/06/2016 22:14, Cor Blom a écrit : Op 14-06-16 om 22:21 schreef Guillaume Munch: Le 14/06/2016 21:16, Cor Blom a écrit : Op 14-06-16 om 22:09 schreef Guillaume

Re: [PATCH] unique_ptr and some clean-up

Le 14/06/2016 21:49, Georg Baum a écrit : Guillaume Munch wrote: What error is it? ../../src/MetricsInfo.cpp:61:4: error: type ‘lyx::MetricsBase’ is not a direct base of ‘lyx::MetricsBase’ Thanks for the clues. I was not even aware that delegate constructors was a C++11 feature. Master

Re: lyx and dark color schemes

Le 14/06/2016 22:14, Cor Blom a écrit : Op 14-06-16 om 22:21 schreef Guillaume Munch: Le 14/06/2016 21:16, Cor Blom a écrit : Op 14-06-16 om 22:09 schreef Guillaume Munch: Le 14/06/2016 18:44, Cor Blom a écrit : Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde

Re: Tarballs for LyX 2.2.0 are on FTP

Le 15/06/2016 00:51, Enrico Forestieri a écrit : On Fri, Jun 10, 2016 at 10:20:32PM +0100, Guillaume Munch wrote: As for lyx2lyx, I gave one example of a commit which explicitly said that it would not be made round-trip, and another example where it had to be fixed afterwards because a special

Re: lyx and dark color schemes

Le 14/06/2016 21:16, Cor Blom a écrit : Op 14-06-16 om 22:09 schreef Guillaume Munch: Le 14/06/2016 18:44, Cor Blom a écrit : Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde plasma 5). Ihe toolbar icons are problematic, but I know how to fix that (and the oxygen set

Re: [PATCH] unique_ptr and some clean-up

Le 14/06/2016 20:55, Georg Baum a écrit : Guillaume Munch wrote: Le 14/06/2016 16:38, Jean-Marc Lasgouttes a écrit : but of course RefChange proved more difficult. I tried to define it as a subclass of unique_ptr<RevertibleRef>, but then my C++11 default skills showed their weakness.

Re: lyx and dark color schemes

Le 14/06/2016 18:44, Cor Blom a écrit : Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde plasma 5). Ihe toolbar icons are problematic, but I know how to fix that (and the oxygen set is not that bad against a dark background). In general I'm happy about it. There is one

Re: [PATCH] unique_ptr and some clean-up

Le 14/06/2016 20:16, Jean-Marc Lasgouttes a écrit : Le 14/06/16 à 18:41, Guillaume Munch a écrit : but of course RefChange proved more difficult. I tried to define it as a subclass of unique_ptr<RevertibleRef>, but then my C++11 default skills showed their weakness. What errors does i

Re: [LyX/master] Add perf comment

Le 14/06/2016 17:31, Jean-Marc Lasgouttes a écrit : Le 14/06/2016 à 18:06, Guillaume Munch a écrit : Interesting. Is it only the loop in itself that is costly, or some of the functions it calls? The combined loop and recursion, I believe. But is the usual behavior is a no-op, except

Re: [PATCH] unique_ptr and some clean-up

Le 14/06/2016 16:38, Jean-Marc Lasgouttes a écrit : Le 14/06/2016 à 16:39, Guillaume Munch a écrit : I am a little short on ideas so we could try the attached, and if it does not work try the commented version below it, and if it does not work, revert e87febd0 for the moment. What I am

Re: [LyX/master] Add perf comment

Le 14/06/2016 17:01, Jean-Marc Lasgouttes a écrit : Le 12/06/2016 à 20:23, Guillaume Munch a écrit : commit 89175ee0f10f75311e2a746dbd450fb23d6c2845 Author: Guillaume Munch <g...@lyx.org> Date: Sat Jun 11 09:14:38 2016 +0100 Add perf comment diff --git a/src/KeyMap.cpp b/src/KeyM

Re: [PATCH] unique_ptr and some clean-up

Le 14/06/2016 10:38, Jean-Marc Lasgouttes a écrit : Le 13/06/2016 à 23:15, Guillaume Munch a écrit : I am not in charge for the machines around me and given 12.04 LTS ends up 2017-04 I don't expect any migration happening soon :) I am in a similar situation (although as I said, clang works

Re: make lyxdist fails: No rule to make target 'Change.h'

Le 14/06/2016 01:25, Scott Kostyshak a écrit : On Mon, Jun 13, 2016 at 08:17:27PM -0400, Scott Kostyshak wrote: On Tue, Jun 14, 2016 at 12:22:21AM +0100, Guillaume Munch wrote: Le 14/06/2016 00:12, Scott Kostyshak a écrit : To reproduce, on a clean repo do the following: ./autogen.sh

Re: make lyxdist fails: No rule to make target 'Change.h'

Le 14/06/2016 00:12, Scott Kostyshak a écrit : To reproduce, on a clean repo do the following: ./autogen.sh && ./configure && make lyxdist I get: $ ./autogen.sh && ./configure && make lyxdist make[3]: Entering directory '/home/scott/lyxbuilds/master/repo/src/support' make[3]: *** No rule to

Re: [PATCH] unique_ptr and some clean-up

Le 13/06/2016 21:54, Pavel Sanda a écrit : Guillaume Munch wrote: Starting from 2.3, LyX will require a C++11 compiler, and g++ 4.6 fails (it seems) at a feature as elementary as generating a default move constructor, even when told so explicitly (which we cannot really blame it for, given

Re: [PATCH] unique_ptr and some clean-up

Le 13/06/2016 21:40, Stephan Witt a écrit : gcc-Version 4.4.7 20120313 (Red Hat 4.4.7-17) (GCC) IMO it’s not dead and end of life is 2020-11-30 I do not know what can be done at the LyX level for CentOS 6. It seems that it is very easy to obtain gcc 4.8 on CentOS 6 provided one has access to

Re: [PATCH] unique_ptr and some clean-up

Le 13/06/2016 20:50, Pavel Sanda a écrit : Guillaume Munch wrote: Then if we are dropping g++ 4.6, does anyone know whether it makes sense Sorry I might got lost somewhere in the threads around. What reasons do we have for dropping gcc 4.6? Starting from 2.3, LyX will require a C++11

Re: [PATCH] unique_ptr and some clean-up

Le 13/06/2016 12:53, Jean-Marc Lasgouttes a écrit : Le 13/06/2016 à 10:14, Guillaume Munch a écrit : Le 12/06/2016 09:29, Pavel Sanda a écrit : Guillaume Munch wrote: I do not clearly see the situation wrt gcc 4.6. Which are the distributions that currently lack gcc > 4.6 ? this is ubu

Re: [PATCH] unique_ptr and some clean-up

Le 12/06/2016 09:29, Pavel Sanda a écrit : Guillaume Munch wrote: I do not clearly see the situation wrt gcc 4.6. Which are the distributions that currently lack gcc > 4.6 ? this is ubuntu 12.04.p I see. I has assumed g++-4.7 was there since there is gcc-4.7. How does clang fare? it

Re: compilation for coverity fails

Le 12/06/2016 19:59, Jean-Marc Lasgouttes a écrit : Le 12/06/2016 20:53, Richard Heck a écrit : I don't think we have a definite policy, but it would be a good sort of comment to have. Coverity seems to want the comment right before the code it complains about, though, so I'm not sure this can

Re: [LyX/2.2.x] Fix compilation with Qt < 4.7

Le 12/06/2016 23:23, Richard Heck a écrit : On 06/12/2016 06:13 PM, Guillaume Munch wrote: commit e6d28aad0a6f267c5ce51c5205fdb60343a7fc90 Author: Guillaume Munch <g...@lyx.org> Date: Sat Jun 11 05:41:48 2016 +0100 Fix compilation with Qt < 4.7 Probably this should go

Re: compilation for coverity fails

Le 12/06/2016 19:39, Richard Heck a écrit : On 06/12/2016 09:17 AM, Jean-Marc Lasgouttes wrote: Le 12/06/2016 15:05, Georg Baum a écrit : If others want to join the effort please keep in mind that the goal is not to get zero coverity errors, but to fix dangerous code. So if you do not

Re: [LyX/master] unique_ptr and make_unique

Le 12/06/2016 10:23, Kornel Benko a écrit : Am Sonntag, 12. Juni 2016 um 10:25:30, schrieb Kornel Benko <kor...@lyx.org> Am Sonntag, 12. Juni 2016 um 03:25:38, schrieb Guillaume Munch <g...@lyx.org> Le 09/06/2016 15:23, Guillaume Munch a écrit : diff --git a/configure.ac b/config

Re: [LyX/master] Make the non-drawing cases faster in TextMetrics::drawParagraph

Le 30/05/2016 13:56, Jean-Marc Lasgouttes a écrit : commit fc73ebc16c4f0aca76360415a94eca57f283e44e Author: Jean-Marc Lasgouttes Date: Mon Feb 29 16:07:35 2016 +0100 Make the non-drawing cases faster in TextMetrics::drawParagraph There are two main cases:

Re: [LyX/master] unique_ptr and make_unique

Le 09/06/2016 15:23, Guillaume Munch a écrit : diff --git a/configure.ac b/configure.ac index 3353df4..52da6ce 100644 --- a/configure.ac +++ b/configure.ac @@ -130,6 +130,9 @@ AC_C_BIGENDIAN # Nice to have when an assertion triggers LYX_CHECK_CALLSTACK_PRINTING +# C++14 only +LYX_CHECK_DEF

Re: [PATCH] unique_ptr and some clean-up

Le 12/06/2016 00:58, Pavel Sanda a écrit : Guillaume Munch wrote: I do not clearly see the situation wrt gcc 4.6. Which are the distributions that currently lack gcc > 4.6 ? this is ubuntu 12.04.p I see. I has assumed g++-4.7 was there since there is gcc-4.7. How does clang fare?

Re: [PATCH] unique_ptr and some clean-up

Le 11/06/2016 21:05, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Le 07/06/2016 ?? 19:05, Guillaume Munch a écrit : It says that it picked the wrong constructor for the pair, that requires a copyable object. Which precise version of g++ 4.6 do you have? In 4.6.3 pairs accept movable

Re: What Qt Version for 2.2.x?

Le 11/06/2016 10:35, Jean-Marc Lasgouttes a écrit : I really think we can use 4.8 as minimum for 2.3 at least. Of course, the patch is for stable. Waiting Richard's reply to commit.

Re: LyX 2.2.0 Linux Compilation Error

Le 11/06/2016 06:12, Joel Kulesza a écrit : This got me well beyond the monospace issue; however, more Qt woes (which now appear to be intrinsic to Qt). See attached to avoid a long copy-and-paste. I don't understand, but try passing --disable-cxx11 to configure. Has anyone successfully

Re: [LyX/master] Fix bug #10119

Le 11/06/2016 05:44, Guillaume Munch a écrit : commit ab41c1d1ac3a54b39b7b5ba630d172ee4bd65049 Author: Guillaume Munch <g...@lyx.org> Date: Wed Jun 1 18:27:36 2016 +0100 Fix bug #10119 This makes Qt 5.4 as usable as Qt 5.5.1 in my experience. Otherwise, fix again I

Re: CMake + clang failure

Le 11/06/2016 03:00, Scott Kostyshak a écrit : -- Using GCC version 4.2.1 CMake Error at CMakeLists.txt:267 (message): gcc >= 4.3 is required. From INSTALL: First of all, you will need a recent C++ compiler, where recent means that the compilers are close to C++11 standard conforming

Re: LyX 2.2.0 Linux Compilation Error

Le 11/06/2016 04:40, Joel Kulesza a écrit : On Fri, Jun 10, 2016 at 3:56 PM, Richard Heck > wrote: You could try adding: #include to support/filetools.cpp. Richard, thanks for the *quick* reply! That worked and let make proceed beyond

Re: What Qt Version for 2.2.x?

Le 11/06/2016 05:13, Richard Heck a écrit : The INSTALL file says that one can use Qt as far back as 4.5.0. But we use QFont::Monospace in GuiApplication.cpp, and this appears not to have existed in Qt 4.6. See http://doc.qt.io/archives/4.6/qfont.html in particular, the QFont::StyleHint

Re: Tarballs for LyX 2.2.0 are on FTP

Le 08/06/2016 22:36, Liviu Andronic a écrit : On Wed, Jun 8, 2016 at 10:14 PM, Guillaume Munch <g...@lyx.org> wrote: Le 08/06/2016 20:48, Pavel Sanda a écrit : Guillaume Munch wrote: Here's what I suggest. Let's do, on a trial basis for the duration of 2.3dev, a branch that mirrors

Re: [PATCH] unique_ptr and some clean-up

Le 10/06/2016 11:19, Jean-Marc Lasgouttes a écrit : Le 07/06/2016 à 19:05, Guillaume Munch a écrit : It says that it picked the wrong constructor for the pair, that requires a copyable object. Which precise version of g++ 4.6 do you have? In 4.6.3 pairs accept movable objects. Maybe it fails

Re: changer

Le 09/06/2016 09:53, Jean-Marc Lasgouttes a écrit : Le 08/06/2016 à 01:30, Guillaume Munch a écrit : I believe clang is right and gcc is wrong. gcc treats rc as an rvalue, which makes the conversion into unique_ptr valid. But rc should not be considered as an rvalue, because the standard only

Re: changer

Le 09/06/2016 18:14, Guillaume Munch a écrit : As for unicode.cpp, the error is in gcc 4.7 as well, thanks to which I could check that it is corrected as I suggested, that is, explicitly defining the move constructor as defaulted. This departs from the specification and is very annoying

Re: changer

Le 09/06/2016 09:53, Jean-Marc Lasgouttes a écrit : Le 08/06/2016 à 01:30, Guillaume Munch a écrit : Try changing 'return rc;' to 'return std::move(rc);' (twice). Unfortunately, with Georg's recent changes, I don't think that your patches still apply. The best would be to publish the branch

Re: [PATCH] unique_ptr and some clean-up

Le 07/06/2016 15:23, Jean-Marc Lasgouttes a écrit : diff --git a/src/frontends/qt4/GuiPainter.cpp b/src/frontends/qt4/GuiPainter.cpp index 725320b..2fd2a20 100644 --- a/src/frontends/qt4/GuiPainter.cpp +++ b/src/frontends/qt4/GuiPainter.cpp @@ -29,6 +29,8 @@ #include "support/lassert.h"

Re: #10206: Problem installing Lyx 2.2

or you. Guillaume Munch

Re: unique_ptr

Le 08/06/2016 21:58, Jean-Marc Lasgouttes a écrit : Le 08/06/16 à 20:21, Guillaume Munch a écrit : I'd rather include only the standard headers to obtain unique_ptr, and then include support/make_unique.h when we explicitly need it. When you have unique_ptr, you also want to have make_unique

Re: Tarballs for LyX 2.2.0 are on FTP

Le 08/06/2016 20:57, Georg Baum a écrit : Guillaume Munch wrote: Le 07/06/2016 00:00, Richard Heck a écrit : Our use of git would make it very easy for us to have a branch in which new features not requiring format changes could also be put. This solution would be fine by me too

Re: Tarballs for LyX 2.2.0 are on FTP

Le 08/06/2016 20:48, Pavel Sanda a écrit : Guillaume Munch wrote: Here's what I suggest. Let's do, on a trial basis for the duration of 2.3dev, a branch that mirrors master but inserts patches to disable the input and output of new file-format features (as well as layout changes, etc.) after

Re: unique_ptr

Le 07/06/2016 16:32, Jean-Marc Lasgouttes a écrit : Le 07/06/2016 à 17:25, Guillaume Munch a écrit : Technically, unique_ptr.h is also useful to include . When you start using unique_ptr, you expect that you might use make_unique at some point, so you want to just include a generic header

Re: Tarballs for LyX 2.2.0 are on FTP

Le 07/06/2016 00:35, Guillaume Munch a écrit : Le 07/06/2016 00:00, Richard Heck a écrit : On 06/06/2016 06:40 PM, Guillaume Munch wrote: The point of the proposal is to enabling the early testing and release of *non-file-format* changes. Then for a proper master release only file-format

Re: changer

Le 07/06/2016 15:05, Jean-Marc Lasgouttes a écrit : Le 07/06/2016 à 09:04, Jean-Marc Lasgouttes a écrit : Le 05/06/2016 01:01, Guillaume Munch a écrit : 12. This is a new helper class that I wrote because the Changer class from MetricsInfo was too cumbersome (essentially a TeX \def

Re: [PATCH] unique_ptr and some clean-up

Le 07/06/2016 15:23, Jean-Marc Lasgouttes a écrit : Le 05/06/2016 à 01:01, Guillaume Munch a écrit : Dear List, I have recently started using c++11 features, and, one thing leading to another, some cleaning of the tree happened. Apparently most of the changes below are supported by old

Re: unique_ptr

Le 07/06/2016 07:53, Jean-Marc Lasgouttes a écrit : Le 05/06/2016 01:01, Guillaume Munch a écrit : Dear List, I have recently started using c++11 features, and, one thing leading to another, some cleaning of the tree happened. Apparently most of the changes below are supported by old

Re: changes (Re: [PATCH] unique_ptr and some clean-up)

Le 07/06/2016 08:09, Jean-Marc Lasgouttes a écrit : Le 05/06/2016 01:01, Guillaume Munch a écrit : 13. This one is more for Jean-Marc I think (but not exclusively). There are three changes detailed in the log which are a bit less important than the ones above, but for which I would nevertheless

Re: boost:regex & gcc

Le 07/06/2016 07:46, Jean-Marc Lasgouttes a écrit : Le 06/06/2016 22:43, Pavel Sanda a écrit : Guillaume Munch wrote: Any reason to want to get rid of boost completely? Well, that's a long term wish. It is not nice to pack boost lib together with our sources and someone need to care updating

Re: Tarballs for LyX 2.2.0 are on FTP

Le 07/06/2016 00:00, Richard Heck a écrit : On 06/06/2016 06:40 PM, Guillaume Munch wrote: The point of the proposal is to enabling the early testing and release of *non-file-format* changes. Then for a proper master release only file-format changes remain to be fully tested. This assumes

<    1   2   3   4   5   6   7   8   9   10   >