[patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Juergen Spitzmueller
Daniel Watkins wrote: This stops the crash, but the undo does not work perfectly. If there is a blank row at the bottom of the matrix, it is not restored. If there is more than one empty row, only the bottom one is removed, but another one is removed if the delete/undo is repeated, until there

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin A fresh patch for bug 1975, due to the boundary changes. Martin Bugzilla doesn't like me today, so attached. Martin Still no external testers found... please?!? Did this ever got applied? JMarc

TOC generation and autogen.sh

2005-10-03 Thread Angus Leeming
Georg, I realise that others have been telling you of problems with the TOC-generation stuff that you played with recently. However, I haven't noticed any messages about autogen.sh output: HTH, Angus Building Makefile templates... . Use of uninitialized value in concatenation (.) or

Re: LyX speedup patch

2005-10-03 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Yes... as it happens I was today thinking along similar lines. Martin But wouldn't it be enough to just cache, e.g., the pos of row Martin end, to determine whether the current row content changes or Martin not, and if not, skip out of

Re: Bug 2058: LyX crashes when attempting to undo matrix deletion

2005-10-03 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Georg Baum wrote: Why don't you put the code in MathNestInset? Since backspace at the first position deletes the containing inset in every math inset I think that recordUndoInset should also be called in general. Juergen Yes,

Re: [patch] fix bug 2050

2005-10-03 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg See http://bugzilla.lyx.org/show_bug.cgi?id=2050. Math mcros Georg that contain \kern are misrendered on screen. The fix is Georg obvious, and I could not reproduce the crash. I propose to put Georg this in. If the crash reappears we may find

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 11:31 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin A fresh patch for bug 1975, due to the boundary changes. Martin Bugzilla doesn't like me today, so attached. Martin Still no external testers found... please?!?

Re: LyX speedup patch

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 11:38 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin Yes... as it happens I was today thinking along similar lines. Martin But wouldn't it be enough to just cache, e.g., the pos of row Martin end, to determine whether the

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No... hanging in my tree. So, what has to be done? testing? How confident are you? JMarc

[patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
It came out that the problem is caused by refreshReadOnly(), called (indirectly) by Dialog::checkStatus(). refreshReadOnly disables all widgets (that are addReadOnly()'ed) in read only mode and enables all these widgets in non-read-only mode. The latter, which is necessary to switch modes,

Re: LyX speedup patch

2005-10-03 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: This would mean implementing SingleRow update instead of SinglePar, right? Martin Yes, I think so. How to do it is another matter. I suspect Martin that caching row.endpos() internally in lyxtext would be Martin enough. This would be almost

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen It came out that the problem is caused by refreshReadOnly(), Juergen called (indirectly) by Dialog::checkStatus(). refreshReadOnly Juergen disables all widgets (that are addReadOnly()'ed) in read only Juergen mode and enables all

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Angus Leeming
Juergen Spitzmueller wrote: It came out that the problem is caused by refreshReadOnly(), called (indirectly) by Dialog::checkStatus(). refreshReadOnly disables all widgets (that are addReadOnly()'ed) in read only mode and enables all these widgets in non-read-only mode. The latter, which is

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: Shouldn't the update be added inside the if (controller().canApply()) block? I just thought about that, too. It's certainly safer, I'll do this. Jürgen

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Juergen Comments? Shouldn't the update be added inside the if (controller().canApply()) block? Urgs. Probably :) Especially given that fact that view_.update() isn't needed for a read-only document. The looks OK. Angus? -- Angus

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: Shouldn't the update be added inside the if (controller().canApply()) block? I just thought about that, too. It's certainly safer, I'll do this. OK to apply the attached? Jürgen BTW this bug also applies to 1.3 Index: Dialog.C

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Jean-Marc Lasgouttes wrote: Shouldn't the update be added inside the if (controller().canApply()) block? Juergen I just thought about that, too. It's certainly safer, I'll do Juergen this. OK. You can apply then. JMarc

Re: LyX speedup patch

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 12:16 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: This would mean implementing SingleRow update instead of SinglePar, right? Martin Yes, I think so. How to do it is another matter. I suspect Martin that caching

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen BTW this bug also applies to 1.3 You can also apply to 1.3.x, then (after some basic testing, of course :) JMarc

[PATCH] fix macro type with math-macro

2005-10-03 Thread Jean-Marc Lasgouttes
Found this while investigating 2050/2060: when creating a macro with math-macro aa, the type is set to instead of newcommand. It is an obvious typo in the code, so I'll just commit. JMarc Index: src/ChangeLog === RCS file:

Re: [PATCH] fix macro type with math-macro

2005-10-03 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Found this while investigating 2050/2060: when creating a macro with math-macro aa, the type is set to instead of newcommand. It is an obvious typo in the code, so I'll just commit. It may be an obvious typo, but it looks to me like it should be

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: Juergen BTW this bug also applies to 1.3 You can also apply to 1.3.x, then (after some basic testing, of course Hm, things look quite a bit different there. I have to take time and look how 1.3 does what checkStatus does in 1.4 Jürgen

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No... hanging in my tree. So, what has to be done? testing? How confident are you? Pretty confident, as it appears that RtL is

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Jean-Marc Lasgouttes
Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No... hanging in my tree. So, what has to be done? testing? How confident are

Re: [PATCH] fix macro type with math-macro

2005-10-03 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus Jean-Marc Lasgouttes wrote: Found this while investigating 2050/2060: when creating a macro with math-macro aa, the type is set to instead of newcommand. It is an obvious typo in the code, so I'll just commit. Angus It may be an

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 14:00 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Martin On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: Martin == Martin Vermeer [EMAIL PROTECTED] writes: Did this ever got applied? Martin No...

Re: TOC generation and autogen.sh

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 11:37 schrieb Angus Leeming: Use of uninitialized value in concatenation (.) or string at /usr/bin/automake line 8450. : `TOCs' is a target; expected a variable lib/doc/Makefile.am:66: variable `TOCs' not defined Use of uninitialized value in concatenation (.) or

Re: [patch] fix bug 2060

2005-10-03 Thread Georg Baum
Am Sonntag, 2. Oktober 2005 23:58 schrieb Angus Leeming: I can confirm the crash but can also supply some debug info. Thanks. The reason for the crash is the same as # 2060: MathNestInsets may have 0 cells. Fix attached. OK to commit? And the fix for # 2060? Georg PS: Daniel, many thanks

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 09:56 schrieb Juergen Spitzmueller: This is a separate bug (# 2067 now). The bug is actually not in undo, but in MathGridInset::write. This means that a matrix with several empty rows is also exported to LaTeX incorrectly, because the end-of-line command was not

Re: [patch] fix bug 2060

2005-10-03 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg See http://bugzilla.lyx.org/show_bug.cgi?id=2060. The problem Georg is that macros with no arguments are stored as a MathNestInset Georg with 0 cells, and that MathNestInset::editXY() assumes at least Georg one cell. I fixed that and added two

Re: Bug 2057: Delete key acting unexpectedly in MathEd

2005-10-03 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Jean-Marc Lasgouttes wrote: Yes, we shall remove          cmd = FuncRequest(LFUN_FINISHED_LEFT);          cur.undispatched(); Juergen OK. Do you happen to have a

Re: [patch] fix bug 2060

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 14:22 schrieb Jean-Marc Lasgouttes: Should some of these tests be asserts? If you can assure me that drawSelection() and cursorPos() don't get called for macros with 0 arguments and macros with 0 arguments are the only case of a MathNestInset, then yes. Otherwise we

Re: relyx inserts spaces in tables imported from LaTeX

2005-10-03 Thread Jean-Marc Lasgouttes
John == John Mongan [EMAIL PROTECTED] writes: John I believe this problem can be fixed in the BasicLyx.pm module of John reLyX by defining each new cell to be the start of a paragraph, John so that the subsequent Text will have it's leading white-space John zapped. This can be accomplished as

Re: CVS lyx and noweb2lyx?

2005-10-03 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg Jean-Marc Lasgouttes wrote: We should see what reLyX did and port that to tex2lyx, then. Georg I did that (at least partially). It works well with the example Georg file. Georg Is it OK to apply? The use of the tex parser is indeed a bit

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Juergen Spitzmueller
Georg Baum wrote: Unfortunately not :-( I changed the math parser some time ago to ignore the last row if it is empty (see delEmptyLastRow). This is needed for arrays with hlines after the last row. If something has to be changed, then in the math parser (e.g. one could only ignore the empty

Re: [patch] fix bug 2060

2005-10-03 Thread Juergen Spitzmueller
Georg Baum wrote: PS: Daniel, many thanks for the bug reports. They are really useful. I have to second that. Jürgen

Re: TOC generation and autogen.sh

2005-10-03 Thread Angus Leeming
Georg Baum wrote: Am Montag, 3. Oktober 2005 11:37 schrieb Angus Leeming: Use of uninitialized value in concatenation (.) or string at /usr/bin/automake line 8450. : `TOCs' is a target; expected a variable lib/doc/Makefile.am:66: variable `TOCs' not defined Use of uninitialized value in

Re: [patch] fix bug 2060

2005-10-03 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg Am Montag, 3. Oktober 2005 14:22 schrieb Jean-Marc Lasgouttes: Should some of these tests be asserts? Georg If you can assure me that drawSelection() and cursorPos() don't Georg get called for macros with 0 arguments and macros with 0 Georg

[PATCH] bug 2063: Spellcheck doesn't check word containing the cursor

2005-10-03 Thread Jean-Marc Lasgouttes
Here is a simple fix. Instead of going forward to put the cursor at beginning of next word, we go backward to the beginning of current word. Bennett, please test. JMarc Index: src/frontends/controllers/ChangeLog === RCS file:

Re: [PATCH] bug 2063: Spellcheck doesn't check word containing the cursor

2005-10-03 Thread Bennett Helm
On Oct 3, 2005, at 9:53 AM, Jean-Marc Lasgouttes wrote: Here is a simple fix. Instead of going forward to put the cursor at beginning of next word, we go backward to the beginning of current word. Bennett, please test. Works for me. Bennett

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 14:53 schrieb Juergen Spitzmueller: Georg Baum wrote: Unfortunately not :-( I changed the math parser some time ago to ignore the last row if it is empty (see delEmptyLastRow). This is needed for arrays with hlines after the last row. If something has to be

Re: lyx-devel lib/: Tag: BRANCH_1_3_X CREDITS ChangeLog

2005-10-03 Thread Angus Leeming
[EMAIL PROTECTED] wrote: CVSROOT: /usr/local/lyx/cvsroot Module name: lyx-devel Repository: lyx-devel/lib/ Changes by: [EMAIL PROTECTED]05/10/03 17:36:51 Modified files: lyx-devel/lib/: Tag: BRANCH_1_3_X CREDITS ChangeLog Log message: Dr. Schmitt became Mr. Gerz

Itemize inside a thanks footnote

2005-10-03 Thread Charles de Miramon
Hello, I've just found this bug (well it is more a LaTeX weakness) inside 1.3.6 and I was wondering if it has been corrected in 1.4.0 before opening a bug report. 1) Create an article 2) Create a title and a footnote (\thanks) 3) Inside the thanks footnote create a bullet list 4) the generated

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Juergen Spitzmueller
Georg Baum wrote: Yes, although my first thought was wrong. Actually the patch is almost right, but it fails if you have a row with extra space (\\[2mm]). Although there is no GUI for the latter and it is not documented, we should get this right. OK. I am working on this now (unfortunately

Debugging Output

2005-10-03 Thread Daniel Watkins
In one of the bugs I reported, I failed to get any CLI output at all, while Angus managed to get a whole heap of stuff. How can I go about getting the largest quantity of useful debugging info? ATM, I have stdlib debugging disabled, which may be the cause. However, it seems unlikely. Is there a

Re: Debugging Output

2005-10-03 Thread Angus Leeming
Daniel Watkins wrote: In one of the bugs I reported, I failed to get any CLI output at all, while Angus managed to get a whole heap of stuff. How can I go about getting the largest quantity of useful debugging info? ATM, I have stdlib debugging disabled, which may be the cause. However, it

Bug 2069: Movement out of sub/superscript works unexpectedly

2005-10-03 Thread Daniel Watkins
And now, ladies and gentlemen, we return you to your regular programming. A MathEd bug! Bug 2069: Movement out of sub/superscript works unexpectedly Description: When, at the leftmost end of the sub/superscript, you press left or, at any point in the sub/superscript, you press up/down

Re: Bug 2069: Movement out of sub/superscript works unexpectedly

2005-10-03 Thread Juergen Spitzmueller
Daniel Watkins wrote: If anyone can think of a word which refers to subscripts and superscripts collectively, that bug report would be much more readable. :P script insets ;-) BTW I didn't understand the report. Jürgen

Re: LyX speedup patch

2005-10-03 Thread Andre Poenitz
On Sun, Oct 02, 2005 at 05:59:38PM +0300, Martin Vermeer wrote: On Sun, Oct 02, 2005 at 01:26:06PM +0200, Andre Poenitz wrote: ... So we should try hard to pass through the critical path just once. I'll send later today a preliminary patch that folds rowBreakPoint() and

Re: [patches 13x, 14x] wrappers for ShGetFolderPath, GetLongPathName

2005-10-03 Thread Andre Poenitz
On Sun, Oct 02, 2005 at 06:19:34PM +0100, Angus Leeming wrote: Andre Poenitz wrote: Right, but we'll need to patch our qt frontend source code to use Qt4, no? 'patch' would be a proper British understatement. 'rework' would be closer in a continental climate. Really? I've been

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Andre Poenitz
On Mon, Oct 03, 2005 at 09:56:09AM +0200, Juergen Spitzmueller wrote: Does this look sensible? Jürgen P.S.: the context of the changes: void MathGridInset::write(WriteStream os) const { [...] string const s = verboseHLine(rowinfo_[nrows()].lines_); if (!s.empty() s !=

Re: Bug 2069: Movement out of sub/superscript works unexpectedly

2005-10-03 Thread Andre Poenitz
On Mon, Oct 03, 2005 at 06:38:26PM +0100, Daniel Watkins wrote: And now, ladies and gentlemen, we return you to your regular programming. A MathEd bug! Did I mention that I feel a bit humilitated by your recent activities? But lucky me there are a few people out there trying to cover my

Re: [patch] fix bug 2060

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 15:04 schrieb Jean-Marc Lasgouttes: What I wondering is whether MathNestInset should tell the world that it is not editable when size() == 0. It is always strange to have to add these tests all over the place. I agree, but after trying to implement that I found out

Re: [patch] fix bug 2060

2005-10-03 Thread Andre Poenitz
On Mon, Oct 03, 2005 at 02:30:10PM +0200, Georg Baum wrote: Am Montag, 3. Oktober 2005 14:22 schrieb Jean-Marc Lasgouttes: Should some of these tests be asserts? If you can assure me that drawSelection() and cursorPos() don't get called for macros with 0 arguments and macros with 0

Re: TOC generation and autogen.sh

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 14:51 schrieb Angus Leeming: I also note that it's an old version of automake (1.6) although autogen.sh is currently set up to accept it. OK, by typing apt-get install automake1.6 update-alternatives --set automake /usr/bin/automake-1.6 I switched to automake 1.6

Re: TOC generation and autogen.sh

2005-10-03 Thread Angus Leeming
Georg Baum wrote: Am Montag, 3. Oktober 2005 14:51 schrieb Angus Leeming: I also note that it's an old version of automake (1.6) although autogen.sh is currently set up to accept it. OK, by typing apt-get install automake1.6 update-alternatives --set automake /usr/bin/automake-1.6

MathEd bug related to 2050/60 (?)

2005-10-03 Thread Daniel Watkins
Hey guys, I'm completely confused by which bug covers what, so I'll tell you the bug and hopefully someone will tell me what's going on. :p Summary: Arrows with curves in display incorrectly/crash LyX Any of the \hook arrows don't display correctly when typed and, when clicked upon within the

Re: TOC generation and autogen.sh

2005-10-03 Thread Kayvan A. Sylvan
On Mon, Oct 03, 2005 at 07:46:38PM +0200, Georg Baum wrote: Am Montag, 3. Oktober 2005 14:51 schrieb Angus Leeming: I also note that it's an old version of automake (1.6) although autogen.sh is currently set up to accept it. OK, by typing apt-get install automake1.6

Latest CVS: make rpmdist fails

2005-10-03 Thread Kayvan A. Sylvan
config.status: creating development/lyx.spec config.status: creating lib/Makefile config.status: creating lib/doc/Makefile config.status: error: cannot find input file: lib/doc/Makefile.in error: Bad exit status from /var/tmp/rpm-tmp.95005 (%build) RPM build errors: Bad exit status from

Re: relyx inserts spaces in tables imported from LaTeX

2005-10-03 Thread John Mongan
Jean-Marc Lasgouttes wrote: John == John Mongan [EMAIL PROTECTED] writes: John I believe this problem can be fixed in the BasicLyx.pm module of John reLyX by defining each new cell to be the start of a paragraph, John so that the subsequent Text will have it's leading white-space John

[patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Juergen Spitzmueller
Daniel Watkins wrote: > This stops the crash, but the undo does not work perfectly. If there is a > blank row at the bottom of the matrix, it is not restored. If there is more > than one empty row, only the bottom one is removed, but another one is > removed if the delete/undo is repeated, until

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> A fresh patch for bug 1975, due to the boundary changes. Martin> Bugzilla doesn't like me today, so attached. Martin> Still no external testers found... please?!? Did this ever got applied? JMarc

TOC generation and autogen.sh

2005-10-03 Thread Angus Leeming
Georg, I realise that others have been telling you of problems with the TOC-generation stuff that you played with recently. However, I haven't noticed any messages about autogen.sh output: HTH, Angus Building Makefile templates... . Use of uninitialized value in concatenation (.) or

Re: LyX speedup patch

2005-10-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Yes... as it happens I was today thinking along similar lines. Martin> But wouldn't it be enough to just cache, e.g., the pos of row Martin> end, to determine whether the current row content changes or Martin> not, and if not,

Re: Bug 2058: LyX crashes when attempting to undo matrix deletion

2005-10-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Georg Baum wrote: >> Why don't you put the code in MathNestInset? Since backspace at the >> first position deletes the containing inset in every math inset I >> think that recordUndoInset should also be called in

Re: [patch] fix bug 2050

2005-10-03 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> See http://bugzilla.lyx.org/show_bug.cgi?id=2050. Math mcros Georg> that contain \kern are misrendered on screen. The fix is Georg> obvious, and I could not reproduce the crash. I propose to put Georg> this in. If the crash reappears

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 11:31 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> A fresh patch for bug 1975, due to the boundary changes. > > Martin> Bugzilla doesn't like me today, so attached. > > Martin> Still no external testers

Re: LyX speedup patch

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 11:38 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Yes... as it happens I was today thinking along similar lines. > Martin> But wouldn't it be enough to just cache, e.g., the pos of row > Martin> end, to

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Did this ever got applied? Martin> No... hanging in my tree. So, what has to be done? testing? How confident are you? JMarc

[patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
It came out that the problem is caused by refreshReadOnly(), called (indirectly) by Dialog::checkStatus(). refreshReadOnly disables all widgets (that are addReadOnly()'ed) in read only mode and enables all these widgets in non-read-only mode. The latter, which is necessary to switch modes,

Re: LyX speedup patch

2005-10-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> This would mean implementing SingleRow update instead of >> SinglePar, right? Martin> Yes, I think so. How to do it is another matter. I suspect Martin> that caching row.endpos() internally in lyxtext would be Martin> enough. This

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> It came out that the problem is caused by refreshReadOnly(), Juergen> called (indirectly) by Dialog::checkStatus(). refreshReadOnly Juergen> disables all widgets (that are addReadOnly()'ed) in read only Juergen> mode and

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Angus Leeming
Juergen Spitzmueller wrote: > It came out that the problem is caused by refreshReadOnly(), called > (indirectly) by Dialog::checkStatus(). refreshReadOnly disables all > widgets (that are addReadOnly()'ed) in read only mode and enables > all these widgets in non-read-only mode. The latter, which

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Shouldn't the update be added inside the > "if (controller().canApply())" block? I just thought about that, too. It's certainly safer, I'll do this. Jürgen

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Juergen> Comments? > > Shouldn't the update be added inside the > "if (controller().canApply())" block? Urgs. Probably :) Especially given that fact that view_.update() isn't needed for a read-only document. > The looks OK. Angus? -- Angus

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > > Shouldn't the update be added inside the > > "if (controller().canApply())" block? > > I just thought about that, too. It's certainly safer, I'll do this. OK to apply the attached? Jürgen BTW this bug also applies to 1.3 Index: Dialog.C

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Shouldn't the update be added inside the "if >> (controller().canApply())" block? Juergen> I just thought about that, too. It's certainly safer, I'll do Juergen> this. OK. You can apply

Re: LyX speedup patch

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 12:16 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> This would mean implementing SingleRow update instead of > >> SinglePar, right? > > Martin> Yes, I think so. How to do it is another matter. I suspect > Martin>

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> BTW this bug also applies to 1.3 You can also apply to 1.3.x, then (after some basic testing, of course :) JMarc

[PATCH] fix macro type with math-macro

2005-10-03 Thread Jean-Marc Lasgouttes
Found this while investigating 2050/2060: when creating a macro with "math-macro aa", the type is set to "" instead of "newcommand". It is an obvious typo in the code, so I'll just commit. JMarc Index: src/ChangeLog === RCS file:

Re: [PATCH] fix macro type with math-macro

2005-10-03 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Found this while investigating 2050/2060: when creating a macro with > "math-macro aa", the type is set to "" instead of "newcommand". > > It is an obvious typo in the code, so I'll just commit. It may be an obvious typo, but it looks to me like it should be

Re: [patch] bug 1894: Disabling of widgets broken

2005-10-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> BTW this bug also applies to 1.3 > > You can also apply to 1.3.x, then (after some basic testing, of course Hm, things look quite a bit different there. I have to take time and look how 1.3 does what checkStatus does in 1.4 Jürgen

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Did this ever got applied? > > Martin> No... hanging in my tree. > > So, what has to be done? testing? How confident are you? Pretty confident, as it appears

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> Did this ever got applied? >> Martin> No... hanging in my tree. >> So, what has to be

Re: [PATCH] fix macro type with math-macro

2005-10-03 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: >> Found this while investigating 2050/2060: when creating a macro >> with "math-macro aa", the type is set to "" instead of >> "newcommand". >> >> It is an obvious typo in the code, so I'll just

Re: Hebrew/bidi bug 1975

2005-10-03 Thread Martin Vermeer
On Mon, 2005-10-03 at 14:00 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Mon, 2005-10-03 at 12:08 +0200, Jean-Marc Lasgouttes wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> Did this ever

Re: TOC generation and autogen.sh

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 11:37 schrieb Angus Leeming: > Use of uninitialized value in concatenation (.) or string > at /usr/bin/automake line 8450. > : `TOCs' is a target; expected a variable > lib/doc/Makefile.am:66: variable `TOCs' not defined > Use of uninitialized value in concatenation (.)

Re: [patch] fix bug 2060

2005-10-03 Thread Georg Baum
Am Sonntag, 2. Oktober 2005 23:58 schrieb Angus Leeming: > I can confirm the crash but can also supply some debug info. Thanks. The reason for the crash is the same as # 2060: MathNestInsets may have 0 cells. Fix attached. OK to commit? And the fix for # 2060? Georg PS: Daniel, many thanks

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 09:56 schrieb Juergen Spitzmueller: > This is a separate bug (# 2067 now). The bug is actually not in undo, but in > MathGridInset::write. This means that a matrix with several empty rows is > also exported to LaTeX incorrectly, because the end-of-line command was

Re: [patch] fix bug 2060

2005-10-03 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> See http://bugzilla.lyx.org/show_bug.cgi?id=2060. The problem Georg> is that macros with no arguments are stored as a MathNestInset Georg> with 0 cells, and that MathNestInset::editXY() assumes at least Georg> one cell. I fixed that

Re: Bug 2057: Delete key acting unexpectedly in MathEd

2005-10-03 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >>> Yes, we shall remove >>> >>>          cmd = FuncRequest(LFUN_FINISHED_LEFT);         >>>  cur.undispatched();

Re: [patch] fix bug 2060

2005-10-03 Thread Georg Baum
Am Montag, 3. Oktober 2005 14:22 schrieb Jean-Marc Lasgouttes: > Should some of these tests be asserts? If you can assure me that drawSelection() and cursorPos() don't get called for macros with 0 arguments and macros with 0 arguments are the only case of a MathNestInset, then yes. Otherwise

Re: relyx inserts spaces in tables imported from LaTeX

2005-10-03 Thread Jean-Marc Lasgouttes
> "John" == John Mongan <[EMAIL PROTECTED]> writes: John> I believe this problem can be fixed in the BasicLyx.pm module of John> reLyX by defining each new cell to be the start of a paragraph, John> so that the subsequent Text will have it's leading white-space John> zapped. This can be

Re: CVS lyx and noweb2lyx?

2005-10-03 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> We should see what reLyX did and port that to tex2lyx, then. Georg> I did that (at least partially). It works well with the example Georg> file. Georg> Is it OK to apply? The use of the tex parser is

Re: [patch] Bug 2067 (was: Re: [Bug 2058] LyX crashes when attempting to undo matrix deletion)

2005-10-03 Thread Juergen Spitzmueller
Georg Baum wrote: > Unfortunately not :-( I changed the math parser some time ago to ignore > the last row if it is empty (see delEmptyLastRow). This is needed for > arrays with hlines after the last row. > If something has to be changed, then in the math parser (e.g. one could > only ignore the

Re: [patch] fix bug 2060

2005-10-03 Thread Juergen Spitzmueller
Georg Baum wrote: > PS: Daniel, many thanks for the bug reports. They are really useful. I have to second that. Jürgen

Re: TOC generation and autogen.sh

2005-10-03 Thread Angus Leeming
Georg Baum wrote: > Am Montag, 3. Oktober 2005 11:37 schrieb Angus Leeming: > >> Use of uninitialized value in concatenation (.) or string >> at /usr/bin/automake line 8450. >> : `TOCs' is a target; expected a variable >> lib/doc/Makefile.am:66: variable `TOCs' not defined >> Use of

Re: [patch] fix bug 2060

2005-10-03 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Am Montag, 3. Oktober 2005 14:22 schrieb Jean-Marc Lasgouttes: >> Should some of these tests be asserts? Georg> If you can assure me that drawSelection() and cursorPos() don't Georg> get called for macros with 0 arguments and macros

[PATCH] bug 2063: Spellcheck doesn't check word containing the cursor

2005-10-03 Thread Jean-Marc Lasgouttes
Here is a simple fix. Instead of going forward to put the cursor at beginning of next word, we go backward to the beginning of current word. Bennett, please test. JMarc Index: src/frontends/controllers/ChangeLog === RCS file:

Re: [PATCH] bug 2063: Spellcheck doesn't check word containing the cursor

2005-10-03 Thread Bennett Helm
On Oct 3, 2005, at 9:53 AM, Jean-Marc Lasgouttes wrote: Here is a simple fix. Instead of going forward to put the cursor at beginning of next word, we go backward to the beginning of current word. Bennett, please test. Works for me. Bennett

  1   2   >