Re: r35861 - lyx-devel/trunk/development/coding

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 06:53 AM, v...@lyx.org wrote: Author: vfr Date: Wed Oct 27 06:53:27 2010 New Revision: 35861 URL: http://www.lyx.org/trac/changeset/35861 Log: Add a lyx-file version of the files: Rules and Recommendations. We might get this document a bit up-to-date. Very nice initiative!

Re: iPad?

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 07:50 AM, Vincent van Ravesteijn wrote: For some numbers a glimpse of the old battles: http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg126692.html I am surprised this was only three years ago. Andre', feeling younger suddenly. Ah, we didn't have those in-depth

Re: iPad?

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 09:42 AM, Vincent van Ravesteijn wrote: Guess what? You fix it and all InsetDialog based dialogs will be fixed :-P Abdel. I guessed something different. Something like that the author of the InsetDialog class would increment the beauty of his design to such a level that

Re: iPad?

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 07:50 AM, Vincent van Ravesteijn wrote: For some numbers a glimpse of the old battles: http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg126692.html I am surprised this was only three years ago. Andre', feeling younger suddenly. Ah, we didn't have those in-depth

Re: r35845 - in lyx-devel/trunk/src: . insets

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 06:22 AM, Vincent van Ravesteijn wrote: If we are going to use dynamic casting in core code I suggest that we do that fully and remove our own implementation of that (asInsetCommand(), asInsetMath(), etc)... Yes, ok. I hope you agree with my log message in

Re: r35714 - lyx-devel/trunk/src/frontends/qt4

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 06:34 AM, Vincent van Ravesteijn wrote: I did something like this for Buffer::loadLyxFile(). Where would you advice to put the UI then ? I can now spit out a lot of error messages according to the number the functions comes up with. In Buffer ? In buffer_funcs ? In GuiView ?

Re: r35861 - lyx-devel/trunk/development/coding

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 06:53 AM, v...@lyx.org wrote: Author: vfr Date: Wed Oct 27 06:53:27 2010 New Revision: 35861 URL: http://www.lyx.org/trac/changeset/35861 Log: Add a lyx-file version of the files: Rules and Recommendations. We might get this document a bit up-to-date. Very nice initiative!

Re: iPad?

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 07:50 AM, Vincent van Ravesteijn wrote: For some numbers a glimpse of the old battles: http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg126692.html I am surprised this was only three years ago. Andre', feeling younger suddenly. Ah, we didn't have those in-depth

Re: iPad?

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 09:42 AM, Vincent van Ravesteijn wrote: Guess what? You fix it and all InsetDialog based dialogs will be fixed :-P Abdel. I guessed something different. Something like that the author of the InsetDialog class would increment the beauty of his design to such a level that

Re: iPad?

2010-10-27 Thread Abdelrazak Younes
On 10/27/2010 07:50 AM, Vincent van Ravesteijn wrote: For some numbers a glimpse of the old battles: http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg126692.html I am surprised this was only three years ago. Andre', feeling younger suddenly. Ah, we didn't have those in-depth

Re: r35845 - in lyx-devel/trunk/src: . insets

2010-10-26 Thread Abdelrazak Younes
On 10/26/2010 01:20 AM, v...@lyx.org wrote: Author: vfr Date: Tue Oct 26 01:20:05 2010 New Revision: 35845 URL: http://www.lyx.org/trac/changeset/35845 Log: We don't want InsetCommand to have a function updateCommand while this is not a special function of an InsetCommand, but only

Re: Inset handling question

2010-10-26 Thread Abdelrazak Younes
On 10/26/2010 02:40 AM, Uwe Stöhr wrote: In order to fix http://www.lyx.org/trac/ticket/6585 I need to check in InsetTabular if the table is inside a float. i thought I can do this by iterating the insets starting with the table inset down to the outer insets. if one of the outer insets is a

Re: r35845 - in lyx-devel/trunk/src: . insets

2010-10-26 Thread Abdelrazak Younes
On 10/26/2010 01:20 AM, v...@lyx.org wrote: Author: vfr Date: Tue Oct 26 01:20:05 2010 New Revision: 35845 URL: http://www.lyx.org/trac/changeset/35845 Log: We don't want InsetCommand to have a function updateCommand while this is not a special function of an InsetCommand, but only

Re: Inset handling question

2010-10-26 Thread Abdelrazak Younes
On 10/26/2010 02:40 AM, Uwe Stöhr wrote: In order to fix http://www.lyx.org/trac/ticket/6585 I need to check in InsetTabular if the table is inside a float. i thought I can do this by iterating the insets starting with the table inset down to the outer insets. if one of the outer insets is a

Re: iPad?

2010-10-25 Thread Abdelrazak Younes
On 10/24/2010 07:53 PM, Richard Heck wrote: On 10/24/2010 12:31 PM, David Whetstone wrote: Hi, I'm new here. I only recently joined this list. I've recently acquired an iPad, and found myself wanting to be able to take notes with embedded equations and such. AFAICT, no such app yet exists.

Re: iPad?

2010-10-25 Thread Abdelrazak Younes
On 10/25/2010 01:51 PM, Richard Heck wrote: On 10/25/2010 03:52 AM, Abdelrazak Younes wrote: On 10/24/2010 07:53 PM, Richard Heck wrote: On 10/24/2010 12:31 PM, David Whetstone wrote: Hi, I'm new here. I only recently joined this list. I've recently acquired an iPad, and found myself

Re: iPad?

2010-10-25 Thread Abdelrazak Younes
On 10/24/2010 07:53 PM, Richard Heck wrote: On 10/24/2010 12:31 PM, David Whetstone wrote: Hi, I'm new here. I only recently joined this list. I've recently acquired an iPad, and found myself wanting to be able to take notes with embedded equations and such. AFAICT, no such app yet exists.

Re: iPad?

2010-10-25 Thread Abdelrazak Younes
On 10/25/2010 01:51 PM, Richard Heck wrote: On 10/25/2010 03:52 AM, Abdelrazak Younes wrote: On 10/24/2010 07:53 PM, Richard Heck wrote: On 10/24/2010 12:31 PM, David Whetstone wrote: Hi, I'm new here. I only recently joined this list. I've recently acquired an iPad, and found myself

Re: switch mouse to busy symbol

2010-10-23 Thread Abdelrazak Younes
On 23/10/2010 18:21, Edwin Leuven wrote: Peter Kuemmel committed: http://www.lyx.org/trac/changeset/35795 peter, after your commit, how easy would it be to change the mouse cursor to Qt::PointingHandCursor when hovering a clickable inset? Quite easy actually but nothing to do

Re: switch mouse to busy symbol

2010-10-23 Thread Abdelrazak Younes
On 23/10/2010 21:42, Peter Kümmel wrote: Am Samstag, den 23.10.2010, 18:21 +0200 schrieb Edwin Leuven: Peter Kuemmel committed: http://www.lyx.org/trac/changeset/35795 peter, after your commit, how easy would it be to change the mouse cursor to Qt::PointingHandCursor when

Re: switch mouse to busy symbol

2010-10-23 Thread Abdelrazak Younes
On 23/10/2010 18:21, Edwin Leuven wrote: Peter Kuemmel committed: http://www.lyx.org/trac/changeset/35795 peter, after your commit, how easy would it be to change the mouse cursor to Qt::PointingHandCursor when hovering a clickable inset? Quite easy actually but nothing to do

Re: switch mouse to busy symbol

2010-10-23 Thread Abdelrazak Younes
On 23/10/2010 21:42, Peter Kümmel wrote: Am Samstag, den 23.10.2010, 18:21 +0200 schrieb Edwin Leuven: Peter Kuemmel committed: http://www.lyx.org/trac/changeset/35795 peter, after your commit, how easy would it be to change the mouse cursor to Qt::PointingHandCursor when

Re: #6710: table dialog broken

2010-10-22 Thread Abdelrazak Younes
On 10/22/2010 03:25 AM, LyX Ticket Tracker wrote: #6710: table dialog broken --+- Reporter: uwestoehr |Owner: nob...@… Type: defect| Status: closed Priority: high |

Re: #6710: table dialog broken

2010-10-22 Thread Abdelrazak Younes
On 10/22/2010 03:25 AM, LyX Ticket Tracker wrote: #6710: table dialog broken --+- Reporter: uwestoehr |Owner: nob...@… Type: defect| Status: closed Priority: high |

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

2010-10-20 Thread Abdelrazak Younes
On 10/20/2010 10:37 AM, Andre Poenitz wrote: On Wed, Oct 20, 2010 at 03:54:03AM +0200, Peter Kümmel wrote: I think what's happening is this. If you export pdf (say) without there already being a pdf file there, then everything is fine. But if the pdf file exists, then LyX will try

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

2010-10-20 Thread Abdelrazak Younes
On 20/10/2010 13:51, Richard Heck wrote: On 10/20/2010 04:37 AM, Andre Poenitz wrote: On Wed, Oct 20, 2010 at 03:54:03AM +0200, Peter Kümmel wrote: I think what's happening is this. If you export pdf (say) without there already being a pdf file there, then everything is fine. But if the pdf

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

2010-10-20 Thread Abdelrazak Younes
On 10/20/2010 10:37 AM, Andre Poenitz wrote: On Wed, Oct 20, 2010 at 03:54:03AM +0200, Peter Kümmel wrote: I think what's happening is this. If you export pdf (say) without there already being a pdf file there, then everything is fine. But if the pdf file exists, then LyX will try

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

2010-10-20 Thread Abdelrazak Younes
On 20/10/2010 13:51, Richard Heck wrote: On 10/20/2010 04:37 AM, Andre Poenitz wrote: On Wed, Oct 20, 2010 at 03:54:03AM +0200, Peter Kümmel wrote: I think what's happening is this. If you export pdf (say) without there already being a pdf file there, then everything is fine. But if the pdf

Re: r35637 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:27, rgh...@lyx.org wrote: Author: rgheck Date: Wed Oct 13 20:27:40 2010 New Revision: 35637 URL: http://www.lyx.org/trac/changeset/35637 Log: Why have an argument in an anonymous method if you aren't going to use it? unfinished iterative cleanups... Good that you add

Re: r35634 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:06, rgh...@lyx.org wrote: Author: rgheck Date: Wed Oct 13 20:06:01 2010 New Revision: 35634 URL: http://www.lyx.org/trac/changeset/35634 Log: The inset DOES know what kind of update is needed, and it is supposed to be telling us. I'm not sure why this wasn't being used any

Re: r35635 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:19, rgh...@lyx.org wrote: Why isn't there any documenation here? This is becoming a mantra, the LyX mantra! Abdel.

Re: r35638 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:30, rgh...@lyx.org wrote: Author: rgheck Date: Wed Oct 13 20:30:37 2010 New Revision: 35638 URL: http://www.lyx.org/trac/changeset/35638 Log: Anonymize some things. Not needed if the function is static; but it does not hurt of course. Abdel.

Re: r35639 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 21:35, Jean-Marc Lasgouttes wrote: Le 13 oct. 10 à 20:53, rgh...@lyx.org a écrit : Author: rgheck Date: Wed Oct 13 20:53:41 2010 New Revision: 35639 URL: http://www.lyx.org/trac/changeset/35639 Log: Change how some of the updating stuff is handled in lyxfind. I had no idea what a

Re: r35639 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 14/10/2010 19:20, Richard Heck wrote: On 10/14/2010 12:52 PM, Abdelrazak Younes wrote: On 13/10/2010 21:35, Jean-Marc Lasgouttes wrote: Le 13 oct. 10 à 20:53, rgh...@lyx.org a écrit : Author: rgheck Date: Wed Oct 13 20:53:41 2010 New Revision: 35639 URL: http://www.lyx.org/trac/changeset

Re: r35637 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:27, rgh...@lyx.org wrote: Author: rgheck Date: Wed Oct 13 20:27:40 2010 New Revision: 35637 URL: http://www.lyx.org/trac/changeset/35637 Log: Why have an argument in an anonymous method if you aren't going to use it? unfinished iterative cleanups... Good that you add

Re: r35634 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:06, rgh...@lyx.org wrote: Author: rgheck Date: Wed Oct 13 20:06:01 2010 New Revision: 35634 URL: http://www.lyx.org/trac/changeset/35634 Log: The inset DOES know what kind of update is needed, and it is supposed to be telling us. I'm not sure why this wasn't being used any

Re: r35635 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:19, rgh...@lyx.org wrote: Why isn't there any documenation here? This is becoming a mantra, the LyX mantra! Abdel.

Re: r35638 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 20:30, rgh...@lyx.org wrote: Author: rgheck Date: Wed Oct 13 20:30:37 2010 New Revision: 35638 URL: http://www.lyx.org/trac/changeset/35638 Log: Anonymize some things. Not needed if the function is static; but it does not hurt of course. Abdel.

Re: r35639 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 13/10/2010 21:35, Jean-Marc Lasgouttes wrote: Le 13 oct. 10 à 20:53, rgh...@lyx.org a écrit : Author: rgheck Date: Wed Oct 13 20:53:41 2010 New Revision: 35639 URL: http://www.lyx.org/trac/changeset/35639 Log: Change how some of the updating stuff is handled in lyxfind. I had no idea what a

Re: r35639 - lyx-devel/trunk/src

2010-10-14 Thread Abdelrazak Younes
On 14/10/2010 19:20, Richard Heck wrote: On 10/14/2010 12:52 PM, Abdelrazak Younes wrote: On 13/10/2010 21:35, Jean-Marc Lasgouttes wrote: Le 13 oct. 10 à 20:53, rgh...@lyx.org a écrit : Author: rgheck Date: Wed Oct 13 20:53:41 2010 New Revision: 35639 URL: http://www.lyx.org/trac/changeset

Re: #6920: Bug in typing a period (or comma) after the word fine.

2010-10-13 Thread Abdelrazak Younes
On 10/12/2010 05:34 PM, Jean-Marc Lasgouttes wrote: Le 11 oct. 10 à 23:59, Pavel Sanda a écrit : John Mac wrote: How do you enable / disable ligatures onscreen? i dont think we can order qt for (not) doing this. but you can try to find some font which is not intelligent enough (if you find

Re: #6920: Bug in typing a period (or comma) after the word "fine."

2010-10-13 Thread Abdelrazak Younes
On 10/12/2010 05:34 PM, Jean-Marc Lasgouttes wrote: Le 11 oct. 10 à 23:59, Pavel Sanda a écrit : John Mac wrote: How do you enable / disable ligatures onscreen? i dont think we can order qt for (not) doing this. but you can try to find some font which is not intelligent enough (if you find

Re: #6920: Bug in typing a period (or comma) after the word fine.

2010-10-12 Thread Abdelrazak Younes
On 10/11/2010 11:59 PM, Pavel Sanda wrote: John Mac wrote: How do you enable / disable ligatures onscreen? i dont think we can order qt for (not) doing this. Of course we can. It is just a matter of painting character by character instead of by word. If you know a bit of C++,

Re: #6920: Bug in typing a period (or comma) after the word "fine."

2010-10-12 Thread Abdelrazak Younes
On 10/11/2010 11:59 PM, Pavel Sanda wrote: John Mac wrote: How do you enable / disable ligatures onscreen? i dont think we can order qt for (not) doing this. Of course we can. It is just a matter of painting character by character instead of by word. If you know a bit of C++,

Re: r35575 - lyx-devel/trunk/src

2010-10-09 Thread Abdelrazak Younes
On 08/10/2010 15:58, Edwin Leuven wrote: Pavel Sandasa...@lyx.org wrote: this makes big sense and was already proposed by Abdel. i always like abdel's ideas... Thanks ;-) The advantage of git (or any other distributed vcs) is of course that you don't need a server. The full

Re: r35575 - lyx-devel/trunk/src

2010-10-09 Thread Abdelrazak Younes
On 08/10/2010 15:58, Edwin Leuven wrote: Pavel Sanda wrote: this makes big sense and was already proposed by Abdel. i always like abdel's ideas... Thanks ;-) The advantage of git (or any other distributed vcs) is of course that you don't need a server. The

Re: Fwd: #6917: spell checker hangs on single quote characters

2010-10-01 Thread Abdelrazak Younes
On 10/01/2010 09:26 AM, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Thing is that on a french azerty keyboard, the single quote and the apostrophe really use the same key... So the user is not to blame here I guess. No. There is no single quote key. Word processors often try

Re: Fwd: #6917: spell checker hangs on single quote characters

2010-10-01 Thread Abdelrazak Younes
On 10/01/2010 09:26 AM, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Thing is that on a french azerty keyboard, the single quote and the apostrophe really use the same key... So the user is not to blame here I guess. No. There is no "single quote" key. Word processors

Re: Fwd: #6917: spell checker hangs on single quote characters

2010-09-29 Thread Abdelrazak Younes
On 09/27/2010 08:34 AM, Stephan Witt wrote: Anfang der weitergeleiteten E-Mail: Von: LyX Ticket Trackert...@lyx.org Datum: 26. September 2010 22:43:25 MESZ An: uwesto...@web.de, st.w...@gmx.net Betreff: Re: #6917: spell checker hangs on single quote characters Antwort an:

Re: Fwd: #6917: spell checker hangs on single quote characters

2010-09-29 Thread Abdelrazak Younes
On 09/27/2010 12:20 PM, Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: I think Abdel only moved code that was already there. Having single quotes as non-separator has some merits for words like don't or aujourd'hui. However, in the report in question, we are really talking

Re: #6917: spell checker hangs on single quote characters

2010-09-29 Thread Abdelrazak Younes
On 09/28/2010 03:16 PM, Stephan Witt wrote: Am 27.09.2010 um 13:54 schrieb Pavel Sanda: Stephan Witt wrote: But seriously: there is already one fragile separator implementation! yes and we already have one crashing bug just in the return d-text_[pos] == ' '; point (6453)

Re: r35529 - in lyx-devel/trunk/src: . frontends/qt4

2010-09-29 Thread Abdelrazak Younes
On 09/29/2010 01:55 PM, rgh...@lyx.org wrote: Author: rgheck Date: Wed Sep 29 13:55:10 2010 New Revision: 35529 URL: http://www.lyx.org/trac/changeset/35529 Log: Introduce a typedef for vectorBuffer *. No change in behavior anticipated. Modified: lyx-devel/trunk/src/Buffer.h

Re: Fwd: #6917: spell checker hangs on single quote characters

2010-09-29 Thread Abdelrazak Younes
On 09/27/2010 08:34 AM, Stephan Witt wrote: Anfang der weitergeleiteten E-Mail: Von: "LyX Ticket Tracker" Datum: 26. September 2010 22:43:25 MESZ An: uwesto...@web.de, st.w...@gmx.net Betreff: Re: #6917: spell checker hangs on single quote characters Antwort an:

Re: Fwd: #6917: spell checker hangs on single quote characters

2010-09-29 Thread Abdelrazak Younes
On 09/27/2010 12:20 PM, Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: I think Abdel only moved code that was already there. Having single quotes as non-separator has some merits for words like "don't" or "aujourd'hui". However, in the report in question, we are really talking

Re: #6917: spell checker hangs on single quote characters

2010-09-29 Thread Abdelrazak Younes
On 09/28/2010 03:16 PM, Stephan Witt wrote: Am 27.09.2010 um 13:54 schrieb Pavel Sanda: Stephan Witt wrote: But seriously: there is already one fragile separator implementation! yes and we already have one crashing bug just in the return d->text_[pos] == ' '; point (6453)

Re: r35529 - in lyx-devel/trunk/src: . frontends/qt4

2010-09-29 Thread Abdelrazak Younes
On 09/29/2010 01:55 PM, rgh...@lyx.org wrote: Author: rgheck Date: Wed Sep 29 13:55:10 2010 New Revision: 35529 URL: http://www.lyx.org/trac/changeset/35529 Log: Introduce a typedef for vector. No change in behavior anticipated. Modified: lyx-devel/trunk/src/Buffer.h

Re: Embedded files in documents

2010-09-23 Thread Abdelrazak Younes
On 09/22/2010 07:30 PM, Richard Heck wrote: For now, you might want to look at the lyxpak.py script, written by Enrico Forestieri, which is a lower-tech approach to the same problem. The script lives at development/tools/lyxpak.py in the source and can be downloaded from:

Re: Embedded files in documents

2010-09-23 Thread Abdelrazak Younes
On 09/22/2010 07:30 PM, Richard Heck wrote: For now, you might want to look at the lyxpak.py script, written by Enrico Forestieri, which is a lower-tech approach to the same problem. The script lives at development/tools/lyxpak.py in the source and can be downloaded from:

Re: [patch] LilyPond-book module

2010-09-21 Thread Abdelrazak Younes
On 09/20/2010 11:56 PM, Pavel Sanda wrote: Julien Rioux wrote: The lytex converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex,

Re: [patch] LilyPond-book module

2010-09-21 Thread Abdelrazak Younes
On 09/20/2010 11:56 PM, Pavel Sanda wrote: Julien Rioux wrote: The "lytex" converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex,

Re: r35447 - lyx-devel/trunk/src

2010-09-20 Thread Abdelrazak Younes
On 09/19/2010 06:00 PM, sw...@lyx.org wrote: Author: switt Date: Sun Sep 19 18:00:32 2010 New Revision: 35447 URL: http://www.lyx.org/trac/changeset/35447 Log: replace the map of the speller state with a vector Modified: lyx-devel/trunk/src/Paragraph.cpp Modified:

Re: r35447 - lyx-devel/trunk/src

2010-09-20 Thread Abdelrazak Younes
On 09/19/2010 06:00 PM, sw...@lyx.org wrote: Author: switt Date: Sun Sep 19 18:00:32 2010 New Revision: 35447 URL: http://www.lyx.org/trac/changeset/35447 Log: replace the map of the speller state with a vector Modified: lyx-devel/trunk/src/Paragraph.cpp Modified:

Re: r35369 - lyx-devel/trunk/src

2010-09-19 Thread Abdelrazak Younes
On 16/09/2010 17:31, Stephan Witt wrote: Am 14.09.2010 um 15:46 schrieb Abdelrazak Younes: On 09/14/2010 02:48 PM, sw...@lyx.org wrote: Author: switt Date: Tue Sep 14 14:48:03 2010 New Revision: 35369 URL: http://www.lyx.org/trac/changeset/35369 Log: reduce nesting levels

Re: r35369 - lyx-devel/trunk/src

2010-09-19 Thread Abdelrazak Younes
On 16/09/2010 17:31, Stephan Witt wrote: Am 14.09.2010 um 15:46 schrieb Abdelrazak Younes: On 09/14/2010 02:48 PM, sw...@lyx.org wrote: Author: switt Date: Tue Sep 14 14:48:03 2010 New Revision: 35369 URL: http://www.lyx.org/trac/changeset/35369 Log: reduce nesting levels

Re: Beta plans (again, again)

2010-09-18 Thread Abdelrazak Younes
On 17/09/2010 18:57, Pavel Sanda wrote: Abdelrazak Younes wrote: This works for me: thanks, added to my local patch set ;) No need to, as I have the nod of 2 devs, I just committed it. Abdel.

Re: Beta plans (again, again)

2010-09-18 Thread Abdelrazak Younes
On 17/09/2010 18:57, Pavel Sanda wrote: Abdelrazak Younes wrote: This works for me: thanks, added to my local patch set ;) No need to, as I have the nod of 2 devs, I just committed it. Abdel.

Re: [patch] support for customizable horizontal lines

2010-09-17 Thread Abdelrazak Younes
On 09/17/2010 03:21 AM, Uwe Stöhr wrote: Replacing pi.base.textwidth with the value of mi.base.textwidth gave exactly the right drawing. Wrong again, my testing revealed a lot of misdrawing. What else was wrong besides the large offset issue? I am fed up with this Uwe. Try to learn by

Re: r35417 - lyx-devel/trunk/src/insets

2010-09-17 Thread Abdelrazak Younes
On 09/17/2010 02:51 PM, Uwe Stöhr wrote: Am 17.09.2010 07:58, schrieb Abdelrazak Younes: - honor Abdel as author That's not needed. I could do this myself in basically all of LyX source code if I wanted to. Why were I then several times forced then to add my name as author to file I

Re: Beta plans (again, again)

2010-09-17 Thread Abdelrazak Younes
On 09/17/2010 02:02 PM, Jean-Marc LASGOUTTES wrote: Pavel Sandasa...@lyx.org writes: better than nothing... btw do i understand correctly this issue was created by changing from curly lines to the doted straight lines? it looks more decent but i became hard-to-find on black background. one

Re: [patch] support for customizable horizontal lines

2010-09-17 Thread Abdelrazak Younes
On 09/17/2010 03:21 AM, Uwe Stöhr wrote: >> Replacing pi.base.textwidth with the value of mi.base.textwidth gave exactly the right drawing. > > Wrong again, my testing revealed a lot of misdrawing. What else was wrong besides the large offset issue? I am fed up with this Uwe. Try to learn by

Re: r35417 - lyx-devel/trunk/src/insets

2010-09-17 Thread Abdelrazak Younes
On 09/17/2010 02:51 PM, Uwe Stöhr wrote: Am 17.09.2010 07:58, schrieb Abdelrazak Younes: - honor Abdel as author That's not needed. I could do this myself in basically all of LyX source code if I wanted to. Why were I then several times forced then to add my name as author to file I

Re: Beta plans (again, again)

2010-09-17 Thread Abdelrazak Younes
On 09/17/2010 02:02 PM, Jean-Marc LASGOUTTES wrote: Pavel Sanda writes: better than nothing... btw do i understand correctly this issue was created by changing from curly lines to the doted straight lines? it looks more decent but i became hard-to-find on black background.

Re: [patch] support for customizable horizontal lines

2010-09-16 Thread Abdelrazak Younes
On 09/16/2010 03:33 AM, Uwe Stöhr wrote: Am 15.09.2010 08:28, schrieb Abdelrazak Younes: No, this is wrong. I need the text width and not the inset width! As I wrote, the text width is calculated in TextMetrics and I need this value in InsetLine.cpp. So I only need to replace there the wrong

Re: r35408 - lyx-devel/trunk/src

2010-09-16 Thread Abdelrazak Younes
On 09/16/2010 09:50 AM, Pavel Sanda wrote: Stephan Witt wrote: Am 16.09.2010 um 09:42 schrieb sw...@lyx.org: Author: switt Date: Thu Sep 16 09:42:08 2010 New Revision: 35408 URL: http://www.lyx.org/trac/changeset/35408 Log: don't copy internal state of spell checker in copy

Re: r35417 - lyx-devel/trunk/src/insets

2010-09-16 Thread Abdelrazak Younes
On 09/17/2010 03:28 AM, uwesto...@lyx.org wrote: Author: uwestoehr Date: Fri Sep 17 03:28:08 2010 New Revision: 35417 URL: http://www.lyx.org/trac/changeset/35417 Log: InsetLine: - honor Abdel as author That's not needed. I could do this myself in basically all of LyX source code if I

Re: [patch] support for customizable horizontal lines

2010-09-16 Thread Abdelrazak Younes
On 09/16/2010 03:33 AM, Uwe Stöhr wrote: Am 15.09.2010 08:28, schrieb Abdelrazak Younes: No, this is wrong. I need the text width and not the inset width! As I wrote, the text width is calculated in TextMetrics and I need this value in InsetLine.cpp. So I only need to replace there the wrong

Re: r35408 - lyx-devel/trunk/src

2010-09-16 Thread Abdelrazak Younes
On 09/16/2010 09:50 AM, Pavel Sanda wrote: Stephan Witt wrote: Am 16.09.2010 um 09:42 schrieb sw...@lyx.org: Author: switt Date: Thu Sep 16 09:42:08 2010 New Revision: 35408 URL: http://www.lyx.org/trac/changeset/35408 Log: don't copy internal state of spell checker in copy

Re: r35417 - lyx-devel/trunk/src/insets

2010-09-16 Thread Abdelrazak Younes
On 09/17/2010 03:28 AM, uwesto...@lyx.org wrote: Author: uwestoehr Date: Fri Sep 17 03:28:08 2010 New Revision: 35417 URL: http://www.lyx.org/trac/changeset/35417 Log: InsetLine: - honor Abdel as author That's not needed. I could do this myself in basically all of LyX source code if I

Re: [patch] support for customizable horizontal lines

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:22 AM, Uwe Stöhr wrote: Am 14.09.2010 15:26, schrieb Abdelrazak Younes: You would very much help me very much if you could look at the code. As said my problem is that the value w (the text width) is calculated in TextMetrics::redoParagraph. I need to have this value

Re: [patch] support for customizable horizontal lines

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:27 AM, Uwe Stöhr wrote: Am 15.09.2010 01:22, schrieb Uwe Stöhr: So you just need the inset width AFAIU which happens to be egal to the text width of the enclosing text inset The inset width is only equal if the line width is 100col% for a line width of 5cm or 10 text% it

Re: [patch] support for customizable horizontal lines

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 03:02 AM, Richard Heck wrote: On 09/14/2010 07:31 PM, Uwe Stöhr wrote: Am 14.09.2010 20:13, schrieb Andre Poenitz: This is my problem: In line 433 of TextMetrics.cpp the text width is calculated: int const w = max_width_ - leftMargin(max_width_, pit, ii-pos) -

Re: r35377 - lyx-devel/trunk/src/insets

2010-09-15 Thread Abdelrazak Younes
Uwe, As a final cutesy I just committed a final fix. As I said, if you want to further improve things, starts from there; but I don't really know what needs to be improved. Drawing works well, now. Otherwise, if you insist on putting your own code, we should just remove this new inset.

Re: r35377 - lyx-devel/trunk/src/insets

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:39 PM, Richard Heck wrote: On 09/15/2010 07:28 AM, Abdelrazak Younes wrote: void InsetLine::draw(PainterInfo pi, int x, int y) const { -frontend::FontMetrics const fm = theFontMetrics(pi.base.font); +// FIXME: We cannot use InsetCommand::dimension

Re: r35377 - lyx-devel/trunk/src/insets

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:42 PM, Abdelrazak Younes wrote: On 09/15/2010 01:39 PM, Richard Heck wrote: On 09/15/2010 07:28 AM, Abdelrazak Younes wrote: void InsetLine::draw(PainterInfo pi, int x, int y) const { -frontend::FontMetrics const fm = theFontMetrics(pi.base.font); +// FIXME: We

Re: [patch] support for customizable horizontal lines

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:22 AM, Uwe Stöhr wrote: Am 14.09.2010 15:26, schrieb Abdelrazak Younes: You would very much help me very much if you could look at the code. As said my problem is that the value "w" (the text width) is calculated in TextMetrics::redoParagraph. I need to have

Re: [patch] support for customizable horizontal lines

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:27 AM, Uwe Stöhr wrote: Am 15.09.2010 01:22, schrieb Uwe Stöhr: So you just need the inset width AFAIU which happens to be egal to the text width of the enclosing text inset The inset width is only equal if the line width is 100col% for a line width of 5cm or 10 text% it

Re: [patch] support for customizable horizontal lines

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 03:02 AM, Richard Heck wrote: On 09/14/2010 07:31 PM, Uwe Stöhr wrote: Am 14.09.2010 20:13, schrieb Andre Poenitz: This is my problem: In line 433 of TextMetrics.cpp the text width is calculated: int const w = max_width_ - leftMargin(max_width_, pit, ii->pos) -

Re: r35377 - lyx-devel/trunk/src/insets

2010-09-15 Thread Abdelrazak Younes
Uwe, As a final cutesy I just committed a final fix. As I said, if you want to further improve things, starts from there; but I don't really know what needs to be improved. Drawing works well, now. Otherwise, if you insist on putting your own code, we should just remove this new inset.

Re: r35377 - lyx-devel/trunk/src/insets

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:39 PM, Richard Heck wrote: On 09/15/2010 07:28 AM, Abdelrazak Younes wrote: void InsetLine::draw(PainterInfo& pi, int x, int y) const { -frontend::FontMetrics const& fm = theFontMetrics(pi.base.font); +// FIXME: We cannot use InsetCommand::d

Re: r35377 - lyx-devel/trunk/src/insets

2010-09-15 Thread Abdelrazak Younes
On 09/15/2010 01:42 PM, Abdelrazak Younes wrote: On 09/15/2010 01:39 PM, Richard Heck wrote: On 09/15/2010 07:28 AM, Abdelrazak Younes wrote: void InsetLine::draw(PainterInfo& pi, int x, int y) const { -frontend::FontMetrics const& fm = theFontMetrics(pi.base.font); +// F

Re: [patch] support for customizable horizontal lines

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 04:30 AM, Uwe Stöhr wrote: Am 13.09.2010 08:58, schrieb Abdelrazak Younes: You forgot the attachement... Sorry. In the meantime I found a solution - ugly but does exactly what I want. This is my problem: In line 433 of TextMetrics.cpp the text width is calculated: int const w

Re: alpha 6 call

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 08:06 AM, Stephan Witt wrote: Am 13.09.2010 um 23:16 schrieb Pavel Sanda: Stephan Witt wrote: Yes. I think so, too. Perhaps you can wait another two days with alpha6 until the developers on platforms I do not have (Windows and Cygwin) have verified that it works at the

Re: alpha 6 call

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 09:30 AM, Stephan Witt wrote: Am 14.09.2010 um 08:32 schrieb Abdelrazak Younes: On 09/14/2010 08:06 AM, Stephan Witt wrote: Am 13.09.2010 um 23:16 schrieb Pavel Sanda: Stephan Witt wrote: Yes. I think so, too. Perhaps you can wait another two

Re: [patch] support for customizable horizontal lines

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 02:20 PM, Uwe Stöhr wrote: Am 14.09.2010 08:21, schrieb Abdelrazak Younes: I tried several approaches to achieve this but only the one via a global variable does the job. Attached is the corresponding patch. It fixes the problem exactly as it should, but I would like to get rid

Re: r35372 - lyx-devel/trunk/src

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 04:31 PM, Stephan Witt wrote: Am 14.09.2010 um 16:01 schrieb you...@lyx.org: Author: younes Date: Tue Sep 14 16:01:44 2010 New Revision: 35372 URL: http://www.lyx.org/trac/changeset/35372 Log: gcc compile fix. Thanks. You're using Windows? No, Linux. Did you

Re: r35369 - lyx-devel/trunk/src

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 02:48 PM, sw...@lyx.org wrote: Author: switt Date: Tue Sep 14 14:48:03 2010 New Revision: 35369 URL: http://www.lyx.org/trac/changeset/35369 Log: reduce nesting levels in markMisspelledWords; simplify range check of fontspan I have a compile error:

Re: [patch] support for customizable horizontal lines

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 04:30 AM, Uwe Stöhr wrote: Am 13.09.2010 08:58, schrieb Abdelrazak Younes: You forgot the attachement... Sorry. In the meantime I found a solution - ugly but does exactly what I want. This is my problem: In line 433 of TextMetrics.cpp the text width is calculated: int const w

Re: alpha 6 call

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 08:06 AM, Stephan Witt wrote: Am 13.09.2010 um 23:16 schrieb Pavel Sanda: Stephan Witt wrote: Yes. I think so, too. Perhaps you can wait another two days with alpha6 until the developers on platforms I do not have (Windows and Cygwin) have verified that it works at the

Re: alpha 6 call

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 09:30 AM, Stephan Witt wrote: Am 14.09.2010 um 08:32 schrieb Abdelrazak Younes: On 09/14/2010 08:06 AM, Stephan Witt wrote: Am 13.09.2010 um 23:16 schrieb Pavel Sanda: Stephan Witt wrote: Yes. I think so, too. Perhaps you can wait another two

Re: [patch] support for customizable horizontal lines

2010-09-14 Thread Abdelrazak Younes
On 09/14/2010 02:20 PM, Uwe Stöhr wrote: Am 14.09.2010 08:21, schrieb Abdelrazak Younes: I tried several approaches to achieve this but only the one via a global variable does the job. Attached is the corresponding patch. It fixes the problem exactly as it should, but I would like to get rid

<    5   6   7   8   9   10   11   12   13   14   >