Re: LyX 1.6.6: please prepare for landing

2010-04-06 Thread rgheck
On 04/06/2010 01:09 PM, Jürgen Spitzmüller wrote: Jean-Pierre Chrétien wrote: I the same line, I submitted an example file for crossrefs http://article.gmane.org/gmane.editors.lyx.devel/126589 and I got no comments about it. Should it have been posted to lyx-docs ? This is for trunk

Cmake compilation error

2010-04-06 Thread rgheck
On 04/06/2010 08:02 PM, BH wrote: On Mon, Apr 5, 2010 at 8:46 PM, Uwe Stöhr wrote: Am 06.04.2010 02:23, schrieb Richard Heck: since r34059 I cannot compile LyX: ..\..\src\Buffer.cpp(1571) : error C2065: 'PACKAGE_STRING' : undeclared identifier I'm guessing this is some

Re: alpha2

2010-04-07 Thread rgheck
On 04/07/2010 06:46 AM, Pavel Sanda wrote: hi, i would like to release alpha2 next week. showstoppers marked as highest priority bugs in trac. currently: #6519changes in document settings cannot be saved Done. #6611assert on old configuration I didn't quite understand this

Re: alpha2

2010-04-07 Thread rgheck
On 04/07/2010 09:44 AM, Pavel Sanda wrote: Rob Oakes wrote: It seems to be choking on some of the XHTML code in Buffer.cpp. I haven't looked into it, but might a solution be to move the XHTML header code into a lib file instead of hardcoding into Buffer.cpp? please send the exact err

Re: r34072 - lyx-devel/trunk/src/frontends/qt4

2010-04-07 Thread rgheck
On 04/07/2010 09:08 AM, Jean-Marc Lasgouttes wrote: rgh...@lyx.org writes: Author: rgheck Date: Wed Apr 7 14:41:19 2010 New Revision: 34072 URL: http://www.lyx.org/trac/changeset/34072 Log: The lv variable was used back in LyXView.cpp, where we didn't have such easy access to the cu

Re: Cmake compilation error

2010-04-07 Thread rgheck
On 04/07/2010 10:23 AM, Kornel Benko wrote: Sorry for not being responsive, but I broke my right arm, and it is somehow not easy to use a computer. Sorry to hear that! rh

Re: changeset 34081

2010-04-07 Thread rgheck
On 04/07/2010 03:00 PM, Uwe Stöhr wrote: > Grant a long-standing wish of Lars's: LyX now functions even if we > have no text classes for some reason (e.g., a corrupt textclass.lst). > We still give the user a chance to reconfigure (Bo's idea). Many thanks! Corrupted text classes occur more often

Re: r34095 - lyx-devel/trunk/src

2010-04-08 Thread rgheck
On 04/08/2010 04:25 PM, Pavel Sanda wrote: for...@lyx.org wrote: Author: forenr Date: Thu Apr 8 22:22:20 2010 New Revision: 34095 URL: http://www.lyx.org/trac/changeset/34095 Log: Use cheaper conversion method. Modified: lyx-devel/trunk/src/Buffer.cpp Modified: lyx-devel/trunk/src/Bu

Re: r34095 - lyx-devel/trunk/src

2010-04-09 Thread rgheck
On 04/08/2010 04:51 PM, Pavel Sanda wrote: Richard Heck wrote: On 04/08/2010 04:25 PM, Pavel Sanda wrote: Modified: lyx-devel/trunk/src/Buffer.cpp == --- lyx-devel/trunk/src/Buffer.cpp Thu Apr

Re: r34095 - lyx-devel/trunk/src

2010-04-09 Thread rgheck
On 04/09/2010 10:00 AM, Enrico Forestieri wrote: On Thu, Apr 08, 2010 at 10:25:38PM +0200, Pavel Sanda wrote: for...@lyx.org wrote: Author: forenr Date: Thu Apr 8 22:22:20 2010 New Revision: 34095 URL: http://www.lyx.org/trac/changeset/34095 Log: Use cheaper conversion method. Mod

[PATCH] FuncRequest Argument Parsing

2010-04-09 Thread rgheck
The attached is a patch I've had sitting around for a while. Currently, we use FuncRequest::getArg(int) to retrieve arguments from an LFUN argument string. The downside to this is that every such call completely reparses the string, and we can do this as many as four times. I thought about ca

Re: r34095 - lyx-devel/trunk/src

2010-04-09 Thread rgheck
On 04/09/2010 03:06 PM, Uwe Stöhr wrote: rgheck schrieb: The display fonts for notes, etc, are actually controlled by the InsetLayouts associated with them. At the moment, however, the declared color has to be one of the color names known to LyX. A simple idea would be to allow this

Re: r34107 - lyx-devel/trunk/src

2010-04-10 Thread rgheck
On 04/09/2010 07:55 PM, Enrico Forestieri wrote: On Sat, Apr 10, 2010 at 01:10:55AM +0200, Vincent van Ravesteijn wrote: Jean-Marc Lasgouttes schreef: Le 9 avr. 10 à 21:03, rgh...@lyx.org a écrit : Log: Mark new files dirty. Otherwise, you can't save them, and maybe you want

Re: LyX/Mac Maintainer

2010-04-12 Thread rgheck
On 04/11/2010 10:30 PM, BH wrote: Stephen Witt has been doing some great things for LyX/Mac. Given that I have not had time or expertise to really advance LyX/Mac, and given his abilities and enthusiasm, I have asked him if he would like to take over as LyX/Mac maintainer. He has agreed. For now

Re: r34120 - lyx-devel/trunk/src

2010-04-12 Thread rgheck
On 04/12/2010 11:31 AM, Pavel Sanda wrote: Vincent van Ravesteijn - TNW wrote: - : action_(LFUN_NOACTION), origin_(o), x_(0), y_(0), + : argument_(0), action_(LFUN_NOACTION), origin_(o), x_(0), y_(0), What's the rationale about initializing a docstring wit

Re: r34120 - lyx-devel/trunk/src

2010-04-12 Thread rgheck
On 04/12/2010 02:25 PM, Pavel Sanda wrote: Vincent van Ravesteijn - TNW wrote: ehh, i thought from the one without argument, no? FuncRequest? (this=0x8c0111c, act=lyx::LFUN_UNKNOWN_ACTION, o=lyx::FuncRequest::INTERNAL) at FuncRequest?.cpp:39 Please read further: #11 0x081a00c8 in

Re: About making new files dirty

2010-04-13 Thread rgheck
On 04/13/2010 09:32 AM, Jean-Marc Lasgouttes wrote: Richard, I tried to revert your recent patches (34119, 34121) to see what the old behaviour was like, and I do not see the problem. When one creates a new file, it is not dirty, but it is possible to save it with File>Save. Could you tell me a

Re: posible bug: url and percentage

2010-04-14 Thread rgheck
On 04/14/2010 03:10 AM, Guenter Milde wrote: On 2010-04-13, Fox_Van wrote: *FOOTNOTE[* Making R Packages Under Windows: A Tutorial. *URL[* http://faculty.chicagobooth.edu/peter.rossi/research/bayes%20book/bayesm/Making%20R%20Packages%20Under%20Windows.pdf ]* ]* When I removed the perc

Re: r34130 - lyx-devel/trunk/src

2010-04-14 Thread rgheck
On 04/14/2010 07:54 AM, v...@lyx.org wrote: Author: vfr Date: Wed Apr 14 13:54:12 2010 New Revision: 34130 URL: http://www.lyx.org/trac/changeset/34130 Log: Fix bug #6651: No error messages when module dependencies are not fulfilled. We need to throw the ExceptionMessage's. Can you tell me

Re: r34130 - lyx-devel/trunk/src

2010-04-14 Thread rgheck
On 04/14/2010 08:11 AM, Vincent van Ravesteijn - TNW wrote: Author: vfr Date: Wed Apr 14 13:54:12 2010 New Revision: 34130 URL: http://www.lyx.org/trac/changeset/34130 Log: Fix bug #6651: No error messages when module dependencies are not fulfilled. We need to throw the ExceptionMe

Re: r34130 - lyx-devel/trunk/src

2010-04-14 Thread rgheck
On 04/14/2010 08:45 AM, Vincent van Ravesteijn - TNW wrote: Can you tell me what happens when this exception gets thrown? (I have no idea why I didn't throw it.) The user get's a message box with a warning that he might not generate any output. (or

Re: Preferences panels

2010-04-15 Thread rgheck
On 04/14/2010 10:16 PM, Pavel Sanda wrote: hi, our tools->preferences->output panels are now completely unbalanced. latex pane overflows with items, while "date format" and "plain text" are orphans. what about joining these two into one "general" panel? Sounds good. Richard do you plan s

Re: [Patch] #94 - LYX forward DVI search.

2010-04-15 Thread rgheck
On 04/14/2010 10:09 PM, Pavel Sanda wrote: diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp index 053680a..32a2604 100644 --- a/src/LyXAction.cpp +++ b/src/LyXAction.cpp @@ -2825,6 +2825,23 @@ void LyXAction::init() */ { LFUN_SERVER_GOTO_FILE_ROW, "server-goto-file-row", Read

Re: Preferences panels

2010-04-15 Thread rgheck
On 04/15/2010 11:06 AM, Pavel Sanda wrote: Richard Heck wrote: Yes, there will be a few XHTML settings. Probably one check box (strict XHTML versus not so strict), one combo box (math output type), and one text field (scaling factor for math images). ok there is place for xhtml in gen

Re: r34149 - in lyx-devel/trunk: lib/ui src src/frontends/qt4 src/frontends/qt4/ui

2010-04-16 Thread rgheck
On 04/16/2010 10:26 AM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Apr 16 10:09:07 2010 New Revision: 34149 URL: http://www.lyx.org/trac/changeset/34149 Log: Guify forward search. No viewer set by default, which keeps context menu clean for uninterested users. Settings

Re: r34149 - in lyx-devel/trunk: lib/ui src src/frontends/qt4 src/frontends/qt4/ui

2010-04-16 Thread rgheck
On 04/16/2010 10:26 AM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Apr 16 10:09:07 2010 New Revision: 34149 URL: http://www.lyx.org/trac/changeset/34149 Log: Guify forward search. No viewer set by default, which keeps context menu clean for uninterested users. Settings

Re: buffer new on tabbar double click

2010-04-17 Thread rgheck
On 04/17/2010 07:34 AM, Edwin Leuven wrote: any objections to the attached? If I'm reading it right, this happens only when you double click into an empty area of the tab bar, right? If so, fine with me. rh

Re: r34190 - lyx-devel/trunk/src/insets

2010-04-17 Thread rgheck
On 04/17/2010 09:34 AM, rgh...@lyx.org wrote: Author: rgheck Date: Sat Apr 17 15:34:13 2010 New Revision: 34190 URL: http://www.lyx.org/trac/changeset/34190 Log: Disable InsetInfo for VC when VC is not active. It would probably be better to let the various backends tell us what they

InsetInfo Context Menu Problems

2010-04-17 Thread rgheck
The context menu seems to be completely disabled unless the cursor is directly in front of the InsetInfo. rh

Re: latex-lab?

2010-04-17 Thread rgheck
On 04/17/2010 12:38 PM, xPol wrote: Do you think that the latex-lab project, an implementation of a web based LaTeX editor for Google Docs, could be exploited to carry lyx on the web? Here: http://code.google.com/p/latex-lab/ The idea behind this sort of thing could be adapted, but the LaTe

Re: r34186 - in lyx-devel/trunk: lib/lyx2lyx src src/frontends/qt4 src/insets

2010-04-17 Thread rgheck
On 04/17/2010 02:16 PM, Enrico Forestieri wrote: On Sat, Apr 17, 2010 at 03:04:41PM +0200, rgh...@lyx.org wrote: Author: rgheck Date: Sat Apr 17 15:04:41 2010 New Revision: 34186 URL: http://www.lyx.org/trac/changeset/34186 Log: LyX version info for InsetInfo. I am not able to load

Master vs Child Preamble, Etc

2010-04-17 Thread rgheck
Given the common questions about this kind of thing, I wonder if we should have a per-document setting that would allow the user to specify that the params for a certain document are to be taken from the master, if there is one. I would guess that this would only be active on output. Has any

Re: r34186 - in lyx-devel/trunk: lib/lyx2lyx src src/frontends/qt4 src/insets

2010-04-17 Thread rgheck
On 04/17/2010 05:19 PM, Enrico Forestieri wrote: On Sat, Apr 17, 2010 at 03:30:10PM -0400, rgheck wrote: On 04/17/2010 02:16 PM, Enrico Forestieri wrote: On Sat, Apr 17, 2010 at 03:04:41PM +0200, rgh...@lyx.org wrote: Author: rgheck Date: Sat Apr 17 15:04:41 2010 New

Re: Crash when module not found

2010-04-17 Thread rgheck
On 04/17/2010 06:06 PM, BH wrote: Stephan's build of LyX-2.0-alpha2 creates a new user's directory for me. When I don't copy over my standard modules but try to open a file that requires one, I get a crash. I thought something like this might be about to happen. I've fixed it. rh

Re: r34186 - in lyx-devel/trunk: lib/lyx2lyx src src/frontends/qt4 src/insets

2010-04-17 Thread rgheck
On 04/17/2010 07:03 PM, Enrico Forestieri wrote: This is with autotools. The file will be copied to the right place but only when installing. The problem occurs when you run lyx in place (without installing it) and I am surprised that it works for you. I'll check it with a fresh co. rh

Re: r34186 - in lyx-devel/trunk: lib/lyx2lyx src src/frontends/qt4 src/insets

2010-04-17 Thread rgheck
On 04/17/2010 08:07 PM, Enrico Forestieri wrote: Please, see lib/lyx2lyx/LyX.py for a workaround to the "import lyx2lyx_version" problem when running from build directory. I saw that before, but the sad thing is it would require replicating the hard-coded string in two places. I'm still th

Re: latex-lab?

2010-04-18 Thread rgheck
On 04/17/2010 10:38 PM, xPol wrote: rgheck wrote: I'm still wondering what precisely people want here. Porting LyX to an AJAX application would be possible, but not something we on the development team have anything near the time to do. So let me ask what I asked before: What is it

Re: Master vs Child Preamble, Etc

2010-04-18 Thread rgheck
On 04/18/2010 03:42 AM, Jürgen Spitzmüller wrote: rgheck wrote: Given the common questions about this kind of thing, I wonder if we should have a per-document setting that would allow the user to specify that the params for a certain document are to be taken from the master, if there is one

Restore Last Position Bug Fixed?

2010-04-18 Thread rgheck
Has the bug concerning restoration of last file position been fixed in trunk? I.e., if you have bookmarks, then the code that updates their location before closing causes the last file position to be set to wherever the last bookmark is. rh

Re: Master vs Child Preamble, Etc

2010-04-18 Thread rgheck
On 04/18/2010 10:38 AM, Jürgen Spitzmüller wrote: rgheck wrote: Here's the thought, then. As I suggested, we use the master's params only on output. The complication is that the params can be accessed from so many places. But they are always accessed via Buffer::params(), so we ju

Re: r34213 - lyx-devel/trunk/src

2010-04-18 Thread rgheck
On 04/18/2010 07:17 PM, Pavel Sanda wrote: if (it == en) { + // debug code to try to figure out what's up. + LYXERR0("Failed to find marked arrow.\n" + "From: "<< from<< ", To: "<< to); + dumpGra

Re: result of a first test with LyX 2.0alpha2

2010-04-18 Thread rgheck
On 04/18/2010 07:19 PM, Uwe Stöhr wrote: > but at least backtrace is possible? No because I wasn't able to crash alpha2 the last hours :-) But I noticed another very annoying behaviour: When I export a file as PDF LyX asks me if I want to replace the existing PDF. This is OK, but replacing sh

Re: r34215 - lyx-devel/trunk/src/insets

2010-04-18 Thread rgheck
On 04/18/2010 07:35 PM, v...@lyx.org wrote: Author: vfr Date: Mon Apr 19 01:35:59 2010 New Revision: 34215 URL: http://www.lyx.org/trac/changeset/34215 Log: Fix bug #6659: InsetInfo context menu disabled unless cursor immediately in front. Thanks, Vincent. rh

Re: result of a first test with LyX 2.0alpha2

2010-04-19 Thread rgheck
On 04/19/2010 02:54 AM, Abdelrazak Younes wrote: On 04/19/2010 05:51 AM, Uwe Stöhr wrote: Am 19.04.2010 02:14, schrieb Vincent van Ravesteijn: When I export a file as PDF LyX asks me if I want to replace the existing PDF. This is OK, but replacing should be the default and not keeping. Why do

Re: result of a first test with LyX 2.0alpha2

2010-04-19 Thread rgheck
On 04/19/2010 08:44 AM, Abdelrazak Younes wrote: On 04/19/2010 01:41 PM, rgheck wrote: On 04/19/2010 02:54 AM, Abdelrazak Younes wrote: On 04/19/2010 05:51 AM, Uwe Stöhr wrote: Am 19.04.2010 02:14, schrieb Vincent van Ravesteijn: When I export a file as PDF LyX asks me if I want to replace

Re: Broken HTML/OpenDocument Code Generation

2010-04-19 Thread rgheck
On 04/19/2010 10:01 AM, Rainer Dorsch wrote: Hello, I have a small LyX document, which shows a combination of a hyperlink and an svg figure break html/opendocument generation: The source documentation is here http://bokomoko.de/~rd/lyxtest/ The output I get is here http://bokomoko.de/~rd/lyx

Re: Master vs Child Preamble, Etc

2010-04-19 Thread rgheck
On 04/19/2010 08:42 AM, Jean-Marc Lasgouttes wrote: rgheck writes: Even better would be to use in both on input and output, and to let the user change these params in the document dialog from within each child. I would prefer that too. I think I'm confused about what&#x

Re: Broken HTML/OpenDocument Code Generation

2010-04-19 Thread rgheck
On 04/19/2010 11:42 AM, Rainer Dorsch wrote: Am Monday 19 April 2010 17:03:41 schrieb Jürgen Spitzmüller: rgheck wrote: The last official release seems to have been the one you have. Perhaps you should report the bug here: http://www.cse.ohio-state.edu/~gurari/TeX4ht/#QQ1-1-82

Re: Broken HTML/OpenDocument Code Generation

2010-04-19 Thread rgheck
On 04/19/2010 12:53 PM, Rainer Dorsch wrote: Am Monday 19 April 2010 16:48:21 schrieb rgheck: Is there anything I am doing wrong? I doubt it. tex4ht is pretty fragile, as people's experience here shows. Is there a better way to generate HTML from LyX files? De

Re: result of a first test with LyX 2.0alpha2

2010-04-19 Thread rgheck
On 04/19/2010 11:22 AM, Enrico Forestieri wrote: On Mon, Apr 19, 2010 at 02:14:25AM +0200, Vincent van Ravesteijn wrote: Uwe Stöhr schreef: But I noticed another very annoying behaviour: When I export a file as PDF LyX asks me if I want to replace the existing PDF. This is OK, but r

Re: r34216 - lyx-devel/trunk/src/insets

2010-04-19 Thread rgheck
On 04/19/2010 12:10 PM, Vincent van Ravesteijn wrote: Better(?) fix for bug #6659: InsetInfo context menu disabled unless cursor immediately in front. Much better indeed. Year, I was about to complain ;-) The problem was that I never expected that InsetInfo is a child class of InsetColla

Re: Broken HTML/OpenDocument Code Generation

2010-04-19 Thread rgheck
On 04/19/2010 04:29 PM, Rainer Dorsch wrote: Just for curiosity: will the "native" XHTML export support ERT sections too? At the moment, ERT is ignored, since in many cases it will be LaTeX we don't know how to handle. But you can easily define a new custom inset that will be output verba

Re: Broken HTML/OpenDocument Code Generation

2010-04-20 Thread rgheck
On 04/20/2010 06:14 AM, Pavel Sanda wrote: Richard Heck wrote: There's also a question about what to do with the new InsetPreview. I haven't thought much about this. i hoped that this could be solved by the same mechanism as when the math insets are plain images in the output...

Math-as-Images for XHTML

2010-04-20 Thread rgheck
The attached patch implements export of math as images for XHTML. I am morally certain that there are lots of things here that could be done better. I do not really understand the code very well. I don't think the patch breaks anything, but I'm guessing (and hoping) that people will have desi

Re: result of a first test with LyX 2.0alpha2

2010-04-20 Thread rgheck
On 04/20/2010 09:16 AM, Jean-Marc Lasgouttes wrote: In this case, I don't see how we could take advantage of that. If the alert is never displayed again, the choice cannot be reverted. Then, the alert doesn't distinguish between ancillary files and main file. Ah, we have no way to revert these

Re: Repeating Errors

2010-04-20 Thread rgheck
On 04/20/2010 11:34 AM, Rob Oakes wrote: Dear LyX Developers, I thought that I would take a stab at fixing bug #6650, http://www.lyx.org/trac/ticket/6650 (mostly because it is driving me to absolute distraction). Thus, I've been looking at the code in the two messages classes, GuiApplication (w

Re: [Code Review] LyX-Outline - Two Column TocModel

2010-05-24 Thread rgheck
On 05/23/2010 09:12 PM, Rob Oakes wrote: Dear LyX Developers, I am writing to request a bit of code review. I will have a look at this tonight, hopefully. rh

Re: bufferparams output

2010-05-24 Thread rgheck
On 05/24/2010 09:17 AM, Pavel Sanda wrote: Richard, looking at the current .lyx header i find a little bit disturbing those \html_latex_start "" and so on. what about enclose all xhtml header stuff into something like xhtml().writeFile(os) and dump it only in non default case as we do with pdf

Re: r34492 - lyx-devel/trunk/src

2010-05-24 Thread rgheck
On 05/24/2010 03:45 PM, Pavel Sanda wrote: rgh...@lyx.org wrote: Author: rgheck Date: Mon May 24 21:38:14 2010 New Revision: 34492 URL: http://www.lyx.org/trac/changeset/34492 Log: Output these params only when they are not default. (In the case of html_latex_*, we'll put the de

Re: r36891 - lyx-devel/trunk/lib/layouts

2010-12-15 Thread rgheck
On 12/15/2010 10:30 AM, rgh...@lyx.org wrote: Author: rgheck Date: Wed Dec 15 16:30:25 2010 New Revision: 36891 URL: http://www.lyx.org/trac/changeset/36891 Log: The letter class supports quote, quotation, and verse, and surely the ---Separator--- might be wanted. This would also be good

[PATCH] Bug 3524

2007-05-07 Thread rgheck
Attached a very simple patch to resolve this bug. OK to commit?Index: frontends/qt4/QParagraph.cpp === --- frontends/qt4/QParagraph.cpp (revision 18231) +++ frontends/qt4/QParagraph.cpp (working copy) @@ -16,6 +16,8 @@ #include "qt_he

[PATCH] Bug 2951

2007-05-07 Thread rgheck
Another simple little patch for this one. OK to commit?Index: Text.cpp === --- Text.cpp (revision 18231) +++ Text.cpp (working copy) @@ -1813,20 +1813,29 @@ if (caption_inset) name = from_ascii(static_cast(caption_inset)->type());

Re: [PATCH] Bug 3524

2007-05-08 Thread rgheck
How about this Index: qt4/QParagraph.cpp === --- qt4/QParagraph.cpp (revision 18231) +++ qt4/QParagraph.cpp (working copy) @@ -254,7 +254,14 @@ dialog_->alignmentToRadioButtons(newAlignment); //indentation - dialog_->indentC

InsetListings and InsetCommandParams

2007-05-09 Thread rgheck
>> The question, basically, is why you're making use of getOptions. My >> understanding was that getOptions and setOptions (and some other things) >> were scheduled for removal because they're some kind of relic of an >> older >> way in which insets interacted with parameters. (There are other >> r

Re: InsetListings and InsetCommandParams

2007-05-09 Thread rgheck
>> If you look at InsetCommandParams, you'll see that params_ is set in >> read(), and the other InsetCommand derived insets call read() when they >> need to set params_. (When they need to read the params, they just get >> params_ directly via params() and index into it.) That's what I meant >> wh

Re: InsetListings and InsetCommandParams

2007-05-09 Thread rgheck
>> > I *think* the way to do this is: >> > >> > string const paramStr = InsetIncludeMailer::params2string(params_); >> > params_.read(paramStr); >> > >> > Abdel...is this right, more or less? > > Sorry that I am slow due to lack of sleep. How can I *set* option in > this way? You basically convert

Re: InsetCommandParams Rewrite, Continued

2008-02-25 Thread rgheck
Pavel Sanda wrote: After a hiatus, I'm returning to the rewrite of InsetCommandParams, the purpose of all of this being to make things more flexible, with the ultimate goal being biblatex support and a kind of InsetCommandFlex that will allow user-definable such things. The next step, really, i

[PATCH] TextClassPtr

2008-02-25 Thread rgheck
In my last commit regarding boost::shared_ptr, I left TextClassPtr as a silly typedef: typedef TextClass * TextClassPtr; The attached would turn it into something akin to a "strong typedef", where TextClassPtr really just wraps a TextClass*. The point of this is to enforce the distinction

Re: [Cvslog] r23235 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2008-02-25 Thread rgheck
Andre Poenitz wrote: On Mon, Feb 25, 2008 at 10:13:46PM -, [EMAIL PROTECTED] wrote: +bool ParamInfo::ParamData::isOptional() const +{ + return type_ == ParamInfo::LATEX_OPTIONAL || + type_ == ParamInfo::LATEX_KV_OPTIONAL; Hmdahm.. IIRC Abdel mentioned putting the

Re: [Cvslog] r23235 - in /lyx-devel/trunk/src/insets: InsetBibitem.cpp...

2008-02-25 Thread rgheck
Andre Poenitz wrote: On Mon, Feb 25, 2008 at 10:13:46PM -, [EMAIL PROTECTED] wrote: +bool ParamInfo::ParamData::isOptional() const +{ + return type_ == ParamInfo::LATEX_OPTIONAL || + type_ == ParamInfo::LATEX_KV_OPTIONAL; Hmdahm.. IIRC Abdel mentioned putting the

Re: Unknown color name

2008-02-25 Thread rgheck
Pavel Sanda wrote: hi, with the current trunk i get this warning: QColor::setNamedColor: Unknown color name 'grey70' Me, too...though we need to fix the color stuff still, anyway. rh

Re: [PATCH] TextClassPtr

2008-02-25 Thread rgheck
Andre Poenitz wrote: On Mon, Feb 25, 2008 at 04:50:42PM -0500, rgheck wrote: In my last commit regarding boost::shared_ptr, I left TextClassPtr as a silly typedef: typedef TextClass * TextClassPtr; The attached would turn it into something akin to a "strong typedef", where Te

Re: [PATCH] TextClassPtr

2008-02-26 Thread rgheck
Abdelrazak Younes wrote: rgheck wrote: Andre Poenitz wrote: On Mon, Feb 25, 2008 at 04:50:42PM -0500, rgheck wrote: I personally don't like this TextClassPtr class. 'TextClass *' is meaningful enough. I would suggest to get rid of the TextClassPtr header altogether now.

GuiView Warnings

2008-02-26 Thread rgheck
The former is trivial, but the latter looks worrying. GuiView.cpp:406: warning: comparison between signed and unsigned integer expressions GuiView.cpp:409: warning: unused variable 'wa' rh

TextClassPtr Must Die

2008-02-26 Thread rgheck
OK, here's another go, along the lines of the suggestions made in my last message. The point of this is basically to introduce a new type, DocumentClass. These are just TextClass objects, basically, but they are specifically the ones that represent the layout information for a Buffer, and the

Re: Configuration error MacOSX 10.4

2008-02-26 Thread rgheck
Anders Ekberg wrote: Trying to compile on a PPC G4 with OSX 10.4 I get config.status: error: cannot find input file: config/Makefile.in anek$ makeMaking all in config make[1]: *** No rule to make target `all'. Stop. make: *** [all-recursive] Error 1 On the other machines I have tried (G4 with 1

Re: TextClassPtr Must Die

2008-02-26 Thread rgheck
Andre Poenitz wrote: On Tue, Feb 26, 2008 at 04:31:56PM -0500, rgheck wrote: - TextClassPtr newClass(TextClass const & baseClass); + DocumentClass * newClass(TextClass const & baseClass); I'd prefer a reference her... otherwise it somehow make me wonder whet

InsetBibtex Question

2008-02-27 Thread rgheck
When doing some other things, I ran across this code: // bibtotoc-Option if (!bibtotoc.empty() && !buffer().params().use_bibtopic) { // maybe a problem when a textclass has no "art" as // part of its name, because it's than book. // For the "official" lyx-layouts it's n

Segfault In Trunk

2008-02-27 Thread rgheck
Open LyX. Open User Guide. Close LyX. (gdb) bt #0 std::_Rb_treelyx::Messages>, std::_Select1stlyx::Messages> >, std::less, std::allocator > >::lower_bound (this=0x7fff2ab6beb0, [EMAIL PROTECTED]) at /usr/lib/gcc/x86_64-redhat-linux/4.1.2/../../../../include/c++/4.1.2/bits/basic_string.

Re: Assertion in rgbFromHexName()

2008-02-28 Thread rgheck
Abdelrazak Younes wrote: The code is very weird: if (isRequired("framed") && mustProvide("color")) { RGBColor c = rgbFromHexName(lcolor.getX11Name(Color_shadedbg)); This is the same problem discussed a while back concerning color handing: http://www.mail-archive.com/lyx-devel@lists.lyx.

Re: Assertion in rgbFromHexName()

2008-02-28 Thread rgheck
Abdelrazak Younes wrote: rgheck wrote: Abdelrazak Younes wrote: The code is very weird: if (isRequired("framed") && mustProvide("color")) { RGBColor c = rgbFromHexName(lcolor.getX11Name(Color_shadedbg)); This is the same problem discussed a while back concern

Re: [Cvslog] r23322 - in /lyx-devel/trunk/src: BaseClassList.cpp BaseC...

2008-02-28 Thread rgheck
[EMAIL PROTECTED] wrote: Author: rgheck Date: Thu Feb 28 15:49:01 2008 New Revision: 23322 URL: http://www.lyx.org/trac/changeset/23322 Log: baseclasslist --> BaseClassList singleton. Prep for further type safety. FYI: The point of all of this is to enforce the distinction between &q

Re: Assertion in rgbFromHexName()

2008-02-28 Thread rgheck
Andre Poenitz wrote: On Thu, Feb 28, 2008 at 11:57:08AM +0100, Abdelrazak Younes wrote: The code is very weird: if (isRequired("framed") && mustProvide("color")) { RGBColor c = rgbFromHexName(lcolor.getX11Name(Color_shadedbg)); getX11Name() returns a named color (egg "red") and rgbF

Re: Assertion in rgbFromHexName()

2008-02-28 Thread rgheck
Abdelrazak Younes wrote: Martin Vermeer wrote: On Thu, 28 Feb 2008 16:06:39 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: rgheck wrote: Abdelrazak Younes wrote: The code is very weird: if (isRequired("framed") && mustProvide("color"))

Re: Todays lyx-1.6svn understands "format 6" but not "format 2" layouts?

2008-02-28 Thread rgheck
Helge Hafting wrote: Compiled & installed todays lyx-1.6 from svn. It complained that it could not use my custom .layout, that used to work for 1.5 as well as a few months old lyx-1.6svn. I've fixed this. It was something I missed when we changed the TextClass::read() API. rh

Re: [Cvslog] r23332 - /lyx-devel/trunk/src/insets/InsetBibtex.cpp

2008-02-28 Thread rgheck
Bernhard Roider wrote: trunk does not compile: [EMAIL PROTECTED] schrieb: -if (!contains(buffer().params().documentClass().name(), "art")) { +if (!contains(buffer().params().baseClass()->name(), "art")) { InsetBibtex.cpp ..\..\..\trunk\src\insets\InsetBibtex.cpp(313) : erro

Re: monolithic build linking problems

2008-03-01 Thread rgheck
Pavel Sanda wrote: hi, i started having these linking errs when using monolithic builds... This is probably a consequence of some change I made, but I don't know anything about monolithic builds (do I do them?) or where information regarding them is contained. It looks as though maybe Inset

Re: monolithic build linking problems

2008-03-01 Thread rgheck
i fixed this. anyway there is still problem: GuiPainter.cpp: At global scope: GuiPainter.cpp:433: error: redefinition of 'const int lyx::frontend::d' GuiFontMetrics.cpp:180: error: 'const int lyx::frontend::d' previously defined here Try putting both of these variables in an anonymous nam

Re: monolithic build linking problems

2008-03-01 Thread rgheck
Pavel Sanda wrote: GuiPainter.cpp: At global scope: GuiPainter.cpp:433: error: redefinition of 'const int lyx::frontend::d' GuiFontMetrics.cpp:180: error: 'const int lyx::frontend::d' previously defined here Try putting both of these variables in an anonymous namespace. hm, d

Re: Layout combobox filtering using the keyboard

2008-03-04 Thread rgheck
Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: I like this idea, too. All we'd need to do is introduce a "Category" tag in the layout files, and I guess a corresponding enum. Should be quite simple, really, though going through all the layout files and adding a "Categor

Wiki Upload

2008-03-04 Thread rgheck
I seem to have lost the upload info Can someone send it to me? I'd like to upload a shot of the new citation dialog. rh

Re: Layout combobox filtering using the keyboard

2008-03-04 Thread rgheck
Jean-Marc Lasgouttes wrote: rgheck <[EMAIL PROTECTED]> writes: My plan was to have e.g. Category Section in layout files, but then to use an enum in Layout.cpp. If you prefer a string in the latter case, I can use one, but I'm guessing that's not what you meant. It

Layout Categories

2008-03-05 Thread rgheck
This is in. See 23501-3. You want Layout::category(). rh

[PATCH] Custom LayoutIterator

2008-03-05 Thread rgheck
In r23505, I removed the ability to index into the LayoutList held in a TextClass, because it seemed too implementation dependent, and just ugly. I replaced it with an iterator. Unfortunately, the iterator was kind of ugly too, because it wasn't returning pointers to Layouts but rather pointe

Re: tex2lyx doesn't compile

2008-03-06 Thread rgheck
Abdelrazak Younes wrote: Fixed. Please take care of tex2lyx next time Richard. Yes, sorry. I usually compile in src/ and forget about tex2lyx. rh

Re: [PATCH] Custom LayoutIterator

2008-03-06 Thread rgheck
Abdelrazak Younes wrote: rgheck wrote: In r23505, I removed the ability to index into the LayoutList held in a TextClass, because it seemed too implementation dependent, and just ugly. I replaced it with an iterator. Unfortunately, the iterator was kind of ugly too, because it wasn&#

Missing \end_layout

2008-03-06 Thread rgheck
I'm getting some errors when opening the User's Guide etc: Unknown token, Undefinable structure, skipping. Unknown token, \end_layout, skipping. Paragraph ended in line 16837 Missing \end_layout. Unknown token, subcaptionText, skipping. Unknown token, Platypus, skipping. Unknown token, \end_layou

[PATCH] LayoutList Changes

2008-03-06 Thread rgheck
Per earlier discussions, the attached patch changes LayoutList from a vector to a vector. Most of the changes are relatively straightforward, but let me ask for comments first. rh Index: src/LayoutPtr.h === --- src/LayoutPtr.h (

Paragraph::layout()

2008-03-06 Thread rgheck
It seems to me that we could just about do for Paragraph the kind of thing we've been doing elsewhere: Change the associated LayoutPtr to a Layout const &. To do so, we'd need to provide a default Layout on construction, but we more or less have this. We could just grab it from the default Ba

TextClass::floatlist_ and TextClass::counters_

2008-03-06 Thread rgheck
Does anyone know why these are boost::shared_ptrs? I don't myself see any reason for this in the current implementation, and I think am pretty sure it can be the source of bugs. Reason: DocumentClass objects are created from BaseClass objects. But now all such objects share a single floatlist

<    3   4   5   6   7   8   9   10   11   12   >