Re: LyX's master is now uncompilable

2015-10-20 Thread Georg Baum
Guillaume Munch wrote: > I'll let Vincent decide whether he wants to make this change. Sure, our messages crossed each other, I would not have suggested that if I knew that he had time to test. The compilation error could btw easily be fixed by moving the implementation of the methods in a

Re: LyX's master is now uncompilable

2015-10-20 Thread Vincent van Ravesteijn
Op 19-10-2015 om 23:36 schreef Guillaume Munch: Le 19/10/2015 21:59, Vincent van Ravesteijn a écrit : Op 19 okt. 2015 22:51 schreef "Guillaume Munch" >: > > Le 19/10/2015 21:34, Georg Baum a écrit : >> >> >> The message on the list is related to commit

Re: LyX's master is now uncompilable

2015-10-20 Thread Vincent van Ravesteijn
Op 20-10-2015 om 20:06 schreef Georg Baum: Guillaume Munch wrote: I'll let Vincent decide whether he wants to make this change. Sure, our messages crossed each other, I would not have suggested that if I knew that he had time to test. The compilation error could btw easily be fixed by moving

LyX's master is now uncompilable

2015-10-19 Thread Uwe Stöhr
Dear LyXers, one of todays' commits broke the compilation for me with MSVC: C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(982): error C2491: 'std::numpunct<_Elem>::id': Definition of static data member for dllimport is not allowed

Re: LyX's master is now uncompilable

2015-10-19 Thread Uwe Stöhr
Am 19.10.2015 um 16:14 schrieb Uwe Stöhr: one of todays' commits broke the compilation for me with MSVC: C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(982): error C2491: 'std::numpunct<_Elem>::id': Definition of static data member for dllimport is not allowed

Re: LyX's master is now uncompilable

2015-10-19 Thread Guillaume Munch
Le 19/10/2015 15:14, Uwe Stöhr a écrit : Dear LyXers, one of todays' commits broke the compilation for me with MSVC: C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(982): error C2491: 'std::numpunct<_Elem>::id': Definition of static data member for dllimport is not

Re: LyX's master is now uncompilable

2015-10-19 Thread Georg Baum
Guillaume Munch wrote: > The former. If we are supposed to include support/docstream.h to use > odocstringstream, shouldn't the latter be defined in docstream.h instead > of strfwd.h? (or the fix be moved to strfwd.h which is already included > by docstream.h via docstring.h?) That was the

Re: LyX's master is now uncompilable

2015-10-19 Thread Georg Baum
Guillaume Munch wrote: > Is that all the information that the compiler gives you? Does it not > give you the name of the file? This is the kind of error messages you often get from templates. The compiler gives the name of the file where the error occurs, but it is a system header and not in

Re: LyX's master is now uncompilable

2015-10-19 Thread Guillaume Munch
Le 19/10/2015 22:01, Georg Baum a écrit : Guillaume Munch wrote: The former. If we are supposed to include support/docstream.h to use odocstringstream, shouldn't the latter be defined in docstream.h instead of strfwd.h? (or the fix be moved to strfwd.h which is already included by docstream.h

Re: LyX's master is now uncompilable

2015-10-19 Thread Vincent van Ravesteijn
Op 19 okt. 2015 22:51 schreef "Guillaume Munch" : > > Le 19/10/2015 21:34, Georg Baum a écrit : >> >> >> The message on the list is related to commit e948caf6, which is supposed to >> fix exactly this issue. What I do not understand it why the fix does not >> work for your recent

Re: LyX's master is now uncompilable

2015-10-19 Thread Guillaume Munch
Le 19/10/2015 21:34, Georg Baum a écrit : The message on the list is related to commit e948caf6, which is supposed to fix exactly this issue. What I do not understand it why the fix does not work for your recent changes. Maybe you forgot to include docstream.h somewhere or got the include order

Re: LyX's master is now uncompilable

2015-10-19 Thread Guillaume Munch
Le 19/10/2015 21:59, Vincent van Ravesteijn a écrit : Op 19 okt. 2015 22:51 schreef "Guillaume Munch" >: > > Le 19/10/2015 21:34, Georg Baum a écrit : >> >> >> The message on the list is related to commit e948caf6, which is supposed to >> fix exactly

Re: LyX's master is now uncompilable

2015-10-19 Thread Vincent van Ravesteijn
Op 19-10-2015 om 19:04 schreef Uwe Stöhr: Am 19.10.2015 um 18:26 schrieb Guillaume Munch: I fail to see a problem with this commit after reading it again. I would like to do some trial-and-error but not being able to reproduce makes it complicated. It is also not clear to me what triggers

Re: LyX's master is now uncompilable

2015-10-19 Thread Uwe Stöhr
Am 19.10.2015 um 21:29 schrieb Vincent van Ravesteijn: I fixed it at 10d7f6d. Many thanks Vincent! This fixes the compilation for me. best regards Uwe

Re: LyX's master is now uncompilable

2015-10-19 Thread Uwe Stöhr
Am 19.10.2015 um 18:26 schrieb Guillaume Munch: I fail to see a problem with this commit after reading it again. I would like to do some trial-and-error but not being able to reproduce makes it complicated. It is also not clear to me what triggers the error. Is that all the information that

Re: LyX's master is now uncompilable

2015-10-19 Thread Guillaume Munch
Le 19/10/2015 16:50, Uwe Stöhr a écrit : Am 19.10.2015 um 16:14 schrieb Uwe Stöhr: one of todays' commits broke the compilation for me with MSVC: C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\xstring(982): error C2491: 'std::numpunct<_Elem>::id': Definition of static data