Le 05/10/2020 à 18:43, José Abílio Matos a écrit :
On Monday, October 5, 2020 5:19:46 PM WEST Jean-Marc Lasgouttes wrote:
Fixed
JMarc
Now, if I may ask what about the following kind of warning:
In file included from ./ui_TabularUi.h:28:
Le 05/10/2020 à 21:38, José Abílio Matos a écrit :
I created a new directory. And then ran configure on that directory using the
CC and CXX environment variables to force clang.
This is what I get. I am using qt-5.15.1 FWIW:
/home/jamatos/lyx/lyx/src/frontends/qt/GuiView.cpp:221:11: warning:
On Monday, October 5, 2020 6:09:40 PM WEST Jean-Marc Lasgouttes wrote:
> Le 05/10/2020 à 18:43, José Abílio Matos a écrit :
> > On Monday, October 5, 2020 5:19:46 PM WEST Jean-Marc Lasgouttes wrote:
> >> Fixed
> >>
> >> JMarc
> >
> > Now, if I may ask what about the following kind of warning:
>
Le 05/10/2020 à 17:50, José Abílio Matos a écrit :
On Monday, October 5, 2020 2:13:35 PM WEST Jean-Marc Lasgouttes wrote:
Yes, clang 10 does
JMarc
BTW compiling with clang 11 and without changing the compile flags I get lots
(in the tens) of warnings like this:
On Monday, October 5, 2020 5:19:46 PM WEST Jean-Marc Lasgouttes wrote:
> Fixed
>
> JMarc
Now, if I may ask what about the following kind of warning:
In file included from ./ui_TabularUi.h:28:
/home/jamatos/lyx/lyx/src/frontends/qt/GuiSetBorder.h:30:59: warning: 'QFlags'
is deprecated: Use
On 10/5/20 11:50 AM, José Abílio Matos wrote:
> On Monday, October 5, 2020 2:13:35 PM WEST Jean-Marc Lasgouttes wrote:
>> Yes, clang 10 does
>>
>> JMarc
> BTW compiling with clang 11 and without changing the compile flags I get lots
> (in the tens) of warnings like this:
>
>
On 10/5/20 12:19 PM, Jean-Marc Lasgouttes wrote:
> Le 05/10/2020 à 17:50, José Abílio Matos a écrit :
>> On Monday, October 5, 2020 2:13:35 PM WEST Jean-Marc Lasgouttes wrote:
>>> Yes, clang 10 does
>>>
>>> JMarc
>>
>> BTW compiling with clang 11 and without changing the compile flags I
>> get
On Sun, Oct 04, 2020 at 07:18:07PM +0300, Yuriy Skalko wrote:
> > And now clang++ 10 complains a lot...
>
> And this patch should fix the rest.
Looks good to me. P
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
On Sun, Oct 04, 2020 at 07:27:28PM +0300, Yuriy Skalko wrote:
> @@ -4010,10 +4009,7 @@ InsetLabel const * Buffer::insetLabel(docstring const
> & label,
>
> bool Buffer::activeLabel(docstring const & label) const
> {
> - if (!insetLabel(label, true))
> - return false;
> -
> -
Le 05/10/2020 à 09:20, Pavel Sanda a écrit :
On Sun, Oct 04, 2020 at 07:27:28PM +0300, Yuriy Skalko wrote:
diff --git a/src/LyXVC.cpp b/src/LyXVC.cpp
index 806d5e8143..9af9372cbe 100644
--- a/src/LyXVC.cpp
+++ b/src/LyXVC.cpp
@@ -348,9 +348,7 @@ string LyXVC::toggleReadOnly()
bool
Le 04/10/2020 à 18:18, Yuriy Skalko a écrit :
And now clang++ 10 complains a lot...
And this patch should fix the rest.
This one is in too.
We are almost there :)
JMarc
In file included from ../../../../master/src/frontends/qt/Dialog.cpp:15:
On Mon, Oct 05, 2020 at 09:33:48AM +0200, Jean-Marc Lasgouttes wrote:
> Le 05/10/2020 ?? 09:20, Pavel Sanda a écrit :
> >On Sun, Oct 04, 2020 at 07:27:28PM +0300, Yuriy Skalko wrote:
> >>diff --git a/src/LyXVC.cpp b/src/LyXVC.cpp
> >>index 806d5e8143..9af9372cbe 100644
> >>--- a/src/LyXVC.cpp
>
See attached.
Kornel
pgpzjOFaqkagd.pgp
Description: Digitale Signatur von OpenPGP
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
> Ok, probably question of habit. When I see former three lines like above I
> immediately
> know what's going on. With new changes and I need to stop and start thinking
> what it does...
>
> Pavel
Just look at the return expression as the answer to the question in
function name:
> bool
> What happens if size_t numberofcells is 0 and cell is also 0? What is 0
> - 1 for an unsigned int? Maybe numberofcells can't be 0, but still it
> seems a bit confusing. I'd suggest:
>
> return cell + 1 >= numberofcells;
>
> instead.
>
> Riki
I assume that if numberofcells is 0 there
Am Mon, 5 Oct 2020 10:48:25 +0200
schrieb Kornel Benko :
> Am Mon, 5 Oct 2020 10:34:51 +0200
> schrieb Jean-Marc Lasgouttes :
>
> > Le 05/10/2020 à 10:20, Kornel Benko a écrit :
> > >
> > > See attached.
> >
> > Weird, I do not see that. Could you give hints on ways to reproduce it?
> >
Am Mon, 5 Oct 2020 13:26:18 +0300
schrieb Yuriy Skalko :
> > This one is in too.
> >
> > We are almost there :)
> >
> > JMarc
>
> Yes, I missed these. Now it should be complete. Does Clang agree with me? :)
>
> Yuriy
No warnings now concerning 'override' with clang8.0.0
Kornel
Le 05/10/2020 à 10:20, Kornel Benko a écrit :
See attached.
Weird, I do not see that. Could you give hints on ways to reproduce it?
Does it depend on screen font? Zoom level?
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
> This one is in too.
>
> We are almost there :)
>
> JMarc
Yes, I missed these. Now it should be complete. Does Clang agree with me? :)
Yuriy
From 8f625dd2931ad3a90187c1f70579c614003be87c Mon Sep 17 00:00:00 2001
From: Yuriy Skalko
Date: Mon, 5 Oct 2020 13:22:55 +0300
Subject: [PATCH] Amend
On Mon, Oct 05, 2020 at 01:48:20PM +0300, Yuriy Skalko wrote:
> > Ok, probably question of habit. When I see former three lines like above I
> > immediately
> > know what's going on. With new changes and I need to stop and start
> > thinking
> > what it does...
> >
> > Pavel
>
> Just look at
Am Mon, 5 Oct 2020 10:34:51 +0200
schrieb Jean-Marc Lasgouttes :
> Le 05/10/2020 à 10:20, Kornel Benko a écrit :
> >
> > See attached.
>
> Weird, I do not see that. Could you give hints on ways to reproduce it?
> Does it depend on screen font? Zoom level?
>
> JMarc
To reproduce here:
1.)
Le 05/10/2020 à 13:03, Yuriy Skalko a écrit :
I assume that if numberofcells is 0 there cannot be 0-th cell, but it
still worth to change the code. Another question is why to bother with
unsigned's usage at all? In my experience unsigned types are only useful
for flag values when definitely will
I committed the updated patch.
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Le 05/10/2020 à 12:26, Yuriy Skalko a écrit :
Yes, I missed these. Now it should be complete. Does Clang agree with me? :)
Yes, clang 10 does :)
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
On Monday, October 5, 2020 1:52:19 PM WEST Jean-Marc Lasgouttes wrote:
> C++ stl uses unsigned for vector indices.
>
> JMarc
What the *man* has to say about that (pag. 123 from the article below):
" The most contentious part of getting span into C++20 turned out to be the
type of subscripts
Le 05/10/2020 à 16:27, José Abílio Matos a écrit :
On Monday, October 5, 2020 1:52:19 PM WEST Jean-Marc Lasgouttes wrote:
C++ stl uses unsigned for vector indices.
JMarc
What the *man* has to say about that (pag. 123 from the article below):
So we fork the standard library?
JMarc
--
Le 05/10/2020 à 05:29, Thibaut Cuvelier a écrit :
Dear list,
While working on the DocBook support, there was the idea to have an
alpha build (or any other kind of prerelease) of LyX 2.4, at least for
Linux (Windows would be nice to have too), to help people test the new
DocBook support.
As
On Mon, Oct 05, 2020 at 12:54:18PM +0200, Pavel Sanda wrote:
> On Mon, Oct 05, 2020 at 01:48:20PM +0300, Yuriy Skalko wrote:
> > > Ok, probably question of habit. When I see former three lines like above
> > > I
> > > immediately
> > > know what's going on. With new changes and I need to stop
Le 05/10/2020 à 17:06, Scott Kostyshak a écrit :
After thinking about it more though, I agree that the new version seems
to be better in terms of having only one return, although it's
interesting that some minor complexity (e.g., the cast or the explicit
comparison to nullptr) has to be added to
On Mon, Oct 05, 2020 at 05:13:09PM +0200, Jean-Marc Lasgouttes wrote:
> Le 05/10/2020 à 17:06, Scott Kostyshak a écrit :
> > After thinking about it more though, I agree that the new version seems
> > to be better in terms of having only one return, although it's
> > interesting that some minor
On 10/5/20 7:03 AM, Yuriy Skalko wrote:
>> What happens if size_t numberofcells is 0 and cell is also 0? What is 0
>> - 1 for an unsigned int? Maybe numberofcells can't be 0, but still it
>> seems a bit confusing. I'd suggest:
>>
>> return cell + 1 >= numberofcells;
>>
>> instead.
>>
>> Riki
>
On 10/5/20 11:06 AM, Scott Kostyshak wrote:
> On Mon, Oct 05, 2020 at 12:54:18PM +0200, Pavel Sanda wrote:
>> On Mon, Oct 05, 2020 at 01:48:20PM +0300, Yuriy Skalko wrote:
Ok, probably question of habit. When I see former three lines like above I
immediately
know what's going on.
On 10/5/20 3:33 AM, Jean-Marc Lasgouttes wrote:
> Le 05/10/2020 à 09:20, Pavel Sanda a écrit :
>> On Sun, Oct 04, 2020 at 07:27:28PM +0300, Yuriy Skalko wrote:
>>> diff --git a/src/LyXVC.cpp b/src/LyXVC.cpp
>>> index 806d5e8143..9af9372cbe 100644
>>> --- a/src/LyXVC.cpp
>>> +++ b/src/LyXVC.cpp
>>>
On Monday, October 5, 2020 2:13:35 PM WEST Jean-Marc Lasgouttes wrote:
> Yes, clang 10 does
>
> JMarc
BTW compiling with clang 11 and without changing the compile flags I get lots
(in the tens) of warnings like this:
/home/jamatos/lyx/lyx/src/insets/InsetTabular.h:92:7: warning: definition of
34 matches
Mail list logo
