Re: Bug 6454: Where Things Stand

2010-03-18 Thread Dov Feldstern
Whoops, adding back the list (haven't done this for a while...!) On Thu, Mar 18, 2010 at 11:22 PM, Dov Feldstern wrote: > On Thu, Mar 18, 2010 at 5:48 PM, rgheck wrote: > . > . >> I'm guessing that this is the cause of the problem. >> >> >>

Re: Bug 6454: Where Things Stand

2010-03-18 Thread Dov Feldstern
On Thu, Mar 18, 2010 at 11:47 PM, rgheck wrote: > > And adding the list here, too > > On 03/18/2010 05:22 PM, Dov Feldstern wrote: >> >> On Thu, Mar 18, 2010 at 5:48 PM, rgheck  wrote: >> . >> . >> >>> I'm guessing that this is the cause

Re: Bug 6454: Where Things Stand

2010-03-18 Thread Dov Feldstern
On Fri, Mar 19, 2010 at 1:22 AM, rgheck wrote: > On 03/18/2010 07:01 PM, Dov Feldstern wrote: >> >> So, in order to figure this out, I added the debug prints mentioned >> above, and then I noticed that only when we're at the end of a word, >> but not anywhere el

Re: Bug 6454: Where Things Stand

2010-03-18 Thread Dov Feldstern
On Fri, Mar 19, 2010 at 1:25 AM, Dov Feldstern wrote: > On Fri, Mar 19, 2010 at 1:22 AM, rgheck wrote: >> On 03/18/2010 07:01 PM, Dov Feldstern wrote: >>> >>> So, in order to figure this out, I added the debug prints mentioned >>> above, and then I noticed

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
re correct, and whether we want to implement them in each case... Miki "Abdelrazak Younes" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Dov Feldstern wrote: , unless the user explicitly changes it with F12 (\language hebrew), the cursor will NOT MOVE, and the t

Re: was: Re: WANTED: users of Right-To-Left languages who want proper support in LyX 1.5

2007-06-15 Thread Dov Feldstern
Dov Feldstern wrote: Miki Dovrat wrote: I was going to say, let the cursor always stay where it is, and the user will learn to press END (end of line) to move it to continue typing. It is logical, (not in the "logical" direction sense), expected and easily adapted to by the user, as

Re: help needed from BiDi people

2007-06-17 Thread Dov Feldstern
Mostafa, you're able to generate Farsi dvi documents, right? Mostafa Vahedi wrote: It doesn't seem to be a bug. Because when some words in ARABIC are written inside a LATIN paragraph the command "\R{arabic phrase}" is used to indicate that. The command "\R{arabic phrase}" is supposed to change

Re: help needed from BiDi people

2007-06-17 Thread Dov Feldstern
Uwe Stöhr wrote: Mostafa Vahedi schrieb: It doesn't seem to be a bug. > Because when some words in ARABIC are written inside a LATIN paragraph > the command "\R{arabic phrase}" is used to indicate that. The command > "\R{arabic phrase}" is supposed to change the language to ARABIC too. It

Re: help needed from BiDi people

2007-06-17 Thread Dov Feldstern
arabi and arabtex, so at the moment I only have arabi installed. Anyhow, at least I can try some of these things out now, see below... Uwe Stöhr wrote: Dov Feldstern schrieb: Uwe, what are you basing this claim on? > And how do you know that it > doesn't really work? Test out the s

Insets Data Structure (was: Re: 20% speedup of paragraph redraw with simple patch)

2007-06-17 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Hmm, I just came across this yesterday when trying to figure out Dov> what was going on with bug 3011, and wondered about it. I'm not Dov> sure if this is what you mean or not, bu

RTL justification bug

2007-06-18 Thread Dov Feldstern
Hi! Here's another RTL regression --- I think this should be really easy to solve for anyone familiar with the painting code. I'd be happy to try and help out if necessary. http://bugzilla.lyx.org/show_bug.cgi?id=3889 Thanks! Dov

Re: help needed from BiDi people

2007-06-18 Thread Dov Feldstern
Uwe Stöhr wrote: > You are probably right but AFAIK, the distinction between \AR and \FR is only useful when you > specifically use ARABI. > > I am only repeating here... Me too ;-): Arabi provides the input encoding cp1256 so without arabi, no Arabic, especially on Windows. So to come t

Re: Insets Data Structure

2007-06-18 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Hmm, I just came across this yesterday when trying to figure out Dov> what was going on with bug 3011, and wondered about it. I'm no

Arabi / ArabTeX for Arabic

2007-06-18 Thread Dov Feldstern
Hi! Here are some more details about getting Arabic working in LyX --- with ArabTeX or with Arabi. (I'm on debian linux, using texlive; and I still don't understand a lot of what's going on. YMMV.) ArabTeX actually currently works better than Arabi (mainly, I guess, because it's what was ori

Re: [patch] fix bug 2928: make Arabic and Farsi correctly usable

2007-06-21 Thread Dov Feldstern
Uwe Stöhr wrote: Mostafa Vahedi schrieb: > See the attached patch. I implemented this but disabled it because > \TOCLanguage gives me the error > "unknown command". Therefore your example-lyxified doesn't compile. The command "\TOCLanguage{}" is defined after the call to BABEL in Latex Pre

Re: Arabi / ArabTeX for Arabic

2007-06-21 Thread Dov Feldstern
Uwe Stöhr wrote: Actually, Mostafa has fixed the last *two* issues for Farsi, but not for Arabic, so as not to interfere with ArabTex. But at least the know-how is already in the sources. We only need to figure out how to allow the option of either Arabi or ArabTeX, so that one doesn't break

Re: character pairs such as parenthesis in Farsi (a patch)

2007-06-21 Thread Dov Feldstern
Mostafa Vahedi wrote: Currently (only) Unicode is used for Farsi as the input encoding. Moreover in Unicode the openning parenthesis is always the left one (independent of the language) I have modified the code to reverse the direction of the character-pairs when it wants to display the characters

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-21 Thread Dov Feldstern
I will test this now. But even if it all works, this is *not* OK as it is --- it breaks ArabTeX Arabic. Please see the email I sent earlier tonight for a patch which separates between arabi and arabtex. This patch should be implemented over the arabic_arabi language. I'll get back to you regar

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-21 Thread Dov Feldstern
Uwe Stöhr wrote: Dov Feldstern schrieb: I will test this now. But even if it all works, this is *not* OK as it is --- it breaks ArabTeX Arabic. I don't understand. Currently ArabTeX is never loaded by LyX for Arabic documents so it is also not used. My patch requires arabi for

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-21 Thread Dov Feldstern
Uwe Stöhr wrote: Uwe Stöhr schrieb: I don't understand. Currently ArabTeX is never loaded by LyX for Arabic documents so it is also not used. Bug 2928 is the prove for my statement. Bug 2928 occurs because the \R command is not defined. But when ArabTeX was loaded \R would have been defined

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-21 Thread Dov Feldstern
I'm resending this message, as only about half my emails seem to be getting through tonight. My apologies if you're receiving it twice... Uwe Stöhr wrote: Dov Feldstern schrieb: I will test this now. But even if it all works, this is *not* OK as it is --- it breaks ArabTeX Arabic.

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-21 Thread Dov Feldstern
Uwe Stöhr wrote: Dov Feldstern schrieb: So my patch can't break arabTeX as it is already not used. Correct me when I'm wrong. see http://permalink.gmane.org/gmane.editors.lyx.devel/88100. If you follow the instructions there, ArabTeX works perfectly alright in LyX. You procedur

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-21 Thread Dov Feldstern
Uwe Stöhr wrote: Dov Feldstern schrieb: To repeat myself: ArabTeX without arabi can't be used due to the missing babel interface and ArabTeX is not babel-based, and therefore doesn't require a babel interface. But LyX currenly uses babel to handle the different languages. Theref

Arabic with Arabi / ArabTeX (take 2)

2007-06-22 Thread Dov Feldstern
Hi! First of all, I just want to apologize to you, Uwe: I feel that we were getting very argumentative last night, and I'm not sure why... I'll blame it on the hour and on the fact that I was getting very frustrated with the fact that not all my messages were making it through for some reason

Re: Arabic with Arabi / ArabTeX (take 2)

2007-06-22 Thread Dov Feldstern
Uwe Stöhr wrote: Dov Feldstern schrieb: First of all, I just want to apologize to you, Uwe: I feel that we were getting very argumentative last night, and I'm not sure why... No problem. I think such discussions are needed to get a decision. So what about the following: - I commi

Re: Arabic with Arabi / ArabTeX (take 2)

2007-06-22 Thread Dov Feldstern
Alfredo Braunstein wrote: Dov Feldstern wrote: Hi! First of all, I just want to apologize to you, Uwe: I feel that we were getting very argumentative last night, and I'm not sure why... I'll blame it on the hour and on the fact that I was getting very frustrated with the fact that

Re: Arabic with Arabi / ArabTeX (take 2)

2007-06-22 Thread Dov Feldstern
Mostafa Vahedi wrote: If we are going to support both ARABI and ArabTeX for Arabic then we should also see how we can combine them in LaTeX terms. I will do that and I will let you know the result. Therefore as I prepared an skeleton (how-to) for writing Farsi based on ARABI, I will prepare on

Re: character pairs such as parenthesis in Farsi (a patch)

2007-06-22 Thread Dov Feldstern
Mostafa Vahedi wrote: Mostafa Vahedi wrote: Currently (only) Unicode is used for Farsi as the input encoding. Moreover in Unicode the openning parenthesis is always the left one (independent of the language) I have modified the code to reverse the direction of the character-pairs when it want

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-22 Thread Dov Feldstern
(Again, resending because it didn't arrive the first time; sorry if you got it twice) Uwe Stöhr wrote: Dov Feldstern schrieb: The question is, should we really go to all this trouble? (Well, not so much, but (a) should we separate between ArabTeX and Arabi, and (b) should we update ly

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-23 Thread Dov Feldstern
=== --- src/Text.cpp(revision 18871) +++ src/Text.cpp(working copy) @@ -369,7 +369,8 @@ if (isPrintable(c)) { Language const * language = font.language(); if (language->rightToLeft()) { - if (langu

build problems with r18872

2007-06-23 Thread Dov Feldstern
I'm getting this message: No rule to make target `de/ExternesMaterialQt4.png', needed by `all-am'. Stop. I did a distclean and reconfigured, but still doesn't help... Thanks! Dov

Arabic Wiki Page

2007-06-23 Thread Dov Feldstern
Hi! Once we do the ArabTeX / Arabi separation, the Wiki page will have to be updated (if you want, I can try to make the changes myself, but I didn't want to do it without your OK, Uwe): * the cuaArab.bind file should have for the F12 key: "language arabic_arabtex" or "language arabic_arabi

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-25 Thread Dov Feldstern
Any thoughts on this? Attached a newer version of the patch, the only difference is incrementing the format number by one, after Jurgen's format change. Dov Feldstern wrote: Uwe Stöhr wrote: Attached is Dov's latest patch. I added the font encoding stuff and the fileformat cha

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-25 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Any thoughts on this? Attached a newer version of the patch, the Dov> only difference is incrementing the format number by one, after Dov> Jurgen's format change. I'll let J

[patch] Re: RTL justification bug

2007-06-25 Thread Dov Feldstern
Dov Feldstern wrote: Hi! Here's another RTL regression --- I think this should be really easy to solve for anyone familiar with the painting code. I'd be happy to try and help out if necessary. http://bugzilla.lyx.org/show_bug.cgi?id=3889 Thanks! Dov Hi! Attached find a patc

Re: [patch] Re: RTL justification bug

2007-06-26 Thread Dov Feldstern
Stefan Schimanski wrote: +// If the last logical character is a separator, skip it, unless +// it's in the last row of a paragraph +if (end > 0 && end < par.size() && par.isSeparator(end - 1)) +skipped_sep_vpos = bidi.log2vis(end - 1); I thought it's about the visually last

Re: [patch] Re: RTL justification bug

2007-06-26 Thread Dov Feldstern
Martin Vermeer wrote: On Mon, Jun 25, 2007 at 11:17:15PM +0300, Dov Feldstern wrote: Dov Feldstern wrote: Hi! Here's another RTL regression --- I think this should be really easy to solve for anyone familiar with the painting code. I'd be happy to try and help out if necessa

Re: [patch] better fix for bug 2928: make Arabic and Farsi correctly usable

2007-06-26 Thread Dov Feldstern
Uwe Stöhr wrote: Dov Feldstern schrieb: Thanks for taking care of the lyx2lyx stuff! I added the requisite comment to the FORMAT file --- could you just check your name (I'm not sure my accents are correct) and email? The name is fine there. Btw. Why do you have a [EMAIL PROTECTED]

Re: [patch] Re: RTL justification bug

2007-06-26 Thread Dov Feldstern
Stefan Schimanski wrote: Ok, after rereading your previous mail I got it. Would be good to put a better documentation there like: // Spaces at line breaks in bidi text can appear visually in the middle // of a row and must be skipped during painting: // * logically "abc_[HEBREW_\nHEBREW]" //

Re: [patch] for bug 2928: make "arabic_arabtex" correctly usable

2007-06-28 Thread Dov Feldstern
nces file could also be added from within the preferences in the GUI. I'll elaborate below. Uwe Stöhr wrote: Dov Feldstern schrieb: one-time setup for ArabTeX) were not taking effect. It looks like the language switch commands are currently used only if babel is activated. I c

Re: [patch] Re: RTL justification bug

2007-06-28 Thread Dov Feldstern
Dov Feldstern wrote: Stefan Schimanski wrote: Ok, after rereading your previous mail I got it. Would be good to put a better documentation there like: // Spaces at line breaks in bidi text can appear visually in the middle // of a row and must be skipped during painting: // * logically

cusorsX speedup? (was: Re: [patch] Re: RTL justification bug)

2007-06-28 Thread Dov Feldstern
Dov Feldstern wrote: Attached find a patch for this bug. OK? Twice almost the same code sequence. Any chance of factoring this out? I know... But if you'll take a look at the two functions (paintText and cursorX), the loop at the heart of them is very similar, and a lot of the same t

Re: Arabic Wiki Page

2007-06-28 Thread Dov Feldstern
Uwe Stöhr wrote: I think you should add the Linux installation instructions to the existing wiki page behind the Windows install section. The actual page contains the both OSes and can be referenced everywhere. Done. The truth is, I think the instructions there should mostly be relevant to

Re: [patch] Re: RTL justification bug

2007-06-28 Thread Dov Feldstern
José Matos wrote: On Thursday 28 June 2007 21:00:28 Dov Feldstern wrote: I haven't gotten any further comments regarding this patch. Is it OK to go in? Are you sure it is safe? Could have the opinion of other RTL users? Would anyone like the patch attached at http://permalink.gman

Re: Arabic Wiki Page

2007-06-29 Thread Dov Feldstern
Uwe Stöhr wrote: Concerning the page: I would not mention the bind file because this is unnecessary. New users will be scared about every preferences fiddling. We don't use special bind files for the other languages, and when the user is experianced enough, he can create any time later its own

Re: cusorsX speedup?

2007-06-29 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: We would also have to decide where the correct place for this cache is (TextMetrics?); Cursor seems like the ideal place for that. should caching occur for the entire paragraph (or even document), or just for the line which the cursor is in

Re: cusorsX speedup?

2007-06-29 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern writes: Dov> Right now it's being called on every cursor blink, I think (I put Dov> in a debug printout, and it prints on every blink); and what it's Dov> doing every time is to loop over all the characters f

Re: cusorsX speedup?

2007-06-29 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Perhaps, I don't know. But note that the main incentive here is Dov> not the optimization, but the cleaning up of the code. Right now Dov> we have almost identical code in two di

[patch] fix "default" encoding

2007-06-29 Thread Dov Feldstern
Hi! Attached find a patch which fixes some problems that existed with the "default" encoding. Georg and I discussed some of these a few months back, but nothing ever came of it then. Now this patch seems to fix all of the problems that I have with "default" encoding. The attached files are t

Re: Switching to secondary keymap not working properly in LyX 1.5.0rc2?

2007-06-29 Thread Dov Feldstern
GoogleGuy wrote: Hi All, I just compiled LyX 1.5.0rc2 from source, and ran into a keyboard map problem. (I'm using primary and secondary keyboard maps extensively, rather than XKB, because this way LyX shortcuts work no matter the layout, and this, I think, is one of LyX's biggest strengths.)

Re: Switching to secondary keymap not working properly in LyX 1.5.0rc2?

2007-06-29 Thread Dov Feldstern
Dov Feldstern wrote: GoogleGuy wrote: Hi All, I just compiled LyX 1.5.0rc2 from source, and ran into a keyboard map problem. (I'm using primary and secondary keyboard maps extensively, rather than XKB, because this way LyX shortcuts work no matter the layout, and this, I think, is o

Re: Switching to secondary keymap not working properly in LyX 1.5.0rc2?

2007-06-29 Thread Dov Feldstern
GoogleGuy wrote: On Fri, 29 Jun 2007 16:43:42 +0300 Dov Feldstern wrote: First of all, I'm with you --- I also like the keymap feature a lot, I think it's great! Hi Dov, thanks for your support, hopefully this feature is here to stay. I fixed a bug regarding the keymap a coupl

Re: Switching to secondary keymap not working properly in LyX 1.5.0rc2?

2007-06-30 Thread Dov Feldstern
GoogleGuy wrote: On Fri, 29 Jun 2007 17:54:40 +0300 Dov Feldstern wrote: Sorry, I didn't explain myself clearly. I already committed a fix for a *different* keymap bug a few weeks ago, and I thought that that fix was causing your problem. But now I don't think that it's my fix

Re: cusorsX speedup?

2007-06-30 Thread Dov Feldstern
Andre Poenitz wrote: On Fri, Jun 29, 2007 at 11:17:51AM +0300, Dov Feldstern wrote: Right now it's being called on every cursor blink, I think (I put in a debug printout, and it prints on every blink); and what it's doing every time is to loop over all the characters from the beginn

Re: [patch] fix "default" encoding

2007-06-30 Thread Dov Feldstern
Georg Baum wrote: Am Freitag, 29. Juni 2007 15:11 schrieb Dov Feldstern: Just a reminder: "default" is supposed to be exactly like "auto" (i.e., the encoding is determined based on the language), except that it shouldn't output any "inputencoding" commands

Re: source code question about language check in LyX documents

2007-06-30 Thread Dov Feldstern
Richard Heck wrote: Uwe Stöhr wrote: Can anybody help me with this issue?: Special lines should to be added to the preamble whenever e.g. Arabic is used in the document. I know how to do this in Bufferparams.cp when Arabic is the document language: if (language->lang() == "arabic_arabtex")

Re: [patch] fix "default" encoding

2007-07-01 Thread Dov Feldstern
Georg Baum wrote: Am Samstag, 30. Juni 2007 22:10 schrieb Dov Feldstern: That would put knowledge about the switchEncoding internals into the caller. That is dangerous, because the internals might change. I would prefer to be explicit: Let switchEncoding return a std::pair. The bool would

[patch] set language inside new inset to current language (bug 3959)

2007-07-01 Thread Dov Feldstern
Hi! Attached find a patch fixing http://bugzilla.lyx.org/show_bug.cgi?id=3959 (which I just opened tonight). Please note that there appears to have been an attempt to explicitly do the opposite of what I'm trying to do here, though for different reasons, I think: r10808, which fixed bug 2115

Re: [patch] fix "default" encoding

2007-07-02 Thread Dov Feldstern
Georg Baum wrote: Dov Feldstern wrote: Index: lyx-devel/src/output_latex.cpp === --- lyx-devel.orig/src/output_latex.cpp2007-06-29 16:02:45.0 +0300 +++ lyx-devel/src/output_latex.cpp2007-07-01 20:52

Re: Need for Mac and RTL beta testers for screen painting performance boost

2007-07-02 Thread Dov Feldstern
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Or you could just replace the two attached files in your tree. Sorry, those won't compile, try these instead. Abdel. Abdel, the attached files seem to be working just fine for me, I don't see anything wrong with the RTL. Is there anything

Re: Arabic Wiki Page

2007-07-02 Thread Dov Feldstern
Uwe Stöhr wrote: Dov Feldstern schrieb: Concerning the page: I would not mention the bind file because this is unnecessary. New users will be scared about every preferences fiddling. We don't use special bind files for the other languages, and when the user is experianced enough, h

Re: [patch] for bug 2928: make "arabic_arabtex" correctly usable

2007-07-02 Thread Dov Feldstern
Uwe Stöhr wrote: First, sorry for the delay. This mail never reached me, I found it by chance in the mail-archive. > All of the problems you're describing are because you haven't performed the one-time setup > required for Arabtex, see http://permalink.gmane.org/gmane.editors.lyx.devel/8810

Keymaps

2007-07-02 Thread Dov Feldstern
Hi! [Don't worry, this is for post-1.5.0] A few times in the past month or two, the issue of whether or not keymaps should be used has come up. I would like to defend the position which says: yes, keymaps are good! and suggest an improvement in how they're used. Let me just start out by say

Bind files for Hebrew & Arabic

2007-07-02 Thread Dov Feldstern
Hi! We would like to add some keybindings for switching languages for Hebrew and Arabic, but I'm not sure where in the tree they belong, so that they will be automatically used (based on the locale?). Also, will the inclusion of cua.bind work correctly (I know it works when I do it in my lyx

Re: [patch] set language inside new inset to current language (bug 3959)

2007-07-02 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern writes: Dov> Hi! Attached find a patch fixing Dov> http://bugzilla.lyx.org/show_bug.cgi?id=3959 (which I just opened Dov> tonight). Dov> Please note that there appears to have been an attempt to Dov> explicitly do

Re: [patch] fix "default" encoding

2007-07-04 Thread Dov Feldstern
Hi! Attached find the (I hope) final version of this patch. I addressed all of the issues which Georg pointed out (Georg, please make sure), and tested this again. I think that this should go in for 1.5.0 if possible, so if I get another OK (I'm assuming Georg's unless I hear otherwise) I'll

Re: [patch] set language inside new inset to current language (bug 3959)

2007-07-04 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern writes: Dov> I think that I'll try to create a constructor which accepts a Dov> font to be used as the initial font. Does this sound all right? That may turn out to be complicated. Do you really need to set the font i

Re: [patch] set language inside new inset to current language (bug 3959)

2007-07-05 Thread Dov Feldstern
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: Dov> Therefore, attached is the original patch, with a comment Dov> explaining the situation. OK to commit? OK with me. me too. Abdel. Thanks, guys. Committed as r18993. I still need another OK for the "default" encoding patch (attach

Re: [patch] set language inside new inset to current language (bug 3959)

2007-07-05 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: I still need another OK for the "default" encoding patch (attached in http://permalink.gmane.org/gmane.editors.lyx.devel/89143), which I think is important for 1.5.0. Could anyone please take a look? If Georg has given his OK I think

Re: [patch] Re: RTL justification bug

2007-07-08 Thread Dov Feldstern
Dov Feldstern wrote: José Matos wrote: On Thursday 28 June 2007 21:00:28 Dov Feldstern wrote: I haven't gotten any further comments regarding this patch. Is it OK to go in? Are you sure it is safe? Could have the opinion of other RTL users? Would anyone like the patch attached at

[patch] bug 1820 --- footnotes in different language

2007-07-08 Thread Dov Feldstern
Hi! Attached find a patch for bug 1820, which has resisted solution for a long time. After a lot of work done by others to tidy up the output_latex code in the past few months, the infrastructure was now in place so that finally we can provide a solution. It would be good if this could still

Re: [patch] bug 1820 --- footnotes in different language

2007-07-08 Thread Dov Feldstern
Dov Feldstern wrote: are attached in bugzilla (though I'm having trouble downloading attachments from bugzilla, at the moment, anyone know anything about this?) Dov I was able to download the attachments from bugzilla now, and I see there's one case which still isn't solv

Re: [patch] Re: RTL justification bug

2007-07-09 Thread Dov Feldstern
José Matos wrote: On Monday 09 July 2007 09:50:27 Abdelrazak Younes wrote: I guess the problem is that nobody understands this bidi stuff like you do. I would tend to say "go ahead!", but I am not sure what are my credentials to do so :) Same position for me. The patch looks not so complicate s

Re: [patch] bug 1820 --- footnotes in different language

2007-07-09 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: are attached in bugzilla (though I'm having trouble downloading attachments from bugzilla, at the moment, anyone know anything about this?) Dov I was able to download the attachments from bugzilla now, and I see there's one case which s

Re: [patch] bug 1820 --- footnotes in different language

2007-07-10 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: So, to sum up: the patch attached at http://permalink.gmane.org/gmane.editors.lyx.devel/89376 together with the patch attached here solve bug 1820 completely. Index: src/insets

Re: [patch] bug 1820 --- footnotes in different language

2007-07-11 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern writes: Dov> Do you know why this whole font-change mechanism was originally Dov> added? Consider a footnote with several paragraphs and assume it is typeset in \emph like this: \emph{Some text\footnote{and and explana

Re: Open Patches

2007-07-11 Thread Dov Feldstern
Jürgen Spitzmüller wrote: Michael Gerz wrote: there are three more patches which may be subject to discussion: [patch] bug 1820 --- footnotes in different language (by Dov) As I just posted in a separate message, it turns out that (I'm pretty sure) this will require a format change in or

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
OK, here's my original patch for bug 1820 (without the second part, identical to what I originally sent in). It solves most cases, as far as I can determine is safe (I tried it on my documents with complex bidi / encoding / language transitions), and it does not constitute a format change, IMO.

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Dov Feldstern wrote: encoding / language transitions), and it does not constitute a format change, IMO. I'm not sure this is true, I think even just this patch is a format change... anyone care to take a look?

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Peter Kümmel wrote: Dov Feldstern wrote: OK, here's my original patch for bug 1820 (without the second part, identical to what I originally sent in). It solves most cases, as far as I can determine is safe (I tried it on my documents with complex bidi / encoding / language transitions)

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Enrico Forestieri wrote: Dov, Hi Enrico! Thanks for taking a look at this... :) this is what I did. Without your patch applied, I started a new document, so the language is english, and then activated "View Source". I wrote "bla bla bla ", then switched the language to italian and wrote "BL

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a \selectlanguage{english} inserted before "bla bla bla". But I also see that the whole footnote inset is marked as foreign, so I select the whole of it and mark it as english. Now it is

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a \selectlanguage{english} inserted before "bla bla bla". But I also see that

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Dov Feldstern wrote: Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a \selectlanguage{english} inserted before "bla bla bla". But

Re: [patch] bug 1820 --- footnotes in different language

2007-07-13 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 03:21:42AM +0300, Dov Feldstern wrote: Dov Feldstern wrote: Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content

Re: [patch] bug 1820 --- footnotes in different language

2007-07-13 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 03:05:39AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a

Re: [new patch] bug 1820

2007-07-13 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:48:49AM +0300, Dov Feldstern wrote: I realized that with the partial solution, which fixed some cases, other cases which used to work stopped working. So the only way to go is to provide a complete solution for all cases (well, maybe not

What constitutes a format change?

2007-07-13 Thread Dov Feldstern
Hi w.r.t. bug 1820, I'm getting very confused about what constitutes a format change and what does not. Generally, I think, a format change is when given an existing file F, I used to get latex output X, and due to a change in LyX I now get latex output Y. In such a case, we normally have ly

Re: [new patch] bug 1820

2007-07-13 Thread Dov Feldstern
Dov Feldstern wrote: Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:48:49AM +0300, Dov Feldstern wrote: I realized that with the partial solution, which fixed some cases, other cases which used to work stopped working. So the only way to go is to provide a complete solution for all

1.5.0 release

2007-07-14 Thread Dov Feldstern
Hi! I have a few patches (for bugs 1820, 3613) which have to go in before the final release, because they involve format changes, but which require more work and testing. I realize, however, that this is holding up continued development, and generally developers (much more than the users, I t

Re: [new patch] bug 1820

2007-07-14 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 07:10:10PM +0300, Dov Feldstern wrote: Attached find the latest additions to the patch. Enrico, I think these will solve the samples you sent me, and it seems to still work for the RTL stuff. But I haven't had time to clean up the patc

Re: [new patch] bug 1820

2007-07-14 Thread Dov Feldstern
Joost Verburg wrote: Abdelrazak Younes wrote: Quite frankly, as there is no format change and that this needs some more testing, I'd prefer that you wait for 1.5.1 which will hopefully happen very soon. Just look at my recent brown paper bag which was supposed to be very very safe. According

[patch] bug 3613 (includes format change)

2007-07-14 Thread Dov Feldstern
tation]], [273, []], Index: lyx-devel/development/FORMAT === --- lyx-devel.orig/development/FORMAT 2007-07-15 02:25:40.0 +0300 +++ lyx-devel/development/FORMAT2007-07-15 02:31:28.0 +0300 @@ -1,6 +1

lyx2lyx help

2007-07-15 Thread Dov Feldstern
Hi! Is there any way for me to only apply one of the stages if the original format number of the file being converted was under 249? The problem with my current patch for bug 3613 is this: Files from pre-249 are wrong, but post-249 don't have the problem. So my new stage (277) should only ru

Re: [patch] bug 3613 (includes format change)

2007-07-15 Thread Dov Feldstern
Dov Feldstern wrote: Hi! Attached find a patch for the last remaining problem with bug 3613. It's a format change. The problem it solves is due to some missed cases way back in format change 249. I'm attaching example files which demonstrate the problem (and which this p

Re: [patch] bug 3613 (includes format change)

2007-07-15 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Hi! Attached find a patch for the last remaining problem with bug 3613. It's a format change. The problem it solves is due to some missed cases way back in format change 249. I'm attaching example files which demonstrate the problem

patches 1820, 3613 explained

2007-07-15 Thread Dov Feldstern
Hi! Here I will try to explain my understanding of the issues leading to bugs 1820 and 3613. This is partly because I feel that it's important that as many people as possible be aware of these, for future development; partly in order to explain the patches I'm proposing for these two bugs, so

Re: [new patch] bug 1820

2007-07-16 Thread Dov Feldstern
José Matos wrote: On Sunday 15 July 2007 10:47:46 Martin Vermeer wrote: If the LaTeX output is different, I would say it is a format change... the problem is then to produce a lyx2lyx entry that would modify an old .lyx file upon conversion to the new format so, that it nevertheless produces the

Re: [patch] bug 3613 (includes format change)

2007-07-16 Thread Dov Feldstern
Hi! I haven't gotten any responses to this. I think this patch (http://permalink.gmane.org/gmane.editors.lyx.devel/89975) should go in, I would be happy for people to test it. Can I commit? Dov

[patch] bug 1820 --- cleaned-up patch

2007-07-16 Thread Dov Feldstern
Hi! Attached find a cleaned up version of the patch for 1820, based on the explanations I provided last night (http://permalink.gmane.org/gmane.editors.lyx.devel/89979). I now feel quite confident that this patch is good. I tried it on all the sample files I have and that I created, I tried

  1   2   3   4   5   6   7   8   >