Re: Possible patch for sox build failure on 10.7

[Joshua Root]

On 2017-8-13 01:12 , Ken Cunningham wrote:

Thank you Josh. I missed ./configure --disable-silent-libtool.


I am a bit confused about this. According to 
, 
disable-silent-rules is the default.


For Automake-generated Makefiles, the user may influence the verbosity 
at |configure| run time as well as at |make| run time:


  * Passing --enable-silent-rules to |configure| will cause build rules
to be less verbose; the option --disable-silent-rules will cause
normal verbose output.


But sox's configure.ac has:

AM_SILENT_RULES([yes])

- Josh

Re: Possible patch for sox build failure on 10.7

[Ken Cunningham]

> Thank you Josh. I missed ./configure --disable-silent-libtool.

I am a bit confused about this. According to 
>,
 disable-silent-rules is the default.

For Automake-generated Makefiles, the user may influence the verbosity at 
configure run time as well as at make run time:

 <>  <>Passing --enable-silent-rules to configure will cause build rules to be 
less verbose; the option --disable-silent-rules will cause normal verbose 
output.



Ken

Re: Possible patch for sox build failure on 10.7

[Jan Stary]

On Aug 12 10:56:57, mo...@macports.org wrote:
> On 12 August 2017 at 10:36, Jan Stary wrote:
> >
> > libtool: link: /usr/bin/grep -E -e 
> > "^(sox_.*|lsx_(check_read_params|(close|open)_dllibrary|(debug(_more|_most)?|fail|report|warn)_impl|eof|fail_errno|filelength|find_(enum_(text|value)|file_extension)|getopt(_init)?|lpc10_(create_(de|en)coder_state|(de|en)code)|raw(read|write)|read(_b_buf|buf|chars)|realloc|rewind|seeki|sigfigs3p?|strcasecmp|tell|unreadb|write(b|_b_buf|buf|s)))$"
> >  ".libs/libsox.exp" > ".libs/libsox.expT"
> >
> > Can someone on 10.7 please check that this is the failing grep line?
> > (Not even in connection with SoX, just grep that regexp on anything.)
> 
> Confirming.

Thank you I will ask upstream whether the regexp can be simplified
(or is even up to date), to see if we can avoid the dependency on grep.

Jan

Re: Possible patch for sox build failure on 10.7

[Mojca Miklavec]

On 12 August 2017 at 10:36, Jan Stary wrote:
>
> libtool: link: /usr/bin/grep -E -e 
> "^(sox_.*|lsx_(check_read_params|(close|open)_dllibrary|(debug(_more|_most)?|fail|report|warn)_impl|eof|fail_errno|filelength|find_(enum_(text|value)|file_extension)|getopt(_init)?|lpc10_(create_(de|en)coder_state|(de|en)code)|raw(read|write)|read(_b_buf|buf|chars)|realloc|rewind|seeki|sigfigs3p?|strcasecmp|tell|unreadb|write(b|_b_buf|buf|s)))$"
>  ".libs/libsox.exp" > ".libs/libsox.expT"
>
> Can someone on 10.7 please check that this is the failing grep line?
> (Not even in connection with SoX, just grep that regexp on anything.)

Confirming.

Mojca

Re: Possible patch for sox build failure on 10.7

[Jan Stary]

On Aug 10 06:30:12, j...@macports.org wrote:
> On 2017-8-9 23:15 , Jan Stary wrote:
> > On Aug 09 15:06:35, ken.cunningham.web...@gmail.com wrote:
> > > I can work with you on this. I'll build a failing version and email you 
> > > the entire log off-list tonight.
> > 
> > Thank you Ken.
> > 
> > I looked on the detailed log of vanilla SoX 14.4.2 itself,
> > but cannot find the offending grep. Is it run by SoX's build system,
> > or is the nm/grep combo run by the building robot?
> 
> The addition of --disable-silent-rules in the patch was to hopefully show
> more of the failing command (and it's a good idea anyway since silent rules
> make logs much less useful).

'make V=1' disables the silent rules

$ ./configure --help
--enable-silent-rules   less verbose build output (undo: "make V=1")
--disable-silent-rules  verbose build output (undo: "make V=0")

> This is not something that would be specific to
> the buildbot. I'm not sure, but given what is happening when the error
> occurs, the offending grep command may be invoked by (g)libtool.

Thank you Josh. I missed ./configure --disable-silent-libtool.
Then the full build log (attached) reveals

libtool: link: /usr/bin/grep -E -e 
"^(sox_.*|lsx_(check_read_params|(close|open)_dllibrary|(debug(_more|_most)?|fail|report|warn)_impl|eof|fail_errno|filelength|find_(enum_(text|value)|file_extension)|getopt(_init)?|lpc10_(create_(de|en)coder_state|(de|en)code)|raw(read|write)|read(_b_buf|buf|chars)|realloc|rewind|seeki|sigfigs3p?|strcasecmp|tell|unreadb|write(b|_b_buf|buf|s)))$"
 ".libs/libsox.exp" > ".libs/libsox.expT"

Can someone on 10.7 please check that this is the failing grep line?
(Not even in connection with SoX, just grep that regexp on anything.)

Jan



typescript.gz
Description: application/gunzip

Re: Possible patch for sox build failure on 10.7

[Joshua Root]

On 2017-8-9 23:15 , Jan Stary wrote:

On Aug 09 15:06:35, ken.cunningham.web...@gmail.com wrote:

I can work with you on this. I'll build a failing version and email you the 
entire log off-list tonight.


Thank you Ken.

I looked on the detailed log of vanilla SoX 14.4.2 itself,
but cannot find the offending grep. Is it run by SoX's build system,
or is the nm/grep combo run by the building robot?


The addition of --disable-silent-rules in the patch was to hopefully 
show more of the failing command (and it's a good idea anyway since 
silent rules make logs much less useful). This is not something that 
would be specific to the buildbot. I'm not sure, but given what is 
happening when the error occurs, the offending grep command may be 
invoked by (g)libtool.


- Josh

Re: Possible patch for sox build failure on 10.7

[Jan Stary]

On Aug 09 15:06:35, ken.cunningham.web...@gmail.com wrote:
> I can work with you on this. I'll build a failing version and email you the 
> entire log off-list tonight.

Thank you Ken.

I looked on the detailed log of vanilla SoX 14.4.2 itself,
but cannot find the offending grep. Is it run by SoX's build system,
or is the nm/grep combo run by the building robot?

Jan

> 
> On 2017-08-09, at 9:55 AM, Jan Stary wrote:
> 
> > On Aug 09 08:44:02, ken.cunningham.web...@gmail.com wrote:
> >> 
> >> On 2017-08-09, at 1:05 AM, Joshua Root wrote:
> >> 
> >>> Perhaps someone with access to a 10.7 machine could try this.
> >>> 
> >>> - Josh
> >>> 
> >> 
> >> Yep, that should do it.  Deactivating MacPorts grep, sox build fails - 
> >> activating MacPorts grep fixes the build on 10.7. I have other things 
> >> installed that get pulled in (gsed, otools) so this is not a buildbot, but 
> >> grep should do the trick.
> > 
> > Can anyone please point to the actual grep call that causes this?
> > I would much rather simplify the grep call in SoX itself (if possible)
> > than depend on a specific version of grep (uggh).
> > 
> > Jan
> > 
> 

Re: Possible patch for sox build failure on 10.7

[Kenneth F. Cunningham]

I can work with you on this. I'll build a failing version and email you the 
entire log off-list tonight.

Ken

On 2017-08-09, at 9:55 AM, Jan Stary wrote:

> On Aug 09 08:44:02, ken.cunningham.web...@gmail.com wrote:
>> 
>> On 2017-08-09, at 1:05 AM, Joshua Root wrote:
>> 
>>> Perhaps someone with access to a 10.7 machine could try this.
>>> 
>>> - Josh
>>> 
>> 
>> Yep, that should do it.  Deactivating MacPorts grep, sox build fails - 
>> activating MacPorts grep fixes the build on 10.7. I have other things 
>> installed that get pulled in (gsed, otools) so this is not a buildbot, but 
>> grep should do the trick.
> 
> Can anyone please point to the actual grep call that causes this?
> I would much rather simplify the grep call in SoX itself (if possible)
> than depend on a specific version of grep (uggh).
> 
>   Jan
> 

Re: Possible patch for sox build failure on 10.7

[Jan Stary]

On Aug 09 08:44:02, ken.cunningham.web...@gmail.com wrote:
> 
> On 2017-08-09, at 1:05 AM, Joshua Root wrote:
> 
> > Perhaps someone with access to a 10.7 machine could try this.
> > 
> > - Josh
> > 
> 
> Yep, that should do it.  Deactivating MacPorts grep, sox build fails - 
> activating MacPorts grep fixes the build on 10.7. I have other things 
> installed that get pulled in (gsed, otools) so this is not a buildbot, but 
> grep should do the trick.

Can anyone please point to the actual grep call that causes this?
I would much rather simplify the grep call in SoX itself (if possible)
than depend on a specific version of grep (uggh).

Jan

Re: Possible patch for sox build failure on 10.7

[Joshua Root]

On 2017-8-9 16:44 , Kenneth F. Cunningham wrote:


On 2017-08-09, at 1:05 AM, Joshua Root wrote:


Perhaps someone with access to a 10.7 machine could try this.

- Josh



Yep, that should do it.  Deactivating MacPorts grep, sox build fails - 
activating MacPorts grep fixes the build on 10.7. I have other things installed 
that get pulled in (gsed, otools) so this is not a buildbot, but grep should do 
the trick.


Thanks.


Is sox building on the 10.5 and 10.6 buildbots? If so, don't know how / why.

Can I suggest this patch be applied to all systems <= 10.7? They probably all 
need the new grep to build it.


They don't. This is a problem with the specific version of grep shipped 
with Lion, which has been noted by others, usually in a "this worked on 
10.6 but 10.7 breaks it" kind of way. E.g. 



- Josh

Re: Possible patch for sox build failure on 10.7

[Kenneth F. Cunningham]

On 2017-08-09, at 1:05 AM, Joshua Root wrote:

> Perhaps someone with access to a 10.7 machine could try this.
> 
> - Josh
> 

Yep, that should do it.  Deactivating MacPorts grep, sox build fails - 
activating MacPorts grep fixes the build on 10.7. I have other things installed 
that get pulled in (gsed, otools) so this is not a buildbot, but grep should do 
the trick.

Is sox building on the 10.5 and 10.6 buildbots? If so, don't know how / why. 

Can I suggest this patch be applied to all systems <= 10.7? They probably all 
need the new grep to build it.

Best,

Ken

Re: Possible patch for sox build failure on 10.7

[Ken Cunningham]

I'm travelling with a 10.7 laptop this summer (hence the rash of 10.7 fixes 
I've sent up over the past month). Can give it a try.  --K

> On Aug 9, 2017, at 1:05 AM, Joshua Root  wrote:
> 
> Perhaps someone with access to a 10.7 machine could try this.
> 
> - Josh
> 

Possible patch for sox build failure on 10.7

[Joshua Root]

Perhaps someone with access to a 10.7 machine could try this.

- Josh
diff --git a/audio/sox/Portfile b/audio/sox/Portfile
index 9914efaf31..893c4c68da 100644
--- a/audio/sox/Portfile
+++ b/audio/sox/Portfile
@@ -32,6 +32,12 @@ patchfiles   patch-src-formats.c.diff
 depends_build  \
port:pkgconfig
 
+platform darwin 11 {
+   # System grep fails: "grep: Regular expression too big"
+   depends_build-append\
+   port:grep
+}
+
 depends_lib\
port:flac   \
port:lame   \
@@ -52,11 +58,12 @@ depends_lib \
 
 configure.args \
--enable-largefile  \
-   --disable-silent-libtool\
+   --disable-silent-libtool\
+   --disable-silent-rules  \
--disable-openmp\
--enable-symlinks   \
--without-libltdl   \
-   --with-distro=macosx\
+   --with-distro=macosx
 
 # additional formats
 configure.args-append \