[Mahara-contributors] [Bug 1723961] A patch has been submitted for review

2018-03-06 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8581

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1723961

Title:
  Edit plans more easily from a page

Status in Mahara:
  In Progress

Bug description:
  We have a client who has identified that end users of their Mahara
  installation need to be able to update a plan or task from within a
  blocktype instance and return to the page that they were on for more
  consistent experience.

  Finding their way to the plan or task itself in their portfolio
  content can be several clicks to get to and then several more to
  return to the page or dashboard they were reviewing. This can also be
  exacerbated if the user has a high number of instances of each content
  or page type.

  Because of the above they have required the following enhancements
  added to the Plans blocktype to improve user experience:

  1. a link to edit a plan instance (description, title, tags etc)
  2. a link to add a new task to a plan instance
  3. the ability to edit a task instance (description, title, tags, completion 
date etc)
  4. the ability to mark a task as complete or incomplete from 

  Requirements 1-3, upon save or cancel, will redirect back to the page
  the user was on before entering these pages.

  All editing functionality will only be available to the page owner and
  when in the editing page mode.

  In addition they have also requested the following functionality:
  - the ability to select more than one plan instance per blocktype

  to reduce the unique number of blocktypes required on the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731807] Re: Remove unused code from lib/view.php that was never used correctly

2018-03-06 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731807

Title:
  Remove unused code from lib/view.php that was never used correctly

Status in Mahara:
  Fix Committed

Bug description:
  I noticed a bug in the
  theme/raw/templates/view/blocktypecontainerediting.tpl where there
  were two closing  tags to the one opening  tag (see
  lines 37/38)

  So I wondered why this didn't cause a problem rendering the page and
  found the code would only be rendered if $configure was true.

  And that would only happen if a block instance called render_editing
  with $configure = true

  And I noticed on view/blocks.php that happens when 
  $blockid = $view->get_blockinstance_currently_being_configured();

  But $view->get_blockinstance_currently_being_configured(); always
  returns 0 as the set_blockinstance_currently_being_configured() is
  never called.

  Changing the number from 0 to a valid block number on an edit screen
  and then reloading page gives all manner of errors.

  Looking at the commit that added the set/get functions
  09c73752c11c800dcb2bfbb6606206831f19d439 this was before 1.0 release
  and doesn't look to have been implemented fully.

  We should clean up this area and remove any/all code that is not
  actually being used

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731807/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731807] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8354
Committed: 
https://git.mahara.org/mahara/mahara/commit/e8fe8839957a3fc0b88340ab56314b784f8a3fec
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit e8fe8839957a3fc0b88340ab56314b784f8a3fec
Author: Rebecca Blundell 
Date:   Thu Dec 14 11:46:10 2017 +1300

Bug 1731807 - remove unused blockinstance code

I've removed some more things that don't seem to be needed.

behatnotneeded

Change-Id: I811aff5ac64e0d4178f61d39e19541f7b5e45cea

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731807

Title:
  Remove unused code from lib/view.php that was never used correctly

Status in Mahara:
  Fix Committed

Bug description:
  I noticed a bug in the
  theme/raw/templates/view/blocktypecontainerediting.tpl where there
  were two closing  tags to the one opening  tag (see
  lines 37/38)

  So I wondered why this didn't cause a problem rendering the page and
  found the code would only be rendered if $configure was true.

  And that would only happen if a block instance called render_editing
  with $configure = true

  And I noticed on view/blocks.php that happens when 
  $blockid = $view->get_blockinstance_currently_being_configured();

  But $view->get_blockinstance_currently_being_configured(); always
  returns 0 as the set_blockinstance_currently_being_configured() is
  never called.

  Changing the number from 0 to a valid block number on an edit screen
  and then reloading page gives all manner of errors.

  Looking at the commit that added the set/get functions
  09c73752c11c800dcb2bfbb6606206831f19d439 this was before 1.0 release
  and doesn't look to have been implemented fully.

  We should clean up this area and remove any/all code that is not
  actually being used

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731807/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1017785] Re: Empty blog should display "No entries yet." and "Add one" link

2018-03-06 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1017785

Title:
  Empty blog should display "No entries yet." and "Add one" link

Status in Mahara:
  Fix Committed

Bug description:
  Version: master

  Assumptions
   - Logged in user has one empty journal.

  Actions
   1. Open the empty journal.

  Expected results
   - Lang string "No entries yet. Add one" with link to create a new entry.

  Actual results
   - string: "0 entries"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1017785/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1017785] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8524
Committed: 
https://git.mahara.org/mahara/mahara/commit/5e7609579b2f78d56759f9ecd34dbefaa601337d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 5e7609579b2f78d56759f9ecd34dbefaa601337d
Author: Liam 
Date:   Thu Feb 15 14:05:23 2018 +1300

Bug #1017785: Empty blog should display "No entries yet." and "Add one"
link Edit

updated language string to use a link

works for user, group, institution, and site journals

behatnotneeded

Change-Id: Iffd24c3678f0ce213d7251406dee8bc7ecbfc74a

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1017785

Title:
  Empty blog should display "No entries yet." and "Add one" link

Status in Mahara:
  Fix Committed

Bug description:
  Version: master

  Assumptions
   - Logged in user has one empty journal.

  Actions
   1. Open the empty journal.

  Expected results
   - Lang string "No entries yet. Add one" with link to create a new entry.

  Actual results
   - string: "0 entries"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1017785/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753312] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8570
Committed: 
https://git.mahara.org/mahara/mahara/commit/a02fe666d7ae3e2c0b9e9211892e1365fc64e4dd
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit a02fe666d7ae3e2c0b9e9211892e1365fc64e4dd
Author: Jaque 
Date:   Tue Mar 6 10:08:17 2018 +1300

Bug #1753312: Add block modal legend has not needed background color

Also removed legend padding-top not needed in primary school theme

behatnotneeded

Change-Id: I7d6d2c5341b7cd7ccc147d9261991c0c1992e75c

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753312

Title:
  Add block modal legend has not needed background color/padding

Status in Mahara:
  Fix Committed

Bug description:
  This is in the ocean theme

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753312/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753312] Re: Add block modal legend has not needed background color

2018-03-06 Thread Robert Lyon
The padding issue is in the primaryschool theme

** Changed in: mahara
   Status: In Progress => Fix Committed

** Summary changed:

- Add block modal legend has not needed background color
+ Add block modal legend has not needed background color/padding

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753312

Title:
  Add block modal legend has not needed background color/padding

Status in Mahara:
  Fix Committed

Bug description:
  This is in the ocean theme

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753312/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746127] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8552
Committed: 
https://git.mahara.org/mahara/mahara/commit/365bb16ab8cd2108a39055d516d8e86435984869
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 365bb16ab8cd2108a39055d516d8e86435984869
Author: Jaque 
Date:   Thu Mar 1 14:51:18 2018 +1300

Bug #1746127: Review primary school theme variables and put more colors
into variables

behatnotneeded

Change-Id: I91fdef966ccd092d51c47189288dfe148f420262

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746127

Title:
  Review theme variables and put more colors into variables

Status in Mahara:
  Fix Committed

Bug description:
  There still seem to be a few colors in the CSS rather than set as
  variables in SASS. This should be reviewed and where possible
  consolidated. Please keep it flexible though so that borders don't get
  background variables assigned only because it is the same color. Our
  designers need to be able to manipulate them separately. :-)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746127] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8561
Committed: 
https://git.mahara.org/mahara/mahara/commit/e02a5946fcbf73194b29868a476d966bb82c56bc
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit e02a5946fcbf73194b29868a476d966bb82c56bc
Author: Jaque 
Date:   Mon Mar 5 10:17:46 2018 +1300

Bug #1746127: Review ocean theme variables and put more colors into
variables

behatnotneeded

Change-Id: I503eed17d07451b7bc4f6eb764de576f5447c3d8

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746127

Title:
  Review theme variables and put more colors into variables

Status in Mahara:
  Fix Committed

Bug description:
  There still seem to be a few colors in the CSS rather than set as
  variables in SASS. This should be reviewed and where possible
  consolidated. Please keep it flexible though so that borders don't get
  background variables assigned only because it is the same color. Our
  designers need to be able to manipulate them separately. :-)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746127] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8543
Committed: 
https://git.mahara.org/mahara/mahara/commit/69886801ab147b40139f66130c897d236d92773a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 69886801ab147b40139f66130c897d236d92773a
Author: Liam 
Date:   Thu Feb 22 10:48:09 2018 +1300

Bug #1746127: Review raw theme variables and put more colors into
variables

behatnotneeded

Change-Id: Ia37ed3be4261974c645ce4e865611e51ece506c8

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746127

Title:
  Review theme variables and put more colors into variables

Status in Mahara:
  Fix Committed

Bug description:
  There still seem to be a few colors in the CSS rather than set as
  variables in SASS. This should be reviewed and where possible
  consolidated. Please keep it flexible though so that borders don't get
  background variables assigned only because it is the same color. Our
  designers need to be able to manipulate them separately. :-)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746127] Re: Review theme variables and put more colors into variables

2018-03-06 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746127

Title:
  Review theme variables and put more colors into variables

Status in Mahara:
  Fix Committed

Bug description:
  There still seem to be a few colors in the CSS rather than set as
  variables in SASS. This should be reviewed and where possible
  consolidated. Please keep it flexible though so that borders don't get
  background variables assigned only because it is the same color. Our
  designers need to be able to manipulate them separately. :-)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753809] [NEW] Quicker access to student portfolios when members of a group

2018-03-06 Thread Kristina Hoeppner
Public bug reported:

"I wondered whether or not it would be helpful if there were an option
whereby when you have students in a group, if the pages associated with
the student could be shown in a collapsed/expanded form along with them
to save each time having to click on a student to open their profile,
and then see what they have got for a page."

I would expand that to include collections, i.e. show portfolios as we
do elsewhere. There are a few questions that should be considered for
this:

1. Would it be added to the members block?
2. The portfolios shown would be the ones that the person looking at has access 
to and not only the ones that the student had shared with the group as per our 
regular sharing permissions.
3. Should a similar display be available in other places? I wouldn't add that 
info everywhere where a person's name appears, but I could imagine that the 
friends block would be a possibility.
4. We have to be careful about how to link this if we go for this functionality 
so that people still have easy access to the person's profile page.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753809

Title:
  Quicker access to student portfolios when members of a group

Status in Mahara:
  Confirmed

Bug description:
  "I wondered whether or not it would be helpful if there were an option
  whereby when you have students in a group, if the pages associated
  with the student could be shown in a collapsed/expanded form along
  with them to save each time having to click on a student to open their
  profile, and then see what they have got for a page."

  I would expand that to include collections, i.e. show portfolios as we
  do elsewhere. There are a few questions that should be considered for
  this:

  1. Would it be added to the members block?
  2. The portfolios shown would be the ones that the person looking at has 
access to and not only the ones that the student had shared with the group as 
per our regular sharing permissions.
  3. Should a similar display be available in other places? I wouldn't add that 
info everywhere where a person's name appears, but I could imagine that the 
friends block would be a possibility.
  4. We have to be careful about how to link this if we go for this 
functionality so that people still have easy access to the person's profile 
page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724415] Re: Compliance with EU GDPR privacy regulations

2018-03-06 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724415

Title:
  Compliance with EU GDPR privacy regulations

Status in Mahara:
  Fix Committed

Bug description:
  http://www.eugdpr.org/

  Stricter privacy will be enforced in May 2018 in the EU.

  We are going to look more closely into what is required in Mahara
  after the 17.10 release for Mahara 18.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724415/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1741799] Re: Strict privacy: Require everyone to accept the T&C and privacy statement

2018-03-06 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1741799

Title:
  Strict privacy: Require everyone to accept the T&C and privacy
  statement

Status in Mahara:
  Fix Committed

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance

  The GDPR requires that users consent to the privacy statement of a site 
explicitely. 
  For institutions, we have a Yes/No switch "Strict privacy" in Config site -> 
Site options -> Institutions settings.

  What is to be done (last item from Bug 1739688):

  5. Turning the "Strict privacy" switch to "Yes" (if enabled) requires
  everyone to accept the T&C and privacy statement when they log in for
  the first time (once changes were made etc. as per the separate
  Launchpad items on that).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1741799/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731067] Re: Some cron jobs cause elasticsearch queue to populate when it doesn't need to

2018-03-06 Thread Robert Lyon
** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731067

Title:
  Some cron jobs cause elasticsearch queue to populate when it doesn't
  need to

Status in Mahara:
  Confirmed

Bug description:
  We only record certain information in elasticsearch but we queue
  things even if unrecorded information changes because we use
  triggers/procedures on the tables

  Example, when the recalculate_quota cron runs it works out what the
  user quota should be and then updates all the users in usr table that
  need fixing. This table has a trigger on it so all users needing
  updating are added to queue to be indexed.

  On a big site that can mean thousands of users being indexed. But we
  don't record quota in elasticsearch so we don't need to index this
  change.

  It would be good to be able to drop/add elasticsearch triggers during
  cron process for certain cron jobs like we do in upgrade.php script

  eg:
drop_elasticsearch_triggers();
... do cron job ...
create_elasticsearch_triggers();

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731067/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753828] [NEW] ik heb problemen met de updats het blijft in engels en ik kan niets van engels

2018-03-06 Thread denis steve
Public bug reported:

ik heb problemen met de updats het blijft in engels en ik kan niets van
engels

** Affects: mahara
 Importance: Undecided
 Status: New

** Attachment added: "Screenshot from 2018-03-06 21:40:42.png"
   
https://bugs.launchpad.net/bugs/1753828/+attachment/5071038/+files/Screenshot%20from%202018-03-06%2021%3A40%3A42.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753828

Title:
  ik heb problemen met de updats het blijft in engels en ik kan niets
  van engels

Status in Mahara:
  New

Bug description:
  ik heb problemen met de updats het blijft in engels en ik kan niets
  van engels

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753828/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753841] [NEW] Behat test: image/text blocks can be deleted

2018-03-06 Thread Rebecca Blundell
Public bug reported:

We need to add delete and should not see steps to newtextblock.feature
and addimageblock.feature

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753841

Title:
  Behat test: image/text blocks can be deleted

Status in Mahara:
  New

Bug description:
  We need to add delete and should not see steps to newtextblock.feature
  and addimageblock.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753841/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753612] Re: Behat test for adding a navigation block to a page

2018-03-06 Thread Rebecca Blundell
** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
 Assignee: (unassigned) => Rebecca Blundell (rjb-dev)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753612

Title:
  Behat test for adding a navigation block to a page

Status in Mahara:
  In Progress

Bug description:
  We need a test for the navigation block.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753612/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1745042] Re: Social profile icon causing warning in Elasticsearch display

2018-03-06 Thread Ghada El-Zoghbi
hi @robertl,

I've dug around a bit more. The bug appears (i.e. icon not set) when the
user logged in does not match the record owner.

That is, in

search/elasticsearch/type/ElasticsearthType_artefact.php::getRecordDataById()

It checks:

if ($USER->get ( 'id' ) == $record->owner) {

If this does not match, the icon and link are not set.

And, the error is generated.

So, I think the check needs to happen in the template if those values
are missing.


What do you think ?


And, this is how we can test for it.


Thanks,
Ghada

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1745042

Title:
  Social profile icon causing warning in Elasticsearch display

Status in Mahara:
  In Progress
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  In Progress

Bug description:
  Mahara: 17:10.2  (2017092611)
  OS: Linux 16.04
  DB: Postgres
  Browser: any

  An warning is displayed (and debug is on) when using Elastisearch when
  searching on data. Please refer to attached image of warning.

  We are using the raw_old theme but it's also present in raw.

  I haven't been able to track down the data itself but I can see that
  it stems from a social profile not having a relevant icon. And, I can
  track it down to:

  
/htdocs/search/elasticsearch/type/ElasticsearchType_artefact.php::getRecordDataById
  - lines 353-356

  
  If the array $icons is empty, the properties: link and icon

  do not get set.

  Which leads to this warning in the template:

  /htdocs/theme/raw_old/plugintype/search/elasticsearch/templates/artefact.tpl

  on line 15.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1745042/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753634] Re: Behat test for Recent forum post block

2018-03-06 Thread Rebecca Blundell
** Changed in: mahara
 Assignee: (unassigned) => Rebecca Blundell (rjb-dev)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753634

Title:
  Behat test for Recent forum post block

Status in Mahara:
  In Progress

Bug description:
  There is currently no test for this block.

  New test. Requires group with forum and forum posts. Add block to page
  and check display.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753634/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1575923] Re: Mathslate/MathJax fails to load on https

2018-03-06 Thread Kristina Hoeppner
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1575923

Title:
  Mathslate/MathJax fails to load on https

Status in Mahara:
  Confirmed

Bug description:
  On HTTPS-enabled sites, the Mathslate tinymce plugin fails, due to
  loading http:// resources from yui.yahooapis.com and cdn.mathjax.org.

  The file htdocs/js/tinymce/plugins/mathslate/mathslate.html is
  hardcoded to pull http:// versions of these scripts (lines 11-12).

  Ultimately this is an upstream bug, but it's one that affects https-
  enabled Mahara sites.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1575923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753841] Re: Behat test: image/text blocks can be deleted

2018-03-06 Thread Rebecca Blundell
** Changed in: mahara
 Assignee: (unassigned) => Rebecca Blundell (rjb-dev)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753841

Title:
  Behat test: image/text blocks can be deleted

Status in Mahara:
  In Progress

Bug description:
  We need to add delete and should not see steps to newtextblock.feature
  and addimageblock.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753841/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753841] A patch has been submitted for review

2018-03-06 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8582

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753841

Title:
  Behat test: image/text blocks can be deleted

Status in Mahara:
  In Progress

Bug description:
  We need to add delete and should not see steps to newtextblock.feature
  and addimageblock.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753841/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1745042] Re: Social profile icon causing warning in Elasticsearch display

2018-03-06 Thread Ghada El-Zoghbi
Steps to reproduce:

1. Set up elasticsearch and ensure social profiles are indexed.
2. As user1, create a social profile for 'Twitter'
3. As user1, add this social profile to your Profile page. 
4. As user2, create a social profile for 'Twitter'
5. As user2, add this social profile to your Profile page.
6. Ensure the elasticsearch indexing is complete
7. As user2, search (at the top) for 'Twitter'
8. You should now see the error message: 
[WAR] 2c (lib/dwoo/dwoo/Dwoo/Core.php:1265) Undefined property: stdClass::$icon

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1745042

Title:
  Social profile icon causing warning in Elasticsearch display

Status in Mahara:
  In Progress
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  In Progress

Bug description:
  Mahara: 17:10.2  (2017092611)
  OS: Linux 16.04
  DB: Postgres
  Browser: any

  An warning is displayed (and debug is on) when using Elastisearch when
  searching on data. Please refer to attached image of warning.

  We are using the raw_old theme but it's also present in raw.

  I haven't been able to track down the data itself but I can see that
  it stems from a social profile not having a relevant icon. And, I can
  track it down to:

  
/htdocs/search/elasticsearch/type/ElasticsearchType_artefact.php::getRecordDataById
  - lines 353-356

  
  If the array $icons is empty, the properties: link and icon

  do not get set.

  Which leads to this warning in the template:

  /htdocs/theme/raw_old/plugintype/search/elasticsearch/templates/artefact.tpl

  on line 15.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1745042/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753911] [NEW] Behat: Files to download block test

2018-03-06 Thread Rebecca Blundell
Public bug reported:

There is no test for Files to Download block currently:

New test requires one pdf and one jpg. Can add the files and check that
the option to download exists, but not confirm it downloads locally.
This would need to be done manually.

** Affects: mahara
 Importance: Undecided
 Assignee: Rebecca Blundell (rjb-dev)
 Status: In Progress


** Tags: behat

** Changed in: mahara
 Assignee: (unassigned) => Rebecca Blundell (rjb-dev)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753911

Title:
  Behat: Files to download block test

Status in Mahara:
  In Progress

Bug description:
  There is no test for Files to Download block currently:

  New test requires one pdf and one jpg. Can add the files and check
  that the option to download exists, but not confirm it downloads
  locally. This would need to be done manually.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753911/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753911] A patch has been submitted for review

2018-03-06 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8583

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753911

Title:
  Behat: Files to download block test

Status in Mahara:
  In Progress

Bug description:
  There is no test for Files to Download block currently:

  New test requires one pdf and one jpg. Can add the files and check
  that the option to download exists, but not confirm it downloads
  locally. This would need to be done manually.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753911/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746346] Re: Unable to add/edit skin for profile & dashboard page in 17.10+

2018-03-06 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746346

Title:
  Unable to add/edit skin for profile & dashboard page in 17.10+

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  In 17.10+ we changed around how a bunch of the page edit screens work.
  This has accidentally removed the ability to edit the skin for a
  profile page.

  We will need to add this back in

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746346/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746346] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8565
Committed: 
https://git.mahara.org/mahara/mahara/commit/3862fa162efc3c91ba66fabee8956bcfffd7bda9
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 3862fa162efc3c91ba66fabee8956bcfffd7bda9
Author: Cecilia Vela Gurovic 
Date:   Mon Mar 5 17:55:58 2018 +1300

Bug 1746346: add skin to profile&dashboard pages

fixed for Dashboard page to show the skin

behatnotneeded

Change-Id: I8720025e854d60c03980f5857786ce8171fe7db1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746346

Title:
  Unable to add/edit skin for profile & dashboard page in 17.10+

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  In 17.10+ we changed around how a bunch of the page edit screens work.
  This has accidentally removed the ability to edit the skin for a
  profile page.

  We will need to add this back in

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746346/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746346] A patch has been submitted for review

2018-03-06 Thread Mahara Bot
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8584

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746346

Title:
  Unable to add/edit skin for profile & dashboard page in 17.10+

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  In 17.10+ we changed around how a bunch of the page edit screens work.
  This has accidentally removed the ability to edit the skin for a
  profile page.

  We will need to add this back in

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746346/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746346] Re: Unable to add/edit skin for profile & dashboard page in 17.10+

2018-03-06 Thread Robert Lyon
** Changed in: mahara/17.10
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746346

Title:
  Unable to add/edit skin for profile & dashboard page in 17.10+

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  In 17.10+ we changed around how a bunch of the page edit screens work.
  This has accidentally removed the ability to edit the skin for a
  profile page.

  We will need to add this back in

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746346/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746346] A change has been merged

2018-03-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8584
Committed: 
https://git.mahara.org/mahara/mahara/commit/2d55c32dbceaaa66534459add0d1ffb83be66f4c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.10_STABLE

commit 2d55c32dbceaaa66534459add0d1ffb83be66f4c
Author: Cecilia Vela Gurovic 
Date:   Mon Mar 5 17:55:58 2018 +1300

Bug 1746346: add skin to profile&dashboard pages

fixed for Dashboard page to show the skin

behatnotneeded

Change-Id: I8720025e854d60c03980f5857786ce8171fe7db1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746346

Title:
  Unable to add/edit skin for profile & dashboard page in 17.10+

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  In 17.10+ we changed around how a bunch of the page edit screens work.
  This has accidentally removed the ability to edit the skin for a
  profile page.

  We will need to add this back in

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746346/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] Re: Changing Datepicker

2018-03-06 Thread Kristina Hoeppner
Different styling when in "Shared by me". It should look the same as in
Resume.

** Attachment added: "calendar_share_page.png"
   
https://bugs.launchpad.net/mahara/+bug/1744191/+attachment/5071335/+files/calendar_share_page.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  In Progress

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] Re: Changing Datepicker

2018-03-06 Thread Kristina Hoeppner
Styling as expected in the date picker

** Attachment added: "calendar_resume.png"
   
https://bugs.launchpad.net/mahara/+bug/1744191/+attachment/5071333/+files/calendar_resume.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  In Progress

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1745278] Re: Publicaly viewable group with submissions

2018-03-06 Thread Kristina Hoeppner
It should also be checked that there is no error message when a user
tries to view the group homepage when she's neither the admin / tutor of
the group nor submitted a portfolio to it as she shouldn't see anything
then either.

** Changed in: mahara
   Status: Confirmed => In Progress

** Changed in: mahara
Milestone: None => 18.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1745278

Title:
  Publicaly viewable group with submissions

Status in Mahara:
  In Progress

Bug description:
  Mahara: 17.10.2 (2017092611)
  OS: Linux 16.04 (php 7)
  DB: Postgres
  Browser: FF && Chrome (any)

  
  When a group is created with the following settings:

  * Allow submissions = Yes
  * Publicly viewable group = Yes

  When a user who is not logged in tries to view this group (i.e.
  because they know the URL), they get the following error:

  [WAR] 75 (lib/user.php:1943) Undefined variable: id

  Call stack (most recent first):
  log_message("Undefined variable: id", 8, true, true, 
"/var/www/clients/mahara/htdocs/lib/user.php", 1943) at 
/var/www/clients/mahara/htdocs/lib/errors.php:521
  error(8, "Undefined variable: id", 
"/var/www/clients/mahara/htdocs/lib/user.php", 1943, array(size 4)) at 
/var/www/clients/mahara/htdocs/lib/user.php:1943
  profile_url(false, false) at /var/www/clients/mahara/htdocs/lib/view.php:6164
  View->get_url(false) at /var/www/clients/mahara/htdocs/lib/view.php:5571
  View::get_extra_view_info(array(size 1), false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:6388
  View::get_views_and_collections(0) at 
/var/www/clients/mahara/htdocs/lib/group.php:1496
  group_view_submission_form("50") at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:424
  PluginBlocktypeGroupViews::get_data("50", false) at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:104
  PluginBlocktypeGroupViews::render_instance(object(BlockInstance)) at 
/var/www/clients/mahara/htdocs/lib/mahara.php:1789
  call_static_method("PluginBlocktypeGroupviews", "render_instance", 
object(BlockInstance)) at /var/www/clients/mahara/htdocs/blocktype/lib.php:1041
  BlockInstance->render_viewing(false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2159
  View->build_column(1, 1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2113
  View->build_columns(1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2098
  View->build_rows() at /var/www/clients/mahara/htdocs/group/view.php:68

  [WAR] 75 (lib/user.php:1947) profile_url called with no user id
  Call stack (most recent first):
  profile_url(false, false) at /var/www/clients/mahara/htdocs/lib/view.php:6164
  View->get_url(false) at /var/www/clients/mahara/htdocs/lib/view.php:5571
  View::get_extra_view_info(array(size 1), false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:6388
  View::get_views_and_collections(0) at 
/var/www/clients/mahara/htdocs/lib/group.php:1496
  group_view_submission_form("50") at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:424
  PluginBlocktypeGroupViews::get_data("50", false) at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:104
  PluginBlocktypeGroupViews::render_instance(object(BlockInstance)) at 
/var/www/clients/mahara/htdocs/lib/mahara.php:1789
  call_static_method("PluginBlocktypeGroupviews", "render_instance", 
object(BlockInstance)) at /var/www/clients/mahara/htdocs/blocktype/lib.php:1041
  BlockInstance->render_viewing(false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2159
  View->build_column(1, 1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2113
  View->build_columns(1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2098
  View->build_rows() at /var/www/clients/mahara/htdocs/group/view.php:68


  Because the group is submittable, the application is trying to
  retrieve a list of submitted pages/collections to this group.

  A check is required to ensure the user is logged in before it
  retrieves this data.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1745278/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp