[Mahara-contributors] [Bug 1535989] Re: Remove obsolete Pear plugins library

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 16.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1535989

Title:
  Remove obsolete Pear plugins library

Status in Mahara:
  Fix Released

Bug description:
  Keeping plugins up to date.

  I note there is a xmlparser.php  included in this - maybe we don't
  need the other xmlparser anymore?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1535989/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1563582] Re: Improve performance of queries against "artefact.path" by also querying against artefact owner

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1563582

Title:
  Improve performance of queries against "artefact.path" by also
  querying against artefact owner

Status in Mahara:
  Confirmed

Bug description:
  A while back we added a "path" column to the "artefact" table to try
  to improve performance when looking up artefact descendants. This
  replaced an older system where we only had a "parent" column, and when
  we needed to query against artefact hierarchies we had to use repeated
  SQL queries.

  Unfortunately, though, the "path" column is a varchar, and it turns
  out that varchar queries are not very performant even when indexed,
  particularly when you're searching substrings of them as we do with
  such queries. This causes big performance problems on sites with many
  artefacts.

  One easy way to drastically improve this performance, is that whenever
  we have a query that primarily searches against "path", we also search
  against the arteafct.owner, artefact.institution, or artefact.group
  column as well. These columns are all indexed, and all integers, which
  means they will perform very quickly. Also, with Mahara's current
  architecture, there are no current situations where an artefact will
  have a parent that is *not* owned by the same entity.

  So, instead of doing "select * from artefact where path like '/' || ?
  || '/%'" to find all the children of a particular artefact, you can do
  "select * from artefact where path like '/' || ? || '/%' AND owner=?"
  (Though note that the actual query will need to check whether the
  artefact is owned by an owner, group, or institution, and will need to
  alter the query accordingly.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1563582/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528991] Re: Indent second line of notification in Inbox

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528991

Title:
  Indent second line of notification in Inbox

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Mahara 15.10+

  When the subject line of a notification is very long, the name pops to
  the second line when on a tablet for example. That second line is not
  indent, but should only start where the text starts on the first line
  (see attachment)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528991/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1558830] Re: Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1558830

Title:
  Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier

Status in Mahara:
  Confirmed

Bug description:
  While working on https://bugs.launchpad.net/mahara/+bug/1558387,
  Robert pointed out to me that we don't set URI.DefinitionRev. We also
  don't set URI.DefinitionID. Although the HTMLPurifier docs say that
  URI.DefinitionID is required if you have custom URIFilters (and our
  allowed iframe list is a custom URIFilter), it looks like the fallback
  behavior is that it generates a URI.DefinitionID based on a hash of
  the config. This has the effect that a new "Revision 1" URI config
  file is generated each time the allowed iframes list changes. It also
  results in an accumulation of old URI cache files in the
  dataroot/htmlpurifier directory, since they're all Revision 1, and all
  have different IDs.

  I think the best approach here is to give the URI.DefinitionRev its
  own revision number, stored in the database, and increment it every
  time we change the allowed iframe list.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1558830/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1633311] A patch has been submitted for review

2016-10-20 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/7201

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1633311

Title:
  JS error in Firefox when editing annotation blocks

Status in Mahara:
  Confirmed

Bug description:
  Version: master (17.04), 16.10
  Platform: any
  Browser: Firefox (45)

  I got the following error when adding/editing an annotation block in a
  portfolio page.

  SyntaxError: in strict mode code, functions may be declared only at
  top level or immediately within another function

  It works ok on Chrome 53

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1633311/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1597536] Re: import_entry_requests table needs a ctime so we can clean up old partial requests

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 16.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1597536

Title:
  import_entry_requests table needs a ctime so we can clean up old
  partial requests

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  A ctime will allow us to clean up the old entries via a new (or
  possibly existing) cronjob

  And we need to make the stored path to the files be relative to
  dataroot rather than full path from '/' on server as we shouldn't be
  recording that info in the db.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1597536/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1513276] Re: Consolidate the iframe sources code

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513276

Title:
  Consolidate the iframe sources code

Status in Mahara:
  Confirmed

Bug description:
  Currently we do a bunch of different things to add allowed iframe
  sources code to the system when we install/upgrade a site

  We need to make it one way only

  Notes:
  lib/upgrade.php, core_postinst(), has a hard-coded list of allowed iframe 
sources
  if you add the youtube-no-iframes one there, can you also move the prezi one 
there, and take it out from blocktype/externalvideo::postinst() ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1513710] Re: Destructor methods that access global variables can cause crashes

2016-10-20 Thread Robert Lyon
** Also affects: mahara/16.10
   Importance: Undecided
   Status: New

** Changed in: mahara/16.10
Milestone: None => 16.10.1

** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

** Changed in: mahara/16.10
   Status: New => Confirmed

** Changed in: mahara/16.10
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513710

Title:
  Destructor methods that access global variables can cause crashes

Status in Mahara:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  See : https://mahara.org/interaction/forum/topic.php?id=7397

  Here's the problem (which appears to be intermittent):

  1. ArtefactType has a destructor method, which gets called when an artefact 
object is garbage-collected by PHP.
  2. PHP runs destructor methods and garbage collects variables in no 
guaranteed order when exit() is called.
  3. Sometimes the ArtefactType destructor method tries to call DML methods, 
which use the global variable $db
  4. Apparently sometimes the $db global variable has already been garbage 
collected by the time the destructor runs
  5. This causes a fatal "method on a non-object" crash.

  It's unclear why this error has only started happening recently. It
  might be due to a change in the behavior of PHP's garbage collector,
  or it might be from new Mahara code leaving some artefacts with their
  $dirty flag set (which triggers that artefact commit).

  In either case, both global variables and implicit destructor methods
  are considered harmful design practices, in part because of this
  particular thing. So it's high time we got rid of these __destruct()
  methods.

  Alternatively, as a workaround for older Mahara versions, we could add
  some code to the top of each __destruct() method that re-creates the
  global $db if it's not set.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513710/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1393620] Re: webservices: get_groups_by_id requires institution

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1393620

Title:
  webservices: get_groups_by_id requires institution

Status in Mahara:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Currently the webservices method to fetch group information by id
  requires the group to have institution set.

  Will need to be adjusted to allow for groups not attached to an
  institution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1393620/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1521781] Re: Make TinyMCE Embedded Image support more automatic

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1521781

Title:
  Make TinyMCE Embedded Image support more automatic

Status in Mahara:
  Confirmed

Bug description:
  We've added that great plugin to TinyMCE that lets you select and
  embed your Mahara images easily, and we've added some library code to
  make sure that people can view your images if they're embedded
  (instead of the old system of relying on the image being shared
  specifically in an image block).

  However, the current implementation relies on the developer
  specifically calling a series of functions in the form submission
  function, and there's no warning or penalty if they fail to do that,
  so it is often overlooked when creating new places that use a wysiwyg
  text editor.

  I'd like to see the support for this become more automatic, ideally by
  making the pieform "wysiwyg" form element handle all of the linking
  logic for the embedded images.

  My proposal is this:

  1. Check to see if there is a post-submit hook in Pieforms for pieform
  elements. If there isn't, add one.

  2. Write a post-submit hook handler for the wysiwyg element, that
  takes care of calling the necessary embedded image libraries

  3. Add settings for the wysiwyg element to get the extra data we
  needed for this (i.e., the "resource type" for
  artefact_file_embedded).

  4. Add another setting to the wysiwyg element (off by default) to say
  "don't use the Mahara image picker in this one". For wysiwygs where we
  don't want to support embedded Mahara images (if there are any)

  5. The tricky part here is that the embedded image thing will need to
  know the id of the "Resource" that you're embedding the image in. And
  if you're creating a new resource, you won't know that until after the
  form's submit method has finished. So, we'll have to expect the
  developer to provide the new resource's ID back to the $form object,
  and to help enforce that, we can make the wysiwyg post-submit hook
  throw an error if the wysiwyg element has embedded images turned on
  but it did not receive a resource ID.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1521781/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 604839] Re: Upgrade swfobject to version 2.2 (new upstream)

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/604839

Title:
  Upgrade swfobject to version 2.2 (new upstream)

Status in Mahara:
  Confirmed

Bug description:
  The SWFObject detection script we used in the internal media blocktype
  is using this upstream code:

http://blog.deconcept.com/swfobject/

  but it has now been replaced by this one, which is up to version 2.2:

http://code.google.com/p/swfobject/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/604839/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1603825] Re: "Collapsible" block setting doesn't work if block has no title.

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603825

Title:
  "Collapsible" block setting doesn't work if block has no title.

Status in Mahara:
  Confirmed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7664

  If a block has no title, it can't be collapsed. That is, if you set
  the "Collapsible" setting to "Yes", the block can't be toggled because
  there's no title bar to click on. Moreover, if you set the block to
  "Already collapsed", it won't be displayed as collapsed, or
  collapsible.

  This behavior is present at least as far back as Mahara 1.7. I've
  found this behavior in the Text and Image blocks, but I haven't tested
  it across all of them so I don't know whether it's part of the
  implementation of particular blocks, or if it's in the block library
  code.

  To replicate:

  1. Put a text block on a page.
  2. Delete the block's title.
  3. Give the block some text.
  4. Set the block's "Collapsible" setting to "Already collapsed"
  5. View the page in display mode.

  Expected result: The block is collapsed, and can be toggled between 
expanded/collapsed.
  Actual result: The block is expanded, and there is no collapse/expand toggle 
to click on.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603825/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1261234] Re: A cron task to periodically clear the VERP bounce counts

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1261234

Title:
  A cron task to periodically clear the VERP bounce counts

Status in Mahara:
  Confirmed

Bug description:
  Mahara has a VERP system to disable email addresses that have been
  bouncing. "Bounces_min" and "Bounces_ratio", and it disables an email
  when it has received more than "bounces_min" bounces and the ratio of
  bounced messages to all messages sent is greater than bounces_ratio.

  The thing is, these are *lifetime* numbers, and never get reset. This
  poses some difficulties once a site has been around for a few years,
  like mahara.org. We have some email addresses that have received
  thousands of messages. So, if we set bounces_threshold to something
  like the default "0.2" setting, then if one of those longtime
  addresses become invalid, we would continue to send hundreds of
  messages to it before we got around to disabling it. On the other
  hand, if we set bounces_threshold to 0, then we have the problem that
  the bounce count is cumulative and never gets reset. So, if we leave
  it at the default 5 emails, I could get disabled due to one bounce
  every three months over the course of a year and a half.

  Really, whether to disable someone's email should be based on how much
  it has been bouncing *recently*. So what we should do is add a cron
  task which sets the artefact_internal_profile_email.maillsent and
  artefact_internal_profile_email.bouncecount columns back to 0
  periodically.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1261234/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606735] Re: Accessibility - Inconsistent heading levels

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606735

Title:
  Accessibility - Inconsistent heading levels

Status in Mahara:
  Confirmed

Bug description:
  Mahara: master

  Headings jump levels - i.e. h1 -> h3 skipping h2.

  Heading levels should be used in sequence to assist users in
  understanding the structure of the page. And, prevent screen readers
  from skipping sections.

  For additional information, please refer to:
  http://webaim.org/techniques/semanticstructure/#contentstructure

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606735/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1607743] Re: Page themes don't work with configurable theme

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607743

Title:
  Page themes don't work with configurable theme

Status in Mahara:
  Confirmed

Bug description:
  Master mahara (but also on 16.04 and 15.10)

  When users can choose a theme for their pages and the institution uses
  the configurable theme, nothing is being displayed properly.

  Part of the configurable theme is always visible but the acutal chosen
  theme is used for the navigation, which does not look good. And then
  putting skins on top...

  To replicate the issue:

  1. Allow users to choose page themes: Admin -> Configure site -> User 
settings -> Users can choose page themes.
  2. Create an institution and choose the configurable theme. Choose a dark 
background color so that header nav items need to be white.
  3. Add a user to that institution.
  4. Set up a page as that user and give it a different theme.
  Expected result: The theme overwrites the configurable theme completely like 
it does when a an institution has a regular theme.
  Actual result: Part of the configurable theme is still visible (see 
screenshot).

  The screenshot also shows how it would look like with a skin. The skin
  doesn't influence it badly though. Just something to keep in mind for
  testing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1607743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1624954] Re: Not able to delete a comment from Safari

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1624954

Title:
  Not able to delete a  comment from Safari

Status in Mahara:
  Confirmed

Bug description:
  Tested in Safari5 Saucelab via php5:

  Test steps:

  Add comment from a page> Edit and Delete button is displayed
  Click on Delete button
  Comment is not deleted

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1624954/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1622771] Re: Bulk delete doesnt work on safari

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1622771

Title:
  Bulk delete doesnt work on safari

Status in Mahara:
  Confirmed

Bug description:
  Version 16.04 and 16.10

  Browser : safari

  Steps to reproduce:

  1) Add few users as site administrators
  2) Login as site administrator
  3) Try to self-delete(site-administrator) the along with another users

  Expected Result: An error message should be displayed. Related to
  https://bugs.launchpad.net/mahara/+bug/1574941

  Actual result: When trying to delete the users it stays on the page
  and does nothing

  Note: This also happens when an institution admin logs in and tries to
  self-delete with other users

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1622771/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422264] Re: IPv6 Compliance

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422264

Title:
  IPv6 Compliance

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Mahara: 15.04
  DB: any
  Browser: any
  OS: any

  Currently, Mahara is not compliant with the IPv6 protocol.

  Some places that need to change (where IP addresses are
  validated/checked):

   - SAML auth - validate URL Syntax (preg_match for IPv6 also).

   - DB: table - host.ipaddress needs to cater for 128 bit address.

   - Peer bootstrap: 
   1) preg-match should also include IPv6 format;
   2) use of PHP function gethostbyname().

   - Zend third part library - current version only supports IPv4. We
  currently use version 1.10.6.

   MNET heavily relise on Zend.
   The latest Zend is on version 3. But there is a release for 1.12.11 - which 
still doesn't support IPv6 (as far as I can tell).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422264/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1576075] Re: Namespaces and Autoloader

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576075

Title:
  Namespaces and Autoloader

Status in Mahara:
  Confirmed

Bug description:
  Discussed at the 52nd developer meeting:
  https://wiki.mahara.org/wiki/Developer_Area/Developer_Meetings/52

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576075/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1575923] Re: Mathslate/MathJax fails to load on https

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1575923

Title:
  Mathslate/MathJax fails to load on https

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  On HTTPS-enabled sites, the Mathslate tinymce plugin fails, due to
  loading http:// resources from yui.yahooapis.com and cdn.mathjax.org.

  The file htdocs/js/tinymce/plugins/mathslate/mathslate.html is
  hardcoded to pull http:// versions of these scripts (lines 11-12).

  Ultimately this is an upstream bug, but it's one that affects https-
  enabled Mahara sites.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1575923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1408577] Re: Elasticsearch not working properly with Chinese characters

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1408577

Title:
  Elasticsearch not working properly with Chinese characters

Status in Mahara:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  1. Search box in the top-right corner (the search box below the Settings) 
return no result.
  2. Search box in the Pages can only locate the name of the pages (not 
searching content of the page).

  Detail Information of server:
  ===
  Elasticsearch server is running:
  {
"cluster_name" : "elasticsearch",
"status" : "green",
"timed_out" : false,
"number_of_nodes" : 1,
"number_of_data_nodes" : 1,
"active_primary_shards" : 1,
"active_shards" : 1,
"relocating_shards" : 0,
"initializing_shards" : 0,
"unassigned_shards" : 0
  }

  The Elasticsearch plugin is currently active. 
  Host: 127.0.0.1
  Elasticsearch port: 9200
  Auth username: (not set)
  Auth password: (not set)
  Index name: mahara
  Bypass index: (not set)
  Elasticsearch analyzer: mahara_analyze
  lasticsearch types: 
usr,interaction_instance,interaction_forum_post,group,view,artefact
  Cron record limit: 0
  Artefact types: Select all

  Number of records of each type currently in the queue:
  usr   (1)
  interaction_instance  (0)
  interaction_forum_post(0)
  group (0)
  view  (0)
  artefact  (0)



  
  - Mahara 1.10.1
  - Ubuntu Linux 14.04.1
  - Postgres database (version 9.3.5)
  - Chrome Version 39.0.2171.95 m, Firefox 33.0.2, I.E. 11

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1408577/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1517732] Re: Upgrade Elastica to 2.3.1

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1517732

Title:
  Upgrade Elastica to 2.3.1

Status in Mahara:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Mahara 15.10 is using Elastica 2.0, which is only compatible with
  Elasticsearch versions up to 1.5.2.

  Elasticsearch is now up to version 2.3, which supports up to
  Elasticsearch 1.73: http://elastica.io/2015/10/18/release-2-dot-3-1/

  We should upgrade.

  It is worth noting, however, that Elasticsearch's latest version is
  2.0.0, and the current version of Elastica does not support that yet.
  Apparently ES 2.0.0 breaks a lot of backwards compatibility. An
  upgrade to support ES 2.0.0 is in progress, however:
  https://github.com/ruflin/Elastica/issues/900

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1517732/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1625389] Re: Error message when sharing profile page with public

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625389

Title:
  Error message when sharing profile page with public

Status in Mahara:
  Confirmed

Bug description:
  Mahara master (16.10dev)

  When I share my profile page with "Public", I get the following error
  message after I saved the form and access rules have been applied.

  [WAR] 0b (view/access.php:415) Undefined index: startdate
  Call stack (most recent first):

  log_message("Undefined index: startdate", 8, true, true, 
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:513
  error(8, "Undefined index: startdate", 
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at 
/home/kristina/code/mahara/htdocs/view/access.php:415
  editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
  call_user_func_array("editaccess_validate", array(size 2)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
  Pieform->validate(array(size 11)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
  Pieform->__construct(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
  pieform(array(size 8)) at 
/home/kristina/code/mahara/htdocs/view/access.php:555

  [WAR] 0b (view/access.php:415) Undefined index: stopdate
  Call stack (most recent first):

  log_message("Undefined index: stopdate", 8, true, true, 
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:513
  error(8, "Undefined index: stopdate", 
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at 
/home/kristina/code/mahara/htdocs/view/access.php:415
  editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
  call_user_func_array("editaccess_validate", array(size 2)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
  Pieform->validate(array(size 11)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
  Pieform->__construct(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
  pieform(array(size 8)) at 
/home/kristina/code/mahara/htdocs/view/access.php:555

  [WAR] 0b (view/access.php:420) Undefined index: stopdate
  Call stack (most recent first):

  log_message("Undefined index: stopdate", 8, true, true, 
"/home/kristina/code/mahara/htdocs/view/access.php", 420) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:513
  error(8, "Undefined index: stopdate", 
"/home/kristina/code/mahara/htdocs/view/access.php", 420, array(size 11)) at 
/home/kristina/code/mahara/htdocs/view/access.php:420
  editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
  call_user_func_array("editaccess_validate", array(size 2)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
  Pieform->validate(array(size 11)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
  Pieform->__construct(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
  pieform(array(size 8)) at 
/home/kristina/code/mahara/htdocs/view/access.php:555

  [WAR] 0b (view/access.php:425) Undefined index: startdate
  Call stack (most recent first):

  log_message("Undefined index: startdate", 8, true, true, 
"/home/kristina/code/mahara/htdocs/view/access.php", 425) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:513
  error(8, "Undefined index: startdate", 
"/home/kristina/code/mahara/htdocs/view/access.php", 425, array(size 11)) at 
/home/kristina/code/mahara/htdocs/view/access.php:425
  editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
  call_user_func_array("editaccess_validate", array(size 2)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
  Pieform->validate(array(size 11)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
  Pieform->__construct(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
  pieform(array(size 8)) at 
/home/kristina/code/mahara/htdocs/view/access.php:555

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625389/+subscriptions


[Mahara-contributors] [Bug 1606738] Re: Accessibility - Information icon and navigation to content in information overlay

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606738

Title:
  Accessibility - Information icon and navigation to content in
  information overlay

Status in Mahara:
  Confirmed

Bug description:
  Mahara: master

  Information icons are appearing as h1 headers.

  Also, screen readers can't get to the content in the pop up dialog.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606738/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1599414] Re: New composer-managed SimpleSAML breaks PHPUnit tests.

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599414

Title:
  New composer-managed SimpleSAML breaks PHPUnit tests.

Status in Mahara:
  Confirmed

Bug description:
  While writing a PHPUnit test for one of my patches, I noticed that the
  new composer-managed SimpleSAML, if present, breaks "make phpunit",
  because it contains some phpunit tests that get detected but are
  lacking the proper stuff to make them run correctly.

  To replicate:

  1. Install the SimpleSAMLPHP library by doing "make ssphp"
  2. Run phpunit tests by doing "make phpunit"

  Expected result: tests run with no failures
  Actual result: Tests fail out with this error message

  PHP Fatal error:  Class 'SimpleSAML_Auth_ProcessingFilter' not found in 
/home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php
 on line 7
  PHP Stack trace:
  PHP   1. {main}() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0
  PHP   2. PHPUnit_TextUI_Command::main() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63
  PHP   3. PHPUnit_TextUI_Command->run() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
  PHP   4. PHPUnit_Runner_BaseTestRunner->getTest() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150
  PHP   5. PHPUnit_Framework_TestSuite->addTestFiles() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96
  PHP   6. PHPUnit_Framework_TestSuite->addTestFile() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416
  PHP   7. PHPUnit_Util_Fileloader::checkAndLoad() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355
  PHP   8. PHPUnit_Util_Fileloader::load() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76
  PHP   9. include_once() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1434312] Re: Pieform elements/renderers documentation

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1434312

Title:
  Pieform elements/renderers documentation

Status in Mahara:
  Confirmed

Bug description:
  Need to develop some useful documentation for the pieform
  elements/renderers

  Each element need to include at the top of the file a comment about
  what settings it uses and whether they are optional or not.

  Once we get each element/renderer file updated then we can collate the
  information on the wiki page:
  https://wiki.mahara.org/index.php/Developer_Area/Core_Subsystems/Form_API

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1434312/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528122] Re: Be able to decide whether to include or not feedback in Leap2A

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528122

Title:
  Be able to decide whether to include or not feedback in Leap2A

Status in Mahara:
  Confirmed

Bug description:
  When you create an HTML export, you can decide whether to include
  feedback or not. However, when you create a Leap2A export, you do not
  have that option and feedback is now always included. Users should be
  able to have the choice like for HTML. At some point, feedback was
  added to the Leap2A export but without providing the option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1234582] Re: Can't display images in RSS feeds with protocol-relative URLs

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1234582

Title:
  Can't display images in RSS feeds with protocol-relative URLs

Status in Mahara:
  Confirmed

Bug description:
  As described by Robert while investigating another bug report:
  https://bugs.launchpad.net/mahara/+bug/1219499/comments/5

  The problem where some images are not showing up is because they tend
  to be protocol relative urls to the images and the Mahara system tries
  to append a url to them but this makes the path incorrect.

  eg for slideshare (http://www.slideshare.net/rss/latest)

  There are image links in the feed like:

  
//cdn.slidesharecdn.com/ss_thumbnails/lptrnhc2008cbnnhtnghththutit360-130902225125-phpapp02-thumbnail-2.jpg

  and mahara sees this as a relative url and appends
  http://www.slideshare.net/ to the front if it which then makes

  
http://www.slideshare.net//cdn.slidesharecdn.com/ss_thumbnails/lptrnhc2008cbnnhtnghththutit360-130902225125-phpapp02-thumbnail-2.jpg

  which is an incorrect url and the image will not be found there

  Need to alter the code in htdocs/blocktype/externalfeed/lib.php from
  /src="(\/[^"]+)"/ to something that doesn't try and update protocol
  relative urls

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1234582/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1500285] Re: Add path and update records slowness

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500285

Title:
  Add path and update records slowness

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Upgrade Issue 1 - Add path and update records :

  This adds a field 'path' to artefact table and thereafter runs a
  update query to add data. We have around 500K rows and this takes
  around 94 minutes to upgrade! This can be done in one go without the
  limit of 200 and it works very well taking around 2-3 minutes!

  Few times the upgrade failed due to "mysqli error: [1205: Lock wait
  timeout exceeded; try restarting transaction]".

  This is spun off from Bug #1499568

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500285/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1529718] Re: Anonymous comment area needs a label for the "Comment" text field

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1529718

Title:
  Anonymous comment area needs a label for the "Comment" text field

Status in Mahara:
  Confirmed

Bug description:
  Mahara 15.10+

  When you add a comment as anonymous user, i.e. someone who is not
  logged in, you need to provide your name first and then see a comment
  text field (see screenshot). That text field doesn't have a label, but
  I think it should have one so it's clear what it is for.

  It is also a required field. Thus marking it as "Comment*" would be
  good.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1529718/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1537861] Re: View layout becomes corrupted when changed

2016-10-20 Thread Robert Lyon
** Changed in: mahara/16.10
Milestone: 16.10.1 => 16.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1537861

Title:
  View layout becomes corrupted when changed

Status in Mahara:
  Fix Released
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Version: Mahara 15.04.5 (only encountered on this version, after
  upgrading from 15.04.4)

  We have had 2 users (out of over a thousand) have this problem so far,
  and I've been unable reproduce it or trace a specific cause but we do
  know the order of events and the outcome:

  They copy a page from another user
  Change content or add some new content
  Attempt to change the layout (say from 3 columns to 2 columns)

  Something goes wrong while the layout is being changed and the data in
  the table view_rows_columns no longer matches what's in the view
  table, and the page won't load anymore.

  As more users encounter this problem (and I'm assuming they will) I
  will update this report.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1537861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1381231] Re: problem with submitting a tagged journal block

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1381231

Title:
  problem with submitting a tagged journal block

Status in Mahara:
  Confirmed
Status in Mahara user manual:
  Fix Released

Bug description:
  There are two problems here - but are probably closely related so will
  add them together.

  1) If I add submit a page with tagged journal blocks on it I can't
  edit those blocks but I can add a new journal entry with the same tag
  and it will show on the submitted page.

  2) If I create a few journal entries (say 5) and tag only 3 of them
  with a new tag (say cats) and then submit a tagged block on a page
  using 'cats' I find all 5 of my journal entries are now locked - I
  should only be getting the submitted ones locked.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1381231/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1594192] Re: Leap2a: Importing a file artefact has failed

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594192

Title:
  Leap2a: Importing a file artefact has failed

Status in Mahara:
  Confirmed

Bug description:
  Version: master (16.10), 16.04, 15.10

  For some reasons, the attribute mtime of a file artefact in a leap2a
  file is empty. This cause the following error when import it.

  [WAR] fc (lib/errors.php:796) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  invalid input syntax for type timestamp: ""] in adodb_throw(UPDATE 
"artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = 
? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , 
"locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , 
"authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? 
, "licensor" = ? , "licensorurl" = ? , "path" = ?  WHERE "id" = ? , 
file,0,60,1,,,2016-06-2010:17:24,,2016-06-2010:17:24,0,MasterofEducationtranscript,,,1,,0,0/60/61,61),
 referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948612 2016] [:error] [pid 11881] [client 
192.168.2.47:33369] [WAR] fc (lib/errors.php:796) Command was: UPDATE 
"artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = 
? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , 
"locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , 
"authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? 
, "licensor" = ? , "licensorurl" = ? , "path" = ?  WHERE "id" = ?  and values 
was 
(0:file,1:0,2:60,3:1,4:,5:,6:2016-06-2010:17:24,7:,8:2016-06-2010:17:24,9:0,10:MasterofEducationtranscript,11:,12:,13:1,14:,15:0,16:0,17:,18:,19:,20:/60/61,21:61),
 referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948629 2016] [:error] [pid 11881] [client 
192.168.2.47:33369] Call stack (most recent first):, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948633 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * log_message("Failed to get a recordset: postgres8 
error: [-1: E...", 8, true, true) at 
/var/www/html/mahara/master/htdocs/lib/errors.php:95, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948638 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * log_warn("Failed to get a recordset: postgres8 error: 
[-1: E...") at /var/www/html/mahara/master/htdocs/lib/errors.php:796, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948642 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * SQLException->__construct("Failed to get a recordset: 
postgres8 error: [-1: E...") at 
/var/www/html/mahara/master/htdocs/lib/dml.php:1302, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948646 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * update_record("artefact", object(stdClass), "id") at 
/var/www/html/mahara/master/htdocs/artefact/lib.php:628, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948649 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * ArtefactType->commit() at 
/var/www/html/mahara/master/htdocs/artefact/file/lib.php:1062, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948653 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * ArtefactTypeFile->commit() at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:499, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948657 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::create_file_from_entry_data(object(stdClass), 
object(PluginImportLeap), "portfolio:artefact148") at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:421, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948661 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::create_file_from_request(object(PluginImportLeap), 
object(stdClass), 60) at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:94, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948667 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::import_from_requests(object(PluginImportLeap)) at Unknown:0, 

[Mahara-contributors] [Bug 1564117] Re: Refactor blocktype JS methods

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1564117

Title:
  Refactor blocktype JS methods

Status in Mahara:
  Confirmed

Bug description:
  Currently the PluginBlocktype abstract class has three methods for
  loading Javascript libraries, and invoking Javascript code to run when
  a block is loaded:

  1. PluginBlocktype::get_instance_javascript(BlockInstance $instance):
  Called when a block instance is displayed (either on the page in view
  mode, or the page in edit mode). Expects to return an array of sub-
  arrays where each sub-array has a "file" item, which is the relative
  path to a JS file (relative to the blocktype's root), and an optional
  "init" item, which is a snippet of code that gets executed once the
  "file" library has loaded. (It currently uses jQuery.getScript() to do
  this).

  2. PluginBlocktype::get_instance_inline_javascript(BlockInstance
  $instance): Called when a block instance is displayed (either on the
  page in view mode, or the page in edit mode). The code here is
  inserted into a 

[Mahara-contributors] [Bug 1530045] Re: Pending friends aren't shown on person's "My friends" page who sent the request

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1530045

Title:
  Pending friends aren't shown on person's "My friends" page who sent
  the request

Status in Mahara:
  Confirmed

Bug description:
  When you send a friend request to someone, you request shows up as
  "Pending" on their "My friends" page. However, you don't see them as
  pending on your "My friends" page.

  To test:

  1. Send friend request to Paula (make sure that she doesn't have 
auto-accepting of friend requests turned on, which is the default)
  2. Go to Groups -> My friends.
  3. Expected result: You can see Paula listed as "Pending". Actual result: 
Paula doesn't show up at all.

  We do keep the information that you requested friendship with Paula
  because when you search for her on "Find friends", you'll see that it
  states that you requested friendship.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1530045/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1566122] Re: Select instittution with web service auth immediately for token

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1566122

Title:
  Select instittution with web service auth immediately for token

Status in Mahara:
  Confirmed

Bug description:
  When a user gets a service access token associated, the institution
  needs to be selected instead of being chosen per default. This means
  that "No institution" can show up when the user is actually a member
  of a different institution.

  This behavior is inconsistent to what you see in "Manage service
  users". There, you can't select your institution, but it is only
  displayed. So it might be an easy fix. :-)

  How to test:

  1) Go to Admin -> Extenstions -> Webservices test client and make sure
  web services is switched on

  2) Go to Institutions and create an institution

  3) Edit institution and for the 'Authentication plugin' dropdown pick
  'Webservices ...' and click 'Add' button then hit submit at bottom of
  form

  4) Go to Admin -> Users and click on a username of a user add them to
  the new institution (bottom of form)

  5) Now change their 'Authentication method' field to the one that is
  the institution name + 'webservice' - click the 'save changes' button

  6) Go back to Admin -> Extenstions -> Webservices and expand the
  'Manage service access tokens' part and search for the user and click
  'Generate token'

  7) On the next form click the 'Back' link at base of form - as we
  don't need to change anything thereat the moment

  8) You should see the user now listed with a 'Token' set. 
  Expected result: The institution should be the one to which you added them 
earlier
  Actual result: "No institution" is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1566122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1432823] Re: Mobile - Inconsistency in not being able to exporting pages

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1432823

Title:
  Mobile - Inconsistency in not being able to exporting pages

Status in Mahara:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  From what I understood, exporting pages is disabled when using Mahara
  on an Android or iOS device.

  However, it is possible to access the export interface when deleting a
  page. To reproduce, you have to click on the delete page icon. There
  is a notification that recommends exporting the page before deleting
  (check screenshots). The link "Exporting" sends the user to the export
  interface.

  This notification should be modified when accessing Mahara on a mobile
  device. The "Exporting" link should be removed. Unless the community
  has plans to include an export function on mobiles.

  This has been reproduce on Mahara 10.0.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1432823/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1632472] Re: Unable to uplaod .oga file

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1632472

Title:
  Unable to uplaod .oga file

Status in Mahara:
  Confirmed

Bug description:
  Version : 16.10

  Steps to reproduce:

  Pre Req: Make sure to enable the OGA audio file in
  administration>Extensions>file/internalmedia >oga-yes

  1) Navigate to Portfolio>pages
  2) click on one of the existing pages
  3) Click on edit the page and select Media>Embedded media>add
  4) Browse and upload a .oga file ( sample oga file attached)

  Expected result: .OGA should be uploaded
  Actual result: An error message is displayed saying " The file you uploaded 
was not the correct type for this block."

  Note: kristina verified it on 16.04 and it works fine( uploaded the
  same file that is attached )

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1632472/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1238373] Re: Mahara sites that have been around since before 1.2 have unique indexes where they should have unique keys

2016-10-20 Thread Robert Lyon
** Also affects: mahara/17.04
   Importance: Low
 Assignee: Aaron Wells (u-aaronw)
   Status: Confirmed

** Changed in: mahara/17.04
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1238373

Title:
  Mahara sites that have been around since before 1.2 have unique
  indexes where they should have unique keys

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed

Bug description:
  See https://bugs.launchpad.net/mahara/+bug/1238363

  In the run-up to 1.2.0, we changed the XMLDB library so that it
  created proper unique keys. Prior to that, whenever you told it to
  create a unique key, it actually created a unique index.

  Normally this doesn't cause any noticeable difference in behavior. But
  in bug 1238363 it caused upgrade to crash, because the drop_key()
  method didn't find the key that was expected. Instead, there was an
  index.

  Potential fixes for this may include:

  1. Investigate the difference between a unique key and unique index in
  MySQL and Postgres to make sure that they really are 100% identical in
  behavior

  2. A one-off upgrade in lib/db/upgrade.php that finds all the "legacy"
  indexes and drops them and recreates them as keys. However, since
  sites that have been around since 1.2 tend to be rather large, this
  might be a slow process.

  3. Make drop_key() more robust, so that if there is no key by that
  name on that table, it just looks for an index by that name on that
  table. This has the potential to be an unexpected side effect and thus
  cause problems of its own, but I think it'd be pretty rare for someone
  to create a key and an index with the same name, on the same table. It
  could also print a debug() message when silently doing this
  substitution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1238373/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1517729] Re: Better documentation of the compatible Elasticsearch version

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1517729

Title:
  Better documentation of the compatible Elasticsearch version

Status in Mahara:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  See the discussion at the bottom of Bug 1389446.

  Currently, Mahara is using Elastica version 2.0 for our Elasticsearch
  PHP library. The Elastica project uncoupled their version numbers from
  Elasticsearch's version numbers with the 2.0 release, so Elastica 2.0
  was written to support Elasticsearch 1.5.

  However, there doesn't seem to be anywhere in the Mahara documentation
  that specifies *which* version of Elasticsearch we support. Even the
  README.Mahara file in htdocs/lib/elastica doesn't say it! So, we
  should really document that somewhere. Possibly in Mahara's main
  README, and/or the Elastica README, maybe even on the elasticsearch
  plugin's config page.

  In fact... maybe it would be a good idea if the elasticsearch plugin
  was able to sniff the elasticsearch version and tell you that it's not
  a compatible version? Of course, that does rely on the version
  detection system of Elasticsearch being backwards compatible.

  On a related note, we should also upgrade our Elastica version.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1517729/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1396321] Re: Allow certain registration information to be public

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1396321

Title:
  Allow certain registration information to be public

Status in Mahara:
  Confirmed

Bug description:
  Mahara instances can decide whether they want to register with the
  Mahara project or not. Currently, the stats that are collected are
  only visible to the Mahara core project team as we do not ask site
  admins permission to make them available more widely to the community
  like for example Moodle: http://moodle.net/stats/

  We should be changing that with the next release and ask permission to
  make certain information available anonymously to the entire
  community. We shouldn't make all the information available that we
  collect, but just the most high level ones like

  - Geographical location of the registered site
  - The site name and URL itself like on http://moodle.net/sites/
  - Number of registered users
  - Version of Mahara used (unless we decide it's a security risk)
  - Number of pages created (could be beneficial to see how active users are on 
the site; ideally excl. dashboards, profile pages and group homepages)

  The information that is shared publicly anonymously with others should
  be highlighted when you review what information is sent when
  registering the site.

  When we make that change, I think we should reset the registration
  checkbox for sites that had it set to give them the chance to review
  the setting and make a conscious decision about registering as it's
  kinda like accepting new Terms and Conditions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1396321/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 784341] Re: Fix xmldb postgres generator to preserve unique keys during alter table

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/784341

Title:
  Fix xmldb postgres generator to preserve unique keys during alter
  table

Status in Mahara:
  Confirmed

Bug description:
  See bug #784322.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/784341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1509167] Re: PHP error message when you submit a page access end date in the past

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1509167

Title:
  PHP error message when you submit a page access end date in the past

Status in Mahara:
  Confirmed

Bug description:
  To replicate:

  1. Create a page
  2. Share page
  3. On the share page screen, share with "Public"
  4. On the ACL line for public, set "Access end date/time" to a date in the 
past
  5. Save

  Expected result: You should see some Mahara end-user error messages
  telling you "The end date for 'Public' access cannot be in the past."
  and "There was an error with submitting this form. Please check the
  marked fields and try again."

  Actual result: In addition to those, PHP throws an error message:

  Set a date in the past with the format: %%d/%%m/%%Y

  [WAR] 32 (lib/form/elements/viewacl.php:65) Undefined index: id
  Call stack (most recent first):

  log_message("Undefined index: id", 8, true, true, 
"/var/www/html/maharagerrit/htdocs/lib/form/element...", 65) at 
/var/www/html/maharagerrit/htdocs/lib/errors.php:441
  error(8, "Undefined index: id", 
"/var/www/html/maharagerrit/htdocs/lib/form/element...", 65, array(size 17)) at 
/var/www/html/maharagerrit/htdocs/lib/form/elements/viewacl.php:65
  pieform_element_viewacl(object(Pieform), array(size 13)) at 
/var/www/html/maharagerrit/htdocs/lib/pieforms/pieform.php:1480
  Pieform->build_element_html(array(size 13)) at 
/var/www/html/maharagerrit/htdocs/lib/pieforms/pieform.php:714
  Pieform->build() at 
/var/www/html/maharagerrit/htdocs/lib/pieforms/pieform.php:169
  Pieform::process(array(size 8)) at 
/var/www/html/maharagerrit/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 8)) at 
/var/www/html/maharagerrit/htdocs/view/access.php:546

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1509167/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1563641] Re: Rewrite "mixed content" URLs via an HTMLPurifier custom filter

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1563641

Title:
  Rewrite "mixed content" URLs via an HTMLPurifier custom filter

Status in Mahara:
  Confirmed

Bug description:
  "Mixed content" refers to the scenario where a web page is served via
  HTTPS, but it includes assets that are served via an HTTP URL. See
  https://developer.mozilla.org/en-US/docs/Security/Mixed_content for
  some discussion of this.

  In Bug 1463629 we fixed this issue for embedded iframes, by patching
  the HTMLPurifier core class HTMLPurifier_URIFilter_SafeIframe so that,
  in addition to filtering iframes for an allowed set of URLs, it also
  transformed them from HTTPS to HTTP if needed.

  After having recently done some work on HTMLPurifier for other bugs,
  and becoming more familiar with their API, it now becomes apparent to
  me that this was a bit of a hack (patching core code should have told
  me this anyway). What we should have done is, instead, write up a new
  custom URIFilter specifically for rewriting URI's from HTTP to HTTPS
  in this way, and used that instead.

  Doing it that way will make future HTMLPurifier upgrades easier, by
  eliminating the need to patch that file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1563641/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1360536] Re: Change page sort order without having to click "Search" button

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1360536

Title:
  Change page sort order without having to click "Search" button

Status in Mahara:
  Confirmed

Bug description:
  Follow on from bug #1302297 comment #10 in regards to the new sort
  option for pages:

  Currently, you need to click the search button to conduct a search,
  but it might be better to have the results change as soon as you
  change the option in a drop-down menu.

  

  If implemented, I think we'd need to implement that across the board
  for all searches to be consistent. A change would also need to work on
  mobile and be accessible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1360536/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1443286] Re: Send out a notification to page watchers when a comment is made public

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1443286

Title:
  Send out a notification to page watchers when a comment is made public

Status in Mahara:
  Confirmed

Bug description:
  As described here:
  https://bugs.launchpad.net/mahara/+bug/1374674/comments/9

  If you put a page on your watchlist, you will receive notifications
  when public feedback is placed on that page. However, you will not
  receive a notification if a person places private feedback which is
  later made public. Or if the page has comment moderation turned on.

  It would be good to send a notification out to page watchers when
  private comments are made public.

  To replicate:

  1. Log in as User A.
  2. Create a page. Allow comments, and make the page public.
  3. Log in as User B.
  4. Place the page on your watchlist.
  5. Log back in as User A.
  6. Place a comment on the page, marking the comment "private".
  7. Once the comment has been posted, make it public.

  Expected result: User B receives a notification about this new comment they 
can now see
  Actual result: User B receives no notification.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1443286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1522215] Re: Make the multirecipientnotification module non-hideable

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1522215

Title:
  Make the multirecipientnotification module non-hideable

Status in Mahara:
  Confirmed

Bug description:
  Mahara 15.10 depends on the multirecipientnotification module for core
  functionality. It should be non-hideable.

  This means setting the "can_be_disabled()" function on it to false.

  But further than that, there can be (strange) cases where the module
  gets disabled in the database, which will cause the Inbox block on the
  standard dashboard page to error out. I think in addition to marking
  that "can_be_disabled()" flag, we should change the plugin loading
  functions so that they ignore the "disabled" flag in the database, for
  plugins that cannot be disabled.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1522215/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1394082] Re: Can create a URL that takes you to a different page depending on whether you're logged in to MNet or not.

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1394082

Title:
  Can create a URL that takes you to a different page depending on
  whether you're logged in to MNet or not.

Status in Mahara:
  Confirmed

Bug description:
  As reported on the mahara.org forum:
  https://mahara.org/interaction/forum/topic.php?id=6549

  To replicate:

  1. Set up a Moodle instance with the Mahara assignment submission
  plugin and connect it up to your Mahara instance.

  2. Create a view with ID 1000.

  3. Create another view with ID 1001.

  4. Make both these pages accessible to the public.

  5. Set up an Mahara assignment in Moodle.

  6. Submit the view with ID 1000 to Moodle as an assignment submission.

  7. Note the access URL that gets generated, which will contain an MNet
  access token, i.e. /view/view.php?mt=abcd1234

  8. Add the ID of page 1001 to this URL:
  /view/view.php?id=1001=abcd1234

  Expected Result: This URL should either display page 1000 every time,
  or an "access denied" message

  Actual Result: If you're logged in to Mahara via MNet, you see page
  1000. If you're not, you see page 1001.

  
  The cause of this problem, is that /view/view.php completely ignores the 
"mt=" tag if you're not logged in via MNet. In which case, if an ID is also 
supplied, it falls back to that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1394082/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1512894] Re: Leap2A import isn't populating the artefact_file_embedded table for most things

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1512894

Title:
  Leap2A import isn't populating the artefact_file_embedded table for
  most things

Status in Mahara:
  Confirmed

Bug description:
  The artefact_file_embedded table was added with the TinyMCE image
  picker button. Its purpose is to store the embed relationship, so that
  it can be checked for permission purposes (I have permission to view
  this thing; do I then have permission to view this other thing?)

  Currently, it's somewhat redundant for some purposes, because this
  relationship is also tracked in the view_artefact &
  artefact_attachment tables, as well as a couple of other places. But
  artefact_file_embedded is unique in that it's abstract enough to cover
  cases that aren't covered by the other tables, such as view
  descriptions and forum posts.

  So, for best practice, we should always be populating this table
  whenever we embed an image into a text field. And we do this pretty
  much everywhere *except* in Leap2a imports.

  For Leap2a imports, artefact_file_embedded is populated for images in
  view descriptions, but not for images embedded in anything else: blog
  entries, resume fields, text blocks, notes, etc.

  We should re-use the
  EmbeddedImage->rewrite_embedded_image_urls_from_import() method, for
  all imports. By my analysis, it can probably go in (or maybe replace)
  the call to ImportLeap->fix_artefact_references() in
  ImportLeap->do_import()

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1512894/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1396761] Re: allow for reordering of files in image gallery block

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1396761

Title:
  allow for reordering of files in image gallery block

Status in Mahara:
  Confirmed

Bug description:
  This bug is similar to https://bugs.launchpad.net/mahara/+bug/732462
  and any resorting drag/drop fix there will need to be done for this as
  bug also.

  But there is another complicating factor that makes this bug separate
  and that is:

  When we first add a gallery block to a page and select some images to
  be attached to it the block renders them in the order we selected
  them.

  but when we got to edit the block again to add more items it changes
  the sort order of the originally added items

  This is due to the image gallery using a function to return the
  information for the selected items via:

  'selectlistcallback' => 'artefact_get_records_by_id'

  and that function returns a list of selected items in the order of
  when they were created in the system - eg an array of class objects
  with each class->id being the array key.

  eg:

  array (
  [9] => stdClass Object
  (
  [artefacttype] => image
  [title] => cats.jpg
   ...
  [id] => 9
  )
  [16] => stdClass Object
  (
  [artefacttype] => image
  [title] => ants.jpg
  ... 
  [id] => 16
  )

  
  So we end up with something that is not alphabetical - nor the order we 
selected them to be attached to the block

  What would be needed is to take the $values (which is in the order of
  attaching to block) and impose that sort order on the $selected array
  so that when we edit the block again it doesn't loose our initial
  selection order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1396761/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1381184] Re: need to drop old default email option

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1381184

Title:
  need to drop old default email option

Status in Mahara:
  Confirmed

Bug description:
  Now that we use individual default email options for each activity
  type we need a patch to remove the 'defaultnotificationmethod' from
  config table.

  But the problem is we can't add it to the lib/db/upgrade.php as that
  is run before the upgrade on plugins - nor can we put it in the
  postinst of a plugin because we don't know which plugins will need to
  be updated last post 1.9 - eg if we go from 1.9 -> 1.10 or even 1.9 ->
  1.15 we will need to know the old defaultmethod. But after the initial
  jump we will not need to know about it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1381184/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 739528] Re: Export to HTML doesn't use selected theme

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/739528

Title:
  Export to HTML doesn't use selected theme

Status in Mahara:
  Confirmed

Bug description:
  When a view or views is/are exported, the default "raw" style sheet
  (theme) is used for display. The export should use the selected theme
  instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/739528/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1489258] Re: Unnecessary labels on buttons in Plugin administration

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1489258

Title:
  Unnecessary labels on buttons in Plugin administration

Status in Mahara:
  Confirmed

Bug description:
  In Administration -> Plugin administration, each "Show" and "Hide"
  button has a hidden label associated with it. This isn't actually
  necessary and is confusing for screen reader users since it appears
  that there is plain text in front of each button with the same text as
  the button. In this case the label should be removed and hidden text
  saying the same thing should be added to the button.

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1489258/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1510278] Re: Behat test "group_view_block.feature" fails in MySQL

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1510278

Title:
  Behat test "group_view_block.feature" fails in MySQL

Status in Mahara:
  Confirmed

Bug description:
  Hi all,

  I ran the Behat suite when we did the release. 15.10. One scenario
  failed.

  Feature:
   `Show the block "Group pages" in the group homepage'.

  Step that failed:
   Form field with id|name|label|value "group_view_submission_form_2_options" 
not found.
  In step `And I select "Page userA_01" from 
"group_view_submission_form_2_options"'. 

  This test is testing  (Bug 1457246). If you'd rather grep search the
  tests using this :)

  This is one of the steps that failed but a few more steps in this
  scenario didn't run because they were dependent on this step.

  Cheers.
  Jinellle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1510278/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1434316] Re: Why two pieform directories?

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1434316

Title:
  Why two pieform directories?

Status in Mahara:
  Confirmed

Bug description:
  Currently the basic pieform elements information lives in:

  htdocs/lib/pieforms/pieform/

  but there are also pieform elements that live in
  htdocs/lib/forms/

  Why do we need to have them in two places?

  I can imagine that there might have been a reason to keep the pieform
  plugin separate from custom pieform elements but seeing as mahara
  pieform is really a fork of the original this seperation is not needed
  within mahara.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1434316/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1402689] Re: Personal information block cannot be copied with exact same information

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1402689

Title:
  Personal information block cannot be copied with exact same
  information

Status in Mahara:
  Confirmed

Bug description:
  When you share a page with the "Profile information" bloc  and allow
  it to be copied, the page is not transfered 100%.

  To reproduce:

  1. As a 1st user, create a page with a "Profile information" bloc, fill it 
with only First name, last name and id#
  2. Share this page with a 2nd user
  3. As the 2nd user, copy the page shared by the 1st user

  Result: When checking that freshly copied page (user #2), not only the
  information did not transfered correctly, but others fields in the
  "Personnal information" bloc are now showing... It should be only
  showing the 3 fields that were filled by the 1st user.

  This bug affects 1.9.1 and 1.10.1 at the moment with any internet
  browser.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1402689/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1513665] Re: Get an HTML5 "click-to-copy" widget

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513665

Title:
  Get an HTML5 "click-to-copy" widget

Status in Mahara:
  Confirmed

Bug description:
  In Bug 1314890, on the Secret URLs page we added the zeroclipboard
  library to allow users to click a clipboard icon and have the URL
  copied to their clipboard. Unfortunately, since then Flash has started
  dying in a bad way, and now this sort of Flash-based clipboard widget
  is on the way out, and can cause browsers to pop up warning messages
  and such.

  Now, there is no way to accomplish exactly this same functionality
  (copy to clipboard) without Flash currently. But, there are some
  useable alternatives. The one that seems to be poised to replace the
  click-to-copy pattern, is that you click and it automatically selects
  the full text, so that you then just have to hit "control-C" instead
  of first dragging to select it all.

  Jen recently added this little clipboard library to the styleguide.php
  script. It works pretty good, so we may as well adopt it for the
  Secret URL screen as well.

  http://zenorocha.github.io/clipboard.js/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513665/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1446400] Re: Add anchor button to tinymce

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1446400

Title:
  Add anchor button to tinymce

Status in Mahara:
  Confirmed

Bug description:
  One of the useful tinyMCE buttons that we currently do not use is the
  Anchor button to allow one to add anchors to a block of text.

  It should be a matter of adding 'anchor' to the plugins and toolbar
  sections of lib/web.php

  and then testing it out to make sure it works as expected

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1446400/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1619051] Re: File extraction success screen 'continue' link hard to spot

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1619051

Title:
  File extraction success screen 'continue' link hard to spot

Status in Mahara:
  Confirmed

Bug description:
  When one uploads a compressed file, say a .zip or .tar file to the
  Files section there is a 'decompress' button the y can click to
  extract the files.

  On clicking the button it gives a list of files that will be
  decompressed and on clicking 'decompress' button it should give a
  progress bar as files are extracted and then a message in the bar with
  success information and 'continue' link.

  This message and link are hard to see.

  It would be better if either:

  A) When the extraction is completed one is redirected to the place the
  'continue' link goes to automatically and have the $session display
  the ok message, eg 'Created 2 folders and 6 files' there to avoid
  needing an extra click here.

  or

  B) If that is not possible have the success message appear below the
  progress bar rather than on it and make the font a bit bigger.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1619051/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1295472] Re: Booklet plugin

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1295472

Title:
  Booklet plugin

Status in Mahara:
  Confirmed

Bug description:
  Booklet plugin is an artefact to build or modify resume-like artefacts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1295472/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1443239] Re: Warning in Mahara logs when a MaharaDroid user has no tags in their Mahara account

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1443239

Title:
  Warning in Mahara logs when a MaharaDroid user has no tags in their
  Mahara account

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Won't Fix
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  This is a bug in the Mahara PHP code which interfaces with the
  MaharaDroid android app. See
  https://github.com/MaharaProject/maharadroid/issues/6 for the
  MaharaDroid side of this bug.

  To replicate:

  1. Create a new Mahara account
  2. Connect it to MaharaDroid
  3. Try to upload a file via MaharaDroid

  Result: You see this warning in the Apache logs:

  
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] [WAR] 88 
(api/mobile/sync.php:77) Invalid argument supplied for foreach()
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] Call stack (most 
recent first):
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] * 
log_message("Invalid argument supplied for foreach()", 8, true, true, 
"/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77) at 
/home/demo/code/mahara/htdocs/lib/errors.php:430
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] * error(2, "Invalid 
argument supplied for foreach()", 
"/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77, array(size 59)) at 
/home/demo/code/mahara/htdocs/api/mobile/sync.php:77
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88]

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1443239/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1487299] Re: All edit and delete buttons should contain the name of what they manage

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487299

Title:
  All edit and delete buttons should contain the name of what they
  manage

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Reopening Bug #1276397 - in the new Bootstrap theme, all edit and
  delete buttons seem to have descriptive text attached to them ("Edit"
  and "Delete"), but it is sometimes ambiguous for screen reader users
  which list item they refer to. In particular:

  - On the My groups page, Settings and Delete buttons should contain the name 
of the group (see Bug #1482482)
  - In the Resume (Education and employment, Achievements) edit and delete 
buttons should contain some information about the row they are on
  - Under Journals, all Edit and Delete buttons should include the name of the 
journal (or entry) they control
  - Same for files in the file browser (eg. Content -> Files)

  For an example of how to include this text, see the edit and delete
  buttons in the list on Portfolio -> Pages.

  There are probably other examples - they should be added here and then
  could be spun off into separate bug reports for fixing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487299/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1541165] Re: Hide the activity types that belong to disabled plugins

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1541165

Title:
  Hide the activity types that belong to disabled plugins

Status in Mahara:
  Confirmed

Bug description:
  In the "User settings -> Notifications" screen, and in the Inbox block
  config, the end user is shown all installed Activity types, even if
  they belong to plugins that are currently hidden.

  This matters specifically because the "Annotation" plugin is hidden by
  default. So it's not good practice to show end users settings related
  to this notification type it will be impossible for them to receive.

  The activity_type table has columns "plugintype" and "pluginname" to
  indicate when an activity belongs to a plugin. So, we should use that
  to check whether the associated plugin is disabled, when displaying a
  list of notification activity types to end users.

  It's still fine to show all activity types to admin users, although in
  those cases it may also make sense to gray out or otherwise indicate
  the inactivity of activity types associated with a disabled plugin.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1541165/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1415258] Re: Behat is having issues unzipping a file

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1415258

Title:
  Behat is having issues unzipping a file

Status in Mahara:
  Confirmed

Bug description:
  Hi Sonn,

  Behat is having some issues decompressing a file. It relates to this
  bug #1386970.

  The tags were added and it was merged, maybe the wrong step definition
  is being used here. This test was written for 1.10 there's a
  possibility the wording has changed since then also.

  This is also dependent on the file attachment step.

  I have attached a test below to test with.

  Cheers,
  Jinelle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1415258/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1363754] Re: extract file's progress bar has wonky progression

2016-10-20 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: Confirmed => Won't Fix

** Changed in: mahara/16.10
Milestone: 16.10.1 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1363754

Title:
  extract file's progress bar has wonky progression

Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Won't Fix
Status in Mahara 16.04 series:
  Won't Fix
Status in Mahara 16.10 series:
  Won't Fix

Bug description:
  The extraction progression is stilted and for a the first bit doesn't
  even indicate that it is working.

  See attached video of what is happening

  We know from the check screen before how many files there are to
  extract so we could use that info straight off to display initial
  progress.

  And we need to get it so the progress bar doesn't blink on/off all the
  time.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/15.04/+bug/1363754/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] Re: Mahara doesn't ask you for your password before deleting your account or changing your username

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  Confirmed

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1519989] Re: Refactor duplicate collections access code in index.php & index.json.php

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1519989

Title:
  Refactor duplicate collections access code in index.php &
  index.json.php

Status in Mahara:
  Confirmed

Bug description:
  After patch https://reviews.mahara.org/#/c/5695/6 for Bug1514374,
  we've now got duplicate code it htdocs/collection/index.php and
  htdocs/collection/index.json.php, for checking whether the user has
  access to the particular collections they're trying to look at.

  This kind of duplication stands a high likelihood of falling out of
  sync if changes are made to the access code in the future, so we
  should abstract it out into a common access method that gets called by
  both scripts.

  The code is not *exactly* the same in both places. index.php
  intersperses it with code to set the menu headers, and index.json.php
  sends an error via json_reply on failure, while index.php throws an
  AccessDeniedException(). So it will require a little bit of thinking
  to do it. But it's not impossible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1519989/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1618269] Re: Issue with uploader saving oldextension value for files with mutiple suffixes

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1618269

Title:
  Issue with uploader saving oldextension value for files with mutiple
  suffixes

Status in Mahara:
  Confirmed

Bug description:
  One thing I noticed with testing the bug 1602452 is this

  Say I have a file called my_test.tar.bz2 (a compressed tar archive
  file) and I upload it to Mahara.

  When it gets saved one of the pieces of information stored in the db
  is its artefact_file_files.oldextension value. I would expect it to be
  saved as 'tar.bz2' but it is only saved as 'bz2'.

  So when I go to extract the file on the confirm page it says: "Files
  will be extracted into my_test.tar"

  And when I do the extraction the directory created is called
  'my_test.tar' rather than 'my_test'

  The system does work but it could be improved so I've marked this as a
  'low' bug

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1618269/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1037365] Re: some third party libraries do not respect the directorypermissions config setting

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1037365

Title:
  some third party libraries do not respect the directorypermissions
  config setting

Status in Mahara:
  Confirmed

Bug description:
  one example is htmlpurifier, from a git grep mkdir, i see that pear,
  dwoo, adobdb, and flowplayer may also be culprits

  Also, the internal examples
  - extract function in artefact/file.lib.php
  - copyr function in lib/file.php
  - there is one instance in lib/db/upgrade.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1037365/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1509175] Re: PHP warning during 1.6/1.7/1.8 -> 15.10 upgrade

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1509175

Title:
  PHP warning during 1.6/1.7/1.8 -> 15.10 upgrade

Status in Mahara:
  Confirmed

Bug description:
  To replicate:

  1. Clean install of Mahara 1.6.5
  2. Log in to Mahara
  3. Upgrade to Mahara 15.10.0 (via the web browser)

  Result: The upgrade works as expected, but PHP prints this warning:

  [WAR] ea (lib/errors.php:747) Failed to get a recordset: postgres8 error: 
[-18: ERROR:  relation "institution_config" does not exist
  LINE 1: DELETE FROM "institution_config" WHERE field LIKE '%/_nav/_%...
  ^] in EXECUTE("DELETE FROM "institution_config" WHERE 
field LIKE '%/_nav/_%' ESCAPE '/'")
  Command was: DELETE FROM "institution_config" WHERE field LIKE '%/_nav/_%' 
ESCAPE '/'
  Call stack (most recent first):

  log_message("Failed to get a recordset: postgres8 error: [-18: ...", 8, 
true, true) at /home/aaronw/www/mahara-clients/htdocs/lib/errors.php:97
  log_warn("Failed to get a recordset: postgres8 error: [-18: ...") at 
/home/aaronw/www/mahara-clients/htdocs/lib/errors.php:747
  SQLException->__construct("Failed to get a recordset: postgres8 error: 
[-18: ...") at /home/aaronw/www/mahara-clients/htdocs/lib/dml.php:974
  delete_records_sql("DELETE FROM {institution_config} WHERE field LIKE 
...", array(size 0)) at /home/aaronw/www/mahara-clients/htdocs/lib/web.php:3011
  clear_menu_cache() at 
/home/aaronw/www/mahara-clients/htdocs/admin/upgrade.json.php:70

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1509175/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1509180] Re: PHP warning message during 1.8/1.9/1.10/15.04 -> 15.10 upgrade of a completely new site

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1509180

Title:
  PHP warning message during 1.8/1.9/1.10/15.04 -> 15.10 upgrade of a
  completely new site

Status in Mahara:
  Confirmed

Bug description:
  To replicate:

  1. Clean install of 15.04.3
  2. Upgrade to 15.10_STABLE

  Result:

  The upgrade proceeds okay, but you see this warning message:

  [DBG] c7 (lib/db/upgrade.php:4164) Add user_login_data table to record when a 
user logs in
  [WAR] c7 (lib/db/upgrade.php:4178) Invalid argument supplied for foreach()
  Call stack (most recent first):

  log_message("Invalid argument supplied for foreach()", 8, true, true, 
"/home/aaronw/www/mahara-clients/htdocs/lib/db/upgr...", 4178) at 
/home/aaronw/www/mahara-clients/htdocs/lib/errors.php:441
  error(2, "Invalid argument supplied for foreach()", 
"/home/aaronw/www/mahara-clients/htdocs/lib/db/upgr...", 4178, array(size 18)) 
at /home/aaronw/www/mahara-clients/htdocs/lib/db/upgrade.php:4178
  xmldb_core_upgrade("2015030417") at 
/home/aaronw/www/mahara-clients/htdocs/lib/upgrade.php:359
  upgrade_core(object(stdClass)) at 
/home/aaronw/www/mahara-clients/htdocs/admin/upgrade.json.php:90

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1509180/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1452625] Re: "Date modified" on footer of each page

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1452625

Title:
  "Date modified" on footer of each page

Status in Mahara:
  Confirmed

Bug description:
  It would be really nice to have a "last modified" date in the footer
  of each page.  I've done a search for this but haven't come across
  anything.

  Regards
  Marion MacDonald

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1452625/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1481450] Re: Should copied page names start at "v.2" or "v.1" (or something else)?

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1481450

Title:
  Should copied page names start at "v.2" or "v.1" (or something else)?

Status in Mahara:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  In Mahara master (15.10dev), the page version numbers were changed and
  a "v." added. However, now the page version numbers start at 2 instead
  of 1. In a sense that is correct because the original page would be
  version 1, but without actually seeing that version number, it is
  confusing why there would be version 2 when no version 1 can be seen.

  Do others feel the same or am I overthinking things?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1481450/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1443287] Re: Get rid of redundant watchlist adds, for users who would receive feedback notifications anyway

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1443287

Title:
  Get rid of redundant watchlist adds, for users who would receive
  feedback notifications anyway

Status in Mahara:
  Confirmed

Bug description:
  As described here:
  https://bugs.launchpad.net/mahara/+bug/1374674/comments/9

  In Bug 1374674, we made it so that when you comment on a page, that
  page is added to your watchlist. However, we set it so that this does
  not happen if you are the owner of the page, because then it's
  redundant (you already receive notifications about feedback to the
  page).

  It would be good to extend that redundant-watchlist-prevention to site
  pages, group pages, and institution pages as well. I.e., if you are a
  site admin and you comment on a site page, we don't add it to your
  watchlist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1443287/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1487274] Re: Elasticsearch choking on non-ASCII characters

2016-10-20 Thread Robert Lyon
** Changed in: mahara/16.10
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487274

Title:
  Elasticsearch choking on non-ASCII characters

Status in Mahara:
  Confirmed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  In 15.10 I've added code to "quarantine" records that Elasticsearch
  won't index. That is, if Elasticsearch errors out while processing a
  batch of records, then I re-try each record individually. And if it
  errors out while processing one of those individual records, I mark
  the record as quarantined, and keep it in the
  search_elasticsearch_queue table.

  I've backported that to one of our large 15.04 sites, and since then
  I've taken a look at the data in the records that have caused
  Elasticsearch to choke. They all contain non-ASCII characters, i.e.
  Unicode characters. These can be as simple as "e with an accent over
  it", all the way up to exotic ones like emoji and the Unicode snowman.

  I was not able to replicate this when testing on my local machine, but
  it is certainly in place on our production servers, and bugs such as
  Bug 1408577 make me think it's probably also present on some other
  servers as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487274/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506654] Re: Share page/collection 'Share with' institution/group options are too many

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506654

Title:
  Share page/collection 'Share with' institution/group options are too
  many

Status in Mahara:
  Confirmed

Bug description:
  If you have a multi tenanted site with many institutions and a user
  belongs to all of them

  and/or

  You have many groups and a user belongs to many groups

  When you go to share a page it lists all the groups/institutions you
  can share with as a separate row in the 'Share with' dropdown.

  What would be better is if the 'Institutions' and 'Groups' options
  worked similar to the 'Find friends' option where you are given a
  second select2/dropdown after making the first selection.

  
  This way one could do a pick like:

Share with -> 'Institution', then pick from 2nd box 'Institution Alpha'
Share with -> 'Group', then pick from 2nd box 'Group Omega'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506654/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1259756] Re: [Ongoing] All form elements need labels

2016-10-20 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: New => Incomplete

** Changed in: mahara/16.10
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1259756

Title:
  [Ongoing] All form elements need labels

Status in Mahara:
  Incomplete
Status in Mahara 16.10 series:
  Incomplete
Status in Mahara 17.04 series:
  Incomplete

Bug description:
  Parent bug: Please make a new bug report for each section that is
  fixed which references this bug in the description, and add a comment
  here with the new bug number.

  For people using screen readers, having a label for every form input
  is essential as they have no other (easy) way of knowing what the
  input is for. Currently there are various form fields in Mahara which
  do not have labels, so either existing labels need to be linked to
  these inputs or new (hidden) ones need to be created.

  - "Upload file" in Content -> Profile -> Files [DONE]
  - New folder name input in Content -> Profile -> Files [DONE]
  - Radio buttons in email selector [now in Bug #1277297]
  - Pagination combobox [now in Bug #1277276]
  - Profile picture radio buttons and checkboxes [DONE]
  - "Attach file" labels in Content -> Resume [now in Bug #1277290]
  - Collection and page checkboxes when editing permissions for a group [now in 
Bug #1278216]
  - Cookie consent -> Types of cookies checkboxes [part of Bug #1278216]
  - Portfolio -> Skins (the whole form, particularly the 8-direction placement 
elements) [now in Bug #1273937]
  - Administration -> Fonts (similar issues to Skins)
  - Non-JS radio buttons in the page editor [part of Bug #1262933]
  - "Add a new entry to ..." combo box in Journal entries block (multiple 
journals only)
  - "Ignore" and "Add new" radio buttons used when importing [now in Bug 
#1278238]

  Affects latest master

  (WCAG Level A)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1259756/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528117] Re: Collection export options need bulk options

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528117

Title:
  Collection export options need bulk options

Status in Mahara:
  Confirmed

Bug description:
  Mahara 16.04

  When you export a portfolio, you can choose to select pages or
  collections. The "Pages" screen has bulk options of selecting all or
  reversing the selection facilitating the selection of multiple pages.
  The collection screen doesn't have these options yet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528117/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528118] Re: Preview collections on Export screen

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528118

Title:
  Preview collections on Export screen

Status in Mahara:
  Confirmed

Bug description:
  When you export pages, you can preview them. But you don't have that
  option for collections. There should be a collection preview link
  which takes you to the first page of the collection and ideally you
  can navigate through the other pages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528118/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1529730] Re: Show full introduction from the profile

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1529730

Title:
  Show full introduction from the profile

Status in Mahara:
  Confirmed

Bug description:
  Mahara 15.10+

  When a user wrote an introduction and it is longer than a few
  characters, it is cut off. However, unless the user puts that
  introduction on their profile page, there is no place to see it fully.

  Therefore, when you are on the group members page or on "My friends"
  and "Find friends", it would be good to display the entire
  introduction. If people do tend to write a lot, then maybe we don't
  show the introduction directly on the page but only upon a click on
  it. Or have a link they can click to expand the introduction.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1529730/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1603658] Re: "Other license (enter URL)" does not work

2016-10-20 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: New => Confirmed

** Changed in: mahara/16.10
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603658

Title:
  "Other license (enter URL)" does not work

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  When you choose the option "Other license (enter URL)" in your
  personal settings, file upload or other places, there is supposed to
  be a second field that comes up in which you can enter the URL for
  that new license. This isn't happening in Mahara 15.10+ and probably
  got lost during the Bootstrap conversion.

  To test:

  1. Go to "Administration -> Configure Site -> General Settings", and
  enable "License metadata" and "Custom licenses".

  2. Change your default license in your account settings
  /account/index.php to "Other license (enter URL)".

  Expected result: Another text field opens up where you can enter the
  URL for this new license.

  Actual result: Nothing happens.

  Other places where this happens: Any artefact where you can choose a
  license.

  It still works in Mahara 15.04 prior to the move to Bootstrap.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603658/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1444457] Re: Standarize the call of some image files

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/157

Title:
  Standarize the call of some image files

Status in Mahara:
  Confirmed

Bug description:
  The following images call are incorrect and may be modified to use the 
$THEME->get_image_url() method:
  htdocs/artefact/blog/atom.php  line 91, column 77
  htdocs/export/html/lib.php line 258, column 82
  htdocs/interaction/forum/atom.php  line 151, column 69
  htdocs/theme/raw/artefact/file/export/html/templates/index.tpl line 
23, column 76
  htdocs/theme/raw/artefact/file/export/html/templates/index.tpl line 
32, column 76
  htdocs/theme/raw/artefact/file/export/html/templates/index.tpl line 
41, column 74
  
htdocs/theme/raw/artefact/internal/blocktype/socialprofile/templates/content.tpl
   line 11, column 115
  htdocs/theme/raw/artefact/plans/templates/taskrows.tpl line 13, 
column 101
  htdocs/theme/raw/artefact/plans/templates/taskrows.tpl line 27, 
column 104
  htdocs/theme/raw/artefact/plans/templates/taskslist.tplline 8, column 
94
  htdocs/theme/raw/artefact/plans/templates/taskslist.tplline 16, 
column 97
  htdocs/theme/raw/pieforms/viewlayout.php   line 33, column 151
  htdocs/theme/raw/pieforms/viewlayout.php   line 96, column 151
  htdocs/theme/raw/search/elasticsearch/templates/artefact.tpl   line 7, column 
135

  Also, the following language packs may use parameters instead of
  hardcoding images :

  htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html  line 
4, column 111
  htdocs/lang/en.utf8/help/forms/accountprefs.addremovecolumns.html  line 
4, column 188
  htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html   line 4, column 
108
  htdocs/lang/en.utf8/help/forms/adduser.addremovecolumns.html   line 4, column 
181
  htdocs/lang/en.utf8/help/forms/license.icon.html   line 6, column 23
  htdocs/lang/en.utf8/help/forms/license.icon.html   line 7, column 33
  htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html line 
4, column 117
  htdocs/lang/en.utf8/help/forms/uploadcsv.addremovecolumns.html line 
4, column 194

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/157/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1437956] Re: Behat: New fixture Given the"block" exists:

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1437956

Title:
  Behat: New fixture Given  the"block" exists:

Status in Mahara:
  Confirmed

Bug description:
  Hi,

  It would be more efficient if we had a fixture for just adding blocks
  to a portfolio.

  As  an example the fixture could say:

  And the given "name of block" block exists:

  We could also make this fixture link to a group/institution. So the
  following blocks exists for a certain group page. Don't know if that's
  plausible or is right, but it's an idea.

  Thanks ,

  Jinelle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1437956/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1576074] Re: Adopt PSR-2 for our PHP code format

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576074

Title:
  Adopt PSR-2 for our PHP code format

Status in Mahara:
  Confirmed

Bug description:
  Currently Mahara has its own idiosyncratic code formatting guidelines:
  https://wiki.mahara.org/wiki/Developer_Area/Coding_guidelines

  It would make things easier for new devs, and improve tool support, if
  we switched to the industry standard PSR-2: http://www.php-
  fig.org/psr/psr-2/

  It would also be good to decide on a Javascript coding standard.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576074/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1444461] Re: Allow the use of SVG files for the license images

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/161

Title:
  Allow the use of SVG files for the license images

Status in Mahara:
  Confirmed

Bug description:
  Licenses images called in the following file are harcoded in png files and 
may use the$THEME->get_image_url():
  htdocs/lib/db/upgrade.php  line 3051, column 41
  htdocs/lib/db/upgrade.php  line 3061, column 38
  htdocs/lib/db/upgrade.php  line 3071, column 41
  htdocs/lib/db/upgrade.php  line 3081, column 44
  htdocs/lib/db/upgrade.php  line 3091, column 41
  htdocs/lib/db/upgrade.php  line 3101, column 44
  htdocs/lib/license.php line 325, column 42
  htdocs/lib/license.php line 344, column 37
  htdocs/lib/license.php line 351, column 34
  htdocs/lib/license.php line 358, column 37
  htdocs/lib/license.php line 365, column 40
  htdocs/lib/license.php line 372, column 37
  htdocs/lib/license.php line 379, column 40
  htdocs/lib/license.php line 386, column 36

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/161/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1551012] Re: Create graphical Mahara pre-installer

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1551012

Title:
  Create graphical Mahara pre-installer

Status in Mahara:
  Confirmed

Bug description:
  Most polished PHP applications come with a graphical pre-installer,
  which does an environmental sanity check and generates your config
  file for you. This helps welcome in new users and those who are
  investigating the software to decide if they want to use it. Mahara
  does not currently have one of these. Instead, it sniffs for the
  presence of a config.php, and if it doesn't find it, it tells you to
  write one by hand, by copying config-dist.php. And that works well
  enough, but it's not a very welcoming experience.

  The pre-installer should work something like those for other popular
  PHP web applications (such as Moodle & Piwik):

  1. When Mahara detects no config.php present, it sends you to the preinstaller
  2. (Optional) The preinstaller asks you which language you want to proceed in
  3. The preinstaller presents you with a form that asks you to fill in the 
minimum fields for your site. For Mahara these would be:

   - DB connection parameters (not including dbprefix)
   - Dataroot
   - wwwroot (pre-filled based on current URL)

  4. Sanity check these options. Mahara would check to make sure the DB
  connection works and has the right permissions, and it would check
  that the dataroot is writeable and try to detect whether it's
  accessible from a URL. It would also access the wwwroot and make sure
  it is this self-same Moodle site.

  5. Generate the config.php file. Using a template file, or
  find/replace in config-dist.php, Mahara would generate the body of a
  sample config.php file for the site. It should also prefill the
  password salt config option, with an appropriate randomly generated
  salt.

  6. Tell the user where to put the config.php, or write it to the right
  place.

  7. Then hand things over to the installer, and proceed as normal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1551012/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1407511] Re: usr_institution uses institution name as foreign key

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1407511

Title:
  usr_institution uses institution name as foreign key

Status in Mahara:
  Confirmed

Bug description:
  In current Mahara dev at the time of writing (15.04-dev), the
  usr_institution table uses the institution name rather than its ID as
  a foreign key. This will slow things down because it forces string
  comparisons to be done instead of simple numeric value comparisons.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1407511/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1496676] Re: Add OpenSans as default font into TinyMCE

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1496676

Title:
  Add OpenSans as default font into TinyMCE

Status in Mahara:
  Confirmed

Bug description:
  Mahara 15.10+

  It would be good to add OpenSans, the default font from Mahara 15.10
  on, into TinyMCE so it can be chosen if somebody wants to go back to
  the default font.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1496676/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1537861] Re: View layout becomes corrupted when changed

2016-10-20 Thread Robert Lyon
This should now be fixed by https://reviews.mahara.org/#/c/7184/

** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

** Changed in: mahara
   Status: Triaged => Fix Committed

** Changed in: mahara/16.10
   Status: Triaged => Fix Released

** Changed in: mahara/16.04
   Status: Triaged => In Progress

** Changed in: mahara/15.10
   Status: Triaged => In Progress

** Changed in: mahara/15.04
   Status: Triaged => In Progress

** No longer affects: mahara/15.04

** No longer affects: mahara/15.10

** Changed in: mahara
   Status: Fix Committed => Fix Released

** Changed in: mahara
Milestone: 17.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1537861

Title:
  View layout becomes corrupted when changed

Status in Mahara:
  Fix Released
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Version: Mahara 15.04.5 (only encountered on this version, after
  upgrading from 15.04.4)

  We have had 2 users (out of over a thousand) have this problem so far,
  and I've been unable reproduce it or trace a specific cause but we do
  know the order of events and the outcome:

  They copy a page from another user
  Change content or add some new content
  Attempt to change the layout (say from 3 columns to 2 columns)

  Something goes wrong while the layout is being changed and the data in
  the table view_rows_columns no longer matches what's in the view
  table, and the page won't load anymore.

  As more users encounter this problem (and I'm assuming they will) I
  will update this report.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1537861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1564715] Re: Change Mahara's content-sniffing to match the WHATWG standard

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1564715

Title:
  Change Mahara's content-sniffing to match the WHATWG standard

Status in Mahara:
  Confirmed

Bug description:
  WHATWG (Web Hypertext Application Technology Working Group) is
  basically the official specification organization for HTML5. They've
  written up some specifications about the correct & secure way that
  HTTP clients & servers ought to deal with file content types aka MIME
  types: https://mimesniff.spec.whatwg.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1564715/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1423411] Re: Combine the "secret URL" screen and the "Sharing" screen.

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1423411

Title:
  Combine the "secret URL" screen and the "Sharing" screen.

Status in Mahara:
  Confirmed

Bug description:
  Once we've implemented Bug 1423410, which will "individualize" the
  "Sharing" screen, we should combine the Secret URL screen and the
  Sharing screen in some way.

  The easiest thing would probably be to make it a separate tab, because
  secret URLs cannot be created in bulk, while the other permissions can
  be done in bulk.

  But it would be really nice if we could do it all on one screen. Maybe
  gray out the Secret URL section if you select some other pages to bulk
  sync?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1423411/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1543905] Re: Allow admins to customize "social media" options

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1543905

Title:
  Allow admins to customize "social media" options

Status in Mahara:
  Confirmed

Bug description:
  If you go to "Content -> Profile -> Social media", you can provide a
  list of your usernames in various social networks. We've also provided
  an "other" option to let this encompass additional types of social
  networks. But! It's still a hard-coded list. The important networks
  will shift over time, and depending on the circumstances of the
  institution running Mahara.

  When we updated this from the previous system (which listed mostly
  instant messaging systems: ICQ, MSN, etc), we stayed with a hard-coded
  system because it was easier to do. But in the long run we need to
  make this system flexible, to allow admins to customize the options
  listed here.

  This will be challenging because the hard-coded system allows us to
  also generate custom URLs for each system, and provide custom icons
  for them. With a custom system, I suppose we'd want to provide some
  kind of variable-based URL generator, and/or maybe fetch the favicon
  for the domain name?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1543905/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1514415] Re: [MySQL] Index column size too large. The maximum column size is 767 bytes.

2016-10-20 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: New => Triaged

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1514415

Title:
  [MySQL] Index column size too large. The maximum column size is 767
  bytes.

Status in Mahara:
  In Progress
Status in Mahara 16.10 series:
  Triaged

Bug description:
  Hallo,

  I have tried to install Mahara with MySQL.

  I have installed it in the following way:

  1. I cloned the git repository at https://git.mahara.org/mahara/mahara.git
  2. I built mahara with make css to create all neccessary files
  3. I started the installationn with php admin/cli/install.php 
--adminpassword='' --adminemail=

  After a while the following error appeared:

  "(lib/dml.php:150) mysqli error: [1709: Index column size too large.
  The maximum column size is 767 bytes.]"

  I did some research and found a potential solution for that:

  1. Some entries in my.cnf, which I have already added:

  innodb_large_prefix=on
  innodb_file_format=barracuda
  innodb_file_per_table=true

  
  2. To add "ROW_FORMAT=DYNAMIC;" when creating a table. But I have no idea how 
to do this.

  
  More information on this error can be found on:

  
http://mechanics.flite.com/blog/2014/07/29/using-innodb-large-prefix-to-avoid-error-1071/
  https://dev.mysql.com/doc/refman/5.5/en/innodb-restrictions.html
  https://dev.mysql.com/doc/refman/5.5/en/innodb-row-format-dynamic.html

  
  Here is the log-file

  [INF] 72 (admin/cli/install.php:74) Installing Mahara
  [INF] 72 (lib/mahara.php:228) Installing core
  [INF] 72 (lib/upgrade.php:1364) Enabled 2 HTML filters.
  [INF] 72 (lib/mahara.php:228) Installing firstcoredata
  [INF] 72 (lib/mahara.php:228) Installing localpreinst
  [INF] 72 (lib/mahara.php:228) Installing artefact.plans
  [INF] 72 (lib/mahara.php:228) Installing artefact.blog
  [INF] 72 (lib/mahara.php:228) Installing artefact.internal
  [INF] 72 (lib/mahara.php:228) Installing artefact.comment
  [INF] 72 (lib/mahara.php:228) Installing artefact.file
  [INF] 72 (artefact/file/lib.php:269) Updated filetype list: 142 added.
  [INF] 72 (lib/mahara.php:228) Installing artefact.annotation
  [INF] 72 (lib/mahara.php:228) Installing artefact.resume
  [INF] 72 (lib/mahara.php:228) Installing auth.saml
  [INF] 72 (lib/mahara.php:228) Installing auth.internal
  [INF] 72 (lib/mahara.php:228) Installing auth.ldap
  [INF] 72 (lib/mahara.php:228) Installing auth.browserid
  [INF] 72 (lib/mahara.php:228) Installing auth.none
  [INF] 72 (lib/mahara.php:228) Installing auth.imap
  [INF] 72 (lib/mahara.php:228) Installing auth.webservice
  [INF] 72 (lib/mahara.php:228) Installing auth.xmlrpc
  [INF] 72 (lib/mahara.php:228) Installing notification.email
  [INF] 72 (lib/mahara.php:228) Installing notification.emaildigest
  [INF] 72 (lib/mahara.php:228) Installing notification.internal
  [INF] 72 (lib/mahara.php:228) Installing search.elasticsearch
  [INF] 72 (lib/mahara.php:228) Installing search.internal
  [INF] 72 (lib/mahara.php:228) Installing blocktype.file/gallery
  [INF] 72 (lib/mahara.php:228) Installing blocktype.resume/entireresume
  [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/profileinfo
  [INF] 72 (lib/mahara.php:228) Installing blocktype.file/image
  [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/textbox
  [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/socialprofile
  [INF] 72 (lib/mahara.php:228) Installing blocktype.file/pdf
  [INF] 72 (lib/mahara.php:228) Installing blocktype.file/html
  [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/recentposts
  [INF] 72 (lib/mahara.php:228) Installing blocktype.file/filedownload
  [INF] 72 (lib/mahara.php:228) Installing blocktype.comment/comment
  [INF] 72 (lib/mahara.php:228) Installing blocktype.file/folder
  [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/blog
  [INF] 72 (lib/mahara.php:228) Installing blocktype.resume/resumefield
  [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/taggedposts
  [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/blogpost
  [INF] 72 (lib/mahara.php:228) Installing blocktype.myfriends
  [INF] 72 (lib/mahara.php:228) Installing blocktype.externalvideo
  [INF] 72 (lib/mahara.php:228) Installing blocktype.inbox
  [INF] 72 (lib/mahara.php:228) Installing blocktype.recentforumposts
  [INF] 72 (lib/mahara.php:228) Installing blocktype.plans/plans
  [INF] 72 (lib/mahara.php:228) Installing blocktype.groupmembers
  [INF] 72 (lib/mahara.php:228) Installing blocktype.groupinfo
  [INF] 72 (lib/mahara.php:228) Installing blocktype.googleapps
  [INF] 72 (lib/mahara.php:228) Installing blocktype.file/internalmedia
  [INF] 72 (lib/mahara.php:228) Installing blocktype.text
  [INF] 72 (lib/mahara.php:228) Installing 

[Mahara-contributors] [Bug 1407855] Re: Implement a feature for Behat to hold Firefox open after a failed step

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1407855

Title:
  Implement a feature for Behat to hold Firefox open after a failed step

Status in Mahara:
  Confirmed

Bug description:
  Hi AaronB,

  When a step fails in Behat it keeps running though till the end. A
  good idea would be for Behat to hold the Firefox window open at the
  failed step. There is notes about this in a Behat.org meeting notes I
  think you already have the code for this.

  Thanks,
  Jinelle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1407855/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1451324] Re: Change "Image" block to have empty title by default

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1451324

Title:
  Change "Image" block to have empty title by default

Status in Mahara:
  Confirmed

Bug description:
  This is a suggestion that came up at the Mahara Hui 2015 in Auckland.

  Currently when you create a new image block, its instance title
  defaults to "Image".

  This is hardly ever the final image title that you want the block to
  have. Most of the time, in fact, to make a good-looking Portfolio
  page, you don't want the image to have a title at all.

  So I think it would be best to change the Image block to have an empty
  title by default. It may also be true that other blocktypes (like
  Text) may also benefit from having a default empty title.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1451324/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1441422] Re: Realtime collaborative page editing

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1441422

Title:
  Realtime collaborative page editing

Status in Mahara:
  Confirmed

Bug description:
  People would like to be able to collaboratively edit Mahara pages in
  realtime. I was discussing this with Robert and it actually might not
  be that hard to do, at least for group pages (which are already
  collaboratively editable). You'd just have to take things at a block-
  by-block basis.

  1. When you're editing a group page, we use Ajax to periodically poll
  the server to determine if someone else is also editing the page.

  2. If someone else is editing the page, we show them listed at the top
  of the page as a collaborative editor. (Maybe some kind of chat system
  to go along side this?) You also poll more frequently.

  3. When there are updates to the page, made by someone else, we load
  them onto the page immediately.

  4. If someone else is editing a block, we "lock" that block. (In the
  long run we could have a flag for some types of blocks to be multi-
  user collaborative.)

  The tricky part here is that you need to be able to track and update (or 
lock) all the ways that a page can be updated:
   - reloading block contents
   - adding blocks
   - deleting blocks
   - moving blocks

  And also page metadata...
   - changing page layout
   - changing page title/description/collection/sharing/tags...

  It would probably be easiest to lock the page metadata while someone
  is editing the page. Also, what if someone opens a block for editing,
  and then they close their window, or their browser crashes? We need
  the block to automatically unlock. Perhaps a "keepalive" ping once per
  minute.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1441422/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1432464] Re: Require captcha for probationary users to take spammy actions

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1432464

Title:
  Require captcha for probationary users to take spammy actions

Status in Mahara:
  Confirmed

Bug description:
  The proposal here is that if you're a user who is on probationary
  status, we make you do a recaptcha before making a forum post, user-
  to-user message, and possibly also other actions that cause emails to
  go out.

  This wouldn't stop the flow of spam completely, probably, but it would
  prevent bots from flooding us with spam.

  The downside is that it would be quite inconvenient for new users.
  Possibly we could mitigate that by combining it with a spam detection
  heuristic.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1432464/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1440915] Re: Stop auto-marking notifications to "read"

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1440915

Title:
  Stop auto-marking notifications to "read"

Status in Mahara:
  Confirmed

Bug description:
  Currently, Mahara marks a new inbox notification as "read" if the
  notification was emailed to the user.

  The idea behind this, was to avoid user annoyance when they've already
  read a notification in their email, and now have to look at it again
  in Mahara.

  However, as more social network services have come on to the Internet,
  they have settled on the opposite norm. When a social network emails
  you about a notification, it also tends to still mark that
  notification "unread" within the social network itself. So, Mahara
  should behave the same way in order to avoid confusing users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1440915/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1451329] Re: Refactor block title methods to allow empty titles and make everything less confusing

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1451329

Title:
  Refactor block title methods to allow empty titles and make everything
  less confusing

Status in Mahara:
  Confirmed

Bug description:
  I initially thought Bug 1451324 would be a bite-sized bug, but after
  looking into it I realized that our system for determining default &
  instance block titles is a mess, and it doesn't allow for a blank
  default block title.

  There are currently five methods involved in determining block titles.
  I'll use "PluginBlocktype{Name}" to refer to a subclass of
  PluginBlocktype (like PluginBlocktypeImage)

  1. PluginBlocktype->get_title(): This method is called to find out the
  block title to display when the block is in "view" mode, and it
  determines the title of the config popup when the block is in editing
  mode. It's sorta meant to be a "final" method, because it contains
  logic that checks other parts of the public block API. First, it
  checks PluginBlocktype{Name}::override_instance_title(). If that's
  false, it checks $this->get('title') (which is block_instance.title
  from the DB), and if that's false then it checks
  PluginBlocktype{Name}::get_instance_title().

  2. PluginBlocktype{Name}::get_title(): This method confusingly has the
  same name as number 1, but is static instead of instance. It's also
  mandatory for every blocktype to implement this. The value returned
  does double-duty. It is the name that is displayed for this blocktype
  in the block picker, and it is also the default name of new block
  instances (unless the blocktype implements override_instance_title()
  or get_instance_title()

  3. PluginBlocktype{Name}::override_instance_title($instance): This
  method is meant to be used for blocks where the title is hard-coded,
  like "My Friends" and "My Groups". If it is present, and it returns
  non-empty, the return value of this is stored in block_instance.title,
  and displayed as the title in view and edit mode, and the "block"
  field is hidden from the block config form.

  4. PluginBlocktype{Name}::get_instance_title($instance): This method
  is meant to be used for blocks where the title defaults to the title
  of the artefact chosen for display in the block. For instance, the
  Blog block displays the title of the selected blog. If this method is
  implemented, the title for new block instances defaults to empty, and
  the block config shows a message that says "If the block title is
  empty it'll default to XXX" (which must be stored in the blocktype's
  "defaulttitledescription" string). And then, when you display the
  block, we check to see whether block_instance.title is empty, and if
  it is, we call this method and use its return value as the title.

  5. View->addblocktype($values): This is the method that contains the
  logic that determines what a new block's default title will be. First
  it checks to see whether the blocktype implements
  get_instance_title(). If it does, it sets the title to an empty
  string. Otherwise, it sets the title to the return value of the
  blocktype's static get_title() method (function number 2 above)

  So you can see, the problem here is that:

  1. The method names are confusing and don't explain what they do and
  how they're different from each other (and there are not sufficient
  comments in the code to explain this either.)

  2. We force the default block title for new block instances to be the
  same as the string used in the block picker.

  3. The only way to make a block title empty by default, would be to
  implement get_instance_title(), and set the blocktype's
  "defaulttitledescription" to an empty string. Which would be pretty
  hacky.

  I'll have to give some thought to the best way to refactor this. It
  might also be worthwhile doing a quick review of 3rd-party blocks to
  see how badly they'd be impacted if we made some big changes to this.
  One possibility that springs to mind, is to move the logic for
  determining the default title, out of View->addblocktype() and into
  the PluginBlocktype class, where it could maybe be overridden by child
  classes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1451329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1417816] Re: Export queue to deal with big vs small exports differently

2016-10-20 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1417816

Title:
  Export queue to deal with big vs small exports differently

Status in Mahara:
  Confirmed

Bug description:
  We should only export big archiving when server is not busy but we
  should be able to do small exports at any time.

  So we need to work out before an export begins approximately how big
  it is going to be and record that in the export_queue table.

  Currently in htdocs/export/lib.php (line 625) there is the following:

  
 // Get an estimate of how big the unzipped export file would be
  // so we can check that we have enough disk space for it
  $space = $exporter->is_diskspace_available();

  So we can take the value of $space and make a decision on it and bail
  out if $space is big and server is busy. Something like:

  if ($space > TOO_BIG && server_busy()) {
  log_info('too busy');
  return true;
  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1417816/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


  1   2   3   4   5   6   7   >