[matplotlib-devel] github devel question

2011-02-25 Thread Benjamin Root
Ok, I am still learning quite a bit about git, please bear with me. I am having difficulty completing a pull request that I opened. When I try to merge the changes to upstream, they get rejected. I can merge it back to my own master, and can even push it up to my github repo's master, but not ma

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Darren Dale
On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root wrote: > Ok, I am still learning quite a bit about git, please bear with me. > > I am having difficulty completing a pull request that I opened. In general, I don't think we should close our own pull requests. It short-circuits the review process. >

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Ryan May
On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale wrote: > On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root wrote: >> Ok, I am still learning quite a bit about git, please bear with me. >> >> I am having difficulty completing a pull request that I opened. > > In general, I don't think we should close ou

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Darren Dale
On Fri, Feb 25, 2011 at 2:43 PM, Ryan May wrote: > On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale wrote: >> On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root wrote: >>> Ok, I am still learning quite a bit about git, please bear with me. >>> >>> I am having difficulty completing a pull request that I

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Ryan May
On Fri, Feb 25, 2011 at 1:48 PM, Darren Dale wrote: > On Fri, Feb 25, 2011 at 2:43 PM, Ryan May wrote: >> On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale wrote: >>> On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root wrote: Ok, I am still learning quite a bit about git, please bear with me. >

Re: [matplotlib-devel] github devel question

2011-02-25 Thread John Hunter
On Fri, Feb 25, 2011 at 1:43 PM, Ryan May wrote: > On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale wrote: >> On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root wrote: >>> Ok, I am still learning quite a bit about git, please bear with me. >>> >>> I am having difficulty completing a pull request that I

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Fernando Perez
On Fri, Feb 25, 2011 at 11:48 AM, Darren Dale wrote: > On Fri, Feb 25, 2011 at 2:43 PM, Ryan May wrote: >> Agreed in principle. However, do we as devs want to get/give reviews >> on every change that fixes typos in the docs or fixes stupid bugs in >> examples? I think there's a point of diminish

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Matthew Brett
Yo, On Fri, Feb 25, 2011 at 12:02 PM, Fernando Perez wrote: > On Fri, Feb 25, 2011 at 11:48 AM, Darren Dale wrote: >> On Fri, Feb 25, 2011 at 2:43 PM, Ryan May wrote: > >>> Agreed in principle. However, do we as devs want to get/give reviews >>> on every change that fixes typos in the docs or f

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Fernando Perez
On Fri, Feb 25, 2011 at 12:01 PM, John Hunter wrote: > I just want to throw out there that in the migration to github, we > never officially said we were going to switch the development process. >  In fact, we said the opposite. After the migration,  Jarrod suggested > the pull request workflow as

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Benjamin Root
On Fri, Feb 25, 2011 at 2:01 PM, John Hunter wrote: > On Fri, Feb 25, 2011 at 1:43 PM, Ryan May wrote: > > On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale wrote: > >> On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root wrote: > >>> Ok, I am still learning quite a bit about git, please bear with me. >

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Eric Firing
On 02/25/2011 10:01 AM, John Hunter wrote: > On Fri, Feb 25, 2011 at 1:43 PM, Ryan May wrote: >> On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale wrote: >>> On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root wrote: Ok, I am still learning quite a bit about git, please bear with me. I am h

Re: [matplotlib-devel] github devel question

2011-02-25 Thread Darren Dale
On Fri, Feb 25, 2011 at 3:16 PM, Eric Firing wrote: > On 02/25/2011 10:01 AM, John Hunter wrote: >> On Fri, Feb 25, 2011 at 1:43 PM, Ryan May  wrote: >>> On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale  wrote: On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root  wrote: > Ok, I am still learning q

[matplotlib-devel] make.osx pull request

2011-02-25 Thread Darren Dale
Here is a pull request proposing some changes to make.osx: https://github.com/matplotlib/matplotlib/pull/17 . I have never used make.osx myself. Could someone familiar with its use please have a look and decide whether the changes should be accepted? Thanks, Darren ---

Re: [matplotlib-devel] Patch for Bug ID: 3176823 plot_date does not respect timezone

2011-02-25 Thread Darren Dale
On Wed, Feb 16, 2011 at 1:21 PM, Maximilian Trescher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi there, > > I just created my first patch for matplotlib, it's addressing bug 3176823. > > I send the patch with an example (as suggested in the faq). A pull request has been filed

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Paul Ivanov
Fernando Garcia Bermudez, on 2011-02-03 09:14, wrote: > On Thu, Feb 3, 2011 at 06:05, Michael Droettboom wrote: > > On 02/03/2011 07:48 AM, Darren Dale wrote: > >> On Thu, Feb 3, 2011 at 12:12 AM, Fernando Garcia Bermudez > >>  wrote: > >> > >>> Before continuing the debug process, though, I wan

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Benjamin Root
On Fri, Feb 25, 2011 at 5:11 PM, Paul Ivanov wrote: > Fernando Garcia Bermudez, on 2011-02-03 09:14, wrote: > > On Thu, Feb 3, 2011 at 06:05, Michael Droettboom > wrote: > > > On 02/03/2011 07:48 AM, Darren Dale wrote: > > >> On Thu, Feb 3, 2011 at 12:12 AM, Fernando Garcia Bermudez > > >> wr

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Paul Ivanov
Benjamin Root, on 2011-02-25 18:03, wrote: > On Fri, Feb 25, 2011 at 5:11 PM, Paul Ivanov wrote: > > By the way, there was a recent poll on python.org for packages > > where users desire Python 3 support. > > > > Here are the top 10: > > > > Votes | Package > > --+ > > 837 | Django

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Christoph Gohlke
On 2/25/2011 4:03 PM, Benjamin Root wrote: > > > On Fri, Feb 25, 2011 at 5:11 PM, Paul Ivanov > wrote: > > Fernando Garcia Bermudez, on 2011-02-03 09:14, wrote: > > On Thu, Feb 3, 2011 at 06:05, Michael Droettboom > wrote: >

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread John Hunter
On Feb 25, 2011, at 7:00 PM, Christoph Gohlke wrote: > Are PIL and PyGTK holding back matplotlib for Python 3 Not at all. Both are optional dependencies. Mpl's hard external dependencies are python, zlib, libpng, freetype and numpy. With those you get the agg, pdf, ps and svg backends.

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Darren Dale
On Fri, Feb 25, 2011 at 9:01 PM, John Hunter wrote: > On Feb 25, 2011, at 7:00 PM, Christoph Gohlke wrote: > >> Are PIL and PyGTK holding back matplotlib for Python 3 > > Not at all. Both are optional dependencies. Mpl's hard external dependencies > are python, zlib, libpng, freetype and numpy.

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Benjamin Root
On Fri, Feb 25, 2011 at 8:01 PM, John Hunter wrote: > > > > > On Feb 25, 2011, at 7:00 PM, Christoph Gohlke wrote: > > > Are PIL and PyGTK holding back matplotlib for Python 3 > > Not at all. Both are optional dependencies. Mpl's hard external > dependencies are python, zlib, libpng, freetype an

Re: [matplotlib-devel] make.osx pull request

2011-02-25 Thread Jim Benson
On Fri, 25 Feb 2011, Darren Dale wrote: > Here is a pull request proposing some changes to make.osx: > https://github.com/matplotlib/matplotlib/pull/17 . I have never used > make.osx myself. Could someone familiar with its use please have a > look and decide whether the changes should be accepted?

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Darren Dale
On Fri, Feb 25, 2011 at 10:36 PM, Christoph Gohlke wrote: > How up to date is matplotlib-py3 with respect to the master branch? It is currently 5 commits behind matplotlib/master. -- Free Software Download: Index, Search

Re: [matplotlib-devel] What's the status of the py3k branch?

2011-02-25 Thread Eric Firing
On 02/25/2011 04:54 PM, Benjamin Root wrote: > > > On Fri, Feb 25, 2011 at 8:01 PM, John Hunter > wrote: > > > > > > On Feb 25, 2011, at 7:00 PM, Christoph Gohlke > wrote: > > > Are PIL and PyGTK holding back matplotlib for Python 3 >