[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Mock CommentStore in RevisionTest

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406142 ) Change subject: Mock CommentStore in RevisionTest .. Mock CommentStore in RevisionTest Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use array_merge in RevisionStore::getArchiveQueryInfo

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406141 ) Change subject: Use array_merge in RevisionStore::getArchiveQueryInfo .. Use array_merge in RevisionStore::getArchiveQueryInfo [ 'foo' ]

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Introduce and use CommentStoreFactory

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406131 ) Change subject: Introduce and use CommentStoreFactory .. Introduce and use CommentStoreFactory Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add 'RevisionStore' to wmgMonologChannels

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406128 ) Change subject: Add 'RevisionStore' to wmgMonologChannels .. Add 'RevisionStore' to wmgMonologChannels Logging for this channel is

[MediaWiki-commits] [Gerrit] mediawiki/vendor[wmf/1.31.0-wmf.17]: Add missing files from wikibase/data-model-services 3.9.0

2018-01-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404758 ) Change subject: Add missing files from wikibase/data-model-services 3.9.0 .. Add missing files from wikibase/data-model-services 3.9.0

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.17]: [MCR] RevisionStore::getTitle final logged fallback to master

2018-01-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404757 ) Change subject: [MCR] RevisionStore::getTitle final logged fallback to master .. [MCR] RevisionStore::getTitle final logged fallback to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP DNM Refactor the Revision Refactor

2018-01-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404058 ) Change subject: WIP DNM Refactor the Revision Refactor .. WIP DNM Refactor the Revision Refactor Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: WIPDNM phan 0.9

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404141 ) Change subject: WIPDNM phan 0.9 .. WIPDNM phan 0.9 Change-Id: I2eaad72b483b8224c4c327e99febed07f9548352 --- A

[MediaWiki-commits] [Gerrit] integration/config[master]: docker: update phan image to phan 0.8.10

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404142 ) Change subject: docker: update phan image to phan 0.8.10 .. docker: update phan image to phan 0.8.10 Bug: T174339 Change-Id:

[MediaWiki-commits] [Gerrit] operations...docker-pkg[master]: Add basic Dockerfile to run docker-pkg

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404084 ) Change subject: Add basic Dockerfile to run docker-pkg .. Add basic Dockerfile to run docker-pkg Make this easy to run by including a

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP core browser tests on beta after update

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404082 ) Change subject: WIP core browser tests on beta after update .. WIP core browser tests on beta after update Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: selenium, user spec, add new message banner test

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404080 ) Change subject: selenium, user spec, add new message banner test .. selenium, user spec, add new message banner test Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: selenium, page spec, add re-creatable

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404079 ) Change subject: selenium, page spec, add re-creatable .. selenium, page spec, add re-creatable Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: selenium, page spec, add restoration

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404078 ) Change subject: selenium, page spec, add restoration .. selenium, page spec, add restoration Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: selenium, update page spec to include more chars

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404075 ) Change subject: selenium, update page spec to include more chars .. selenium, update page spec to include more chars Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Selenium README note about --url-base on Windows

2018-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404074 ) Change subject: Selenium README note about --url-base on Windows .. Selenium README note about --url-base on Windows For me /wd/hub

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.16]: RevisionStore, fix loadSlotContent with no $blobFlags

2018-01-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403930 ) Change subject: RevisionStore, fix loadSlotContent with no $blobFlags .. RevisionStore, fix loadSlotContent with no $blobFlags This

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionStore, fix loadSlotContent with no $blobFlags

2018-01-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403909 ) Change subject: RevisionStore, fix loadSlotContent with no $blobFlags .. RevisionStore, fix loadSlotContent with no $blobFlags Tested in

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Extra tests for SqlBlobStore with 'windows-1252' legacy enco...

2018-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403754 ) Change subject: Extra tests for SqlBlobStore with 'windows-1252' legacy encoding .. Extra tests for SqlBlobStore with 'windows-1252'

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RevisionStore tests for current behaviour of getTitle

2018-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403705 ) Change subject: RevisionStore tests for current behaviour of getTitle .. RevisionStore tests for current behaviour of getTitle Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.16]: Make Revision::__construct work with bad page ID

2018-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403693 ) Change subject: Make Revision::__construct work with bad page ID .. Make Revision::__construct work with bad page ID For

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.31.0-wmf.16]: Fix IncompleteRevisionException comment must not be NULL!

2018-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403668 ) Change subject: Fix IncompleteRevisionException comment must not be NULL! .. Fix IncompleteRevisionException comment must not be NULL!

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.16]: Handle failure to load content in Revision getSize, etc

2018-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403661 ) Change subject: Handle failure to load content in Revision getSize, etc .. Handle failure to load content in Revision getSize, etc The

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.16]: Revision::newNullRevision don't pass null to RevisionStore

2018-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403660 ) Change subject: Revision::newNullRevision don't pass null to RevisionStore .. Revision::newNullRevision don't pass null to RevisionStore

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revision::newNullRevision don't pass null to RevisionStore

2018-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403607 ) Change subject: Revision::newNullRevision don't pass null to RevisionStore .. Revision::newNullRevision don't pass null to RevisionStore

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.16]: [MCR] RevisionStore::getTitle final logged fallback to master

2018-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403446 ) Change subject: [MCR] RevisionStore::getTitle final logged fallback to master .. [MCR] RevisionStore::getTitle final logged fallback to

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.16]: [MCR] RevisionStore::getTitle, Fix flags passed to Title::ne...

2018-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403445 ) Change subject: [MCR] RevisionStore::getTitle, Fix flags passed to Title::newFromID .. [MCR] RevisionStore::getTitle, Fix flags passed to

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.16]: Revert "Revert "[MCR] Add and use $title param to RevisionSt...

2018-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403444 ) Change subject: Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next"" .. Revert "Revert "[MCR] Add and use

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[wmf/1.31.0-wmf.16]: FlaggedRevision, construct Revision with Title if known

2018-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403443 ) Change subject: FlaggedRevision, construct Revision with Title if known .. FlaggedRevision, construct Revision with Title if known If we

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: FlaggedRevision, construct Revision with Title if known

2018-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403426 ) Change subject: FlaggedRevision, construct Revision with Title if known .. FlaggedRevision, construct Revision with Title if known If we

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] RevisionStore::getTitle, Fix flags passed to Title::ne...

2018-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403423 ) Change subject: [MCR] RevisionStore::getTitle, Fix flags passed to Title::newFromID .. [MCR] RevisionStore::getTitle, Fix flags passed to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Revert "[MCR] Add and use $title param to RevisionSt...

2018-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403391 ) Change subject: Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next"" .. Revert "Revert "[MCR] Add and use

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use RevisionLookup where possible in Revision

2018-01-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403117 ) Change subject: Use RevisionLookup where possible in Revision .. Use RevisionLookup where possible in Revision Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Update AdvancedSearchRequest Logging Schema version

2018-01-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403113 ) Change subject: Update AdvancedSearchRequest Logging Schema version .. Update AdvancedSearchRequest Logging Schema version This is a

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix BlobStoreFactoryTest @covers tag

2018-01-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402812 ) Change subject: Fix BlobStoreFactoryTest @covers tag .. Fix BlobStoreFactoryTest @covers tag Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Assert order of MediaWikiTestCaseSchema*Test execution

2018-01-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402369 ) Change subject: Assert order of MediaWikiTestCaseSchema*Test execution .. Assert order of MediaWikiTestCaseSchema*Test execution Make

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Set a default delimiter in Database::sourceStream

2018-01-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402367 ) Change subject: Set a default delimiter in Database::sourceStream .. Set a default delimiter in Database::sourceStream Discovered while

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP DNM MCR RevisionStore::checkDatabaseWikiId use DatabaseD...

2018-01-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401736 ) Change subject: WIP DNM MCR RevisionStore::checkDatabaseWikiId use DatabaseDomain .. WIP DNM MCR RevisionStore::checkDatabaseWikiId use

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DNM WIP MCR switch from wikiId to DatabaseDomain

2018-01-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401746 ) Change subject: DNM WIP MCR switch from wikiId to DatabaseDomain .. DNM WIP MCR switch from wikiId to DatabaseDomain Exploration...

[MediaWiki-commits] [Gerrit] analytics...scripts[production]: Fix twitter count grep

2018-01-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401544 ) Change subject: Fix twitter count grep .. Fix twitter count grep Bug: T165463 Change-Id: I16199d6841c0423d48fa0832cf1a613130dc3b68

[MediaWiki-commits] [Gerrit] analytics...scripts[production]: Fix IRC count of wikidata

2018-01-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401543 ) Change subject: Fix IRC count of wikidata .. Fix IRC count of wikidata Bug: T165463 Change-Id: I1dad0b51f5af378d8f1989cd11d60f2893d101a7

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Pass $title to RevisionStore in Revision::newFromArchiveRow

2018-01-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401540 ) Change subject: Pass $title to RevisionStore in Revision::newFromArchiveRow .. Pass $title to RevisionStore in Revision::newFromArchiveRow

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "[MCR] Add and use $title param to RevisionStore getP...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400604 ) Change subject: Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next" .. Revert "[MCR] Add and use $title param to

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: Revert "Pass a Title to Revision::newFromId in onRevisionIns...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400603 ) Change subject: Revert "Pass a Title to Revision::newFromId in onRevisionInsertComplete" .. Revert "Pass a Title to Revision::newFromId

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "[MCR] Add optional $title param to Revision byId met...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400602 ) Change subject: Revert "[MCR] Add optional $title param to Revision byId methods" .. Revert "[MCR] Add optional $title param to Revision

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove duplicate getTitle call in RevisionStore::getNextRevi...

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400578 ) Change subject: Remove duplicate getTitle call in RevisionStore::getNextRevision .. Remove duplicate getTitle call in

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] pass $queryFlags into RevisionStore::getTitle

2017-12-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400577 ) Change subject: [MCR] pass $queryFlags into RevisionStore::getTitle .. [MCR] pass $queryFlags into RevisionStore::getTitle Bug: T183716

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove duplicate ServiceWiring definitions

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/37 ) Change subject: Remove duplicate ServiceWiring definitions .. Remove duplicate ServiceWiring definitions Change-Id:

[MediaWiki-commits] [Gerrit] wikibase/wikiba.se[master]: Add a services page including the query service

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/33 ) Change subject: Add a services page including the query service .. Add a services page including the query service This is pretty empty

[MediaWiki-commits] [Gerrit] wikibase/wikiba.se[master]: Split contact and FAQ into seperate pages

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/32 ) Change subject: Split contact and FAQ into seperate pages .. Split contact and FAQ into seperate pages Increases findability by having

[MediaWiki-commits] [Gerrit] wikibase/wikiba.se[master]: Include Wikibase Extensions & split components

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/31 ) Change subject: Include Wikibase Extensions & split components .. Include Wikibase Extensions & split components This creates a new page

[MediaWiki-commits] [Gerrit] wikibase/wikiba.se[master]: Add .editorconfig

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/30 ) Change subject: Add .editorconfig .. Add .editorconfig Change-Id: Iba435c745e879f631e86981277b80844a8c747bd --- A .editorconfig 1 file

[MediaWiki-commits] [Gerrit] wikibase/wikiba.se[master]: Actually link to Mailing_Lists section

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399987 ) Change subject: Actually link to Mailing_Lists section .. Actually link to Mailing_Lists section Change-Id:

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: Gerrit: report wikibase/.* to #wikidata-feed

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399986 ) Change subject: Gerrit: report wikibase/.* to #wikidata-feed .. Gerrit: report wikibase/.* to #wikidata-feed Change-Id:

[MediaWiki-commits] [Gerrit] wikibase/wikiba.se[master]: README note about how to run sculpin in docker

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399984 ) Change subject: README note about how to run sculpin in docker .. README note about how to run sculpin in docker I use this as I

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Re Enable AdvancedSearch on deployment.wikimedia.beta

2017-12-23 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399981 ) Change subject: Re Enable AdvancedSearch on deployment.wikimedia.beta .. Re Enable AdvancedSearch on deployment.wikimedia.beta Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] Don't require $title to be passed to Revision::newFromId

2017-12-22 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399856 ) Change subject: [MCR] Don't require $title to be passed to Revision::newFromId .. [MCR] Don't require $title to be passed to

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] Revision::newFromArchiveRow convert overrides for rows

2017-12-22 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399838 ) Change subject: [MCR] Revision::newFromArchiveRow convert overrides for rows .. [MCR] Revision::newFromArchiveRow convert overrides for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] Add and use $title param to RevisionStore getPrevious/...

2017-12-22 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399812 ) Change subject: [MCR] Add and use $title param to RevisionStore getPrevious/Next .. [MCR] Add and use $title param to RevisionStore

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] Add optional $title param to Revision byId methods

2017-12-22 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399795 ) Change subject: [MCR] Add optional $title param to Revision byId methods .. [MCR] Add optional $title param to Revision byId methods Bug:

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: Use Revision::newFromId with READ_LATEST for onRevisionInser...

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399764 ) Change subject: Use Revision::newFromId with READ_LATEST for onRevisionInsertComplete .. Use Revision::newFromId with READ_LATEST for

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] Fix RevisionInsertComplete Revision pass by reference

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399703 ) Change subject: [MCR] Fix RevisionInsertComplete Revision pass by reference .. [MCR] Fix RevisionInsertComplete Revision pass by reference

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: BETA: unset $wgSentryDsn

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399680 ) Change subject: BETA: unset $wgSentryDsn .. BETA: unset $wgSentryDsn Bug: T106920 Bug: T183494 Bug: T180208 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add @covers tag for PageArchive::undeleteRevisions

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399637 ) Change subject: Add @covers tag for PageArchive::undeleteRevisions .. Add @covers tag for PageArchive::undeleteRevisions Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add test for PageArchive::listRevisions

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399636 ) Change subject: Add test for PageArchive::listRevisions .. Add test for PageArchive::listRevisions Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Stop MediaWikiTestCase defition appearing for IDEs

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399635 ) Change subject: Stop MediaWikiTestCase defition appearing for IDEs .. Stop MediaWikiTestCase defition appearing for IDEs This has been

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[wmf/1.31.0-wmf.12]: Also track filetype option

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399628 ) Change subject: Also track filetype option .. Also track filetype option Bug: T173572 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.12]: Add onBeforeInitializeWMDECampaign

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399627 ) Change subject: Add onBeforeInitializeWMDECampaign .. Add onBeforeInitializeWMDECampaign This reverts commit

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Add onBeforeInitializeWMDECampaign

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399626 ) Change subject: Add onBeforeInitializeWMDECampaign .. Add onBeforeInitializeWMDECampaign This reverts commit

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Also track filetype option

2017-12-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399602 ) Change subject: Also track filetype option .. Also track filetype option Bug: T173572 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove empty RevisionRecordTest

2017-12-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399235 ) Change subject: Remove empty RevisionRecordTest .. Remove empty RevisionRecordTest Bug: T183219 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [MCR] Fix SqlBlobStore using DB_REPLICA for writes

2017-12-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399188 ) Change subject: [MCR] Fix SqlBlobStore using DB_REPLICA for writes .. [MCR] Fix SqlBlobStore using DB_REPLICA for writes Bug: T183242

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use RevisionStore::getArchiveQueryInfo in PageArchive

2017-12-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398385 ) Change subject: Use RevisionStore::getArchiveQueryInfo in PageArchive .. Use RevisionStore::getArchiveQueryInfo in PageArchive Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[wmf/1.31.0-wmf.12]: Eventlogging for conflicts

2017-12-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398042 ) Change subject: Eventlogging for conflicts .. Eventlogging for conflicts Bug: T181704 Bug: T182008 Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: parameter_functions load EventLogging with TwoColConflict

2017-12-12 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397840 ) Change subject: parameter_functions load EventLogging with TwoColConflict .. parameter_functions load EventLogging with TwoColConflict

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: WIP DNM better logging for dispatch stuff

2017-12-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397538 ) Change subject: WIP DNM better logging for dispatch stuff .. WIP DNM better logging for dispatch stuff Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: dispatchChanges allow configuration instead of params

2017-12-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397535 ) Change subject: dispatchChanges allow configuration instead of params .. dispatchChanges allow configuration instead of params This means

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Count failed lock grabs in SqlChangeDispatchCoordinator

2017-12-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397537 ) Change subject: Count failed lock grabs in SqlChangeDispatchCoordinator .. Count failed lock grabs in SqlChangeDispatchCoordinator

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: dispatchChanges add dispatchNullRuns config option

2017-12-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397536 ) Change subject: dispatchChanges add dispatchNullRuns config option .. dispatchChanges add dispatchNullRuns config option This config

[MediaWiki-commits] [Gerrit] mediawiki...Transliterator[master]: NewRevisionFromEditComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396406 ) Change subject: NewRevisionFromEditComplete WikiPage typehint .. NewRevisionFromEditComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SocialProfile[master]: NewRevisionFromEditComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396405 ) Change subject: NewRevisionFromEditComplete WikiPage typehint .. NewRevisionFromEditComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: NewRevisionFromEditComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396404 ) Change subject: NewRevisionFromEditComplete WikiPage typehint .. NewRevisionFromEditComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...PubSubHubbub[master]: NewRevisionFromEditComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396403 ) Change subject: NewRevisionFromEditComplete WikiPage typehint .. NewRevisionFromEditComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: NewRevisionFromEditComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396402 ) Change subject: NewRevisionFromEditComplete WikiPage typehint .. NewRevisionFromEditComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[master]: NewRevisionFromEditComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396400 ) Change subject: NewRevisionFromEditComplete WikiPage typehint .. NewRevisionFromEditComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ApprovedRevs[master]: ArticleEditUpdates WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396399 ) Change subject: ArticleEditUpdates WikiPage typehint .. ArticleEditUpdates WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...InterwikiIntegration[master]: ArticleEditUpdates WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396396 ) Change subject: ArticleEditUpdates WikiPage typehint .. ArticleEditUpdates WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RestBaseUpdateJobs[master]: ArticleEditUpdates WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396397 ) Change subject: ArticleEditUpdates WikiPage typehint .. ArticleEditUpdates WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: ArticleEditUpdates WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396395 ) Change subject: ArticleEditUpdates WikiPage typehint .. ArticleEditUpdates WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: ArticlePrepareTextForEdit WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396393 ) Change subject: ArticlePrepareTextForEdit WikiPage typehint .. ArticlePrepareTextForEdit WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: ArticleProtect WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396391 ) Change subject: ArticleProtect WikiPage typehint .. ArticleProtect WikiPage typehint Change-Id: I5c19164ce940a7cb3c16bc9955f683ed67721867

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: ArticleRollbackComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396390 ) Change subject: ArticleRollbackComplete WikiPage typehint .. ArticleRollbackComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: ArticleRollbackComplete WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396388 ) Change subject: ArticleRollbackComplete WikiPage typehint .. ArticleRollbackComplete WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: ArticleEditUpdateNewTalk WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396385 ) Change subject: ArticleEditUpdateNewTalk WikiPage typehint .. ArticleEditUpdateNewTalk WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...InterwikiIntegration[master]: ArticleEditUpdatesDeleteFromRecentchanges WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396384 ) Change subject: ArticleEditUpdatesDeleteFromRecentchanges WikiPage typehint .. ArticleEditUpdatesDeleteFromRecentchanges WikiPage typehint

[MediaWiki-commits] [Gerrit] mediawiki...PhpTagsStorage[master]: WikiPageDeletionUpdates WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396383 ) Change subject: WikiPageDeletionUpdates WikiPage typehint .. WikiPageDeletionUpdates WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: PageContentSave WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396377 ) Change subject: PageContentSave WikiPage typehint .. PageContentSave WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikiCategoryTagCloud[master]: PageContentSave WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396379 ) Change subject: PageContentSave WikiPage typehint .. PageContentSave WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TweetANew[master]: PageContentSave WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396378 ) Change subject: PageContentSave WikiPage typehint .. PageContentSave WikiPage typehint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TitleBlacklist[master]: PageContentSave WikiPage typehint

2017-12-08 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396376 ) Change subject: PageContentSave WikiPage typehint .. PageContentSave WikiPage typehint Change-Id:

  1   2   3   4   5   6   7   8   9   10   >