[MediaWiki-commits] [Gerrit] Changed UI text source to reference - change (mediawiki...Wikibase)

2014-04-17 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/127005 Change subject: Changed UI text source to reference .. Changed UI text source to reference Change-Id:

[MediaWiki-commits] [Gerrit] Set up configuration for App indexing - change (operations/mediawiki-config)

2014-03-11 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/118220 Change subject: Set up configuration for App indexing .. Set up configuration for App indexing (BUG 60537) Set up app indexing

[MediaWiki-commits] [Gerrit] (bug 60537) Adds a deep link to a mobile app if so configured - change (mediawiki...MobileFrontend)

2014-02-12 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/112921 Change subject: (bug 60537) Adds a deep link to a mobile app if so configured .. (bug 60537) Adds a deep link to a mobile app if so

[MediaWiki-commits] [Gerrit] Added script to upload Freebase identifiers - change (pywikibot/core)

2013-12-04 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/99180 Change subject: Added script to upload Freebase identifiers .. Added script to upload Freebase identifiers Change-Id:

[MediaWiki-commits] [Gerrit] allow URLs for sources\n\nChange-Id: I5f65e8ce51fe7f34b66bc8... - change (pywikibot/core)

2013-11-27 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/98018 Change subject: allow URLs for sources\n\nChange-Id: I5f65e8ce51fe7f34b66bc8dfaa920209c087055a .. allow URLs for

[MediaWiki-commits] [Gerrit] Removed failing test for illegal time value - change (mediawiki...Wikibase)

2013-07-25 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/76022 Change subject: Removed failing test for illegal time value .. Removed failing test for illegal time value Change-Id:

[MediaWiki-commits] [Gerrit] move term setting to lib - change (mediawiki...Wikibase)

2013-07-18 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/74356 Change subject: move term setting to lib .. move term setting to lib Change-Id: I31f605ac242d02fb692b89e0c29d6d0a1358fcf4 --- M

[MediaWiki-commits] [Gerrit] Change DOUBLE to FLOAT for wb_term.term_weight - change (mediawiki...Wikibase)

2013-07-18 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/74426 Change subject: Change DOUBLE to FLOAT for wb_term.term_weight .. Change DOUBLE to FLOAT for wb_term.term_weight Needs less space,

[MediaWiki-commits] [Gerrit] Improve errors in wblinktitles - change (mediawiki...Wikibase)

2013-07-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Improve errors in wblinktitles .. Improve errors in wblinktitles Change-Id: Ib9ea338f5c24e0055d595c690760f0580ce13dc8 --- M

[MediaWiki-commits] [Gerrit] Work on store interface - change (mediawiki...WikibaseQueryEngine)

2013-07-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Work on store interface .. Work on store interface * Removed stubs that will not be implemented any time soon * Simplified test cases * Provide

[MediaWiki-commits] [Gerrit] Optimize imports - change (mediawiki...Ask)

2013-07-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Optimize imports .. Optimize imports Change-Id: I80016bf4bbf964641bbb1d89fad33a4e748445d0 --- M

[MediaWiki-commits] [Gerrit] Update QueryRountrip integration test to use new factories - change (mediawiki...Ask)

2013-07-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Update QueryRountrip integration test to use new factories .. Update QueryRountrip integration test to use new factories Change-Id:

[MediaWiki-commits] [Gerrit] Add missing wfProfileOut() call - change (mediawiki...Wikibase)

2013-07-13 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Add missing wfProfileOut() call .. Add missing wfProfileOut() call Change-Id: I2e3aaef7015e109a094cbfb512e09eec2b641d83 --- M

[MediaWiki-commits] [Gerrit] Check if Diff is a value before accessing value field - change (mediawiki...Wikibase)

2013-07-13 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/73566 Change subject: Check if Diff is a value before accessing value field .. Check if Diff is a value before accessing value field This

[MediaWiki-commits] [Gerrit] Log a warning if ItemChange::getSiteLinkDiff returns a non-a... - change (mediawiki...Wikibase)

2013-07-13 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Log a warning if ItemChange::getSiteLinkDiff returns a non-array .. Log a warning if ItemChange::getSiteLinkDiff returns a non-array Untested quick

[MediaWiki-commits] [Gerrit] Revert Log a warning if ItemChange::getSiteLinkDiff returns... - change (mediawiki...Wikibase)

2013-07-13 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Revert Log a warning if ItemChange::getSiteLinkDiff returns a non-array .. Revert Log a warning if ItemChange::getSiteLinkDiff returns a non-array

[MediaWiki-commits] [Gerrit] (bug 43238) Add very simple weighting for entity search (DO ... - change (mediawiki...Wikibase)

2013-07-12 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/73405 Change subject: (bug 43238) Add very simple weighting for entity search (DO NOT MERGE) .. (bug 43238) Add very simple weighting for

[MediaWiki-commits] [Gerrit] (bug 51227) add term_weight column to wb_terms table - change (mediawiki...Wikibase)

2013-07-12 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/73420 Change subject: (bug 51227) add term_weight column to wb_terms table .. (bug 51227) add term_weight column to wb_terms table

[MediaWiki-commits] [Gerrit] editentity aliases only 1 changeop per change type - change (mediawiki...Wikibase)

2013-07-11 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: editentity aliases only 1 changeop per change type .. editentity aliases only 1 changeop per change type Previously a changeop was created for each

[MediaWiki-commits] [Gerrit] Fix class name of query entity - change (mediawiki...Wikibase)

2013-07-10 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Fix class name of query entity .. Fix class name of query entity Change-Id: I607d2ae2d39f8ddb4d5258897309a30abc3a2bca --- M

[MediaWiki-commits] [Gerrit] (bug 46867) skip bad search keys and report them. - change (mediawiki...Wikibase)

2013-07-10 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: (bug 46867) skip bad search keys and report them. .. (bug 46867) skip bad search keys and report them. rebuildTermsSearchKey.php now reports terms

[MediaWiki-commits] [Gerrit] Auto-populate wb_property_info in updater. - change (mediawiki...Wikibase)

2013-07-10 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Auto-populate wb_property_info in updater. .. Auto-populate wb_property_info in updater. Change-Id: I7ba72849258d26a106eb39b9ac91de9b800042fc --- M

[MediaWiki-commits] [Gerrit] Added DispatchingDeserializer - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added DispatchingDeserializer .. Added DispatchingDeserializer Change-Id: I53802bf1ebb98887b6fe9d37974d732196d00cdb --- A

[MediaWiki-commits] [Gerrit] Introduced TypedObjectDeserializer to avoid code duplication - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Introduced TypedObjectDeserializer to avoid code duplication .. Introduced TypedObjectDeserializer to avoid code duplication Change-Id:

[MediaWiki-commits] [Gerrit] Added SelectionRequestDeserializer - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added SelectionRequestDeserializer .. Added SelectionRequestDeserializer Change-Id: Ibaaf7d0c4a263370a65c190939e96b20d721880e --- A

[MediaWiki-commits] [Gerrit] Tweaks to entry point file - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Tweaks to entry point file .. Tweaks to entry point file Change-Id: I280f19a0e0f0f7913afcc14b2edda5ba644f9fe5 --- M Ask.php 1 file changed, 6

[MediaWiki-commits] [Gerrit] Rename source folder to src - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Rename source folder to src .. Rename source folder to src Change-Id: I64f4c844300f701b4391f9bc356d39af2fa3d1eb --- M Ask.php R

[MediaWiki-commits] [Gerrit] Optimized imports - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Optimized imports .. Optimized imports Change-Id: I40d48a0935981e49c8ca97c95b0ad45c05373314 --- M src/Ask/Deserializers/DescriptionDeserializer.php A

[MediaWiki-commits] [Gerrit] Remove Serializer from SerializationException - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Remove Serializer from SerializationException .. Remove Serializer from SerializationException Change-Id: I7e3be7547c14b2c7c4d9d2102a1f0ae8031aaf39

[MediaWiki-commits] [Gerrit] Added attributeValue to InvalidAttributeException - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added attributeValue to InvalidAttributeException .. Added attributeValue to InvalidAttributeException Change-Id:

[MediaWiki-commits] [Gerrit] Split off StrategicDeserializer from TypedObjectDeserializer... - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Split off StrategicDeserializer from TypedObjectDeserializer and added QueryOptionsDeserializer .. Split off StrategicDeserializer from

[MediaWiki-commits] [Gerrit] Added QueryDeserializer - change (mediawiki...Ask)

2013-07-09 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added QueryDeserializer .. Added QueryDeserializer * Added QueryDeserializer * Added QueryDeserializerTest * Added QueryRountripTest (integration) *

[MediaWiki-commits] [Gerrit] Ground work for deserialization code - change (mediawiki...Ask)

2013-07-08 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Ground work for deserialization code .. Ground work for deserialization code * Added Deserializer interface * Added DeserializationException * Added

[MediaWiki-commits] [Gerrit] Preliminary implementation of DescriptionDeserializer - change (mediawiki...Ask)

2013-07-08 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Preliminary implementation of DescriptionDeserializer .. Preliminary implementation of DescriptionDeserializer * Added preliminary

[MediaWiki-commits] [Gerrit] Added SortExpressionDeserializer - change (mediawiki...Ask)

2013-07-08 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added SortExpressionDeserializer .. Added SortExpressionDeserializer Change-Id: I8986394c6b4c726a2adc2138b29e72750a9d42b4 --- M

[MediaWiki-commits] [Gerrit] Improve class LanguageFallbackChain and its factory - change (mediawiki...Wikibase)

2013-07-05 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Improve class LanguageFallbackChain and its factory .. Improve class LanguageFallbackChain and its factory Change-Id:

[MediaWiki-commits] [Gerrit] Make MultiLangSerializationOptions aware of fallback chains - change (mediawiki...Wikibase)

2013-07-05 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Make MultiLangSerializationOptions aware of fallback chains .. Make MultiLangSerializationOptions aware of fallback chains Change-Id:

[MediaWiki-commits] [Gerrit] Hooked up EntityRemover to lower level components - change (mediawiki...Wikibase)

2013-05-29 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Hooked up EntityRemover to lower level components .. Hooked up EntityRemover to lower level components Change-Id:

[MediaWiki-commits] [Gerrit] Added EntityUpdater - change (mediawiki...Wikibase)

2013-05-29 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added EntityUpdater .. Added EntityUpdater Change-Id: I809273a8b21ff08522c9d9331b8f917478e51cc8 --- A QueryEngine/includes/SQLStore/EntityUpdater.php

[MediaWiki-commits] [Gerrit] Fix action=purge for Special:EntityData - change (mediawiki...Wikibase)

2013-05-29 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Fix action=purge for Special:EntityData .. Fix action=purge for Special:EntityData Previous check was silly. Change-Id:

[MediaWiki-commits] [Gerrit] Fix action=purge for Special:EntityData - change (mediawiki...Wikibase)

2013-05-29 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Fix action=purge for Special:EntityData .. Fix action=purge for Special:EntityData Previous check was silly. Change-Id:

[MediaWiki-commits] [Gerrit] Take care of TableBuilder TODO in QueryEngine component - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Take care of TableBuilder TODO in QueryEngine component .. Take care of TableBuilder TODO in QueryEngine component Change-Id:

[MediaWiki-commits] [Gerrit] Removed unused import in EntityInserter - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Removed unused import in EntityInserter .. Removed unused import in EntityInserter Change-Id: If4970eec3ace422ec624196b2bab73c1fcca3de0 --- M

[MediaWiki-commits] [Gerrit] Fixed some docs in EntityInserter - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Fixed some docs in EntityInserter .. Fixed some docs in EntityInserter Change-Id: Ibaf8fb7f2c677a40c73eb57114d6c16b1ee8f94b --- M

[MediaWiki-commits] [Gerrit] Remove EntityTable from EntityInserter - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Remove EntityTable from EntityInserter .. Remove EntityTable from EntityInserter We currently have no need to insert into this table. Change-Id:

[MediaWiki-commits] [Gerrit] Removed unused import in EntityInserterTest - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Removed unused import in EntityInserterTest .. Removed unused import in EntityInserterTest Change-Id: Ib452ae78522f43603af127386d16d5d8c2d21be6 --- M

[MediaWiki-commits] [Gerrit] Added SnakRemover - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added SnakRemover .. Added SnakRemover Change-Id: I01266d0f964186b539f45db7fc2fe1e0586d7fd2 --- A

[MediaWiki-commits] [Gerrit] getInternalIdForEntity now takes an EntityId rather than its... - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: getInternalIdForEntity now takes an EntityId rather than its components .. getInternalIdForEntity now takes an EntityId rather than its components

[MediaWiki-commits] [Gerrit] Remove obsolete test registration code - change (mediawiki...Ask)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Remove obsolete test registration code .. Remove obsolete test registration code Change-Id: I5c75f1132b55db53617b8c0d406e51ca173d1b7d --- M

[MediaWiki-commits] [Gerrit] Added covers tags for DescriptionCollection covering tests - change (mediawiki...Ask)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added covers tags for DescriptionCollection covering tests .. Added covers tags for DescriptionCollection covering tests Change-Id:

[MediaWiki-commits] [Gerrit] Added tests for DescriptionCollection::equals - change (mediawiki...Ask)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added tests for DescriptionCollection::equals .. Added tests for DescriptionCollection::equals Change-Id: I56540d45131a9fde8243932b94043be122bb66fe

[MediaWiki-commits] [Gerrit] Simplified FQNs and imported classes - change (mediawiki...Ask)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Simplified FQNs and imported classes .. Simplified FQNs and imported classes Change-Id: I04e4eb99fe829e29b058d3dc9fd33d33840477c8 --- M

[MediaWiki-commits] [Gerrit] Added ThrowingPatcherTest to test throwErrors and ignoreErrors - change (mediawiki...Diff)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added ThrowingPatcherTest to test throwErrors and ignoreErrors .. Added ThrowingPatcherTest to test throwErrors and ignoreErrors Change-Id:

[MediaWiki-commits] [Gerrit] Added FIXME to broken code - change (mediawiki...Diff)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added FIXME to broken code .. Added FIXME to broken code Change-Id: I04cb8c0c3362de03c6344e0c1e2a2b173dd35413 --- M includes/differ/ListDiffer.php 1

[MediaWiki-commits] [Gerrit] Remove ListDiff::newEmpty - change (mediawiki...Diff)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Remove ListDiff::newEmpty .. Remove ListDiff::newEmpty Change-Id: I51467c1245f86d90d646e4d757f5864160e0d6f9 --- M includes/diffop/diff/ListDiff.php 1

[MediaWiki-commits] [Gerrit] Removed impossible to test else case, only there for legacy ... - change (mediawiki...Diff)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Removed impossible to test else case, only there for legacy reasons, from Diff .. Removed impossible to test else case, only there for legacy

[MediaWiki-commits] [Gerrit] Added testErrorOnUnknownDiffOpType to MapPatcherTest - change (mediawiki...Diff)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added testErrorOnUnknownDiffOpType to MapPatcherTest .. Added testErrorOnUnknownDiffOpType to MapPatcherTest Change-Id:

[MediaWiki-commits] [Gerrit] Fixed paths in test suite config - change (mediawiki...DataValues)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Fixed paths in test suite config .. Fixed paths in test suite config Change-Id: I5a55b88217f172df2698ab991812c5f158775ae2 --- M phpunit.xml.dist 1

[MediaWiki-commits] [Gerrit] Move Set and RemoveQualifier api modules out of experimental - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Move Set and RemoveQualifier api modules out of experimental .. Move Set and RemoveQualifier api modules out of experimental we've had qualifiers for

[MediaWiki-commits] [Gerrit] Added @throws docs - change (mediawiki...Diff)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added @throws docs .. Added @throws docs Change-Id: I47c7ad264501c884be28566167fd4dd17e6f03de --- M includes/patcher/ListPatcher.php M

[MediaWiki-commits] [Gerrit] Implemented ValueSnakStore-removeSnaksOfSubject - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Implemented ValueSnakStore-removeSnaksOfSubject .. Implemented ValueSnakStore-removeSnaksOfSubject Change-Id:

[MediaWiki-commits] [Gerrit] Implemented ValuelessSnakStore-removeSnaksOfSubject - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Implemented ValuelessSnakStore-removeSnaksOfSubject .. Implemented ValuelessSnakStore-removeSnaksOfSubject Change-Id:

[MediaWiki-commits] [Gerrit] Fix fetching of a TableBuilder after it got moved about - change (mediawiki...Wikibase)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Fix fetching of a TableBuilder after it got moved about .. Fix fetching of a TableBuilder after it got moved about Change-Id:

[MediaWiki-commits] [Gerrit] Added testPatchMapRaisesError to ListPatcherTest - change (mediawiki...Diff)

2013-05-28 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added testPatchMapRaisesError to ListPatcherTest .. Added testPatchMapRaisesError to ListPatcherTest Also removed an unreachable line in ListPatcher

[MediaWiki-commits] [Gerrit] Removed word 'proleptic' from message - change (mediawiki...DataValues)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Removed word 'proleptic' from message .. Removed word 'proleptic' from message - this was misleading and just wrong in some cases Change-Id:

[MediaWiki-commits] [Gerrit] Purging of cached output from Special:EntityData. - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Purging of cached output from Special:EntityData. .. Purging of cached output from Special:EntityData. This will cause Special:EntityData to purge

[MediaWiki-commits] [Gerrit] Config setting for cache duration of entity data. - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Config setting for cache duration of entity data. .. Config setting for cache duration of entity data. This introduces

[MediaWiki-commits] [Gerrit] Allow ntriples in Special:EntityData - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Allow ntriples in Special:EntityData .. Allow ntriples in Special:EntityData Change-Id: I410166bb96a60dc4851ac21917aee8fcd3eabb25 --- M

[MediaWiki-commits] [Gerrit] (hotfix) Fixed diff of claims with a time property - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: (hotfix) Fixed diff of claims with a time property .. (hotfix) Fixed diff of claims with a time property Bug: 48709 Change-Id:

[MediaWiki-commits] [Gerrit] Stopgap to avoid excessively long string values (backport) - change (mediawiki...DataValues)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Stopgap to avoid excessively long string values (backport) .. Stopgap to avoid excessively long string values (backport) Change-Id:

[MediaWiki-commits] [Gerrit] Added UpdateFailedException - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added UpdateFailedException .. Added UpdateFailedException Change-Id: Ifd963ef53a0c18566c502e08b58a3888b7e1a6e8 --- A

[MediaWiki-commits] [Gerrit] trim incoming string values - change (mediawiki...DataValues)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: trim incoming string values .. trim incoming string values Change-Id: I0055dddbb0b810432879d275e1e102069e7736c2 --- M

[MediaWiki-commits] [Gerrit] Added DeleteFailedException - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added DeleteFailedException .. Added DeleteFailedException Change-Id: Ib70c85b202c1db9c8735baa94f9eb373c4b022f3 --- A

[MediaWiki-commits] [Gerrit] Add @throws to QueryInterface interface - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Add @throws to QueryInterface interface .. Add @throws to QueryInterface interface Change-Id: I8caf8db70dbd4ab82b651767f7780aa6444526f3 --- M

[MediaWiki-commits] [Gerrit] Updated depenedencies in composer.json - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Updated depenedencies in composer.json .. Updated depenedencies in composer.json Change-Id: I8c1efb6f10681aa3ddcc0011e1a64210a1933c03 --- M

[MediaWiki-commits] [Gerrit] Added InsertFailedException - change (mediawiki...Wikibase)

2013-05-22 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added InsertFailedException .. Added InsertFailedException Change-Id: I12a18822c4f4ee2e8ea3cf950edba33fa53e59dc --- M

[MediaWiki-commits] [Gerrit] Fixed wrong decade precision - change (mediawiki...DataValues)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Fixed wrong decade precision .. Fixed wrong decade precision Bug: 48673 Change-Id: Ic819a280783ac0afe261988b913d14ee0d57c061 --- M

[MediaWiki-commits] [Gerrit] Remove some deprecated methods - change (mediawiki...Diff)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Remove some deprecated methods .. Remove some deprecated methods Change-Id: If918a7ed1346dbf2924dbc7106adbc19376abe59 --- M Diff.php M RELEASE-NOTES

[MediaWiki-commits] [Gerrit] (bug 48145) Moves Time data type out of experimental - change (mediawiki...Wikibase)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: (bug 48145) Moves Time data type out of experimental .. (bug 48145) Moves Time data type out of experimental Change-Id:

[MediaWiki-commits] [Gerrit] Add unhappy path test to DiffTest - change (mediawiki...Diff)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Add unhappy path test to DiffTest .. Add unhappy path test to DiffTest Change-Id: I31abcd1a5273ce8b600a1bb33130924c4653f9c6 --- M

[MediaWiki-commits] [Gerrit] Add unhappy path test to MapDifferTest - change (mediawiki...Diff)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Add unhappy path test to MapDifferTest .. Add unhappy path test to MapDifferTest Change-Id: Iba9b99b71852a4758a8fce7756cb0c2ef5da50c7 --- M

[MediaWiki-commits] [Gerrit] Add unhappy path test to CallbackListDifferTest - change (mediawiki...Diff)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Add unhappy path test to CallbackListDifferTest .. Add unhappy path test to CallbackListDifferTest Change-Id:

[MediaWiki-commits] [Gerrit] Improved ListPatcherTest - change (mediawiki...Diff)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Improved ListPatcherTest .. Improved ListPatcherTest Change-Id: Ie4be97512dd2831ffd5d88f7da5e859fcc5ac37c --- M

[MediaWiki-commits] [Gerrit] Throw an exception when DataValues is not loaded rather then... - change (mediawiki...Ask)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Throw an exception when DataValues is not loaded rather then outputting HTML .. Throw an exception when DataValues is not loaded rather then

[MediaWiki-commits] [Gerrit] Added Travis CI build status image to readme.md - change (mediawiki...Ask)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added Travis CI build status image to readme.md .. Added Travis CI build status image to readme.md Change-Id:

[MediaWiki-commits] [Gerrit] Add DataValues as requirement in composer.json - change (mediawiki...Ask)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Add DataValues as requirement in composer.json .. Add DataValues as requirement in composer.json Change-Id: I72c129c3a63369862c98837f42c818cd3536fd5b

[MediaWiki-commits] [Gerrit] (bug 44576) Select format based on Accept header. - change (mediawiki...Wikibase)

2013-05-21 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: (bug 44576) Select format based on Accept header. .. (bug 44576) Select format based on Accept header. This implements content negotiation for

[MediaWiki-commits] [Gerrit] changed namespaces a bit, added license - change (mediawiki...Wikibase)

2013-05-19 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/64538 Change subject: changed namespaces a bit, added license .. changed namespaces a bit, added license Change-Id:

[MediaWiki-commits] [Gerrit] Have the SnakStores actually insert the subject_id field - change (mediawiki...Wikibase)

2013-05-17 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Have the SnakStores actually insert the subject_id field .. Have the SnakStores actually insert the subject_id field Change-Id:

[MediaWiki-commits] [Gerrit] Work on DescriptionMatchFinder - change (mediawiki...Wikibase)

2013-05-17 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Work on DescriptionMatchFinder .. Work on DescriptionMatchFinder Change-Id: I0925c4e0df35481fc6e17546536453c32cd1388b --- M

[MediaWiki-commits] [Gerrit] Added SelectFailedException - change (mediawiki...Wikibase)

2013-05-17 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Added SelectFailedException .. Added SelectFailedException Change-Id: Ied44503ca68e0156bb445787c64d958119149f8e --- M

[MediaWiki-commits] [Gerrit] Throw a TableCreationFailedException when table creation fai... - change (mediawiki...Wikibase)

2013-05-17 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Throw a TableCreationFailedException when table creation fails rather then returning false .. Throw a TableCreationFailedException when table

[MediaWiki-commits] [Gerrit] Insert subject id into snak rows - change (mediawiki...Wikibase)

2013-05-17 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Insert subject id into snak rows .. Insert subject id into snak rows Change-Id: If785bea11374eef2bc38d3794ea8f3cb1f910883 --- M

[MediaWiki-commits] [Gerrit] SomeProperty-getDescription to -getSubDescription - change (mediawiki...Ask)

2013-05-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: SomeProperty-getDescription to -getSubDescription .. SomeProperty-getDescription to -getSubDescription Change-Id:

[MediaWiki-commits] [Gerrit] Have PropertyValue return the value is contains in getValue ... - change (mediawiki...DataValues)

2013-05-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Have PropertyValue return the value is contains in getValue rather then itself .. Have PropertyValue return the value is contains in getValue rather

[MediaWiki-commits] [Gerrit] SomePropertyDescription now takes anything that is a DataVal... - change (mediawiki...Ask)

2013-05-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: SomePropertyDescription now takes anything that is a DataValue as $propertyId argument .. SomePropertyDescription now takes anything that is a

[MediaWiki-commits] [Gerrit] Get rid of all PropertyValue usage, replace by DataValue typ... - change (mediawiki...Ask)

2013-05-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Get rid of all PropertyValue usage, replace by DataValue type hinting .. Get rid of all PropertyValue usage, replace by DataValue type hinting

[MediaWiki-commits] [Gerrit] Removed PropertyValue class - change (mediawiki...DataValues)

2013-05-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Removed PropertyValue class .. Removed PropertyValue class Change-Id: Ib1d6b79efe25e5d144ea5f949b810c002f53b600 --- M

[MediaWiki-commits] [Gerrit] Add subject_id field to all property snak tables - change (mediawiki...Wikibase)

2013-05-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has submitted this change and it was merged. Change subject: Add subject_id field to all property snak tables .. Add subject_id field to all property snak tables Change-Id:

[MediaWiki-commits] [Gerrit] first draft of the RDF dump creating script (DO NOT MERGE) - change (mediawiki...Wikibase)

2013-05-16 Thread Denny Vrandecic (Code Review)
Denny Vrandecic has uploaded a new change for review. https://gerrit.wikimedia.org/r/64081 Change subject: first draft of the RDF dump creating script (DO NOT MERGE) .. first draft of the RDF dump creating script (DO NOT

  1   2   >