Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348185 )
Change subject: [DNM] Try to find untracked/mid-test ajax request
..
[DNM] Try to find untracked/mid-test ajax request
Change-Id: Ic011f717
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348179 )
Change subject: Replace use of deprecated jQuery bind() with on()
..
Replace use of deprecated jQuery bind() with on()
bind() wasnt removed
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348145 )
Change subject: jquery.tablesorter: Disable a flaky isoDate test case
..
jquery.tablesorter: Disable a flaky isoDate test case
This one var
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348144 )
Change subject: qunit: Remove test for deprecated jquery.placeholder
..
qunit: Remove test for deprecated jquery.placeholder
It's not very
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348143 )
Change subject: Use JSON.parse() instead of deprecated $.parseJSON()
..
Use JSON.parse() instead of deprecated $.parseJSON()
> JQMIGRATE: j
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348142 )
Change subject: build: Remove unused jquery.js copy
..
build: Remove unused jquery.js copy
Change-Id: Ia053b707589d230b0bb545c1b0375bcb997c
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348141 )
Change subject: build: Enforce minumum code coverage
..
build: Enforce minumum code coverage
Change-Id: I5e03ccc1a4d0717aec4a2a38b86b70db24
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348140 )
Change subject: build: Switch default form PhantomJS to Chrome
..
build: Switch default form PhantomJS to Chrome
Rename karma:local to karm
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348139 )
Change subject: build: Remove 'grunt watch'
..
build: Remove 'grunt watch'
I don't think anyone uses this much and is quite a hack to maint
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348137 )
Change subject: build: Merge 'clean:*' subtasks into one 'clean'
..
build: Merge 'clean:*' subtasks into one 'clean'
Similar to unicodejs,
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348134 )
Change subject: Use JSON.parse() instead of deprecated $.parseJSON()
..
Use JSON.parse() instead of deprecated $.parseJSON()
> JQMIGRATE: j
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348133 )
Change subject: tests: Use assert.async() instead of QUnit.stop/start
..
tests: Use assert.async() instead of QUnit.stop/start
Also remove
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348123 )
Change subject: tests: Don't assume synchronous jQuery.Deferred
..
tests: Don't assume synchronous jQuery.Deferred
Match the way mediawiki.
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348121 )
Change subject: Remove outdated wgIncludejQueryMigrate setting
..
Remove outdated wgIncludejQueryMigrate setting
Change-Id: I868262a5793ef9
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348120 )
Change subject: Set wgUsejQueryThree to false in prod
..
Set wgUsejQueryThree to false in prod
This new variable will start to exist in the
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348014 )
Change subject: Make LoadBalancer::waitFor() and friends more robust via
try/finally
..
Make LoadBalancer::waitFor() and friends
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347982 )
Change subject: [WIP] Debug trackAjax()
..
[WIP] Debug trackAjax()
jQuery 3 + VisualEditor fails in Jenkins with "Pending ajax request"
how
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347970 )
Change subject: Ensure logo preload transforms urls if needed
..
Ensure logo preload transforms urls if needed
If the logo url is from with
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347797 )
Change subject: tests: Ignore export.js
..
tests: Ignore export.js
Change-Id: I514325eb6fa784f43d6f0dcd93583ec3c2373c71
---
M src/export.js
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347795 )
Change subject: build: Enforce karma-coverage >97% and 100% for functions
..
build: Enforce karma-coverage >97% and 100% for functions
* Ea
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347792 )
Change subject: tests: Complete code coverage by tests for EmitterList
..
tests: Complete code coverage by tests for EmitterList
* removeIt
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347788 )
Change subject: tests: Complete code coverage by tests for Registry and Factory
..
tests: Complete code coverage by tests for Registry and F
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347675 )
Change subject: tests: Complete code coverage by tests for EventEmitter
..
tests: Complete code coverage by tests for EventEmitter
* valida
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347672 )
Change subject: core: Complete code coverage
..
core: Complete code coverage
* compare():
- Add case for comparing DOM nodes using isEqua
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347669 )
Change subject: tests: Fix broken setup/teardown in tests/index.html
..
tests: Fix broken setup/teardown in tests/index.html
In QUnit 1.16,
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347555 )
Change subject: build: Use source maps in coverage report
..
build: Use source maps in coverage report
* Add concat:test which builds dist/
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347550 )
Change subject: interwiki: Remove inappropiate use of wfMemcKey()
..
interwiki: Remove inappropiate use of wfMemcKey()
This is used for loo
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347549 )
Change subject: interwiki: Use makeKey from WANObjectCache instead of wfMemcKey
..
interwiki: Use makeKey from WANObjectCache instead of wfM
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347544 )
Change subject: [WIP] oojs-ui: Use dist/*-icon*.css instead re-creating with
RLIM
..
[WIP] oojs-ui: Use dist/*-icon*.css instead re-creatin
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347539 )
Change subject: phpunit: Avoid use of wmf-production host names
..
phpunit: Avoid use of wmf-production host names
* Remove used of 'eqiad'
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347512 )
Change subject: objectcache: Complete coverage for newAnything()
..
objectcache: Complete coverage for newAnything()
* Fix typo that disabl
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347135 )
Change subject: objectcache: Complete code coverage for CachedBagOStuff
..
objectcache: Complete code coverage for CachedBagOStuff
Change-I
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347133 )
Change subject: objectcache: Fix CachedBagOStuff to use backend makeKey()
..
objectcache: Fix CachedBagOStuff to use backend makeKey()
Foll
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346936 )
Change subject: CNChoiceDataModule: Avoid deprecated getModifiedHash()
..
CNChoiceDataModule: Avoid deprecated getModifiedHash()
ResourceLo
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346932 )
Change subject: phpunit: Shadow getMock() as deprecated in MediaWikiTestCase
..
phpunit: Shadow getMock() as deprecated in MediaWikiTestCase
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346925 )
Change subject: Add HD logos
..
Add HD logos
Bug: T100999
Change-Id: Idb8559a178f339c1eb6aa520f2d7d0a8ac2c003e
(cherry picked from commit 6
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346822 )
Change subject: EventEmitter: Document disconnect() behaviour regarding array
matching
..
EventEmitter: Document disconnect() behaviour reg
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346674 )
Change subject: resourceloader: Improve code coverage
..
resourceloader: Improve code coverage
* Missing cases for StartupModule::getModule
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/34 )
Change subject: [WIP] phpunit: Avoid use of deprecated getMock for PHPUnit 5
compat
..
[WIP] phpunit: Avoid use of deprecated getMock for P
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346662 )
Change subject: phpunit: Remove unused assertEmpty() fallback for PHPUnit 3
compat
..
phpunit: Remove unused assertEmpty() fallback for PHP
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346653 )
Change subject: test: Update mobile_result fixture
..
test: Update mobile_result fixture
The current one was outdated and mentioned various
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346491 )
Change subject: util: Simplify isPlainObject and fix two false positives
..
util: Simplify isPlainObject and fix two false positives
We alr
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346490 )
Change subject: build: Update to jQuery 3
..
build: Update to jQuery 3
Change-Id: I96da155143654de4e94c6f828eb260997bd9b20c
---
M package.j
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/345628 )
Change subject: Use full qualified names in @uses/@covers in PHPUnit
..
Use full qualified names in @uses/@covers in PHPUnit
Bug: T
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/345627 )
Change subject: Use full qualified names in @uses/@covers in PHPUnit
..
Use full qualified names in @uses/@covers in PHPUnit
Bug: T
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/345629 )
Change subject: Use full qualified names in @uses/@covers in PHPUnit
..
Use full qualified names in @uses/@covers in PHPUnit
Bug: T
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346471 )
Change subject: mw.loader: Remove redundant compat code for IE <= 9
..
mw.loader: Remove redundant compat code for IE <= 9
Follows-up 09fce
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346466 )
Change subject: rlfeature: Remove es5strict support tracking
..
rlfeature: Remove es5strict support tracking
We've been collecting data for
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346465 )
Change subject: mediawiki.log: Improve documentation
..
mediawiki.log: Improve documentation
* Clarify that all mw.log submethods use the n
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346454 )
Change subject: jsduck: Unbreak live demos (mwNow undefined)
..
jsduck: Unbreak live demos (mwNow undefined)
* Update the mock startup.js i
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346234 )
Change subject: [WIP] Document and automate sources of static/project-logos
..
[WIP] Document and automate sources of static/project-logos
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/345616 )
Change subject: Convert WikimediaBadges to extension registration
..
Convert WikimediaBadges to extension registration
Bug: T92980
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345953 )
Change subject: resourceloader: Improve code coverage for WikiModuleTest
..
resourceloader: Improve code coverage for WikiModuleTest
preloa
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345952 )
Change subject: FauxRequest: Complete code coverage for FauxRequestTest
..
FauxRequest: Complete code coverage for FauxRequestTest
* Add mi
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345951 )
Change subject: Html: Add a few @covers for HtmlTest
..
Html: Add a few @covers for HtmlTest
Change-Id: I0804e87ebc732d7adf082915af6d137f82
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345950 )
Change subject: ObjectFactory: Complete code coverage for ObjectFactoryTest
..
ObjectFactory: Complete code coverage for ObjectFactoryTest
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345949 )
Change subject: objectcache: Complete code coverage for HashBagOStuff
..
objectcache: Complete code coverage for HashBagOStuff
Change-Id: I
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345948 )
Change subject: resourceloader: Complete code coverage for MessageBlobStore
..
resourceloader: Complete code coverage for MessageBlobStore
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345947 )
Change subject: changes: Remove assertTag from RCCacheEntryFactoryTest
..
changes: Remove assertTag from RCCacheEntryFactoryTest
Use PHPUni
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345946 )
Change subject: [WIP] phpunit: Make deprecated assertTag() work in PHPUnit 5
..
[WIP] phpunit: Make deprecated assertTag() work in PHPUnit 5
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345945 )
Change subject: phpunit: Remove unused assertNotTag() method
..
phpunit: Remove unused assertNotTag() method
Deprecated since PHPUnit 4.2,
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345882 )
Change subject: Simplify OtherProjects caching by using getWithSetCallback()
..
Simplify OtherProjects caching by using getWithSetCallback()
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345792 )
Change subject: build: Use HTTPS for mit-license.org url
..
build: Use HTTPS for mit-license.org url
Change-Id: Iff15a5df82da8b24fbdbb9c7b4
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345787 )
Change subject: tests: Complete code coverage to 100%
..
tests: Complete code coverage to 100%
* Add missing coverage for addCidr() errors.
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345785 )
Change subject: build: Update PHPUnit 4.7 to 4.8
..
build: Update PHPUnit 4.7 to 4.8
* Adds forwards-compatibility for PHPUnit 6 interface.
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345786 )
Change subject: tests: Set name for data provider data sets
..
tests: Set name for data provider data sets
Move test names into array keys
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345493 )
Change subject: build: Remove PHP 5.3.3 from Travis config (keep other 5.3.x)
..
build: Remove PHP 5.3.3 from Travis config (keep other 5.3.
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345475 )
Change subject: Move mw coverage from Trusty (PHP 5.5) to Jessie (PHP 5.6)
..
Move mw coverage from Trusty (PHP 5.5) to Jessie (PHP 5.6)
Sh
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345433 )
Change subject: tests: Complete code coverage to 100%
..
tests: Complete code coverage to 100%
* Add missing coverage for getKeywords().
*
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345432 )
Change subject: build: Update PHPUnit 4.6 to 4.8
..
build: Update PHPUnit 4.6 to 4.8
* PHPUnit 5.x requires PHP 5.7+
Change-Id: I089fc88e8
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345418 )
Change subject: tests: Complete code coverage to 100%
..
tests: Complete code coverage to 100%
There is one line not being covered because
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345416 )
Change subject: tests: Complete code coverage to 100%
..
tests: Complete code coverage to 100%
WrappedStringList::__toString() wasn't cover
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345417 )
Change subject: build: Update PHPUnit 4.6 to 4.8
..
build: Update PHPUnit 4.6 to 4.8
We could raise support from PHP 5.3 to PHP 5.5, but th
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345415 )
Change subject: build: Update PHPUnit 4.7 to 4.8
..
build: Update PHPUnit 4.7 to 4.8
* PHPUnit 5.x requires PHP 5.7+
* PHPUnit 6.x requires
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345413 )
Change subject: build: Add 'composer run cover' command
..
build: Add 'composer run cover' command
Easier to run locally than `./vendor/bin
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345414 )
Change subject: tests: Complete code coverage to 100%
..
tests: Complete code coverage to 100%
Add missing test case for invalid input to g
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345392 )
Change subject: qunit: Remove obsolete 'tac|tac' hack
..
qunit: Remove obsolete 'tac|tac' hack
Follows-up bc110f8b8241.
Aside from this be
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345269 )
Change subject: HttpFunctions: Increase code coverage
..
HttpFunctions: Increase code coverage
* Complete coverage for Http::getProxy().
*
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345251 )
Change subject: resourceloader: Avoid deprecated getModifiedHash() in SkinModule
..
resourceloader: Avoid deprecated getModifiedHash() in Sk
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345249 )
Change subject: build: Make Travis CI 'Postgres' build non-voting
..
build: Make Travis CI 'Postgres' build non-voting
This will make it ea
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345084 )
Change subject: collapsibleFooter: Move client-side state cookies to
localStorage
..
collapsibleFooter: Move client-side state cookies to l
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345079 )
Change subject: build: Make Travis CI 'Postgres' build non-voting
..
build: Make Travis CI 'Postgres' build non-voting
This will make it ea
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345078 )
Change subject: ext.NavigationTiming: Restore unsampled Save Timing
..
ext.NavigationTiming: Restore unsampled Save Timing
Follows-up 89578
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345068 )
Change subject: build: Switch from JSHint/JSCS to ESLint
..
build: Switch from JSHint/JSCS to ESLint
Change-Id: I8fd9ec82db5b9316162bd09180
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345067 )
Change subject: index: Remove use of Google Fonts
..
index: Remove use of Google Fonts
Also remove non-standard nav.navbar-default wrapper
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345064 )
Change subject: sync-gh-pages: Add .nojekyll file
..
sync-gh-pages: Add .nojekyll file
As of December 2016, GitHub Pages is powered by Jeky
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345051 )
Change subject: ext.NavigationTiming: Restore unsampled Save Timing
..
ext.NavigationTiming: Restore unsampled Save Timing
Follows-up 89578
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344746 )
Change subject: resourceloader: Use Object.keys() instead of map() to get keys
..
resourceloader: Use Object.keys() instead of map() to get
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344745 )
Change subject: resourceloader: Use Array#map instead of jQuery#map for arrays
..
resourceloader: Use Array#map instead of jQuery#map for ar
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344744 )
Change subject: resourceloader: Use Date.now() for mw.now() instead of '+new
Date'
..
resourceloader: Use Date.now() for mw.now() instead o
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344743 )
Change subject: Use mw.now() instead of 'new Date' for relative measurement
..
Use mw.now() instead of 'new Date' for relative measurement
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344741 )
Change subject: resourceloader: Optimise getMimeType() for common case
..
resourceloader: Optimise getMimeType() for common case
About 0.74
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344737 )
Change subject: WikiPage: Remove unused doPurge flags
..
WikiPage: Remove unused doPurge flags
The only callsites that use this argument ar
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344733 )
Change subject: mediawiki-core-code-coverage: Commit live hack
..
mediawiki-core-code-coverage: Commit live hack
Follows-up 4c65c6e4 which
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344731 )
Change subject: qunit: Remove experimental CompletenessTest feature
..
qunit: Remove experimental CompletenessTest feature
The Completeness
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344683 )
Change subject: StartProfiler: Add hostname in xhgui record
..
StartProfiler: Add hostname in xhgui record
Bug: T161286
Change-Id: I51394fb
Krinkle has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/344569 )
Change subject: Revert "Update Wikibase for cherry-picks"
..
Revert "Update Wikibase for cherry-picks"
Outage
This reverts commit
Hello Aude, Catrope, Jonas Kress (WMDE), Addshore, Tobias Gritschacher,
jenkins-bot, Siebrand,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/344569
to review the following change.
Change subject: Revert "Update Wikibase for cherry-picks"
..
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344531 )
Change subject: Grant admin rights on tungsten to perf-roots
..
Grant admin rights on tungsten to perf-roots
Bug: T161261
Change-Id: Ied08d
Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344504 )
Change subject: StartProfiler: Disable production sampling for xhgui
..
StartProfiler: Disable production sampling for xhgui
The current us
501 - 600 of 4836 matches
Mail list logo