[MediaWiki-commits] [Gerrit] operations...wikistats[master]: footer: rm W3C icons and XHTML/CSS claims, use NuHTML validator

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367002 )

Change subject: footer: rm W3C icons and XHTML/CSS claims, use NuHTML validator
..


footer: rm W3C icons and XHTML/CSS claims, use NuHTML validator

These files have been removed, are non-free and nowadays the document
doesn't validate as XHTML strict anymore. (it used to).

Also CSS isn't valid anymore since we use Bootstrap instead of homebrew.

Remove those icons and claims but still link to validator. That uses
the NuHTML validator once the doc type gets changed here.

Change-Id: I15efad937713fcc6c9ffe3d33f0720c2cea88b4c
---
M usr/share/php/wikistats/footer.php
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/usr/share/php/wikistats/footer.php 
b/usr/share/php/wikistats/footer.php
index 4979e3f..a65109d 100644
--- a/usr/share/php/wikistats/footer.php
+++ b/usr/share/php/wikistats/footer.php
@@ -8,8 +8,6 @@
 In use on: ">
 Back to Index
 http://validator.w3.org/check?uri=http://".$selfurl; ?>">
-
-http://jigsaw.w3.org/css-validator/validator?uri=http://".$selfurl; ?>">
-
+validate html
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/367002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I15efad937713fcc6c9ffe3d33f0720c2cea88b4c
Gerrit-PatchSet: 2
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: footer: rm W3C icons and XHTML/CSS claims, use NuHTML validator

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367002 )

Change subject: footer: rm W3C icons and XHTML/CSS claims, use NuHTML validator
..

footer: rm W3C icons and XHTML/CSS claims, use NuHTML validator

Change-Id: I15efad937713fcc6c9ffe3d33f0720c2cea88b4c
---
M usr/share/php/wikistats/footer.php
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/wikistats 
refs/changes/02/367002/1

diff --git a/usr/share/php/wikistats/footer.php 
b/usr/share/php/wikistats/footer.php
index 4979e3f..a65109d 100644
--- a/usr/share/php/wikistats/footer.php
+++ b/usr/share/php/wikistats/footer.php
@@ -8,8 +8,6 @@
 In use on: ">
 Back to Index
 http://validator.w3.org/check?uri=http://".$selfurl; ?>">
-
-http://jigsaw.w3.org/css-validator/validator?uri=http://".$selfurl; ?>">
-
+validate html
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/367002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15efad937713fcc6c9ffe3d33f0720c2cea88b4c
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: index: add link to phab bugs, emphasize not-analytics

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367001 )

Change subject: index: add link to phab bugs, emphasize not-analytics
..


index: add link to phab bugs, emphasize not-analytics

Add a link to Phabricator to the right workboard to show
open bugs and how to report them and emphasize that this
is NOT the stats.wikimedia.org Analytics project.

Change-Id: I0ea90fb07d3c60f0cc8784d0ec57b8bacf4e8329
---
M var/www/wikistats/index.php
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/var/www/wikistats/index.php b/var/www/wikistats/index.php
index 6e3dc48..825949c 100644
--- a/var/www/wikistats/index.php
+++ b/var/www/wikistats/index.php
@@ -61,7 +61,7 @@
 
 Wikistats 2.2
 
-[not-Analytics-Wikistats]
+[not-Analytics-Wikistats]
 
 
 largest (html)
 largest (csv)
@@ -313,8 +314,8 @@
 wikimedias (html)
 wikimedias (csv)
 wikimedias (wiki)
-Ranks
-
+ranks
+https://phabricator.wikimedia.org/tag/vps-project-wikistats/;>bugs
 ALSOSEE;
 
 # Footer / W3C

-- 
To view, visit https://gerrit.wikimedia.org/r/367001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ea90fb07d3c60f0cc8784d0ec57b8bacf4e8329
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: index: add link to phab bugs, emphasize not-analytics

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367001 )

Change subject: index: add link to phab bugs, emphasize not-analytics
..

index: add link to phab bugs, emphasize not-analytics

Add a link to Phabricator to the right workboard to show
open bugs and how to report them and emphasize that this
is NOT the stats.wikimedia.org Analytics project.

Change-Id: I0ea90fb07d3c60f0cc8784d0ec57b8bacf4e8329
---
M var/www/wikistats/index.php
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/wikistats 
refs/changes/01/367001/1

diff --git a/var/www/wikistats/index.php b/var/www/wikistats/index.php
index 6e3dc48..825949c 100644
--- a/var/www/wikistats/index.php
+++ b/var/www/wikistats/index.php
@@ -61,7 +61,7 @@
 
 Wikistats 2.2
 
-[not-Analytics-Wikistats]
+[not-Analytics-Wikistats]
 
 
 largest (html)
 largest (csv)
@@ -313,8 +314,8 @@
 wikimedias (html)
 wikimedias (csv)
 wikimedias (wiki)
-Ranks
-
+ranks
+https://phabricator.wikimedia.org/tag/vps-project-wikistats/;>bugs
 ALSOSEE;
 
 # Footer / W3C

-- 
To view, visit https://gerrit.wikimedia.org/r/367001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ea90fb07d3c60f0cc8784d0ec57b8bacf4e8329
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: fix typo in index.php, remove W3C icons

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367000 )

Change subject: fix typo in index.php, remove W3C icons
..


fix typo in index.php, remove W3C icons

Fix "gwikis" typo introduced in I910d6ed7e699f and
seen by Krinkle.

Remove now unused and W3C icons that
"debian-glue-non-voting" jenkins check even notices
as "license-problem-md5sum-non-free-file". Wow.

Change-Id: I6a41e363437ae31ca510f2f13983042989ebb18c
---
D var/www/wikistats/images/valid-xhtml10-blue.png
D var/www/wikistats/images/vcss-blue.png
M var/www/wikistats/index.php
3 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/var/www/wikistats/images/valid-xhtml10-blue.png 
b/var/www/wikistats/images/valid-xhtml10-blue.png
deleted file mode 100644
index e971248..000
--- a/var/www/wikistats/images/valid-xhtml10-blue.png
+++ /dev/null
Binary files differ
diff --git a/var/www/wikistats/images/vcss-blue.png 
b/var/www/wikistats/images/vcss-blue.png
deleted file mode 100644
index f022511..000
--- a/var/www/wikistats/images/vcss-blue.png
+++ /dev/null
Binary files differ
diff --git a/var/www/wikistats/index.php b/var/www/wikistats/index.php
index 3f6f11f..6e3dc48 100644
--- a/var/www/wikistats/index.php
+++ b/var/www/wikistats/index.php
@@ -142,7 +142,7 @@
 while ($row = $fnord->fetch()) {
 $count++;
 $users = $row['gusers'];
-$gwikis = gwikis + $row['numwikis'];
+$gwikis = $gwikis + $row['numwikis'];
 $gtotal = $gtotal + $row['gtotal'];
 $ggood = $ggood + $row['ggood'];
 $gedits = $gedits + $row['gedits'];

-- 
To view, visit https://gerrit.wikimedia.org/r/367000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a41e363437ae31ca510f2f13983042989ebb18c
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: fix typo in index.php, remove W3C icons

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367000 )

Change subject: fix typo in index.php, remove W3C icons
..

fix typo in index.php, remove W3C icons

Fix "gwikis" typo introduced in I910d6ed7e699f and
seen by Krinkle.

Remove now unused and W3C icons that
"debian-glue-non-voting" jenkins check even notices
as "license-problem-md5sum-non-free-file". Wow.

Change-Id: I6a41e363437ae31ca510f2f13983042989ebb18c
---
D var/www/wikistats/images/valid-xhtml10-blue.png
D var/www/wikistats/images/vcss-blue.png
M var/www/wikistats/index.php
3 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/wikistats 
refs/changes/00/367000/1

diff --git a/var/www/wikistats/images/valid-xhtml10-blue.png 
b/var/www/wikistats/images/valid-xhtml10-blue.png
deleted file mode 100644
index e971248..000
--- a/var/www/wikistats/images/valid-xhtml10-blue.png
+++ /dev/null
Binary files differ
diff --git a/var/www/wikistats/images/vcss-blue.png 
b/var/www/wikistats/images/vcss-blue.png
deleted file mode 100644
index f022511..000
--- a/var/www/wikistats/images/vcss-blue.png
+++ /dev/null
Binary files differ
diff --git a/var/www/wikistats/index.php b/var/www/wikistats/index.php
index 3f6f11f..6e3dc48 100644
--- a/var/www/wikistats/index.php
+++ b/var/www/wikistats/index.php
@@ -142,7 +142,7 @@
 while ($row = $fnord->fetch()) {
 $count++;
 $users = $row['gusers'];
-$gwikis = gwikis + $row['numwikis'];
+$gwikis = $gwikis + $row['numwikis'];
 $gtotal = $gtotal + $row['gtotal'];
 $ggood = $ggood + $row['ggood'];
 $gedits = $gedits + $row['gedits'];

-- 
To view, visit https://gerrit.wikimedia.org/r/367000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a41e363437ae31ca510f2f13983042989ebb18c
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: index: link largest/wikimedias, fix invalid (X)HTML, rm W3C ...

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366999 )

Change subject: index: link largest/wikimedias, fix invalid (X)HTML, rm W3C 
icons
..


index: link largest/wikimedias, fix invalid (X)HTML, rm W3C icons

The previous footer (before switch to datatables/boostrap was
commented out the whole time. Add it back, partially.

Add links to the old but existing
largest / wikimedia tables that are here but not linked from index.

Remove what doesn't exist anymore ("coalesced").

Don't claim to be XHTML strict anymore, remove W3C Icons, link
to experimental HTML5 validator instead. Don't claim to be valid CSS
anymore (-> bootstrap).

Fix invalid HTML so that the W3C "Nu HTML Checker" is happy:

https://validator.w3.org/nu/?doc=https%3A%2F%2Fwikistats.wmflabs.org%2Findex.php

Change-Id: I910d6ed7e699f54d045d7d5d78be50657c80a3c3
---
M var/www/wikistats/index.php
1 file changed, 37 insertions(+), 46 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/var/www/wikistats/index.php b/var/www/wikistats/index.php
index e024833..3f6f11f 100644
--- a/var/www/wikistats/index.php
+++ b/var/www/wikistats/index.php
@@ -30,7 +30,7 @@
 header('Last-Modified: ' . getlastmod());
 header('Content-type: text/html; charset=utf-8');
 ?>
-http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd;>
+
 http://www.w3.org/1999/xhtml; lang="en" xml:lang="en">
 
 
@@ -61,7 +61,7 @@
 
 Wikistats 2.2
 
-[beta]
+[not-Analytics-Wikistats]
 
 
-
+
 
 
 List of MediaWikis
@@ -121,21 +121,7 @@
 Formats
 Last update
 
-
-
-
-Project
- of wikis
-Good articles
-Total pages
-Edits
-Files
-Users
-Admins
-Stub ratio
-Formats
-Last update
-
+
 ";
 
 
@@ -156,7 +142,7 @@
 while ($row = $fnord->fetch()) {
 $count++;
 $users = $row['gusers'];
-$gwikis = $gwikis + $row['numwikis'];
+$gwikis = gwikis + $row['numwikis'];
 $gtotal = $gtotal + $row['gtotal'];
 $ggood = $ggood + $row['ggood'];
 $gedits = $gedits + $row['gedits'];
@@ -206,6 +192,7 @@
 csv
 ssv
 xml";
+
 if ($project == 'wp') {
 echo "mwiki";
 } else {
@@ -300,39 +287,43 @@
 }
 
 
-echo "";
-
-$name = "coalesced";
-/*
-echo <
-
+
+http://validator.w3.org/check?uri=https://wikistats.wmflabs.org/index.php;>validate
 html
 FOOTER;
-
-# CSS Validator
-$selfurl = $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
-$selfurl = str_replace("&", "", $selfurl);
-echo <
-
-
-W3C;
-
-# Last Mod
-echo "Last modified: " . date("F d Y - H:i:s", getlastmod());
-echo "";
-*/
+echo "Last modified:";
+echo  date("F d Y - H:i:s", getlastmod());
+echo "";
 ?>
+

-- 
To view, visit https://gerrit.wikimedia.org/r/366999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I910d6ed7e699f54d045d7d5d78be50657c80a3c3
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: index: link largest/wikimedias, fix invalid (X)HTML, rm W3C ...

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366999 )

Change subject: index: link largest/wikimedias, fix invalid (X)HTML, rm W3C 
icons
..

index: link largest/wikimedias, fix invalid (X)HTML, rm W3C icons

The previous footer (before switch to datatables/boostrap was
commented out the whole time. Add it back, partially.

Add links to the old but existing
largest / wikimedia tables that are here but not linked from index.

Remove what doesn't exist anymore ("coalesced").

Don't claim to be XHTML strict anymore, remove W3C Icons, link
to experimental HTML5 validator instead. Don't claim to be valid CSS
anymore (-> bootstrap).

Fix invalid HTML so that the W3C "Nu HTML Checker" is happy:

https://validator.w3.org/nu/?doc=https%3A%2F%2Fwikistats.wmflabs.org%2Findex.php

Change-Id: I910d6ed7e699f54d045d7d5d78be50657c80a3c3
---
M var/www/wikistats/index.php
1 file changed, 37 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/wikistats 
refs/changes/99/366999/1

diff --git a/var/www/wikistats/index.php b/var/www/wikistats/index.php
index e024833..3f6f11f 100644
--- a/var/www/wikistats/index.php
+++ b/var/www/wikistats/index.php
@@ -30,7 +30,7 @@
 header('Last-Modified: ' . getlastmod());
 header('Content-type: text/html; charset=utf-8');
 ?>
-http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd;>
+
 http://www.w3.org/1999/xhtml; lang="en" xml:lang="en">
 
 
@@ -61,7 +61,7 @@
 
 Wikistats 2.2
 
-[beta]
+[not-Analytics-Wikistats]
 
 
-
+
 
 
 List of MediaWikis
@@ -121,21 +121,7 @@
 Formats
 Last update
 
-
-
-
-Project
- of wikis
-Good articles
-Total pages
-Edits
-Files
-Users
-Admins
-Stub ratio
-Formats
-Last update
-
+
 ";
 
 
@@ -156,7 +142,7 @@
 while ($row = $fnord->fetch()) {
 $count++;
 $users = $row['gusers'];
-$gwikis = $gwikis + $row['numwikis'];
+$gwikis = gwikis + $row['numwikis'];
 $gtotal = $gtotal + $row['gtotal'];
 $ggood = $ggood + $row['ggood'];
 $gedits = $gedits + $row['gedits'];
@@ -206,6 +192,7 @@
 csv
 ssv
 xml";
+
 if ($project == 'wp') {
 echo "mwiki";
 } else {
@@ -300,39 +287,43 @@
 }
 
 
-echo "";
-
-$name = "coalesced";
-/*
-echo <
-
+
+http://validator.w3.org/check?uri=https://wikistats.wmflabs.org/index.php;>validate
 html
 FOOTER;
-
-# CSS Validator
-$selfurl = $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
-$selfurl = str_replace("&", "", $selfurl);
-echo <
-
-
-W3C;
-
-# Last Mod
-echo "Last modified: " . date("F d Y - H:i:s", getlastmod());
-echo "";
-*/
+echo "Last modified:";
+echo  date("F d Y - H:i:s", getlastmod());
+echo "";
 ?>
+

-- 
To view, visit https://gerrit.wikimedia.org/r/366999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I910d6ed7e699f54d045d7d5d78be50657c80a3c3
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update: dim images in dark mode

2017-07-21 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366998 )

Change subject: Update: dim images in dark mode
..

Update: dim images in dark mode

Change-Id: Ic78c5b9a56bc6088e067cf2296b383a8c701f2cb
---
M app/src/main/assets/bundle.js
M app/src/main/assets/preview.js
M www/js/dark.js
3 files changed, 15 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/98/366998/1

diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 726c491..b5ddb1f 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -134,12 +134,13 @@
 var pagelib = require("wikimedia-page-library");
 
 bridge.registerListener( 'toggleDarkMode', function() {
-   var theme;
+var theme;
 
-   window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
 
-   theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK : 
pagelib.ThemeTransform.THEME.DEFAULT;
-   pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK : 
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
 } );
 
},{"./bridge":2,"wikimedia-page-library":20}],4:[function(require,module,exports){
 var transformer = require('./transformer');
diff --git a/app/src/main/assets/preview.js b/app/src/main/assets/preview.js
index 18f5cb3..69eefa5 100644
--- a/app/src/main/assets/preview.js
+++ b/app/src/main/assets/preview.js
@@ -134,12 +134,13 @@
 var pagelib = require("wikimedia-page-library");
 
 bridge.registerListener( 'toggleDarkMode', function() {
-   var theme;
+var theme;
 
-   window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
 
-   theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK : 
pagelib.ThemeTransform.THEME.DEFAULT;
-   pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK : 
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
 } );
 
},{"./bridge":2,"wikimedia-page-library":7}],4:[function(require,module,exports){
 var bridge = require("./bridge");
diff --git a/www/js/dark.js b/www/js/dark.js
index 6daad80..913ec7b 100644
--- a/www/js/dark.js
+++ b/www/js/dark.js
@@ -2,10 +2,11 @@
 var pagelib = require("wikimedia-page-library");
 
 bridge.registerListener( 'toggleDarkMode', function() {
-   var theme;
+var theme;
 
-   window.isDarkMode = !window.isDarkMode;
+window.isDarkMode = !window.isDarkMode;
 
-   theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK : 
pagelib.ThemeTransform.THEME.DEFAULT;
-   pagelib.ThemeTransform.setTheme( document, theme );
+theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK : 
pagelib.ThemeTransform.THEME.DEFAULT;
+pagelib.ThemeTransform.setTheme( document, theme );
+pagelib.DimImagesTransform.dim( window, window.isDarkMode );
 } );
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/366998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic78c5b9a56bc6088e067cf2296b383a8c701f2cb
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Sniedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Complete DatabaseDomain code coverage

2017-07-21 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366997 )

Change subject: rdbms: Complete DatabaseDomain code coverage
..

rdbms: Complete DatabaseDomain code coverage

Add missing coverage for:
* DatabaseDomain::equals()
* DatabaseDomain::newUnspecified()
* DatabaseDomain::__toString()

Change-Id: I38863c5652ec395e7194bfb85b3485e3343a3b7e
---
M tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php
1 file changed, 81 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/97/366997/1

diff --git a/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php 
b/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php
index 3dc7e28..a8dbdd3 100644
--- a/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php
+++ b/tests/phpunit/includes/libs/rdbms/database/DatabaseDomainTest.php
@@ -8,16 +8,20 @@
 class DatabaseDomainTest extends PHPUnit_Framework_TestCase {
public static function provideConstruct() {
return [
-   // All strings
-   [ 'foo', 'bar', 'baz', 'foo-bar-baz' ],
-   // Nothing
-   [ null, null, '', '' ],
-   // Invalid $database
-   [ 0, 'bar', '', '', true ],
-   // - in one of the fields
-   [ 'foo-bar', 'baz', 'baa', 'foo?hbar-baz-baa' ],
-   // ? in one of the fields
-   [ 'foo?bar', 'baz', 'baa', 'foo??bar-baz-baa' ],
+   'All strings' =>
+   [ 'foo', 'bar', 'baz', 'foo-bar-baz' ],
+   'Nothing' =>
+   [ null, null, '', '' ],
+   'Invalid $database' =>
+   [ 0, 'bar', '', '', true ],
+   'Invalid $schema' =>
+   [ 'foo', 0, '', '', true ],
+   'Invalid $prefix' =>
+   [ 'foo', 'bar', 0, '', true ],
+   'Dash' =>
+   [ 'foo-bar', 'baz', 'baa', 'foo?hbar-baz-baa' ],
+   'Question mark' =>
+   [ 'foo?bar', 'baz', 'baa', 'foo??bar-baz-baa' ],
];
}
 
@@ -27,6 +31,8 @@
public function testConstruct( $db, $schema, $prefix, $id, $exception = 
false ) {
if ( $exception ) {
$this->setExpectedException( 
InvalidArgumentException::class );
+   new DatabaseDomain( $db, $schema, $prefix );
+   return;
}
 
$domain = new DatabaseDomain( $db, $schema, $prefix );
@@ -35,23 +41,27 @@
$this->assertEquals( $schema, $domain->getSchema() );
$this->assertEquals( $prefix, $domain->getTablePrefix() );
$this->assertEquals( $id, $domain->getId() );
+   $this->assertEquals( $id, strval( $domain ), 'toString' );
}
 
public static function provideNewFromId() {
return [
-   // basic
-   [ 'foo', 'foo', null, '' ],
-   // -
-   [ 'foo-bar', 'foo', null, 'bar' ],
-   [ 'foo-bar-baz', 'foo', 'bar', 'baz' ],
-   // ?h -> -
-   [ 'foo?hbar-baz-baa', 'foo-bar', 'baz', 'baa' ],
-   // ?? -> ?
-   [ 'foo??bar-baz-baa', 'foo?bar', 'baz', 'baa' ],
-   // ? is left alone
-   [ 'foo?bar-baz-baa', 'foo?bar', 'baz', 'baa' ],
-   // too many parts
-   [ 'foo-bar-baz-baa', '', '', '', true ],
+   'Basic' =>
+   [ 'foo', 'foo', null, '' ],
+   'db+prefix' =>
+   [ 'foo-bar', 'foo', null, 'bar' ],
+   'db+schema+prefix' =>
+   [ 'foo-bar-baz', 'foo', 'bar', 'baz' ],
+   '?h -> -' =>
+   [ 'foo?hbar-baz-baa', 'foo-bar', 'baz', 'baa' ],
+   '?? -> ?' =>
+   [ 'foo??bar-baz-baa', 'foo?bar', 'baz', 'baa' ],
+   '? is left alone' =>
+   [ 'foo?bar-baz-baa', 'foo?bar', 'baz', 'baa' ],
+   'too many parts' =>
+   [ 'foo-bar-baz-baa', '', '', '', true ],
+   'from instance' =>
+   [ DatabaseDomain::newUnspecified(), null, null, 
'' ],
];
}
 
@@ -61,6 +71,8 @@
public function testNewFromId( $id, $db, $schema, $prefix,

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: fix rank.php calculations

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366996 )

Change subject: fix rank.php calculations
..


fix rank.php calculations

Fix various problems with the rank calculations
after switch to PDO.

Bug: T168474
Change-Id: I738ca1122ab7e031a7ce54c6b5f2b5acb6f1b389
---
M var/www/wikistats/rank.php
1 file changed, 9 insertions(+), 13 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Verified; Looks good to me, approved



diff --git a/var/www/wikistats/rank.php b/var/www/wikistats/rank.php
index ac9bf9f..fd4ba37 100644
--- a/var/www/wikistats/rank.php
+++ b/var/www/wikistats/rank.php
@@ -44,7 +44,7 @@
 die();
 }
 
-$count=1;
+$count=0;
 $arcount=0;
 $lang_check="FALSE";
 $languages=array();
@@ -154,19 +154,18 @@
 $query = "select id,prefix from ${table} where prefix is not null order by 
good desc,total desc";
 $fnord = $wdb->prepare($query);
 $fnord -> execute();
-$num_rows = $wdb->query($query)->fetchColumn();
 
 while ($row = $fnord->fetch()) {
 
+$count++;
 if ($row[prefix]==$lang) {
 $rank_project=$count;
-$number_project=$num_rows;
 }
-
-$count++;
 }
 
-$count=1;
+$number_project=$count;
+
+$count=0;
 
 $query = < execute();
 
-$num_rows = $wdb->query($query)->fetchColumn();
-
 while ($row = $fnord->fetch()) {
-
+$count++;
 if ($row[prefix]==$lang AND $row[type]==$table) {
 $rank_global=$count;
-$number_global=$num_rows;
 $type=$row[type];
 }
-
-$count++;
 }
 
-echo "$lang.$family $rank_project $number_project $rank_global 
$number_global\n";
+$number_global=$count;
 
+echo "$lang.$family $rank_project $number_project $rank_global 
$number_global\n\n";
+#echo "debug: lang.family $lang.$family rank_project: $rank_project 
number_project: $number_project rank_global: $rank_global number_global: 
$number_global\n";
 if ($rank_project==""){
 echo "\n! this language version does not seem to exist yet in this 
project";
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I738ca1122ab7e031a7ce54c6b5f2b5acb6f1b389
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...wikistats[master]: fix rank.php calculations

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366996 )

Change subject: fix rank.php calculations
..

fix rank.php calculations

Fix various problems with the rank calculations
after switch to PDO.

Bug: T168474
Change-Id: I738ca1122ab7e031a7ce54c6b5f2b5acb6f1b389
---
M var/www/wikistats/rank.php
1 file changed, 9 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/wikistats 
refs/changes/96/366996/1

diff --git a/var/www/wikistats/rank.php b/var/www/wikistats/rank.php
index ac9bf9f..fd4ba37 100644
--- a/var/www/wikistats/rank.php
+++ b/var/www/wikistats/rank.php
@@ -44,7 +44,7 @@
 die();
 }
 
-$count=1;
+$count=0;
 $arcount=0;
 $lang_check="FALSE";
 $languages=array();
@@ -154,19 +154,18 @@
 $query = "select id,prefix from ${table} where prefix is not null order by 
good desc,total desc";
 $fnord = $wdb->prepare($query);
 $fnord -> execute();
-$num_rows = $wdb->query($query)->fetchColumn();
 
 while ($row = $fnord->fetch()) {
 
+$count++;
 if ($row[prefix]==$lang) {
 $rank_project=$count;
-$number_project=$num_rows;
 }
-
-$count++;
 }
 
-$count=1;
+$number_project=$count;
+
+$count=0;
 
 $query = < execute();
 
-$num_rows = $wdb->query($query)->fetchColumn();
-
 while ($row = $fnord->fetch()) {
-
+$count++;
 if ($row[prefix]==$lang AND $row[type]==$table) {
 $rank_global=$count;
-$number_global=$num_rows;
 $type=$row[type];
 }
-
-$count++;
 }
 
-echo "$lang.$family $rank_project $number_project $rank_global 
$number_global\n";
+$number_global=$count;
 
+echo "$lang.$family $rank_project $number_project $rank_global 
$number_global\n\n";
+#echo "debug: lang.family $lang.$family rank_project: $rank_project 
number_project: $number_project rank_global: $rank_global number_global: 
$number_global\n";
 if ($rank_project==""){
 echo "\n! this language version does not seem to exist yet in this 
project";
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I738ca1122ab7e031a7ce54c6b5f2b5acb6f1b389
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/wikistats
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Check headers_sent() before sending cpPosTime headers

2017-07-21 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366995 )

Change subject: Check headers_sent() before sending cpPosTime headers
..

Check headers_sent() before sending cpPosTime headers

Some entry points stream output and flush their own headers.
This avoids "headers already send" warnings in some cases.

Change-Id: Ifb232d4575486749bbbccba88f3f688972fe9c20
---
M includes/MediaWiki.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/95/366995/1

diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php
index 4df4d76..413346f 100644
--- a/includes/MediaWiki.php
+++ b/includes/MediaWiki.php
@@ -616,7 +616,7 @@
$flags = $lbFactory::SHUTDOWN_CHRONPROT_ASYNC;
$cpPosTime = microtime( true );
// Client's next request should see 1+ positions with 
this DBMasterPos::asOf() time
-   if ( $urlDomainDistance === 'local' ) {
+   if ( $urlDomainDistance === 'local' && !headers_sent() 
) {
// Client will stay on this domain, so set an 
unobtrusive cookie
$expires = time() + 
ChronologyProtector::POSITION_TTL;
$options = [ 'prefix' => '' ];
@@ -633,7 +633,7 @@
// OutputPage::output() is fairly slow; run it in 
$postCommitWork to mask
// the latency of syncing DB positions accross all 
datacenters synchronously
$flags = $lbFactory::SHUTDOWN_CHRONPROT_SYNC;
-   if ( $lbFactory->hasOrMadeRecentMasterChanges( INF ) ) {
+   if ( $lbFactory->hasOrMadeRecentMasterChanges( INF ) && 
!headers_sent() ) {
$cpPosTime = microtime( true );
// Set a cookie in case the DB position store 
cannot sync accross datacenters.
// This will at least cover the common case of 
the user staying on the domain.

-- 
To view, visit https://gerrit.wikimedia.org/r/366995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb232d4575486749bbbccba88f3f688972fe9c20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on test.wikipedia.org and test2.wikipedia.org

2017-07-21 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366994 )

Change subject: Enable jQuery 3 on test.wikipedia.org and test2.wikipedia.org
..

Enable jQuery 3 on test.wikipedia.org and test2.wikipedia.org

Follows-up 3dce3fccfde.

Bug: T124742
Change-Id: I37a68472cf0ebd25d660215285dd725690800aa8
---
M wmf-config/InitialiseSettings.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/94/366994/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 6d7302b..0280987 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -14792,9 +14792,13 @@
 // --- VisualEditor end ---
 
 // Whether to use jQuery 3.x or keep using the 1.x series.
-// Temporarily disabled during testing of the feature, 2017-04-13.
+// Temporarily disabled during testing of the feature, 2017-04-13 – T124742.
 'wgUsejQueryThree' => [
-   'default' => false, // T124742
+   'default' => false,
+
+   // group 0
+   'testwiki' => true,
+   'test2wiki' => true,
 ],
 
 // Whether to use OOUI to render the buttons on EditPage.php

-- 
To view, visit https://gerrit.wikimedia.org/r/366994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37a68472cf0ebd25d660215285dd725690800aa8
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hiegyne: Remove unused global LESS vars wgMFThumbnailTiny an...

2017-07-21 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366993 )

Change subject: Hiegyne: Remove unused global LESS vars wgMFThumbnailTiny and 
wgMFThumbnailSmall
..

Hiegyne: Remove unused global LESS vars wgMFThumbnailTiny and wgMFThumbnailSmall

No matches in any other repo in Wikimedia Git, including commit messages.

Bug: T171365
Change-Id: I25246f1188a7c2e6c3a2e530efdabdc9001e90dc
---
M includes/MobileFrontend.hooks.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/93/366993/1

diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index 5a9ad14..b71ee66 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1034,8 +1034,6 @@
$lessVars = array_merge( $lessVars,
[
'wgMFDeviceWidthMobileSmall' => "{$config->get( 
'MFDeviceWidthMobileSmall' )}px",
-   'wgMFThumbnailTiny' =>  
MobilePage::TINY_IMAGE_WIDTH . 'px',
-   'wgMFThumbnailSmall' =>  
MobilePage::SMALL_IMAGE_WIDTH . 'px'
]
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25246f1188a7c2e6c3a2e530efdabdc9001e90dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...XenForoAuth[master]: Avoid deprecated ResourceLoaderGetLessVars hook

2017-07-21 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366992 )

Change subject: Avoid deprecated ResourceLoaderGetLessVars hook
..

Avoid deprecated ResourceLoaderGetLessVars hook

Bug: T140804
Change-Id: I92671613e23314875ec34941305f6a6d7266b827
---
M extension.json
M includes/Hooks.php
A includes/XenForoResourceLoaderModule.php
3 files changed, 18 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/XenForoAuth 
refs/changes/92/366992/1

diff --git a/extension.json b/extension.json
index 7a96e5c..155a660 100644
--- a/extension.json
+++ b/extension.json
@@ -20,7 +20,6 @@
"Hooks": {
"LoadExtensionSchemaUpdates": 
"XenForoAuth\\Hooks::onLoadExtensionSchemaUpdates",
"AuthChangeFormFields": 
"XenForoAuth\\Hooks::onAuthChangeFormFields",
-   "ResourceLoaderGetLessVars": 
"XenForoAuth\\Hooks::onResourceLoaderGetLessVars"
},
"AutoloadClasses": {
"XenForoAuth\\Auth\\XenForoPrimaryAuthenticationProvider": 
"includes/auth/XenForoPrimaryAuthenticationProvider.php",
@@ -30,7 +29,8 @@
"XenForoAuth\\Auth\\XenForoUserInfoAuthenticationRequest": 
"includes/auth/XenForoUserInfoAuthenticationRequest.php",
"XenForoAuth\\HTMLXenForoButtonField": 
"includes/htmlform/HTMLXenForoButtonField.php",
"XenForoAuth\\XenForoUser": "includes/XenForoUser.php",
-   "XenForoAuth\\Hooks": "includes/Hooks.php"
+   "XenForoAuth\\Hooks": "includes/Hooks.php",
+   "XenForoAuth\\XenForoResourceLoaderModule": 
"includes/XenForoResourceLoaderModule.php"
},
"AuthManagerAutoConfig": {
"primaryauth": {
@@ -42,6 +42,7 @@
},
"ResourceModules": {
"ext.XenForo.userlogincreate.style": {
+   "class": "XenForoAuth\\XenForoResourceLoaderModule",
"styles": "style/ext.XenForo.userlogincreate.less",
"position": "top",
"targets": [
@@ -50,6 +51,7 @@
]
},
"ext.XenForo.userlogincreate.ooui.style": {
+   "class": "XenForoAuth\\XenForoResourceLoaderModule",
"styles": "style/ext.XenForo.userlogincreate.ooui.less",
"position": "top",
"targets": [
diff --git a/includes/Hooks.php b/includes/Hooks.php
index b389001..29549f3 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -46,19 +46,4 @@
unset( $formDescriptor['xenforoauth']['type'] );
}
}
-
-   /**
-* ResourceLoaderGetLessVars hook handler
-*
-* @see 
https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetLessVars
-* @param array &$lessVars Variables already added
-*/
-   public static function onResourceLoaderGetLessVars( &$lessVars ) {
-   $config = 
MediaWikiServices::getInstance()->getConfigFactory()->makeConfig( 'xenforoauth' 
);
-   $lessVars = array_merge( $lessVars,
-   [
-   'wgXenForoAuthButtonIcon' => $config->get( 
'XenForoAuthButtonIcon' )
-   ]
-   );
-   }
 }
diff --git a/includes/XenForoResourceLoaderModule.php 
b/includes/XenForoResourceLoaderModule.php
new file mode 100644
index 000..e1d9a78
--- /dev/null
+++ b/includes/XenForoResourceLoaderModule.php
@@ -0,0 +1,14 @@
+getConfig()->get( 
'XenForoAuthButtonIcon' );
+   return $vars;
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/366992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92671613e23314875ec34941305f6a6d7266b827
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/XenForoAuth
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Soft-deprecate use of global LESS variables

2017-07-21 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366990 )

Change subject: resourceloader: Soft-deprecate use of global LESS variables
..

resourceloader: Soft-deprecate use of global LESS variables

Add deprecation notice to $wgResourceLoaderLESSVars and
hook 'ResourceLoaderGetLessVars'. Warnings to be added in 1.31.

Migrate to exposing variables via the individual module's getLessVars()
method.
- Ensures better cache invalidation.
- Separates concerns from getting information and exposing information
  as less variables. And allows an extension to, for example, use a different
  variable name for somethign if needed.

The 'deviceWidthTablet' variable will need to be migrated to
either a regular configuration variable that individual modules
can expose in their getLessVars() method - or, alternatively, we
can deprecate it alltogether in favour of exposing it through
a less import file instead (see T112747). That would mean, however,
that the value can only be changed in core, not by site config.

Bug: T140804
Change-Id: I61cff1d9652d88dc53c43075dd5053b7707809e6
---
M docs/hooks.txt
M includes/DefaultSettings.php
2 files changed, 9 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/366990/1

diff --git a/docs/hooks.txt b/docs/hooks.txt
index 3ff3365..7e8539e 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -2764,9 +2764,10 @@
 or request state must be added through MakeGlobalVariablesScript instead.
 &$vars: array( variable name => value )
 
-'ResourceLoaderGetLessVars': Called in ResourceLoader::getLessVars after
-variables from $wgResourceLoaderLESSVars are added. Can be used to add
-context-based variables.
+'ResourceLoaderGetLessVars': DEPRECATED! Called in ResourceLoader::getLessVars
+to add global LESS variable. Loaded after $wgResourceLoaderLESSVars is added.
+Global LESS variables are deprecated. Use ResourceLoaderModule::getLessVars()
+instead to expose variables only in modules that need them.
 &$lessVars: array of variables already added
 
 'ResourceLoaderJqueryMsgModuleMagicWords': Called in
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index f35715e..83c2391 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -3754,20 +3754,18 @@
  * at the beginning of all your .less files, with all the consequences.
  * In particular, string values must be escaped and quoted.
  *
- * Changes to LESS variables do not trigger cache invalidation.
- *
- * If the LESS variables need to be dynamic, you can use the
- * ResourceLoaderGetLessVars hook (since 1.25).
+ * Changes to this configuration does NOT trigger cache invalidation.
  *
  * @par Example:
  * @code
  *   $wgResourceLoaderLESSVars = [
- * 'baseFontSize'  => '1em',
- * 'smallFontSize' => '0.75em',
- * 'WikimediaBlue' => '#006699',
+ * 'exampleFontSize'  => '1em',
+ * 'exampleBlue' => '#eee',
  *   ];
  * @endcode
  * @since 1.22
+ * @deprecated since 1.30 Use ResourceLoaderModule::getLessVars() instead to
+ *  add variables to individual modules that need them.
  */
 $wgResourceLoaderLESSVars = [
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/366990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61cff1d9652d88dc53c43075dd5053b7707809e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Add 'boolean' group

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366511 )

Change subject: RCFilters: Add 'boolean' group
..


RCFilters: Add 'boolean' group

The group allows filters to be represented 'directly' with their
selected values corresponding to their parameter "1" or "0" value.

Change-Id: I56e9b52ff79a46227de71c905b2ecd97a3823624
---
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.ItemModel.js
M tests/qunit/suites/resources/mediawiki.rcfilters/dm.FiltersViewModel.test.js
4 files changed, 166 insertions(+), 38 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
index 9a85291..8bedd68 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
@@ -52,6 +52,7 @@
 
this.conflicts = config.conflicts || {};
this.defaultParams = {};
+   this.defaultFilters = {};
 
this.aggregate( { update: 'filterItemUpdate' } );
this.connect( this, { filterItemUpdate: 'onFilterItemUpdate' } 
);
@@ -89,6 +90,7 @@
var subsetNames = [],
filterItem = new mw.rcfilters.dm.FilterItem( 
filter.name, model, {
group: model.getName(),
+   useDefaultAsBaseValue: 
!!filter.useDefaultAsBaseValue,
label: filter.label || filter.name,
description: filter.description || '',
labelPrefixKey: model.labelPrefixKey,
@@ -131,7 +133,10 @@
items.push( filterItem );
 
// Store default parameter state; in this case, default 
is defined per filter
-   if ( model.getType() === 'send_unselected_if_any' ) {
+   if (
+   model.getType() === 'send_unselected_if_any' ||
+   model.getType() === 'boolean'
+   ) {
// Store the default parameter state
// For this group type, parameter values are 
direct
// We need to convert from a boolean to a 
string ('1' and '0')
@@ -176,6 +181,25 @@
// or select the first option
this.selectItemByParamName( defaultParam );
}
+
+   // Store default filter state based on default params
+   this.defaultFilters = this.getFilterRepresentation( 
this.getDefaultParams() );
+
+   // Check for filters that should be initially selected by their 
default value
+   this.getItems().forEach( function ( item ) {
+   if (
+   item.isUsingDefaultAsBaseValue() &&
+   (
+   // This setting can only be applied to 
these groups
+   // the other groups are way too complex 
for that
+   model.getType() === 'single_option' ||
+   model.getType() === 'boolean'
+   )
+   ) {
+   // Apply selection
+   item.toggleSelected( !!model.defaultFilters[ 
item.getName() ] );
+   }
+   } );
};
 
/**
@@ -251,6 +275,15 @@
 */
mw.rcfilters.dm.FilterGroup.prototype.getDefaultParams = function () {
return this.defaultParams;
+   };
+
+   /**
+* Get the default filter state of this group
+*
+* @return {Object} Default filter state
+*/
+   mw.rcfilters.dm.FilterGroup.prototype.getDefaultFilters = function () {
+   return this.defaultFilters;
};
 
/**
@@ -448,6 +481,7 @@
var values,
areAnySelected = false,
buildFromCurrentState = !filterRepresentation,
+   defaultFilters = this.getDefaultFilters(),
result = {},
model = this,
filterParamNames = {},
@@ -480,8 +514,22 @@
} else if ( !filterRepresentation[ item.getName() ] ) {
// We are given a filter representation, but we 
have

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix service dependency name for update service

2017-07-21 Thread Smalyshev (Code Review) 
Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366989 )

Change subject: Fix service dependency name for update service
..

Fix service dependency name for update service

Bug: T168918
Change-Id: I951e941a6133719c07ecc557ab41d01a4860d4a8
---
M modules/wdqs/templates/initscripts/wdqs-updater.systemd.erb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/89/366989/1

diff --git a/modules/wdqs/templates/initscripts/wdqs-updater.systemd.erb 
b/modules/wdqs/templates/initscripts/wdqs-updater.systemd.erb
index ac4d86d..8af36c2 100644
--- a/modules/wdqs/templates/initscripts/wdqs-updater.systemd.erb
+++ b/modules/wdqs/templates/initscripts/wdqs-updater.systemd.erb
@@ -1,7 +1,7 @@
 [Unit]
 Description=Wikidate Query Service Updater
-Wants=wdqs-blazegraph
-After=wdqs-blazegraph
+Wants=wdqs-blazegraph.service
+After=wdqs-blazegraph.service
 AssertPathExists=<%= @data_dir %>/wikidata.jnl
 ConditionPathExists=<%= @data_dir %>/data_loaded
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I951e941a6133719c07ecc557ab41d01a4860d4a8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Parser on skins other than DefaultSkins

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366988 )

Change subject: Parser on skins other than DefaultSkins
..

Parser on skins other than DefaultSkins

the last piece of the puzzle...

Someone more familiar with this code should feel free to fold this
into Legoktm's patch in a sane way...

Bug: T170880
Change-Id: I173b060765ebf67d009bdfb65cf60d7eb13bd4f5
---
M includes/parser/ParserOutput.php
M tests/parser/ParserTestRunner.php
2 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/366988/1

diff --git a/includes/parser/ParserOutput.php b/includes/parser/ParserOutput.php
index 10ac192..bad1614 100644
--- a/includes/parser/ParserOutput.php
+++ b/includes/parser/ParserOutput.php
@@ -23,6 +23,11 @@
  */
 class ParserOutput extends CacheTime {
/**
+* @var Skin $skin
+*/
+   protected $skin;
+
+   /**
 * @var string $mText The output text
 */
public $mText;
@@ -249,13 +254,21 @@
return $this->mText;
}
 
+   /**
+* set the skin associated with the parse
+* @param Skin $skin
+*/
+   public function setSkin( Skin $skin ) {
+   $this->skin = $skin;
+   }
+
public function getText() {
$text = $this->mText;
if ( $this->mEditSectionTokens ) {
$text = preg_replace_callback(
ParserOutput::EDITSECTION_REGEX,
function ( $m ) {
-   global $wgOut, $wgLang;
+   global $wgLang;
$editsectionPage = Title::newFromText( 
htmlspecialchars_decode( $m[1] ) );
$editsectionSection = 
htmlspecialchars_decode( $m[2] );
$editsectionContent = isset( $m[4] ) ? 
$m[3] : null;
@@ -264,7 +277,11 @@
throw new MWException( "Bad 
parser output text." );
}
 
-   $skin = $wgOut->getSkin();
+   $skin = $this->skin;
+   if ( !$skin ) {
+   global $wgOut;
+   $wgOut->getSkin();
+   }
return call_user_func_array(
[ $skin, 'doEditSectionLink' ],
[ $editsectionPage, 
$editsectionSection,
diff --git a/tests/parser/ParserTestRunner.php 
b/tests/parser/ParserTestRunner.php
index b225a49..d68b7ad 100644
--- a/tests/parser/ParserTestRunner.php
+++ b/tests/parser/ParserTestRunner.php
@@ -823,6 +823,7 @@
$local = isset( $opts['local'] );
$preprocessor = isset( $opts['preprocessor'] ) ? 
$opts['preprocessor'] : null;
$parser = $this->getParser( $preprocessor );
+   $parser->setSkin( new DefaultSkin() );
$title = Title::newFromText( $titleText );
 
if ( isset( $opts['pst'] ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/366988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I173b060765ebf67d009bdfb65cf60d7eb13bd4f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Expose content model in response

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366909 )

Change subject: Expose content model in response
..


Expose content model in response

Certain pages are not wikitext. This flags those to the client.
e.g.
meta.wikimedia.org/wiki/Schema:RelatedArticles

Change-Id: Idb67a564a386cad86a5412cf5f0d885bb2e56bd7
---
M lib/mwapi.js
M routes/mobile-sections.js
M test/features/mobile-sections-lead/pagecontent.js
3 files changed, 16 insertions(+), 1 deletion(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/mwapi.js b/lib/mwapi.js
index d092d2b..0ade581 100644
--- a/lib/mwapi.js
+++ b/lib/mwapi.js
@@ -123,7 +123,7 @@
 mwapi.getMetadata = function(app, req) {
 const props = ['languagecount', 'thumb', 'image', 'id', 'revision', 
'description',
 'lastmodified', 'lastmodifiedby', 'normalizedtitle', 'displaytitle', 
'protection',
-'editable', 'namespace', 'pageprops'];
+'editable', 'namespace', 'pageprops', 'contentmodel'];
 
 const query = {
 action: 'mobileview',
diff --git a/routes/mobile-sections.js b/routes/mobile-sections.js
index 719a6a5..efbd0a0 100644
--- a/routes/mobile-sections.js
+++ b/routes/mobile-sections.js
@@ -101,6 +101,10 @@
 let sections;
 let text;
 let disambiguation;
+let contentmodel;
+if (input.meta.contentmodel !== 'wikitext') {
+contentmodel = input.meta.contentmodel;
+}
 if (input.meta.pageprops && input.meta.pageprops.disambiguation !== 
undefined) {
 disambiguation = true;
 }
@@ -120,6 +124,7 @@
 
 return {
 ns: input.meta.ns,
+contentmodel,
 userinfo: input.meta.userinfo,
 imageinfo: input.meta.imageinfo,
 id: input.meta.id,
diff --git a/test/features/mobile-sections-lead/pagecontent.js 
b/test/features/mobile-sections-lead/pagecontent.js
index 95a612f..827baf2 100644
--- a/test/features/mobile-sections-lead/pagecontent.js
+++ b/test/features/mobile-sections-lead/pagecontent.js
@@ -284,4 +284,14 @@
 'Disambiguation flag is missing in meta data.');
 });
 });
+it('Content model present in response', () => {
+const title = 'Schema:RelatedArticles';
+const uri = 
`${server.config.uri}meta.wikimedia.org/v1/page/mobile-sections-lead/${title}`;
+return preq.get({ uri })
+.then((res) => {
+assert.deepEqual(res.status, 200);
+assert.ok(res.body.contentmodel === 'JsonSchema',
+'Article flagged as a JsonSchema.');
+});
+});
 });

-- 
To view, visit https://gerrit.wikimedia.org/r/366909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb67a564a386cad86a5412cf5f0d885bb2e56bd7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: Update GUI

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366985 )

Change subject: Update GUI
..


Update GUI

Change-Id: I22999aeff9ffbe65a64c9db7f390d556a471f29c
---
M gui
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/gui b/gui
index f9380cc..a4b827d 16
--- a/gui
+++ b/gui
@@ -1 +1 @@
-Subproject commit f9380cc6e3cef74d9c53bf76c8015a81fb239eb8
+Subproject commit a4b827d58051f019cc401ae5e0cb85ae63ed2c91

-- 
To view, visit https://gerrit.wikimedia.org/r/366985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22999aeff9ffbe65a64c9db7f390d556a471f29c
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Smalyshev 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui-deploy[production]: Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:

2017-07-21 Thread Smalyshev (Code Review) 
Smalyshev has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366986 )

Change subject: Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:
..


Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:

Merge "Swap buttons Help and Tools in header toolbar"

Change-Id: I605586c915f93406940215d01cac1594e8da84d9
---
R css/embed.style.min.6a2554cbe7455d13d75d.css
R css/style.min.b66b9e8037bbeca333b1.css
M embed.html
M i18n/en.json
M i18n/qqq.json
M index.html
R js/embed.wdqs.min.e6834e8cf4eeb6c9b6c2.js
A js/vendor.min.263f5fcc4546fbb91430.js
D js/vendor.min.cd7ae247632fc4e29f3b.js
D js/wdqs.min.a71d98bb33e70ce4c279.js
A js/wdqs.min.be3d42bc7fa6d7dda18b.js
11 files changed, 13 insertions(+), 10 deletions(-)

Approvals:
  Smalyshev: Verified; Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/366986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I605586c915f93406940215d01cac1594e8da84d9
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui-deploy
Gerrit-Branch: production
Gerrit-Owner: Smalyshev 
Gerrit-Reviewer: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add stylelint dependency

2017-07-21 Thread Smalyshev (Code Review) 
Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366987 )

Change subject: Add stylelint dependency
..

Add stylelint dependency

Bug: T171358
Change-Id: Ibcb0758aaedf3f7b3ddb59269fead2af16d5dbea
---
M package.json
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/87/366987/1

diff --git a/package.json b/package.json
index e7fa2f5..5dd4770 100644
--- a/package.json
+++ b/package.json
@@ -65,6 +65,7 @@
 "load-grunt-tasks": "^3.5.2",
 "qunitjs": "1.23.1",
 "sinon": "^2.3.6",
+"stylelint": "7.8.0",
 "stylelint-config-wikimedia": "0.4.1"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcb0758aaedf3f7b3ddb59269fead2af16d5dbea
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui-deploy[production]: Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:

2017-07-21 Thread Smalyshev (Code Review) 
Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366986 )

Change subject: Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:
..

Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:

Merge "Swap buttons Help and Tools in header toolbar"

Change-Id: I605586c915f93406940215d01cac1594e8da84d9
---
R css/embed.style.min.6a2554cbe7455d13d75d.css
R css/style.min.b66b9e8037bbeca333b1.css
M embed.html
M i18n/en.json
M i18n/qqq.json
M index.html
R js/embed.wdqs.min.e6834e8cf4eeb6c9b6c2.js
A js/vendor.min.263f5fcc4546fbb91430.js
D js/vendor.min.cd7ae247632fc4e29f3b.js
D js/wdqs.min.a71d98bb33e70ce4c279.js
A js/wdqs.min.be3d42bc7fa6d7dda18b.js
11 files changed, 13 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui-deploy 
refs/changes/86/366986/1


-- 
To view, visit https://gerrit.wikimedia.org/r/366986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I605586c915f93406940215d01cac1594e8da84d9
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui-deploy
Gerrit-Branch: production
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: Update GUI

2017-07-21 Thread Smalyshev (Code Review) 
Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366985 )

Change subject: Update GUI
..

Update GUI

Change-Id: I22999aeff9ffbe65a64c9db7f390d556a471f29c
---
M gui
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf 
refs/changes/85/366985/1

diff --git a/gui b/gui
index f9380cc..a4b827d 16
--- a/gui
+++ b/gui
@@ -1 +1 @@
-Subproject commit f9380cc6e3cef74d9c53bf76c8015a81fb239eb8
+Subproject commit a4b827d58051f019cc401ae5e0cb85ae63ed2c91

-- 
To view, visit https://gerrit.wikimedia.org/r/366985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22999aeff9ffbe65a64c9db7f390d556a471f29c
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui-deploy[production]: Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:

2017-07-21 Thread Smalyshev (Code Review) 
Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366984 )

Change subject: Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:
..

Merging from a4b827d58051f019cc401ae5e0cb85ae63ed2c91:

Merge "Swap buttons Help and Tools in header toolbar"

Change-Id: Ib2756e09d37f26d67cde5e5493c39a0557d994b7
---
A block.html
R css/embed.style.min.6a2554cbe7455d13d75d.css
R css/style.min.b66b9e8037bbeca333b1.css
M embed.html
M i18n/en.json
M i18n/qqq.json
M index.html
R js/embed.wdqs.min.e6834e8cf4eeb6c9b6c2.js
A js/vendor.min.263f5fcc4546fbb91430.js
D js/vendor.min.cd7ae247632fc4e29f3b.js
D js/wdqs.min.a71d98bb33e70ce4c279.js
A js/wdqs.min.be3d42bc7fa6d7dda18b.js
12 files changed, 14 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui-deploy 
refs/changes/84/366984/1


-- 
To view, visit https://gerrit.wikimedia.org/r/366984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2756e09d37f26d67cde5e5493c39a0557d994b7
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui-deploy
Gerrit-Branch: production
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: install_server: Add new partman recipe for labstore100[1-2]

2017-07-21 Thread Madhuvishy (Code Review) 
Madhuvishy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366977 )

Change subject: install_server: Add new partman recipe for labstore100[1-2]
..


install_server: Add new partman recipe for labstore100[1-2]

Bug: T158196
Change-Id: If1e36ffaae3cfc15f7718d3d53bbb98b028c13e3
---
M modules/install_server/files/autoinstall/netboot.cfg
A modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg
2 files changed, 49 insertions(+), 0 deletions(-)

Approvals:
  Madhuvishy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/install_server/files/autoinstall/netboot.cfg 
b/modules/install_server/files/autoinstall/netboot.cfg
index 97aa3b2..d7eadf2 100755
--- a/modules/install_server/files/autoinstall/netboot.cfg
+++ b/modules/install_server/files/autoinstall/netboot.cfg
@@ -99,6 +99,7 @@
 labsdb[1-3]|labsdb100[1-3]) echo partman/mw.cfg ;; \
 sodium) echo partman/lvm-ext-srv.cfg ;; \
 labpuppetmaster100[12]|labnet100[34]|labnodepool1002|labweb100[12]) 
echo partman/raid1-lvm-ext4-srv-noswap.cfg;; \
+labstore100[1-2]) echo partman/labstore-lvm-noraid-swap.cfg ;; \
 labstore200[1-4]) echo partman/labstore-lvm-noraid.cfg ;; \
 labtestneutron2001) echo partman/mw.cfg ;; \
 labtestnet2001) echo partman/raid1.cfg ;; \
diff --git 
a/modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg 
b/modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg
new file mode 100644
index 000..c45aca5
--- /dev/null
+++ 
b/modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg
@@ -0,0 +1,48 @@
+# configuration to create:
+#  * no RAID (either single disk or hardware raid presenting a single device)
+*  ** 80G / ext4 outside lvm
+#  ** 8G swap
+#  ** the rest as ext4 on /srv
+
+
+d-ipartman-auto/method string  lvm
+d-ipartman-auto/disk   string  /dev/sda
+
+# the install makes sure we want to wipe the lvm
+d-ipartman-lvm/device_remove_lvm   boolean true
+d-ipartman-lvm/confirm boolean true
+d-ipartman-lvm/confirm_nooverwrite true
+
+d-ipartman/confirm_nooverwrite true
+d-ipartman/choose_partitionselect  finish
+
+d-ipartman-auto/expert_recipe  string  es ::   \
+   8 2 8 ext4  \
+   $primary{ } \
+   $bootable{ }\
+   method{ format }\
+   format{ }   \
+   use_filesystem{ }   \
+   filesystem{ ext4 }  \
+   mountpoint{ / } \
+   .   \
+   8000 8000 8000 linux-swap   \
+   method{ swap }  \
+   $lvmok{ }   \
+   format{ }   \
+   .   \
+   64 1000 1000 ext4   \
+   $primary{ } \
+   method{ format }\
+   format{ }   \
+   use_filesystem{ }   \
+   filesystem{ ext4 }  \
+   lv_name{ data } \
+   $defaultignore{ }   \
+   $lvmok{ }   \
+   mountpoint{ /srv }  \
+   .
+
+d-ipartman-auto-lvm/guided_sizestring  80%
+
+d-ipartman-auto/choose_recipe  es

-- 
To view, visit https://gerrit.wikimedia.org/r/366977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1e36ffaae3cfc15f7718d3d53bbb98b028c13e3
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Madhuvishy 
Gerrit-Reviewer: Madhuvishy 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: Show the hostname in error messages

2017-07-21 Thread Tim Starling (Code Review) 
Tim Starling has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366983 )

Change subject: Show the hostname in error messages
..

Show the hostname in error messages

It's helpful for the system administrator to know which PC server is
giving connection errors and the like.

Error messages from the core will not give the hostname, but they are
less likely to be specific to a PC server.

Bug: T65027
Change-Id: Ic8bfc927b6fa6086b7ae9cc694e848f5808ff58b
---
M PoolCounterClient_body.php
M PoolCounter_ConnectionManager.php
M i18n/en.json
M i18n/qqq.json
4 files changed, 24 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PoolCounter 
refs/changes/83/366983/1

diff --git a/PoolCounterClient_body.php b/PoolCounterClient_body.php
index 52066e9..07a51c8 100644
--- a/PoolCounterClient_body.php
+++ b/PoolCounterClient_body.php
@@ -8,6 +8,11 @@
private $conn;
 
/**
+* @var string The server host name
+*/
+   private $hostName;
+
+   /**
 * @var PoolCounter_ConnectionManager
 */
static private $manager;
@@ -35,7 +40,8 @@
if ( !$status->isOK() ) {
return $status;
}
-   $this->conn = $status->value;
+   $this->conn = $status->value['conn'];
+   $this->hostName = $status->value['hostName'];
 
// Set the read timeout to be 1.5 times the pool 
timeout.
// This allows the server to time out gracefully before 
we give up on it.
@@ -58,11 +64,11 @@
$conn = $status->value;
wfDebug( "Sending pool counter command: $cmd\n" );
if ( fwrite( $conn, "$cmd\n" ) === false ) {
-   return Status::newFatal( 'poolcounter-write-error' );
+   return Status::newFatal( 'poolcounter-write-error', 
$this->hostName );
}
$response = fgets( $conn );
if ( $response === false ) {
-   return Status::newFatal( 'poolcounter-read-error' );
+   return Status::newFatal( 'poolcounter-read-error', 
$this->hostName );
}
$response = rtrim( $response, "\r\n" );
wfDebug( "Got pool counter response: $response\n" );
@@ -85,7 +91,7 @@
default:
$parts = explode( ' ', $parts[1], 2 );
$errorMsg = isset( $parts[1] ) ? $parts[1] : 
'(no message given)';
-   return Status::newFatal( 
'poolcounter-remote-error', $errorMsg );
+   return Status::newFatal( 
'poolcounter-remote-error', $errorMsg, $this->hostName );
}
return Status::newGood( constant( "PoolCounter::$responseType" 
) );
}
diff --git a/PoolCounter_ConnectionManager.php 
b/PoolCounter_ConnectionManager.php
index a1f5b62..91df439 100644
--- a/PoolCounter_ConnectionManager.php
+++ b/PoolCounter_ConnectionManager.php
@@ -29,12 +29,13 @@
$hashes[$hostName] = md5( $hostName . $key );
}
asort( $hashes );
-   $errno = $errstr = '';
+   $errno = $errstr = $hostName = '';
$conn = null;
foreach ( $hashes as $hostName => $hash ) {
if ( isset( $this->conns[$hostName] ) ) {
$this->refCounts[$hostName]++;
-   return Status::newGood( $this->conns[$hostName] 
);
+   return Status::newGood(
+   [ 'conn' => $this->conns[$hostName], 
'hostName' => $hostName ] );
}
$parts = explode( ':', $hostName, 2 );
if ( count( $parts ) < 2 ) {
@@ -48,12 +49,12 @@
}
}
if ( !$conn ) {
-   return Status::newFatal( 
'poolcounter-connection-error', $errstr );
+   return Status::newFatal( 
'poolcounter-connection-error', $errstr, $hostName );
}
wfDebug( "Connected to pool counter server: $hostName\n" );
$this->conns[$hostName] = $conn;
$this->refCounts[$hostName] = 1;
-   return Status::newGood( $conn );
+   return Status::newGood( [ 'conn' => $conn, 'hostName' => 
$hostName ] );
}
 
/**
diff --git a/i18n/en.json b/i18n/en.json
index 2190e6a..10e180a 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -5,8 +5,8 @@
]
},
"poolcounter-desc": "MediaWiki client for the pool counter daemon",
-

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: integrate page-library red links transform

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366744 )

Change subject: Hygiene: integrate page-library red links transform
..


Hygiene: integrate page-library red links transform

Bug: T165419
Change-Id: Ia1165e6b3800289bac5948d476f1db498b339d3d
---
M app/src/main/assets/bundle.js
M www/js/sections.js
D www/js/transforms/service/hideRedLinks.js
3 files changed, 10 insertions(+), 35 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index b8df1ec..9dafacd 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -91,7 +91,7 @@
 
 module.exports = new ActionsHandler();
 
-},{"./bridge":2,"./utilities":20}],2:[function(require,module,exports){
+},{"./bridge":2,"./utilities":19}],2:[function(require,module,exports){
 function Bridge() {
 }
 
@@ -141,7 +141,7 @@
theme = window.isDarkMode ? pagelib.ThemeTransform.THEME.DARK : 
pagelib.ThemeTransform.THEME.DEFAULT;
pagelib.ThemeTransform.setTheme( document, theme );
 } );
-},{"./bridge":2,"wikimedia-page-library":21}],4:[function(require,module,exports){
+},{"./bridge":2,"wikimedia-page-library":20}],4:[function(require,module,exports){
 var transformer = require('./transformer');
 
 transformer.register( 'displayDisambigLink', function( content ) {
@@ -443,7 +443,7 @@
 if (isLeadSection) {
 transformer.transform( "moveFirstGoodParagraphUp" );
 }
-transformer.transform( "hideRedLinks", content );
+pagelib.RedLinks.hideRedLinks( document, content );
 transformer.transform( "anchorPopUpMediaTransforms", content );
 transformer.transform( "hideIPA", content );
 } else {
@@ -687,7 +687,7 @@
 bridge.sendMessage( "currentSectionResponse", { sectionID: 
getCurrentSection() } );
 } );
 
-},{"./bridge":2,"./onclick":8,"./transformer":12,"wikimedia-page-library":21}],12:[function(require,module,exports){
+},{"./bridge":2,"./onclick":8,"./transformer":12,"wikimedia-page-library":20}],12:[function(require,module,exports){
 function Transformer() {
 }
 
@@ -741,7 +741,7 @@
 handleTableCollapseOrExpandClick: toggleCollapseClickCallback
 };
 
-},{"../transformer":12,"wikimedia-page-library":21}],14:[function(require,module,exports){
+},{"../transformer":12,"wikimedia-page-library":20}],14:[function(require,module,exports){
 var transformer = require("../transformer");
 var collapseTables = require("./collapseTables");
 
@@ -872,19 +872,6 @@
 
},{"../../bridge":2,"../../transformer":12}],17:[function(require,module,exports){
 var transformer = require("../../transformer");
 
-transformer.register( "hideRedLinks", function( content ) {
-var redLinks = content.querySelectorAll( 'a.new' );
-for ( var i = 0; i < redLinks.length; i++ ) {
-var redLink = redLinks[i];
-var replacementSpan = document.createElement( 'span' );
-replacementSpan.innerHTML = redLink.innerHTML;
-replacementSpan.setAttribute( 'class', redLink.getAttribute( 'class' ) 
);
-redLink.parentNode.replaceChild( replacementSpan, redLink );
-}
-} );
-},{"../../transformer":12}],18:[function(require,module,exports){
-var transformer = require("../../transformer");
-
 // Move the first non-empty paragraph (and related elements) to the top of the 
section.
 // This will have the effect of shifting the infobox and/or any images at the 
top of the page
 // below the first paragraph, allowing the user to start reading the page 
right away.
@@ -966,7 +953,7 @@
 }
 }
 
-},{"../../transformer":12}],19:[function(require,module,exports){
+},{"../../transformer":12}],18:[function(require,module,exports){
 var maybeWidenImage = 
require('wikimedia-page-library').WidenImage.maybeWidenImage;
 var transformer = require("../transformer");
 
@@ -988,7 +975,7 @@
 }
 } );
 
-},{"../transformer":12,"wikimedia-page-library":21}],20:[function(require,module,exports){
+},{"../transformer":12,"wikimedia-page-library":20}],19:[function(require,module,exports){
 function ancestorContainsClass( element, className ) {
 var contains = false;
 var curNode = element;
@@ -1037,7 +1024,7 @@
 firstDivAncestor: firstDivAncestor
 };
 
-},{}],21:[function(require,module,exports){
+},{}],20:[function(require,module,exports){
 (function (global, factory) {
typeof exports === 'object' && typeof module !== 'undefined' ? 
module.exports = factory() :
typeof define === 'function' && define.amd ? define(factory) :
@@ -2412,4 +2399,4 @@
 })));
 
 
-},{}]},{},[2,7,20,12,13,14,19,15,16,17,18,1,4,5,6,3,9,10,11]);
+},{}]},{},[2,7,19,12,13,14,18,15,16,17,1,4,5,6,3,9,10,11]);
diff --git a/www/js/sections.js b/www/js/sections.js
index 2e04988..2581a0f 100644
--- a/www/js/sections.js
+++ b/www/js/sections.js
@@ -180,7 +180,7 @@
 if (isLeadSection) {

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: Update project name for XTools

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366786 )

Change subject: Update project name for XTools
..


Update project name for XTools

Bug: T171265
Change-Id: I4a939a8c292368cb46676b183723b30fe8e00a3e
---
M channels.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  BryanDavis: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/channels.yaml b/channels.yaml
index 241a526..c2456df 100644
--- a/channels.yaml
+++ b/channels.yaml
@@ -256,7 +256,7 @@
 - mediawiki-skins-Blueprint
 
 "#wikimedia-xtools":
-- Tool-Labs-tools-Xtools
+- XTools
 
 "#wikimedia-ios":
 - Wikipedia-iOS-.*

-- 
To view, visit https://gerrit.wikimedia.org/r/366786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a939a8c292368cb46676b183723b30fe8e00a3e
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/wikibugs2
Gerrit-Branch: master
Gerrit-Owner: Matthewrbowker 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Matthewrbowker 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: MusikAnimal 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Avoid using deprecated PreparedEdit::$pst

2017-07-21 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366982 )

Change subject: Avoid using deprecated PreparedEdit::$pst
..

Avoid using deprecated PreparedEdit::$pst

Change-Id: I2767d3a6a95920880b80a76b9e798546f79d
---
M includes/page/WikiPage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/366982/1

diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index f8f53a1..478b1dc 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -1607,7 +1607,7 @@
$meta = [
'bot' => ( $flags & EDIT_FORCE_BOT ),
'minor' => ( $flags & EDIT_MINOR ) && $user->isAllowed( 
'minoredit' ),
-   'serialized' => $editInfo->pst,
+   'serialized' => $pstContent->serialize( $serialFormat ),
'serialFormat' => $serialFormat,
'baseRevId' => $baseRevId,
'oldRevision' => $old_revision,

-- 
To view, visit https://gerrit.wikimedia.org/r/366982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2767d3a6a95920880b80a76b9e798546f79d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Swap buttons Help and Tools in header toolbar

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366960 )

Change subject: Swap buttons Help and Tools in header toolbar
..


Swap buttons Help and Tools in header toolbar

Change-Id: Id0b246e33d0da233e9954b510a91ec322ce9ead0
---
M index.html
1 file changed, 13 insertions(+), 12 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/index.html b/index.html
index 3aaf3cd..528172c 100644
--- a/index.html
+++ b/index.html
@@ -56,18 +56,7 @@
 


-   
-   
-   
-   https://tools.wmflabs.org/hay/propbrowse/;> Hay's Properties 
Browser
-   https://tools.wmflabs.org/sqid/#/browse?type=properties;> SQID 
Properties Browser
-   https://angryloki.github.io/wikidata-graph-builder/;> Wikidata 
Graph Builder
-   
-   https://github.com/wikimedia/wikidata-query-rdf/blob/master/docs/exploring-linked-data.md;> Exploring 
Linked Data
-   https://tools.wmflabs.org/wdq2sparql/w2s.php;> WDQ Syntax Translator
-   https://www.mediawiki.org/wiki/Wikidata_query_service/User_Manual#SPARQL_endpoint;> SPARQL REST 
Endpoint
-   
-   
+   

https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Wikidata_Query_Help;
 target="_blank" class="btn btn-default">
 
@@ -90,6 +79,18 @@



+   
+   
+   
+   https://tools.wmflabs.org/hay/propbrowse/;> Hay's Properties 
Browser
+   https://tools.wmflabs.org/sqid/#/browse?type=properties;> SQID 
Properties Browser
+   https://angryloki.github.io/wikidata-graph-builder/;> Wikidata 
Graph Builder
+   
+   https://github.com/wikimedia/wikidata-query-rdf/blob/master/docs/exploring-linked-data.md;> Exploring 
Linked Data
+   https://tools.wmflabs.org/wdq2sparql/w2s.php;> WDQ Syntax Translator
+   https://www.mediawiki.org/wiki/Wikidata_query_service/User_Manual#SPARQL_endpoint;> SPARQL REST 
Endpoint
+   
+   




-- 
To view, visit https://gerrit.wikimedia.org/r/366960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0b246e33d0da233e9954b510a91ec322ce9ead0
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WikiPage: Update comments related to new PreparedEdit object

2017-07-21 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366981 )

Change subject: WikiPage: Update comments related to new PreparedEdit object
..

WikiPage: Update comments related to new PreparedEdit object

Follows up 85585c47ecbf219.

Change-Id: Iff677257553e20ae37d37142436507b9c8af23a1
---
M includes/page/WikiPage.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/81/366981/1

diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index 20fb9be..f8f53a1 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -50,7 +50,7 @@
public $mLatest = false; // !< Integer (false means "not 
loaded")
/**@}}*/
 
-   /** @var stdClass Map of cache fields (text, parser output, ect) for a 
proposed/new edit */
+   /** @var PreparedEdit Map of cache fields (text, parser output, ect) 
for a proposed/new edit */
public $mPreparedEdit = false;
 
/**
@@ -782,7 +782,7 @@
 * Determine whether a page would be suitable for being counted as an
 * article in the site_stats table based on the title & its content
 *
-* @param object|bool $editInfo (false): object returned by 
prepareTextForEdit(),
+* @param PreparedEdit|bool $editInfo (false): object returned by 
prepareTextForEdit(),
 *   if false, the current database state will be used
 * @return bool
 */
@@ -1961,7 +1961,9 @@
 
/**
 * Prepare content which is about to be saved.
-* Returns a stdClass with source, pst and output members
+*
+* Prior to 1.30, this returned a stdClass object with the same class
+* members.
 *
 * @param Content $content
 * @param Revision|int|null $revision Revision object. For backwards 
compatibility, a

-- 
To view, visit https://gerrit.wikimedia.org/r/366981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff677257553e20ae37d37142436507b9c8af23a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Minify design of updater status

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366897 )

Change subject: Minify design of updater status
..


Minify design of updater status

Replace text from updater status with icon and move text into the
popover.

Change-Id: I9fd9a760a872469465bf148066784c9a2d959211
---
M index.html
M wikibase/queryService/ui/App.js
2 files changed, 13 insertions(+), 12 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/index.html b/index.html
index 0efbb69..3aaf3cd 100644
--- a/index.html
+++ b/index.html
@@ -165,7 +165,7 @@



-   
+   

 

diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index bed8b14..aa15881 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -350,19 +350,14 @@
 
var updateDataStatus = function() {
self._sparqlApi.queryDataUpdatedTime().done( function( 
time, difference ) {
-   var updatestatustext = moment.duration( 
difference, 'seconds' ).humanize(),
-   labelClass,
-   badge;
-
+   var labelClass = 'list-group-item-danger';
if ( difference <= 60 * 2 ) {
labelClass = 'list-group-item-success';
} else if ( difference <= 60 * 15 ) {
labelClass =  'list-group-item-warning';
-   } else {
-   labelClass = 'list-group-item-danger';
}
-   badge = '' + updatestatustext + '';
-   $label.html( $.i18n( 'wdqs-app-footer-updated', 
badge ) );
+
+   $label.html( $( '' ).addClass( 'fa 
fa-refresh badge ' + labelClass ).html( ' ' ) );
} );
};
 
@@ -375,15 +370,21 @@
 
var e = $( this );
self._sparqlApi.queryDataUpdatedTime().done( function( 
time, difference ) {
+   var text = moment.duration( difference, 
'seconds' ).humanize(),
+   title = time,
+   badge = '' + text + 
'';
+
+   $label.attr( 'title', title );
e.popover( {
html: true,
+   trigger: 'hover',
placement: 'top',
-   content: $.i18n( 
'wdqs-app-footer-updated-seconds', difference ) + '.' + time
-   } ).popover( 'show' );
+   content: $.i18n( 
'wdqs-app-footer-updated', badge )
+   } );
} ).fail( function() {
e.popover( {
content: '[unable to connect]'
-   } ).popover( 'show' );
+   } );
} );
}, function() {
var e = $( this );

-- 
To view, visit https://gerrit.wikimedia.org/r/366897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9fd9a760a872469465bf148066784c9a2d959211
Gerrit-PatchSet: 4
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ReadingLists[master]: [WIP] API

2017-07-21 Thread Code Review 
Gergő Tisza has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366980 )

Change subject: [WIP] API
..

[WIP] API

Adds API endpoints:
* action=readinglists
* meta=readinglists
* list=readinglistentries
* list=readinglistchanges

TODO:
* return list/entry order
* add i18n/doc boilerplate
* return ids from write modules
* fix useless sync return format
* prevent adding/removing entries from deleted lists?
* review DB index coverage
* use non-offset-based continuation where possible
* T164990#3460750
* turn ApiQueryReadingListEntries into a generator
  * create ReverseInterwikiLookup (cf InterwikiLookup::getAllPrefixes)

Longer term TODO: how will the REST API use tokens?

Bug: T168980
Bug: T168988
Change-Id: I3615581fb06c599dea50877d3678d1ba3e82bb20
---
M extension.json
M i18n/en.json
M i18n/qqq.json
A maintenance/purge.php
A src/Api/ApiQueryReadingListChanges.php
A src/Api/ApiQueryReadingListEntries.php
A src/Api/ApiQueryReadingLists.php
A src/Api/ApiReadingLists.php
A src/Api/ApiReadingListsCreate.php
A src/Api/ApiReadingListsCreateEntry.php
A src/Api/ApiReadingListsDelete.php
A src/Api/ApiReadingListsDeleteEntry.php
A src/Api/ApiReadingListsOrder.php
A src/Api/ApiReadingListsOrderEntry.php
A src/Api/ApiReadingListsSetup.php
A src/Api/ApiReadingListsTeardown.php
A src/Api/ApiReadingListsUpdate.php
A src/Api/ApiTrait.php
M src/ReadingListRepositoryException.php
19 files changed, 1,631 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReadingLists 
refs/changes/80/366980/1

diff --git a/extension.json b/extension.json
index 3049a86..c0c04cb 100644
--- a/extension.json
+++ b/extension.json
@@ -12,7 +12,43 @@
"MediaWiki\\Extensions\\ReadingLists\\HookHandler": 
"src/HookHandler.php",
"MediaWiki\\Extensions\\ReadingLists\\Utils": "src/Utils.php",
"MediaWiki\\Extensions\\ReadingLists\\ReadingListRepository": 
"src/ReadingListRepository.php",
-   
"MediaWiki\\Extensions\\ReadingLists\\ReadingListRepositoryException": 
"src/ReadingListRepositoryException.php"
+   
"MediaWiki\\Extensions\\ReadingLists\\ReadingListRepositoryException": 
"src/ReadingListRepositoryException.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingListChanges": 
"src/Api/ApiQueryReadingListChanges.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingListEntries": 
"src/Api/ApiQueryReadingListEntries.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingLists": 
"src/Api/ApiQueryReadingLists.php",
+   "MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingLists": 
"src/Api/ApiReadingLists.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsCreateEntry": 
"src/Api/ApiReadingListsCreateEntry.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsCreate": 
"src/Api/ApiReadingListsCreate.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsDeleteEntry": 
"src/Api/ApiReadingListsDeleteEntry.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsDelete": 
"src/Api/ApiReadingListsDelete.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsOrderEntry": 
"src/Api/ApiReadingListsOrderEntry.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsOrder": 
"src/Api/ApiReadingListsOrder.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsSetup": 
"src/Api/ApiReadingListsSetup.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsTeardown": 
"src/Api/ApiReadingListsTeardown.php",
+   
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingListsUpdate": 
"src/Api/ApiReadingListsUpdate.php",
+   "MediaWiki\\Extensions\\ReadingLists\\Api\\ApiTrait": 
"src/Api/ApiTrait.php"
+   },
+   "APIModules": {
+   "readinglists": 
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiReadingLists"
+   },
+   "APIListModules": {
+   "readinglistentries": {
+   "class": 
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingListEntries",
+   "factory": 
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingListEntries::factory"
+   },
+   "readinglistchanges": {
+   "class": 
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingListChanges",
+   "factory": 
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingListChanges::factory"
+   }
+   },
+   "APIMetaModules": {
+   "readinglists": {
+   "class": 
"MediaWiki\\Extensions\\ReadingLists\\Api\\ApiQueryReadingLists",
+   "factory":

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Add extensions/skins/vendor as submodules

2017-07-21 Thread MacFan4000 (Code Review) 
MacFan4000 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366979 )

Change subject: Add extensions/skins/vendor as submodules
..

Add extensions/skins/vendor as submodules

Bug: T137564
Change-Id: I27428aaf82eb1af4a556632c20054f7446a4a1f5
---
M .gitignore
A .gitmodules
D extensions/.gitignore
A extensions/Cite
A extensions/CiteThisPage
A extensions/ConfirmEdit
A extensions/Gadgets
A extensions/ImageMap
A extensions/InputBox
A extensions/Interwiki
A extensions/LocalisationUpdate
A extensions/Nuke
A extensions/ParserFunctions
A extensions/PdfHandler
A extensions/Poem
A extensions/Renameuser
A extensions/SpamBlacklist
A extensions/SyntaxHighlight_GeSHi
A extensions/TitleBlacklist
A extensions/WikiEditor
D skins/.gitignore
A skins/CologneBlue
A skins/Modern
A skins/MonoBook
A skins/Vector
A vendor
26 files changed, 110 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/366979/1

diff --git a/.gitignore b/.gitignore
index 01a11bf..e9e9b82 100644
--- a/.gitignore
+++ b/.gitignore
@@ -46,7 +46,6 @@
 /tests/phpunit/phpunit.phar
 
 # Composer
-/vendor
 /composer.lock
 /composer.json
 /composer.local.json
diff --git a/.gitmodules b/.gitmodules
new file mode 100644
index 000..51b46bb
--- /dev/null
+++ b/.gitmodules
@@ -0,0 +1,88 @@
+[submodule "vendor"]
+   path = vendor
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/vendor
+   branch = REL1_28
+[submodule "skins/Vector"]
+   path = skins/Vector
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/Vector
+   branch = REL1_28
+[submodule "skins/MonoBook"]
+   path = skins/MonoBook
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/MonoBook
+   branch = REL1_28
+[submodule "skins/Modern"]
+   path = skins/Modern
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/Modern
+   branch = REL1_28
+[submodule "skins/CologneBlue"]
+   path = skins/CologneBlue
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/CologneBlue
+   branch = REL1_28
+[submodule "extensions/CiteThisPage"]
+   path = extensions/CiteThisPage
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/CiteThisPage
+   branch = REL1_28
+[submodule "extensions/SpamBlacklist"]
+   path = extensions/SpamBlacklist
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/SpamBlacklist
+   branch = REL1_28
+[submodule "extensions/PdfHandler"]
+   path = extensions/PdfHandler
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/PdfHandler
+   branch = REL1_28
+[submodule "extensions/TitleBlacklist"]
+   path = extensions/TitleBlacklist
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/TitleBlacklist
+   branch = REL1_28
+[submodule "extensions/SyntaxHighlight_GeSHi"]
+   path = extensions/SyntaxHighlight_GeSHi
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/SyntaxHighlight_GeSHi
+   branch = REL1_28
+[submodule "extensions/Poem"]
+   path = extensions/Poem
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Poem
+   branch = REL1_28
+[submodule "extensions/LocalisationUpdate"]
+   path = extensions/LocalisationUpdate
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/LocalisationUpdate
+   branch = REL1_28
+[submodule "extensions/Interwiki"]
+   path = extensions/Interwiki
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Interwiki
+   branch = REL1_28
+[submodule "extensions/InputBox"]
+   path = extensions/InputBox
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/InputBox
+   branch = REL1_28
+[submodule "extensions/ImageMap"]
+   path = extensions/ImageMap
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/ImageMap
+   branch = REL1_28
+[submodule "extensions/Cite"]
+   path = extensions/Cite
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Cite
+   branch = REL1_28
+[submodule "extensions/WikiEditor"]
+   path = extensions/WikiEditor
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/WikiEditor
+   branch = REL1_28
+[submodule "extensions/Renameuser"]
+   path = extensions/Renameuser
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Renameuser
+   branch = REL1_28
+[submodule "extensions/ParserFunctions"]
+   path = extensions/ParserFunctions
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/ParserFunctions
+   branch = REL1_28
+[submodule "extensions/Nuke"]
+   path = extensions/Nuke
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Nuke
+   branch = REL1_28
+[submodule "extensions/Gadgets"]
+   path = extensions/Gadgets
+   url =

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Deprecate multi-source instance on dbstore2002

2017-07-21 Thread Jcrespo (Code Review) 
Jcrespo has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366978 )

Change subject: mariadb: Deprecate multi-source instance on dbstore2002
..


mariadb: Deprecate multi-source instance on dbstore2002

Reduce the number of expected instances to 3 instead of 4 (s1, s2,
x1).

Also monitor s1 by deafault instead of s2.

Bug: T169514
Change-Id: Ib91559d3732cce7fa6991967a164f31445b9ffb2
---
M modules/role/manifests/mariadb/dbstore_multiinstance.pp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jcrespo: Looks good to me, approved



diff --git a/modules/role/manifests/mariadb/dbstore_multiinstance.pp 
b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
index dc5b185..8a62209 100644
--- a/modules/role/manifests/mariadb/dbstore_multiinstance.pp
+++ b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
@@ -17,9 +17,9 @@
 #TODO: define one group per shard
 class {'mariadb::groups':
 mysql_group => 'dbstore',
-mysql_shard => 's2',
+mysql_shard => 's1',
 mysql_role  => 'slave',
-socket  => '/run/mysqld/mysqld.s2.sock',
+socket  => '/run/mysqld/mysqld.s1.sock',
 }
 
 class {'mariadb::packages_wmf': }
@@ -80,7 +80,7 @@
 }
 
 class { 'mariadb::monitor_process':
-process_count => 4,
+process_count => 3,
 is_critical   => false,
 contact_group => 'admins',
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib91559d3732cce7fa6991967a164f31445b9ffb2
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Deprecate multi-source instance on dbstore2002

2017-07-21 Thread Jcrespo (Code Review) 
Jcrespo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366978 )

Change subject: Deprecate multi-source instance on dbstore2002
..

Deprecate multi-source instance on dbstore2002

Reduce the number of expected instances to 3 instead of 4 (s1, s2,
x1).

Also monitor s1 by deafult instead of s2.

Bug: T169514
Change-Id: Ib91559d3732cce7fa6991967a164f31445b9ffb2
---
M modules/role/manifests/mariadb/dbstore_multiinstance.pp
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/78/366978/1

diff --git a/modules/role/manifests/mariadb/dbstore_multiinstance.pp 
b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
index dc5b185..8a62209 100644
--- a/modules/role/manifests/mariadb/dbstore_multiinstance.pp
+++ b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
@@ -17,9 +17,9 @@
 #TODO: define one group per shard
 class {'mariadb::groups':
 mysql_group => 'dbstore',
-mysql_shard => 's2',
+mysql_shard => 's1',
 mysql_role  => 'slave',
-socket  => '/run/mysqld/mysqld.s2.sock',
+socket  => '/run/mysqld/mysqld.s1.sock',
 }
 
 class {'mariadb::packages_wmf': }
@@ -80,7 +80,7 @@
 }
 
 class { 'mariadb::monitor_process':
-process_count => 4,
+process_count => 3,
 is_critical   => false,
 contact_group => 'admins',
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib91559d3732cce7fa6991967a164f31445b9ffb2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: install_server: Add new partman recipe for labstore100[1-2]

2017-07-21 Thread Madhuvishy (Code Review) 
Madhuvishy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366977 )

Change subject: install_server: Add new partman recipe for labstore100[1-2]
..

install_server: Add new partman recipe for labstore100[1-2]

Bug: T158196
Change-Id: If1e36ffaae3cfc15f7718d3d53bbb98b028c13e3
---
M modules/install_server/files/autoinstall/netboot.cfg
A modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg
2 files changed, 49 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/77/366977/1

diff --git a/modules/install_server/files/autoinstall/netboot.cfg 
b/modules/install_server/files/autoinstall/netboot.cfg
index 97aa3b2..d7eadf2 100755
--- a/modules/install_server/files/autoinstall/netboot.cfg
+++ b/modules/install_server/files/autoinstall/netboot.cfg
@@ -99,6 +99,7 @@
 labsdb[1-3]|labsdb100[1-3]) echo partman/mw.cfg ;; \
 sodium) echo partman/lvm-ext-srv.cfg ;; \
 labpuppetmaster100[12]|labnet100[34]|labnodepool1002|labweb100[12]) 
echo partman/raid1-lvm-ext4-srv-noswap.cfg;; \
+labstore100[1-2]) echo partman/labstore-lvm-noraid-swap.cfg ;; \
 labstore200[1-4]) echo partman/labstore-lvm-noraid.cfg ;; \
 labtestneutron2001) echo partman/mw.cfg ;; \
 labtestnet2001) echo partman/raid1.cfg ;; \
diff --git 
a/modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg 
b/modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg
new file mode 100644
index 000..9453c9d
--- /dev/null
+++ 
b/modules/install_server/files/autoinstall/partman/labstore-lvm-noraid-swap.cfg
@@ -0,0 +1,48 @@
+# configuration to create:
+#  * no RAID (either single disk or hardware raid presenting a single device)
+*  ** 30G / ext4 outside lvm
+#  ** 8G swap
+#  ** the rest as ext4 on /srv
+
+
+d-ipartman-auto/method string  lvm
+d-ipartman-auto/disk   string  /dev/sda
+
+# the install makes sure we want to wipe the lvm
+d-ipartman-lvm/device_remove_lvm   boolean true
+d-ipartman-lvm/confirm boolean true
+d-ipartman-lvm/confirm_nooverwrite true
+
+d-ipartman/confirm_nooverwrite true
+d-ipartman/choose_partitionselect  finish
+
+d-ipartman-auto/expert_recipe  string  es ::   \
+   3 2 3 ext4  \
+   $primary{ } \
+   $bootable{ }\
+   method{ format }\
+   format{ }   \
+   use_filesystem{ }   \
+   filesystem{ ext4 }  \
+   mountpoint{ / } \
+   .   \
+8000 8000 8000 linux-swap  \
+   method{ swap }  \
+   $lvmok{ }   \
+   format{ }   \
+   .   \
+   64 1000 1000 ext4   \
+   $primary{ } \
+   method{ format }\
+   format{ }   \
+   use_filesystem{ }   \
+   filesystem{ ext4 }  \
+   lv_name{ data } \
+   $defaultignore{ }   \
+   $lvmok{ }   \
+   mountpoint{ /srv }  \
+   .
+
+d-ipartman-auto-lvm/guided_sizestring  80%
+
+d-ipartman-auto/choose_recipe  es

-- 
To view, visit https://gerrit.wikimedia.org/r/366977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1e36ffaae3cfc15f7718d3d53bbb98b028c13e3
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Madhuvishy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: WIP Tag refunds with correct paypal gateway

2017-07-21 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366976 )

Change subject: WIP Tag refunds with correct paypal gateway
..

WIP Tag refunds with correct paypal gateway

Wow, these are crappy ways to tell the difference! Really should have
put the gateway code in one of those tracking fields.

Bug: T171351
Change-Id: I49da156eb72933d44bb299d92072c551c02798ad
---
M PaymentProviders/PayPal/RefundMessage.php
M PaymentProviders/PayPal/Tests/Data/chargeback_settlement.json
A PaymentProviders/PayPal/Tests/Data/chargeback_settlement_ec.json
A PaymentProviders/PayPal/Tests/Data/chargeback_settlement_ec_transformed.json
A PaymentProviders/PayPal/Tests/Data/chargeback_settlement_transformed.json
M PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
6 files changed, 73 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/76/366976/1

diff --git a/PaymentProviders/PayPal/RefundMessage.php 
b/PaymentProviders/PayPal/RefundMessage.php
index 98227a6..6ce11e2 100644
--- a/PaymentProviders/PayPal/RefundMessage.php
+++ b/PaymentProviders/PayPal/RefundMessage.php
@@ -14,12 +14,21 @@
$message['type'] = 'refund';
}
 
-   // Express checkout puts a description in transaction_subject, 
Legacy puts a contribution
-   // tracking ID there. Chargebacks don't set the field at all.
-   if ( isset( $ipnMessage['transaction_subject'] ) && 
!is_numeric( $ipnMessage['transaction_subject'] ) ) {
-   $message['gateway'] = 'paypal_ec';
+   if ( $message['type'] === 'refund' ) {
+   // For refunds, express checkout puts a description in 
transaction_subject,
+   // but legacy puts a contribution tracking ID there.
+   if ( isset( $ipnMessage['transaction_subject'] ) && 
!is_numeric( $ipnMessage['transaction_subject'] ) ) {
+   $message['gateway'] = 'paypal_ec';
+   } else {
+   $message['gateway'] = 'paypal';
+   }
} else {
-   $message['gateway'] = 'paypal';
+   // For chargebacks, express checkout sets the 'invoice' 
field
+   if ( isset( $ipnMessage['invoice'] ) ) {
+   $message['gateway'] = 'paypal_ec';
+   } else {
+   $message['gateway'] = 'paypal';
+   }
}
 
}
diff --git a/PaymentProviders/PayPal/Tests/Data/chargeback_settlement.json 
b/PaymentProviders/PayPal/Tests/Data/chargeback_settlement.json
index d96bde3..bfdbb40 100644
--- a/PaymentProviders/PayPal/Tests/Data/chargeback_settlement.json
+++ b/PaymentProviders/PayPal/Tests/Data/chargeback_settlement.json
@@ -1,22 +1,18 @@
 {
-   "payment_date": "11:55:22 Sep 28, 2016 PDT",
+   "payment_date": "05:32:08 Jun 30, 2017 PDT",
+   "txn_id": "91N12345TB8654321",
"payment_status": "Completed",
-   "txn_type": "adjustment",
-   "parent_txn_id": "X",
-   "txn_id": "Y",
"mc_currency": "USD",
-   "reason_code": "chargeback_settlement",
-   "email": "a...@wikimedia.org",
-   "mc_gross": "-10.00",
-   "gateway": "paypal",
-   "notify_version": "3.8",
-   "payment_gross": "-10.00",
+   "parent_txn_id": "2JP12345X654321V",
+   "notify_version": 3.8,
+   "custom": 47470083,
+   "txn_type": "adjustment",
+   "charset": "UTF-8",
+   "mc_gross": -1.00,
+   "payment_gross": -1.00,
+   "payer_email": "recipi...@wikimedia.org",
+   "verify_sign": 
"AZfnGop49sf6bIkvk-UIIwAT3vE6AqUlokuReG4Znr85ICxgRDn1rO8s",
+   "payer_id": "AA987ASDFGHUW8",
"payer_status": "verified",
-   "payment_fee": "-20.00",
-   "source_name": "SmashPig",
-   "source_type": "listener",
-   "source_host": "secrethost",
-   "source_run_id": "12423",
-   "source_version": "",
-   "source_enqueued_time": "1476796977"
+   "ipn_track_id": "28eec9b3c7857"
 }
diff --git a/PaymentProviders/PayPal/Tests/Data/chargeback_settlement_ec.json 
b/PaymentProviders/PayPal/Tests/Data/chargeback_settlement_ec.json
new file mode 100644
index 000..daef6ad
--- /dev/null
+++ b/PaymentProviders/PayPal/Tests/Data/chargeback_settlement_ec.json
@@ -0,0 +1,19 @@
+{
+   "txn_type" : "adjustment",
+   "payment_date" : "06:25:22 Jul 10, 2017 PDT",
+   "payment_gross" : -5.00,
+   "mc_currency" : "USD",
+   "verify_sign" : 
"A21kmBLyRcQpDSjYvmswlm3ckjahAZ-SbzbHuzDA0wERKwHSrBlTr9cY",
+   "payer_status" : "verified",
+   "payer_email" : "recipi...@wikimedia.org",
+   "txn_id" :

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit: make name of config template flexible

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366911 )

Change subject: gerrit: make name of config template flexible
..


gerrit: make name of config template flexible

Make the name of the config template file flexible and set it
via Hiera, to allow using a different template on a VPS
to test config changes before they hit production.

Also allows changing LDAP server name as was intended with
Ia1e9f932fc7daf9889 and is necessary now since prod LDAP server
won't allow connections from "labs" anymore.

Change-Id: I989e746c6c4f7a9b53608dafb6ffcd68fb1b2c0c
---
M hieradata/role/common/gerrit/server.yaml
M modules/gerrit/manifests/init.pp
M modules/gerrit/manifests/jetty.pp
M modules/profile/manifests/gerrit/server.pp
4 files changed, 12 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/common/gerrit/server.yaml 
b/hieradata/role/common/gerrit/server.yaml
index 4b42a98..59e7938 100644
--- a/hieradata/role/common/gerrit/server.yaml
+++ b/hieradata/role/common/gerrit/server.yaml
@@ -8,6 +8,7 @@
 gerrit::server::host: 'gerrit.wikimedia.org'
 gerrit::server::master_host: 'cobalt.wikimedia.org'
 gerrit::server::bacula: 'srv-gerrit-git'
+gerrit::server::config: 'gerrit.config.erb'
 
 # list of gerrit servers used in firewall rules
 gerrit::servers:
diff --git a/modules/gerrit/manifests/init.pp b/modules/gerrit/manifests/init.pp
index 5339aca..3365849 100644
--- a/modules/gerrit/manifests/init.pp
+++ b/modules/gerrit/manifests/init.pp
@@ -1,11 +1,13 @@
 # Manifest to setup a Gerrit instance
 class gerrit(
+$config,
 $host,
 $slave = false,
 ) {
 
 class { '::gerrit::jetty':
-slave => $slave,
+slave  => $slave,
+config => $config,
 }
 
 if !$slave {
diff --git a/modules/gerrit/manifests/jetty.pp 
b/modules/gerrit/manifests/jetty.pp
index 874ac8f..842378b 100644
--- a/modules/gerrit/manifests/jetty.pp
+++ b/modules/gerrit/manifests/jetty.pp
@@ -10,7 +10,8 @@
 $slave = false,
 $java_home = '/usr/lib/jvm/java-8-openjdk-amd64/jre',
 $log_host = undef,
-$log_port = '4560'
+$log_port = '4560',
+$config = 'gerrit.config.erb',
 ) {
 
 include ::nrpe
@@ -159,7 +160,7 @@
 }
 
 file { '/var/lib/gerrit2/review_site/etc/gerrit.config':
-content => template('gerrit/gerrit.config.erb'),
+content => template("gerrit/${config}"),
 owner   => 'gerrit2',
 group   => 'gerrit2',
 mode=> '0444',
diff --git a/modules/profile/manifests/gerrit/server.pp 
b/modules/profile/manifests/gerrit/server.pp
index c5d1cb5..36fa8cf 100644
--- a/modules/profile/manifests/gerrit/server.pp
+++ b/modules/profile/manifests/gerrit/server.pp
@@ -7,7 +7,8 @@
 $host = hiera('gerrit::server::host'),
 $master_host = hiera('gerrit::server::master_host'),
 $bacula = hiera('gerrit::server::bacula'),
-$gerrit_servers = join(hiera('gerrit::servers'), ' ')
+$gerrit_servers = join(hiera('gerrit::servers'), ' '),
+$config = hiera('gerrit::server::config'),
 ) {
 
 interface::alias { 'gerrit server':
@@ -65,7 +66,8 @@
 }
 
 class { '::gerrit':
-host  => $host,
-slave => $slave,
+host   => $host,
+slave  => $slave,
+config => $config,
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I989e746c6c4f7a9b53608dafb6ffcd68fb1b2c0c
Gerrit-PatchSet: 9
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Add extensions/skins/vendor as submodules

2017-07-21 Thread MacFan4000 (Code Review) 
MacFan4000 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366975 )

Change subject: Add extensions/skins/vendor as submodules
..

Add extensions/skins/vendor as submodules

Bug: T137564
Change-Id: I736705bd3d3a1bbfc675a708ffa1c04b4726dfab
---
M .gitignore
A .gitmodules
D extensions/.gitignore
A extensions/Cite
A extensions/CiteThisPage
A extensions/ConfirmEdit
A extensions/Gadgets
A extensions/ImageMap
A extensions/InputBox
A extensions/Interwiki
A extensions/LocalisationUpdate
A extensions/Nuke
A extensions/ParserFunctions
A extensions/PdfHandler
A extensions/Poem
A extensions/Renameuser
A extensions/SpamBlacklist
A extensions/SyntaxHighlight_GeSHi
A extensions/TitleBlacklist
A extensions/WikiEditor
D skins/.gitignore
A skins/CologneBlue
A skins/Modern
A skins/MonoBook
A skins/Vector
A vendor
26 files changed, 110 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/75/366975/1

diff --git a/.gitignore b/.gitignore
index 01a11bf..e9e9b82 100644
--- a/.gitignore
+++ b/.gitignore
@@ -46,7 +46,6 @@
 /tests/phpunit/phpunit.phar
 
 # Composer
-/vendor
 /composer.lock
 /composer.json
 /composer.local.json
diff --git a/.gitmodules b/.gitmodules
new file mode 100644
index 000..73ce970
--- /dev/null
+++ b/.gitmodules
@@ -0,0 +1,88 @@
+[submodule "extensions/ConfirmEdit"]
+   path = extensions/ConfirmEdit
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/ConfirmEdit
+   branch = REL1_27
+[submodule "extensions/Gadgets"]
+   path = extensions/Gadgets
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Gadgets
+   branch = REL1_27
+[submodule "extensions/Nuke"]
+   path = extensions/Nuke
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Nuke
+   branch = REL1_27
+[submodule "extensions/ParserFunctions"]
+   path = extensions/ParserFunctions
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/ParserFunctions
+   branch = REL1_27
+[submodule "extensions/Renameuser"]
+   path = extensions/Renameuser
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Renameuser
+   branch = REL1_27
+[submodule "extensions/WikiEditor"]
+   path = extensions/WikiEditor
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/WikiEditor
+   branch = REL1_27
+[submodule "extensions/Cite"]
+   path = extensions/Cite
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Cite
+   branch = REL1_27
+[submodule "extensions/ImageMap"]
+   path = extensions/ImageMap
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/ImageMap
+   branch = REL1_27
+[submodule "extensions/InputBox"]
+   path = extensions/InputBox
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/InputBox
+   branch = REL1_27
+[submodule "extensions/Interwiki"]
+   path = extensions/Interwiki
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Interwiki
+   branch = REL1_27
+[submodule "extensions/LocalisationUpdate"]
+   path = extensions/LocalisationUpdate
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/LocalisationUpdate
+   branch = REL1_27
+[submodule "extensions/Poem"]
+   path = extensions/Poem
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Poem
+   branch = REL1_27
+[submodule "extensions/SyntaxHighlight_GeSHi"]
+   path = extensions/SyntaxHighlight_GeSHi
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/SyntaxHighlight_GeSHi
+   branch = REL1_27
+[submodule "extensions/TitleBlacklist"]
+   path = extensions/TitleBlacklist
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/TitleBlacklist
+   branch = REL1_27
+[submodule "extensions/PdfHandler"]
+   path = extensions/PdfHandler
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/PdfHandler
+   branch = REL1_27
+[submodule "extensions/SpamBlacklist"]
+   path = extensions/SpamBlacklist
+   url = 
https://gerrit.wikimedia.org/r/p/mediawiki/extensions/SpamBlacklist
+   branch = REL1_27
+[submodule "extensions/CiteThisPage"]
+   path = extensions/CiteThisPage
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/extensions/CiteThisPage
+   branch = REL1_27
+[submodule "skins/CologneBlue"]
+   path = skins/CologneBlue
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/CologneBlue
+   branch = REL1_27
+[submodule "skins/Modern"]
+   path = skins/Modern
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/Modern
+   branch = REL1_27
+[submodule "skins/MonoBook"]
+   path = skins/MonoBook
+   url = https://gerrit.wikimedia.org/r/p/mediawiki/skins/MonoBook
+   branch = REL1_27
+[submodule "skins/Vector"]
+   path = skins/Vector
+   url =

[MediaWiki-commits] [Gerrit] labs...stewardbots[master]: Wikimedia Labs rebranding

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366881 )

Change subject: Wikimedia Labs rebranding
..


Wikimedia Labs rebranding

Change-Id: Ibd79ea8d56c4e428c7375beb65542ac637e30867
---
M index.html
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/index.html b/index.html
index b638959..75419b7 100644
--- a/index.html
+++ b/index.html
@@ -1,15 +1,15 @@
 
 
 
-   Stewardbots Home - Wikimedia Labs
+   Wikimedia Toolforge - Stewardbots

 
 
 
 
-Wikimedia Tool Labs: ~stewardbots project
+Wikimedia Toolforge: ~stewardbots project
 
-This is a https://tools.wmflabs.org/; target="_self">multi-mantainer 
projectfor several https://meta.wikimedia.org/wiki/IRC/Bots; 
target="_self">IRC bots and relatedhttps://meta.wikimedia.org/wiki/Stewards; target="_self">steward 
tools.
+This is a https://tools.wmflabs.org/; target="_self">multi-mantainer project 
for several https://meta.wikimedia.org/wiki/IRC/Bots; 
target="_self">IRC bots and related https://meta.wikimedia.org/wiki/Stewards; target="_self">steward 
tools.
 
 WARNING: We 
are in the process of updating this site files from the old system we used in 
Toolserver, expect 404 errors for now.
 
@@ -35,11 +35,11 @@
 
 Code
 
-You can browse our code at our https://phabricator.wikimedia.org/diffusion/TSTW/;>Phabricator 
repository or its mirror athttps://github.com/wikimedia/labs-tools-stewardbots;>GitHub.
+You can browse our code at our https://phabricator.wikimedia.org/diffusion/TSTW/;>Phabricator 
repository or its mirror at https://github.com/wikimedia/labs-tools-stewardbots;>GitHub.
 
 Bugs and suggestions
 
-You can report bugs and suggestions at https://phabricator.wikimedia.org/maniphest/task/create/?projects=Tool-Labs-tools-stewardbots;>Phabricator.
+You can report bugs and suggestions at https://phabricator.wikimedia.org/maniphest/task/create/?projects=Tool-stewardbots;>Phabricator.
 
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd79ea8d56c4e428c7375beb65542ac637e30867
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/stewardbots
Gerrit-Branch: master
Gerrit-Owner: MarcoAurelio 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' of https://gerrit.wikimedia.org/r/wiki...

2017-07-21 Thread Eileen (Code Review) 
Eileen has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366974 )

Change subject: Merge branch 'master' of 
https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment
..


Merge branch 'master' of 
https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment

3289733 Change CiviMailing create command to use is_completed
5647648 Resurrecting hashar's original composer json linter

Change-Id: I1d0695b0b3816f7612d125213d1183166ddcf5f3
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Eileen: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/366974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d0695b0b3816f7612d125213d1183166ddcf5f3
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: deployment
Gerrit-Owner: Eileen 
Gerrit-Reviewer: Eileen 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...crm[deployment]: Merge branch 'master' of https://gerrit.wikimedia.org/r/wiki...

2017-07-21 Thread Eileen (Code Review) 
Eileen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366974 )

Change subject: Merge branch 'master' of 
https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment
..

Merge branch 'master' of 
https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment

3289733 Change CiviMailing create command to use is_completed
5647648 Resurrecting hashar's original composer json linter

Change-Id: I1d0695b0b3816f7612d125213d1183166ddcf5f3
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/74/366974/1


-- 
To view, visit https://gerrit.wikimedia.org/r/366974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d0695b0b3816f7612d125213d1183166ddcf5f3
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: deployment
Gerrit-Owner: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LdapAuthentication[master]: when user lookups fail, NULL out $this->userInfo

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366973 )

Change subject: when user lookups fail, NULL out $this->userInfo
..


when user lookups fail, NULL out $this->userInfo

Since we use this class as a singleton object,
a failed user lookup could result in us 'returning'
incorrect data in $this->userInfo based on whatever
was the last successful lookup.

Probably the caller is meant to check $this->fetchedUserInfo
before checking $this->userInfo but a) fetchedUserInfo
also wasn't unset in all cases and b) OpenStackManager
definitely did not check that.

Bug: T171313
Change-Id: Ia2e2df5c09392e00e458fbe41c9782e208479498
---
M LdapAuthenticationPlugin.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/LdapAuthenticationPlugin.php b/LdapAuthenticationPlugin.php
index b92f2b4..5d51227 100644
--- a/LdapAuthenticationPlugin.php
+++ b/LdapAuthenticationPlugin.php
@@ -1437,6 +1437,8 @@
}
if ( !$bind ) {
$this->printDebug( "Failed to bind", 
NONSENSITIVE );
+   $this->fetchedUserInfo = false;
+   $this->userInfo = null;
return '';
}
}
@@ -1458,6 +1460,7 @@
if ( LdapAuthenticationPlugin::ldap_count_entries( 
$this->ldapconn, $entry ) == 0 ) {
$this->printDebug( "Couldn't find an entry", 
NONSENSITIVE );
$this->fetchedUserInfo = false;
+   $this->userInfo = null;
return '';
}
$this->userInfo = LdapAuthenticationPlugin::ldap_get_entries( 
$this->ldapconn, $entry );

-- 
To view, visit https://gerrit.wikimedia.org/r/366973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2e2df5c09392e00e458fbe41c9782e208479498
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/LdapAuthentication
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LdapAuthentication[master]: when user lookups fail, NULL out $this->userInfo

2017-07-21 Thread Andrew Bogott (Code Review) 
Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366973 )

Change subject: when user lookups fail, NULL out $this->userInfo
..

when user lookups fail, NULL out $this->userInfo

Since we use this class as a singleton object,
a failed user lookup could result in us 'returning'
incorrect data in $this->userInfo based on whatever
was the last successful lookup.

Probably the caller is meant to check $this->fetchedUserInfo
before checking $this->userInfo but a) fetchedUserInfo
also wasn't unset in all cases and b) OpenStackManager
definitely did not check that.

Bug: T171313
Change-Id: Ia2e2df5c09392e00e458fbe41c9782e208479498
---
M LdapAuthenticationPlugin.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LdapAuthentication 
refs/changes/73/366973/1

diff --git a/LdapAuthenticationPlugin.php b/LdapAuthenticationPlugin.php
index b92f2b4..3082341 100644
--- a/LdapAuthenticationPlugin.php
+++ b/LdapAuthenticationPlugin.php
@@ -1437,6 +1437,8 @@
}
if ( !$bind ) {
$this->printDebug( "Failed to bind", 
NONSENSITIVE );
+   $this->fetchedUserInfo = false;
+   $this->userInfo = NULL;
return '';
}
}
@@ -1458,6 +1460,7 @@
if ( LdapAuthenticationPlugin::ldap_count_entries( 
$this->ldapconn, $entry ) == 0 ) {
$this->printDebug( "Couldn't find an entry", 
NONSENSITIVE );
$this->fetchedUserInfo = false;
+   $this->userInfo = NULL;
return '';
}
$this->userInfo = LdapAuthenticationPlugin::ldap_get_entries( 
$this->ldapconn, $entry );

-- 
To view, visit https://gerrit.wikimedia.org/r/366973
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2e2df5c09392e00e458fbe41c9782e208479498
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LdapAuthentication
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Don't empty the changes list on first load

2017-07-21 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366972 )

Change subject: RCFilters: Don't empty the changes list on first load
..

RCFilters: Don't empty the changes list on first load

jQuery.empty() apparently also unattaches event handlers.
Only empty before we re-append if we are not in the first
load of the changes list.

Bug: T171085
Change-Id: I68754e99a6c5c821be47b1b1e8e22f23db85746c
---
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/366972/1

diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
index 6512f04..0e9e843 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
@@ -125,7 +125,9 @@
this.$element.append( $message );
} else {
this.$changesListContent = $changesListContent;
-   this.$element.empty().append( this.$changesListContent 
);
+   if ( !isInitialDOM ) {
+   this.$element.empty().append( 
this.$changesListContent );
+   }
// Set up highlight containers
this.setupHighlightContainers( this.$element );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68754e99a6c5c821be47b1b1e8e22f23db85746c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Adjustments to floating elements in print styles

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366971 )

Change subject: Adjustments to floating elements in print styles
..

Adjustments to floating elements in print styles

Bug: T169823
Change-Id: I38c030fe5d321f8d3419dca5a69e2a0f99ae6c16
---
M resources/src/mediawiki.legacy/commonPrint.css
1 file changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/71/366971/1

diff --git a/resources/src/mediawiki.legacy/commonPrint.css 
b/resources/src/mediawiki.legacy/commonPrint.css
index 085406c..dfa8164 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -197,12 +197,19 @@
  * Floating divs (and thumbnails)
  */
 /* @noflip */
+table.floatright,
 div.floatright,
 div.tright {
float: right;
clear: right;
position: relative;
-   margin: 0.5em 0 0.8em 1.4em;
+   margin: 0.5em 0 1.3em 1.4em;
+}
+
+div.floatright,
+table.floatright {
+   margin: 0 0 0.5em 0.5em;
+   border: 0;
 }
 
 div.floatright p {
@@ -210,12 +217,13 @@
 }
 
 /* @noflip */
+table.floatleft,
 div.floatleft,
 div.tleft {
float: left;
clear: left;
position: relative;
-   margin: 0.5em 1.4em 0.8em 0;
+   margin: 0.5em 1.4em 1.3em 0;
 }
 
 div.floatleft p {

-- 
To view, visit https://gerrit.wikimedia.org/r/366971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c030fe5d321f8d3419dca5a69e2a0f99ae6c16
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove signoff from security patch process.

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366969 )

Change subject: Remove signoff from security patch process.
..


Remove signoff from security patch process.

It's a lie, and causes problems with Gerrit/CI

Change-Id: I31b2d60dd6d40393e2b8908b7e59c7a6bbe2ec62
---
M make-release/make-release.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/make-release/make-release.py b/make-release/make-release.py
index 8641b21..a5d7c67 100755
--- a/make-release/make-release.py
+++ b/make-release/make-release.py
@@ -477,7 +477,7 @@
 oldDir = os.getcwd()
 os.chdir(targetDir)
 with open(patchFile) as patchIn:
-patchProc = subprocess.Popen(['git', 'am', '--signoff', '--3way'],
+patchProc = subprocess.Popen(['git', 'am', '--3way'],
  stdin=patchIn)
 status = patchProc.wait()
 if status != 0:

-- 
To view, visit https://gerrit.wikimedia.org/r/366969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31b2d60dd6d40393e2b8908b7e59c7a6bbe2ec62
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Adjust print styles for thumb

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366970 )

Change subject: Adjust print styles for thumb
..

Adjust print styles for thumb

Bug: T169823
Change-Id: If32f76f11f260bb33decf1ebe934470acee66ce6
---
M resources/src/mediawiki.legacy/commonPrint.css
1 file changed, 15 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/366970/1

diff --git a/resources/src/mediawiki.legacy/commonPrint.css 
b/resources/src/mediawiki.legacy/commonPrint.css
index a7b7fb2..085406c 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -223,7 +223,10 @@
 }
 
 .center {
+   width: 100%;
text-align: center;
+   margin-left: auto;
+   margin-right: auto;
 }
 
 /**
@@ -233,19 +236,26 @@
background-color: transparent;
border: 0;
width: auto;
-   margin-top: 0.5em;
-   margin-bottom: 0.8em;
+   margin: .5em auto;
+   text-align: center;
+}
+
+div.thumb a {
+   border-bottom: 0;
 }
 
 div.thumbinner {
background-color: #fff;
border: 1pt solid #ccc;
-   padding: 3px;
-   font-size: 94%;
-   text-align: center;
+   border-radius: 2px;
+   padding: 5px;
+   font-size: 12px;
+   color: #666;
+   text-align: left;
/* new block formatting context,
 * to clear background from floating content  */
overflow: hidden;
+   min-width: 100px;
 }
 
 html .thumbimage {

-- 
To view, visit https://gerrit.wikimedia.org/r/366970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If32f76f11f260bb33decf1ebe934470acee66ce6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove signoff from security patch process.

2017-07-21 Thread Chad (Code Review) 
Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366969 )

Change subject: Remove signoff from security patch process.
..

Remove signoff from security patch process.

It's a lie, and causes problems with Gerrit/CI

Change-Id: I31b2d60dd6d40393e2b8908b7e59c7a6bbe2ec62
---
M make-release/make-release.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/69/366969/1

diff --git a/make-release/make-release.py b/make-release/make-release.py
index 8641b21..a5d7c67 100755
--- a/make-release/make-release.py
+++ b/make-release/make-release.py
@@ -477,7 +477,7 @@
 oldDir = os.getcwd()
 os.chdir(targetDir)
 with open(patchFile) as patchIn:
-patchProc = subprocess.Popen(['git', 'am', '--signoff', '--3way'],
+patchProc = subprocess.Popen(['git', 'am', '--3way'],
  stdin=patchIn)
 status = patchProc.wait()
 if status != 0:

-- 
To view, visit https://gerrit.wikimedia.org/r/366969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31b2d60dd6d40393e2b8908b7e59c7a6bbe2ec62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Change loading animation

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366770 )

Change subject: RCFilters: Change loading animation
..


RCFilters: Change loading animation

Bug: T165286
Change-Id: If816dd1e3a2677c36195546c51f87505ba883e04
---
M includes/specials/SpecialRecentchanges.php
M resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
M resources/src/mediawiki.rcfilters/styles/mw.rcfilters.less
3 files changed, 60 insertions(+), 8 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialRecentchanges.php 
b/includes/specials/SpecialRecentchanges.php
index 15bbffd..c9c2475 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -669,6 +669,15 @@
[ 'class' => 'rcfilters-container' ]
);
 
+   $loadingContainer = Html::rawElement(
+   'div',
+   [ 'class' => 'rcfilters-spinner' ],
+   Html::element(
+   'div',
+   [ 'class' => 'rcfilters-spinner-bounce' 
]
+   )
+   );
+
// Wrap both with rcfilters-head
$this->getOutput()->addHTML(
Html::rawElement(
@@ -677,6 +686,9 @@
$rcfilterContainer . $rcoptions
)
);
+
+   // Add spinner
+   $this->getOutput()->addHTML( $loadingContainer );
} else {
$this->getOutput()->addHTML( $rcoptions );
}
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
index 6cd2d0b..9da3f8c 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
@@ -39,6 +39,7 @@
 
// Set as ready
$( '.rcfilters-head' ).addClass( 
'mw-rcfilters-ui-ready' );
+   $( '.rcfilters-spinner' ).detach();
 
$( 'a.mw-helplink' ).attr(
'href',
diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.less 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.less
index 6277fd9..305f3f9 100644
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.less
@@ -1,5 +1,5 @@
 // Corrections for the standard special page
-.client-js{
+.client-js {
.rcoptions {
border: 0;
border-bottom: 1px solid #a2a9b1;
@@ -11,14 +11,10 @@
 
.rcfilters-head {
min-height: 310px;
-   &:not( .mw-rcfilters-ui-ready ) {
-   /* @embed */
-   background-image: url( ../images/pending.gif );
-   margin: 0;
 
-   * {
-   visibility: hidden;
-   }
+   &:not( .mw-rcfilters-ui-ready ) {
+   opacity: 0.5;
+   pointer-events: none;
}
}
 
@@ -33,8 +29,51 @@
// message of our own
display: none;
}
+
+   .rcfilters-spinner {
+   margin: -2em auto 0;
+   width: 70px;
+   opacity: 0.8;
+   display: block;
+   white-space: nowrap;
+
+   & .rcfilters-spinner-bounce,
+   &:before,
+   &:after {
+   content: '';
+   display: inline-block;
+   width: 12px;
+   height: 12px;
+   background-color: #c8ccd1;
+   border-radius: 100%;
+   animation: rcfiltersBouncedelay 1.5s infinite 
ease-in-out;
+   animation-fill-mode: both;
+   animation-delay: -0.16s;
+   }
+
+   &:before {
+   animation-delay: -0.33s;
+   }
+
+   &:after {
+   animation-delay: 0s;
+   }
+
+   }
 }
 
 .mw-rcfilters-staticfilters-selected {
font-weight: bold;
 }
+
+@keyframes rcfiltersBouncedelay {
+   0%,
+   100%,
+   80% {
+   transform: scale( 0.7 );
+   }
+   40% {
+   transform: scale( 1 );
+   background-color: #a2a9b1;
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/366770
To unsubscribe, visit

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Popup: Use built-in features of PopupWidget instead of custo...

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366568 )

Change subject: Popup: Use built-in features of PopupWidget instead of custom 
CSS
..


Popup: Use built-in features of PopupWidget instead of custom CSS

* Use OOUI buttons for the actions.
* Make the widget wider to accommodate longer titles in
  different languages.
* Don't show if CM already enabled

Change-Id: Ibde461a99929565c15b5e7c5ef3ad88e163fba05
---
M resources/ext.CodeMirror.js
M resources/modules/popup.less
2 files changed, 74 insertions(+), 62 deletions(-)

Approvals:
  Niharika29: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ext.CodeMirror.js b/resources/ext.CodeMirror.js
index cf13bef..c82b57f 100644
--- a/resources/ext.CodeMirror.js
+++ b/resources/ext.CodeMirror.js
@@ -1,6 +1,6 @@
 ( function ( mw, $ ) {
var origTextSelection, useCodeMirror, codeMirror, api, 
originHooksTextarea,
-   wikiEditorToolbarEnabled, popupStatus = null, popup = false;
+   wikiEditorToolbarEnabled;
 
if ( mw.config.get( 'wgCodeEditorCurrentLanguage' ) ) { // If the 
CodeEditor is used then just exit;
return;
@@ -388,56 +388,72 @@
 
/**
 * Add a popup for first time users (T165003)
+*
+* If popup hasn't been shown before, show popup and add a localStorage 
entry.
+* check it before showing popup in future.
 */
-   function addPopup() {
-   var $content =
+   /**
+*/
+   function handlePopup() {
+   var yesButton, noButton, $title, $content, popup;
+
+   // If popup has previously been dismissed, don't show again.
+   if ( mw.storage.get( 'codemirror-try-popup' ) ) {
+   return;
+   }
+   mw.storage.set( 'codemirror-try-popup', 1 );
+
+   yesButton = new OO.ui.ButtonWidget( {
+   label: mw.msg( 'codemirror-popup-btn-yes' ),
+   flags: [ 'primary', 'progressive' ]
+   } );
+   noButton = new OO.ui.ButtonWidget( {
+   label: mw.msg( 'codemirror-popup-btn-no' ),
+   flags: [ 'destructive' ]
+   } );
+   $title =
+   $( '' ).append(
+   '{ ',
+   $( '' ).addClass( 
'codemirror-popup-color-blue' ).text( mw.msg( 'codemirror-popup-syntax' ) ),
+   ' ',
+   document.createTextNode( mw.msg( 
'codemirror-popup-highlighting' ) ),
+   ' }'
+   );
+   $content =
$( '' ).addClass( 'codemirror-popup-div' ).append(
-   $( '' ).addClass( 'codemirror-popup-top' 
).append(
-   '{ ',
-   $( '' ).addClass( 
'codemirror-popup-color-blue' ).text( mw.msg( 'codemirror-popup-syntax' ) ),
-   ' ',
-   document.createTextNode( mw.msg( 
'codemirror-popup-highlighting' ) ),
-   ' }'
-   ),
$( '' ).addClass( 'codemirror-popup-text' 
).text( mw.msg( 'codemirror-popup-desc' ) ),
-   $( '' ).addClass( 'codemirror-popup-btn 
codemirror-popup-btn-yes' ).text( mw.msg( 'codemirror-popup-btn-yes' ) ),
-   $( '' ).addClass( 'codemirror-popup-btn 
codemirror-popup-btn-no' ).text( mw.msg( 'codemirror-popup-btn-no' ) )
+   yesButton.$element,
+   noButton.$element
);
 
popup = new OO.ui.PopupWidget( {
+   head: true,
+   label: $title,
+   classes: [ 'codemirror-popup' ],
$content: $content,
-   containerPadding: 80,
$floatableContainer: $( '#mw-editbutton-codemirror' ),
-   padded: false,
-   width: 215
+   padded: true,
+   width: 300
} );
// Add our popup to the body, it will find its correct position 
using $floatableContainer
$( 'body' ).append( popup.$element );
 
+   // Events
+   yesButton.on( 'click', function () {
+   if ( !codeMirror ) {
+   switchCodeMirror();
+   }
+   popup.toggle( false );
+   } );
+   noButton.on( 'click', function () {
+   if ( codeMirror ) {
+

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Temporarily disable webrequest deletion while lawyers do som...

2017-07-21 Thread Ottomata (Code Review) 
Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366966 )

Change subject: Temporarily disable webrequest deletion while lawyers do some 
research
..


Temporarily disable webrequest deletion while lawyers do some research

Change-Id: I8f5e6194e26309b097055d1ecbd0fe451a48e549
---
M modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Ottomata: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp 
b/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
index a9283d3..9fd888c 100644
--- a/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
+++ b/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
@@ -20,6 +20,9 @@
 # Keep this many days of raw webrequest data.
 $raw_retention_days = 31
 cron { 'refinery-drop-webrequest-raw-partitions':
+# Temporarily disable webrequest deletion while lawyers do some 
research (Otto, Dan, Nuria)
+# This should only be disabled for a week or so.
+ensure  => 'absent',
 command => "${env} && 
${role::analytics_cluster::refinery::path}/bin/refinery-drop-webrequest-partitions
 -d ${raw_retention_days} -D wmf_raw -l /wmf/data/raw/webrequest -w raw >> 
${webrequest_log_file} 2>&1",
 user=> 'hdfs',
 minute  => '15',
@@ -29,6 +32,9 @@
 # Keep this many days of refined webrequest data.
 $refined_retention_days = 90
 cron { 'refinery-drop-webrequest-refined-partitions':
+# Temporarily disable webrequest deletion while lawyers do some 
research (Otto, Dan, Nuria)
+# This should only be disabled for a week or so.
+ensure  => 'absent',
 command => "${env} && 
${role::analytics_cluster::refinery::path}/bin/refinery-drop-webrequest-partitions
 -d ${refined_retention_days} -D wmf -l /wmf/data/wmf/webrequest -w refined >> 
${webrequest_log_file} 2>&1",
 user=> 'hdfs',
 minute  => '45',

-- 
To view, visit https://gerrit.wikimedia.org/r/366966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f5e6194e26309b097055d1ecbd0fe451a48e549
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Milimetric 
Gerrit-Reviewer: Nuria 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix font size and backgrounds in gallery

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366967 )

Change subject: Fix font size and backgrounds in gallery
..

Fix font size and backgrounds in gallery

In print medium we should be explicit about font size
 - don't rely on %
and colors should be made more printer friendly

Bug: T69823
Change-Id: Iffcff305a4e0b973bdd52a57f52d8a0766cef512
---
M resources/src/mediawiki/page/gallery.print.css
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/67/366967/1

diff --git a/resources/src/mediawiki/page/gallery.print.css 
b/resources/src/mediawiki/page/gallery.print.css
index 80fc964..21079fe 100644
--- a/resources/src/mediawiki/page/gallery.print.css
+++ b/resources/src/mediawiki/page/gallery.print.css
@@ -24,13 +24,14 @@
 
 li.gallerybox div.thumb {
text-align: center;
-   border: 1px solid #ccc;
+   background-color: #fff !important;
+   border: 1px solid #ccc !important;
margin: 2px;
 }
 
 div.gallerytext {
overflow: hidden;
-   font-size: 94%;
+   font-size: 10pt;
padding: 2px 4px;
word-wrap: break-word;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366967
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffcff305a4e0b973bdd52a57f52d8a0766cef512
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Adjustments to printed table styles

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366968 )

Change subject: Adjustments to printed table styles
..

Adjustments to printed table styles

* Remove bolding
* Remove backgrounds
* Explicitly choose font sizes
* Adjust paddings

Bug: T169823
Change-Id: I9c82f10fa92a24c7bcfff4458c6e5b8d2ddaffbf
---
M resources/src/mediawiki.legacy/commonPrint.css
1 file changed, 13 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/366968/1

diff --git a/resources/src/mediawiki.legacy/commonPrint.css 
b/resources/src/mediawiki.legacy/commonPrint.css
index dec0fe8..a7b7fb2 100644
--- a/resources/src/mediawiki.legacy/commonPrint.css
+++ b/resources/src/mediawiki.legacy/commonPrint.css
@@ -271,14 +271,16 @@
 table.wikitable,
 table.mw_metadata {
background: #fff;
-   margin: 1em 0;
-   border: 1pt solid #aaa;
+   border: solid 1px #aaa;
border-collapse: collapse;
+   font-size: 10pt;
+   margin: 1em 0;
 }
 
 table.wikitable > caption,
 .mw_metadata caption {
-   font-weight: bold;
+   padding: 5px;
+   font-size: 13px;
 }
 
 table.wikitable > tr > th,
@@ -287,15 +289,19 @@
 table.wikitable > * > tr > td,
 .mw_metadata th,
 .mw_metadata td {
-   border: 1pt solid #aaa;
-   padding: 0.2em;
+   border: 1px solid rgba(0, 0, 0, 0.3);
+   padding: 0.4em 0.6em;
 }
 
+table.wikitable th,
+table.wikitable tr,
+table.wikitable td {
+   /* Important is required to override any inline styles provided by 
editors */
+   background-color: #FFF !important;
+}
 table.wikitable > tr > th,
 table.wikitable > * > tr > th,
 .mw_metadata th {
-   background: #fff;
-   font-weight: bold;
text-align: center;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c82f10fa92a24c7bcfff4458c6e5b8d2ddaffbf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Temporarily disable webrequest deletion while lawyers do som...

2017-07-21 Thread Ottomata (Code Review) 
Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366966 )

Change subject: Temporarily disable webrequest deletion while lawyers do some 
research
..

Temporarily disable webrequest deletion while lawyers do some research

Change-Id: I8f5e6194e26309b097055d1ecbd0fe451a48e549
---
M modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/66/366966/1

diff --git a/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp 
b/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
index a9283d3..d9ea9ca 100644
--- a/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
+++ b/modules/role/manifests/analytics_cluster/refinery/job/data_drop.pp
@@ -20,6 +20,9 @@
 # Keep this many days of raw webrequest data.
 $raw_retention_days = 31
 cron { 'refinery-drop-webrequest-raw-partitions':
+# Temporarily disable webrequest deletion while lawyers do some 
research (Otto, Dan, Nuria)
+# This should only be disabled for a week or so.
+ensure  => 'absent',
 command => "${env} && 
${role::analytics_cluster::refinery::path}/bin/refinery-drop-webrequest-partitions
 -d ${raw_retention_days} -D wmf_raw -l /wmf/data/raw/webrequest -w raw >> 
${webrequest_log_file} 2>&1",
 user=> 'hdfs',
 minute  => '15',
@@ -29,6 +32,9 @@
 # Keep this many days of refined webrequest data.
 $refined_retention_days = 90
 cron { 'refinery-drop-webrequest-refined-partitions':
+# Temporarily disable webrequest deletion while lawyers do some 
research (Otto, Dan, Nuria)
+# This should only be disabled for a week or so.
+ensure => 'absent',
 command => "${env} && 
${role::analytics_cluster::refinery::path}/bin/refinery-drop-webrequest-partitions
 -d ${refined_retention_days} -D wmf -l /wmf/data/wmf/webrequest -w refined >> 
${webrequest_log_file} 2>&1",
 user=> 'hdfs',
 minute  => '45',

-- 
To view, visit https://gerrit.wikimedia.org/r/366966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f5e6194e26309b097055d1ecbd0fe451a48e549
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Bump Android periodic test to android-25

2017-07-21 Thread Hashar (Code Review) 
Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366965 )

Change subject: Bump Android periodic test to android-25
..

Bump Android periodic test to android-25

Requires a hotfix to the Jenkins Android Plugin.

Set ABI to google_apis/x86

Bug: T150623
Change-Id: I965999f762cdb4ce6c97b11bcb4b0e0e735fe7ea
Depends-On: I9c42dfc0d8ee662440fcdd1668007d0931a7b2b3
---
M jjb/mobile.yaml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/65/366965/1

diff --git a/jjb/mobile.yaml b/jjb/mobile.yaml
index fa781d9..14746a6 100644
--- a/jjb/mobile.yaml
+++ b/jjb/mobile.yaml
@@ -83,9 +83,9 @@
  - timestamps
  - ansicolor
  - android-emulator: # api 24 on a nexus s because 1440x2560 at 560 PPI 
doesn't boot in CI
- os: android-24
+ os: android-25
  screen-density: 240
- target-abi: x86
+ target-abi: google_apis/x86
  show-window: true
  commandline-options: -no-window -no-boot-anim
  hardware-properties:

-- 
To view, visit https://gerrit.wikimedia.org/r/366965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I965999f762cdb4ce6c97b11bcb4b0e0e735fe7ea
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Log more and catch errors on duplicate invoice ID

2017-07-21 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366964 )

Change subject: Log more and catch errors on duplicate invoice ID
..

Log more and catch errors on duplicate invoice ID

TODO: tests

Bug: T171349
Change-Id: I0e71426e21fc3f642aab34aa3adfd304f01ec5ff
---
M sites/all/modules/wmf_civicrm/wmf_civicrm.module
1 file changed, 23 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/64/366964/1

diff --git a/sites/all/modules/wmf_civicrm/wmf_civicrm.module 
b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
index 025335e..a692882 100644
--- a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
@@ -443,21 +443,34 @@
   watchdog('wmf_civicrm', 'Contribution result from 
civicrm_contribution_add(): ' . print_r($contribution_result, TRUE), NULL, 
WATCHDOG_DEBUG);
 }
 catch (CiviCRM_API3_Exception $e) {
+watchdog( 'wmf_civicrm', 'Error inserting contribution: ' . 
$e->getMessage(), NULL, WATCHDOG_INFO );
 $duplicate = null;
-if (array_key_exists('invoice_id', $contribution)) {
-$invoice_id = $contribution['invoice_id'];
-$duplicate = civicrm_api3("Contribution", "getSingle", 
array("invoice_id" => $invoice_id));
+
+try {
+if ( array_key_exists( 'invoice_id', $contribution ) ) {
+watchdog( 'wmf_civicrm', 'Checking for duplicate on invoice ID 
' . $contribution['invoice_id'], NULL, WATCHDOG_INFO );
+$invoice_id = $contribution['invoice_id'];
+$duplicate = civicrm_api3( "Contribution", "getSingle", array( 
"invoice_id" => $invoice_id ) );
+}
+if ( $duplicate ) {
+$contribution['invoice_id'] = $contribution['invoice_id'] . 
'|dup-' . UtcDate::getUtcTimeStamp();
+watchdog( 'wmf_civicrm', 'Found duplicate invoice ID, changing 
this one to ' . $contribution['invoice_id'], NULL, WATCHDOG_INFO );
+$contribution_result = civicrm_api3( "Contribution", "Create", 
$contribution );
+watchdog( 'wmf_civicrm', 'Contribution result from 
civicrm_contribution_add(): ' . print_r( $contribution_result, TRUE ), NULL, 
WATCHDOG_DEBUG );
+$msg['contribution_tags'][] = 'DuplicateInvoiceId';
+} else {
+throw new WmfException(
+'INVALID_MESSAGE',
+'Cannot create contribution, civi error!',
+$e->getExtraParams()
+);
+}
 }
-if ($duplicate){
-$contribution['invoice_id'] = $contribution['invoice_id'] . 
'|dup-' . UtcDate::getUtcTimeStamp();
-$contribution_result = civicrm_api3("Contribution", "Create", 
$contribution);
-$msg['contribution_tags'][] = 'DuplicateInvoiceId';
-}
-else {
+catch ( CiviCRM_API3_Exception $eInner ) {
 throw new WmfException(
 'INVALID_MESSAGE',
 'Cannot create contribution, civi error!',
-$e->getExtraParams()
+$eInner->getExtraParams()
 );
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e71426e21fc3f642aab34aa3adfd304f01ec5ff
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[dev_cluster]: Config: add table-ng options

2017-07-21 Thread Eevans (Code Review) 
Eevans has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366963 )

Change subject: Config: add table-ng options
..


Config: add table-ng options

Change-Id: I3b149d8822295e226822c246e2a324fa224600fb
---
M scap/templates/config.yaml.j2
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Eevans: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 9012345..3a2dbb2 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -53,7 +53,7 @@
   x-modules:
 - path: projects/wmf_default.yaml
   options: _options
-table:
+table: _options
   backend: cassandra
   hosts: ['<%= seeds|join("','") %>']
   keyspace: system
@@ -74,6 +74,9 @@
 # Catch-all group
 - name: default.group.local
   domains: /./
+table-ng:
+  <<: *table_options
+  backend: cassandra-ng
 parsoid:
   host: <%= parsoid_uri %>
 action:

-- 
To view, visit https://gerrit.wikimedia.org/r/366963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b149d8822295e226822c246e2a324fa224600fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: dev_cluster
Gerrit-Owner: Ppchelko 
Gerrit-Reviewer: Eevans 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[dev_cluster]: Config: add table-ng options

2017-07-21 Thread Ppchelko (Code Review) 
Ppchelko has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366963 )

Change subject: Config: add table-ng options
..

Config: add table-ng options

Change-Id: I3b149d8822295e226822c246e2a324fa224600fb
---
M scap/templates/config.yaml.j2
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/63/366963/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 9012345..3a2dbb2 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -53,7 +53,7 @@
   x-modules:
 - path: projects/wmf_default.yaml
   options: _options
-table:
+table: _options
   backend: cassandra
   hosts: ['<%= seeds|join("','") %>']
   keyspace: system
@@ -74,6 +74,9 @@
 # Catch-all group
 - name: default.group.local
   domains: /./
+table-ng:
+  <<: *table_options
+  backend: cassandra-ng
 parsoid:
   host: <%= parsoid_uri %>
 action:

-- 
To view, visit https://gerrit.wikimedia.org/r/366963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b149d8822295e226822c246e2a324fa224600fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: dev_cluster
Gerrit-Owner: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[dev_cluster]: Update restbase to fae19d2

2017-07-21 Thread Eevans (Code Review) 
Eevans has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366961 )

Change subject: Update restbase to fae19d2
..


Update restbase to fae19d2

List of changes:
e705ecf WIP: Add special parsoid bucket
68926a3 Point to the correct dependency and only test on cassandra 3
b455e71 Correctly point to the branch
a78fdae Implement indexing and deleting
57ec6c9 Updated the cleanup algorithm
a8bdfe1 Actually remove the dependent content as well
fae19d2 Increase timeout for event tests and fix them
xxx Update node module dependencies

Change-Id: Idc2f692b299b9f8c28514e3393ea7bcd295e6499
---
M node_modules/bluebird/package.json
M node_modules/cassandra-driver/package.json
M node_modules/cassandra-uuid/package.json
M node_modules/content-type/package.json
M node_modules/core-js/package.json
M node_modules/extend/package.json
M node_modules/js-yaml/package.json
M node_modules/json-stable-stringify/package.json
M node_modules/kad/package.json
A node_modules/restbase-mod-table-cassandra-ng/.eslintrc.yml
A node_modules/restbase-mod-table-cassandra-ng/.jscs.json
A node_modules/restbase-mod-table-cassandra-ng/.jshintignore
A node_modules/restbase-mod-table-cassandra-ng/.jshintrc
A node_modules/restbase-mod-table-cassandra-ng/.npmignore
A node_modules/restbase-mod-table-cassandra-ng/.travis.yml
A node_modules/restbase-mod-table-cassandra-ng/LICENSE
A node_modules/restbase-mod-table-cassandra-ng/index.js
A node_modules/restbase-mod-table-cassandra-ng/lib/db.js
A node_modules/restbase-mod-table-cassandra-ng/lib/dbutils.js
A node_modules/restbase-mod-table-cassandra-ng/lib/index.js
A node_modules/restbase-mod-table-cassandra-ng/lib/schemaMigration.js
A node_modules/restbase-mod-table-cassandra-ng/maintenance/keyspace_name.js
A node_modules/restbase-mod-table-cassandra-ng/maintenance/lib/index.js
A 
node_modules/restbase-mod-table-cassandra-ng/maintenance/thin_out_key_rev_value_data.js
A node_modules/restbase-mod-table-cassandra-ng/maintenance/thin_out_parsoid.js
A node_modules/restbase-mod-table-cassandra-ng/package.json
A node_modules/restbase-mod-table-cassandra-ng/scripts/RashomonDumpImporter.js
A node_modules/restbase-mod-table-cassandra-ng/scripts/direct-request.js
A node_modules/restbase-mod-table-cassandra-ng/scripts/dumpReader.js
A node_modules/restbase-mod-table-cassandra-ng/scripts/package.json
A node_modules/restbase-mod-table-cassandra-ng/scripts/unused_queries.txt
A node_modules/restbase-mod-table-cassandra-ng/table.yaml
A 
node_modules/restbase-mod-table-cassandra-ng/test/functional/backend_migrations.js
A 
node_modules/restbase-mod-table-cassandra-ng/test/functional/config_migrations.js
A node_modules/restbase-mod-table-cassandra-ng/test/functional/replication.js
A node_modules/restbase-mod-table-cassandra-ng/test/index.js
A node_modules/restbase-mod-table-cassandra-ng/test/mocha.opts
A node_modules/restbase-mod-table-cassandra-ng/test/unit/dbutils.js
A node_modules/restbase-mod-table-cassandra-ng/test/utils/test_client.conf.yaml
A node_modules/restbase-mod-table-spec-ng/.jshintignore
A node_modules/restbase-mod-table-spec-ng/.jshintrc
A node_modules/restbase-mod-table-spec-ng/.npmignore
A node_modules/restbase-mod-table-spec-ng/.travis.yml
A node_modules/restbase-mod-table-spec-ng/index.js
A node_modules/restbase-mod-table-spec-ng/lib/validator.js
A node_modules/restbase-mod-table-spec-ng/package.json
A node_modules/restbase-mod-table-spec-ng/table.yaml
A node_modules/restbase-mod-table-spec-ng/test/functional/invalid_requests.js
A node_modules/restbase-mod-table-spec-ng/test/functional/multi_ranged.js
A node_modules/restbase-mod-table-spec-ng/test/functional/schema_migrations.js
A node_modules/restbase-mod-table-spec-ng/test/functional/simple.js
A node_modules/restbase-mod-table-spec-ng/test/functional/types.js
A node_modules/restbase-mod-table-spec-ng/test/functional/varint.js
A node_modules/restbase-mod-table-spec-ng/test/lib/jshint.js
A node_modules/restbase-mod-table-spec-ng/test/lib/validator.js
A node_modules/restbase-mod-table-spec-ng/test/mocha.opts
A node_modules/restbase-mod-table-spec-ng/test/utils/test_router.js
A node_modules/restbase-mod-table-spec-ng/test/utils/test_utils.js
M node_modules/routeswitch/package.json
M node_modules/semver/package.json
M node_modules/swagger-ui/package.json
M restbase
62 files changed, 7,674 insertions(+), 9 deletions(-)

Approvals:
  Eevans: Verified; Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/366961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc2f692b299b9f8c28514e3393ea7bcd295e6499
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: dev_cluster
Gerrit-Owner: Ppchelko 
Gerrit-Reviewer: Eevans 
Gerrit-Reviewer: Mobrovac

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix toolbar position on Special:CollabPad

2017-07-21 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366962 )

Change subject: Fix toolbar position on Special:CollabPad
..

Fix toolbar position on Special:CollabPad

Adds missing ve-init-mw-desktopArticleTarget-toolbar-open class.

Change-Id: I8579928c8daa224bb9bec8fa5f4360fb3c52c5a1
---
M modules/ve-mw-collab/ve.init.mw.CollabTarget.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/62/366962/1

diff --git a/modules/ve-mw-collab/ve.init.mw.CollabTarget.js 
b/modules/ve-mw-collab/ve.init.mw.CollabTarget.js
index 4d95271..327bed5 100644
--- a/modules/ve-mw-collab/ve.init.mw.CollabTarget.js
+++ b/modules/ve-mw-collab/ve.init.mw.CollabTarget.js
@@ -81,7 +81,9 @@
  * @inheritdoc
  */
 ve.init.mw.CollabTarget.prototype.attachToolbar = function () {
-   this.toolbar.$element.addClass( 
've-init-mw-desktopArticleTarget-toolbar 
ve-init-mw-desktopArticleTarget-toolbar-opened' );
+   this.toolbar.$element.addClass(
+   've-init-mw-desktopArticleTarget-toolbar 
ve-init-mw-desktopArticleTarget-toolbar-open 
ve-init-mw-desktopArticleTarget-toolbar-opened'
+   );
this.$element.prepend( this.toolbar.$element );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/366962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8579928c8daa224bb9bec8fa5f4360fb3c52c5a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[dev_cluster]: Update restbase to fae19d2

2017-07-21 Thread Ppchelko (Code Review) 
Ppchelko has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366961 )

Change subject: Update restbase to fae19d2
..

Update restbase to fae19d2

List of changes:
e705ecf WIP: Add special parsoid bucket
68926a3 Point to the correct dependency and only test on cassandra 3
b455e71 Correctly point to the branch
a78fdae Implement indexing and deleting
57ec6c9 Updated the cleanup algorithm
a8bdfe1 Actually remove the dependent content as well
fae19d2 Increase timeout for event tests and fix them
xxx Update node module dependencies

Change-Id: Idc2f692b299b9f8c28514e3393ea7bcd295e6499
---
M node_modules/bluebird/package.json
M node_modules/cassandra-driver/package.json
M node_modules/cassandra-uuid/package.json
M node_modules/content-type/package.json
M node_modules/core-js/package.json
M node_modules/extend/package.json
M node_modules/js-yaml/package.json
M node_modules/json-stable-stringify/package.json
M node_modules/kad/package.json
A node_modules/restbase-mod-table-cassandra-ng/.eslintrc.yml
A node_modules/restbase-mod-table-cassandra-ng/.jscs.json
A node_modules/restbase-mod-table-cassandra-ng/.jshintignore
A node_modules/restbase-mod-table-cassandra-ng/.jshintrc
A node_modules/restbase-mod-table-cassandra-ng/.npmignore
A node_modules/restbase-mod-table-cassandra-ng/.travis.yml
A node_modules/restbase-mod-table-cassandra-ng/LICENSE
A node_modules/restbase-mod-table-cassandra-ng/index.js
A node_modules/restbase-mod-table-cassandra-ng/lib/db.js
A node_modules/restbase-mod-table-cassandra-ng/lib/dbutils.js
A node_modules/restbase-mod-table-cassandra-ng/lib/index.js
A node_modules/restbase-mod-table-cassandra-ng/lib/schemaMigration.js
A node_modules/restbase-mod-table-cassandra-ng/maintenance/keyspace_name.js
A node_modules/restbase-mod-table-cassandra-ng/maintenance/lib/index.js
A 
node_modules/restbase-mod-table-cassandra-ng/maintenance/thin_out_key_rev_value_data.js
A node_modules/restbase-mod-table-cassandra-ng/maintenance/thin_out_parsoid.js
A node_modules/restbase-mod-table-cassandra-ng/package.json
A node_modules/restbase-mod-table-cassandra-ng/scripts/RashomonDumpImporter.js
A node_modules/restbase-mod-table-cassandra-ng/scripts/direct-request.js
A node_modules/restbase-mod-table-cassandra-ng/scripts/dumpReader.js
A node_modules/restbase-mod-table-cassandra-ng/scripts/package.json
A node_modules/restbase-mod-table-cassandra-ng/scripts/unused_queries.txt
A node_modules/restbase-mod-table-cassandra-ng/table.yaml
A 
node_modules/restbase-mod-table-cassandra-ng/test/functional/backend_migrations.js
A 
node_modules/restbase-mod-table-cassandra-ng/test/functional/config_migrations.js
A node_modules/restbase-mod-table-cassandra-ng/test/functional/replication.js
A node_modules/restbase-mod-table-cassandra-ng/test/index.js
A node_modules/restbase-mod-table-cassandra-ng/test/mocha.opts
A node_modules/restbase-mod-table-cassandra-ng/test/unit/dbutils.js
A node_modules/restbase-mod-table-cassandra-ng/test/utils/test_client.conf.yaml
A node_modules/restbase-mod-table-spec-ng/.jshintignore
A node_modules/restbase-mod-table-spec-ng/.jshintrc
A node_modules/restbase-mod-table-spec-ng/.npmignore
A node_modules/restbase-mod-table-spec-ng/.travis.yml
A node_modules/restbase-mod-table-spec-ng/index.js
A node_modules/restbase-mod-table-spec-ng/lib/validator.js
A node_modules/restbase-mod-table-spec-ng/package.json
A node_modules/restbase-mod-table-spec-ng/table.yaml
A node_modules/restbase-mod-table-spec-ng/test/functional/invalid_requests.js
A node_modules/restbase-mod-table-spec-ng/test/functional/multi_ranged.js
A node_modules/restbase-mod-table-spec-ng/test/functional/schema_migrations.js
A node_modules/restbase-mod-table-spec-ng/test/functional/simple.js
A node_modules/restbase-mod-table-spec-ng/test/functional/types.js
A node_modules/restbase-mod-table-spec-ng/test/functional/varint.js
A node_modules/restbase-mod-table-spec-ng/test/lib/jshint.js
A node_modules/restbase-mod-table-spec-ng/test/lib/validator.js
A node_modules/restbase-mod-table-spec-ng/test/mocha.opts
A node_modules/restbase-mod-table-spec-ng/test/utils/test_router.js
A node_modules/restbase-mod-table-spec-ng/test/utils/test_utils.js
M node_modules/routeswitch/package.json
M node_modules/semver/package.json
M node_modules/swagger-ui/package.json
M restbase
62 files changed, 7,674 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/61/366961/1


-- 
To view, visit https://gerrit.wikimedia.org/r/366961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc2f692b299b9f8c28514e3393ea7bcd295e6499
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: dev_cluster
Gerrit-Owner: Ppchelko 

___
MediaWiki-commits mailing list

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: API: Add deprecation warnings for Iae0e2ce3

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/321407 )

Change subject: API: Add deprecation warnings for Iae0e2ce3
..


API: Add deprecation warnings for Iae0e2ce3

Change-Id: Ib0c9d5a18803b406a1266eb24238536d122ff6e7
---
M includes/api/ApiBase.php
M includes/api/ApiMain.php
M includes/api/ApiUsageException.php
M tests/phpunit/includes/api/ApiErrorFormatterTest.php
M tests/phpunit/includes/api/ApiMainTest.php
5 files changed, 32 insertions(+), 4 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index aa970f4..a22f3ec 100644
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -2573,6 +2573,7 @@
 * @param string $warning Warning message
 */
public function setWarning( $warning ) {
+   wfDeprecated( __METHOD__, '1.29' );
$msg = new ApiRawMessage( $warning, 'warning' );
$this->getErrorFormatter()->addWarning( $this->getModulePath(), 
$msg );
}
@@ -2591,6 +2592,7 @@
 * @throws ApiUsageException always
 */
public function dieUsage( $description, $errorCode, $httpRespCode = 0, 
$extradata = null ) {
+   wfDeprecated( __METHOD__, '1.29' );
$this->dieWithError(
new RawMessage( '$1', [ $description ] ),
$errorCode,
@@ -2610,6 +2612,7 @@
 * @throws MWException
 */
public function getErrorFromStatus( $status, &$extraData = null ) {
+   wfDeprecated( __METHOD__, '1.29' );
if ( $status->isGood() ) {
throw new MWException( 'Successful status passed to 
ApiBase::dieStatus' );
}
@@ -2819,6 +2822,7 @@
 * @return [ 'code' => code, 'info' => info ]
 */
public function parseMsg( $error ) {
+   wfDeprecated( __METHOD__, '1.29' );
// Check whether someone passed the whole array, instead of one 
element as
// documented. This breaks if it's actually an array of 
fallback keys, but
// that's long-standing misbehavior introduced in r87627 to 
incorrectly
@@ -2848,6 +2852,7 @@
 * @throws ApiUsageException always
 */
public function dieUsageMsg( $error ) {
+   wfDeprecated( __METHOD__, '1.29' );
$this->dieWithError( $this->parseMsgInternal( $error ) );
}
 
@@ -2860,6 +2865,7 @@
 * @since 1.21
 */
public function dieUsageMsgOrDebug( $error ) {
+   wfDeprecated( __METHOD__, '1.29' );
$this->dieWithErrorOrDebug( $this->parseMsgInternal( $error ) );
}
 
diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php
index d7586e0..c644e87 100644
--- a/includes/api/ApiMain.php
+++ b/includes/api/ApiMain.php
@@ -1038,7 +1038,7 @@
// None of the rest have any messages for non-error 
types
} elseif ( $e instanceof UsageException ) {
// User entered incorrect parameters - generate error 
response
-   $data = $e->getMessageArray();
+   $data = MediaWiki\quietCall( [ $e, 'getMessageArray' ] 
);
$code = $data['code'];
$info = $data['info'];
unset( $data['code'], $data['info'] );
diff --git a/includes/api/ApiUsageException.php 
b/includes/api/ApiUsageException.php
index 9dc1f92..fb49e2d 100644
--- a/includes/api/ApiUsageException.php
+++ b/includes/api/ApiUsageException.php
@@ -45,6 +45,10 @@
$this->mCodestr = $codestr;
$this->mExtraData = $extradata;
 
+   if ( !$this instanceof ApiUsageException ) {
+   wfDeprecated( __METHOD__, '1.29' );
+   }
+
// This should never happen, so throw an exception about it 
that will
// hopefully get logged with a backtrace (T138585)
if ( !is_string( $codestr ) || $codestr === '' ) {
@@ -58,6 +62,7 @@
 * @return string
 */
public function getCodeString() {
+   wfDeprecated( __METHOD__, '1.29' );
return $this->mCodestr;
}
 
@@ -65,6 +70,7 @@
 * @return array
 */
public function getMessageArray() {
+   wfDeprecated( __METHOD__, '1.29' );
$result = [
'code' => $this->mCodestr,
'info' => $this->getMessage()
@@ -183,6 +189,7 @@
 * @inheritdoc
 */
public function getCodeString() {
+   wfDeprecated( __METHOD__, '1.29' );
return $this->getApiMessage()->getApiCode();
}
 
@@ -192,6 +199,7 @@
 * @inheritdoc

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Swap buttons Help and Tools in header toolbar

2017-07-21 Thread Jonas Kress (WMDE) (Code Review) 
Jonas Kress (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366960 )

Change subject: Swap buttons Help and Tools in header toolbar
..

Swap buttons Help and Tools in header toolbar

Change-Id: Id0b246e33d0da233e9954b510a91ec322ce9ead0
---
M index.html
1 file changed, 13 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/60/366960/1

diff --git a/index.html b/index.html
index 3aaf3cd..528172c 100644
--- a/index.html
+++ b/index.html
@@ -56,18 +56,7 @@
 


-   
-   
-   
-   https://tools.wmflabs.org/hay/propbrowse/;> Hay's Properties 
Browser
-   https://tools.wmflabs.org/sqid/#/browse?type=properties;> SQID 
Properties Browser
-   https://angryloki.github.io/wikidata-graph-builder/;> Wikidata 
Graph Builder
-   
-   https://github.com/wikimedia/wikidata-query-rdf/blob/master/docs/exploring-linked-data.md;> Exploring 
Linked Data
-   https://tools.wmflabs.org/wdq2sparql/w2s.php;> WDQ Syntax Translator
-   https://www.mediawiki.org/wiki/Wikidata_query_service/User_Manual#SPARQL_endpoint;> SPARQL REST 
Endpoint
-   
-   
+   

https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Wikidata_Query_Help;
 target="_blank" class="btn btn-default">
 
@@ -90,6 +79,18 @@



+   
+   
+   
+   https://tools.wmflabs.org/hay/propbrowse/;> Hay's Properties 
Browser
+   https://tools.wmflabs.org/sqid/#/browse?type=properties;> SQID 
Properties Browser
+   https://angryloki.github.io/wikidata-graph-builder/;> Wikidata 
Graph Builder
+   
+   https://github.com/wikimedia/wikidata-query-rdf/blob/master/docs/exploring-linked-data.md;> Exploring 
Linked Data
+   https://tools.wmflabs.org/wdq2sparql/w2s.php;> WDQ Syntax Translator
+   https://www.mediawiki.org/wiki/Wikidata_query_service/User_Manual#SPARQL_endpoint;> SPARQL REST 
Endpoint
+   
+   




-- 
To view, visit https://gerrit.wikimedia.org/r/366960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0b246e33d0da233e9954b510a91ec322ce9ead0
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add s1 instance to dbstore2002 (imported from db2072)

2017-07-21 Thread Jcrespo (Code Review) 
Jcrespo has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366865 )

Change subject: Add s1 instance to dbstore2002 (imported from db2072)
..


Add s1 instance to dbstore2002 (imported from db2072)

This will enable a new systemd service and data on the host.

Bug: T171321
Change-Id: Idc6c7623263aa3da38a3cc6cefb32632af1edaf4
---
M modules/role/manifests/mariadb/dbstore_multiinstance.pp
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jcrespo: Looks good to me, approved



diff --git a/modules/role/manifests/mariadb/dbstore_multiinstance.pp 
b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
index aa77450..dc5b185 100644
--- a/modules/role/manifests/mariadb/dbstore_multiinstance.pp
+++ b/modules/role/manifests/mariadb/dbstore_multiinstance.pp
@@ -49,9 +49,9 @@
 group  => root,
 mode   => '0755',
 }
-#mariadb::instance {'s1':
-#port => 3311,
-#}
+mariadb::instance {'s1':
+port => 3311,
+}
 mariadb::instance {'s2':
 port => 3312,
 }
@@ -80,7 +80,7 @@
 }
 
 class { 'mariadb::monitor_process':
-process_count => 3,
+process_count => 4,
 is_critical   => false,
 contact_group => 'admins',
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc6c7623263aa3da38a3cc6cefb32632af1edaf4
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.30.0-wmf.10]: Fix layout regression in notification popup footer

2017-07-21 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366952 )

Change subject: Fix layout regression in notification popup footer
..

Fix layout regression in notification popup footer

Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
(cherry picked from commit 0bf4861d929a21d4f80a1a466e04f04e61ea9642)
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/52/366952/1

diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less 
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 2c2f0aa..183edf9 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -56,6 +56,9 @@
border-top: 1px solid #ddd;
width: 100%;
 
+   // Override the margins that OOUI suddenly 
added to popup footers (T171302)
+   margin: 0;
+
> .oo-ui-buttonGroupWidget {
display: block;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Fix layout regression in notification popup footer

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366903 )

Change subject: Fix layout regression in notification popup footer
..


Fix layout regression in notification popup footer

Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less 
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 2c2f0aa..183edf9 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -56,6 +56,9 @@
border-top: 1px solid #ddd;
width: 100%;
 
+   // Override the margins that OOUI suddenly 
added to popup footers (T171302)
+   margin: 0;
+
> .oo-ui-buttonGroupWidget {
display: block;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Define response behaviour for a variety of endpoints

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366947 )

Change subject: Define response behaviour for a variety of endpoints
..

Define response behaviour for a variety of endpoints

Per the spec [1]

Define responses for:
* For a page outside of the wiki's content namespaces
* For a page in the wiki's content namespace(s)
* For a page that doesn't use the wikitext, wikibase-item, or wikibase-property 
content model
* For a page that doesn't exist
* For a page that redirects to another page

[1] 
https://www.mediawiki.org/wiki/User:Phuedx_(WMF)/Reading/Web/Page_Preview_API

Change-Id: I9264e1b55c1742c3aa5a021ef1154007af83b76f
---
M routes/mobile-sections.js
A test/features/mobile-sections-lead/previewHtml.js
2 files changed, 80 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/47/366947/1

diff --git a/routes/mobile-sections.js b/routes/mobile-sections.js
index 8fee414..a8b9ae1 100644
--- a/routes/mobile-sections.js
+++ b/routes/mobile-sections.js
@@ -371,15 +371,26 @@
  */
 function buildSummary(req) {
 return buildLeadObject(req, false).then((lead) => {
-const intro = lead && lead.intro;
-if (intro) {
-return {
-html: transforms.summarize(intro),
-revision: lead.revision
-};
-} else {
+let summary = '';
+let code = 200;
+let title = lead.displaytitle;
+
+if (!lead) {
 return false;
+} else if (lead.redirected) {
+code = 302;
+title = lead.redirected;
+} else if (lead.contentmodel !== 'wikitext' || lead.ns !== 0) {
+code = 204;
+} else if (lead.intro) {
+summary = transforms.summarize(lead.intro);
 }
+return {
+code,
+title,
+html: summary,
+revision: lead.revision
+};
 });
 }
 
@@ -436,9 +447,14 @@
 router.get('/preview-html/:title', (req, res) => {
 return buildSummary(req).then((summary) => {
 if (summary) {
-res.status(200);
-mUtil.setETag(res, summary.revision);
-res.send(summary.html).end();
+res.status(summary.code);
+if (summary.code === 200) {
+mUtil.setETag(res, summary.revision);
+res.send(summary.html);
+} else if (summary.code === 302) {
+res.header('Location', 
`${req.protocol}://${req.headers.host}${req.baseUrl}/preview-html/${summary.title}`);
+}
+res.end();
 } else {
 res.status(404);
 }
diff --git a/test/features/mobile-sections-lead/previewHtml.js 
b/test/features/mobile-sections-lead/previewHtml.js
new file mode 100644
index 000..a4ddff4
--- /dev/null
+++ b/test/features/mobile-sections-lead/previewHtml.js
@@ -0,0 +1,54 @@
+'use strict';
+
+const assert = require('../../utils/assert.js');
+const preq   = require('preq');
+const server = require('../../utils/server.js');
+
+describe('preview-html', function() {
+
+this.timeout(2); // eslint-disable-line no-invalid-this
+
+before(() => { return server.start(); });
+
+it('200 For a page that does exist', () => {
+const uri = 
`${server.config.uri}en.wikipedia.org/v1/page/preview-html/Barack Obama`;
+return preq.get({ uri })
+.then((res) => {
+assert.ok(res.status === 200);
+});
+});
+
+it('404 For a page that doesn\'t exist', () => {
+const uri = 
`${server.config.uri}en.wikipedia.org/v1/page/preview-html/ashsahahash`;
+return preq.get({ uri })
+.catch((res) => {
+assert.ok(res.status === 404, 'Pages that do not exist 404');
+});
+});
+
+it('204 for pages that are not wikitext', () => {
+const title = 'Schema:RelatedArticles';
+const uri = 
`${server.config.uri}meta.wikimedia.org/v1/page/preview-html/${title}`;
+return preq.get({ uri })
+.then((res) => {
+assert.ok(res.status === 204, 'If not wikitext we send 204');
+});
+});
+
+it('204 for pages outside content namespace', () => {
+const title = 'Talk:Barack Obama';
+const uri = 
`${server.config.uri}en.wikipedia.org/v1/page/preview-html/${title}`;
+return preq.get({ uri })
+.then((res) => {
+assert.ok(res.status === 204, 'If not in main namespace we 
send 204');
+});
+});
+
+it('302 for pages that are redirects', () => {
+const uri = 
`${server.config.uri}en.wikipedia.org/v1/page/preview-html/Barack`;
+return preq.get({ uri })
+.then((res) => {
+assert.ok(res.status === 302, 'Redirect pages respond with 
302');
+});
+

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add Explore overflow option to access compilations.

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366862 )

Change subject: Add Explore overflow option to access compilations.
..


Add Explore overflow option to access compilations.

This adds an option to the overflow menu in the feed for accessing the
local compilations list. This makes compilations accessible regardless of
whether the user is offline or online.

Change-Id: I7f4632c942244f2028a232524bcdb00173def819
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
M app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
M app/src/main/res/layout/view_explore_overflow.xml
3 files changed, 16 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java 
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index af8ba6a..5d1276a 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -480,5 +480,10 @@
 WikipediaApp.getInstance().logOut();
 FeedbackUtil.showMessage(FeedFragment.this, 
R.string.toast_logout_complete);
 }
+
+@Override
+public void compilationsClick() {
+startActivity(LocalCompilationsActivity.newIntent(getContext()));
+}
 }
 }
diff --git a/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java 
b/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
index cf19813..1c56497 100644
--- a/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
+++ b/app/src/main/java/org/wikipedia/views/ExploreOverflowView.java
@@ -26,6 +26,7 @@
 public interface Callback {
 void loginClick();
 void logoutClick();
+void compilationsClick();
 void settingsClick();
 void donateClick();
 }
@@ -53,7 +54,8 @@
 }
 
 @OnClick({R.id.explore_overflow_settings, R.id.explore_overflow_donate,
-R.id.explore_overflow_account_container, 
R.id.explore_overflow_log_out})
+R.id.explore_overflow_account_container, 
R.id.explore_overflow_log_out,
+R.id.explore_overflow_compilations})
 void onItemClick(View view) {
 if (popupWindowHost != null) {
 popupWindowHost.dismiss();
@@ -68,6 +70,9 @@
 callback.loginClick();
 }
 break;
+case R.id.explore_overflow_compilations:
+callback.compilationsClick();
+break;
 case R.id.explore_overflow_settings:
 callback.settingsClick();
 break;
diff --git a/app/src/main/res/layout/view_explore_overflow.xml 
b/app/src/main/res/layout/view_explore_overflow.xml
index ff534d6..4c4037f 100644
--- a/app/src/main/res/layout/view_explore_overflow.xml
+++ b/app/src/main/res/layout/view_explore_overflow.xml
@@ -46,6 +46,11 @@
 android:background="?attr/window_background_color">
 
 
+
+

-- 
To view, visit https://gerrit.wikimedia.org/r/366862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f4632c942244f2028a232524bcdb00173def819
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Experimental table of content print styles

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366618 )

Change subject: Experimental table of content print styles
..


Experimental table of content print styles

* Provide sense of hierarchy
* Make full width
* Break pages before and after

Bug: T169823
Change-Id: I8a20c70b550de5bfda638873d180ea97880dfd13
---
M print.less
1 file changed, 57 insertions(+), 0 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/print.less b/print.less
index 8e6021d..50c3d30 100644
--- a/print.less
+++ b/print.less
@@ -82,5 +82,62 @@
font-size: 10pt;
}
}
+
+   // Using #toc rather than .toc to override default print style
+   #toc {
+   page-break-before: always;
+   page-break-after: always;
+   font-family: serif;
+   background: none;
+   border: 0;
+   display: block;
+
+   a {
+   border: 0;
+   font-weight: normal;
+   }
+
+   > ul {
+
+   > li {
+   margin-bottom: 20px;
+   font-weight: bold;
+
+   > ul {
+   padding-left: 0;
+   }
+   }
+   }
+
+   ul {
+   margin: 0;
+   list-style: none;
+
+   ul {
+   padding-left: 30px;
+
+   li {
+   padding-left: 30px;
+   }
+   .tocnumber {
+   min-width: 30px;
+   }
+   }
+   }
+
+   li.toclevel-1 {
+   > a {
+   font-weight: bold;
+   font-size: 16px;
+   }
+   }
+
+   .tocnumber {
+   padding-right: 0;
+   text-align: right;
+   margin-right: 30px;
+   display: inline-block;
+   }
+   }
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a20c70b550de5bfda638873d180ea97880dfd13
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Feature flagged print styles

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366173 )

Change subject: Feature flagged print styles
..


Feature flagged print styles

These are feature flagged to allow editors to test before making
them the default. A class is added to the body tag to allow us
to switch between old and new styles at a later date.

To start with we introduce some typography improvements.
Further iterations will focus on other elements.

Changes:
* headings were previously diluted in the body content and difficult to spot.
This evens out the spacing between last content and its own content block.
* clear ownership of s with its heading
* We would like to match Latex style body typography with single column.
The new styles reduce the number of pages by around 20-25%
* hyperlink underline -
This is a community requested feature. We do not use color in print styles
because it's printer friendly. Because of this, it is not possible to indicate
blue links in articles. If a user wants to know if this article exists on 
wikipedia,
it's not possible given solution.
We would like to underline the  tags in print styles.
it's better for accessibility as well.

Bug: T169823
Change-Id: I453ae43099796a74c39d965b796f2fa13942106c
---
M SkinVector.php
A print.less
M skin.json
3 files changed, 112 insertions(+), 0 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified
  Phuedx: Looks good to me, but someone else must approve



diff --git a/SkinVector.php b/SkinVector.php
index 1733bb6..b0915aa 100644
--- a/SkinVector.php
+++ b/SkinVector.php
@@ -40,6 +40,15 @@
$this->vectorConfig = 
ConfigFactory::getDefaultInstance()->makeConfig( 'vector' );
}
 
+   /** @inheritdoc */
+   public function getPageClasses( $title ) {
+   $className = parent::getPageClasses( $title );
+   if ( $this->vectorConfig->get( 'VectorExperimentalPrintStyles' 
) ) {
+   $className .= ' vector-experimental-print-styles';
+   }
+   return $className;
+   }
+
/**
 * Enables the responsive mode
 */
@@ -63,6 +72,14 @@
$this->enableResponsiveMode();
}
 
+   // Print styles are feature flagged.
+   // This flag can be removed when T169732 is resolved.
+   if ( $this->vectorConfig->get( 'VectorExperimentalPrintStyles' 
) ) {
+   // Note, when deploying (T169732) we'll want to fold 
the stylesheet into
+   // skins.vector.styles and remove this module 
altogether.
+   $out->addModuleStyles( 
'skins.vector.styles.experimental.print' );
+   }
+
$out->addModules( 'skins.vector.js' );
}
 
diff --git a/print.less b/print.less
new file mode 100644
index 000..8e6021d
--- /dev/null
+++ b/print.less
@@ -0,0 +1,86 @@
+@pureBlack: #000;
+
+@media print {
+
+   .vector-experimental-print-styles {
+{
+   padding: 10px;
+   font-family: serif;
+   }
+
+   // Normalize Blue links in the article
+   a {
+   border-bottom: 1px solid #aaa;
+   }
+
+   .firstHeading {
+   font-size: 25pt;
+   line-height: 28pt;
+   margin-bottom: 20px;
+   padding-bottom: 5px;
+   }
+
+   // Headings
+   .firstHeading,
+   h2 {
+   border-bottom: 2px solid @pureBlack;
+   }
+
+   h3,
+   h4,
+   h5,
+   h6 {
+   margin: 30px 0 0;
+   font-family: sans-serif;
+   }
+
+   h2,
+   h3,
+   h4,
+   h5,
+   h6 {
+   padding: 0;
+   position: relative;
+   }
+
+   h2 {
+   font-size: 18pt;
+   line-height: 24pt;
+   margin-bottom: 0.25em;
+   }
+
+   h3 {
+   font-size: 13pt;
+   line-height: 20pt;
+   }
+
+   h4,
+   h5,
+   h6 {
+   font-size: 10pt;
+   line-height: 15pt;
+   }
+
+   p {
+   font-size: 10pt;
+   line-height: 16pt;
+   margin-top: 5px;
+   text-align: justify;
+   }
+
+   blockquote {
+   border-left: 2px solid @pureBlack;
+   padding-left: 20px;
+   }
+
+

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix infinite theme change loop in PageActivity.

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366856 )

Change subject: Fix infinite theme change loop in PageActivity.
..


Fix infinite theme change loop in PageActivity.

When changing the theme in PageActivity (while online) it enters an
infinite loop of light/dark theme changes.  This is because of a race
condition between the UserOption uploader uploading the new value and the
UserOption *downloader* downloading the previous value and triggering a
theme change to the old value.

This patch requests a sync of UserOptions only when the activity is
launched freshly (i.e. not restarted via theme change).

Bug: T170756
Change-Id: I830aef92c1c57dc64e42c49550a0b2fcb402534b
---
M app/src/main/java/org/wikipedia/page/PageActivity.java
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java 
b/app/src/main/java/org/wikipedia/page/PageActivity.java
index 14961e1..94f18c2 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivity.java
@@ -168,7 +168,7 @@
 
 // Note: when system language is enabled, and the system language 
is changed outside of
 // the app, MRU languages are not updated. There's no harm in 
doing that here but since
-// the user didin't choose that language in app, it may be 
unexpected.
+// the user didn't choose that language in app, it may be 
unexpected.
 }
 
 if (languageChanged) {
@@ -180,9 +180,9 @@
 // if there's no savedInstanceState, and we're not coming back 
from a Theme change,
 // then we must have been launched with an Intent, so... handle it!
 handleIntent(getIntent());
-}
 
-UserOptionContentResolver.requestManualSync();
+UserOptionContentResolver.requestManualSync();
+}
 }
 
 private void finishActionMode() {

-- 
To view, visit https://gerrit.wikimedia.org/r/366856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I830aef92c1c57dc64e42c49550a0b2fcb402534b
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Query Helper default query

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364274 )

Change subject: Query Helper default query
..


Query Helper default query

Load an empty query as default query when no SPARQL query is defined.

Change-Id: I504b8d1978867aaeeae9ec0e9ce9edeff8fe8344
---
M wikibase/queryService/ui/App.js
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index 596ca2d..943b1ab 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -5,10 +5,10 @@
 wikibase.queryService.ui.App = ( function( $, download, window, _, Cookies, 
moment ) {
'use strict';
 
-   var SHORTURL_API = '//tinyurl.com/api-create.php?url=';
-   var RAWGRAPHS_BASE_URL = 'http://wikidata.rawgraphs.io/?url=';
-
-   var TRACKING_NAMESPACE = 'wikibase.queryService.ui.app.';
+   var SHORTURL_API = '//tinyurl.com/api-create.php?url=',
+   RAWGRAPHS_BASE_URL = 'http://wikidata.rawgraphs.io/?url=',
+   TRACKING_NAMESPACE = 'wikibase.queryService.ui.app.',
+   DEFAULT_QUERY = 'SELECT * WHERE {} LIMIT 20';
 
/**
 * A ui application for the Wikibase query service
@@ -221,6 +221,8 @@
 
return false;
} );
+
+   window.setTimeout( $.proxy( this._drawQueryHelper, this ), 500 
);
};
 
/**
@@ -228,7 +230,7 @@
 */
SELF.prototype._drawQueryHelper = function() {
try {
-   this._queryHelper.setQuery( this._editor.getValue() );
+   this._queryHelper.setQuery( this._editor.getValue() || 
DEFAULT_QUERY );
this._queryHelper.draw( $( '.query-helper .panel-body' 
) );
$( '.query-helper' ).css( 'min-width', '' );
this._updateQueryHelperMinWidth(); // TODO also do this 
after labels in the query helper have loaded

-- 
To view, visit https://gerrit.wikimedia.org/r/364274
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I504b8d1978867aaeeae9ec0e9ce9edeff8fe8344
Gerrit-PatchSet: 4
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove ldap user and password from secure.config

2017-07-21 Thread Paladox (Code Review) 
Paladox has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366910 )

Change subject: Gerrit: Remove ldap user and password from secure.config
..

Gerrit: Remove ldap user and password from secure.config

It's not really needed now or is it?

We can connect annon to ldap we doing need a user or password.

Change-Id: Ie1df3bfc706129ba5d7f4ec82d08cde1e228e3fe
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/10/366910/1


-- 
To view, visit https://gerrit.wikimedia.org/r/366910
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1df3bfc706129ba5d7f4ec82d08cde1e228e3fe
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit: make name of config template flexible

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366911 )

Change subject: gerrit: make name of config template flexible
..

gerrit: make name of config template flexible

Make the name of the config template file flexible and set it
via Hiera, to allow using a different template on a VPS
to test config changes before they hit production.

Also allows changing LDAP server name as was intended with
Ia1e9f932fc7daf9889 and is necessary now since prod LDAP server
won't allow connections from "labs" anymore.

Change-Id: I989e746c6c4f7a9b53608dafb6ffcd68fb1b2c0c
---
M hieradata/role/common/gerrit/server.yaml
M modules/gerrit/manifests/jetty.pp
M modules/profile/manifests/gerrit/server.pp
3 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/11/366911/1

diff --git a/hieradata/role/common/gerrit/server.yaml 
b/hieradata/role/common/gerrit/server.yaml
index 4b42a98..78a217b 100644
--- a/hieradata/role/common/gerrit/server.yaml
+++ b/hieradata/role/common/gerrit/server.yaml
@@ -8,6 +8,7 @@
 gerrit::server::host: 'gerrit.wikimedia.org'
 gerrit::server::master_host: 'cobalt.wikimedia.org'
 gerrit::server::bacula: 'srv-gerrit-git'
+gerrit::server::config 'gerrit.config.erb'
 
 # list of gerrit servers used in firewall rules
 gerrit::servers:
diff --git a/modules/gerrit/manifests/jetty.pp 
b/modules/gerrit/manifests/jetty.pp
index 874ac8f..308feb8 100644
--- a/modules/gerrit/manifests/jetty.pp
+++ b/modules/gerrit/manifests/jetty.pp
@@ -11,6 +11,7 @@
 $java_home = '/usr/lib/jvm/java-8-openjdk-amd64/jre',
 $log_host = undef,
 $log_port = '4560'
+$gerrit_config = 'gerrit.config.erb',
 ) {
 
 include ::nrpe
@@ -158,8 +159,9 @@
 require => File['/var/lib/gerrit2/review_site'],
 }
 
+1G
 file { '/var/lib/gerrit2/review_site/etc/gerrit.config':
-content => template('gerrit/gerrit.config.erb'),
+content => template('gerrit/${gerrit_config}'),
 owner   => 'gerrit2',
 group   => 'gerrit2',
 mode=> '0444',
diff --git a/modules/profile/manifests/gerrit/server.pp 
b/modules/profile/manifests/gerrit/server.pp
index c5d1cb5..20a3f16 100644
--- a/modules/profile/manifests/gerrit/server.pp
+++ b/modules/profile/manifests/gerrit/server.pp
@@ -8,6 +8,7 @@
 $master_host = hiera('gerrit::server::master_host'),
 $bacula = hiera('gerrit::server::bacula'),
 $gerrit_servers = join(hiera('gerrit::servers'), ' ')
+$config = hiera('gerrit::server::config'),
 ) {
 
 interface::alias { 'gerrit server':
@@ -65,7 +66,8 @@
 }
 
 class { '::gerrit':
-host  => $host,
-slave => $slave,
+host   => $host,
+slave  => $slave,
+config => $gerrit_config,
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I989e746c6c4f7a9b53608dafb6ffcd68fb1b2c0c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Expose content model in response

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366909 )

Change subject: Expose content model in response
..

Expose content model in response

Certain pages are not wikitext. This flags those to the client.
e.g.
meta.wikimedia.org/wiki/Schema:RelatedArticles

Change-Id: Idb67a564a386cad86a5412cf5f0d885bb2e56bd7
---
M lib/mwapi.js
M routes/mobile-sections.js
M test/features/mobile-sections-lead/pagecontent.js
3 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/09/366909/1

diff --git a/lib/mwapi.js b/lib/mwapi.js
index d092d2b..0ade581 100644
--- a/lib/mwapi.js
+++ b/lib/mwapi.js
@@ -123,7 +123,7 @@
 mwapi.getMetadata = function(app, req) {
 const props = ['languagecount', 'thumb', 'image', 'id', 'revision', 
'description',
 'lastmodified', 'lastmodifiedby', 'normalizedtitle', 'displaytitle', 
'protection',
-'editable', 'namespace', 'pageprops'];
+'editable', 'namespace', 'pageprops', 'contentmodel'];
 
 const query = {
 action: 'mobileview',
diff --git a/routes/mobile-sections.js b/routes/mobile-sections.js
index 719a6a5..8fee414 100644
--- a/routes/mobile-sections.js
+++ b/routes/mobile-sections.js
@@ -120,6 +120,7 @@
 
 return {
 ns: input.meta.ns,
+contentmodel: input.meta.contentmodel,
 userinfo: input.meta.userinfo,
 imageinfo: input.meta.imageinfo,
 id: input.meta.id,
diff --git a/test/features/mobile-sections-lead/pagecontent.js 
b/test/features/mobile-sections-lead/pagecontent.js
index 95a612f..827baf2 100644
--- a/test/features/mobile-sections-lead/pagecontent.js
+++ b/test/features/mobile-sections-lead/pagecontent.js
@@ -284,4 +284,14 @@
 'Disambiguation flag is missing in meta data.');
 });
 });
+it('Content model present in response', () => {
+const title = 'Schema:RelatedArticles';
+const uri = 
`${server.config.uri}meta.wikimedia.org/v1/page/mobile-sections-lead/${title}`;
+return preq.get({ uri })
+.then((res) => {
+assert.deepEqual(res.status, 200);
+assert.ok(res.body.contentmodel === 'JsonSchema',
+'Article flagged as a JsonSchema.');
+});
+});
 });

-- 
To view, visit https://gerrit.wikimedia.org/r/366909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb67a564a386cad86a5412cf5f0d885bb2e56bd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: android: drop -no-audio

2017-07-21 Thread Hashar (Code Review) 
Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366908 )

Change subject: android: drop -no-audio
..

android: drop -no-audio

When not using the classic engine (qemu2??) the emulator errors out
with:

  qemu-system-i386: -audio: invalid option

Stop passing -no-audio to the emulator.

Bug: T150623
Change-Id: I822057a37693735a1ccfeccc0fd23bb182c7b101
---
M jjb/mobile.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/08/366908/1

diff --git a/jjb/mobile.yaml b/jjb/mobile.yaml
index 135dff1..66127fa 100644
--- a/jjb/mobile.yaml
+++ b/jjb/mobile.yaml
@@ -83,7 +83,7 @@
  screen-density: 240
  target-abi: x86
  show-window: true
- commandline-options: -no-window -no-audio -no-boot-anim
+ commandline-options: -no-window -no-boot-anim
  hardware-properties:
 # Required for emulators to terminate: 
https://wiki.jenkins-ci.org/display/JENKINS/Android+Emulator+Plugin#AndroidEmulatorPlugin-Knownissues
 hw.audioInput: no

-- 
To view, visit https://gerrit.wikimedia.org/r/366908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I822057a37693735a1ccfeccc0fd23bb182c7b101
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Fix layout regression in notification popup footer

2017-07-21 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366903 )

Change subject: Fix layout regression in notification popup footer
..

Fix layout regression in notification popup footer

Caused by a new margin rule in OOUI.

Bug: T171302
Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/03/366903/1

diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less 
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 2c2f0aa..183edf9 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -56,6 +56,9 @@
border-top: 1px solid #ddd;
width: 100%;
 
+   // Override the margins that OOUI suddenly 
added to popup footers (T171302)
+   margin: 0;
+
> .oo-ui-buttonGroupWidget {
display: block;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/366903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5746d9e6a2daa2b0d18e76a99e67c8fdaa1464d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: admins: Update aude's ssh key

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363180 )

Change subject: admins: Update aude's ssh key
..


admins: Update aude's ssh key

back to the one on my old WMDE macbook, which I use
for now until I fix or replace my personal laptop.

https://gerrit.wikimedia.org/r/#/c/207079/2/modules/admin/data/data.yaml

Change-Id: I5075d1071da70c6581d46e31208605599b2354f1
---
M modules/admin/data/data.yaml
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  WMDE-leszek: Looks good to me, but someone else must approve
  Ladsgroup: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
  Dzahn: Looks good to me, approved



diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index 778e2e9..0385d60 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -822,8 +822,7 @@
 gid: 500
 name: aude
 realname: Katie Filbert
-ssh_keys: [ssh-rsa 
B3NzaC1yc2EDAQABAAACAQC4isIiXTX8cAcOD30Pb5Auy/NqidYSEqzrybfEti/qbJf0cTuqPzrNnp3cPK76yTwW+6aTjH8LC71GjaM7gHs2hn4xQJDJVPvH8FHd+RWjndigIOAEPlKtlyXPRor32lNhDFjNDMwS0gJgwJWGyzdDSPap4A9oAYvOlXHMbwF86gPoTKTCIhKSwryUyn9XXYKpa3nwYHchJ0ugVrxo31KHu107YbGpquocEg3I+fPftJHRxDlhVho09OnzZedTKacNJvAkH+8F9AWEl8mQRYxA/5Bpm4ty1spCHcPU0LEpMFFRnSjb13p1e3Xh+rhwLg3NREW+nRI9DKHassaUvkfQnVipCjNpFy3gX70LS0u+M+vg8wUM88AYVMn1VohN9RbXFPnMHHZACeWJCClCj08qI/Z5WDEUCKBAv4B3nrlYHxMGsa+HAKHREvH+YQI3l4WauIq1Ri5qCVkhEZQKEKVH5uMny1bE3XMolsi1jwxQTiRWbctmGOPjUtXeSBe9N8yWzWmcduzbd60ipItclRqD8gh6FvE1Nb5AtWTkR1wdu691VZpN1BNf14joYz8eq8I6W2JupB4EYUnru3PQS0wQI+/RqWApCvWG4ajtp8hOTicwPSrXRhsYBWbg+HNzhI/KlQelwhm4MnZAESRtm+VgOl1g2kRpicHoiS+oGh1iXQ==
-katie@katie-UX303LNB]
+ssh_keys: [ssh-rsa 
B3NzaC1yc2EDAQABAAABAQC+OiQ1ptiP6VqmiP8IOp0sKET9pQHOJxscK6bAvAmAP72DL9MgLIBaWpaL9iWsb/DMXI2CQpEnu88VMVXCSgiqw+Gy6Q93pAquAQWAzkMnDD+QvxTm23oFCxP795IEP3JMHuONNg2x3NU3jYaOADOGZX41nRhbkO4yl32jQCTF9i670KS+CFDHxRzmOMzNhlytWJYyVPS6iqUGykaFcebFNThMtRtQF+pWJNreCFxZoXp1TyzkiJE1rX98tj2yhVQmET6mENuGXuAES/Atzpxp8zvsckHn06Mm1RZZmIExEqn/JdK6nHs1UoSNpsI195ltzkKSEWdFdYKRLZNFuRBL
 aude.w...@gmail.com]
 uid: 1185
 email: aude.w...@gmail.com
   awight:

-- 
To view, visit https://gerrit.wikimedia.org/r/363180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5075d1071da70c6581d46e31208605599b2354f1
Gerrit-PatchSet: 6
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Aude 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc: remove now unused phab director iridium

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366896 )

Change subject: cache::misc: remove now unused phab director iridium
..


cache::misc: remove now unused phab director iridium

This director has been renamed/replace by 'phabricator'
in Ifc73692e947d7a3d666 and is now unused.

Change-Id: Ifa9c3f6f77f6129febf062dc93475da3dd266e4d
---
M hieradata/role/common/cache/misc.yaml
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/common/cache/misc.yaml 
b/hieradata/role/common/cache/misc.yaml
index 29df6f7..a5e4a5c 100644
--- a/hieradata/role/common/cache/misc.yaml
+++ b/hieradata/role/common/cache/misc.yaml
@@ -72,9 +72,6 @@
   graphite2001:
 backends:
   eqiad: 'graphite2001.codfw.wmnet'
-  iridium:
-backends:
-  eqiad: 'iridium.eqiad.wmnet'
   krypton:
 backends:
   eqiad: 'krypton.eqiad.wmnet'

-- 
To view, visit https://gerrit.wikimedia.org/r/366896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa9c3f6f77f6129febf062dc93475da3dd266e4d
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[wmf/1.30.0-wmf.10]: Add missing jQueryMsg dependency for mobile diff view

2017-07-21 Thread Mattflaschen (Code Review) 
Mattflaschen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366899 )

Change subject: Add missing jQueryMsg dependency for mobile diff view
..

Add missing jQueryMsg dependency for mobile diff view

Bug: T170917
Change-Id: Ibca76902e0d748b95bb57e871993a4dc2664d5cd
(cherry picked from commit 545a7de5e2eaadaa7d245e92eabe472b784d6b1b)
---
M extension.json
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks 
refs/changes/99/366899/1

diff --git a/extension.json b/extension.json
index 314b78f..5e30b49 100644
--- a/extension.json
+++ b/extension.json
@@ -102,6 +102,7 @@
],
"dependencies": [
"mediawiki.api",
+   "mediawiki.jqueryMsg",
"mediawiki.notify"
],
"targets": [

-- 
To view, visit https://gerrit.wikimedia.org/r/366899
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibca76902e0d748b95bb57e871993a4dc2664d5cd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Mattflaschen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add tracking for selected query category

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366554 )

Change subject: Add tracking for selected query category
..


Add tracking for selected query category

Change-Id: I0092b334abe3141a0719bb9600dcf529233533e3
---
M wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikibase/queryService/ui/QueryExampleDialog.js 
b/wikibase/queryService/ui/QueryExampleDialog.js
index 787a895..30c9948 100644
--- a/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/wikibase/queryService/ui/QueryExampleDialog.js
@@ -120,7 +120,7 @@
self._$element.find( '.searchable' 
).append( $( '' ).addClass( 'active' )
.append( $( '' ).text( category ) ) );
}
-   self._addExample( example.title, example.query, 
example.href, example.tags );
+   self._addExample( example.title, example.query, 
example.href, example.tags, category );
} );
} );
};
@@ -222,12 +222,13 @@
/**
 * @private
 */
-   SELF.prototype._addExample = function( title, query, href, tags ) {
+   SELF.prototype._addExample = function( title, query, href, tags, 
category ) {
var self = this,
$link = $( '' 
).text( title ).attr( 'href', '#' )
.click( function() {
self._callback( query, title );
self._track( 'select' );
+   self._track( 'select.category.' 
+ category.replace( /[^a-zA-Z0-9]/g, '_' ) );
} ),
$edit = $( '' )
.attr( { title: 'Edit', href: href, target: 
'_blank' } )

-- 
To view, visit https://gerrit.wikimedia.org/r/366554
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0092b334abe3141a0719bb9600dcf529233533e3
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Auto hide and show query box on scroll

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366522 )

Change subject: Auto hide and show query box on scroll
..


Auto hide and show query box on scroll

This reduces the amount of scrolling needed when switching between the
editor and the query result, which is especially convenient when the
query result consumes scroll events (Map view).

The result navbar is moved out of the query box so that it is still
visible when the query box is hidden.

Change-Id: Iced825177110be330e40333b5e85ad7b3c00103c
---
M index.html
M wikibase/queryService/ui/App.js
2 files changed, 31 insertions(+), 15 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  Jonas Kress (WMDE): Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/index.html b/index.html
index 6a4c958..0efbb69 100644
--- a/index.html
+++ b/index.html
@@ -171,6 +171,23 @@

 

+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   For interactive query editing, 
a localized user interface, and other improvements,
+   please enable JavaScript or use 
a browser that supports it.
+   
+   
+   
+   
+   



@@ -214,22 +231,7 @@



-   
-   

-   
-   
-   
-   
-   
-   
-   
-   For interactive query editing, 
a localized user interface, and other improvements,
-   please enable JavaScript or use 
a browser that supports it.
-   
-   
-   
-   

Test result

diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index a23816c..e72975b 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -124,6 +124,20 @@
this._initQuery();
this._initRdfNamespaces();
this._initHandlers();
+
+   $( window ).scroll( function () {
+   var minScroll = $( '#query-box' ).offset().top + $( 
'#query-box' ).height() - $( window ).height();
+
+   if ( minScroll + 100 < $( this ).scrollTop() && $( this 
).scrollTop() > 1 ) {
+   $( '#query-box' ).hide( {
+   duration: 500
+   } );
+   } else {
+   $( '#query-box' ).show( {
+   duration: 100
+   } );
+   }
+   } );
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/366522
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iced825177110be330e40333b5e85ad7b3c00103c
Gerrit-PatchSet: 4
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Display border-bottom when figcaption isn't present

2017-07-21 Thread Arlolra (Code Review) 
Arlolra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366898 )

Change subject: Display border-bottom when figcaption isn't present
..

Display border-bottom when figcaption isn't present

 * Parsoid doesn't emit a figcaption when no caption is present, so
   having the border-bottom styled on it meant there are cases where it
   goes missing.

Change-Id: I2ff8e41d3cb973f56f6571d84fb662aed23b1f10
---
M resources/src/mediawiki.skinning/content.parsoid.less
1 file changed, 19 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/98/366898/1

diff --git a/resources/src/mediawiki.skinning/content.parsoid.less 
b/resources/src/mediawiki.skinning/content.parsoid.less
index 7a7df7a..cf32055 100644
--- a/resources/src/mediawiki.skinning/content.parsoid.less
+++ b/resources/src/mediawiki.skinning/content.parsoid.less
@@ -86,27 +86,9 @@
float: none;
}
 
+   /* Hide the caption for frameless and plain floated images */
> figcaption {
-   display: table-caption;
-   caption-side: bottom;
-   /* In mw-core the font-size is duplicated, 94% in thumbiner
-* and again 94% in thumbcaption. 88.4% for font size of the
-* caption results in the same behavior. */
-   font-size: 88.4%;
-   line-height: 1.4em;
-   text-align: left;
-
-   border: 1px solid #c8ccd1;
-   border-top: 0;
-
-   /* taken from .thumbcaption, plus .thumbinner */
-   padding: 0 6px 6px 6px;
-   background-color: #f8f9fa;
-
-   table {
-   /* reset caption side for tables inside figcaptions */
-   caption-side: top;
-   }
+   display: none;
}
 }
 
@@ -117,12 +99,12 @@
 figure[typeof~='mw:Video/Frame'],
 figure[typeof~='mw:Audio/Frame'] {
display: table;
-   overflow: auto;
text-align: center;
border: 1px solid #c8ccd1;
-   border-bottom: 0; // No border to caption
-   border-collapse: collapse;
background-color: #f8f9fa;
+   width: 1px;  // From https://stackoverflow.com/a/6536025
+   padding: 3px;
+
// Default to right alignment. This is needed since Parsoid only 
specifies the
// alignment class when the alignment is explicitly set.
margin: 0.5em 0 1.3em 1.4em;
@@ -133,9 +115,22 @@
> img,
> video {
border: 1px solid #c8ccd1;
-   margin: 3px;
background: #fff;
}
+   }
+
+   > figcaption {
+   display: block;
+
+   /* In mw-core the font-size is duplicated, 94% in thumbiner
+* and again 94% in thumbcaption. 88.4% for font size of the
+* caption results in the same behavior. */
+   font-size: 88.4%;
+   line-height: 1.4em;
+   text-align: left;
+
+   /* taken from .thumbcaption, plus .thumbinner */
+   padding: 3px;
}
 }
 
@@ -144,17 +139,5 @@
> img,
> video {
border: 1px solid #eaecf0;
-   }
-}
-
-/* Hide the caption for frameless and plain floated images */
-figure[typeof~='mw:Image/Frameless'],
-figure[typeof~='mw:Video/Frameless'],
-figure[typeof~='mw:Audio/Frameless'],
-figure[typeof~='mw:Image'],
-figure[typeof~='mw:Video'],
-figure[typeof~='mw:Audio'] {
-   > figcaption {
-   display: none;
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/366898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ff8e41d3cb973f56f6571d84fb662aed23b1f10
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Arlolra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Minify design of updater status

2017-07-21 Thread Jonas Kress (WMDE) (Code Review) 
Jonas Kress (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366897 )

Change subject: Minify design of updater status
..

Minify design of updater status

Replace text from updater status with icon and move text into the
popover.

Change-Id: I9fd9a760a872469465bf148066784c9a2d959211
---
M index.html
M wikibase/queryService/ui/App.js
2 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/97/366897/1

diff --git a/index.html b/index.html
index 6a4c958..937db99 100644
--- a/index.html
+++ b/index.html
@@ -165,7 +165,7 @@



-   
+   

 

diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index 596ca2d..a2dcd14 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -336,19 +336,14 @@
 
var updateDataStatus = function() {
self._sparqlApi.queryDataUpdatedTime().done( function( 
time, difference ) {
-   var updatestatustext = moment.duration( 
difference, 'seconds' ).humanize(),
-   labelClass,
-   badge;
-
+   var labelClass = 'list-group-item-danger';
if ( difference <= 60 * 2 ) {
labelClass = 'list-group-item-success';
} else if ( difference <= 60 * 15 ) {
labelClass =  'list-group-item-warning';
-   } else {
-   labelClass = 'list-group-item-danger';
}
-   badge = '' + updatestatustext + '';
-   $label.html( $.i18n( 'wdqs-app-footer-updated', 
badge ) );
+
+   $label.html( $( '' ).addClass( 'fa 
fa-refresh badge ' + labelClass ).html( ' ' ) );
} );
};
 
@@ -361,10 +356,13 @@
 
var e = $( this );
self._sparqlApi.queryDataUpdatedTime().done( function( 
time, difference ) {
+   var text = moment.duration( difference, 
'seconds' ).humanize(),
+   badge = '' + 
text + '';
+
e.popover( {
html: true,
placement: 'top',
-   content: $.i18n( 
'wdqs-app-footer-updated-seconds', difference ) + '.' + time
+   content: $.i18n( 
'wdqs-app-footer-updated', badge )
} ).popover( 'show' );
} ).fail( function() {
e.popover( {

-- 
To view, visit https://gerrit.wikimedia.org/r/366897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd9a760a872469465bf148066784c9a2d959211
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc: remove now unused phab director iridium

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366896 )

Change subject: cache::misc: remove now unused phab director iridium
..

cache::misc: remove now unused phab director iridium

This director has been renamed/replace by 'phabricator'
in Ifc73692e947d7a3d666 and is now unused.

Change-Id: Ifa9c3f6f77f6129febf062dc93475da3dd266e4d
---
M hieradata/role/common/cache/misc.yaml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/96/366896/1

diff --git a/hieradata/role/common/cache/misc.yaml 
b/hieradata/role/common/cache/misc.yaml
index 29df6f7..a5e4a5c 100644
--- a/hieradata/role/common/cache/misc.yaml
+++ b/hieradata/role/common/cache/misc.yaml
@@ -72,9 +72,6 @@
   graphite2001:
 backends:
   eqiad: 'graphite2001.codfw.wmnet'
-  iridium:
-backends:
-  eqiad: 'iridium.eqiad.wmnet'
   krypton:
 backends:
   eqiad: 'krypton.eqiad.wmnet'

-- 
To view, visit https://gerrit.wikimedia.org/r/366896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa9c3f6f77f6129febf062dc93475da3dd266e4d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc: rename director for phabricator from iridium

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366893 )

Change subject: cache::misc: rename director for phabricator from iridium
..


cache::misc: rename director for phabricator from iridium

"iridium" is the name of a server, not a good name for the
director itself as there will be multiple servers replacing
iridium, phab1001,phab2001.

So renaming it by adding a new director "phabricator" first
with the same existing backend.

Removing the old director and switching phab to new backend
will be separate steps.

Change-Id: Ifc73692e947d7a3d6664a43dfdd92288277b6c4e
---
M hieradata/role/common/cache/misc.yaml
1 file changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/common/cache/misc.yaml 
b/hieradata/role/common/cache/misc.yaml
index 69e6718..29df6f7 100644
--- a/hieradata/role/common/cache/misc.yaml
+++ b/hieradata/role/common/cache/misc.yaml
@@ -97,6 +97,9 @@
   dbtree:
 backends:
   eqiad: 'terbium.eqiad.wmnet'
+  phabricator:
+backends:
+  eqiad: 'iridium.eqiad.wmnet'
   planet:
 backends:
   eqiad: 'planet1001.eqiad.wmnet'
@@ -145,9 +148,9 @@
   annual.wikimedia.org:
 director: 'bromine'
   bugs.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   bugzilla.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   config-master.wikimedia.org:
 director: 'pybal_config'
 caching: 'pass'
@@ -166,7 +169,7 @@
 director: 'etherpad1001'
 caching: 'websockets'
   git.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   grafana-admin.wikimedia.org:
 director: 'krypton'
 caching: 'pass'
@@ -215,9 +218,9 @@
   performance.wikimedia.org:
 director: 'graphite1001'
   phabricator.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   phab.wmfusercontent.org:
-director: 'iridium'
+director: 'phabricator'
   pivot.wikimedia.org:
 director: 'thorium'
   piwik.wikimedia.org:

-- 
To view, visit https://gerrit.wikimedia.org/r/366893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc73692e947d7a3d6664a43dfdd92288277b6c4e
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[wmf/1.30.0-wmf.10]: Default constraint parameters to []

2017-07-21 Thread Lucas Werkmeister (WMDE) (Code Review) 
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366895 )

Change subject: Default constraint parameters to []
..

Default constraint parameters to []

I don’t know why $constraintParameters would ever be null here, but it
seems to happen, so for now default to empty parameters in that case.

Bug: T171295
Change-Id: I7ea8b8936d9b4e0beae8a5ee0cfd92b8b49a0035
---
M includes/ConstraintRepository.php
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
 refs/changes/95/366895/1

diff --git a/includes/ConstraintRepository.php 
b/includes/ConstraintRepository.php
index 29fbd93..497e5c1 100644
--- a/includes/ConstraintRepository.php
+++ b/includes/ConstraintRepository.php
@@ -3,6 +3,7 @@
 namespace WikibaseQuality\ConstraintReport;
 
 use InvalidArgumentException;
+use MediaWiki\Logger\LoggerFactory;
 use Wikimedia\Rdbms\DBUnexpectedError;
 use Wikimedia\Rdbms\LikeMatch;
 use Wikibase\DataModel\Entity\PropertyId;
@@ -137,6 +138,17 @@
$constraintTypeItemId = $result->constraint_type_qid;
$constraintParameters = json_decode( 
$result->constraint_parameters, true );
 
+   if ( $constraintParameters === null ) {
+   // T171295
+   LoggerFactory::getInstance( 
'WikibaseQualityConstraints' )
+   ->warning( 'Constraint {constraintId} 
has invalid constraint parameters.', [
+   'method' => __METHOD__,
+   'constraintId' => 
$result->constraint_guid,
+   'constraintParameters' => 
$result->constraint_parameters,
+   ] );
+   $constraintParameters = [];
+   }
+
$constraints[] = new Constraint(
$result->constraint_guid,
PropertyId::newFromNumber( $result->pid ),

-- 
To view, visit https://gerrit.wikimedia.org/r/366895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ea8b8936d9b4e0beae8a5ee0cfd92b8b49a0035
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: wmf/1.30.0-wmf.10
Gerrit-Owner: Lucas Werkmeister (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BetaFeatures[master]: Hygiene: Define PHPUnit group for unit tests

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366891 )

Change subject: Hygiene: Define PHPUnit group for unit tests
..


Hygiene: Define PHPUnit group for unit tests

While testing different extensions which depend upon BetaFeatures
extension it should be possible to narrow tests to specific extension
only. To do that unit test have to specify the group they belong.

Changes:
 - introduced group called BetaFeatures
 - added @group annotation to every BetaFeatures unit tests

Change-Id: I58848f46a32fc39238d30d023c3e321502643900
---
M tests/phpunit/AutoEnrollmentTest.php
M tests/phpunit/BetaFeaturesTestCase.php
M tests/phpunit/DependentFeatureTest.php
M tests/phpunit/HTMLFeatureFieldTest.php
M tests/phpunit/HTMLHorizontalRuleTest.php
M tests/phpunit/HTMLTextBlockTest.php
M tests/phpunit/HooksRunTest.php
M tests/phpunit/NewHTMLCheckFieldTest.php
M tests/phpunit/PreferenceHandlingTest.php
9 files changed, 27 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/tests/phpunit/AutoEnrollmentTest.php 
b/tests/phpunit/AutoEnrollmentTest.php
index f397a1c..3b801dd 100644
--- a/tests/phpunit/AutoEnrollmentTest.php
+++ b/tests/phpunit/AutoEnrollmentTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class AutoEnrollmentTest extends BetaFeaturesTestCase {
 
// Structure of testing preference
diff --git a/tests/phpunit/BetaFeaturesTestCase.php 
b/tests/phpunit/BetaFeaturesTestCase.php
index e884450..47a9113 100644
--- a/tests/phpunit/BetaFeaturesTestCase.php
+++ b/tests/phpunit/BetaFeaturesTestCase.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class BetaFeaturesTestCase extends MediaWikiTestCase {
 
protected function setUp() {
diff --git a/tests/phpunit/DependentFeatureTest.php 
b/tests/phpunit/DependentFeatureTest.php
index c2f45c7..bc9f8bf 100644
--- a/tests/phpunit/DependentFeatureTest.php
+++ b/tests/phpunit/DependentFeatureTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class DependentFeatureTest extends BetaFeaturesTestCase {
 
// Key for testing preference
diff --git a/tests/phpunit/HTMLFeatureFieldTest.php 
b/tests/phpunit/HTMLFeatureFieldTest.php
index de01c0a..bbbf8c8 100644
--- a/tests/phpunit/HTMLFeatureFieldTest.php
+++ b/tests/phpunit/HTMLFeatureFieldTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HTMLFeatureFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/HTMLHorizontalRuleTest.php 
b/tests/phpunit/HTMLHorizontalRuleTest.php
index 06be579..5b27836 100644
--- a/tests/phpunit/HTMLHorizontalRuleTest.php
+++ b/tests/phpunit/HTMLHorizontalRuleTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HTMLHorizontalRuleFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/HTMLTextBlockTest.php 
b/tests/phpunit/HTMLTextBlockTest.php
index f526106..3de29c8 100644
--- a/tests/phpunit/HTMLTextBlockTest.php
+++ b/tests/phpunit/HTMLTextBlockTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HTMLTextBlockFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/HooksRunTest.php b/tests/phpunit/HooksRunTest.php
index 94b970f..15727e0 100644
--- a/tests/phpunit/HooksRunTest.php
+++ b/tests/phpunit/HooksRunTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HooksRunTest extends MediaWikiTestCase {
 
// Key for testing preference
diff --git a/tests/phpunit/NewHTMLCheckFieldTest.php 
b/tests/phpunit/NewHTMLCheckFieldTest.php
index 5fd25b6..f0671de 100644
--- a/tests/phpunit/NewHTMLCheckFieldTest.php
+++ b/tests/phpunit/NewHTMLCheckFieldTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class NewHTMLCheckFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/PreferenceHandlingTest.php 
b/tests/phpunit/PreferenceHandlingTest.php
index 103a451..a36532f 100644
--- a/tests/phpunit/PreferenceHandlingTest.php
+++ b/tests/phpunit/PreferenceHandlingTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class

[MediaWiki-commits] [Gerrit] translatewiki[master]: Fixed ignored and optional messages

2017-07-21 Thread John Erling Blad (Code Review) 
John Erling Blad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366894 )

Change subject: Fixed ignored and optional messages
..

Fixed ignored and optional messages

Removed keys for optional "-wrap-" and "-translated" messages,
and ignored "-original" and "-original-num" messages,
and added a new optional "-keyword" message.

Bug: T168691

Change-Id: I934757012a8e2b9b2c8787fd90762f1966d81d56
---
M groups/MediaWiki/mwgithub.yaml
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/94/366894/1

diff --git a/groups/MediaWiki/mwgithub.yaml b/groups/MediaWiki/mwgithub.yaml
index 443c73d..65be6ea 100644
--- a/groups/MediaWiki/mwgithub.yaml
+++ b/groups/MediaWiki/mwgithub.yaml
@@ -341,12 +341,9 @@
 - pickle-testcase-invoke
 - pickle-default-subpage
 - pickle-default-invoke
-- pickle-report-*-wrap-*
-- pickle-report-*-translated
+- pickle-report-*-keyword
 - pickle-report-*-no-description
 
   ignored:
 - pickle-testspec-subpage
 - pickle-testspec-invoke
-- pickle-report-*-original
-- pickle-report-*-original-num

-- 
To view, visit https://gerrit.wikimedia.org/r/366894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I934757012a8e2b9b2c8787fd90762f1966d81d56
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: John Erling Blad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cache::misc: rename director for phabricator from iridium

2017-07-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366893 )

Change subject: cache::misc: rename director for phabricator from iridium
..

cache::misc: rename director for phabricator from iridium

"iridium" is the name of a server, not a good name for the
director itself as there will be multiple servers replacing
iridium, phab1001,phab2001.

So renaming it by adding a new director "phabricator" first
with the same existing backend.

Removing the old director and switching phab to new backend
will be separate steps.

Change-Id: Ifc73692e947d7a3d6664a43dfdd92288277b6c4e
---
M hieradata/role/common/cache/misc.yaml
1 file changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/93/366893/1

diff --git a/hieradata/role/common/cache/misc.yaml 
b/hieradata/role/common/cache/misc.yaml
index 69e6718..29df6f7 100644
--- a/hieradata/role/common/cache/misc.yaml
+++ b/hieradata/role/common/cache/misc.yaml
@@ -97,6 +97,9 @@
   dbtree:
 backends:
   eqiad: 'terbium.eqiad.wmnet'
+  phabricator:
+backends:
+  eqiad: 'iridium.eqiad.wmnet'
   planet:
 backends:
   eqiad: 'planet1001.eqiad.wmnet'
@@ -145,9 +148,9 @@
   annual.wikimedia.org:
 director: 'bromine'
   bugs.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   bugzilla.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   config-master.wikimedia.org:
 director: 'pybal_config'
 caching: 'pass'
@@ -166,7 +169,7 @@
 director: 'etherpad1001'
 caching: 'websockets'
   git.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   grafana-admin.wikimedia.org:
 director: 'krypton'
 caching: 'pass'
@@ -215,9 +218,9 @@
   performance.wikimedia.org:
 director: 'graphite1001'
   phabricator.wikimedia.org:
-director: 'iridium'
+director: 'phabricator'
   phab.wmfusercontent.org:
-director: 'iridium'
+director: 'phabricator'
   pivot.wikimedia.org:
 director: 'thorium'
   piwik.wikimedia.org:

-- 
To view, visit https://gerrit.wikimedia.org/r/366893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc73692e947d7a3d6664a43dfdd92288277b6c4e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add sensible defaults to mediawiki.hlist module

2017-07-21 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366892 )

Change subject: Add sensible defaults to mediawiki.hlist module
..

Add sensible defaults to mediawiki.hlist module

This allows skins to define how hlists appear (e.g. which pseudo
elements to use or whether to use them at all)  while
providing some sensible defaults.

Bug: T42062
Change-Id: I61b5f077d8b4a4c7fe845b7b6d1df98bb2dbafc8
---
M resources/Resources.php
A resources/src/mediawiki/mediawiki.hlist-allskins.less
M resources/src/mediawiki/mediawiki.hlist.css
3 files changed, 24 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/366892/1

diff --git a/resources/Resources.php b/resources/Resources.php
index 33fb8f1..f725efe 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1060,6 +1060,9 @@
'targets' => [ 'desktop', 'mobile' ],
],
'mediawiki.hlist' => [
+   'styles' => [
+   'resources/src/mediawiki/mediawiki.hlist-allskins.less',
+   ],
'skinStyles' => [
'default' => 
'resources/src/mediawiki/mediawiki.hlist.css',
],
diff --git a/resources/src/mediawiki/mediawiki.hlist-allskins.less 
b/resources/src/mediawiki/mediawiki.hlist-allskins.less
new file mode 100644
index 000..d7071e4
--- /dev/null
+++ b/resources/src/mediawiki/mediawiki.hlist-allskins.less
@@ -0,0 +1,21 @@
+.hlist {
+   dl,
+   ol,
+   ul {
+   margin: 0;
+   padding: 0;
+
+   dl,
+   ol,
+   ul {
+   display: inline;
+   }
+   }
+
+   dd,
+   dt,
+   li {
+   margin: 0;
+   display: inline;
+   }
+}
diff --git a/resources/src/mediawiki/mediawiki.hlist.css 
b/resources/src/mediawiki/mediawiki.hlist.css
index c0788a4..2663d87 100644
--- a/resources/src/mediawiki/mediawiki.hlist.css
+++ b/resources/src/mediawiki/mediawiki.hlist.css
@@ -2,31 +2,6 @@
  * Stylesheet for mediawiki.hlist module
  * @author [[User:Edokter]]
  */
-.hlist dl,
-.hlist ol,
-.hlist ul {
-   margin: 0;
-   padding: 0;
-}
-/* Display list items inline */
-.hlist dd,
-.hlist dt,
-.hlist li {
-   margin: 0;
-   display: inline;
-}
-/* Display nested lists inline */
-.hlist dl dl,
-.hlist dl ol,
-.hlist dl ul,
-.hlist ol dl,
-.hlist ol ol,
-.hlist ol ul,
-.hlist ul dl,
-.hlist ul ol,
-.hlist ul ul {
-   display: inline;
-}
 /* Generate interpuncts */
 .hlist dt:after {
content: ':';

-- 
To view, visit https://gerrit.wikimedia.org/r/366892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b5f077d8b4a4c7fe845b7b6d1df98bb2dbafc8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BetaFeatures[master]: Hygiene: Define PHPUnit group for unit tests

2017-07-21 Thread Pmiazga (Code Review) 
Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366891 )

Change subject: Hygiene: Define PHPUnit group for unit tests
..

Hygiene: Define PHPUnit group for unit tests

While testing different extensions which depend upon BetaFeatures
extension it should be possible to narrow tests to specific extension
only. To do that unit test have to specify the group they belong.

Changes:
 - introduced group called BetaFeatures
 - added @group annotation to every BetaFeatures unit tests

Change-Id: I58848f46a32fc39238d30d023c3e321502643900
---
M tests/phpunit/AutoEnrollmentTest.php
M tests/phpunit/BetaFeaturesTestCase.php
M tests/phpunit/DependentFeatureTest.php
M tests/phpunit/HTMLFeatureFieldTest.php
M tests/phpunit/HTMLHorizontalRuleTest.php
M tests/phpunit/HTMLTextBlockTest.php
M tests/phpunit/HooksRunTest.php
M tests/phpunit/NewHTMLCheckFieldTest.php
M tests/phpunit/PreferenceHandlingTest.php
9 files changed, 27 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BetaFeatures 
refs/changes/91/366891/1

diff --git a/tests/phpunit/AutoEnrollmentTest.php 
b/tests/phpunit/AutoEnrollmentTest.php
index f397a1c..3b801dd 100644
--- a/tests/phpunit/AutoEnrollmentTest.php
+++ b/tests/phpunit/AutoEnrollmentTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class AutoEnrollmentTest extends BetaFeaturesTestCase {
 
// Structure of testing preference
diff --git a/tests/phpunit/BetaFeaturesTestCase.php 
b/tests/phpunit/BetaFeaturesTestCase.php
index e884450..47a9113 100644
--- a/tests/phpunit/BetaFeaturesTestCase.php
+++ b/tests/phpunit/BetaFeaturesTestCase.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class BetaFeaturesTestCase extends MediaWikiTestCase {
 
protected function setUp() {
diff --git a/tests/phpunit/DependentFeatureTest.php 
b/tests/phpunit/DependentFeatureTest.php
index c2f45c7..bc9f8bf 100644
--- a/tests/phpunit/DependentFeatureTest.php
+++ b/tests/phpunit/DependentFeatureTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class DependentFeatureTest extends BetaFeaturesTestCase {
 
// Key for testing preference
diff --git a/tests/phpunit/HTMLFeatureFieldTest.php 
b/tests/phpunit/HTMLFeatureFieldTest.php
index de01c0a..bbbf8c8 100644
--- a/tests/phpunit/HTMLFeatureFieldTest.php
+++ b/tests/phpunit/HTMLFeatureFieldTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HTMLFeatureFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/HTMLHorizontalRuleTest.php 
b/tests/phpunit/HTMLHorizontalRuleTest.php
index 06be579..5b27836 100644
--- a/tests/phpunit/HTMLHorizontalRuleTest.php
+++ b/tests/phpunit/HTMLHorizontalRuleTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HTMLHorizontalRuleFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/HTMLTextBlockTest.php 
b/tests/phpunit/HTMLTextBlockTest.php
index f526106..3de29c8 100644
--- a/tests/phpunit/HTMLTextBlockTest.php
+++ b/tests/phpunit/HTMLTextBlockTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HTMLTextBlockFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/HooksRunTest.php b/tests/phpunit/HooksRunTest.php
index 94b970f..15727e0 100644
--- a/tests/phpunit/HooksRunTest.php
+++ b/tests/phpunit/HooksRunTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class HooksRunTest extends MediaWikiTestCase {
 
// Key for testing preference
diff --git a/tests/phpunit/NewHTMLCheckFieldTest.php 
b/tests/phpunit/NewHTMLCheckFieldTest.php
index 5fd25b6..f0671de 100644
--- a/tests/phpunit/NewHTMLCheckFieldTest.php
+++ b/tests/phpunit/NewHTMLCheckFieldTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+ */
 class NewHTMLCheckFieldTest extends MediaWikiTestCase {
 
public function testCreatingFieldGivesExpectedStrings() {
diff --git a/tests/phpunit/PreferenceHandlingTest.php 
b/tests/phpunit/PreferenceHandlingTest.php
index 103a451..a36532f 100644
--- a/tests/phpunit/PreferenceHandlingTest.php
+++ b/tests/phpunit/PreferenceHandlingTest.php
@@ -23,6 +23,9 @@
  * @license GNU General Public License version 2 or later
  */
 
+/**
+ * @group BetaFeatures
+

[MediaWiki-commits] [Gerrit] mediawiki...ContactPage[master]: Drop DisplayFormat configuration

2017-07-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348483 )

Change subject: Drop DisplayFormat configuration
..


Drop DisplayFormat configuration

Force ooui display format for all contact
forms

Change-Id: Idb4225fb71d9d030192226bb6bad39a9040d
---
M ContactPage_body.php
M README
M extension.json
3 files changed, 1 insertion(+), 7 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/ContactPage_body.php b/ContactPage_body.php
index 0e5c5a6..86d2730 100644
--- a/ContactPage_body.php
+++ b/ContactPage_body.php
@@ -201,7 +201,7 @@
];
}
 
-   $form = HTMLForm::factory( $config['DisplayFormat'],
+   $form = HTMLForm::factory( 'ooui',
$formItems, $this->getContext(), 
"contactpage-{$this->formType}"
);
$form->setWrapperLegendMsg( 'contactpage-legend' );
diff --git a/README b/README
index 1afb099..f73016c 100644
--- a/README
+++ b/README
@@ -80,10 +80,6 @@
   ),
   ),
 
-DisplayFormat is used to configure the HTMLForm. See HTMLForm documentation
-for possible values. Recommended value is "ooui" for consistency with other
-forms and better mobile rendering.
-
 RLModules can be used to add ResourceLoader modules (custom CSS and
 JavaScript) to the page.
 
diff --git a/extension.json b/extension.json
index 804cb24..463469b 100644
--- a/extension.json
+++ b/extension.json
@@ -19,14 +19,12 @@
},
"config": {
"ContactConfig": {
-   "@doc": "Use DisplayFormat `ooui` for compatibility 
with most skins.",
"default": {
"RecipientUser": null,
"SenderEmail": null,
"SenderName": null,
"RequireDetails": false,
"IncludeIP": false,
-   "DisplayFormat": "ooui",
"RLModules": [],
"RLStyleModules": [],
"AdditionalFields": {

-- 
To view, visit https://gerrit.wikimedia.org/r/348483
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb4225fb71d9d030192226bb6bad39a9040d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContactPage
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] 3d2png[master]: Remove wireframes per design input

2017-07-21 Thread MarkTraceur (Code Review) 
MarkTraceur has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366890 )

Change subject: Remove wireframes per design input
..

Remove wireframes per design input

Change-Id: I7c94173f59e4dbab57da7bc0656e0a69ab72de4f
---
M 3d2png.js
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/3d2png refs/changes/90/366890/1

diff --git a/3d2png.js b/3d2png.js
index da29b88..af0dd7c 100755
--- a/3d2png.js
+++ b/3d2png.js
@@ -50,13 +50,9 @@
  * @returns {THREE.Mesh} mesh
  */
 ThreeDtoPNG.prototype.outputToObject = function ( geometry ) {
-   var materials = [
-   new THREE.MeshPhongMaterial( { color: 0xF8F9FA, 
shading: THREE.FlatShading } ),
-   new THREE.MeshBasicMaterial( { color: 0xC8CCD1, 
shading: THREE.FlatShading, wireframe: true, transparent: true } )
-   ],
-   mesh = new THREE.SceneUtils.createMultiMaterialObject( 
geometry, materials );
+   var material = new THREE.MeshPhongMaterial( { color: 0xF8F9FA, shading: 
THREE.FlatShading } );
 
-   return mesh;
+   return new THREE.Mesh( geometry, material );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/366890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c94173f59e4dbab57da7bc0656e0a69ab72de4f
Gerrit-PatchSet: 1
Gerrit-Project: 3d2png
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...3D[master]: Removing wireframe per design input

2017-07-21 Thread MarkTraceur (Code Review) 
MarkTraceur has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366889 )

Change subject: Removing wireframe per design input
..

Removing wireframe per design input

Change-Id: I0a74774e1496de35b15e113b2ae18cfc33992303
---
M modules/mmv.3d.js
1 file changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/3D 
refs/changes/89/366889/1

diff --git a/modules/mmv.3d.js b/modules/mmv.3d.js
index c910d95..4d2e0ec 100644
--- a/modules/mmv.3d.js
+++ b/modules/mmv.3d.js
@@ -86,12 +86,9 @@
};
 
TD.geometryToObject = function ( geometry ) {
-   var materials = [
-   new THREE.MeshPhongMaterial( { color: 0xF8F9FA, 
shading: THREE.FlatShading } ),
-   new THREE.MeshBasicMaterial( { color: 0xC8CCD1, 
shading: THREE.FlatShading, wireframe: true, transparent: true } )
-   ];
+   var material = new THREE.MeshPhongMaterial( { color: 0xF8F9FA, 
shading: THREE.FlatShading } );
 
-   return THREE.SceneUtils.createMultiMaterialObject( geometry, 
materials );
+   return new THREE.Mesh( geometry, material );
};
 
TD.loadFile = function ( extension, url ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/366889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a74774e1496de35b15e113b2ae18cfc33992303
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/3D
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

  1   2   3   >