Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288121
Change subject: Enable progressive rendering of JPEGs
..
Enable progressive rendering of JPEGs
I haven't actually noticed a difference bu
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288119
Change subject: Upgrade HockeyApp to v4.0.1
..
Upgrade HockeyApp to v4.0.1
Upgrade the HockeyApp SDK[0] and enable user metrics[1].
[0]
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288116
Change subject: Upgrade Butter Knife to v8.0.1
..
Upgrade Butter Knife to v8.0.1
https://github.com/JakeWharton/butterknife/blob/master/C
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288118
Change subject: Upgrade Android Testing Support Libraries
..
Upgrade Android Testing Support Libraries
Upgrade Espresso to v2.2.2 and Run
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288326
Change subject: Unbind Views on Fragment destruction
..
Unbind Views on Fragment destruction
Add missing unbind() call in UserOptionRowFr
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288438
Change subject: Hygiene: add @NonNull annotation
..
Hygiene: add @NonNull annotation
Assume an English translation exists for File, Speci
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288533
Change subject: Fix cookies and user options
..
Fix cookies and user options
• The cookie jar was only being used for old Api requests. U
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288699
Change subject: Hygiene: break layout into separate XML files
..
Hygiene: break layout into separate XML files
The Reading List onboardin
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288698
Change subject: Upgrade Android Support libraries to v23.4.0
..
Upgrade Android Support libraries to v23.4.0
http://developer.android.com
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356955 )
Change subject: Hygiene: refactor event bus thread concerns to separate class
..
Hygiene: refactor event bus thread concerns to separate
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356957 )
Change subject: Fix: update reading list UI on change
..
Fix: update reading list UI on change
- Move ReadingListSyncEvent postage from
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356956 )
Change subject: Fix: only tally page sizes of offline pages
..
Fix: only tally page sizes of offline pages
If a page was marked for off
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357246 )
Change subject: Hygiene: remove div overflow JavaScript transform
..
Hygiene: remove div overflow JavaScript transform
On closer inspec
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342707 )
Change subject: Upgrade Gradle wrapper to 3.4
..
Upgrade Gradle wrapper to 3.4
Bug: T160393
Change-Id: I8b030c71e3e0251f9006672
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342263 )
Change subject: Hygiene: Remove Jenkins plugin-driven install-android-sdk
builder
..
Hygiene: Remove Jenkins plugin-driven inst
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/342843 )
Change subject: Hygiene: move CI publish script from Jenkins Job Builder config
to repo
..
Hygiene: move CI publish script from Jenkins
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/342844 )
Change subject: Hygiene: [Android] move JJB script to app repo
..
Hygiene: [Android] move JJB script to app repo
It should be easy for
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342265 )
Change subject: Hygiene: Get and display lint reports from /app/build/reports
..
Hygiene: Get and display lint reports from /app
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/342844 )
Change subject: Hygiene: [Android] move JJB script to app repo
..
Hygiene: [Android] move JJB script to app repo
It should be e
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/342889 )
Change subject: Fix: set executable bit on CI script
..
Fix: set executable bit on CI script
A follow-up to 9c2d1c4, set the executable
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343287 )
Change subject: Hygiene: remove unused SavedPage methods and infer nullity
..
Hygiene: remove unused SavedPage methods and infer nullity
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343289 )
Change subject: Update: remove saved page image downloading and link remapping
..
Update: remove saved page image downloading and link r
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343288 )
Change subject: Hygiene: rename ImageUrlMap to ImageUrlHtmlParser
..
Hygiene: rename ImageUrlMap to ImageUrlHtmlParser
Also, remove unu
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343295 )
Change subject: Update: do not forbid Fresco image request caching
..
Update: do not forbid Fresco image request caching
Bug: T156917
C
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343293 )
Change subject: Update: expose WikiSite URI
..
Update: expose WikiSite URI
This new API is useful for clients wishing to build upon a W
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343294 )
Change subject: Update: use OkHttp for WebView requests
..
Update: use OkHttp for WebView requests
Bug: T156917
Change-Id: I237be04b201
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343296 )
Change subject: Fix: save page downloading
..
Fix: save page downloading
Bug: T156917
Change-Id: Ide92549e6f1066737f36afedb08ff674ace2c
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343292 )
Change subject: Update: prepare to replace image URL parser
..
Update: prepare to replace image URL parser
Support extracting src and s
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343291 )
Change subject: Hygiene: add jsoup v1.10.2
..
Hygiene: add jsoup v1.10.2
Add Java HTML Parser for parsing image src and srcset links.
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343290 )
Change subject: Update: use the new save page download api
..
Update: use the new save page download api
Bug: T156917
Change-Id: I77758
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343900 )
Change subject: Hygiene: replace runtime resource use with static uses
..
Hygiene: replace runtime resource use with static uses
Update
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343914 )
Change subject: Hygiene: remove unused resources
..
Hygiene: remove unused resources
Change-Id: I412c0e1f597ec52a2e863a194b79cb00dc807d
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343915 )
Change subject: Hygiene: remove unused FileUtil method
..
Hygiene: remove unused FileUtil method
Remove FileUtil.writeToStream().
Chan
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343913 )
Change subject: Hygiene: remove unused legacy colors
..
Hygiene: remove unused legacy colors
Change-Id: I0fef6aeae48751893e5bf6e1c4527f
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343912 )
Change subject: Hygiene: remove outdated @VisibleForTest annotations
..
Hygiene: remove outdated @VisibleForTest annotations
Remove a c
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/343916 )
Change subject: Hygiene: upgrade to Retrofit v2.2.0
..
Hygiene: upgrade to Retrofit v2.2.0
https://github.com/square/retrofit/blob/mast
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344263 )
Change subject: Hygiene: remove unused ReadingListDaoProxy.pageTitles() method
..
Hygiene: remove unused ReadingListDaoProxy.pageTitles(
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344262 )
Change subject: Chore: remove pageCombo endpoint
..
Chore: remove pageCombo endpoint
Bug: T156917
Change-Id: Ibec49dab4873023faa8efac8a
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344261 )
Change subject: Chore: add PageClient tests
..
Chore: add PageClient tests
Bug: T156917
Change-Id: I26eb87b10cfb4c7a2a539dcbca3325f6acb
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344266 )
Change subject: Hygiene: remove ResponseLoggingInterceptor
..
Hygiene: remove ResponseLoggingInterceptor
In combination with HttpLoggin
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344264 )
Change subject: Hygiene: limit dev test timeout to 5 seconds
..
Hygiene: limit dev test timeout to 5 seconds
CI is slow but local dev b
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344265 )
Change subject: Hygiene: remove outdated SharedPreference
..
Hygiene: remove outdated SharedPreference
A reading list page delete tutor
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345002 )
Change subject: Update: [Wikipedia Android] mark wikidata description guide url
optional
..
Update: [Wikipedia Android] mark wikidata d
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348798 )
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I673c654ed0b329887d412f3056192d3e9e43ebce
---
M app/build.gradle
1 file
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348865 )
Change subject: Fix: remove hardware feature requirements
..
Fix: remove hardware feature requirements
Forcefully remove unnecessary ha
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348864 )
Change subject: Revert: add alternate casing for device feature requirements
..
Revert: add alternate casing for device feature requirem
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348950 )
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I987c74c46f97a86e1bb3dbeed4f53d5b8bcf919c
---
M app/build.gradle
1 file
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349115 )
Change subject: Chore: update styles
..
Chore: update styles
Update styles for I04d210c01328ec77a44c9a4617b69a1d34715b20.
Change-Id: I
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349371 )
Change subject: Consolidate collapse table CSS
..
Consolidate collapse table CSS
Move collapse table to wikimedia-page-library.
https:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349373 )
Change subject: Consolidate collapse table CSS and JavaScript
..
Consolidate collapse table CSS and JavaScript
Move collapse table to w
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349452 )
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I368af357936d6ef26d1b994f4fff555f3735f318
---
M app/build.gradle
1 file
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349688 )
Change subject: Hygiene: remove dead saved page database code
..
Hygiene: remove dead saved page database code
Remove some unused saved
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345859 )
Change subject: Fix: add workaround for numeric userjs options
..
Fix: add workaround for numeric userjs options
The userjs options API
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346174 )
Change subject: Hygiene: upgrade Support Libraries to v25.3.1
..
Hygiene: upgrade Support Libraries to v25.3.1
Just a couple bug fixes.
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346793 )
Change subject: Hygiene: upgrade Android Plugin for Gradle to v2.3.1
..
Hygiene: upgrade Android Plugin for Gradle to v2.3.1
> This is
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346835 )
Change subject: Hygiene: remove Spoon page content integration tests
..
Hygiene: remove Spoon page content integration tests
These inte
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346837 )
Change subject: Fix: update screenshots for tests
..
Fix: update screenshots for tests
• Update for layout changes:
• org.wikipedia
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/353129 )
Change subject: Update: reading list UI with saved page disk stats
..
Update: reading list UI with saved page disk stats
- Update readi
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351212 )
Change subject: New: record physical and logical file size of saved pages
..
New: record physical and logical file size of saved pages
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351200 )
Change subject: Ensure that the Jenkins build timestamp is interpreted as UTC
..
Ensure that the Jenkins build timestamp is inte
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/349630 )
Change subject: Android: Set -no-boot-anim command line flag for emulator
..
Android: Set -no-boot-anim command line flag for em
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/352063 )
Change subject: Hygiene: remove some dead JavaScript
..
Hygiene: remove some dead JavaScript
These bridge messages aren't sent or recei
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347084 )
Change subject: Fix: network cache request order
..
Fix: network cache request order
In CacheIfErrorInterceptor, only request a cached
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347117 )
Change subject: Hygiene: remove unused style old NavTabView
..
Hygiene: remove unused style old NavTabView
Change-Id: I7454e0cba7c94a80
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347119 )
Change subject: Hygiene: remove unused string resources
..
Hygiene: remove unused string resources
Change-Id: Ibc534fa03fc096140a559413
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347517 )
Change subject: Hyginee: remove dead code in PageImageDatabaseTable
..
Hyginee: remove dead code in PageImageDatabaseTable
Change-Id: I
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347542 )
Change subject: Hygiene: consolidate image widening CSS in applib
..
Hygiene: consolidate image widening CSS in applib
Move the common
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347543 )
Change subject: Hygiene: consolidate image widening CSS and JS in applib
..
Hygiene: consolidate image widening CSS and JS in applib
Mo
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348787 )
Change subject: Fix: add alternate casing for device feature requirements
..
Fix: add alternate casing for device feature requirements
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310014
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id: I
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310345
Change subject: Hygiene: update deprecated @LargeTest import
..
Hygiene: update deprecated @LargeTest import
http://stackoverflow.com/que
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310356
Change subject: Annotate tests that do not require a WebView
..
Annotate tests that do not require a WebView
BasePageLoadTest is annotate
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310368
Change subject: Hygiene: replace ImageButton with ImageView
..
Hygiene: replace ImageButton with ImageView
Replace ImageButtons with Imag
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310380
Change subject: Add missing interface tests to NavTabViewTest
..
Add missing interface tests to NavTabViewTest
Change-Id: I53daa2e4c39cb6
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310387
Change subject: Add missing tests to CardLargeHeaderViewTest
..
Add missing tests to CardLargeHeaderViewTest
Test all methods exposed by
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310390
Change subject: Hygiene: reduce visibility of @OnClick methods
..
Hygiene: reduce visibility of @OnClick methods
@OnClick methods should
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310481
Change subject: Test null listener in CardLargeHeaderViewTest
..
Test null listener in CardLargeHeaderViewTest
Change-Id: I34d32e4708fc01
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310480
Change subject: Move generic TextView assertion method to ViewTest
..
Move generic TextView assertion method to ViewTest
assertText() wil
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310584
Change subject: Update NavTavViewTest screenshots
..
Update NavTavViewTest screenshots
These became outdated with a previous update to th
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310585
Change subject: Hygiene: remove redundant code in NavTabView/Test
..
Hygiene: remove redundant code in NavTabView/Test
• Remove redundant
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310611
Change subject: Bump versionCode
..
Bump versionCode
Increment version minor too: v2.4.153
Change-Id: Ia237182ab0f7a102f9fe22d2749412fa4
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310620
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I6878e0efcb875643604674c3b737fee7847dc836
---
M app/build.gradle
1 file c
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310843
Change subject: Thoroughly fix feed card equals contracts
..
Thoroughly fix feed card equals contracts
2cb18da patched BecauseYouReadCard
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310844
Change subject: Hygiene: remove dead code in FeaturedImageCard
..
Hygiene: remove dead code in FeaturedImageCard
Change-Id: I6b155e2931f5
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310875
Change subject: Fix two NPEs in nearby
..
Fix two NPEs in nearby
• Respect Fragment / View lifecyels per 56a5e7a:
Call MapView.onDes
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310885
Change subject: Fix Fragment crash when leaving GalleryActivity
..
Fix Fragment crash when leaving GalleryActivity
The GalleryActivity ma
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310966
Change subject: Hygiene: use @BindView for SearchFragment View
..
Hygiene: use @BindView for SearchFragment View
Change-Id: If395bfe42437
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310967
Change subject: Null View listener in SearchFragment.onDestroyView
..
Null View listener in SearchFragment.onDestroyView
Change-Id: I913b
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310969
Change subject: Hygiene: use @OnClick for SearchFragment listeners
..
Hygiene: use @OnClick for SearchFragment listeners
Change-Id: I14af
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310970
Change subject: Hygiene: set initial container visibility in XML
..
Hygiene: set initial container visibility in XML
Change-Id: I22dbdbd7
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310968
Change subject: Hygiene: refactor SearchFragment
..
Hygiene: refactor SearchFragment
• Move SearchFragment.InvokeSource to separate file,
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311152
Change subject: Upgrade to Fresco v0.13.0
..
Upgrade to Fresco v0.13.0
Also replace demo code copies per release notes[0,1,2]. From 6efeb
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311154
Change subject: Upgrade to OkHttp v3.4.1 and Retrofit v2.1.0
..
Upgrade to OkHttp v3.4.1 and Retrofit v2.1.0
https://github.com/square/ok
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311192
Change subject: Upgrade to Spoon v1.7.0
..
Upgrade to Spoon v1.7.0
https://github.com/square/spoon/blob/master/CHANGELOG.md#version-154-2
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311193
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: Ia4ef9dde2ae0226aeb57ac9da871092318de5bd4
---
M app/build.gradle
1 file c
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370635 )
Change subject: Hygiene: omit slash in jQuery node creation
..
Hygiene: omit slash in jQuery node creation
https://www.mediawiki.org/wi
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370678 )
Change subject: Marvin: add NPM template
..
Marvin: add NPM template
Configure the new Marvin project with the stock NPM template.
htt
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370771 )
Change subject: - Keep Marvin members as owner for refs/* but remove all other
permissions until they're necessary. The intent was to keep permissions
minimal although an ideal configuration is unkno
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370772 )
Change subject: Chore: update Gerrit permissions
..
Chore: update Gerrit permissions
- Keep Marvin members as owner for refs/* but remo
Niedzielski has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370671 )
Change subject: Doc: Use not-null markers on server/templates/page jsdoc
..
Doc: Use not-null markers on server/templates/page j
701 - 800 of 1372 matches
Mail list logo
