Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305758
Change subject: handle lots of files #chore
..
handle lots of files #chore
pass files on stdin instead of arguments. for simplicity,
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306006
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340434 )
Change subject: WIP: rework into pagedataclient and update calls in sync service
..
WIP: rework into pagedataclient and update calls in
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340433 )
Change subject: Hygiene: remove duplicate method in WidgetProviderFeaturedPage
..
Hygiene: remove duplicate method in
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340432 )
Change subject: WIP: ripout some saved page loading logic
..
WIP: ripout some saved page loading logic
Change-Id:
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340679 )
Change subject: Hygiene: consolidate RESTBase and MobileView URL comparisons
..
Hygiene: consolidate RESTBase and MobileView URL
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340678 )
Change subject: Hygiene: rename PageDataClient to PageFragmentLoadState
..
Hygiene: rename PageDataClient to PageFragmentLoadState
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340677 )
Change subject: Hygiene: delete PageLoadStrategy
..
Hygiene: delete PageLoadStrategy
The PageLoadStrategy interface is so tightly
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340680 )
Change subject: Hygiene: move MediaWiki fallback checks from clients to
response interceptor
..
Hygiene: move MediaWiki fallback
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340676 )
Change subject: Hygiene: rename PageService classes to PageClients
..
Hygiene: rename PageService classes to PageClients
Bug: T156917
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340687 )
Change subject: Hygiene: clean up empty string checks
..
Hygiene: clean up empty string checks
Replace calls to
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/340688 )
Change subject: Hygiene: move Wikipedia Zero header checks from clients to
response interceptor
..
Hygiene: move Wikipedia Zero header
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308581
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308579
Change subject: Limit performance jobs IRC notification channels
..
Limit performance jobs IRC notification channels
The
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308651
Change subject: Reduce memory usage of Fragment pagers
..
Reduce memory usage of Fragment pagers
Use FragmentStatePagerAdapter instead
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308652
Change subject: Fix crash in reading lists screen
..
Fix crash in reading lists screen
The default implementation of
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308653
Change subject: Hygiene: use Butter Knife in ReadingListFragment
..
Hygiene: use Butter Knife in ReadingListFragment
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308654
Change subject: Hygiene: rename NavTabViewPagerAdapter
..
Hygiene: rename NavTabViewPagerAdapter
Rename NavTabViewPagerAdapter to
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308669
Change subject: Remove Android Commons app job
..
Remove Android Commons app job
This app is no longer maintained by the Foundation.
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308758
Change subject: Always hide the soft keyboard on the main screen
..
Always hide the soft keyboard on the main screen
The soft keyboard
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308760
Change subject: Use defaults for main config handling, launch mode
..
Use defaults for main config handling, launch mode
The
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308104
Change subject: Update ViewTest to include system font size
..
Update ViewTest to include system font size
Users may specify a font size
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308101
Change subject: Hygiene: remove unused constructors
..
Hygiene: remove unused constructors
All FeedCardViews are constructed in
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308105
Change subject: Add CardLargeHeaderViewTest
..
Add CardLargeHeaderViewTest
Bug: T144401
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308102
Change subject: Hygiene: remove commented out code
..
Hygiene: remove commented out code
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308103
Change subject: Hygiene: simplify CardLargeHeaderView
..
Hygiene: simplify CardLargeHeaderView
• Fix title for RTL.
• Remove unused
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307512
Change subject: Upgrade Butter Knife to v8.4.0
..
Upgrade Butter Knife to v8.4.0
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307514
Change subject: Upgrade Gson to v2.7
..
Upgrade Gson to v2.7
https://github.com/google/gson/blob/master/CHANGELOG.md#version-27
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307515
Change subject: Hygiene: misc cleanup
..
Hygiene: misc cleanup
Remove a dead method and reduce visibility of another method.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307518
Change subject: Tie BecauseYouReadCard equals & hashCode together
..
Tie BecauseYouReadCard equals & hashCode together
Kind of fix
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307513
Change subject: Hygiene: move callback to Butter Knife annotation
..
Hygiene: move callback to Butter Knife annotation
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307516
Change subject: Truncate subtitles in Feed card headers
..
Truncate subtitles in Feed card headers
When space is unavailable, truncate
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307519
Change subject: Hygiene: remove cast
..
Hygiene: remove cast
Change-Id: I927cc86251777b04f9d485a266a99608a8080141
---
M
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309007
Change subject: Update screenshot names for packaging changes
..
Update screenshot names for packaging changes
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307655
Change subject: Increase ADB timeout
..
Increase ADB timeout
ADB times out in the rare scenario where a new emulator image must be
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307775
Change subject: Hygiene: update Namespace Javadocs
..
Hygiene: update Namespace Javadocs
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310356
Change subject: Annotate tests that do not require a WebView
..
Annotate tests that do not require a WebView
BasePageLoadTest is
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310345
Change subject: Hygiene: update deprecated @LargeTest import
..
Hygiene: update deprecated @LargeTest import
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310368
Change subject: Hygiene: replace ImageButton with ImageView
..
Hygiene: replace ImageButton with ImageView
Replace ImageButtons with
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310380
Change subject: Add missing interface tests to NavTabViewTest
..
Add missing interface tests to NavTabViewTest
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310584
Change subject: Update NavTavViewTest screenshots
..
Update NavTavViewTest screenshots
These became outdated with a previous update to
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310585
Change subject: Hygiene: remove redundant code in NavTabView/Test
..
Hygiene: remove redundant code in NavTabView/Test
• Remove
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310620
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I6878e0efcb875643604674c3b737fee7847dc836
---
M app/build.gradle
1 file
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310611
Change subject: Bump versionCode
..
Bump versionCode
Increment version minor too: v2.4.153
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309411
Change subject: Don't resize the main screen when keyboard is up
..
Don't resize the main screen when keyboard is up
Pan the app, don't
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309376
Change subject: Show the keyboard when tapping the history search
..
Show the keyboard when tapping the history search
Show the soft
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309811
Change subject: WIP: Hygiene: don't calculate, ask GeoData for distance
..
WIP: Hygiene: don't calculate, ask GeoData for distance
• use
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310390
Change subject: Hygiene: reduce visibility of @OnClick methods
..
Hygiene: reduce visibility of @OnClick methods
@OnClick methods should
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310387
Change subject: Add missing tests to CardLargeHeaderViewTest
..
Add missing tests to CardLargeHeaderViewTest
Test all methods exposed by
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310480
Change subject: Move generic TextView assertion method to ViewTest
..
Move generic TextView assertion method to ViewTest
assertText()
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310481
Change subject: Test null listener in CardLargeHeaderViewTest
..
Test null listener in CardLargeHeaderViewTest
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310843
Change subject: Thoroughly fix feed card equals contracts
..
Thoroughly fix feed card equals contracts
2cb18da patched
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310844
Change subject: Hygiene: remove dead code in FeaturedImageCard
..
Hygiene: remove dead code in FeaturedImageCard
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310875
Change subject: Fix two NPEs in nearby
..
Fix two NPEs in nearby
• Respect Fragment / View lifecyels per 56a5e7a:
Call
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310885
Change subject: Fix Fragment crash when leaving GalleryActivity
..
Fix Fragment crash when leaving GalleryActivity
The GalleryActivity
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310014
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312608
Change subject: WIP: Autohide the nav bar on scroll
..
WIP: Autohide the nav bar on scroll
Pending:
- Nearby FAB should appear above the
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312838
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312849
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313220
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: I37ba081e4f30a4d918b2e85a02c698bd1e1d8d84
---
M app/build.gradle
1 file
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314279
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314036
Change subject: Android: add IRC notification to alpha builds
..
Android: add IRC notification to alpha builds
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314770
Change subject: Annotate BridgeTests as @Large
..
Annotate BridgeTests as @Large
A follow-up to 4994f86, add @Large annotation to missed
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314781
Change subject: Annotate TranslationTests as @Large
..
Annotate TranslationTests as @Large
A follow-up to 4994f86 and 8d2b632, add
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314788
Change subject: WIP: Android: upgrade emulator to API 24
..
WIP: Android: upgrade emulator to API 24
• Upgrade the Android emulator to
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314331
Change subject: Demo: required field Gson fields
..
Demo: required field Gson fields
Just copy and paste this answer:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314031
Change subject: Hygiene: use TimeUnit instead of arithmetic
..
Hygiene: use TimeUnit instead of arithmetic
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314415
Change subject: Hygiene: remove legacy code for Site domain
..
Hygiene: remove legacy code for Site domain
Remove legacy unmarshalling
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314419
Change subject: Don't toggle the GPS when requesting location
..
Don't toggle the GPS when requesting location
The Mapbox SDK will
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314789
Change subject: Hygiene: remove adb-setup.bash
..
Hygiene: remove adb-setup.bash
Remove setup script which unlocked the screen, waited
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312060
Change subject: Hygiene: remove redundant code from FeedView
..
Hygiene: remove redundant code from FeedView
Remove programmatic
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312059
Change subject: Add multicolumn support to feed header
..
Add multicolumn support to feed header
This feels a little clunky but seems
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310966
Change subject: Hygiene: use @BindView for SearchFragment View
..
Hygiene: use @BindView for SearchFragment View
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310967
Change subject: Null View listener in SearchFragment.onDestroyView
..
Null View listener in SearchFragment.onDestroyView
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310969
Change subject: Hygiene: use @OnClick for SearchFragment listeners
..
Hygiene: use @OnClick for SearchFragment listeners
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310970
Change subject: Hygiene: set initial container visibility in XML
..
Hygiene: set initial container visibility in XML
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310968
Change subject: Hygiene: refactor SearchFragment
..
Hygiene: refactor SearchFragment
• Move SearchFragment.InvokeSource to separate
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311193
Change subject: Bump versionCode
..
Bump versionCode
Change-Id: Ia4ef9dde2ae0226aeb57ac9da871092318de5bd4
---
M app/build.gradle
1 file
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311192
Change subject: Upgrade to Spoon v1.7.0
..
Upgrade to Spoon v1.7.0
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311432
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311433
Change subject: Hygiene: rename FeedRecyclerAdapter to FeedAdapter
..
Hygiene: rename FeedRecyclerAdapter to FeedAdapter
FeedView now
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312530
Change subject: Don't require faketouch support
..
Don't require faketouch support
Previously, we required faketouch support to allow
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312533
Change subject: Hygiene: Butter Knife FeaturedArticleCardView
..
Hygiene: Butter Knife FeaturedArticleCardView
Convert
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312144
Change subject: Hygiene: move FeaturedImageCardView callback
..
Hygiene: move FeaturedImageCardView callback
Encapsulate
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312142
Change subject: Hygiene: encapsulate FeedAdapter callback in class
..
Hygiene: encapsulate FeedAdapter callback in class
Move
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312140
Change subject: Hygiene: name callback s/getters consistently
..
Hygiene: name callback s/getters consistently
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312147
Change subject: Hygiene: move FeedViewCallback to FeedAdapter
..
Hygiene: move FeedViewCallback to FeedAdapter
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312146
Change subject: Hygiene: encapsulate NewsListCardView's callback
..
Hygiene: encapsulate NewsListCardView's callback
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312143
Change subject: Hygiene: encapsulate CardHeaderView callback
..
Hygiene: encapsulate CardHeaderView callback
Move CardHeaderView's
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312145
Change subject: Hygiene: encapsulate SearchCardView's callback
..
Hygiene: encapsulate SearchCardView's callback
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312141
Change subject: Hygiene: move PageTitleListCardItemCallback
..
Hygiene: move PageTitleListCardItemCallback
Move
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312148
Change subject: Null out feed card callbacks when Activity dies
..
Null out feed card callbacks when Activity dies
Bug: T146086
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312296
Change subject: Hygiene: move article toolbar to custom View
..
Hygiene: move article toolbar to custom View
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311868
Change subject: Hygiene: move FeedView Adapter config to client
..
Hygiene: move FeedView Adapter config to client
Focus FeedView on
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311867
Change subject: Hygiene: treat FeedView like an AdapterView
..
Hygiene: treat FeedView like an AdapterView
FeedView is now a plain
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311869
Change subject: Hygiene: make feed cards branch polymorphically
..
Hygiene: make feed cards branch polymorphically
Feed card types were
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311870
Change subject: Workaround ItemTouchHelper NPE
..
Workaround ItemTouchHelper NPE
This issue occurs with "don't keep activities" enabled
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311909
Change subject: Hygiene: unify feed card interface
..
Hygiene: unify feed card interface
Handle all feed cards in the same way. Also,
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311911
Change subject: Hygiene: convert SearchCardView to Butter Knife
..
Hygiene: convert SearchCardView to Butter Knife
Change-Id:
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311152
Change subject: Upgrade to Fresco v0.13.0
..
Upgrade to Fresco v0.13.0
Also replace demo code copies per release notes[0,1,2]. From
701 - 800 of 1370 matches
Mail list logo
