[MediaWiki-commits] [Gerrit] Inject siteLinkGroups into ItemView - change (mediawiki...Wikibase)

2014-11-28 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Inject siteLinkGroups into ItemView .. Inject siteLinkGroups into ItemView Change-Id: Icd9af0daf0353245eeb73c225dd9121a762d5e98 --- M repo

[MediaWiki-commits] [Gerrit] Rewrite completely broken EntityView tests - change (mediawiki...Wikibase)

2014-11-28 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Rewrite completely broken EntityView tests .. Rewrite completely broken EntityView tests Change-Id: Ibc373a9017c25cc2bdacbabeea2b97d283e31b00

[MediaWiki-commits] [Gerrit] Clean up SiteLinkLookup and related - change (mediawiki...Wikibase)

2014-12-01 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176652 Change subject: Clean up SiteLinkLookup and related .. Clean up SiteLinkLookup and related I found this in my stashes. It&#

[MediaWiki-commits] [Gerrit] Move all Hooks to Hooks folder and namespace - change (mediawiki...Wikibase)

2014-12-01 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176655 Change subject: Move all Hooks to Hooks folder and namespace .. Move all Hooks to Hooks folder and namespace Change-Id

[MediaWiki-commits] [Gerrit] Move client Hooks classes to Hooks folder/namespace - change (mediawiki...Wikibase)

2014-12-01 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176660 Change subject: Move client Hooks classes to Hooks folder/namespace .. Move client Hooks classes to Hooks folder/namespace

[MediaWiki-commits] [Gerrit] Move Repo Hooks classes to Hooks folder/namespace - change (mediawiki...Wikibase)

2014-12-01 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176661 Change subject: Move Repo Hooks classes to Hooks folder/namespace .. Move Repo Hooks classes to Hooks folder/namespace Change

[MediaWiki-commits] [Gerrit] Narrow RdfBuilder interfaces as much as possible - change (mediawiki...Wikibase)

2014-12-01 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176725 Change subject: Narrow RdfBuilder interfaces as much as possible .. Narrow RdfBuilder interfaces as much as possible ... and

[MediaWiki-commits] [Gerrit] Remove unused imports from Client - change (mediawiki...Wikibase)

2014-12-02 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176903 Change subject: Remove unused imports from Client .. Remove unused imports from Client Some are not reported by PHPStorm, I

[MediaWiki-commits] [Gerrit] Remove unused imports from Lib - change (mediawiki...Wikibase)

2014-12-02 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176904 Change subject: Remove unused imports from Lib .. Remove unused imports from Lib Some are not reported by PHPStorm, I found

[MediaWiki-commits] [Gerrit] Remove unused imports from Repo - change (mediawiki...Wikibase)

2014-12-02 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176905 Change subject: Remove unused imports from Repo .. Remove unused imports from Repo Some are not reported by PHPStorm, I found

[MediaWiki-commits] [Gerrit] Make EntityPerPageBuilderTest fields/methods private - change (mediawiki...Wikibase)

2014-12-02 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176913 Change subject: Make EntityPerPageBuilderTest fields/methods private .. Make EntityPerPageBuilderTest fields/methods private

[MediaWiki-commits] [Gerrit] Avoid getDefaultInstance method name in tests - change (mediawiki...Wikibase)

2014-12-02 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/176915 Change subject: Avoid getDefaultInstance method name in tests .. Avoid getDefaultInstance method name in tests This is split

[MediaWiki-commits] [Gerrit] Remove repeated var name from @var doc tags - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177193 Change subject: Remove repeated var name from @var doc tags .. Remove repeated var name from @var doc tags This is a copy

[MediaWiki-commits] [Gerrit] Rename getSiteLinkTable to getSiteLinkLookup - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177194 Change subject: Rename getSiteLinkTable to getSiteLinkLookup .. Rename getSiteLinkTable to getSiteLinkLookup Looks like the

[MediaWiki-commits] [Gerrit] Clean up ItemsPerSiteBuilderTest - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177195 Change subject: Clean up ItemsPerSiteBuilderTest .. Clean up ItemsPerSiteBuilderTest I may be wrong but I don't think i

[MediaWiki-commits] [Gerrit] Clean up MockClientStore - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177197 Change subject: Clean up MockClientStore .. Clean up MockClientStore Again, I don't think it's a good idea to

[MediaWiki-commits] [Gerrit] Clean up MockPropertyLabelResolver - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177198 Change subject: Clean up MockPropertyLabelResolver .. Clean up MockPropertyLabelResolver Change-Id

[MediaWiki-commits] [Gerrit] Rename ambiguous $repo to $wikibaseRepo - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177200 Change subject: Rename ambiguous $repo to $wikibaseRepo .. Rename ambiguous $repo to $wikibaseRepo This is split from I04767f2

[MediaWiki-commits] [Gerrit] Fix mistakes in AffectedPagesFinder and UsageAspectTransformer - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177206 Change subject: Fix mistakes in AffectedPagesFinder and UsageAspectTransformer .. Fix mistakes in AffectedPagesFinder and

[MediaWiki-commits] [Gerrit] Remove redundant variable names from @return tags - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177214 Change subject: Remove redundant variable names from @return tags .. Remove redundant variable names from @return tags Reason

[MediaWiki-commits] [Gerrit] Delete unused TermMatchScoreCalculator - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177215 Change subject: Delete unused TermMatchScoreCalculator .. Delete unused TermMatchScoreCalculator Change-Id

[MediaWiki-commits] [Gerrit] Use switch in EntityIdTitleFormatters - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177234 Change subject: Use switch in EntityIdTitleFormatters .. Use switch in EntityIdTitleFormatters If it looks like a switch why

[MediaWiki-commits] [Gerrit] Use 'property' string constant to avoid dependencies - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177237 Change subject: Use 'property' string constant to avoid dependencies .. Use 'property' string constant t

[MediaWiki-commits] [Gerrit] Use 'item' string constant to avoid dependencies - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177239 Change subject: Use 'item' string constant to avoid dependencies .. Use 'item' string constant to avoid dep

[MediaWiki-commits] [Gerrit] Formatters for JSON? - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177258 Change subject: Formatters for JSON? .. Formatters for JSON? A Formatter that outputs JSON is not a Formatter, that

[MediaWiki-commits] [Gerrit] Fix wrong SqlUsageTrackerSchemaUpdater filename - change (mediawiki...Wikibase)

2014-12-04 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177532 Change subject: Fix wrong SqlUsageTrackerSchemaUpdater filename .. Fix wrong SqlUsageTrackerSchemaUpdater filename Change-Id

[MediaWiki-commits] [Gerrit] Fix doc tags in EntityUsageTableBuilder - change (mediawiki...Wikibase)

2014-12-04 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177537 Change subject: Fix doc tags in EntityUsageTableBuilder .. Fix doc tags in EntityUsageTableBuilder Change-Id

[MediaWiki-commits] [Gerrit] Replaced "caseInsensitive" option - change (mediawiki...Wikibase)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172675 Change subject: Replaced "caseInsensitive" option .. Replaced "caseInsensitive" option See https://githu

[MediaWiki-commits] [Gerrit] Add missing method visibility everywhere - change (mediawiki...Wikibase)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172678 Change subject: Add missing method visibility everywhere .. Add missing method visibility everywhere Change-Id

[MediaWiki-commits] [Gerrit] Fix visibility of setUp/tearDown - change (mediawiki...Wikibase)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172679 Change subject: Fix visibility of setUp/tearDown .. Fix visibility of setUp/tearDown Change-Id

[MediaWiki-commits] [Gerrit] Fix visibility of setUp/tearDown - change (mediawiki...Scribunto)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172688 Change subject: Fix visibility of setUp/tearDown .. Fix visibility of setUp/tearDown Required for Idf44d31. Change-Id

[MediaWiki-commits] [Gerrit] Add missing visibility keywords everywhere - change (mediawiki...Scribunto)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172691 Change subject: Add missing visibility keywords everywhere .. Add missing visibility keywords everywhere Change-Id

[MediaWiki-commits] [Gerrit] Unify top factory getter implementations - change (mediawiki...Wikibase)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172703 Change subject: Unify top factory getter implementations .. Unify top factory getter implementations The fact that the

[MediaWiki-commits] [Gerrit] Fix visibility issues in Scribunto tests - change (mediawiki...Wikibase)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172709 Change subject: Fix visibility issues in Scribunto tests .. Fix visibility issues in Scribunto tests This needs If6d2705 to be

[MediaWiki-commits] [Gerrit] Move all client tests to Wikibase\Client\Tests - change (mediawiki...Wikibase)

2014-11-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172711 Change subject: Move all client tests to Wikibase\Client\Tests .. Move all client tests to Wikibase\Client\Tests Change-Id

[MediaWiki-commits] [Gerrit] Change @throw to @throws - change (mediawiki...Wikibase)

2014-11-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172977 Change subject: Change @throw to @throws .. Change @throw to @throws Change-Id: I40067da35283f99ccf49f7fbc2cd76f9b62bc302 --- M

[MediaWiki-commits] [Gerrit] Optimize all use sections in Repo - change (mediawiki...Wikibase)

2014-11-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172997 Change subject: Optimize all use sections in Repo .. Optimize all use sections in Repo Stuff that's not in a namespace

[MediaWiki-commits] [Gerrit] Optimize all use sections in Lib - change (mediawiki...Wikibase)

2014-11-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172998 Change subject: Optimize all use sections in Lib .. Optimize all use sections in Lib Change-Id

[MediaWiki-commits] [Gerrit] Optimize all use sections in Client - change (mediawiki...Wikibase)

2014-11-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/172999 Change subject: Optimize all use sections in Client .. Optimize all use sections in Client Change-Id

[MediaWiki-commits] [Gerrit] Increase selector precedence for aliasesview in fingerprintview - change (mediawiki...Wikibase)

2014-11-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173017 Change subject: Increase selector precedence for aliasesview in fingerprintview .. Increase selector precedence for aliasesview

[MediaWiki-commits] [Gerrit] Move parsers from lib to repo - change (mediawiki...Wikibase)

2014-11-13 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Move parsers from lib to repo .. Move parsers from lib to repo They are only used in repo. Change-Id: I08bd8883614f1c85b71b52a3f5f56a9646b9f410

[MediaWiki-commits] [Gerrit] Use $this->settings instead of $this->getSettings - change (mediawiki...Wikibase)

2014-11-14 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173262 Change subject: Use $this->settings instead of $this->getSettings .. Use $this->settings instead of $this->getSettin

[MediaWiki-commits] [Gerrit] Rename dataTypes to dataTypeStore - change (mediawiki...Wikibase)

2014-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173773 Change subject: Rename dataTypes to dataTypeStore .. Rename dataTypes to dataTypeStore wbDataTypes is the settings array. This

[MediaWiki-commits] [Gerrit] Move Client tests to namespace Wikibase\Client\Tests - change (mediawiki...Wikibase)

2014-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173786 Change subject: Move Client tests to namespace Wikibase\Client\Tests .. Move Client tests to namespace Wikibase\Client\Tests

[MediaWiki-commits] [Gerrit] Fix namespace of all Wikibase\Client\DataAccess tests - change (mediawiki...Wikibase)

2014-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173787 Change subject: Fix namespace of all Wikibase\Client\DataAccess tests .. Fix namespace of all Wikibase\Client\DataAccess tests

[MediaWiki-commits] [Gerrit] Move all remaining client tests to specific namespaces - change (mediawiki...Wikibase)

2014-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173788 Change subject: Move all remaining client tests to specific namespaces .. Move all remaining client tests to specific namespaces

[MediaWiki-commits] [Gerrit] Change namespace of all Client Scribunto tests - change (mediawiki...Wikibase)

2014-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173797 Change subject: Change namespace of all Client Scribunto tests .. Change namespace of all Client Scribunto tests To be honest

[MediaWiki-commits] [Gerrit] Fix covers tag in WikibaseClientTest - change (mediawiki...Wikibase)

2014-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173819 Change subject: Fix covers tag in WikibaseClientTest .. Fix covers tag in WikibaseClientTest Found by Adrian in I9140582

[MediaWiki-commits] [Gerrit] Replace some Claims with StatementList - change (mediawiki...Wikibase)

2014-11-17 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/173828 Change subject: Replace some Claims with StatementList .. Replace some Claims with StatementList I wanted to replace some

[MediaWiki-commits] [Gerrit] Replace some deprecated setClaims with getStatements - change (mediawiki...Wikibase)

2014-11-18 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/174109 Change subject: Replace some deprecated setClaims with getStatements .. Replace some deprecated setClaims with getStatements

[MediaWiki-commits] [Gerrit] Reduce inheritance in EntityContentTest - change (mediawiki...Wikibase)

2014-11-18 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/174110 Change subject: Reduce inheritance in EntityContentTest .. Reduce inheritance in EntityContentTest Especially the redirect

[MediaWiki-commits] [Gerrit] Drop optional empty array() constructor parameters - change (mediawiki...Wikibase)

2014-11-18 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/174112 Change subject: Drop optional empty array() constructor parameters .. Drop optional empty array() constructor parameters Change

[MediaWiki-commits] [Gerrit] More descriptive names for $repo variables and methods - change (mediawiki...Wikibase)

2014-11-18 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/174123 Change subject: More descriptive names for $repo variables and methods .. More descriptive names for $repo variables and methods

[MediaWiki-commits] [Gerrit] Catch more edge cases in EntityInfo - change (mediawiki...Wikibase)

2014-12-05 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/12 Change subject: Catch more edge cases in EntityInfo .. Catch more edge cases in EntityInfo The most important issue this patch

[MediaWiki-commits] [Gerrit] Remove all readOnly usability blockages - change (mediawiki...MultimediaViewer)

2014-12-05 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177786 Change subject: Remove all readOnly usability blockages .. Remove all readOnly usability blockages I understand that there are

[MediaWiki-commits] [Gerrit] Do not reuse variable in SetClaim - change (mediawiki...Wikibase)

2014-12-05 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/177818 Change subject: Do not reuse variable in SetClaim .. Do not reuse variable in SetClaim Change-Id

[MediaWiki-commits] [Gerrit] Simplify LanguageNameSearch code - change (mediawiki...UniversalLanguageSelector)

2014-12-08 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178224 Change subject: Simplify LanguageNameSearch code .. Simplify LanguageNameSearch code A more efficient "startsWith" l

[MediaWiki-commits] [Gerrit] Clean up ViewEntityAction - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178465 Change subject: Clean up ViewEntityAction .. Clean up ViewEntityAction * Remove redundant code. * Make stuff private or

[MediaWiki-commits] [Gerrit] Make stuff in DirectSqlStore private and fix docs - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178513 Change subject: Make stuff in DirectSqlStore private and fix docs .. Make stuff in DirectSqlStore private and fix docs Change

[MediaWiki-commits] [Gerrit] Narrow DirectSqlStore to use languageCode instead of Language - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178519 Change subject: Narrow DirectSqlStore to use languageCode instead of Language .. Narrow DirectSqlStore to use languageCode

[MediaWiki-commits] [Gerrit] Make stuff private in some Lib\Store lookups - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178521 Change subject: Make stuff private in some Lib\Store lookups .. Make stuff private in some Lib\Store lookups ... and fix some

[MediaWiki-commits] [Gerrit] Fix missing/unused private properties in DirectSqlStore - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178522 Change subject: Fix missing/unused private properties in DirectSqlStore .. Fix missing/unused private properties in

[MediaWiki-commits] [Gerrit] Fix out-of-sync docu in Client/Repo Store implementations - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178524 Change subject: Fix out-of-sync docu in Client/Repo Store implementations .. Fix out-of-sync docu in Client/Repo Store

[MediaWiki-commits] [Gerrit] Clean up DirectSqlStore implementation - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178528 Change subject: Clean up DirectSqlStore implementation .. Clean up DirectSqlStore implementation * Order all class properties

[MediaWiki-commits] [Gerrit] Make stuff in SpecialSetSiteLink private - change (mediawiki...Wikibase)

2014-12-09 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178530 Change subject: Make stuff in SpecialSetSiteLink private .. Make stuff in SpecialSetSiteLink private ... and fix/add some

[MediaWiki-commits] [Gerrit] Avoid RegexValidator if possible - change (mediawiki...Wikibase)

2014-12-10 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178922 Change subject: Avoid RegexValidator if possible .. Avoid RegexValidator if possible ... and a bit of refactoring, mainly

[MediaWiki-commits] [Gerrit] Reduce non-functional validator nesting - change (mediawiki...Wikibase)

2014-12-10 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/178967 Change subject: Reduce non-functional validator nesting .. Reduce non-functional validator nesting ... mainly removing

[MediaWiki-commits] [Gerrit] Drop dead and redundant special page code - change (mediawiki...Wikibase)

2014-12-11 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/179114 Change subject: Drop dead and redundant special page code .. Drop dead and redundant special page code * SpecialPage::execute

[MediaWiki-commits] [Gerrit] Fall back to page title if wikibase-titletext is n/a - change (mediawiki...Wikibase)

2014-12-11 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/179135 Change subject: Fall back to page title if wikibase-titletext is n/a .. Fall back to page title if wikibase-titletext is n/a

[MediaWiki-commits] [Gerrit] Fix broken/missing @covers tags in Lib\Store - change (mediawiki...Wikibase)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/181050 Change subject: Fix broken/missing @covers tags in Lib\Store .. Fix broken/missing @covers tags in Lib\Store Change-Id

[MediaWiki-commits] [Gerrit] Fix broken emails in @author tags - change (mediawiki...Wikibase)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/181051 Change subject: Fix broken emails in @author tags .. Fix broken emails in @author tags ... and use the same @author tag for

[MediaWiki-commits] [Gerrit] Suggester visibility depend on spinner visibility - change (mediawiki...Wikibase)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/181056 Change subject: Suggester visibility depend on spinner visibility .. Suggester visibility depend on spinner visibility This

[MediaWiki-commits] [Gerrit] Add/correct comments in SpecialListDatatypes.php - change (mediawiki...Wikibase)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Add/correct comments in SpecialListDatatypes.php .. Add/correct comments in SpecialListDatatypes.php Adds comments for missing messages or ones

[MediaWiki-commits] [Gerrit] Added type checks to wikibase.api.RepoApi functions - change (mediawiki...WikibaseJavaScriptApi)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Added type checks to wikibase.api.RepoApi functions .. Added type checks to wikibase.api.RepoApi functions Actually reflecting parameter

[MediaWiki-commits] [Gerrit] Added RepoApi tests for functions not yet tested - change (mediawiki...WikibaseJavaScriptApi)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Added RepoApi tests for functions not yet tested .. Added RepoApi tests for functions not yet tested Change-Id

[MediaWiki-commits] [Gerrit] getEntitiesByPage: Always submit "normalize" parameter if sp... - change (mediawiki...WikibaseJavaScriptApi)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: getEntitiesByPage: Always submit "normalize" parameter if specified .. getEntitiesByPage: Always submit "normalize" pa

[MediaWiki-commits] [Gerrit] Rewrote RepoApi tests - change (mediawiki...WikibaseJavaScriptApi)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Rewrote RepoApi tests .. Rewrote RepoApi tests Implemented mocking/spying using SinonJS. No actual API request are triggered anymore. Change

[MediaWiki-commits] [Gerrit] Add i18n messages for the new 'wikibase-property' datatype - change (mediawiki...Wikibase)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Add i18n messages for the new 'wikibase-property' datatype .. Add i18n messages for the new 'wikibase-property'

[MediaWiki-commits] [Gerrit] This is a direct follow up to I4261b3d. - change (mediawiki...Wikibase)

2014-12-19 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/181094 Change subject: This is a direct follow up to I4261b3d. .. This is a direct follow up to I4261b3d. * Type hinted against

[MediaWiki-commits] [Gerrit] Reuse existing date formats in MwTimeIsoFormatter - change (mediawiki...Wikibase)

2014-07-23 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/148641 Change subject: Reuse existing date formats in MwTimeIsoFormatter .. Reuse existing date formats in MwTimeIsoFormatter This is

[MediaWiki-commits] [Gerrit] Add more test cases to EntityInfoBuilderTest - change (mediawiki...Wikibase)

2014-07-23 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/148658 Change subject: Add more test cases to EntityInfoBuilderTest .. Add more test cases to EntityInfoBuilderTest This is a follow

[MediaWiki-commits] [Gerrit] Add more DataValues to DataModelSerializationRoundtripTest - change (mediawiki...Wikibase)

2014-07-24 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149000 Change subject: Add more DataValues to DataModelSerializationRoundtripTest .. Add more DataValues to

[MediaWiki-commits] [Gerrit] Roundtrip tests for Qualifiers and References - change (mediawiki...Wikibase)

2014-07-24 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149038 Change subject: Roundtrip tests for Qualifiers and References .. Roundtrip tests for Qualifiers and References This fails

[MediaWiki-commits] [Gerrit] Add test for ranks to DataModelSerializationRoundtripTest - change (mediawiki...Wikibase)

2014-07-24 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149048 Change subject: Add test for ranks to DataModelSerializationRoundtripTest .. Add test for ranks to

[MediaWiki-commits] [Gerrit] Drop dead experimental code - change (mediawiki...Wikibase)

2014-07-25 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149280 Change subject: Drop dead experimental code .. Drop dead experimental code Warning: I honestly don't know what the purpo

[MediaWiki-commits] [Gerrit] Code style cleanup in wbcreateredirect API module - change (mediawiki...Wikibase)

2014-07-25 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149286 Change subject: Code style cleanup in wbcreateredirect API module .. Code style cleanup in wbcreateredirect API module This is

[MediaWiki-commits] [Gerrit] Add missing type hints - change (mediawiki...Wikibase)

2014-07-25 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149291 Change subject: Add missing type hints .. Add missing type hints Change-Id: I1cb04a13d84ca90aec18d557bf5b8e48299c3d99 --- M

[MediaWiki-commits] [Gerrit] [WIP] All date formats in all languages should roundtrip - change (mediawiki...Wikibase)

2014-07-25 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149294 Change subject: [WIP] All date formats in all languages should roundtrip .. [WIP] All date formats in all languages should

[MediaWiki-commits] [Gerrit] LegacyIdInterpreter::newIdFromTypeAndNumber is static - change (mediawiki...Wikibase)

2014-07-25 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149309 Change subject: LegacyIdInterpreter::newIdFromTypeAndNumber is static .. LegacyIdInterpreter::newIdFromTypeAndNumber is static

[MediaWiki-commits] [Gerrit] Remove temporary performance hack - change (mediawiki...Wikibase)

2014-07-25 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149385 Change subject: Remove temporary performance hack .. Remove temporary performance hack See I3bb39e7. I don't see a diffe

[MediaWiki-commits] [Gerrit] Add support for numeric months in MwTimeIsoFormatter - change (mediawiki...Wikibase)

2014-07-28 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/149823 Change subject: Add support for numeric months in MwTimeIsoFormatter .. Add support for numeric months in MwTimeIsoFormatter &q

[MediaWiki-commits] [Gerrit] Add UnDeserializableValue to DataModelSerializationRoundtrip... - change (mediawiki...Wikibase)

2014-07-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/150202 Change subject: Add UnDeserializableValue to DataModelSerializationRoundtripTest .. Add UnDeserializableValue to

[MediaWiki-commits] [Gerrit] Add order test to DataModelSerializationRoundtripTest - change (mediawiki...Wikibase)

2014-07-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/150284 Change subject: Add order test to DataModelSerializationRoundtripTest .. Add order test to DataModelSerializationRoundtripTest

[MediaWiki-commits] [Gerrit] Use real cloning in ChangeOpAliasesTest - change (mediawiki...Wikibase)

2014-07-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/150308 Change subject: Use real cloning in ChangeOpAliasesTest .. Use real cloning in ChangeOpAliasesTest Clone doesn't really

[MediaWiki-commits] [Gerrit] Replace Aliases in WikibaseRepo class map - change (mediawiki...Wikibase)

2014-07-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/150376 Change subject: Replace Aliases in WikibaseRepo class map .. Replace Aliases in WikibaseRepo class map I honestly don't kn

[MediaWiki-commits] [Gerrit] Refactoring/optimizing SpecialUnconnectedPages - change (mediawiki...Wikibase)

2014-06-06 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/138100 Change subject: Refactoring/optimizing SpecialUnconnectedPages .. Refactoring/optimizing SpecialUnconnectedPages Some basic

[MediaWiki-commits] [Gerrit] Expand tooltip details fast - change (mediawiki...Wikibase)

2014-06-10 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/138654 Change subject: Expand tooltip details fast .. Expand tooltip details fast There is no reason to slow this down so much. The

[MediaWiki-commits] [Gerrit] Accept array of HTML messages in tooltip JavaScript - change (mediawiki...Wikibase)

2014-06-10 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/138660 Change subject: Accept array of HTML messages in tooltip JavaScript .. Accept array of HTML messages in tooltip JavaScript I

[MediaWiki-commits] [Gerrit] Bump ValueView to version 0.6.2 - change (mediawiki...Wikibase)

2014-06-10 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/138679 Change subject: Bump ValueView to version 0.6.2 .. Bump ValueView to version 0.6.2 Because of https://github.com/wmde/ValueView

[MediaWiki-commits] [Gerrit] [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSeria... - change (mediawiki...Wikibase)

2014-06-11 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/138790 Change subject: [WIP] Roundtrip tests for Lib\Serializers vs. DataModelSerialization .. [WIP] Roundtrip tests for Lib

<    1   2   3   4   5   6   7   8   9   10   >