[MediaWiki-commits] [Gerrit] Fix incorrect replacement inside regular expression - change (mediawiki/core)

2014-10-20 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/167537 Change subject: Fix incorrect replacement inside regular expression .. Fix incorrect replacement inside regular expression Fix for Id3aa87cfa0

[MediaWiki-commits] [Gerrit] Get the value of microtime() directly as float in updateSpec... - change (mediawiki/core)

2014-10-20 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/167621 Change subject: Get the value of microtime() directly as float in updateSpecialPages.php .. Get the value of microtime() directly as float in

[MediaWiki-commits] [Gerrit] Use $_SERVER[REQUEST_TIME_FLOAT] for $wgRequestTime if ava... - change (mediawiki/core)

2014-10-20 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/167630 Change subject: Use $_SERVER[REQUEST_TIME_FLOAT] for $wgRequestTime if available .. Use $_SERVER[REQUEST_TIME_FLOAT] for $wgRequestTime if

[MediaWiki-commits] [Gerrit] Add returntoquery URL parameter support in Special:ChangeE... - change (mediawiki/core)

2014-09-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/163552 Change subject: Add returntoquery URL parameter support in Special:ChangeEmail .. Add returntoquery URL parameter support in

[MediaWiki-commits] [Gerrit] Remove executable bit from non-executable files - change (mediawiki/core)

2014-09-27 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/163377 Change subject: Remove executable bit from non-executable files .. Remove executable bit from non-executable files Change-Id:

[MediaWiki-commits] [Gerrit] Remove dead code after removal of cancel button on Special:C... - change (mediawiki/core)

2014-09-27 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/163447 Change subject: Remove dead code after removal of cancel button on Special:ChangeEmail .. Remove dead code after removal of cancel button on

[MediaWiki-commits] [Gerrit] Remove executable bit from non-executable files - change (mediawiki/core)

2014-09-26 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/163109 Change subject: Remove executable bit from non-executable files .. Remove executable bit from non-executable files Follow-up: - Ibd1c0617c4

[MediaWiki-commits] [Gerrit] Add missing space to log message - change (mediawiki/core)

2014-09-23 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/162216 Change subject: Add missing space to log message .. Add missing space to log message Follow-up I72c5c3fb75 (6fc2e603). Change-Id:

[MediaWiki-commits] [Gerrit] Coding standard fixes in SpecialChangeEmail.php - change (mediawiki/core)

2014-09-17 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/160919 Change subject: Coding standard fixes in SpecialChangeEmail.php .. Coding standard fixes in SpecialChangeEmail.php Follow-up Ic5246ea0eb

[MediaWiki-commits] [Gerrit] Avoid a fatal error in maintenance/cleanupTitles.php - change (mediawiki/core)

2014-09-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/159116 Change subject: Avoid a fatal error in maintenance/cleanupTitles.php .. Avoid a fatal error in maintenance/cleanupTitles.php

[MediaWiki-commits] [Gerrit] Replace $wgConf-localVHosts by $wgLocalVirtualHosts - change (mediawiki/core)

2014-09-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/157712 Change subject: Replace $wgConf-localVHosts by $wgLocalVirtualHosts .. Replace $wgConf-localVHosts by $wgLocalVirtualHosts The former is

[MediaWiki-commits] [Gerrit] Remove the sub page when using the form in Special:ListFiles - change (mediawiki/core)

2014-08-27 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/156684 Change subject: Remove the sub page when using the form in Special:ListFiles .. Remove the sub page when using the form in Special:ListFiles

[MediaWiki-commits] [Gerrit] Use as strict comparison to check whether an user name was p... - change (mediawiki/core)

2014-08-27 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/156688 Change subject: Use as strict comparison to check whether an user name was provided in Special:ListFiles .. Use as strict comparison to check

[MediaWiki-commits] [Gerrit] Use Config instead of globals in CategoryViewer.php - change (mediawiki/core)

2014-08-26 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/156456 Change subject: Use Config instead of globals in CategoryViewer.php .. Use Config instead of globals in CategoryViewer.php Change-Id:

[MediaWiki-commits] [Gerrit] Use local content to get configuration settings in Action - change (mediawiki/core)

2014-08-16 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/154429 Change subject: Use local content to get configuration settings in Action .. Use local content to get configuration settings in Action

[MediaWiki-commits] [Gerrit] Remove useless $out parameter from SkinTemplate::prepareQuic... - change (mediawiki/core)

2014-08-12 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/153636 Change subject: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() .. Remove useless $out parameter from

[MediaWiki-commits] [Gerrit] Fix undefined variable notice in ResourceLoaderFileModule::g... - change (mediawiki/core)

2014-08-12 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/153638 Change subject: Fix undefined variable notice in ResourceLoaderFileModule::getSkipFunction() .. Fix undefined variable notice in

[MediaWiki-commits] [Gerrit] Correctly handle incorrect namespace in cleanupTitles.php - change (mediawiki/core)

2014-08-12 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/153644 Change subject: Correctly handle incorrect namespace in cleanupTitles.php .. Correctly handle incorrect namespace in cleanupTitles.php If the

[MediaWiki-commits] [Gerrit] Don't set the session name in CLI or when sessions are deact... - change (mediawiki/core)

2014-08-04 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/151722 Change subject: Don't set the session name in CLI or when sessions are deactivated .. Don't set the session name in CLI or when sessions are

[MediaWiki-commits] [Gerrit] Group E-mail settings stuff in Setup.php - change (mediawiki/core)

2014-08-04 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/151768 Change subject: Group E-mail settings stuff in Setup.php .. Group E-mail settings stuff in Setup.php - Move the overrides of e-mail settings

[MediaWiki-commits] [Gerrit] Move debug log related settings up in Setup.php - change (mediawiki/core)

2014-08-04 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/151769 Change subject: Move debug log related settings up in Setup.php .. Move debug log related settings up in Setup.php Since this doesn't rely on

[MediaWiki-commits] [Gerrit] Use camel case for variable names in Article.php - change (mediawiki/core)

2014-08-02 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/151288 Change subject: Use camel case for variable names in Article.php .. Use camel case for variable names in Article.php Found only one which was

[MediaWiki-commits] [Gerrit] Deglobalise some special pages - change (mediawiki/core)

2014-08-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/151085 Change subject: Deglobalise some special pages .. Deglobalise some special pages Change-Id: Ib983d7ee7817139d3c016df2f10deb7385927f06 --- M

[MediaWiki-commits] [Gerrit] Factorise $this-getTitle() call in Article::confirmDelete() - change (mediawiki/core)

2014-08-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/151086 Change subject: Factorise $this-getTitle() call in Article::confirmDelete() .. Factorise $this-getTitle() call in Article::confirmDelete()

[MediaWiki-commits] [Gerrit] Remove useless temporary variable in Setup.php - change (mediawiki/core)

2014-07-31 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/150886 Change subject: Remove useless temporary variable in Setup.php .. Remove useless temporary variable in Setup.php Also makes the definition of

[MediaWiki-commits] [Gerrit] Add method XmlSelect::addAttributes() and use it in HTMLSele... - change (mediawiki/core)

2014-07-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144671 Change subject: Add method XmlSelect::addAttributes() and use it in HTMLSelectField .. Add method XmlSelect::addAttributes() and use it in

[MediaWiki-commits] [Gerrit] Fix the (un)watch token to include the namespace name. - change (mediawiki/core)

2014-07-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144749 Change subject: Fix the (un)watch token to include the namespace name. .. Fix the (un)watch token to include the namespace name.

[MediaWiki-commits] [Gerrit] Use the user from the context to format the date in Block::g... - change (mediawiki/core)

2014-07-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144755 Change subject: Use the user from the context to format the date in Block::getPermissionsError() .. Use the user from the context to format

[MediaWiki-commits] [Gerrit] Allow to set a salt for the edit token in HTMLForm - change (mediawiki/core)

2014-07-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144766 Change subject: Allow to set a salt for the edit token in HTMLForm .. Allow to set a salt for the edit token in HTMLForm And set one in

[MediaWiki-commits] [Gerrit] Remove tabindex from the drop-down in Special:RevisionDelete - change (mediawiki/core)

2014-07-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144348 Change subject: Remove tabindex from the drop-down in Special:RevisionDelete .. Remove tabindex from the drop-down in Special:RevisionDelete

[MediaWiki-commits] [Gerrit] Allow size attribute to HTMLSelectField - change (mediawiki/core)

2014-07-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144371 Change subject: Allow size attribute to HTMLSelectField .. Allow size attribute to HTMLSelectField Pass this one to XmlSelect is provided.

[MediaWiki-commits] [Gerrit] Some misc cleanup to ProtectionForm - change (mediawiki/core)

2014-07-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144372 Change subject: Some misc cleanup to ProtectionForm .. Some misc cleanup to ProtectionForm - Set variables near to where they are used in

[MediaWiki-commits] [Gerrit] Don't use isset to check for null - change (mediawiki/core)

2014-07-04 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144177 Change subject: Don't use isset to check for null .. Don't use isset to check for null Change isset() checks for variables that are always

[MediaWiki-commits] [Gerrit] Don't use isset() to check for null - change (mediawiki/core)

2014-07-03 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144047 Change subject: Don't use isset() to check for null .. Don't use isset() to check for null - Remove isset for defined member variables - Add a

[MediaWiki-commits] [Gerrit] Force array parameters in SiteConfiguration - change (mediawiki/core)

2014-07-03 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/144049 Change subject: Force array parameters in SiteConfiguration .. Force array parameters in SiteConfiguration Now that we require PHP 5.1 (for

[MediaWiki-commits] [Gerrit] Don't use isset() to check for null - change (mediawiki/core)

2014-07-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/143353 Change subject: Don't use isset() to check for null .. Don't use isset() to check for null Those two member variables are always defined.

[MediaWiki-commits] [Gerrit] Don't use isset() to check for null - change (mediawiki/core)

2014-06-30 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/143085 Change subject: Don't use isset() to check for null .. Don't use isset() to check for null $wgLocalTZoffset is defined in DefaultSettings.php

[MediaWiki-commits] [Gerrit] Use HTMLForm to generate the form on Special:ListFiles - change (mediawiki/core)

2014-06-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/142876 Change subject: Use HTMLForm to generate the form on Special:ListFiles .. Use HTMLForm to generate the form on Special:ListFiles - Makes the

[MediaWiki-commits] [Gerrit] Update Special:ChangeEmail to use HTMLForm - change (mediawiki/core)

2014-06-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/142878 Change subject: Update Special:ChangeEmail to use HTMLForm .. Update Special:ChangeEmail to use HTMLForm Makes the code shorter and easier to

[MediaWiki-commits] [Gerrit] Fix documentation of HistoryPager::lastLink() and make code ... - change (mediawiki/core)

2014-06-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/142899 Change subject: Fix documentation of HistoryPager::lastLink() and make code more readable .. Fix documentation of HistoryPager::lastLink() and

[MediaWiki-commits] [Gerrit] Remove unneeded else brach from SpecialAllMessages::execute() - change (mediawiki/core)

2014-06-28 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/142827 Change subject: Remove unneeded else brach from SpecialAllMessages::execute() .. Remove unneeded else brach from SpecialAllMessages::execute()

[MediaWiki-commits] [Gerrit] Also check if 'debug_backtrace' is diabled in Maintenance::s... - change (mediawiki/core)

2014-06-25 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/142117 Change subject: Also check if 'debug_backtrace' is diabled in Maintenance::shouldExecute() .. Also check if 'debug_backtrace' is diabled in

[MediaWiki-commits] [Gerrit] Documentation improvements in ChangeTags.php - change (mediawiki/core)

2014-06-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/138670 Change subject: Documentation improvements in ChangeTags.php .. Documentation improvements in ChangeTags.php - Variables in

[MediaWiki-commits] [Gerrit] Remove not-working scripts in maintenance/language - change (mediawiki/core)

2014-05-23 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/135182 Change subject: Remove not-working scripts in maintenance/language .. Remove not-working scripts in maintenance/language Change-Id:

[MediaWiki-commits] [Gerrit] Don't use isset() to check for null - change (mediawiki/core)

2014-05-23 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/135184 Change subject: Don't use isset() to check for null .. Don't use isset() to check for null Fixes in includes/specials Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused variables from SpecialAllpages::showToplevel() - change (mediawiki/core)

2014-05-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/133209 Change subject: Remove unused variables from SpecialAllpages::showToplevel() .. Remove unused variables from SpecialAllpages::showToplevel()

[MediaWiki-commits] [Gerrit] Improve a bit the code of SpecialAllpages::showChunk() - change (mediawiki/core)

2014-05-13 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/133103 Change subject: Improve a bit the code of SpecialAllpages::showChunk() .. Improve a bit the code of SpecialAllpages::showChunk() - Early

[MediaWiki-commits] [Gerrit] Remove messageTypes.inc and replace it by a hook - change (mediawiki/core)

2014-05-13 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/133122 Change subject: Remove messageTypes.inc and replace it by a hook .. Remove messageTypes.inc and replace it by a hook The list is now

[MediaWiki-commits] [Gerrit] Don't use $this for docuementing hook parameters - change (mediawiki/core)

2014-05-11 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132789 Change subject: Don't use $this for docuementing hook parameters .. Don't use $this for docuementing hook parameters It is a reserved keyword,

[MediaWiki-commits] [Gerrit] Deprecate $wgSessionStarted - change (mediawiki/core)

2014-05-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132624 Change subject: Deprecate $wgSessionStarted .. Deprecate $wgSessionStarted Wrape it in a DeprecatedGlobal object to notify extensions using it

[MediaWiki-commits] [Gerrit] Improve a bit Database-related documentation - change (mediawiki/core)

2014-05-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132625 Change subject: Improve a bit Database-related documentation .. Improve a bit Database-related documentation - $wgDBport is also for MSSQL -

[MediaWiki-commits] [Gerrit] Allow to send the memory usage with UDP profiler. - change (mediawiki/core)

2014-05-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132643 Change subject: Allow to send the memory usage with UDP profiler. .. Allow to send the memory usage with UDP profiler. Mention the possibility

[MediaWiki-commits] [Gerrit] Remove isset() check for $wgLocalTZoffset in Language.php - change (mediawiki/core)

2014-05-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132646 Change subject: Remove isset() check for $wgLocalTZoffset in Language.php .. Remove isset() check for $wgLocalTZoffset in Language.php Do not

[MediaWiki-commits] [Gerrit] Remove useless variable from Title::newFromText() - change (mediawiki/core)

2014-05-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132648 Change subject: Remove useless variable from Title::newFromText() .. Remove useless variable from Title::newFromText() Instead of setting and

[MediaWiki-commits] [Gerrit] Don't use isset() to check for null - change (mediawiki/core)

2014-05-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132664 Change subject: Don't use isset() to check for null .. Don't use isset() to check for null Fixes in maintenance/ Change-Id:

[MediaWiki-commits] [Gerrit] One more bump for 1.24 - change (mediawiki/core)

2014-04-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/125766 Change subject: One more bump for 1.24 .. One more bump for 1.24 But this one is 1.22 - 1.23! Change-Id:

[MediaWiki-commits] [Gerrit] Make profiling to UDP work again - change (mediawiki/core)

2014-04-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/125770 Change subject: Make profiling to UDP work again .. Make profiling to UDP work again Fix for I1260bab2b5 (afa6af0). Since

[MediaWiki-commits] [Gerrit] Normalise comments in Setup.php - change (mediawiki/core)

2014-04-13 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/125677 Change subject: Normalise comments in Setup.php .. Normalise comments in Setup.php - Changed # to // for non-block comments - Put the inline

[MediaWiki-commits] [Gerrit] Improve UDP logging code - change (mediawiki/core)

2014-04-11 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/125436 Change subject: Improve UDP logging code .. Improve UDP logging code - Use stream_socket_client() instead of socket_create() for the UDP

[MediaWiki-commits] [Gerrit] Fix spelling: occurred - change (mediawiki...ErrorHandler)

2014-04-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Fix spelling: occurred .. Fix spelling: occurred Change-Id: I3cf77d84debc55fed9ba033e252b07f33f949e11 --- M ErrorHandler.php 1 file changed, 2 insertions(+), 2

[MediaWiki-commits] [Gerrit] Remove isset() check in Sanitizer::setupAttributeWhitelist() - change (mediawiki/core)

2014-04-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/124157 Change subject: Remove isset() check in Sanitizer::setupAttributeWhitelist() .. Remove isset() check in Sanitizer::setupAttributeWhitelist()

[MediaWiki-commits] [Gerrit] Remove obsolete settings - change (mediawiki...Configure)

2014-04-06 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Remove obsolete settings .. Remove obsolete settings Change-Id: I583f0eb09f0deade803eac0ad9b57fe0ae413464 --- M settings/Settings-core.php M

[MediaWiki-commits] [Gerrit] Remove obsolete settings - change (mediawiki...Configure)

2014-04-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/124188 Change subject: Remove obsolete settings .. Remove obsolete settings Change-Id: I583f0eb09f0deade803eac0ad9b57fe0ae413464 --- M

[MediaWiki-commits] [Gerrit] Misc follow-up - change (mediawiki...Configure)

2014-04-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/124256 Change subject: Misc follow-up .. Misc follow-up - Required version is now 1.23 (SpecialPage::getPageTitle()) - Replace another call to

[MediaWiki-commits] [Gerrit] Fix usage of $wgDebugDumpSql - change (mediawiki/core)

2014-04-05 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/124048 Change subject: Fix usage of $wgDebugDumpSql .. Fix usage of $wgDebugDumpSql - In DatabaseMssql, use $this-debug() instead of $wgDebugDumpSql

[MediaWiki-commits] [Gerrit] Correctly order AutoLoader class definitions - change (mediawiki/core)

2014-04-05 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/124051 Change subject: Correctly order AutoLoader class definitions .. Correctly order AutoLoader class definitions - Group per directory - Sort by

[MediaWiki-commits] [Gerrit] Disabling profiling in the debug toolbar for ProfilerSimple ... - change (mediawiki/core)

2014-04-05 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/124066 Change subject: Disabling profiling in the debug toolbar for ProfilerSimple (for now) .. Disabling profiling in the debug toolbar for

[MediaWiki-commits] [Gerrit] Remove trailing line break check from MemcachedBagOStuff::de... - change (mediawiki/core)

2014-04-05 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/124067 Change subject: Remove trailing line break check from MemcachedBagOStuff::debugLog() .. Remove trailing line break check from

[MediaWiki-commits] [Gerrit] fix typo in comment in Preferences.php - change (mediawiki/core)

2014-04-05 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: fix typo in comment in Preferences.php .. fix typo in comment in Preferences.php The name of the preference was spelled wrong. Change-Id:

[MediaWiki-commits] [Gerrit] Fix language statistics after messages have been moved to JSON - change (mediawiki/core)

2014-04-02 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/123358 Change subject: Fix language statistics after messages have been moved to JSON .. Fix language statistics after messages have been moved to

[MediaWiki-commits] [Gerrit] Send profiled items under the correct name - change (mediawiki/core)

2014-04-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/122780 Change subject: Send profiled items under the correct name .. Send profiled items under the correct name Fix for Ie8481a2e13 (811a084). The

[MediaWiki-commits] [Gerrit] Make the global objects documentation consistent in Setup.php - change (mediawiki/core)

2014-04-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/122875 Change subject: Make the global objects documentation consistent in Setup.php .. Make the global objects documentation consistent in Setup.php

[MediaWiki-commits] [Gerrit] Add missing line breaks to wfDebug() calls - change (mediawiki/core)

2014-03-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121928 Change subject: Add missing line breaks to wfDebug() calls .. Add missing line breaks to wfDebug() calls Also removed true as second parameter

[MediaWiki-commits] [Gerrit] Send the localisation store debug message to the caches lo... - change (mediawiki/core)

2014-03-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121971 Change subject: Send the localisation store debug message to the caches log group .. Send the localisation store debug message to the caches

[MediaWiki-commits] [Gerrit] Send the profiler output to the 'profileoutput' log group - change (mediawiki/core)

2014-03-27 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121336 Change subject: Send the profiler output to the 'profileoutput' log group .. Send the profiler output to the 'profileoutput' log group And

[MediaWiki-commits] [Gerrit] Fix path in findHooks.php script - change (mediawiki/core)

2014-03-27 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121433 Change subject: Fix path in findHooks.php script .. Fix path in findHooks.php script Follow-up I4c8a2b421 (9ffd4f0): include/job was renamed

[MediaWiki-commits] [Gerrit] Use {{FULLPAGENAME}} in 'missing-revision' message. - change (mediawiki/core)

2014-03-27 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121444 Change subject: Use {{FULLPAGENAME}} in 'missing-revision' message. .. Use {{FULLPAGENAME}} in 'missing-revision' message. Otherwise the

[MediaWiki-commits] [Gerrit] Fixed bug where variables referenced where not reachable (ou... - change (mediawiki...MassEditRegex)

2014-03-27 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Fixed bug where variables referenced where not reachable (out of scope) .. Fixed bug where variables referenced where not reachable (out of scope) Change-Id:

[MediaWiki-commits] [Gerrit] Use session_id() instead of $wgSessionStarted to check for s... - change (mediawiki...FacebookOpenGraph)

2014-03-26 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121243 Change subject: Use session_id() instead of $wgSessionStarted to check for session existence .. Use session_id() instead of $wgSessionStarted

[MediaWiki-commits] [Gerrit] Remove useless .DS_Store file - change (mediawiki...WikibaseMobile)

2014-03-26 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121245 Change subject: Remove useless .DS_Store file .. Remove useless .DS_Store file Change-Id: I0913f1dbc0003d56fe5b6c27181c309b2aa6f5ea --- D

[MediaWiki-commits] [Gerrit] Use session_id() instead of $wgSessionStarted to check for s... - change (mediawiki...SecureSessions)

2014-03-26 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121246 Change subject: Use session_id() instead of $wgSessionStarted to check for session existence .. Use session_id() instead of $wgSessionStarted

[MediaWiki-commits] [Gerrit] Use session_id() instead of $wgSessionStarted to check for s... - change (mediawiki...SocialLogin)

2014-03-26 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/121250 Change subject: Use session_id() instead of $wgSessionStarted to check for session existence .. Use session_id() instead of $wgSessionStarted

[MediaWiki-commits] [Gerrit] Remove wfDebugLog() call from wfSetupSession() - change (mediawiki/core)

2014-03-25 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/120848 Change subject: Remove wfDebugLog() call from wfSetupSession() .. Remove wfDebugLog() call from wfSetupSession() Since Iffba121a99 (00b7f76)

[MediaWiki-commits] [Gerrit] Remove unused $wgLicenseTerms - change (mediawiki/core)

2014-03-25 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/120860 Change subject: Remove unused $wgLicenseTerms .. Remove unused $wgLicenseTerms Follow-up I3454d605a7 (4ebd4de). Change-Id:

[MediaWiki-commits] [Gerrit] Fix documentation of wfDebugLog() - change (mediawiki/core)

2014-03-23 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/120354 Change subject: Fix documentation of wfDebugLog() .. Fix documentation of wfDebugLog() - $public parameter does not exist anymore - Put the

[MediaWiki-commits] [Gerrit] Automatically add a new line at the end of wfLogDBError() - change (mediawiki/core)

2014-03-23 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/120355 Change subject: Automatically add a new line at the end of wfLogDBError() .. Automatically add a new line at the end of wfLogDBError() I found

[MediaWiki-commits] [Gerrit] Remove double wfDebug() call in Database.php - change (mediawiki/core)

2014-03-23 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/120360 Change subject: Remove double wfDebug() call in Database.php .. Remove double wfDebug() call in Database.php Fix for I12adfb4fcb (54664be).

[MediaWiki-commits] [Gerrit] Fix profiling error in LocalisationCache::readJSONFile() - change (mediawiki/core)

2014-03-18 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/119244 Change subject: Fix profiling error in LocalisationCache::readJSONFile() .. Fix profiling error in LocalisationCache::readJSONFile() Follow-up

[MediaWiki-commits] [Gerrit] Use elseif instead of else if in PHP - change (mediawiki/core)

2014-03-15 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/118811 Change subject: Use elseif instead of else if in PHP .. Use elseif instead of else if in PHP Per

[MediaWiki-commits] [Gerrit] Move variable definitions near to where they are used - change (mediawiki/core)

2014-03-15 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/118813 Change subject: Move variable definitions near to where they are used .. Move variable definitions near to where they are used In

[MediaWiki-commits] [Gerrit] New 'profileerror' log group for profiling errors - change (mediawiki/core)

2014-03-15 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/118937 Change subject: New 'profileerror' log group for profiling errors .. New 'profileerror' log group for profiling errors Easier to catch them

[MediaWiki-commits] [Gerrit] Link to bugs.mediawiki.org in UPGRADE for consistency - change (mediawiki/core)

2014-03-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/118761 Change subject: Link to bugs.mediawiki.org in UPGRADE for consistency .. Link to bugs.mediawiki.org in UPGRADE for consistency README mentions

[MediaWiki-commits] [Gerrit] Put the else (or elseif) on the same line as the previou... - change (mediawiki/core)

2014-03-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/118764 Change subject: Put the else (or elseif) on the same line as the previous closing brace .. Put the else (or elseif) on the same line as the

[MediaWiki-commits] [Gerrit] Remove request_with_session/request_without_session from sho... - change (mediawiki/core)

2014-03-13 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/118437 Change subject: Remove request_with_session/request_without_session from showCacheStats.php .. Remove

[MediaWiki-commits] [Gerrit] Don't use isset() to check whether an existing variable is null - change (mediawiki/core)

2014-03-11 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/118092 Change subject: Don't use isset() to check whether an existing variable is null .. Don't use isset() to check whether an existing variable is

[MediaWiki-commits] [Gerrit] Add a deprecation notice of $wgRateLimitLog in RELEASE-NOTES - change (mediawiki/core)

2014-03-04 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/116755 Change subject: Add a deprecation notice of $wgRateLimitLog in RELEASE-NOTES .. Add a deprecation notice of $wgRateLimitLog in RELEASE-NOTES

[MediaWiki-commits] [Gerrit] Update messages.inc and rebuild MessagesEn.php. Again. - change (mediawiki/core)

2014-03-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/116262 Change subject: Update messages.inc and rebuild MessagesEn.php. Again. .. Update messages.inc and rebuild MessagesEn.php. Again. Follow-up

[MediaWiki-commits] [Gerrit] Explicitely return null from WikiPage::newFromID() - change (mediawiki/core)

2014-02-13 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/113149 Change subject: Explicitely return null from WikiPage::newFromID() .. Explicitely return null from WikiPage::newFromID() Follow-up I8943b4dec5

[MediaWiki-commits] [Gerrit] Use wfShellWikiCmd() for the shell command in cleanupSpam.php - change (mediawiki/core)

2014-02-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/112297 Change subject: Use wfShellWikiCmd() for the shell command in cleanupSpam.php .. Use wfShellWikiCmd() for the shell command in cleanupSpam.php

[MediaWiki-commits] [Gerrit] Put line breaks after each element in OutputPage::headElement() - change (mediawiki/core)

2014-02-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/111794 Change subject: Put line breaks after each element in OutputPage::headElement() .. Put line breaks after each element in

  1   2   3   4   5   6   7   8   >