On Wed, 11 Apr 2018 00:41:41 +0900
Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1522590109 -32400
> # Sun Apr 01 22:41:49 2018 +0900
> # Node ID a4d06c685ee182279e91c2856d8a69e809c6e317
> # Parent d9f6292315ef2ee3553a6dc10c20eefd
> hgweb: wrap {arch
pulkit added inline comments.
INLINE COMMENTS
> mharbison72 wrote in test-infinitepush-ci.t:79
> On Windows, this command fails like so. Any thoughts on the unexpected end
> of stream?
>
> --- c:/Users/Matt/projects/hg/tests/test-infinitepush-ci.t
> +++ c:/Users/Matt/projects/hg/tests/test
pulkit added a comment.
In https://phab.mercurial-scm.org/D3218#51610, @yuja wrote:
> `print(nonascii)` may fail depending on the locale.
> We have to use `getattr(sys.stdout, 'buffer', sys.stdout)` or
`pycompat.stdout`.
I get the following failure:
--- /home/foobar/repo
pulkit updated this revision to Diff 7962.
pulkit retitled this revision from "py3: use pycompat.bytestr() where repr in
involved" to "py3: use pycompat.byterepr() instead of repr()".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3216?vs=7928&id=7962
REV
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3244
AFFECTED FILES
hgext/mq.py
CHANGE DETAILS
diff --git a/hgext/mq.py b/hgext/mq.py
--- a/hgext/mq.p
On 02/03/2018 05:58, Yuya Nishihara wrote:
On Thu, 1 Mar 2018 15:48:47 -0500, Feld Boris wrote:
On 26/02/2018 08:11, Yuya Nishihara wrote:
On Mon, 26 Feb 2018 11:45:03 +0100, Feld Boris wrote:
On 13/02/2018 12:47, Yuya Nishihara wrote:
On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote:
#
# HG changeset patch
# User Boris Feld
# Date 1520412972 18000
# Wed Mar 07 03:56:12 2018 -0500
# Node ID 00090d394d4e0a7c2637f161493353530dcf739d
# Parent 5c1a0d784a26d4e8659dcec80503c8764432a303
# EXP-Topic noname
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1523369212 -7200
# Tue Apr 10 16:06:52 2018 +0200
# Node ID 1fa181fa9b18860c1ec97a31def9bcfcc6959057
# Parent b52727111f7f17524fd8e8982af59b5f372cc7c3
# EXP-Topic noname
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1523367822 -7200
# Tue Apr 10 15:43:42 2018 +0200
# Node ID b52727111f7f17524fd8e8982af59b5f372cc7c3
# Parent 00090d394d4e0a7c2637f161493353530dcf739d
# EXP-Topic noname
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1519922236 18000
# Thu Mar 01 11:37:16 2018 -0500
# Node ID 5c1a0d784a26d4e8659dcec80503c8764432a303
# Parent e45545f7895e66d55379a7db48b13831eff6cf2a
# EXP-Topic noname
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
yuja added a comment.
Maybe you didn't add "\n".
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3218
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-
pulkit updated this revision to Diff 7964.
pulkit retitled this revision from "py3: use print as a function in
test-mq-qpush-fail.t" to "py3: use sys.stdout instead of print in
test-mq-qpush-fail.t".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3218?vs=
pulkit added a comment.
In https://phab.mercurial-scm.org/D3218#51878, @yuja wrote:
> Maybe you didn't add "\n".
Yep, I didn't add "\n". Thanks a lot!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3218
To: pulkit, #hg-reviewers, yuja
Cc: yuja, merc
pulkit abandoned this revision.
pulkit added a comment.
Superseded by https://phab.mercurial-scm.org/D3218.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2334
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
On Tue, 10 Apr 2018 16:09:24 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1523154140 14400
> # Sat Apr 07 22:22:20 2018 -0400
> # Node ID b784de3b414876f25964778b02e684f9b0a3787f
> # Parent 473a8954c957945d1642d08eeefc8fe706597b59
> lfs: infer the blob s
On Tue, 10 Apr 2018 23:02:19 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1523415475 14400
> # Tue Apr 10 22:57:55 2018 -0400
> # Node ID 16cd8fe997579a6d4aecfe15b54daee3081610e7
> # Parent 50ea07f04fd451faf27e14d914baf67eb51f15d5
> tests: stabilize test
On Tue, 10 Apr 2018 16:09:23 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1523155211 14400
> # Sat Apr 07 22:40:11 2018 -0400
> # Node ID 473a8954c957945d1642d08eeefc8fe706597b59
> # Parent 49a8c2cc7978cdd73155fc354aae8851a79c58d8
> lfs: add the ability
yuja added a comment.
Queued, thanks. I've dropped unneeded flush(), and added b''.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3218
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mail
On Tue, 10 Apr 2018 16:09:25 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1523165019 14400
> # Sun Apr 08 01:23:39 2018 -0400
> # Node ID b0ae606b4a10738c97d791ac6867cd100eb2ea9d
> # Parent b784de3b414876f25964778b02e684f9b0a3787f
> lfs: infer the blob s
> On Apr 11, 2018, at 7:29 AM, Yuya Nishihara wrote:
>
>> On Tue, 10 Apr 2018 16:09:24 -0400, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison
>> # Date 1523154140 14400
>> # Sat Apr 07 22:22:20 2018 -0400
>> # Node ID b784de3b414876f25964778b02e684f9b0a3787f
>> # Paren
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd17cfb23017c: py3: use '//' for integer division
in tests/test-mq-qimport.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D32
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2d00058ac2f8: py3: use bytes instead of str in isinstance()
(authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3215?vs=7927&id=79
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf5ffcac66c02: py3: make sure we write bytes to file
(authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3220?vs=7932&id=7972
REVI
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1c09481acdcc: context: handle stringified ints in
revsymbol() (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3146?vs=7884
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3740d1abde44: py3: add b'' prefixes in
tests/test-ui-config.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3221?vs=7933&id
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5d81f1b7051b: py3: use sys.stdout instead of print in
test-mq-qpush-fail.t (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D3218?vs=7964&id=7970#toc
REPOSIT
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG45667439439e: context: handle namespaces in revsymbol()
(authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3194?vs=7886&id=79
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG58230f4fcc0b: py3: use pycompat.byterepr() instead of
repr() (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3216?vs=7962&id=7
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfa6cdd6668e1: py3: use .startswith() instead of bytes[0]
(authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3214?vs=7926&id=7966
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6639ac97ec3b: revsymbol: stop delegating to
repo.__getitem__ for unhandled symbols (API) (authored by martinvonz, committed
by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mer
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd2b484eed1ec: scmutil: handle full hex nodeids in
revsymbol() (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3193?vs=7885
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG35b34202dd3b: context: handle partial nodeids in
revsymbol() (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3195?vs=7887&
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa7de62adcf03: py3: workaround comparing NoneType and
integers (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3219?vs=7931&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8475c9bf096d: context: add deprecation warnings for
deprecated types of changeids (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-s
yuja added a comment.
It's just a few-line patch after removal of the current worddiff, and can be
simplified further.
Anyway, I can clean up later.
diff --git a/mercurial/patch.py b/mercurial/patch.py
--- a/mercurial/patch.py
+++ b/mercurial/patch.py
@@ -2490,10 +2490
yuja added a comment.
> That said, I'm fine with changing the defaults to whatever. So feel
> free to send follow-ups changing it.
Can you split a patch changing the color scheme so we can easily
back it out as needed?
INLINE COMMENTS
> quark wrote in patch.py:2536
> For a split lis
On Wed, 11 Apr 2018 07:57:56 -0400, Matt Harbison wrote:
> >> +url = util.url(bytes(defaulturl))
> >
> > Nit: perhaps no need to reparse the url since defaulturl is a url object.
>
> I don’t have the code in front of me, but I think there is an _originalpath
> member that doesn’t get
On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote:
> >> The proposal here is to define a prefix for which we break backward
> >> compatibility. If we do so, people with a "" label will have to use:
> >>
> >> "":whatever
> >>
> >> to get a similar effect.
> > IIRC x:y was the most important s
On Wed, 11 Apr 2018 11:50:15 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1520412972 18000
> # Wed Mar 07 03:56:12 2018 -0500
> # Node ID 00090d394d4e0a7c2637f161493353530dcf739d
> # Parent 5c1a0d784a26d4e8659dcec80503c8764432a303
> # EXP-Topic noname
> # Avai
# HG changeset patch
# User Yuya Nishihara
# Date 1523274281 -32400
# Mon Apr 09 20:44:41 2018 +0900
# Node ID da53a21e2b96040ca2005d627b6c69a91e83f938
# Parent 8475c9bf096d5f67b3a82de73b27a61ef53018f1
py3: get rid of character access from pure.diffhelpers
's' is a result of readline(), so
# HG changeset patch
# User Yuya Nishihara
# Date 1523274463 -32400
# Mon Apr 09 20:47:43 2018 +0900
# Node ID 35a82b6cd55528b0aa0028321c69756d41175b54
# Parent da53a21e2b96040ca2005d627b6c69a91e83f938
diffhelpers: port docstrings from cext to pure
I'll remove the C implementation.
diff --
# HG changeset patch
# User Yuya Nishihara
# Date 1523274840 -32400
# Mon Apr 09 20:54:00 2018 +0900
# Node ID 5985aee99980721a04dda5980dc4c33eb560ff72
# Parent 69d8de4156f5a230b8abc73d87e5aeb46ceb5b06
diffhelpers: move out of pure package
diff --git a/mercurial/pure/diffhelpers.py b/mercur
# HG changeset patch
# User Yuya Nishihara
# Date 1523274683 -32400
# Mon Apr 09 20:51:23 2018 +0900
# Node ID 79d149236bfa8ebfb221573ad33b8f8f715fde7d
# Parent 2d521734ec51a8dbf99c77fd0c2242669c7b5109
diffhelpers: remove C implementation in favor of pure Python version
diff --git a/contrib
# HG changeset patch
# User Yuya Nishihara
# Date 1523274774 -32400
# Mon Apr 09 20:52:54 2018 +0900
# Node ID 69d8de4156f5a230b8abc73d87e5aeb46ceb5b06
# Parent 79d149236bfa8ebfb221573ad33b8f8f715fde7d
diffhelpers: naming and whitespace cleanup
diff --git a/mercurial/patch.py b/mercurial/pa
# HG changeset patch
# User Yuya Nishihara
# Date 1523274905 -32400
# Mon Apr 09 20:55:05 2018 +0900
# Node ID 62ebfa7e5a3388c1761830d788b53dd46d0a9ad4
# Parent 5985aee99980721a04dda5980dc4c33eb560ff72
diffhelpers: remove unused return value from fixnewline() and addlines()
diff --git a/mer
# HG changeset patch
# User Yuya Nishihara
# Date 1523274579 -32400
# Mon Apr 09 20:49:39 2018 +0900
# Node ID 2d521734ec51a8dbf99c77fd0c2242669c7b5109
# Parent 35a82b6cd55528b0aa0028321c69756d41175b54
patch: stop using cext.diffhelpers
The C implementation has a couple of memory bugs, and
# HG changeset patch
# User Yuya Nishihara
# Date 1523275606 -32400
# Mon Apr 09 21:06:46 2018 +0900
# Node ID 6265e0c7a7ab727f253fdc915caa2339fbe65728
# Parent 62ebfa7e5a3388c1761830d788b53dd46d0a9ad4
patch: error out if reached to EOF while reading hunk
This was where out-of-bounds read o
# HG changeset patch
# User Yuya Nishihara
# Date 1523275732 -32400
# Mon Apr 09 21:08:52 2018 +0900
# Node ID c487b1b45eabcbe4cfd38a22a66e2fe6a71176b3
# Parent 6265e0c7a7ab727f253fdc915caa2339fbe65728
diffhelpers: make return value of testhunk() more Pythonic
It's no longer C.
diff --git
# HG changeset patch
# User Yuya Nishihara
# Date 1523032645 -32400
# Sat Apr 07 01:37:25 2018 +0900
# Node ID 209a355d60e0d4996b5587d0e017380d3484670b
# Parent c487b1b45eabcbe4cfd38a22a66e2fe6a71176b3
diffhelpers: be more tolerant for stripped empty lines of CRLF ending
Exchange. It appear
> On Apr 11, 2018, at 7:54 AM, Yuya Nishihara wrote:
>
>> On Tue, 10 Apr 2018 16:09:25 -0400, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison
>> # Date 1523165019 14400
>> # Sun Apr 08 01:23:39 2018 -0400
>> # Node ID b0ae606b4a10738c97d791ac6867cd100eb2ea9d
>> # Paren
durin42 added inline comments.
INLINE COMMENTS
> indygreg wrote in test-wireproto-command-pushkey.t:1
> And at the same time having giant test files makes it difficult to refactor
> an existing test file because tests below change due to differences above.
> You end up doing all kinds of strips
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG465187fec06f: wireproto: only expose "stream_out"
to version 1 transports (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D32
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdf4985497986: wireproto: implement capabilities for wire
protocol v2 (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3200?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG693cb3768943: wireproto: make @wireprotocommand version 1
only by default (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D32
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG69e46c1834ac: wireproto: define and expose types of wire
command arguments (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4a0d58d6faba: wireproto: only expose "getbundle"
and "unbundle" to v1 transports (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3e5e37204b32: wireproto: disallow commands handlers for
multiple transport versions (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-s
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG89fed81bbb6c: wireproto: port lookup to wire protocol v2
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3205?vs=7909&id=798
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbe5d4749edc0: wireproto: port pushkey command to wire
protocol version 2 (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D320
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2003da12f49b: wireproto: only expose
"clonebundles" to version 1 transports (authored by indygreg,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/
durin42 added inline comments.
INLINE COMMENTS
> httppeer.py:507
>
> -url = '%s/api/%s/%s/%s' % (self.url, wireprotoserver.HTTPV2,
> permission,
> - name)
> +url = '%s/api/%s/%s/%s' % (self.url, wireprotov2server.HTTPV2,
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG55b5ba8d4e68: wireproto: client reactor support for
receiving frames (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3224?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1ec5ce21cb46: tests: extract wire protocol framing tests to
own file (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3222?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8e7a4435ab6d: httppeer: extract code for performing an HTTP
request (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3233?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG01361be9e2dc: wireproto: introduce a reactor for
client-side state (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3223?vs=7
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3a2367e6c6f2: wireproto: move version 2 command handlers to
wireprotov2server (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG93397c4633f6: wireproto: extract HTTP version 2 code to own
module (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3230?vs=7
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb5862ee01abe: httppeer: move error handling and response
wrapping into sendrequest (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-sc
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG946eb204ba67: httppeer: extract common response handling
into own function (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG835ccc2a5ef1: httppeer: move requestbuilder defaults into
makepeer() argument (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG301a1d2e8016: httppeer: don't accept very old media
types (BC) (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3239?vs=7957&
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG66d1001e1500: httppeer: extract code for creating a request
into own function (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG930c433eb311: httppeer: always add x-hg* headers to Vary
header (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3240?vs=7958
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6b08cf6b900f: httppeer: allow opener to be passed to
makepeer() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3238?vs=7956
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8b8a845c85fc: httppeer: perform capabilities request in
makepeer() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3237?vs=7
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8a73132214a3: httppeer: support protocol upgrade (authored
by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3243?vs=7961&id=8004
REVIS
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb77aa48ba690: httppeer: only advertise partial-pull if
capabilities are known (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG734515aca84d: wireproto: define and implement HTTP
handshake to upgrade protocol (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.
On Wed, Apr 11, 2018 at 9:03 PM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1523274281 -32400
> # Mon Apr 09 20:44:41 2018 +0900
> # Node ID da53a21e2b96040ca2005d627b6c69a91e83f938
> # Parent 8475c9bf096d5f67b3a82de73b27a61ef53018f1
> py3: get rid of cha
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
queued, congrats on becoming the new mq maintainer
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3244
To: pulkit, #hg-reviewers, durin42
Cc: durin42, mercu
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc4a0626f6b6e: py3: use pycompat.bytestr() where repr in
involved (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3244?vs=7963&
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
Sorry, this fell through the cracks somehow. Queued.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2988
To: hooper, #hg-reviewers, durin42
Cc: durin42, mha
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG41ba336d9f1e: fix: use a portable python script instead of
sed in test (authored by hooper, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2988?vs
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Looks good!
INLINE COMMENTS
> remotenames.py:113
> +else:
> +msg = _("bookmark '%s' does not exists on remote")
> +raise error.Abort(msg % bookmark)
Nit: "exist". T
smf added a comment.
In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote:
> Looks good!
I'm very heavily against this direction. Changing the behavior of push (even
in this extension) is something I've always considered outside the scope of
remotenames. Having another
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I'm not crazy about the implementation. But for an experimental feature, I
think it is fine. The bundle2 changes to do this right are definitely scope
bloat.
INLINE COMMENTS
> exchang
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8478b198af9c: tests: add tests showing pulling from
infinitepush works over wire (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.or
durin42 updated this revision to Diff 8009.
durin42 edited the summary of this revision.
durin42 retitled this revision from "hgweb: str/bytes followups after
indygreg's refactoring" to "hgweb: use our forked wsgiheaders module instead of
stdlib one".
REPOSITORY
rHG Mercurial
CHANGES SINCE LA
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This also gives us some minimal "it loads" coverage on showstack,
which I rather like.
I added this in service of debugging a hang introduced on Python 3 by
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It turns out http.client on Python 3 sometimes uses readinto() in the
implementation of read().
Subclassing is bad, folks.
REPOSITORY
rHG Mercurial
REVISI
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This will let us restore Python 3 compatibility for tests that do http things.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3245
A
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This re-fixes test-pull-http.t on Python 3. Probably many others as well.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3249
AFFECT
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This fixes a lot of hanging tests on Python 3, because
"Content-Length" was getting sent as "b'Content-Length'" (yes, really)
and then clients would expect a clo
durin42 updated this revision to Diff 8014.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3245?vs=8008&id=8014
REVISION DETAIL
https://phab.mercurial-scm.org/D3245
AFFECTED FILES
mercurial/hgweb/wsgiheaders.py
CHANGE DETAILS
diff --git a/mercurial/
durin42 updated this revision to Diff 8015.
durin42 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3246?vs=8010&id=8015
REVISION DETAIL
https://phab.mercurial-scm.org/D3246
AFFECTED FILES
mercurial/keepalive.py
CH
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We're still parsing the stdlib-provided headers here, so we need to
tread carefully and use native strings. Yuck.
REPOSITORY
rHG Mercurial
REVISION DETAIL
ht
indygreg added a comment.
In https://phab.mercurial-scm.org/D2873#52025, @smf wrote:
> In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote:
>
> > Looks good!
>
>
> I'm very heavily against this direction. Changing the behavior of push
(even in this extension) is somet
quark added a comment.
In https://phab.mercurial-scm.org/D3212#51917, @yuja wrote:
> Can you split a patch changing the color scheme so we can easily
> back it out as needed?
Note the color configs are not entirely equivalent to the old code. To give
an example:
-LINE-1
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These localhost instances are actually from a getfqdn call, which
means on some of my test systems it comes out as localhost.localdomain
or
1.0.0.0.0.0.0.0.0.0
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Also increase sleep to two seconds so this test will likely pass on FAT32.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3252
AFFEC
1 - 100 of 135 matches
Mail list logo
