yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> templatekw.py:222
> +# Don't call expensive key function if not necessary
> +pdate, pdist, ptag = ptags[0]
> except KeyErr
yuja added inline comments.
INLINE COMMENTS
> quark wrote in revsetlang.py:492
> Yes! That's much shorter (I had to copy the trees from debugshell) and more
> robust (no fragile `len(x) >= 3` handling).
>
> For performance concerns, I think it's fine. Practically, revset parsing is
> hardly a
3 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/f257943e47ab
changeset: 33800:f257943e47ab
user:Gregory Szorc
date:Sun Aug 13 10:58:48 2017 -0700
summary: repository: formalize peer interface with abstract base class
https://www.mercurial-scm.org/re
martinvonz added inline comments.
INLINE COMMENTS
> yuja wrote in templatekw.py:222
> This should be enabled only if `ptags[0][2] != ptags[1][2]`.
>
> The latesttagdistance is documented to return the longest path to the latest
> tag.
> https://phab.mercurial-scm.org/rHGf04d179124410d491a8def23
martinvonz updated this revision to Diff 1088.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D447?vs=1080&id=1088
REVISION DETAIL
https://phab.mercurial-scm.org/D447
AFFECTED FILES
mercurial/templatekw.py
tests/test-command-template.t
CHANGE DETAIL
yuja added inline comments.
INLINE COMMENTS
> martinvonz wrote in templatekw.py:222
> > This should be enabled only if ptags[0][2] != ptags[1][2].
>
> Good point. Done.
>
> > The latesttagdistance is documented to return the longest path to the
> > latest tag.
>
> I'm not changing latesttagdi
martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in templatekw.py:222
> > This should be enabled only if ptags[0][2] != ptags[1][2].
>
> Good point. Done.
>
> > The latesttagdistance is documented to return the longest path to the
> > latest tag.
>
> I'm not changing lates
5 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/707750e5310b
changeset: 33803:707750e5310b
user:Gregory Szorc
date:Wed Aug 09 23:52:25 2017 -0700
summary: localrepo: use peer interfaces
https://www.mercurial-scm.org/repo/hg/rev/1f8460b55986
changese
martinvonz updated this revision to Diff 1089.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D447?vs=1088&id=1089
REVISION DETAIL
https://phab.mercurial-scm.org/D447
AFFECTED FILES
mercurial/templatekw.py
tests/test-command-template.t
CHANGE DETAIL
martinvonz added inline comments.
INLINE COMMENTS
> yuja wrote in templatekw.py:222
> > I'm not changing latesttagdistance (AFAIK), only the definition of
> > latesttag.
>
> Try `ptags = reversed(...)` and run tests. The largest `pdist` should be
> selected
> so that `latesttagdistance` return
phillco added inline comments.
INLINE COMMENTS
> martinvonz wrote in simplemerge.py:411-423
> def _picklabels(defaults, overrides):
> if len(overrides) > 3:
> raise error.Abort(_("can only specify three labels."))
> result = defaults[:]
> for i, override in enumerate(overr
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Keeping `order` in tree makes AST operation harder. And there could be
certain invalid cases, like:
A(order=define) | B(order=define)
quark added inline comments.
INLINE COMMENTS
> yuja wrote in revsetlang.py:492
> I'll rebase my patches then. I'm sure that isn't trivial because I introduced
> the order flag.
Maybe `order` could be removed from AST since they can be inferred during tree
traversal? I have a draft https://phab
phillco added inline comments.
INLINE COMMENTS
> martinvonz wrote in simplemerge.py:412
> Seems unfortunate to have both files and contexts. This is what you mentioned
> today you will replace by use of "arbitraryfilectx"?
They get taken out in https://phab.mercurial-scm.org/D381; they have to
phillco added inline comments.
INLINE COMMENTS
> martinvonz wrote in simplemerge.py:430
> What is this "post-filter data"? I didn't know hg had this feature. Something
> like git' clean/smudge filters?
Yeah, exactly. I didn't know about it either.
https://www.mercurial-scm.org/wiki/EncodeDecod
phillco added a subscriber: martinvonz.
phillco added inline comments.
INLINE COMMENTS
> simplemerge:44-63
> +class filebackedctx(object):
> +"""simplemerge requires context-like objects"""
> +def __init__(self, path):
> +self._path = path
> +
> +def decodeddata(self):
> +
quark updated this revision to Diff 1091.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1090&id=1091
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
quark added a subscriber: yuja.
quark added a comment.
@yuja Let me know if this can simplify `matchtree`, `buildtree`
implementation.
INLINE COMMENTS
> test-revset.t:2502
>
>$ try -p optimized '(reverse(contains("a")) + 2) & 0:2'
>* optimized:
The new code is less efficient here.
quark updated this revision to Diff 1092.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1091&id=1092
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
quark updated this revision to Diff 1093.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1092&id=1093
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
quark updated this revision to Diff 1094.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1093&id=1094
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
quark updated this revision to Diff 1095.
quark edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1094&id=1095
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/
quark added inline comments.
INLINE COMMENTS
> test-revset.t:2893
> ,
> ->
> +>
>0
This is caused by `fullreposet` having a default order. If we remove that, it
would be optimized to `` here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D451
To
quark updated this revision to Diff 1096.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1095&id=1096
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
quark updated this revision to Diff 1097.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1096&id=1097
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
quark updated this revision to Diff 1098.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1097&id=1098
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in test-bisect.t:190
> What does None mean here?
Oh, _conflictsmsg() is returning None which is getting printed. I will send a
follow-up for this.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D219
pulkit added a comment.
Any updates on this? The function `_fastmergecopies()` is simply a port of
`_domergecopies()` from fbhgext/copytrace.py.
https://phab.mercurial-scm.org/diffusion/FBHGX/browse/default/hgext3rd/copytrace.py;75cfcc6fc62a4f172857beebda6c0e43f318ea87$290
REPOSITORY
rHG M
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
This one looks good to me, thanks. I leave it to Sean since he said he's
queued the previous series.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D447
To: marti
quark added inline comments.
INLINE COMMENTS
> revset.py:58-61
> +# TODO migrate existing functions to accept "order", and maybe wrap
> +# registered functions automatically if they do not accept "order".
> +m = methods[x[0]]
> +return m(repo, subset, *x[1:], order=order)
TODO ca
yuja added a comment.
Clever. I haven't looked this carefully, but the general direction seems fine.
> @yuja Let me know if this can simplify `matchtree`, `buildtree`
implementation.
Actually `matchtree` can ignore extra elements in a node tuple, so the
existence
of `order` flag i
quark updated this revision to Diff 1099.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D451?vs=1098&id=1099
REVISION DETAIL
https://phab.mercurial-scm.org/D451
AFFECTED FILES
mercurial/revset.py
mercurial/revsetlang.py
tests/test-revset.t
CHANGE
32 matches
Mail list logo