D218: phabricator: add --confirm option to phabsend command

2017-08-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This adds a --confirm flag similar to the confirm flag of `hg email` using which one can confirm the changesets before they get emailed. The confirm flag will

D210: pushvars: move fb extension pushvars to core

2017-08-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 514. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D210?vs=512=514 REVISION DETAIL https://phab.mercurial-scm.org/D210 AFFECTED FILES mercurial/bundle2.py mercurial/commands.py mercurial/exchange.py

D218: phabricator: add --confirm option to phabsend command

2017-08-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 515. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D218?vs=513=515 REVISION DETAIL https://phab.mercurial-scm.org/D218 AFFECTED FILES contrib/phabricator.py CHANGE DETAILS diff --git a/contrib/phabricator.py

D210: pushvars: move fb extension pushvars to core

2017-08-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 512. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D210?vs=493=512 REVISION DETAIL https://phab.mercurial-scm.org/D210 AFFECTED FILES mercurial/bundle2.py

D210: pushvars: move fb extension pushvars to core

2017-08-01 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > akushner wrote in commands.py:4012-4016 > This should definitely be opt-in, vs. opt-out. Sorry but I don't understand what you mean here. Do I need to change the documentation part or the change the flag part. Currently I have set the default of

D209: bundle2: load hookargs from bundleoperation into transaction when started one

2017-08-01 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When a transaction is started, we must load the hookargs from the bundleoperation object to the transaction so that they can be used in the transaction. Also

D210: pushvars: move fb extension pushvars to core

2017-08-01 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY pushvars extension in fbext adds a --pushvars flag to push command using which one send environment variables to server which can be used to run hooks. The

D208: bundle2: add the capability to store hookargs on bundle operation object

2017-08-01 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are extensions like pushrebase, pushvars which run hooks on a server before taking the lock. Since the lock is not taken, transaction is not there, so the

D219: morestatus: move fb extension to core as '--repo-state' option to status

2017-08-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY morestatus extension in fbext use to show more context about the state of the repo like the repository is in a unfinished merge state, or a rebase is going on,

D219: morestatus: move fb extension to core as '--repo-state' option to status

2017-08-02 Thread pulkit (Pulkit Goyal)
pulkit added a subscriber: durham. pulkit added a comment. @durham and I thought on the flag name and had '--more' and '--repo-state' in our mind. Since '--repo-state' is more explicit, I went with that. Need suggestions for a better flag name. :) REPOSITORY rHG Mercurial REVISION DETAIL

D219: morestatus: move fb extension to core as '--repo-state' option to status

2017-08-03 Thread pulkit (Pulkit Goyal)
pulkit added a comment. @akushner @martinvonz : thanks for suggestions. I also like the --verbose option, I will send a new version with that. @martinvonz: Since you don't like 'morestatus' much, shall I place the skipstates option which skips some states under some different config name,

D409: copies: add more details to the documentation of mergecopies()

2017-08-15 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG42ad7cc645a4: copies: add more details to the documentation of mergecopies() (authored by pulkit). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D409?vs=942=950

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-15 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 943. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D358?vs=819=943 REVISION DETAIL https://phab.mercurial-scm.org/D358 AFFECTED FILES mercurial/configitems.py

D409: copies: add more details to the documentation of mergecopies()

2017-08-15 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This documentation is very helpful for any developer to understand what copytracing is and what the function does. Since this is the main function of doing

D359: pushvars: add a coreconfigitem for push.pushvars.server

2017-08-15 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG057d31ceace3: pushvars: add a coreconfigitem for push.pushvars.server (authored by pulkit). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D359?vs=820=963

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG96f43981c1c4: morestatus: move fb extension to core by plugging to `hg status --verbose` (authored by pulkit). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D219?vs=577=798#toc REPOSITORY

D354: merge with stable

2017-08-11 Thread pulkit (Pulkit Goyal)
pulkit requested changes to this revision. pulkit added a comment. This revision now requires changes to proceed. I think this is send by mistake. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D354 To: rishabhmadan96, #hg-reviewers, pulkit Cc: pulkit,

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-11 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Again I am not sure whether the flag names are good. Since disablecopytrace was in experimental section, I went with the same for these ones. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D358 To: pulkit, #hg-reviewers Cc:

D359: pushvars: add a coreconfigitem for push.pushvars.server

2017-08-11 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D359 AFFECTED FILES mercurial/bundle2.py mercurial/configitems.py CHANGE DETAILS diff --git

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-11 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY copytrace extension in fb-hgext has a heuristic implementation of copy tracing which is faster than the current copy tracing. The heuristic limits the search of

D355: contrib: add check flag for use of admonitions and its validity

2017-08-12 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Can you add tests for this. Also the commit message starts with "contrib", which seems unrelated here, please correct that. INLINE COMMENTS > releasenotes.py:543 > +if opts.get('check'): > +checkadmonitions(ui, repo, sections.names(), revs) > + You can

D218: phabricator: add --confirm option to phabsend command

2017-08-04 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG40cfe3197bc1: phabricator: add --confirm option to phabsend command (authored by pulkit). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D218?vs=515=562 REVISION

D210: pushvars: move fb extension pushvars to core

2017-08-04 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdb3dc11356ed: pushvars: move fb extension pushvars to core (authored by pulkit). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D210?vs=514=567 REVISION DETAIL

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 577. pulkit edited the summary of this revision. pulkit retitled this revision from "morestatus: move fb extension to core as '--repo-state' option to status" to "morestatus: move fb extension to core by plugging to `hg status --verbose`". REPOSITORY rHG

D208: bundle2: add the capability to store hookargs on bundle operation object

2017-08-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3407d56a6e8: bundle2: add the capability to store hookargs on bundle operation object (authored by pulkit). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D209: bundle2: load hookargs from bundleoperation into transaction when started one

2017-08-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5fc4ddfbe626: bundle2: load hookargs from bundleoperation into transaction when started one (authored by pulkit). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D210: pushvars: move fb extension pushvars to core

2017-08-02 Thread pulkit (Pulkit Goyal)
pulkit added a comment. >> Notice that the HG_USERVAR is prepended to the "BYPASS_LARGE_FILE_CHECK" var? The user can't override normal shell variables with this. > > Sure, but environment variables are still global state, so its got nonzero concurrency concerns. I'm also

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-09 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D219#4343, @durin42 wrote: > I'm still a tiny bit worried about potential confusion between --terse and --verbose (in that they're not opposites), but I'm also fine with this. I'll take it in a couple of days if I don't hear any

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-19 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in test-bisect.t:190 > What does None mean here? Oh, _conflictsmsg() is returning None which is getting printed. I will send a follow-up for this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D219

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-19 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Any updates on this? The function `_fastmergecopies()` is simply a port of `_domergecopies()` from fbhgext/copytrace.py. https://phab.mercurial-scm.org/diffusion/FBHGX/browse/default/hgext3rd/copytrace.py;75cfcc6fc62a4f172857beebda6c0e43f318ea87$290 REPOSITORY rHG

D529: uncommit: move fb-extension to core which uncommits a changeset

2017-09-15 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd01819c8f3c4: uncommit: move fb-extension to core which uncommits a changeset (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D623: copytrace: move fast heuristic copytracing algorithm to core

2017-09-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa8d139c37353: copytrace: move fast heuristic copytracing algorithm to core (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D623?vs=1791=1815#toc REPOSITORY

D623: copytrace: move fast heuristic copytracing algorithm to core

2017-09-13 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 1791. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D623?vs=1688=1791 REVISION DETAIL https://phab.mercurial-scm.org/D623 AFFECTED FILES mercurial/copies.py tests/test-copytrace-heuristics.t CHANGE DETAILS

D625: copytrace: use the full copytracing method if only drafts are involved

2017-09-13 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 1792. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D625?vs=1689=1792 REVISION DETAIL https://phab.mercurial-scm.org/D625 AFFECTED FILES mercurial/copies.py tests/test-copytrace-heuristics.t CHANGE DETAILS

D726: uncommit: rename the flag 'empty' to 'keep' which retains empty changeset

2017-09-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch renames the flag 'empty' which retains the empty changeset if all the files are uncommitted to 'keep'. REPOSITORY rHG Mercurial REVISION DETAIL

D728: rebase: move working parent movement logic to scmutil.cleanupnodes

2017-09-18 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D728#12194, @quark wrote: > In https://phab.mercurial-scm.org/D728#12181, @pulkit wrote: > > > How about having a new upper level function which handles all these things and also call `scmutil.cleanupnodes`? Maybe we can add

D737: directaccess: add support for accessing hidden commits if command is read only

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds support for accessing hidden commits by read only commands. It introduces a new config experimental.directaccess which can be set to true to

D736: directaccess: add support for storing the type of command in func object

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds support for storing the type of command which is going to run in the func object. For this it does the following: 1. Add three possible

D738: directaccess: add support to export and tests to demonstrate things

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds the cmdtype attribute to export command which is a read only command and adds test for accessing hidden commits using the same command. REPOSITORY

D614: registrar: make cmdtype an attribute of the function in registar.command

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Send as https://phab.mercurial-scm.org/D736, https://phab.mercurial-scm.org/D737 and https://phab.mercurial-scm.org/D738. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D614 To: pulkit, #hg-reviewers,

D696: registrar: add a enum 'cmdtype' for the type of the command

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Send the series as https://phab.mercurial-scm.org/D736, https://phab.mercurial-scm.org/D737 and https://phab.mercurial-scm.org/D738. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D696 To: pulkit,

D740: tersestatus: sort the dictionary before iterating on it

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There has report of flakiness in test-status-terse.t. In the terse code, we are iterating on a dictionary without sorting and since python dicts are unordered,

D612: command: add a cmdtype argument to registrar.command

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Resend the series as https://phab.mercurial-scm.org/D736, https://phab.mercurial-scm.org/D737 and https://phab.mercurial-scm.org/D738. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D612 To: pulkit, #hg-reviewers, durham Cc: quark,

D734: uncommit: don't allow bare uncommit on dirty working directory

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As per IRC discussion and suggestion by Augie, we should not allow bare `hg uncommit` on dirty working directory. REPOSITORY rHG Mercurial REVISION DETAIL

D735: uncommit: add an experimental.uncommitondirtywdir config

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are people who wants to do `hg uncommit` on dirty working directory, so this patch adds a config which can be used to the achieve that. Adds tests for

D763: copytrace: add a a new config to limit the number of drafts in heuristics

2017-09-21 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The heuristics options tries to the default full copytracing algorithm if both the source and destination branches contains of non-public changesets only. But

D761: test: backout update evolution config

2017-09-21 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. The evolution config name makes sense. stabilization was ambiguous. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D761 To: lothiraldan, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

D740: tersestatus: sort the dictionary before iterating on it

2017-09-20 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1d6558f5ea74: tersestatus: sort the dictionary before iterating on it (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D726: uncommit: rename the flag 'empty' to 'keep' which retains empty changeset

2017-09-20 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf94442d46984: uncommit: rename the flag empty to keep which retains empty changeset (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D734: uncommit: don't allow bare uncommit on dirty working directory

2017-09-20 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG624c53e4121d: uncommit: dont allow bare uncommit on dirty working directory (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D760: cmdutil: move the logic from copy() to a new function copies.copy()

2017-09-21 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 1959. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D760?vs=1956=1959 REVISION DETAIL https://phab.mercurial-scm.org/D760 AFFECTED FILES mercurial/cmdutil.py mercurial/copies.py CHANGE DETAILS diff --git

D763: copytrace: add a a new config to limit the number of drafts in heuristics

2017-09-21 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 1967. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D763?vs=1961=1967 REVISION DETAIL https://phab.mercurial-scm.org/D763 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copies.py

D529: uncommit: move fb-extension to core which uncommits a changeset

2017-09-14 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 1823. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D529?vs=1729=1823 REVISION DETAIL https://phab.mercurial-scm.org/D529 AFFECTED FILES hgext/uncommit.py tests/test-uncommit.t CHANGE DETAILS diff --git

D728: rebase: move working parent movement logic to scmutil.cleanupnodes

2017-09-18 Thread pulkit (Pulkit Goyal)
pulkit added a comment. How about having a new upper level function which handles all these things and also call `scmutil.cleanupnodes`? Maybe we can add phases logic in that function also afterwards. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D728 To:

D625: copytrace: use the full copytracing method if only drafts are involved

2017-09-20 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfc3b8483c6cb: copytrace: use the full copytracing method if only drafts are involved (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D735: uncommit: add an experimental.uncommitondirtywdir config

2017-09-20 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7b1e524ad73f: uncommit: add an experimental.uncommitondirtywdir config (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D760: cmdutil: move the logic from copy() to a new function copies.copy()

2017-09-21 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY cmdutil.py is still 3647 lines after this change. This patch moves the logic to copy a file from cmdutil.py to copies.py. Now, cmdutil.py just calls copies.py

D933: scmutil: add a new function to show changes after a command

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2458. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D933?vs=2427=2458 REVISION DETAIL https://phab.mercurial-scm.org/D933 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D937#15824, @dlax wrote: > Also, it'd be useful to indicate where the code comes from (i.e. what is the "remoterepo" mentioned in the first line of the commit message). Yeah sure I will add that in next version. >

D934: rebase: add an experimental.showhashchanges config to show hash changes

2017-10-06 Thread pulkit (Pulkit Goyal)
pulkit planned changes to this revision. pulkit added a comment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D934 To: pulkit, #hg-reviewers Cc: quark, dlax, durin42, mercurial-devel ___ Mercurial-devel mailing list

D985: tersestatus: re-implement the functionality to terse the status

2017-10-06 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous terse status implementation was hacking around os.listdir() and was flaky. There have been a lot of instances of buildbots failing because of the

D987: copies: add a config to limit the number of candidates to check in heuristics

2017-10-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The heuristics algorithm find possible candidates for move/copy and then check whether they are actually a copy or move. In some cases, there can be lot of

D986: copies: add docs for config `experimental.copytrace.sourcecommitlimit`

2017-10-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds documentation for the config option. The config name does not convey much and hence documentation was required. REPOSITORY rHG Mercurial

D985: tersestatus: re-implement the functionality to terse the status

2017-10-07 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2520. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D985?vs=2515=2520 REVISION DETAIL https://phab.mercurial-scm.org/D985 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py CHANGE DETAILS diff --git

D985: tersestatus: re-implement the functionality to terse the status

2017-10-07 Thread pulkit (Pulkit Goyal)
pulkit marked 4 inline comments as done. pulkit added inline comments. INLINE COMMENTS > dlax wrote in cmdutil.py:540 > if s not in stdic: > raise ... Done thanks! > dlax wrote in cmdutil.py:549 > No need for the intermediate `statusdic`, just iterate as `for name in > ('modified',

D933: scmutil: add a new function to show changes after a command

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2418. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D933?vs=2414=2418 REVISION DETAIL https://phab.mercurial-scm.org/D933 AFFECTED FILES mercurial/scmutil.py CHANGE

D934: rebase: add an experimental.showhashchanges config to show hash changes

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2419. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D934?vs=2415=2419 REVISION DETAIL https://phab.mercurial-scm.org/D934 AFFECTED FILES hgext/rebase.py mercurial/configitems.py tests/test-rebase-base.t

D933: scmutil: add a new function to show changes after a command

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit planned changes to this revision. pulkit added a comment. In https://phab.mercurial-scm.org/D933#15594, @dlax wrote: > > diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py > > > > - a/mercurial/scmutil.py +++ b/mercurial/scmutil.py @@ -685,6 +685,18 @@ if tostrip:

D933: scmutil: add a new function to show changes after a command

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds a new function named showchanges() which will output the changes like hashchanges, wdir change, movement of bookmarks etc. after a command. This

D934: rebase: add an experimental.showhashchanges config to show hash changes

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds an experimental config, which if turned on will show hash changes after a rebase. Support will be added to more commands which changes hash.

D932: filemerge: introduce functions to halt merge flow

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > config.txt:1248 > + or halt the merge process. Setting this to ``halt`` will automatically > + half the merge process on any merge tool failure. The merge process > + can be restarted by using the ``resolve`` command. When a merge is typo,

D933: scmutil: add a new function to show changes after a command

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit added subscribers: yuja, quark. pulkit added a comment. @quark I was unable to make 'hashchanges' resolved by templater. I took help from Yuya and he was bit confused on how you want it to be done. (adding @yuja) REPOSITORY rHG Mercurial REVISION DETAIL

D933: scmutil: add a new function to show changes after a command

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2420. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D933?vs=2418=2420 REVISION DETAIL https://phab.mercurial-scm.org/D933 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D986: copies: add docs for config `experimental.copytrace.sourcecommitlimit`

2017-10-09 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe79b3611223b: copies: add docs for config `experimental.copytrace.sourcecommitlimit` (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D991: tests: optimize test-copytrace-heuristics.t

2017-10-10 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1b261be2033b: tests: optimize test-copytrace-heuristics.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D991?vs=2538=2571

D760: cmdutil: move the logic from copy() to a new function copies.copy()

2017-10-10 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Was deferred by Yuya. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D760 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel mailing

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D937#17855, @durin42 wrote: > Could we try and get this series ready to land before the freeze on Wednesday? or should we be aiming to get this early in the 4.5 cycle? Yes, I will be trying to get this series ready to land

D1074: branch: add a --rev flag to change branch name of given revisions

2017-10-15 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2789. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1074?vs=2736=2789 REVISION DETAIL https://phab.mercurial-scm.org/D1074 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-branch-change.t

D1095: amend: add a flag `-n/--note` to store note with amend

2017-10-15 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch utilises the functionality added in previous patches and adds a flag to amend command in hgext/amend to add a note to the amend. Since the note is

D1094: cmdutil: pass metadata from amend() to cleanupnodes

2017-10-15 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `commit --amend` and amend command in core and extensions rely on cmdutil.amend() for amending a commit. So the logic to add a note to amend must reside here.

D1093: scmutil: add capability to cleanupnodes to take obsmarker metadata

2017-10-15 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds a metadata argument to cleanupnodes() which will be dict and can be passed to obsmarker.createmarkers() and can be stored on the obsmarker. In

D1098: releasenotes: add pager support when printing to the ui

2017-10-15 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1098 AFFECTED FILES hgext/releasenotes.py CHANGE DETAILS diff --git a/hgext/releasenotes.py

D1097: releasenotes: don't abort is there is a bad formatted entry for releasenotes

2017-10-15 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While producing releasenotes for (4.3::), releasenotes aborts with error because of some bad formatting of releasenotes in some commits. Instead of aborting,

D1096: releasenotes: make the import of fuzzywuzzy optional

2017-10-15 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If fuzzywuzzy is note present, we will not be having the capability to merge existing releasenotes with the new releasenotes on the similarity basis. The merging

D1098: releasenotes: add pager support when printing to the ui

2017-10-16 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG25b5787e8dde: releasenotes: add pager support when printing to the ui (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1074: branch: add a --rev flag to change branch name of given revisions

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2807. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1074?vs=2789=2807 REVISION DETAIL https://phab.mercurial-scm.org/D1074 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-branch-change.t

D971: uncommit: unify functions _uncommitdirstate and _unamenddirstate to one

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The _unamenddirstate() function was inspired by _uncommitdirstate() function as the logic was same but we were unable to use the latter function directly. So

D965: templatefilters: be sure we always feed cgi.escape a str

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. Checked docs and made sure `cgi.escape` on Python 3 accepts str only. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D965 To: durin42, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

D934: rebase: add an experimental.showhashchanges config to show hash changes

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D934#15939, @durin42 wrote: > I see what it does, but why? What's the motivation for the feature? It's for automation and helping editors such as Nuclide. REPOSITORY rHG Mercurial REVISION DETAIL

D973: py3: use '%d' for integers instead of '%s'

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D973 AFFECTED FILES mercurial/filemerge.py mercurial/mdiff.py CHANGE DETAILS diff --git

D974: py3: handle keyword arguments correctly in hgext/patchbomb.py

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The keys of keyword arguments must be str on Python 3 which is unicode. This patch make sure we pass keyword arguments with keys are str everywhere in this file

D972: py3: fix keyword arguments handling in mq

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch fixes the handling of keyword arguments to functions on Python 3. On python3, the keys of keyword arguments need to str which is unicode. So any

D821: unamend: move fb extension unamend to core

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2493. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D821?vs=2128=2493 REVISION DETAIL https://phab.mercurial-scm.org/D821 AFFECTED FILES hgext/uncommit.py tests/test-unamend.t CHANGE DETAILS diff --git

D1095: amend: add a flag `-n/--note` to store note with amend

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D1095#18566, @yuja wrote: > > We don't have a UI to display obsmarker in core, so for now extensions has to do this. > > I know. It would be nice if reviewers can know how the planned UI will be > to determine whether only

D1096: releasenotes: make the import of fuzzywuzzy optional

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > yuja wrote in releasenotes.py:224 > Perhaps it should return True. > > Any maybe it should show warning, status or debug message? Also, whatever message we will use here, warning, status or debug, it will be repeated a lot of times as the

D1096: releasenotes: make the import of fuzzywuzzy optional

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2830. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1096?vs=2786=2830 REVISION DETAIL https://phab.mercurial-scm.org/D1096 AFFECTED FILES hgext/releasenotes.py CHANGE DETAILS diff --git a/hgext/releasenotes.py

D1119: releasenotes: fix documentation of similaritycheck()

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The function document says that it returns true when the fragment can be merged, but if you see the function just above it which is similar(), it writes already

D1097: releasenotes: don't abort is there is a bad formatted entry for releasenotes

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2833. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1097?vs=2787=2833 REVISION DETAIL https://phab.mercurial-scm.org/D1097 AFFECTED FILES hgext/releasenotes.py CHANGE

D1120: releasenotes: move import of fuzzywuzzy to import level

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help us in determining easily that whether fuzzywuzzy is loaded or not loaded in any of the function. REPOSITORY rHG Mercurial REVISION DETAIL

D1121: releasenotes: show a warning if fuzzywuzzy is not present

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1121 AFFECTED FILES hgext/releasenotes.py CHANGE DETAILS diff --git a/hgext/releasenotes.py

  1   2   3   4   5   6   7   8   9   10   >