[Mesa-dev] [Bug 99481] glsl_parser_extras.cpp:1253:18: error: expected ')' before 'PRId64'

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99481 Bug ID: 99481 Summary: glsl_parser_extras.cpp:1253:18: error: expected ')' before 'PRId64' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux

[Mesa-dev] [PATCH] i965: Support the force_glsl_version driconf option.

2017-01-20 Thread Kenneth Graunke
Gallium drivers have had this for a while. It makes sense to support it consistently across drivers, so expose it in i965 as well. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c | 3 +++ src/mesa/drivers/dri/i965/intel_screen.c | 1 + 2 files

[Mesa-dev] [Bug 93089] mesa fails to check for gcc atomic primitives before using them

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93089 --- Comment #11 from Jonathan Gray --- Previously 64 bit atomics were contained to i965. The on disk shader cache introduced in Mesa 13.0 in 87ab26b2ab35a29d446ae66f1795d40c184c0739 now requires 64 bit atomics as well which

[Mesa-dev] [PATCH 2/4] llvmpipe: enable the front buffer blit fix

2017-01-20 Thread Karl Lessard
The "drawbuffer-modes -auto" piglit test was also failing on llvmpipe approx. 1/5 times, and the glarea sample app had the same issue as the softpipe. The PIPE_BIND_DISPLAY_SYNC fix seems to apply well on both drivers. Signed-off-by: Karl Lessard ---

[Mesa-dev] [PATCH 4/4] gallium/swrast: avoid syncing with drawable on unmap

2017-01-20 Thread Karl Lessard
I think that we do not have to force a display/drawable refresh right after unmapping the front buffer, this could be handled later on when the pipe is being flushed or buffers are swapped (for optimisation). Signed-off-by: Karl Lessard ---

[Mesa-dev] [PATCH 3/4] gallium/swrast: rename "resource_create_front" method

2017-01-20 Thread Karl Lessard
Rename pipe_screen "resource_create_front" method to "resource_create2" since it is not only invoked for front buffer creation (I'm not a big fan of the '2' suffix but nothing else came up to my mind...) Signed-off-by: Karl Lessard ---

[Mesa-dev] [PATCH 2/4] llvmpipe: enable the front buffer blit fix

2017-01-20 Thread Karl Lessard
The "drawbuffer-modes -auto" piglit test was also failing on llvmpipe approx. 1/5 times, and the glarea sample app had the same issue as the softpipe. The PIPE_BIND_DISPLAY_SYNC fix seems to apply well on both drivers. Signed-off-by: Karl Lessard ---

[Mesa-dev] [PATCH 3/4] gallium/swrast: rename "resource_create_front" method

2017-01-20 Thread Karl Lessard
Rename pipe_screen "resource_create_front" method to "resource_create2" since it is not only invoked for front buffer creation (I'm not a big fan of the '2' suffix but nothing else came up to my mind...) Signed-off-by: Karl Lessard --- src/gallium/drivers/llvmpipe/lp_texture.c |

[Mesa-dev] [PATCH 4/4] gallium/swrast: avoid syncing with drawable on unmap (optimisation)

2017-01-20 Thread Karl Lessard
I think that we do not have to force a display/drawable refresh right after unmapping the front buffer, this could be handled later on when the pipe is being flushed or buffers are swapped. Signed-off-by: Karl Lessard --- src/gallium/winsys/sw/dri/dri_sw_winsys.c | 13

[Mesa-dev] [PATCH 1/4] gallium/swrast: fix software blitting with front buffers

2017-01-20 Thread Karl Lessard
This patch is mainly a workaround of commit 2b676570960277d47477822ffeccc672613f914 and fixes many problems with framebuffer blitting in software drivers when the front buffer is involved. It resolves regression issues listed above but also problems with gtk-gl applications (like

[Mesa-dev] [PATCH 4/4] gallium/swrast: avoid syncing with drawable on unmap (optimisation)

2017-01-20 Thread Karl Lessard
I think that we do not have to force a display/drawable refresh right after unmapping the front buffer, this could be handled later on when the pipe is being flushed or buffers are swapped. Signed-off-by: Karl Lessard --- src/gallium/winsys/sw/dri/dri_sw_winsys.c | 13

[Mesa-dev] [PATCH 2/4] llvmpipe: enable the front buffer blit fix

2017-01-20 Thread Karl Lessard
The "drawbuffer-modes -auto" piglit test was also failing on llvmpipe approx. 1/5 times, and the glarea sample app had the same issue as the softpipe. The PIPE_BIND_DISPLAY_SYNC fix seems to apply well on both drivers. Signed-off-by: Karl Lessard ---

[Mesa-dev] [PATCH 3/4] gallium/swrast: rename "resource_create_front" method

2017-01-20 Thread Karl Lessard
Rename pipe_screen "resource_create_front" method to "resource_create2" since it is not only invoked for front buffer creation (I'm not a big fan of the '2' suffix but nothing else came up to my mind...) Signed-off-by: Karl Lessard --- src/gallium/drivers/llvmpipe/lp_texture.c |

[Mesa-dev] [PATCH 1/4] gallium/swrast: fix software blitting with front buffers

2017-01-20 Thread Karl Lessard
This patch is mainly a workaround of commit 2b676570960277d47477822ffeccc672613f914 and fixes many problems with framebuffer blitting in software drivers when the front buffer is involved. It resolves regression issues listed above but also problems with gtk-gl applications (like

[Mesa-dev] [AppVeyor] mesa master #3219 completed

2017-01-20 Thread AppVeyor
Build mesa 3219 completed Commit bb5db5564f by Kenneth Graunke on 1/21/2017 3:14 AM: glsl: Rename [u]int64_t tokens.\n\nbasetsd.h on Windows defines INT64 and UINT64 typedefs which conflict\nwith these. Append "_TOK" to avoid conflicts.\n\nShould fix the

Re: [Mesa-dev] [PATCH] glsl: Rename [u]int64_t tokens.

2017-01-20 Thread Matt Turner
Elsewhere we use _TOK. Not sure if you want to move to _TOKEN everywhere. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Rename [u]int64_t tokens.

2017-01-20 Thread Kenneth Graunke
basetsd.h on Windows defines INT64 and UINT64 typedefs which conflict with these. Append "_TOKEN" to avoid conflicts. Should fix the Windows build. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glsl_lexer.ll | 4 ++-- src/compiler/glsl/glsl_parser.yy | 6 +++---

Re: [Mesa-dev] [PATCH 1/2] i965: Select DF type for 64-bit integers on Gen < 8.

2017-01-20 Thread Kenneth Graunke
On Friday, January 20, 2017 7:07:31 PM PST Matt Turner wrote: > Gen8 adds Q/UQ types. We attempted to change the types back to DF in the > generator (commit c95380c40), but an assertion added in the FP64 series > (commit e481dcc3) triggers before that code has a chance to execute. > > In fact,

[Mesa-dev] [PATCH 1/2] i965: Select DF type for 64-bit integers on Gen < 8.

2017-01-20 Thread Matt Turner
Gen8 adds Q/UQ types. We attempted to change the types back to DF in the generator (commit c95380c40), but an assertion added in the FP64 series (commit e481dcc3) triggers before that code has a chance to execute. In fact, using Q/UQ in the IR and then changing to DF in the generator would not

[Mesa-dev] [PATCH 2/2] Revert "i965: Really don't emit Q or UQ moves on Gen < 8"

2017-01-20 Thread Matt Turner
This reverts commit c95380c4044237d73fb537511667c3c8f658fcee. --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index 4b557d9..de6a1d9 100644 ---

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #6 from Pierre-Loup A. Griffais --- [re-posting with proper account] The developers are already aware of the problem; it'll probably get addressed in the next major update for DOOM. -- You are

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #5 from Pierre-Loup A. Griffais --- The developers are already aware of the problem; it'll probably get addressed in the next major update for DOOM. -- You are receiving this mail because: You are the QA

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #4 from Grazvydas Ignotas --- Good luck getting in touch with any of the devs of an AAA game company. And I can't imagine why they'd want to fix it and have to redo the whole QA just for some obscure platform the

Re: [Mesa-dev] [PATCH] [rfc] spirv: work around doom shaders having load/store to sampler types

2017-01-20 Thread Jason Ekstrand
On Fri, Jan 20, 2017 at 4:46 PM, Ian Romanick wrote: > On 12/23/2016 06:46 AM, Jason Ekstrand wrote: > > Bah... It's definitely illegal. I had fix glslang myself. I have some > > NIR reworks planned that would make this work "properly" but it's a bit > > more complicated

Re: [Mesa-dev] [PATCH] [rfc] spirv: work around doom shaders having load/store to sampler types

2017-01-20 Thread Ian Romanick
On 12/23/2016 06:46 AM, Jason Ekstrand wrote: > Bah... It's definitely illegal. I had fix glslang myself. I have some > NIR reworks planned that would make this work "properly" but it's a bit > more complicated than this hack. That said, I'm very reluctant to fix > app bugs in our driver.

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #3 from Edward O'Callaghan --- (In reply to Grazvydas Ignotas from comment #2) > Supposedly it's because the game is doing something illegal: >

Re: [Mesa-dev] [PATCH 12/27] i965/gen6: Calculate stencil offset on demand

2017-01-20 Thread Jason Ekstrand
On Mon, Jan 16, 2017 at 1:13 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > This is kept on purpose in i965. It can be moved to ISL if it > is needed in vulkan. > > Pointers to miptrees are given solely for verification purposes. > These will be dropped in following patches. > >

Re: [Mesa-dev] [PATCH 21/27] intel/isl/gen7: Add CCS alignment restrictions

2017-01-20 Thread Jason Ekstrand
On Mon, Jan 16, 2017 at 1:13 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Gen8 and Gen9 are already more heavily constrained as one > applies arrayed/mipmapped alignment even for non-arrayed and > non-mipmapped. > > Signed-off-by: Topi Pohjolainen > ---

Re: [Mesa-dev] [PATCH 22/27] intel/isl: Apply render target alignment constraints for MCS

2017-01-20 Thread Jason Ekstrand
For HiZ, we did this directly in isl_choose_image_alignment_el in isl.c. Maybe it's better to do it there given that they're all 4x4. On Mon, Jan 16, 2017 at 1:13 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Otherwise i965 driver will start experiencing failures with > "texelFetch

[Mesa-dev] [AppVeyor] mesa master #3217 failed

2017-01-20 Thread AppVeyor
Build mesa 3217 failed Commit db6d23cfd2 by Ian Romanick on 9/1/2016 7:06 PM: i965: Enable ARB_gpu_shader_int64 on Gen8+\n\nSigned-off-by: Ian Romanick \nReviewed-by: Matt Turner Configure your

Re: [Mesa-dev] [PATCH v2 3/5] st/nine: set the MUL_ZERO_WINS flag when supported

2017-01-20 Thread Ilia Mirkin
Thanks! In practice, on nv50, it checks the vertex shader for the flag, and on nvc0 it's per-stage (since they killed the global override on kepler+). On Fri, Jan 20, 2017 at 5:48 PM, Axel Davy wrote: > With this patch, there is one case where we hit the "undefined case" of

[Mesa-dev] [Bug 99477] [Master of Orion] Shader compile error: no matching function for call to `texture2DLod(sampler2D, vec2, float)';

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99477 Andreas Schultes changed: What|Removed |Added Status|NEW

Re: [Mesa-dev] [PATCH v2 3/5] st/nine: set the MUL_ZERO_WINS flag when supported

2017-01-20 Thread Axel Davy
With this patch, there is one case where we hit the "undefined case" of the spec (mismatch between different shaders): With streamout we use a dummy pixel created by utils instead of nine_shader. As we use software renderers for the feature doing the streamout, I guess that's ok for now.

[Mesa-dev] [Bug 99477] [Master of Orion] Shader compile error: no matching function for call to `texture2DLod(sampler2D, vec2, float)';

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99477 --- Comment #3 from Kenneth Graunke --- Sorry, nevermind that - it exists in 1.30, it's just deprecated. Should work though. -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 99477] [Master of Orion] Shader compile error: no matching function for call to `texture2DLod(sampler2D, vec2, float)';

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99477 --- Comment #2 from Kenneth Graunke --- GLSL 1.30 does not include texture2DLod(). The function is called textureLod() in #version 130. -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [PATCH 3/3] i965: Use correct VertStride on align16 instructions.

2017-01-20 Thread Francisco Jerez
Matt Turner writes: > In commit c35fa7a, we changed the "width" of DF source registers to 2, > which is conceptually fine. Unfortunately a VertStride of 2 is not > allowed by align16 instructions on IVB/BYT, and the regular VertStride > of 4 works fine in any case. > I'll

[Mesa-dev] [PATCH] glsl: there is no need to check for < 0

2017-01-20 Thread Christian Gmeiner
size_t is defined in the C Standard section 4.1.5 as an 'unsigned integral type'. Fixes the following clang compile warning: glsl/blob.c:110:15: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (offset < 0 || blob->size - offset < to_write)

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 m...@pepelino.de changed: What|Removed |Added CC||m...@pepelino.de -- You are

Re: [Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

2017-01-20 Thread Christian Gmeiner
Hi Rhys, 2017-01-19 7:02 GMT+01:00 Rhys Kidd : > Use of unsigned loop control variable with '>= 0' would lead to infinite loop. > > Reported by clang: > > etnaviv_compiler.c:1024:39: warning: comparison of unsigned expression >= 0 is > always true

Re: [Mesa-dev] [PATCH 0/7] i965: Implement EGL_ANDROID_native_fence_sync

2017-01-20 Thread Rafael Antognolli
I have tested this series with the branches that you mentioned, and with piglit with the patches from my own branch: https://github.com/rantogno/piglit/tree/review/fences-v02 Everything seems to work fine. You can add: Tested-by: Rafael Antognolli I also have gone

[Mesa-dev] [Bug 99477] [Master of Orion] Shader compile error: no matching function for call to `texture2DLod(sampler2D, vec2, float)';

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99477 --- Comment #1 from Ilia Mirkin --- Are you sure that the GLSL version is 1.30? i.e. do those shaders have a #version 130 at the top? If not, they get GLSL version 1.10, which does not have those functions. You can force

Re: [Mesa-dev] [PATCH 1/2] spirv: don't assert with location decorations on non i/o variables

2017-01-20 Thread Lionel Landwerlin
On 20/01/17 20:40, Dave Airlie wrote: On 21 January 2017 at 03:08, Jason Ekstrand wrote: On Fri, Jan 20, 2017 at 8:45 AM, Lionel Landwerlin wrote: Some applications might add location decoration to samplers. Rather than raising an error it

[Mesa-dev] [AppVeyor] mesa master #3216 completed

2017-01-20 Thread AppVeyor
Build mesa 3216 completed Commit 74c23bde5b by Lionel Landwerlin on 1/19/2017 4:20 PM: anv: don't require render target isl bit for depth/stencil surfaces\n\nBlorp can deal with depth/stencil surfaces blits/copies without the\nrender target requirement. Also

Re: [Mesa-dev] [PATCH v2 09/20] i965/fs: indirect addressing with doubles is not supported in IVB/BYT

2017-01-20 Thread Matt Turner
On Tue, Jan 17, 2017 at 1:49 AM, Samuel Iglesias Gonsálvez wrote: > It is tested empirically that IVB/BYT don't support indirect addressing > with doubles but it is not documented in the PRM. > > This patch applies the same solution than for Cherryview/Broxton and > takes

[Mesa-dev] [Bug 99477] [Master of Orion] Shader compile error: no matching function for call to `texture2DLod(sampler2D, vec2, float)';

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99477 Bug ID: 99477 Summary: [Master of Orion] Shader compile error: no matching function for call to `texture2DLod(sampler2D, vec2, float)'; Product: Mesa Version:

[Mesa-dev] [PATCH 2/3] i965/vec4: Fix exec size for MOVs SET_{HIGH, LOW}_32BIT.

2017-01-20 Thread Matt Turner
Otherwise for a pack_double_2x32_split opcode, we emit: vec1 64 ssa_135 = pack_double_2x32_split ssa_133, ssa_134 mov(8) g5<1>UD g5<4>.xUD { align16 1Q compacted }; mov(8) g7<2>UD g5<4,4,1>UD { align1 1Q };

[Mesa-dev] [PATCH 1/3] i965: Handle IVB DF differences in the validator.

2017-01-20 Thread Matt Turner
On IVB/BYT, region parameters and execution size for DF are in terms of 32-bit elements, so they are doubled. For evaluating the validity of an instruction, we halve them. --- src/mesa/drivers/dri/i965/brw_eu_validate.c | 12 1 file changed, 12 insertions(+) diff --git

[Mesa-dev] [PATCH 0/3] i965: IVB/BYT fp64 fixes

2017-01-20 Thread Matt Turner
I committed my EU validator earlier today. It's caught three bugs in the IVB fp64 series. Patches 2 and 3 fix two of them. I'll respond directly to the patch in Igalia's series that introduces the other bug. These should go in with Igalia's series, before the extension is turned on.

[Mesa-dev] [PATCH 3/3] i965: Use correct VertStride on align16 instructions.

2017-01-20 Thread Matt Turner
In commit c35fa7a, we changed the "width" of DF source registers to 2, which is conceptually fine. Unfortunately a VertStride of 2 is not allowed by align16 instructions on IVB/BYT, and the regular VertStride of 4 works fine in any case. See

[Mesa-dev] [PATCH] intel/blorp/copy: Properly handle clear colors for CCS_E images

2017-01-20 Thread Jason Ekstrand
In order to handle CCS_E, we stomp the image format to a UINT format and then do some bitcasting logic in the shader. This works fine since SKL render compression only considers the channel layout of the format and not the format itself. In order for this to work on images that have been

[Mesa-dev] [Bug 99413] Rust game have wrong colors

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99413 --- Comment #2 from Gustaw Smolarczyk --- IIRC Rust has undefined behavior in its shader(s) or something like that. >From what I remember, running Rust without steam overlay (I think just running it from command line

Re: [Mesa-dev] [PATCH 1/2] spirv: don't assert with location decorations on non i/o variables

2017-01-20 Thread Dave Airlie
On 21 January 2017 at 03:08, Jason Ekstrand wrote: > On Fri, Jan 20, 2017 at 8:45 AM, Lionel Landwerlin > wrote: >> >> Some applications might add location decoration to samplers. Rather >> than raising an error it seems it would make more

[Mesa-dev] [Bug 99413] Rust game have wrong colors

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99413 --- Comment #1 from gtc...@gmail.com --- Same here. Ubuntu 16.10, kernel 4.8, Mesa 17-dev padoka ppa. GPU Radeon HD 7870 That said: the driver performance is great if compared to the closed source driver. Absolutely superior! But the colors are

Re: [Mesa-dev] [PATCH] nir: add min/max optimisation

2017-01-20 Thread Jason Ekstrand
On Wed, Jan 18, 2017 at 8:27 AM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > pushed. > On Jan 18, 2017 3:23 AM, "Elie Tournier" wrote: > > Add the following optimisations: > > min(x, -x) = -abs(x) > min(x,

[Mesa-dev] [AppVeyor] mesa master #3215 failed

2017-01-20 Thread AppVeyor
Build mesa 3215 failed Commit 0ae1f4a5ea by Matt Turner on 11/22/2016 6:40 PM: i965: Split gen_device_info_i965 between brw and cl.\n\ncl (Crestline) supports a few more things than brw (Broadwater). Sort\nand sync PCI IDs from the kernel.\n\nThe G45 PRMs use

Re: [Mesa-dev] [PATCH] [swr] Align query results allocation

2017-01-20 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jan 20, 2017, at 1:44 PM, George Kyriazis > wrote: > > Some query results struct contents are declared as cache line aligned. > Use aligned malloc, and align the whole struct, to be safe. > > Fixes crash

[Mesa-dev] [PATCH] [swr] Align query results allocation

2017-01-20 Thread George Kyriazis
Some query results struct contents are declared as cache line aligned. Use aligned malloc, and align the whole struct, to be safe. Fixes crash when compiling with clang. CC: --- src/gallium/drivers/swr/swr_query.cpp | 7 ---

Re: [Mesa-dev] [PATCH 11/27] i965/hiz/gen6: Stop setting false qpitch

2017-01-20 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Jan 16, 2017 at 1:13 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > which is not applicable for "all slices at each lod". Current > logic makes one to believe it has some purpose. When miptree > layout is calculated

Re: [Mesa-dev] [PATCH 10/27] i965/blorp/gen6: Drop unnecessary stencil/hiz surf dimension adjust

2017-01-20 Thread Jason Ekstrand
On Mon, Jan 16, 2017 at 1:13 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Hardware state setup only needs offset and pitch and ignores the > rest. > True... But it seems a a bit sketchy to lie to blorp even if the lie is ok. This isn't a NAK, just a comment for now. I need to

Re: [Mesa-dev] [PATCH 09/27] i965/gen6: Remove dead code in hiz surface setup

2017-01-20 Thread Jason Ekstrand
6-9 are Reviewed-by: Jason Ekstrand On Mon, Jan 16, 2017 at 1:13 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > In intel_hiz_miptree_buf_create() the miptree is unconditionally > created with MIPTREE_LAYOUT_FORCE_ALL_SLICE_AT_LOD. > > Signed-off-by: Topi

[Mesa-dev] [PATCH 1/2] gallium/radeon: refactor the GRBM counters path

2017-01-20 Thread Samuel Pitoiset
This will allow to expose more queries in order to know which blocks are busy/idle. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_gpu_load.c| 55 ++- src/gallium/drivers/radeon/r600_pipe_common.h | 18 +

[Mesa-dev] [PATCH 2/2] gallium/radeon: add HUD queries for monitoring some hw blocks

2017-01-20 Thread Samuel Pitoiset
It's also possible to monitor them via performance counters but the hardware can only use two counters simultaneously. It seems easier to re-use the existing code which reads from MMIO instead of writing a multi-pass approach. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

2017-01-20 Thread Mauro Rossi
Il lunedì 9 gennaio 2017, Zhen Wu > ha scritto: > Thanks for your review, Rob. Using kms-dri would mean writing a new > gralloc to basically the same thing as > gralloc.default and moving to grm_gralloc seems to be a bigger

[Mesa-dev] [PATCH 2/7] winsys/amdgpu: drop all IBs if at least one was rejected within the context

2017-01-20 Thread Marek Olšák
From: Marek Olšák The corruption is inevitable and hangs are possible too. --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

[Mesa-dev] [PATCH 3/7] gallium/radeon: adjust the rule for using the LINEAR_ALIGNED layout

2017-01-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index cba4e7d..0b77c82 100644 ---

[Mesa-dev] [PATCH 1/7] winsys/amdgpu: report a rejected IB as a lost context

2017-01-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 11 +++ src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 2 ++ src/gallium/winsys/amdgpu/drm/amdgpu_winsys.h | 1 + 3 files changed, 14 insertions(+) diff --git

[Mesa-dev] [PATCH 5/7] radeonsi: don't declare LDS in TES

2017-01-20 Thread Marek Olšák
From: Marek Olšák not used since we started using the offchip tess ring --- src/gallium/drivers/radeonsi/si_shader.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 6/7] radeonsi: always set the TCL1_ACTION_ENA when invalidating L2

2017-01-20 Thread Marek Olšák
From: Marek Olšák Some CIK-VI docs say this is the default behavior on SI. That doesn't answer whether it's also the default behavior on CIK-VI. Cc: 17.0 13.0 --- src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 7/7] radeonsi: handle first_non_void correctly in si_create_vertex_elements

2017-01-20 Thread Marek Olšák
From: Marek Olšák Cc: 17.0 --- src/gallium/drivers/radeonsi/si_state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

[Mesa-dev] [PATCH 4/7] radeonsi: preload PS inputs only if KILL is used

2017-01-20 Thread Marek Olšák
From: Marek Olšák so that most shaders can get lower VGPR usage thanks to lazy input loading. I think this is a more accurate constraint that prevents the black transitions in Witcher 2. Affected shaders (7758): Max Waves: 57437 -> 58231 (1.38 %) ---

[Mesa-dev] [PATCH] st/mesa: destroy pipe_context before destroying st_context

2017-01-20 Thread Marek Olšák
From: Marek Olšák If radeonsi starts compiling an optimized shader variant for asynchronously with a GL debug callback set and the application destroys the GL context, radeonsi crashes when trying to write shader stats into the debug output of a non-existent context after

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-20 Thread Jason Ekstrand
On Fri, Jan 20, 2017 at 10:26 AM, Ilia Mirkin wrote: > On Fri, Jan 20, 2017 at 1:25 PM, Jason Ekstrand > wrote: > > On Fri, Jan 20, 2017 at 10:16 AM, Ilia Mirkin > wrote: > >> > >> What level of support would a driver need to

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-20 Thread Ilia Mirkin
On Fri, Jan 20, 2017 at 1:25 PM, Jason Ekstrand wrote: > On Fri, Jan 20, 2017 at 10:16 AM, Ilia Mirkin wrote: >> >> What level of support would a driver need to provide? Can this just be >> enabled for all drivers? [This seems like largely a

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-20 Thread Jason Ekstrand
On Fri, Jan 20, 2017 at 10:16 AM, Ilia Mirkin wrote: > What level of support would a driver need to provide? Can this just be > enabled for all drivers? [This seems like largely a driver-side > feature rather than hardware-based.] > My understanding is that we should just

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-20 Thread Ilia Mirkin
What level of support would a driver need to provide? Can this just be enabled for all drivers? [This seems like largely a driver-side feature rather than hardware-based.] On Fri, Jan 20, 2017 at 1:12 PM, Plamena Manolova wrote: > Since we already have the

[Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-20 Thread Plamena Manolova
Since we already have the functionality in place and games like Game of Thrones seem to depend on this extension, I think it makes sense to enable it by making it part of the extension string even though its still a draft:

[Mesa-dev] [PATCH v4 4/6] i965: Add support for xfb overflow on query buffer objects.

2017-01-20 Thread Rafael Antognolli
Enable getting the results of a transform feedback overflow query with a buffer object. v4: - hsw_overflow_result_to_gpr0 a public function, so it can be used by conditional render. (Kenneth) - fix typo grp0/gpr0 (Kenneth) - rename load_gen_written_data_to_regs to

Re: [Mesa-dev] [PATCH v4 6/6] i965/gen6+: Enable arb_transform_feedback_overflow_query.

2017-01-20 Thread Rafael Antognolli
On Fri, Jan 20, 2017 at 09:53:27AM -0800, Rafael Antognolli wrote: > This extension adds new query types which can be used to detect overflow > of transform feedback buffers. The new query types are also accepted by > conditional rendering commands. > > v3: > - s/gen7+/gen6+/ in the relnotes

[Mesa-dev] [PATCH v4 6/6] i965/gen6+: Enable arb_transform_feedback_overflow_query.

2017-01-20 Thread Rafael Antognolli
This extension adds new query types which can be used to detect overflow of transform feedback buffers. The new query types are also accepted by conditional rendering commands. v3: - s/gen7+/gen6+/ in the relnotes (Jordan Justen) Signed-off-by: Rafael Antognolli

[Mesa-dev] [PATCH v4 1/6] mesa: Add types for ARB_transform_feedback_oveflow_query.

2017-01-20 Thread Rafael Antognolli
Add some basic types and storage for the queries of this extension. v2: - update date of extension (Kenneth) Signed-off-by: Rafael Antognolli --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 5 + 2 files changed, 6

[Mesa-dev] [PATCH v4 2/6] mesa: Track transform feedback overflow query objects.

2017-01-20 Thread Rafael Antognolli
Also update checks on conditional rendering. Signed-off-by: Rafael Antognolli --- src/mesa/main/condrender.c | 4 +++- src/mesa/main/queryobj.c| 21 + src/mesa/state_tracker/st_cb_queryobj.c | 6 ++ 3 files

[Mesa-dev] [PATCH v4 3/6] i965: add plumbing for ARB_transform_feedback_overflow_query.

2017-01-20 Thread Rafael Antognolli
When querying for transform feedback overflow on one or all of the streams, store information about number of generated and written primitives. Then check whether generated == written. v2: - use only SO_PRIM_STORAGE_NEEDED, do not fallback to CL_INVOCATION_COUNT. (Kenneth)

[Mesa-dev] [PATCH v4 0/6] Add support for ARB_transform_feedback_overflow_query.

2017-01-20 Thread Rafael Antognolli
This patch series implements the ARB_transform_feedback_overflow_query extension for i965. Changes for v4: - Reuse of MI_MATH calcs from hsw_queryobj.c in brw_conditional_render.c - Renamed a couple functions as suggested by Kenneth - Fallback to CPU-side conditional rendering if

[Mesa-dev] [PATCH v4 5/6] i965: Add support for xfb overflow query on conditional render.

2017-01-20 Thread Rafael Antognolli
Enable the use of a transform feedback overflow query with glBeginConditionalRender. The render commands will only execute if the query is true (i.e. if there was an overflow). Use ARB_conditional_render_inverted to change this behavior. v4: - reuse MI_MATH calcs from hsw_queryob (Kenneth)

Re: [Mesa-dev] [PATCH v2 2/2] anv: don't require render target isl bit for depth/stencil surfaces

2017-01-20 Thread Jason Ekstrand
Cc: "13.0 17.0" Reviewed-by: Jason Ekstrand On Fri, Jan 20, 2017 at 9:31 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Blorp can deal with depth/stencil surfaces blits/copies without the > render target requirement.

[Mesa-dev] [PATCH v2 2/2] anv: don't require render target isl bit for depth/stencil surfaces

2017-01-20 Thread Lionel Landwerlin
Blorp can deal with depth/stencil surfaces blits/copies without the render target requirement. Also having both render target and depth/stencil requirement is incompatible from isl's point of view. This fixes an image creation issue in the high level quality settings of the Unity3D player, which

Re: [Mesa-dev] [PATCH 1/2] spirv: don't assert with location decorations on non i/o variables

2017-01-20 Thread Jason Ekstrand
On Fri, Jan 20, 2017 at 8:45 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Some applications might add location decoration to samplers. Rather > than raising an error it seems it would make more sense to just > discard these decorations. > That's annoying but not the end of the

Re: [Mesa-dev] [PATCH 2/2] anv: don't require render target isl bit for depth/stencil surfaces

2017-01-20 Thread Jason Ekstrand
On Fri, Jan 20, 2017 at 8:45 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Blorp can deal with depth/stencil surfaces blits/copies without the > render target requirement. Also having both render target and > depth/stencil requirement is incompatible from isl's point of view. >

[Mesa-dev] [PATCH 0/2] anv/spirv: Fixes for Unity3D

2017-01-20 Thread Lionel Landwerlin
Hi, While testing Unity3D demos, I've noticed a couple of issues with our driver. Cheers, Lionel Landwerlin (2): spirv: don't assert with location decorations on non i/o variables anv: don't require render target isl bit for depth/stencil surfaces src/compiler/spirv/vtn_variables.c | 3

[Mesa-dev] [PATCH 1/2] spirv: don't assert with location decorations on non i/o variables

2017-01-20 Thread Lionel Landwerlin
Some applications might add location decoration to samplers. Rather than raising an error it seems it would make more sense to just discard these decorations. Signed-off-by: Lionel Landwerlin --- src/compiler/spirv/vtn_variables.c | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 2/2] anv: don't require render target isl bit for depth/stencil surfaces

2017-01-20 Thread Lionel Landwerlin
Blorp can deal with depth/stencil surfaces blits/copies without the render target requirement. Also having both render target and depth/stencil requirement is incompatible from isl's point of view. This fixes an image creation issue in the high level quality settings of the Unity3D player, which

Re: [Mesa-dev] Time to update GSoC/EVoC ideas page

2017-01-20 Thread Jason Ekstrand
On Fri, Jan 20, 2017 at 2:15 AM, Nicolai Hähnle wrote: > Hi Rob, > > On 19.01.2017 23:32, Rob Clark wrote: > >> Just a friendly reminder that now would be a good time to update the >> wiki page for GSoC/EVoC ideas: >> >> https://www.x.org/wiki/SummerOfCodeIdeas/ >> >> There

Re: [Mesa-dev] [PATCH 2/3] spirv: fix warn string typo

2017-01-20 Thread Jason Ekstrand
All three are Reviewed-by: Jason Ekstrand On Fri, Jan 20, 2017 at 8:38 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Signed-off-by: Lionel Landwerlin > --- > src/compiler/spirv/vtn_variables.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-20 Thread Jason Ekstrand
On Thu, Jan 19, 2017 at 11:48 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Thu, Jan 19, 2017 at 01:39:49PM -0800, Jason Ekstrand wrote: > >On Thu, Jan 19, 2017 at 12:40 PM, Francisco Jerez > ><[1]curroje...@riseup.net> wrote: > > > > "Pohjolainen, Topi"

[Mesa-dev] [PATCH 1/3] blorp: remove unnecessary struct declaration

2017-01-20 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index ff60567fc4..e0687e9261 100644 --- a/src/intel/blorp/blorp.h +++ b/src/intel/blorp/blorp.h @@

[Mesa-dev] [PATCH 2/3] spirv: fix warn string typo

2017-01-20 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 61a3701e43..a543a52dd0 100644 ---

[Mesa-dev] [PATCH 3/3] anv: fix comment typo

2017-01-20 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_descriptor_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index 2926e7a259..4367c0ebe0 100644 ---

[Mesa-dev] [Bug 99446] [anv] (and radv) Regression enabling Vulkan loader interface version 3

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99446 yann changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are

[Mesa-dev] [Bug 99446] [anv] (and radv) Regression enabling Vulkan loader interface version 3

2017-01-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99446 Jason Ekstrand changed: What|Removed |Added Resolution|--- |NOTOURBUG

Re: [Mesa-dev] [PATCH 01/19] i965: automake: correctly set MKDIR_GEN

2017-01-20 Thread Emil Velikov
On 16 January 2017 at 18:30, Kenneth Graunke wrote: > On Monday, January 16, 2017 3:45:32 PM PST Emil Velikov wrote: >> From: Emil Velikov >> >> Otherwise we might end up w/o the respective folder (depending on >> autotools version) and fail at

  1   2   >