Re: [Mesa-dev] [PATCH] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

2017-03-30 Thread Kenneth Graunke
On Thursday, March 30, 2017 6:48:38 PM PDT Kenneth Graunke wrote: > On Thursday, March 30, 2017 4:38:14 PM PDT Chris Wilson wrote: > > On Thu, Mar 30, 2017 at 04:28:19PM -0700, Kenneth Graunke wrote: > > > On modern systems with 4GB apertures, the size in bytes is 4294967296, > > > or (1ull <<

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

2017-03-30 Thread Rob Clark
On Fri, Mar 31, 2017 at 12:22 AM, Tapani Pälli wrote: > > > On 03/30/2017 05:57 PM, Emil Velikov wrote: >> >> On 30 March 2017 at 15:30, Tomasz Figa wrote: >>> >>> On Thu, Mar 30, 2017 at 11:17 PM, Emil Velikov >>> wrote:

Re: [Mesa-dev] [PATCH 1/3] gm107/ir: Emit SV_CLOCK system value

2017-03-30 Thread Boyan Ding
2017-03-31 11:21 GMT+08:00 Ilia Mirkin : > Did you check what the blob does? There's clocklo/hi and > globaltimerlo/hi. Without additional documentation, it's a bit hard to > tell the difference... Note that envydis's gf100.c/gk110.c disagree on > which is which. Probably not

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

2017-03-30 Thread Tapani Pälli
On 03/30/2017 05:57 PM, Emil Velikov wrote: On 30 March 2017 at 15:30, Tomasz Figa wrote: On Thu, Mar 30, 2017 at 11:17 PM, Emil Velikov wrote: On 30 March 2017 at 11:55, Tomasz Figa wrote: Android buffer queues can be

Re: [Mesa-dev] [PATCH] glsl: use -O0 optimization for builtin_functions.cpp with MinGW

2017-03-30 Thread Brian Paul
On 03/30/2017 09:23 PM, Brian Paul wrote: Some versions of MinGW-w64 such as 5.3.1 and 6.2.0 produce bad code with -O2 or -O3 causing a random driver crash when running programs that use GLSL. Most Mesa demos in the glsl/ directory trigger the bug, but not the fragcoord.c test. Use a #pragma

Re: [Mesa-dev] [PATCH 2/3] nvc0/ir: Handle TGSI_OPCODE_CLOCK

2017-03-30 Thread Ilia Mirkin
On Thu, Mar 30, 2017 at 10:33 PM, Boyan Ding wrote: > Signed-off-by: Boyan Ding > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[Mesa-dev] [PATCH] glsl: use -O0 optimization for builtin_functions.cpp with MinGW

2017-03-30 Thread Brian Paul
Some versions of MinGW-w64 such as 5.3.1 and 6.2.0 produce bad code with -O2 or -O3 causing a random driver crash when running programs that use GLSL. Most Mesa demos in the glsl/ directory trigger the bug, but not the fragcoord.c test. Use a #pragma to force -O1 for this file for later MinGW

[Mesa-dev] [PATCH] glsl: add null pointer check in print_without_declaration()

2017-03-30 Thread Brian Paul
To avoid/fix a segmentation fault when running the stand-alone GLSL compiler utility for cases such as the Mesa demos toyball test: glsl_compiler --dump-builder --version 120 CH11-toyball.vert CH11-toyball.frag --- src/compiler/glsl/ir_builder_print_visitor.cpp | 4 +++- 1 file changed, 3

Re: [Mesa-dev] [PATCH 1/3] gm107/ir: Emit SV_CLOCK system value

2017-03-30 Thread Ilia Mirkin
Did you check what the blob does? There's clocklo/hi and globaltimerlo/hi. Without additional documentation, it's a bit hard to tell the difference... Note that envydis's gf100.c/gk110.c disagree on which is which. Probably not due to any architectural reasons, but due to RE methodology. (From

[Mesa-dev] [PATCH 3/3] nvc0: enable ARB_shader_clock

2017-03-30 Thread Boyan Ding
Signed-off-by: Boyan Ding --- docs/features.txt | 2 +- docs/relnotes/17.1.0.html | 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] gm107/ir: Emit SV_CLOCK system value

2017-03-30 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp index

[Mesa-dev] [PATCH 2/3] nvc0/ir: Handle TGSI_OPCODE_CLOCK

2017-03-30 Thread Boyan Ding
Signed-off-by: Boyan Ding --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index

[Mesa-dev] [PATCH 0/3] ARB_shader_clock for nvc0

2017-03-30 Thread Boyan Ding
This series depends on the Nicolai's work in gallium[1], and it's quite trivial. The first patch handles clock registers on Maxwell+, and the second one translates TGSI_OPCODE_CLOCK into special register reads. The last patch just flips the extension on. Boyan

Re: [Mesa-dev] [PATCH] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

2017-03-30 Thread Kenneth Graunke
On Thursday, March 30, 2017 4:38:14 PM PDT Chris Wilson wrote: > On Thu, Mar 30, 2017 at 04:28:19PM -0700, Kenneth Graunke wrote: > > On modern systems with 4GB apertures, the size in bytes is 4294967296, > > or (1ull << 32). The kernel gives us the aperture size as a __u64, > > which works out

[Mesa-dev] [PATCH] radv: always do tess ring size calculations.

2017-03-30 Thread Dave Airlie
From: Dave Airlie We could store these in the device, but it's probably not that much overhead to recalculate them, this is needed because we will emit the rings if the queue has them created so we need to emit the register values correctly as well. This fixes some tess

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

2017-03-30 Thread Chad Versace
On Wed 15 Mar 2017, Jason Ekstrand wrote: > This cache allows us to easily ensure that we have a unique anv_bo for > each gem handle. We'll need this in order to support multiple-import of > memory objects and semaphores. > > v2 (Jason Ekstrand): > - Reject BO imports if the size doesn't match

Re: [Mesa-dev] [rfc] radv missing tesseellation patches

2017-03-30 Thread Mike Lothian
That gets both tessellation and terraintessellation demos working for me Feel free to add my tested by for the series On Fri, 31 Mar 2017 at 01:45 Dave Airlie wrote: > I somehow in my rebasing lost two patches, not sure where I ate them. > > Anyways slot these in as patch

Re: [Mesa-dev] [PATCH 1/2] intel: genxml: compress all gen files into one

2017-03-30 Thread Mike Lothian
This prevents me building master PYTHONPATH=/var/tmp/portage/media-libs/mesa-/work/mesa-/src/compiler/nir /usr/bin/python2.7 /var/tmp/portage/media-libs/mesa-/work/mesa-/src/intel/compiler/brw_nir_trig_workarounds.py > compiler/brw_nir_trig_workarounds.c || (rm -f compi

Re: [Mesa-dev] [PATCH V2] mesa: disable glthread when DEBUG_OUTPUT_SYNCHRONOUS is enabled

2017-03-30 Thread Timothy Arceri
On 31/03/17 11:45, Timothy Arceri wrote: We could re-enable it also but I haven't tested that yet, and I'm not sure we care much anyway. V2: don't disable it from with the call itself. We need a custom marshalling function or we get stuck waiting for thread to finish. *from within

[Mesa-dev] [PATCH V2] mesa: disable glthread when DEBUG_OUTPUT_SYNCHRONOUS is enabled

2017-03-30 Thread Timothy Arceri
We could re-enable it also but I haven't tested that yet, and I'm not sure we care much anyway. V2: don't disable it from with the call itself. We need a custom marshalling function or we get stuck waiting for thread to finish. --- src/mapi/glapi/gen/gl_API.xml | 2 +-

[Mesa-dev] [PATCH 2/2] radv: setup lds for tessellation

2017-03-30 Thread Dave Airlie
From: Dave Airlie This seems to get lost in the rebases, should fix the tessellation demos, crash in llvm. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 12 1 file changed, 12 insertions(+) diff --git

[Mesa-dev] [rfc] radv missing tesseellation patches

2017-03-30 Thread Dave Airlie
I somehow in my rebasing lost two patches, not sure where I ate them. Anyways slot these in as patch 24.1 and 24.2 before the enable patch. I've updated the radv-wip-tess-submit branch as well. Dave. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 1/2] radv: add ia_multi_vgt_param tessellation support.

2017-03-30 Thread Dave Airlie
From: Dave Airlie This just ports the relevant radeonsi pieces. Signed-off-by: Dave Airlie --- src/amd/vulkan/si_cmd_buffer.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: disable glthread when DEBUG_OUTPUT_SYNCHRONOUS is enabled

2017-03-30 Thread Timothy Arceri
On 30/03/17 18:54, Nicolai Hähnle wrote: On 30.03.2017 07:21, Timothy Arceri wrote: We could re-enable it also but I haven't tested that yet, and I'm not sure we care much anyway. Reviewed-by: Nicolai Hähnle Sorry, I've made a silly mistake here. We can't

[Mesa-dev] [Bug 96684] [swrast] piglit glsl-array-bounds-01 regression

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96684 --- Comment #4 from Timothy Arceri --- I've update the test to have the same outcome regardless of which branch is taken. https://patchwork.freedesktop.org/patch/147474/ This should fix the problem. -- You are

[Mesa-dev] [Bug 96684] [swrast] piglit glsl-array-bounds-01 regression

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96684 --- Comment #3 from Timothy Arceri --- I think the test is wrong, it should not be expecting a specific outcome. The spec says: "Behavior is undefined if a shader subscripts an array with an index less than 0 or greater

Re: [Mesa-dev] [PATCH] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

2017-03-30 Thread Chris Wilson
On Thu, Mar 30, 2017 at 04:28:19PM -0700, Kenneth Graunke wrote: > On modern systems with 4GB apertures, the size in bytes is 4294967296, > or (1ull << 32). The kernel gives us the aperture size as a __u64, > which works out great. > > Unfortunately, libdrm "helpfully" returns the data as a

[Mesa-dev] [PATCH] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

2017-03-30 Thread Kenneth Graunke
On modern systems with 4GB apertures, the size in bytes is 4294967296, or (1ull << 32). The kernel gives us the aperture size as a __u64, which works out great. Unfortunately, libdrm "helpfully" returns the data as a size_t, which on 32-bit systems means it truncates the aperture size to 0

Re: [Mesa-dev] [PATCH v2 6/6] nvc0: Add support for NV_fill_rectangle for the GM200+

2017-03-30 Thread Ilia Mirkin
On Thu, Mar 30, 2017 at 5:40 PM, Lyude wrote: > This enables support for the GL_NV_fill_rectangle extension on the > GM200+ for Desktop OpenGL. > > Signed-off-by: Lyude > > Changes since v1: > - Fix commit message > - Add note to reldocs > > Signed-off-by:

Re: [Mesa-dev] [PATCH v2 2/6] mesa: Add support for GL_NV_fill_rectangle

2017-03-30 Thread Ilia Mirkin
On Thu, Mar 30, 2017 at 5:40 PM, Lyude wrote: > + /* From the GL_NV_fill_rectangle spec: > +* > +* "An INVALID_OPERATION error is generated by Begin or any Draw command > if > +* only one of the front and back polygon mode is FILL_RECTANGLE_NV." > +*/ > +

Re: [Mesa-dev] [RFC] radv initial tessellation support

2017-03-30 Thread Mike Lothian
I tried running the tessellation demo from Sacha Williams on my Tonga and I got the following error: vulkantessellation: /var/tmp/portage/sys-devel/llvm-/work/llvm-/include/llvm/Support/Casting.h:95: static bool llvm::isa_impl_cl::doit(const From *)

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-03-30 Thread Jose Fonseca
On 30/03/17 19:52, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-29 15:27:58) On 28/03/17 22:37, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-28 13:45:57) On 28/03/17 21:32, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-28 09:19:48) On 28/03/17 00:12, Dylan Baker wrote: Quoting

Re: [Mesa-dev] [PATCH v2] util/u_atomic: provide 64bit atomics where they're missing

2017-03-30 Thread Matt Turner
On Thu, Mar 30, 2017 at 3:26 PM, Grazvydas Ignotas wrote: > There are still some distributions trying to support unfortunate people > with old or exotic CPUs that don't have 64bit atomic operations. When > compiling for such a machine, gcc conveniently inserts a library call to

Re: [Mesa-dev] [PATCH 3/4] mesa: remove MESA_GLSL=no_opts env option

2017-03-30 Thread Emil Velikov
On 30 March 2017 at 17:44, Brian Paul wrote: > On 03/30/2017 05:26 AM, Timothy Arceri wrote: >> >> This is confusing because is only applys to ARB shaders, and because > > > s/ARB shaders/GL_ARB_vertex/fragment_program/ > >> of that its also not very useful. >> >> If someone

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_tgsi: fix 64-bit integer bit shifts

2017-03-30 Thread Marek Olšák
On Thu, Mar 30, 2017 at 5:29 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fix a bug that was caused by a type mismatch in the shfit count between > GLSL and TGSI. I briefly considered adjusting the TGSI semantics, but > since both LLVM and AMD

Re: [Mesa-dev] [PATCH] i965: Select pipeline and emit state base address in Gen8+ HiZ ops.

2017-03-30 Thread Nanley Chery
On Mon, Mar 20, 2017 at 08:05:22PM -0700, Nanley Chery wrote: Okay, I've re-read the email. > On Mon, Mar 20, 2017 at 08:01:25PM -0700, Nanley Chery wrote: > > On Thu, Mar 16, 2017 at 05:34:13PM -0700, Kenneth Graunke wrote: > > > On Wednesday, March 8, 2017 10:27:20 AM PDT Nanley Chery wrote:

[Mesa-dev] [Bug 100262] libswrAVX2.so Causes hang with QOpenGLWidget

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100262 --- Comment #4 from ch...@circlecvi.com --- (In reply to Tim Rowley from comment #3) > Ok, looks like I need to check and make sure there hasn't been a regression > for this since Mesa 13. Are you using the dri version of the driver, or >

[Mesa-dev] [PATCH v2] util/u_atomic: provide 64bit atomics where they're missing

2017-03-30 Thread Grazvydas Ignotas
There are still some distributions trying to support unfortunate people with old or exotic CPUs that don't have 64bit atomic operations. When compiling for such a machine, gcc conveniently inserts a library call to a helper, but it's implementation is missing and we get a linker error. This allows

Re: [Mesa-dev] [PATCH] gallivm: add lp_build_emit_fetch_src() helper

2017-03-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 7:57 PM, Samuel Pitoiset wrote: > lp_build_emit_fetch() is useful when the source type can be > infered from the instruction opcode. > > However, for bindless samplers/images we can't do that

Re: [Mesa-dev] [PATCH] intel: genxml: add gen7 ERR_INT register

2017-03-30 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] mesa: remove MESA_GLSL=opt

2017-03-30 Thread Marek Olšák
I agree with Nicolai. For the series: Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 1:26 PM, Timothy Arceri wrote: > This is unused. > --- > docs/shading.html | 1 - > src/mesa/main/mtypes.h| 15 +++ >

Re: [Mesa-dev] [PATCH] radeonsi: implement ARB_shader_group_vote

2017-03-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 10:48 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > docs/features.txt| 2 +- > docs/relnotes/17.1.0.html| 1 + >

[Mesa-dev] [Bug 100262] libswrAVX2.so Causes hang with QOpenGLWidget

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100262 --- Comment #3 from Tim Rowley --- Ok, looks like I need to check and make sure there hasn't been a regression for this since Mesa 13. Are you using the dri version of the driver, or libgl-x11? Interesting that

[Mesa-dev] [PATCH v2 6/6] nvc0: Add support for NV_fill_rectangle for the GM200+

2017-03-30 Thread Lyude
This enables support for the GL_NV_fill_rectangle extension on the GM200+ for Desktop OpenGL. Signed-off-by: Lyude Changes since v1: - Fix commit message - Add note to reldocs Signed-off-by: Lyude --- docs/relnotes/17.1.0.html| 1 +

[Mesa-dev] [PATCH v2 5/6] st/mesa: Add support for NV_fill_rectangle

2017-03-30 Thread Lyude
Signed-off-by: Lyude Changes since v1: - Fix commit name Signed-off-by: Lyude --- src/mesa/state_tracker/st_atom_rasterizer.c | 2 ++ src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH v2 4/6] gallium: Add NV_fill_rectangle to pipe state

2017-03-30 Thread Lyude
Signed-off-by: Lyude Changes since v1: - Fix accidental widening of bitfields Signed-off-by: Lyude --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h

[Mesa-dev] [PATCH v2 3/6] gallium: Add a cap to check if the driver supports fill_rectangle

2017-03-30 Thread Lyude
Changes since v1: - Add pipe caps for etnaviv, freedreno, swr and virgl Signed-off-by: Lyude --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 +

[Mesa-dev] [PATCH v2 2/6] mesa: Add support for GL_NV_fill_rectangle

2017-03-30 Thread Lyude
Since we don't have the bits required to support this in OpenGLES yet, this only enables support for Desktop OpenGL Signed-off-by: Lyude Changes since v1: - Simply _mesa_PolygonMode() a little bit - Fix formatting in OpenGL spec excerpts - Move polygon mode checking into

[Mesa-dev] [PATCH v2 1/6] glapi: Add GL_NV_fill_rectangle

2017-03-30 Thread Lyude
Signed-off-by: Lyude --- src/mapi/glapi/gen/gl_API.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index dfaeaaf..8392e3a 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/src/mapi/glapi/gen/gl_API.xml @@

[Mesa-dev] [PATCH v2 0/6] Add support for GL_NV_fill_rectangle

2017-03-30 Thread Lyude
This adds basic support for GL_NV_fill_rectangle in Gallium, along with enabling it for the GM200+ in nouveau. It should be noted this only implements the OpenGL 4.3 bits, since we don't have the features required yet to add this for OpenGLES. Lyude (6): glapi: Add GL_NV_fill_rectangle mesa:

[Mesa-dev] [PATCH] intel: tools: add aubinator_error_decode tool

2017-03-30 Thread Lionel Landwerlin
This is pretty much the same tool as what i-g-t has, only with a more fancy decoding of the instructions/registers. It also doesn't support anything before gen4. v2 (from Matt): Drop authors Remove undefined automake variable Signed-off-by: Lionel Landwerlin

[Mesa-dev] [PATCH] intel: genxml: add gen7 ERR_INT register

2017-03-30 Thread Lionel Landwerlin
v2: add register to gen7.5 (Matt) Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen7.xml | 11 +++ src/intel/genxml/gen75.xml | 11 +++ 2 files changed, 22 insertions(+) diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml

Re: [Mesa-dev] [PATCH 3/4] mesa: remove MESA_GLSL=no_opts env option

2017-03-30 Thread Timothy Arceri
On 31/03/17 03:44, Brian Paul wrote: On 03/30/2017 05:26 AM, Timothy Arceri wrote: This is confusing because is only applys to ARB shaders, and because s/ARB shaders/GL_ARB_vertex/fragment_program/ of that its also not very useful. If someone requires this for debugging they can just

Re: [Mesa-dev] [PATCH 4/4] anv: Use subpass dependencies for flushes

2017-03-30 Thread Nanley Chery
On Tue, Mar 14, 2017 at 07:55:53AM -0700, Jason Ekstrand wrote: > Instead of figuring it all out ourselves, just use the information given > to us by the client. > --- > src/intel/vulkan/anv_blorp.c | 88 > -- > src/intel/vulkan/genX_cmd_buffer.c | 10

Re: [Mesa-dev] Windows build requires extra tools from release tarball

2017-03-30 Thread Jose Fonseca
On 30/03/17 18:38, Ben Boeckel wrote: Hi, I'm trying to compile Mesa on Windows, but am hitting up against a problem that mako and lex/yacc are required. The generated files are in the source tree, but from my investigations (and limited knowledge of Scons), it appears that the Scons code does

Re: [Mesa-dev] [PATCH v2 3/4] anv/pass: Record required pipe flushes

2017-03-30 Thread Nanley Chery
On Wed, Mar 15, 2017 at 12:01:16PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_pass.c| 89 > ++ > src/intel/vulkan/anv_private.h | 2 + > 2 files changed, 91 insertions(+) > > diff --git a/src/intel/vulkan/anv_pass.c

Re: [Mesa-dev] i965: On-demand render target flushing

2017-03-30 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > Jason, Curro, do you have any opinion if this is worth pursuing? > I need something for blorp blits at least - using blorp for texture > uploads on top of current excessive flushing regresses perf. > I wouldn't be surprised if it

Re: [Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

2017-03-30 Thread Kristian Høgsberg
On Thu, Mar 30, 2017 at 1:38 PM, Lionel Landwerlin wrote: > On 30/03/17 20:09, Chris Wilson wrote: >> >> On Thu, Mar 30, 2017 at 11:27:26AM -0700, Matt Turner wrote: >>> >>> I think we should figure out how to make this not just a fork of >>> intel_error_decode.

Re: [Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

2017-03-30 Thread Lionel Landwerlin
On 30/03/17 20:09, Chris Wilson wrote: On Thu, Mar 30, 2017 at 11:27:26AM -0700, Matt Turner wrote: I think we should figure out how to make this not just a fork of intel_error_decode. Should intel_error_decode do away? There are various tools in i-g-t that I'm definitely in favor of moving

[Mesa-dev] [Bug 35268] initial-exec TLS model breaks dlopen'ed libGL

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35268 Nicholas Fish changed: What|Removed |Added CC||x...@seaofdirac.net

[Mesa-dev] [PATCH] mesa/glthread: Call unmarshal_batch directly in glthread_finish

2017-03-30 Thread Bartosz Tomczyk
Call it directly when batch queue is empty. This avoids costly thread synchronisation. This commit improves performance of games that have previously regressed with mesa_glthread=true. --- src/mesa/main/glthread.c | 47 ++- 1 file changed, 34

Re: [Mesa-dev] [PATCH] glsl: allow glsl_type::sampler_index() with images

2017-03-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 12:33 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/compiler/glsl_types.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: use glsl_type::sampler_index()

2017-03-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 12:28 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 68 > +- > 1

Re: [Mesa-dev] [PATCH 6/6] radeonsi: enable ARB_shader_clock

2017-03-30 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 9:38 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > docs/features.txt | 2 +- > docs/relnotes/17.1.0.html |

Re: [Mesa-dev] [Request for Comments] - Port documentation to Markdown

2017-03-30 Thread Jean Hertel
Hello Emil, I'm not sure if you have read the full conversation, but I changed my mind about this. I have shifted focus to use Sphinx for website generation along with documentation. As far as I can tell, there is already documentation about NIR and Gallium writen in ReStructured Text,

[Mesa-dev] [Bug 100262] libswrAVX2.so Causes hang with QOpenGLWidget

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100262 --- Comment #2 from ch...@circlecvi.com --- (In reply to Tim Rowley from comment #1) > Not seeing a hang here, but a transparent area where the OpenGL should be > rendered to. > > what version of Mesa and Qt were you using? > > If you don't

[Mesa-dev] [PATCH 0/1] NULL pointer in blob_write_string

2017-03-30 Thread Gregory Hainaut
Hello, Fix a crash on Nouveau + Shader cache. I don't know if it could impact current stable version As a remainder I don't have commit access. Best regards, Gregory Hainaut (1): glsl/blob: handle copy of NULL ptr in blob_write_string src/compiler/glsl/blob.c | 5

[Mesa-dev] [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

2017-03-30 Thread Gregory Hainaut
Typically happen when we want to copy an unnamed shader parameter in the shader cache. Note: it is safer to copy an empty string so we can read it back safely. Fix piglit crashes of the 'texturegatheroffsets' tests Signed-off-by: Gregory Hainaut ---

Re: [Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

2017-03-30 Thread Lionel Landwerlin
On 30/03/17 19:27, Matt Turner wrote: On Wed, Mar 29, 2017 at 1:07 PM, Lionel Landwerlin wrote: This is pretty much the same tool as what i-g-t has, only with a more fancy decoding of the instructions/registers. It also doesn't support anything before gen4.

[Mesa-dev] Windows build requires extra tools from release tarball

2017-03-30 Thread Ben Boeckel
Hi, I'm trying to compile Mesa on Windows, but am hitting up against a problem that mako and lex/yacc are required. The generated files are in the source tree, but from my investigations (and limited knowledge of Scons), it appears that the Scons code does not care and always does the generation

Re: [Mesa-dev] [PATCH 4/7] intel: genxml: add gen7 ERR_INT register

2017-03-30 Thread Lionel Landwerlin
On 30/03/17 18:53, Matt Turner wrote: On Wed, Mar 29, 2017 at 1:07 PM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen7.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 06/18] anv: Implement VK_KHX_external_memory

2017-03-30 Thread Jason Ekstrand
On Thu, Mar 30, 2017 at 11:27 AM, Chad Versace wrote: > On Mon 13 Mar 2017, Jason Ekstrand wrote: > > There's really nothing for us to do here. So long as the user doesn't > > set any crazy environment variables such as INTEL_VK_HIZ=false, all of > > the compression

Re: [Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

2017-03-30 Thread Chris Wilson
On Thu, Mar 30, 2017 at 11:27:26AM -0700, Matt Turner wrote: > I think we should figure out how to make this not just a fork of > intel_error_decode. Should intel_error_decode do away? > > There are various tools in i-g-t that I'm definitely in favor of > moving into Mesa (like the assembler and

[Mesa-dev] [PATCH] radv: Invalidate L2 for TRANSFER_WRITE barriers

2017-03-30 Thread Bas Nieuwenhuizen
From: Alex Smith CP DMA and PKT3_WRITE_DATA (in CmdUpdateBuffer) don't (currently) write through L2. Therefore, to make these writes visible to later accesses we must invalidate L2 rather than just writing it back, to avoid the possibility that stale data is read

Re: [Mesa-dev] [PATCH 1/2] intel: genxml: compress all gen files into one

2017-03-30 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2017-03-25 14:57:15, Lionel Landwerlin wrote: > Combining all the files into a single string didn't make any > difference in the size of the aubinator binary. > > With this change we now also embed gen4/4.5/5 descriptions, which >

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

2017-03-30 Thread Dylan Baker
Quoting Jose Fonseca (2017-03-29 15:27:58) > On 28/03/17 22:37, Dylan Baker wrote: > > Quoting Jose Fonseca (2017-03-28 13:45:57) > >> On 28/03/17 21:32, Dylan Baker wrote: > >>> Quoting Jose Fonseca (2017-03-28 09:19:48) > On 28/03/17 00:12, Dylan Baker wrote: > > Quoting Jose Fonseca

[Mesa-dev] [Bug 100262] libswrAVX2.so Causes hang with QOpenGLWidget

2017-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100262 --- Comment #1 from Tim Rowley --- Not seeing a hang here, but a transparent area where the OpenGL should be rendered to. what version of Mesa and Qt were you using? If you don't mind running an experiment, could

Re: [Mesa-dev] [Mesa-announce] Mesa 17.0.3 release candidate

2017-03-30 Thread Andres Gomez
On Thu, 2017-03-30 at 18:09 +0300, Andres Gomez wrote: ... > Rejected (2) > ... > Thomas Hellstrom (1): >   gbm/dri: Flush after unmap > > The commit caused a regression in i965 (and possibly others) since it This should have said i915 - -- Br, Andres

Re: [Mesa-dev] [PATCH v2 1/2] anv: Add support for 48-bit addresses

2017-03-30 Thread Jason Ekstrand
On Thu, Mar 30, 2017 at 9:25 AM, Kristian H. Kristensen wrote: > Jason Ekstrand writes: > > > This commit adds support for using the full 48-bit address space on > > Broadwell and newer hardware. Thanks to certain limitations, not all > > objects can

Re: [Mesa-dev] [PATCH 1/2] nir/constant_expressions: Pull the guts out into a helper block

2017-03-30 Thread Jason Ekstrand
On Thu, Mar 30, 2017 at 4:23 AM, Eduardo Lima Mitev wrote: > Looks good and clearer. Series is: > > Reviewed-by: Eduardo Lima Mitev > Thanks! I've pushed these two and the one for float16 support. > On 03/14/2017 10:08 PM, Jason Ekstrand wrote: > > --- >

Re: [Mesa-dev] [PATCH 1/4] anv: Add helpers for converting access flags to pipe bits

2017-03-30 Thread Nanley Chery
On Tue, Mar 14, 2017 at 07:55:50AM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_private.h | 59 > ++ > src/intel/vulkan/genX_cmd_buffer.c | 48 ++- > 2 files changed, 62 insertions(+), 45 deletions(-) > This patch

Re: [Mesa-dev] [PATCH v2 06/18] anv: Implement VK_KHX_external_memory

2017-03-30 Thread Chad Versace
On Mon 13 Mar 2017, Jason Ekstrand wrote: > There's really nothing for us to do here. So long as the user doesn't > set any crazy environment variables such as INTEL_VK_HIZ=false, all of > the compression formats etc. should "just work" at least for opaque > handle types. I think the commit

Re: [Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

2017-03-30 Thread Matt Turner
On Wed, Mar 29, 2017 at 1:07 PM, Lionel Landwerlin wrote: > This is pretty much the same tool as what i-g-t has, only with a more > fancy decoding of the instructions/registers. It also doesn't support > anything before gen4. > > Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH v2 05/18] anv: Implement VK_KHX_external_memory_capabilities

2017-03-30 Thread Chad Versace
On Mon 13 Mar 2017, Jason Ekstrand wrote: > From: Chad Versace > > This is a complete but trivial implementation. It's trivial becasue We > support no external memory capabilities yet. Most of the real work in > this commit is in reworking the UUIDs advertised by the

Re: [Mesa-dev] [PATCH 0/7] Aubinator error decode

2017-03-30 Thread Matt Turner
1-3 are Reviewed-by: Matt Turner I think 4 should touch gen75.xml, and I sent a comment. I cannot find the registers in 5 or 6 in the internal documentation. I'll review patch 7 separately. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 14/14] st/mesa: Use compressed fog mode for atifs.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 6 +++--- src/mesa/state_tracker/st_atom_shader.c | 17 + 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/src/mesa/state_tracker/st_atifs_to_tgsi.c

[Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/mtypes.h | 83 ++ src/mesa/main/texstate.c | 103 +++ 2 files changed, 186 insertions(+) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 13/14] mesa/main/ff_frag: Use compressed TexEnv Combine state.

2017-03-30 Thread Gustaw Smolarczyk
Along the way, add missing GL_ONE source support and drop non-existing GL_ZERO and GL_ONE operand support. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 335 +++ 1 file changed, 104 insertions(+), 231

[Mesa-dev] [PATCH 09/14] mesa/main/ff_frag: Don't retrieve format if not necessary.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 2b4d99c879..e1fe9b58c0 100644 ---

[Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

2017-03-30 Thread Gustaw Smolarczyk
It's not used. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 95c74e2b92..05641997de 100644

[Mesa-dev] [PATCH 12/14] mesa/main/ff_frag: Use compressed fog mode.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index e1fe9b58c0..bdbefc7880 100644

[Mesa-dev] [PATCH 07/14] mesa/main/ff_frag: Store nr_enabled_units only once.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 1b76f40e9a..717f39e9d3 100644 ---

[Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/enable.c | 1 + src/mesa/main/fog.c| 9 + src/mesa/main/mtypes.h | 14 ++ 3 files changed, 24 insertions(+) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index

[Mesa-dev] [PATCH 08/14] mesa/main/ff_frag: Use gl_texture_object::TargetIndex.

2017-03-30 Thread Gustaw Smolarczyk
Instead of computing it once again using _mesa_tex_target_to_index. Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp

[Mesa-dev] [PATCH 06/14] mesa/main/ff_frag: Simplify get_fp_input_mask.

2017-03-30 Thread Gustaw Smolarczyk
Change it into filter_fp_input_mask transform function that instead of returning a mask, transforms input. Also, simplify the case of vertex program handling by assuming that fp_inputs is always a combination of VARYING_BIT_COL* and VARYING_BIT_TEX*. Signed-off-by: Gustaw Smolarczyk

[Mesa-dev] [PATCH 01/14] mesa/main/ff_frag: Use correct constant.

2017-03-30 Thread Gustaw Smolarczyk
Since fixed-function shaders are restricted to MAX_TEXTURE_COORD_UNITS texture units, use this constant instead of MAX_TEXTURE_UNITS. This reduces the array size from 32 to 8. Signed-off-by: Gustaw Smolarczyk Reviewed-by: Eric Anholt ---

[Mesa-dev] [PATCH 04/14] mesa/main/ff_frag: Remove unused struct.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/main/ff_fragment_shader.cpp | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shader.cpp b/src/mesa/main/ff_fragment_shader.cpp index 9b00c36534..95c74e2b92 100644 ---

[Mesa-dev] [PATCH 03/14] mesa/main/ff_frag: Reduce the size of nr_enabled_units.

2017-03-30 Thread Gustaw Smolarczyk
Since it holds values from 0 to 8, 4 bits will suffice. Signed-off-by: Gustaw Smolarczyk Reviewed-by: Eric Anholt --- src/mesa/main/ff_fragment_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 02/14] mesa/main/ff_frag: Remove enabled_units.

2017-03-30 Thread Gustaw Smolarczyk
Its only usage is easily replaced by nr_enabled_units. As for cache key part, unit[i].enabled should be enough. Signed-off-by: Gustaw Smolarczyk Reviewed-by: Eric Anholt --- src/mesa/main/ff_fragment_shader.cpp | 4 +--- 1 file changed, 1 insertion(+), 3

[Mesa-dev] [PATCH 00/14] More substantial ff_fragment_shader cache key optimizations.

2017-03-30 Thread Gustaw Smolarczyk
Hello, This is the continuation of my ff_fragment_shader cache key optimizations. I have continued to try to reduce overhead of make_state_key function and it seems that I have gained a little bit. As this is the first time I have ventured into the mesa codebase so much, it's possible that I did

  1   2   3   >