Re: [Mesa-dev] [RFC mesa] travis: add couple missing proto+lib

On 22 June 2017 at 00:29, Eric Engestrom wrote: >> configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes >> x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met: >> No package 'xdamage' found >> No package 'xfixes' found > Any ideas why I cannot see

[Mesa-dev] [PATCH v2] getteximage: fix returned error value when texture object is not found

From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: "An INVALID_VALUE error is generated if texture is not the name of an existing texture object." Same wording applies to the compressed version. But turns out this is a spec bug, and Khronos is fixing it for the next

Re: [Mesa-dev] [PATCH mesa v2] egl: properly count configs

On 21 June 2017 at 21:55, Eric Engestrom wrote: > dri2_conf represents another config (which shouldn't be counted) > if it doesn't have the requested ID. > > Reported-by: Liu Zhiquan > Signed-off-by: Eric Engestrom > --- > v2: use

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

Am 22.06.2017 um 13:09 schrieb Nicolai Hähnle: > On 22.06.2017 10:14, Michel Dänzer wrote: >> On 22/06/17 04:34 PM, Nicolai Hähnle wrote: >>> On 22.06.2017 03:38, Rob Clark wrote: On Wed, Jun 21, 2017 at 8:15 PM, Marek Olšák wrote: > On Wed, Jun 21, 2017 at 10:37 PM,

Re: [Mesa-dev] [PATCH 01/11] util: Remove u_math from u_vector

Hey Lucas, On 22 June 2017 at 16:03, Lucas Stach wrote: > Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone: >> u_vector.h doesn't actually use anything from u_math, but it does mean >> everyone has to pull in src/gallium/auxiliary/util includes. >> >> Just

Re: [Mesa-dev] [PATCH 1/2] spirv: Fix reaching unreachable for compare exchange on images

On 21 June 2017 at 16:59, James Legg wrote: > We were hitting the > unreachable("Invalid image opcode") > near the end of vtn_handle_image when parsing SpvOpAtomicCompareExchange > and SpvOpAtomicCompareExchangeWeak opcodes. Thanks James. Are you hitting that

Re: [Mesa-dev] [PATCH 1/2] intel: common: break has_hiz_and_separate_stencil into 2 flags

Yeah I wasn't sure either. I'll look into changing things to use the debug flags. On 22/06/17 15:53, Jason Ekstrand wrote: Not a fan... As a hardware feature, the two definitely go together. The fact that both drivers identifiable hiz with an environment variable is immaterial. I think the

Re: [Mesa-dev] [PATCH v2] egl/dri2: implement query surface hook

Hi Tapani, On 21 December 2016 at 08:21, Tapani Pälli wrote: > This makes better guarantee that the values we return are > in sync what the underlying drawable currently has. > > Together with dEQP change in bug #98327 this fixes following test: > >

Re: [Mesa-dev] [PATCH 3/5] st/dri: add a drirc workaround for Rocket League

On Thu, Jun 22, 2017 at 3:46 PM, Emil Velikov wrote: > Hi Marek, > > Adding Timothee Besset, who I believe did the Linux port. > > Is this something that can be addressed within the game itself? > If the dev. team can roll a quick update it might be better to have that

[Mesa-dev] [PATCH v3] glsl: do not call link_xfb_stride_layout_qualifiers() for fragment shaders

xfb only applies to the latest stage before the fragment shader, so there is no need to invoke it in the fragment shader. Fixes: KHR-GL45.enhanced_layouts.xfb_stride_of_empty_list KHR-GL45.enhanced_layouts.xfb_stride_of_empty_list_and_api v2: do reset only if shaders provide an explicit stride

Re: [Mesa-dev] [PATCH] egl_dri2: swrastGetDrawableInfo: set *x, *y

Hi Ben, On 21 June 2017 at 16:55, Ben Crocker wrote: > In swrastGetDrawableInfo, set *x and *y, not just *w and *h; > this fixes a crash later in drisw_update_tex_buffer when the > (formerly) uninitialized x and y values are used to construct > an address in a call to

[Mesa-dev] [PATCH] radeonsi: enable LLVM sisched for Unigine Superposition

From: Marek Olšák +2.3% better score on Fiji. It might be better without HBM. --- src/gallium/drivers/radeonsi/si_pipe.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index

Re: [Mesa-dev] [PATCH 1/2] mesa: remove unused _NEW_TEXTURE composite state flags

On 06/22/2017 06:49 AM, Samuel Pitoiset wrote: --- src/mesa/main/mtypes.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 0cb002469b2..c88ca2e8e9c 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -4290,8 +4290,6 @@

Re: [Mesa-dev] [PATCH 01/11] util: Remove u_math from u_vector

Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone: > u_vector.h doesn't actually use anything from u_math, but it does mean > everyone has to pull in src/gallium/auxiliary/util includes. > > Just remove it, adding a include to u_vector.c to cover > memcpy. This patch seems to cause:

Re: [Mesa-dev] [PATCH 1/4] mesa: remove spurious flush in _mesa_DepthRange()

On 06/22/2017 08:35 AM, Samuel Pitoiset wrote: I don't think this is actually required, if the depth range values are different from the ones stored in the context, we already flush and trigger _NEW_VIEWPORT in set_depth_range_no_notify(). Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 2/2] mesa: do not trigger _NEW_TEXTURE_STATE in glActiveTexture()

On 06/22/2017 06:49 AM, Samuel Pitoiset wrote: This looks like useless because gl_context::Texture::CurrentUnit is not used by _mesa_update_texture_state() and friends. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstate.c | 2 -- 1 file changed, 2

Re: [Mesa-dev] [PATCH 2/2] mesa: do not trigger _NEW_TEXTURE_STATE in glActiveTexture()

On 06/22/2017 04:48 PM, Brian Paul wrote: On 06/22/2017 06:49 AM, Samuel Pitoiset wrote: This looks like useless because gl_context::Texture::CurrentUnit is not used by _mesa_update_texture_state() and friends. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 1/2] mesa: remove unused _NEW_TEXTURE composite state flags

On 06/22/2017 04:52 PM, Brian Paul wrote: On 06/22/2017 06:49 AM, Samuel Pitoiset wrote: --- src/mesa/main/mtypes.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 0cb002469b2..c88ca2e8e9c 100644 --- a/src/mesa/main/mtypes.h +++

Re: [Mesa-dev] [PATCH 1/2] intel: common: break has_hiz_and_separate_stencil into 2 flags

Not a fan... As a hardware feature, the two definitely go together. The fact that both drivers identifiable hiz with an environment variable is immaterial. I think the correct reafactor here would be to make the miptree code directly look at INTEL_DEBUG & DEBUG_NOHIZ instead of whacking the

Re: [Mesa-dev] [PATCH] i915: Fix gl_Fragcoord interpolation

On Thu, Jun 22, 2017 at 03:43:36PM +0300, Ville Syrjälä wrote: > On Wed, Jun 21, 2017 at 03:13:22PM -0700, Ian Romanick wrote: > > On 06/21/2017 10:38 AM, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > gl_FragCoord contains the window

Re: [Mesa-dev] [PATCH v4 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

Hi Gert, On 21 June 2017 at 13:59, Gert Wollny wrote: > This patch adds a set of unit tests for the new lifetime tracker. > --- > configure.ac | 1 + > src/mesa/Makefile.am | 2 +- >

Re: [Mesa-dev] [PATCH 2/4] mesa: remove spurious flush in _mesa_Viewport()

On 06/22/2017 08:35 AM, Samuel Pitoiset wrote: I don't think this is actually required, if the viewport values are different from the ones stored in the context, we already flush and trigger _NEW_VIEWPORT in set_viewport_no_notify(). Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 2/2] mesa: don't flush vertices in glClientActiveTexture

On 06/22/2017 06:34 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/main/texstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 0a2883f..bddd04b 100644 --- a/src/mesa/main/texstate.c

Re: [Mesa-dev] [PATCH 1/2] mesa: don't flag _NEW_ARRAY for GL_PRIMITIVE_RESTART_NV

On 06/22/2017 06:34 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/main/enable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index f1a9c7b..e1293f9 100644 --- a/src/mesa/main/enable.c +++

[Mesa-dev] [PATCH 7/8] mesa: add viewport() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index 867c35054b9..254b4aedd8e 100644 ---

[Mesa-dev] [PATCH 3/8] mesa: rename ViewportIndexedf() to viewport_indexed_err()

While are at it, add a 'context' parameter for consistency. Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index

[Mesa-dev] [PATCH 5/8] mesa: add viewport_array() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index 54d6e9905cf..5e28cf35c42 100644 ---

[Mesa-dev] [PATCH 1/8] mesa: add clip_control() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 61 +++- 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index ae03d6a5dd2..cf91dd284cb 100644

[Mesa-dev] [PATCH 2/8] mesa: add KHR_no_error support for glClipControl()

--- src/mapi/glapi/gen/ARB_clip_control.xml | 2 +- src/mesa/main/viewport.c| 9 + src/mesa/main/viewport.h| 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_clip_control.xml

[Mesa-dev] [PATCH 6/8] mesa: add KHR_no_error support for glViewportArrayv()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_viewport_array.xml | 2 +- src/mesa/main/viewport.c | 9 + src/mesa/main/viewport.h | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 8/8] mesa: add KHR_no_error support for glViewport()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/viewport.c | 7 +++ src/mesa/main/viewport.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 4/8] mesa: add KHR_no_error support for glViewportIndexed*()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_viewport_array.xml | 4 ++-- src/mesa/main/viewport.c | 15 +++ src/mesa/main/viewport.h | 7 +++ 3 files changed, 24 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/4] mesa: remove spurious flush in _mesa_Viewport()

I don't think this is actually required, if the viewport values are different from the ones stored in the context, we already flush and trigger _NEW_VIEWPORT in set_viewport_no_notify(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 1 - 1 file

[Mesa-dev] [PATCH 3/4] mesa: remove useless comments in the viewport code path

No need to explain why calling a driver callback is needed. Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index

Re: [Mesa-dev] [PATCH v4 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

Hi Gert, A couple of trivial bits I've noticed in patches 2 and 3, but applicable overall. - Unify if/return chains I've seen the following three examples, sometimes even right next to each other. if foo return f1; if bar return b1; return c1; if foo return f1; if bar return b1;

[Mesa-dev] [PATCH 4/4] mesa: only flush vertices when the viewport is different

This prevents glViewport() and friends to always flush and trigger _NEW_VIEWPORT. Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c

[Mesa-dev] [PATCH 1/4] mesa: remove spurious flush in _mesa_DepthRange()

I don't think this is actually required, if the depth range values are different from the ones stored in the context, we already flush and trigger _NEW_VIEWPORT in set_depth_range_no_notify(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 2 -- 1 file

Re: [Mesa-dev] [PATCH] swr: invalidate attachment on transition change

Reviewed-by: Tim Rowley > On Jun 20, 2017, at 11:42 AM, George Kyriazis > wrote: Consider the following RT attachment order: 1. Attach surfaces attachments 0 & 1, and

Re: [Mesa-dev] [PATCH mesa] egl: simplify dri_config conditionals

On 21 June 2017 at 13:25, Eric Engestrom wrote: > In the same spirit as 858f2f2ae6 (egl/dri2: ease srgb __DRIconfig > conditionals), let's merge dri_single_config and dri_double_config into > a single dri_config[2]. > > This moves the `if (double) dri_double_config else

Re: [Mesa-dev] [PATCH 3/5] st/dri: add a drirc workaround for Rocket League

Hi Marek, Adding Timothee Besset, who I believe did the Linux port. Is this something that can be addressed within the game itself? If the dev. team can roll a quick update it might be better to have that one in? -Emil On 20 June 2017 at 23:54, Marek Olšák wrote: > From:

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/android: Change order of EGLConfig generation (v2)

On 20 June 2017 at 23:03, Chad Versace wrote: > Many Android apps (such as Google's official NDK GLES2 example app), and > even portions the core framework code (such as SystemServiceManager in > Nougat), incorrectly choose their EGLConfig. They neglect to match the >

Re: [Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

Hi Dan, On 20 June 2017 at 16:18, Daniel Stone wrote: > Hey Emil, > A few bits from me, since this is actually lfrb's code ... > > On 20 June 2017 at 15:19, Emil Velikov wrote: >> Top-level comments >> >> Build POV: >> - Having the

Re: [Mesa-dev] [PATCH 2/2] radeonsi: unreference vertex buffers when destroying the context

Reviewed-by: Samuel Pitoiset On 06/22/2017 02:34 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c

[Mesa-dev] [PATCH 1/2] mesa: remove unused _NEW_TEXTURE composite state flags

--- src/mesa/main/mtypes.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 0cb002469b2..c88ca2e8e9c 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -4290,8 +4290,6 @@ struct gl_matrix_stack * Composite state flags

[Mesa-dev] [PATCH 2/2] mesa: do not trigger _NEW_TEXTURE_STATE in glActiveTexture()

This looks like useless because gl_context::Texture::CurrentUnit is not used by _mesa_update_texture_state() and friends. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/texstate.c

Re: [Mesa-dev] [PATCH] i915: Fix gl_Fragcoord interpolation

On Wed, Jun 21, 2017 at 03:13:22PM -0700, Ian Romanick wrote: > On 06/21/2017 10:38 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > gl_FragCoord contains the window coordinates so it seems to me that > > we should not use perspective

Re: [Mesa-dev] [PATCH 4/4] etnaviv: add support for snorm textures

On Wed, Jun 21, 2017 at 10:36:48PM +0200, Christian Gmeiner wrote: > Based on a patch from Wladimir J. van der Laan and untested due > to lack of hardware. Binary blob emits those formats if GPU supports > HALTI1 (faked with ibvivhook). Reviewed-by: Wladimir J. van der Laan >

Re: [Mesa-dev] [PATCH 3/4] etnaviv: add R8G8 texture support

On Wed, Jun 21, 2017 at 10:36:47PM +0200, Christian Gmeiner wrote: > Passes texwrap GL_ARB_texture_rg piglit (with faked full texture rg support). Reviewed-by: Wladimir J. van der Laan > > Signed-off-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

On Wed, Jun 21, 2017 at 10:36:46PM +0200, Christian Gmeiner wrote: > Passes all ext_texture_swizzle piglits. You seem to have dropped the check in etnaviv_screen.c for HALTI0 when texture formats have implicit non-identity swizzle. I do think that is necessary as those formats don't work on

[Mesa-dev] [PATCH 2/2] mesa: don't flush vertices in glClientActiveTexture

From: Marek Olšák --- src/mesa/main/texstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 0a2883f..bddd04b 100644 --- a/src/mesa/main/texstate.c +++ b/src/mesa/main/texstate.c @@ -344,21

[Mesa-dev] [PATCH 1/2] mesa: don't flag _NEW_ARRAY for GL_PRIMITIVE_RESTART_NV

From: Marek Olšák --- src/mesa/main/enable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index f1a9c7b..e1293f9 100644 --- a/src/mesa/main/enable.c +++ b/src/mesa/main/enable.c @@ -59,20 +59,21 @@

[Mesa-dev] [PATCH 1/2] radeonsi/gfx9: don't overallocate shader binaries

From: Marek Olšák It's not needed. The hw doesn't fetch ahead over page boundaries. --- src/gallium/drivers/radeonsi/si_shader.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 2/2] radeonsi: unreference vertex buffers when destroying the context

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index acf6fb4..75d2a1d 100644 ---

Re: [Mesa-dev] [PATCH 1/3] mesa/glthread: track buffer creation/destruction

On Thursday 22 June 2017, Timothy Arceri wrote: > From: Gregory Hainaut > > It would be used in next commit to allow asynchronous PBO transfer. > > The tracking saves the buffer name into a hash. Saving pointer > will be more complex as the buffer is created in

Re: [Mesa-dev] [PATCH] getteximage: fix returned error value when texture object is not found

On Thu, 2017-06-22 at 14:15 +0200, Samuel Pitoiset wrote: > So, you can use _mesa_lookup_texture_err() now (this helper throws a > INVALID_OPERATION error). > Oh, right. I'll change it. > Don't you need to also update some piglit tests to reflect that spec change? > Good point. I need to

Re: [Mesa-dev] [PATCH] getteximage: fix returned error value when texture object is not found

So, you can use _mesa_lookup_texture_err() now (this helper throws a INVALID_OPERATION error). Don't you need to also update some piglit tests to reflect that spec change? On 06/22/2017 01:59 PM, Juan A. Suarez Romero wrote: From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page

Re: [Mesa-dev] [PATCH 2/2] glsl: disable array splitting for AoA

Hi Jason, I think this patch is exposing a bug in nir_opt_copy_prop_vars with AoA. I've tried to figure out what was going on but got a bit lost in that code, any ideas/pointers appreciated. An example of the bug can be seen with:

Re: [Mesa-dev] [PATCH 1/4] etnaviv: add support for extended texture formats

On Wed, Jun 21, 2017 at 10:36:45PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- >

[Mesa-dev] [PATCH] getteximage: fix returned error value when texture object is not found

From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236: "An INVALID_VALUE error is generated if texture is not the name of an existing texture object." Same wording applies to the compressed version. But turns out this is a spec bug, and Khronos is fixing it for the next

Re: [Mesa-dev] [PATCH 2/2] anv/i965: drop copies of gen_device_info fields into brw_context

Acked-by: Iago Toral Quiroga On Tue, 2017-06-20 at 23:42 +0100, Lionel Landwerlin wrote: > This removes a few fields in brw_context that are copies of what's > already in gen_device_info. > > Signed-off-by: Lionel Landwerlin > --- >  

Re: [Mesa-dev] [PATCH 1/2] intel: common: break has_hiz_and_separate_stencil into 2 flags

Reviewed-by: Iago Toral Quiroga On Tue, 2017-06-20 at 23:42 +0100, Lionel Landwerlin wrote: > i965's brw_context needs to disable hiz under some debug flag, so > break this in 2 so we can configure this at runtime. > > Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On 22.06.2017 10:14, Michel Dänzer wrote: On 22/06/17 04:34 PM, Nicolai Hähnle wrote: On 22.06.2017 03:38, Rob Clark wrote: On Wed, Jun 21, 2017 at 8:15 PM, Marek Olšák wrote: On Wed, Jun 21, 2017 at 10:37 PM, Rob Clark wrote: On Tue, Jun 20, 2017 at

[Mesa-dev] [PATCH] mesa/st: Reduce the number of frontbuffer flush calls

The mesa state tracker was needlessly flushing the front buffer even if it hadn't been drawn to since the last flush. This was happening during glXSwapBuffers if we at some point previously had set that frontbuffer as a read- or draw renderbuffer, or at glFlush() or glFinish() if we at some point

[Mesa-dev] [PATCH 4/5] st/dri2 Plumb the flush_swapbuffer functionality through to dri3

Implement the state tracker manager drawable interface flush_swapbuffer method by plumping it through to dri3 if avilable. Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/dri/dri2.c | 16

[Mesa-dev] [PATCH 3/5] gallium/st: Add a method to flush outstanding swapbuffers

Add a state tracker interface method to flush outstanding swapbuffers, and add a call to it from the mesa state tracker during glFinish(). This doesn't strictly mean the outstanding swapbuffers have actually finished executing but is sufficient for glFinish() to be able to be used as a replacement

[Mesa-dev] [PATCH 5/5] dri3: Use SwapBuffer flips for back- and fake front

Use flips for back- and fake front buffers. This might lead to fake front and real front being shared if the hardware is page-flip capable. In any case it will save a full-drawable copy and also the subsequent wait for the X server to submit that copy to hardware if front-buffer reading or

[Mesa-dev] [PATCH 1/5] dri3: Wait for all pending swapbuffers to be scheduled before touching the front

This implements a wait for glXWaitGL, glXCopySubBuffer, dri flush_front and creation of fake front until all pending SwapBuffers have been committed to hardware. Among other things this fixes piglit glx-copy-sub-buffers on dri3. Signed-off-by: Thomas Hellstrom ---

[Mesa-dev] [PATCH 2/5] dri: Add a flushSwapBuffers method to the image loader extension

This method may be used by dri drivers to make sure all outstanding buffer swaps have been flushed to hardware. Also add a dri3 implementation. Signed-off-by: Thomas Hellstrom --- include/GL/internal/dri_interface.h | 16 +++- src/glx/dri3_glx.c

[Mesa-dev] [PATCH 0/5] dri3, gallium: Correctness and performance fixes

A patch series that deals with dri3 correctness- and performance fixes. The corectness fixes attempts to deal with the fact that we need to wait for all pending swapbuffers before we touch the front buffer. Otherwise a front buffer change may be overwritten by a pending swapbuffer when it was

Re: [Mesa-dev] [PATCH 3/3] glsl: relax loop unrolling restrictions

On 22/06/17 18:46, Samuel Pitoiset wrote: Here's a shader-db report: https://pastebin.com/raw/QBMnF2pv This doesn't sound like a total win actually... I'm surprised to see this. I thought we pretty much unrolled everything already, although maybe that was what happened after NIR unrolling.

[Mesa-dev] [PATCH 2/3] mesa/glthread: add tracking of PBO binding

From: Gregory Hainaut In gl core, buffer must be reserved first by CreateBuffers/GenBuffers to be valid. v4: update comments based on Nicolai review Signed-off-by: Gregory Hainaut --- src/mesa/main/marshal.c | 36

[Mesa-dev] [PATCH 1/3] mesa/glthread: track buffer creation/destruction

From: Gregory Hainaut It would be used in next commit to allow asynchronous PBO transfer. The tracking saves the buffer name into a hash. Saving pointer will be more complex as the buffer is created in BindBuffer due to IsBuffer insanity. Perf wise DeleteBuffers is

[Mesa-dev] RESEND v6 asynchronous pbo transfer with glthread

I rebased this on master to test if it made any difference on top of Mareks glthread updates for Civ6 (since it reduces some syncs there). It didn't make any noticable difference but since its been almost 2 months since Gregory send it, I thought I might as well resend as it didn't get any

[Mesa-dev] [PATCH 3/3] mapi/glthread: generate asynchronous code for PBO transfer

From: Gregory Hainaut Improve speed on PCSX2 v2: Add ppbo/ubpo status in XML file Disable variable parameter (as the pointer would be a fixed offset) v3: split buffer tracking into separate patches. use 'goto fallback_to_sync' when asynchronous transfer isn't

[Mesa-dev] [PATCH 3/2] ac/nir: assert printfs will fit

--- src/amd/common/ac_nir_to_llvm.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3a26668..b32a9f5 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@

[Mesa-dev] [Bug 101556] [llvmpipe] crashes when GL context is created and a previous context was shared

https://bugs.freedesktop.org/show_bug.cgi?id=101556 --- Comment #1 from Florian Link --- I reverted the commit from https://github.com/mesa3d/mesa/commit/043883647acaee0b2c67c1c6b496404ebb4e8d67 and then the crash is gone. The problem seems to be: stw_context.c: line

[Mesa-dev] [Bug 101556] [llvmpipe] crashes when GL context is created and a previous context was shared

https://bugs.freedesktop.org/show_bug.cgi?id=101556 Bug ID: 101556 Summary: [llvmpipe] crashes when GL context is created and a previous context was shared Product: Mesa Version: 17.1 Hardware: Other OS:

[Mesa-dev] [st/va] Fix leak in VAAPI subpictures

From: Chandu Babu N Subject: [PATCH] [st/va] Fix leak in VAAPI subpictures sampler view allocated in vaAssociateSubpicture is not cleared in vaiDeassociateSubpicture. Reviewed-by: Christian König --- src/gallium/state_trackers/va/subpicture.c | 1 + 1

Re: [Mesa-dev] radeonsi: ppc64 glamor backtrace

On 22/06/17 05:58 PM, Jack Mitchell wrote: > On 22/06/17 03:32, Michel Dänzer wrote: >> On 22/06/17 02:56 AM, Grazvydas Ignotas wrote: >>> Looks like nobody tested radeonsi on BE for 5 months at least. You can >>> try the attached patch, but I suspect there will be other places like >>> this... >

Re: [Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

On Thu, 2017-06-22 at 09:27 +1000, Timothy Arceri wrote: > > On 22/06/17 02:41, Juan A. Suarez Romero wrote: > > On Wed, 2017-06-21 at 20:24 +1000, Timothy Arceri wrote: > > > On 21/06/17 18:13, Juan A. Suarez Romero wrote: > > > > link_xfb_stride_layout_qualifiers() can be called multiple times,

Re: [Mesa-dev] radeonsi: ppc64 glamor backtrace

On 22/06/17 03:32, Michel Dänzer wrote: > On 22/06/17 02:56 AM, Grazvydas Ignotas wrote: >> Looks like nobody tested radeonsi on BE for 5 months at least. You can >> try the attached patch, but I suspect there will be other places like >> this... This got me further but it now looks like

Re: [Mesa-dev] [PATCH 3/3] glsl: relax loop unrolling restrictions

Here's a shader-db report: https://pastebin.com/raw/QBMnF2pv This doesn't sound like a total win actually... For now, patches 1&2 are: Reviewed-by: Samuel Pitoiset On 06/21/2017 12:12 PM, Timothy Arceri wrote: The main reason these restriction exist is because

[Mesa-dev] [Bug 100259] [EGL] [GBM] undefined reference to `gbm_bo_create_with_modifiers'

https://bugs.freedesktop.org/show_bug.cgi?id=100259 --- Comment #19 from kusayu --- Arch Linux still broken. CXXLDvulkan/libvulkan_intel.la vulkan/.libs/libvulkan_common.a(vulkan_libvulkan_common_la-anv_device.o): In function `anv_EnumeratePhysicalDevices':

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On 06/21/2017 03:34 PM, Timothee Besset wrote: On Wed, Jun 21, 2017 at 4:50 AM, Samuel Pitoiset > wrote: On 06/21/2017 11:48 AM, Marek Olšák wrote: On Jun 21, 2017 8:46 AM, "Samuel Pitoiset"

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On 22/06/17 04:34 PM, Nicolai Hähnle wrote: > On 22.06.2017 03:38, Rob Clark wrote: >> On Wed, Jun 21, 2017 at 8:15 PM, Marek Olšák wrote: >>> On Wed, Jun 21, 2017 at 10:37 PM, Rob Clark wrote: On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák

Re: [Mesa-dev] [PATCH] nv50/ir: Properly fold constants in SPLIT operation

I think we never split values that are < 64-bit wide, as the RA pass does not support < 32-bit wide values. And 64-bit values aren’t used that often, I would guess. Does adding the Fixes: tag here work, or should I send a new version? Fixes: b7d9677d ("nv50/ir: constant fold OP_SPLIT") On 02:46

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

On 06/22/2017 01:54 AM, Marek Olšák wrote: On Tue, Jun 20, 2017 at 10:56 PM, Samuel Pitoiset wrote: On 06/20/2017 10:53 PM, Samuel Pitoiset wrote: I have just tested this patch with Hero Siege, it still crashes. As you said, it's definitely a multithreading

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On 21.06.2017 00:54, Marek Olšák wrote: Hi, This series updates pipe loaders so that flags such as drirc options can be passed to create_screen(). I have compile-tested everything except clover. The first pipe_screen flag is a drirc option to fix incorrect grass rendering in Rocket League for

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On 22.06.2017 03:38, Rob Clark wrote: On Wed, Jun 21, 2017 at 8:15 PM, Marek Olšák wrote: On Wed, Jun 21, 2017 at 10:37 PM, Rob Clark wrote: On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote: Hi, This series updates pipe loaders so

Re: [Mesa-dev] [PATCH 3/3] glsl: relax loop unrolling restrictions

On 21.06.2017 12:12, Timothy Arceri wrote: The main reason these restriction exist is because glsl the loop unrolling pass is super slow with large loops. be5f27a84d0d fixed things so that expression trees were counted against the limit, however it left the limit as max_iterations * 5 which is

Re: [Mesa-dev] [PATCH 22/31] mesa: don't flag _NEW_TRANSFORM for st/mesa if possible

On 13/06/17 01:55 AM, Marek Olšák wrote: > From: Marek Olšák This broke piglit spec@glsl-1.20@execution@clipping@fixed-clip-enables on my Kaveri: Probe color at (200,75) Expected: 0.00 0.00 0.00 0.00 Observed: 1.00 1.00 1.00 1.00 Test

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák sizeof(struct si_shader_key): Before reverting the 2 commits: 120 bytes After reverting the 2 commits: 128 bytes With #pragma pack: 107 bytes I'm not sure if memcmp with a byte-aligned size is a good idea.

Re: [Mesa-dev] [PATCH 4/4] radeonsi/gfx9: enable DCC fast clear

For the series: Reviewed-by: Nicolai Hähnle On 20.06.2017 19:06, Marek Olšák wrote: From: Marek Olšák It seems to work now. --- src/gallium/drivers/radeon/r600_texture.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radeonsi: don't emit partial flushes at the end of IBs (v2)

On 20.06.2017 16:06, Marek Olšák wrote: From: Marek Olšák The kernel sort of does the same thing with fences. v2: do emit partial flushes on SI Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_hw_context.c | 14

Re: [Mesa-dev] [PATCH 02/30] i965/miptree: Rename the non_msrt_mcs functions to _ccs

On Fri, Jun 16, 2017 at 03:41:24PM -0700, Jason Ekstrand wrote: > While we're here, we also make the two support checks static since there > are no users outside intel_mipmap_tree.c. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c |

Re: [Mesa-dev] [PATCH 00/11] glthread cleanup, 4 whitelisted games!

On 22/06/17 11:02, Marek Olšák wrote: Hi, This series: - cleans up glthread, mainly switches the implementation to u_queue and rearranges it so that it looks like gallium/u_threaded_context - adds "performance" counters for monitoring glthread behavior and display them on the gallium HUD

<    1   2