Re: [Mesa-dev] [PATCH v2 3/5] anv: wire up vk_errorf macro to do debug reporting

On 09/07/2017 07:56 PM, Jason Ekstrand wrote: On Mon, Aug 28, 2017 at 10:44 PM, Tapani Pälli > wrote: Signed-off-by: Tapani Pälli > ---

Re: [Mesa-dev] [PATCH 08/10] drirc: Don't expose 10 bpc visuals/configs to gnome-shell.

On 08/09/17 12:26 AM, Marek Olšák wrote: > [+ Dave] > > We can also ignore gnome-shell in Mesa for now and let the gnome-shell > maintainers fix the issue in gnome-shell. Indeed, that would be better. IIUC, with this workaround, all content composited by gnome-shell will effectively use only 8

Re: [Mesa-dev] Mesa (master): mesa/st/tests: Fix classic build regressions introduced with 7be6d8fe12

On 07/09/17 09:14 PM, Nicolai Hähnle wrote: > Module: Mesa > Branch: master > Commit: ab16538b8353aadce97962b002730dd1a869dc99 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=ab16538b8353aadce97962b002730dd1a869dc99 > > Author: Gert Wollny > Date: Wed Sep 6

Re: [Mesa-dev] [PATCH] gallivm: fix gather implementation a bit

On 09/07/2017 10:16 AM, srol...@vmware.com wrote: From: Roland Scheidegger gather is defined in terms of bilinear filtering, just without the filtering part. However, there's actually some subtle differences required in our implementation, because we use some tricks to

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: enable PIPE_CAP_QUERY_PIPELINE_STATISTICS

Both look OK to me. Reviewed-by: Brian Paul On 09/07/2017 07:00 PM, srol...@vmware.com wrote: From: Roland Scheidegger This was implemented since forever, but not enabled. It passes all piglit tests except one, arb_pipeline_statistics_query-frag. The

Re: [Mesa-dev] [PATCH] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

On Thu, Sep 7, 2017 at 5:50 PM, Francisco Jerez wrote: > Currently the liveness analysis pass would extend a live interval up > to the top of the program when no unconditional and complete > definition of the variable is found that dominates all of its uses. > > This can

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_indirect_parameters

Hey Pam! A quick skim through this looks fairly good. I'll be honest, I expected to have some quick comments on the v1 but I'm not seeing anything immediately. That said, I've got to think about it fairly hard to convince myself that it's actually correct. The i965 drawing logic isn't really

[Mesa-dev] [Bug 102597] [Regression] mpv, high rendering times (two to three times higher)

https://bugs.freedesktop.org/show_bug.cgi?id=102597 Kenneth Graunke changed: What|Removed |Added Status|NEW |NEEDINFO ---

Re: [Mesa-dev] [PATCH] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

On Thu, Sep 7, 2017 at 5:50 PM, Francisco Jerez wrote: > Currently the liveness analysis pass would extend a live interval up > to the top of the program when no unconditional and complete > definition of the variable is found that dominates all of its uses. > > This can

[Mesa-dev] [PATCH 1/2] llvmpipe: enable PIPE_CAP_QUERY_PIPELINE_STATISTICS

From: Roland Scheidegger This was implemented since forever, but not enabled. It passes all piglit tests except one, arb_pipeline_statistics_query-frag. The reason is that the test (for drawing a 10x10 rect) expects between 100 and 150 pixel shader invocations. But since

[Mesa-dev] [PATCH 2/2] llvmpipe, draw: improve shader cache debugging

From: Roland Scheidegger With GALLIVM_DEBUG=perf set, output the relevant stats for shader cache usage whenever we have to evict shader variants. Also add some output when shaders are deleted (but not with the perf setting to keep this one less noisy). While here, also don't

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

Jason Ekstrand writes: > On Wed, Sep 6, 2017 at 3:58 PM, Chema Casanova > wrote: > >> Hi Connor and Curro, >> >> On 28/08/17 12:24, Alejandro Piñeiro wrote: >> > On 27/08/17 20:24, Connor Abbott wrote: >> >> Hi, >> >> >> >> On Aug 25, 2017 9:28 AM,

[Mesa-dev] [PATCH] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

Currently the liveness analysis pass would extend a live interval up to the top of the program when no unconditional and complete definition of the variable is found that dominates all of its uses. This can lead to a serious performance problem in shaders containing many partial writes, like

Re: [Mesa-dev] [PATCH] ttn: Fix out-of-bounds accesses since the always-2D-constants change.

This fixes a crash from glTexImage2D() at startup for all EFL applications on rpi3. Thanks, Tested-by: Derek Foreman On 2017-09-07 12:17 PM, Eric Anholt wrote: Only one of the three checks for dim was updated, so we would try to set a UBO buffer index source value on

Re: [Mesa-dev] [RFC] NIR serialization

On Thu, Sep 7, 2017 at 5:09 PM, Rob Clark wrote: > On Thu, Sep 7, 2017 at 7:26 PM, Jordan Justen > wrote: > > On 2017-09-06 14:12:41, Daniel Schürmann wrote: > >> Hello together! > >> Recently, we had a small discussion (off the list) about the

Re: [Mesa-dev] [RFC] NIR serialization

On Thu, Sep 7, 2017 at 7:26 PM, Jordan Justen wrote: > On 2017-09-06 14:12:41, Daniel Schürmann wrote: >> Hello together! >> Recently, we had a small discussion (off the list) about the NIR >> serialization, which was previously discussed in [RFC] ARB_gl_spirv and >>

Re: [Mesa-dev] [PATCH v2] i965/fs: Add remove_extra_rounding_modes optimization

On Tue, Aug 29, 2017 at 11:54 PM, Alejandro Piñeiro wrote: > Although from SPIR-V point of view, rounding modes are attached to the > operation/destination, on i965 it is a status, so we don't need to > explicitly set the rounding mode if the one we want is already set. > >

Re: [Mesa-dev] [PATCH 14/47] i965/fs: Set stride 2 when dealing with 16-bit floats/ints

On Thu, Aug 24, 2017 at 6:54 AM, Alejandro Piñeiro wrote: > From: Jose Maria Casanova Crespo > > From Skylake PRM, Volume 07 3D Media GPGPU, Section Register Region > Restrictions, SubSection 5. Special Cases for Word Operations (page > 781): > >

Re: [Mesa-dev] [RFC] NIR serialization

On 2017-09-06 14:12:41, Daniel Schürmann wrote: > Hello together! > Recently, we had a small discussion (off the list) about the NIR > serialization, which was previously discussed in [RFC] ARB_gl_spirv and > NIR backend for radeonsi. > > As this topic could be interesting to more people, I

[Mesa-dev] [Bug 102596] indirect_init.c not compiling, incomplete function

https://bugs.freedesktop.org/show_bug.cgi?id=102596 Cris changed: What|Removed |Added Summary|indirect_init.c not |indirect_init.c not

[Mesa-dev] [Bug 102597] [Regression] mpv, high rendering times (two to three times higher)

https://bugs.freedesktop.org/show_bug.cgi?id=102597 Bug ID: 102597 Summary: [Regression] mpv, high rendering times (two to three times higher) Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 102596] indirect_init.c not compiling

https://bugs.freedesktop.org/show_bug.cgi?id=102596 Bug ID: 102596 Summary: indirect_init.c not compiling Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v2 2/2] clover: Query and export half precision support

v2: PIPE_CAP_HALFS -> PIPE_SHADER_CAP_FP16 has_halfs -> has_halves Signed-off-by: Jan Vesely Reviewed-by: Francisco Jerez --- src/gallium/state_trackers/clover/api/device.cpp | 14 +++---

[Mesa-dev] [PATCH v2 1/2] gallium: Add PIPE_SHADER_CAP_FP16

Denotes native half precision float operations capability v2: PIPE_CAP_HALFS -> PIPE_SHADER_CAP_FP16 fix indentation Signed-off-by: Jan Vesely --- I modeled this after PIPE_SHARED_CAP_INTEGERS, but I might have missed a spot.

Re: [Mesa-dev] [PATCH] anv/allocator: Loosen the size restriction on imported BOs

Seems reasonable Reviewed-by: Jason Ekstrand On Wed, Aug 2, 2017 at 3:37 PM, Kevin Strasser wrote: > It's possible for a buffer manager to issue the application a BO that is > larger than what is requested. The out-of-bounds access issue would

[Mesa-dev] [PATCH] Android: Add LLVM support for Android P

The Android version in AOSP master has changed now to P, so we need to add LLVM flags for it. Duplicating the lines because I expect the version will get bumped at some point and diverge from O. Cc: Chih-Wei Huang Signed-off-by: Rob Herring ---

[Mesa-dev] [PATCH] radv: Actually check for vm faults.

The code can check for vm faults having happened. If we only do it on a hang we don't know when the faults happened. This changes the behavior to when the first VM faults is found, even without a hang. --- src/amd/vulkan/radv_debug.c | 10 +++--- src/amd/vulkan/radv_debug.h | 1 +

[Mesa-dev] [PATCH 2/2] radv/gfx9: allocate events from uncached VA space

From: Dave Airlie This copies what amdgpu-pro does, and allocates the memory for an event with an uncached mtype. This fixes hangs with: dEQP-VK.api.command_buffers.record_simul_use_primary Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 1/2] radv/winsys: use amdgpu_bo_va_op_raw.

From: Dave Airlie This is a precursor to the gfx9 fix to use uncached for the event memory. Move to the interface which allows setting the flags, but wrap it to avoid having to copy it around the place. Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 1/2] tgsi/scan: add a new pass that analyzes tess factor writes (v2)

From: Marek Olšák The pass tries to deduce whether tess factors are always written by all shader invocations. The implication for radeonsi is that it doesn't have to use a barrier near the end of TCS, and doesn't have to use LDS for passing the tess factors to the epilog.

[Mesa-dev] [PATCH 2/2] radeonsi: optimize TCS epilog when invocation 0 writes tess factors

From: Marek Olšák This removes the barrier and LDS stores and loads for tess factors when it's possible. The removal of the barrier seems more important to me though. In one shader, it removes 17 * 4 bytes from the shader binary. ---

Re: [Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

On 09/07/2017 11:56 AM, Emil Velikov wrote: On 7 September 2017 at 18:36, Kyle Brenneman wrote: On 09/07/2017 10:03 AM, Emil Velikov wrote: From: Emil Velikov Instead of having three, almost identical but not quite, _eglDebugReport*

[Mesa-dev] [PATCH 8/9] configure.ac: split the wayland client/server confusion

From: Emil Velikov At the moment wayland-clients, such as the Vulkan drivers were over-linking against libwayland-server.so. That went unnoticed, since both client and server code uses the wl*interface symbols, which are present in both libwayland-client.so and

[Mesa-dev] [PATCH 9/9] automake: adjust wayland-drm comment

From: Emil Velikov Vulkan does not depend on the library or any of the objects created in the process. Signed-off-by: Emil Velikov --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am

[Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

From: Emil Velikov The function is effectively a direct function call into libwayland-server.so Signed-off-by: Emil Velikov --- src/egl/wayland/wayland-drm/wayland-drm.c | 26 --

[Mesa-dev] [PATCH 1/9] wayland-drm: remove hardcoded enum wl_drm_format

From: Emil Velikov The exact same copy is generated in the client/server protocol header. Signed-off-by: Emil Velikov --- src/egl/wayland/wayland-drm/wayland-drm.h | 64 --- 1 file changed, 64 deletions(-)

[Mesa-dev] [PATCH 6/9] wayland-drm: constify the callbacks struct

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 14 +- src/egl/wayland/wayland-drm/wayland-drm.c | 4 ++-- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 5/9] wayland-drm: add wl_display/wl_resource forward declarations

From: Emil Velikov ... making the header self-contained. Signed-off-by: Emil Velikov --- src/egl/wayland/wayland-drm/wayland-drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/wayland/wayland-drm/wayland-drm.h

[Mesa-dev] [PATCH 2/9] wayland-drm: remove unused wayland_drm_buffer_get_{format, buffer}

From: Emil Velikov Unused anywhere throughout the codebase. We could start using it, although that contradicts to an evil plan* of mine. * Only wayland servers will make use of the static library, providing actual distinction between server vs client. Signed-off-by:

[Mesa-dev] [PATCH 4/9] configure.ac: define WL_HIDE_DEPRECATED at global scale

From: Emil Velikov Due to GCC feature described in previous commit, the expected deprecation warnings may be missing. Set the WL_HIDE_DEPRECATED macro which will omit the deprecated functionality, resulting in more distinct build issues. Patch is UNTESTED, see the

[Mesa-dev] [PATCH 3/9] wayland-drm: avoid deprecated use of struct wl_resource

From: Micah Fedke Wayland v1.2 with commit 1488c96a5db ("Add accessor functions for wl_resource and deprecate wl_client_add_resource") paves the way towards making wl_resource opaque. Namely, new helpers were introduced and the struct was annotated as deprecated.

Re: [Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

On 7 September 2017 at 18:36, Kyle Brenneman wrote: > On 09/07/2017 10:03 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Instead of having three, almost identical but not quite, >> _eglDebugReport* functions, simply fold them into one.

Re: [Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

On 09/07/2017 10:03 AM, Emil Velikov wrote: From: Emil Velikov Instead of having three, almost identical but not quite, _eglDebugReport* functions, simply fold them into one. While doing so drop the unnecessary arguments 'command' and 'objectLabel'. Former is

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

On Wed, Sep 6, 2017 at 3:58 PM, Chema Casanova wrote: > Hi Connor and Curro, > > On 28/08/17 12:24, Alejandro Piñeiro wrote: > > On 27/08/17 20:24, Connor Abbott wrote: > >> Hi, > >> > >> On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" >>

[Mesa-dev] [PATCH] ttn: Fix out-of-bounds accesses since the always-2D-constants change.

Only one of the three checks for dim was updated, so we would try to set a UBO buffer index source value on a nir_load_uniform, and wouldn't actually declare non-UBO uniforms. Fixes: 37dd8e8dee1d ("gallium: all drivers should accept two-dimensional constant buffer indexing") ---

Re: [Mesa-dev] [PATCH v4] glsl: Add 16-bit types

Reviewed-by: Jason Ekstrand On Sat, Sep 2, 2017 at 12:10 AM, Alejandro Piñeiro wrote: > From: Eduardo Lima Mitev > > Adds new INT16, UINT16 and FLOAT16 base types. > > The corresponding GL types for half floats were reused from the

Re: [Mesa-dev] [PATCH v2] nir/spirv: fix chain access with different index bit sizes

I'd probably go with u2u32 so we don't get sign-extension. Other than that, Reviewed-by: Jason Ekstrand On Mon, Aug 28, 2017 at 11:42 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > Currently we support 32-bit indexes/offsets all over the driver, so we >

Re: [Mesa-dev] [PATCH] nir/spirv: fix crashes when dereferencing a pointer for an OpVariable

On Tue, Aug 29, 2017 at 3:04 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > When creating a vtn_pointer for an OpVariable, the block_index and > offsets fields are null because there is not ssa to take the data > from. > > However, we can dereference that pointer when processing

Re: [Mesa-dev] [PATCH] nir/spirv: handle if's with same label in both branches

On Thu, Aug 24, 2017 at 8:16 AM, Juan A. Suarez Romero wrote: > When a conditional branch has the same labels in the "if" part and in the > "else" part, then we have the same cfg block, and it must be handled > once. > > Fixes: >

Re: [Mesa-dev] [PATCH 4/4] egl: use switch statements over if/else chain

On Thursday, 2017-09-07 17:03:53 +0100, Emil Velikov wrote: > From: Emil Velikov > > Shorter, explicit and consistent with the rest of the co debase. s/co debase/code base/ in the commit title of patch 2/4: s/since line/single line/ I don't have time to properly

Re: [Mesa-dev] [PATCH v2 0/5] VK_EXT_debug_report

Looks pretty good over-all. Most of the comments are on patch 1. I fully expect v3 to get merged. On Mon, Aug 28, 2017 at 10:44 PM, Tapani Pälli wrote: > Hi; > > Here's v2 of VK_EXT_debug_report with fixes to issues found by Jason > and for some issues that came up

Re: [Mesa-dev] [PATCH v2 3/5] anv: wire up vk_errorf macro to do debug reporting

On Mon, Aug 28, 2017 at 10:44 PM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/anv_allocator.c | 8 +--- > src/intel/vulkan/anv_device.c| 38 -- > >

Re: [Mesa-dev] [PATCH v2 2/5] anv: wire up anv_perf_warn macro to do debug reporting

On Mon, Aug 28, 2017 at 10:44 PM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/anv_device.c | 3 +- > src/intel/vulkan/anv_image.c | 12 ++-- > src/intel/vulkan/anv_private.h | 112

Re: [Mesa-dev] [PATCH v2 1/5] anv: implementation of VK_EXT_debug_report extension

On Thu, Sep 7, 2017 at 9:46 AM, Jason Ekstrand wrote: > On Mon, Aug 28, 2017 at 10:44 PM, Tapani Pälli > wrote: > >> Patch adds required functionality for extension to manage a list of >> application provided callbacks and handle debug reporting

Re: [Mesa-dev] [PATCH v2 1/5] anv: implementation of VK_EXT_debug_report extension

On Mon, Aug 28, 2017 at 10:44 PM, Tapani Pälli wrote: > Patch adds required functionality for extension to manage a list of > application provided callbacks and handle debug reporting from driver > and application side. > > v2: remove useless helper anv_debug_report_call

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

Hey Thomas, Thomas Hellstrom wrote on 07.09.2017 10:53: > This fixes a regression introduced with commit > eceb6710024716433069d705fbd873d6d136c2cc: > "mesa/st: Reduce the number of frontbuffer flush calls" > where we, after flushing the front buffer marked it as not-rendered-to, > the idea being

[Mesa-dev] [PATCH] gallivm: fix gather implementation a bit

From: Roland Scheidegger gather is defined in terms of bilinear filtering, just without the filtering part. However, there's actually some subtle differences required in our implementation, because we use some tricks to simplify coord wrapping for the two coords per

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

Hi Thomas, On 7 September 2017 at 09:53, Thomas Hellstrom wrote: > This fixes a regression introduced with commit > eceb6710024716433069d705fbd873d6d136c2cc: > "mesa/st: Reduce the number of frontbuffer flush calls" > where we, after flushing the front buffer marked it as

Re: [Mesa-dev] [PATCH mesa 3/6] r300: use ARRAY_SIZE macro

Reviewed-by: Marek Olšák Marek On Thu, Sep 7, 2017 at 12:21 PM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/gallium/drivers/r300/compiler/r300_fragprog_swizzle.c | 4 +++- > 1 file changed, 3

[Mesa-dev] [PATCH 2/4] egl: remove unneeded braces around since line if statements

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/main/eglcurrent.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/egl/main/eglcurrent.c b/src/egl/main/eglcurrent.c index

[Mesa-dev] [PATCH 1/4] egl: simplify _eglDebugReport* API

From: Emil Velikov Instead of having three, almost identical but not quite, _eglDebugReport* functions, simply fold them into one. While doing so drop the unnecessary arguments 'command' and 'objectLabel'. Former is identical to funcName, while the latter is already

[Mesa-dev] [PATCH 3/4] egl: use _eglError's 'msg' as an actual message in EGL_KHR_debug

From: Emil Velikov Seemingly, the original intent behind _eglError's 'msg' was aimed to provide a function name. At some point, people started using it the way EGL_KHR_debug's callback() message is meant to be used. Aka providing meaningful information to the

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

Reviewed-by: Marek Olšák Marek On Thu, Sep 7, 2017 at 10:53 AM, Thomas Hellstrom wrote: > This fixes a regression introduced with commit > eceb6710024716433069d705fbd873d6d136c2cc: > "mesa/st: Reduce the number of frontbuffer flush calls" > where we,

[Mesa-dev] [PATCH 4/4] egl: use switch statements over if/else chain

From: Emil Velikov Shorter, explicit and consistent with the rest of the co debase. Signed-off-by: Emil Velikov --- src/egl/main/eglapi.c | 59 --- 1 file changed, 28 insertions(+), 31

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

Reviewed-by: Bruce Cherniak > On Sep 7, 2017, at 3:53 AM, Thomas Hellstrom wrote: > > This fixes a regression introduced with commit > eceb6710024716433069d705fbd873d6d136c2cc: > "mesa/st: Reduce the number of frontbuffer flush calls" > where

Re: [Mesa-dev] [PATCH 08/10] drirc: Don't expose 10 bpc visuals/configs to gnome-shell.

[+ Dave] We can also ignore gnome-shell in Mesa for now and let the gnome-shell maintainers fix the issue in gnome-shell. Marek On Tue, Sep 5, 2017 at 7:01 AM, Mario Kleiner wrote: > Set 'expose_rgb10_configs' false when gnome-shell is the > client. > >

Re: [Mesa-dev] [PATCH 1/2] radeonsi: enable out-of-order rasterization when possible on VI and GFX9 dGPUs

On 07.09.2017 16:56, Marek Olšák wrote: +static bool si_out_of_order_rasterization(struct si_context *sctx) +{ + struct si_state_blend *blend = sctx->queued.named.blend; + struct si_state_dsa *dsa = sctx->queued.named.dsa; + + if (!sctx->screen->has_out_of_order_rast) +

Re: [Mesa-dev] [PATCH] ac/surface: add radeon_surf::has_stencil for convenience

Reviewed-by: Nicolai Hähnle On 07.09.2017 16:42, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_surface.c| 2 ++ src/amd/common/ac_surface.h| 1 + src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH v2 1/4] dri/image: Add a format modifier attributes query

On 5 September 2017 at 19:29, Jason Ekstrand wrote: > On Tue, Sep 5, 2017 at 10:14 AM, Emil Velikov > wrote: >> >> Hi Jason, >> >> On 5 September 2017 at 16:48, Jason Ekstrand wrote: >> >> > + GLboolean

Re: [Mesa-dev] [PATCH mesa 6/6] gallium/tests: use ARRAY_SIZE macro

Reviewed-by: Marek Olšák Marek On Thu, Sep 7, 2017 at 12:21 PM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/gallium/tests/graw/fs-fragcoord.c | 4 +++- > src/gallium/tests/graw/fs-frontface.c | 4

Re: [Mesa-dev] [PATCH 7/7] winsys/amdgpu: use the new raw CS API

BTW, this series is a prep work for Android fences. Marek On Wed, Sep 6, 2017 at 11:34 AM, Marek Olšák wrote: > From: Marek Olšák > > This also cleans things up. > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 165 > -- >

Re: [Mesa-dev] Mesa 17.1.9 release candidate

Hi all, For anyone wondering why a couple of commits are missing from the list, those have been squashed as applicable. Namely: > Charmaine Lee (1): > vbo: fix offset in minmax cache key Squashed with vbo: fix build errors on android > Jason Ekstrand (2): > anv/formats:

[Mesa-dev] [Bug 102573] fails to build on armel

https://bugs.freedesktop.org/show_bug.cgi?id=102573 --- Comment #1 from Emil Velikov --- Hmm the code in src/util/u_atomic.c should handle that. The code is omitted when the GCC_64BIT_ATOMICS_SUPPORTED test [in configure.ac] reports "it works". I don't have a armel

Re: [Mesa-dev] [PATCH 1/2] radeonsi: enable out-of-order rasterization when possible on VI and GFX9 dGPUs

>> +static bool si_out_of_order_rasterization(struct si_context *sctx) >> +{ >> + struct si_state_blend *blend = sctx->queued.named.blend; >> + struct si_state_dsa *dsa = sctx->queued.named.dsa; >> + >> + if (!sctx->screen->has_out_of_order_rast) >> + return

Re: [Mesa-dev] [PATCH 10/10] egl/dri2: Add Wayland+EGL support for RGB10 winsys buffers.

Hi Mario, On 5 September 2017 at 06:01, Mario Kleiner wrote: > Successfully tested under Weston 3.0, both with the new > (experimental) dmabuf+modifiers path, and the old buffer > import path. Photometer confirms 10 rgb bits from rendering > to display. > Can you

[Mesa-dev] [PATCH] ac/surface: add radeon_surf::has_stencil for convenience

From: Marek Olšák --- src/amd/common/ac_surface.c| 2 ++ src/amd/common/ac_surface.h| 1 + src/amd/vulkan/radv_device.c | 6 +++--- src/gallium/drivers/r600/evergreen_state.c | 2 +-

Re: [Mesa-dev] [PATCH 09/10] egl/x11: Match depth 30 RGB visuals to 32-bit RGBA EGLConfigs.

On 7 September 2017 at 01:51, Mario Kleiner wrote: > On 09/06/2017 03:18 PM, Eric Engestrom wrote: >> >> On Tuesday, 2017-09-05 07:01:13 +0200, Mario Kleiner wrote: >>> >>> Similar to the matching of 24 bit RGB visuals to 32-bit >>> RGBA EGLConfigs. >>> >>> Fixes

Re: [Mesa-dev] [PATCH 1/2] radeonsi: enable out-of-order rasterization when possible on VI and GFX9 dGPUs

On Thu, Sep 7, 2017 at 7:33 AM, Axel Davy wrote: > Hi, > > On 07/09/2017 00:35, Marek Olšák wrote: >> >> + /* Out-of-order rasterization can be enabled for these cases: >> +* >> +* - color-only rendering: >> +* + blending must be enabled

Re: [Mesa-dev] [PATCH 06/10] dri/common: Add option to disable exposure of 10 bpc color configs.

On 5 September 2017 at 06:01, Mario Kleiner wrote: > A few clients don't like RGB10X2 and RGB10A2 fbconfigs and > visuals. Add a new driconf option 'expose_rgb10_configs' to > allow per application enable/disable. > > The option defaults to enabled. > Most configs

Re: [Mesa-dev] [PATCH 01/10] i965/screen: Add basic support for rendering 10 bpc/depth 30 framebuffers.

Hi Mario, On 5 September 2017 at 06:01, Mario Kleiner wrote: > Expose formats which are supported at least back to Gen 5 Ironlake, > possibly further. Allow creation of 10 bpc winsys buffers for drawables. > > glxinfo now lists new RGBA 10 10 10 2/0 formats. > Works

Re: [Mesa-dev] [PATCH 1/9] tgsi/scan: add a new pass that analyzes tess factor writes

On Thu, Sep 7, 2017 at 2:24 PM, Nicolai Hähnle wrote: > On 07.09.2017 14:23, Nicolai Hähnle wrote: >> >> On 07.09.2017 12:55, Marek Olšák wrote: >>> >>> We can also say if gl_TessLevel* is written multiple times, then one >>> these must be true: >>> - there must not be a

[Mesa-dev] [Bug 102564] swr: GPU Caps Viewer crashes with any 3D demo

https://bugs.freedesktop.org/show_bug.cgi?id=102564 --- Comment #2 from Bruce Cherniak --- > Regression in 17.2.0. v17.1.8 is unaffected. I haven't had a chance to try it yet, but you're saying that 17.1.8 runs without crashing? That's helpful. Thanks. -- You are

[Mesa-dev] [PATCH] radv: add an assertion when pushing meta descriptor sets

Just to make sure we are using the set 0, because it's the only one which is saved/restored when doing meta operations. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] radeonsi: enable out-of-order rasterization when possible on VI and GFX9 dGPUs

Am 07.09.2017 00:35, schrieb Marek Olšák: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 143 +++-

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

On Thu, Sep 7, 2017, at 14:52, Nicolai Hähnle wrote: > On 07.09.2017 12:26, Dave Airlie wrote: > > > > > > On 7 Sep. 2017 6:34 pm, "Nicolai Hähnle" > > wrote: > > > > On 07.09.2017 09 :58, Bas Nieuwenhuizen wrote: > >

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

On 07.09.2017 12:26, Dave Airlie wrote: On 7 Sep. 2017 6:34 pm, "Nicolai Hähnle" > wrote: On 07.09.2017 09 :58, Bas Nieuwenhuizen wrote: I'm not really happy with this, what happens if a game actually

Re: [Mesa-dev] [PATCH 1/9] tgsi/scan: add a new pass that analyzes tess factor writes

On 07.09.2017 14:23, Nicolai Hähnle wrote: On 07.09.2017 12:55, Marek Olšák wrote: We can also say if gl_TessLevel* is written multiple times, then one these must be true: - there must not be a barrier between the writes - gl_TessLevel* writes aren't inside conditional blocks I see that these

Re: [Mesa-dev] [PATCH 1/9] tgsi/scan: add a new pass that analyzes tess factor writes

On 07.09.2017 12:55, Marek Olšák wrote: We can also say if gl_TessLevel* is written multiple times, then one these must be true: - there must not be a barrier between the writes - gl_TessLevel* writes aren't inside conditional blocks I see that these games use a barrier in TCS: - Hitman - Grid

Re: [Mesa-dev] [PATCH 2/2] mesa/st/tests: Fix regressions with libunwind enabled introduced with 7be6d8fe12

Hi Gert, A couple of small suggestions for the future. On 6 September 2017 at 20:24, Gert Wollny wrote: > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=102565 > > Add the according flags to link with libunwind. Please keep tags at the bottom of the summary. Fixes:

Re: [Mesa-dev] [PATCH] nir/spirv: handle if's with same label in both branches

This patch is still unreviewed. Gently ping if someone can take a look. Thanks in advance! J.A. On Thu, 2017-08-24 at 17:16 +0200, Juan A. Suarez Romero wrote: > When a conditional branch has the same labels in the "if" part and in the > "else" part, then we have the same cfg block,

Re: [Mesa-dev] [PATCH 2/2] mesa/st/tests: Fix regressions with libunwind enabled introduced with 7be6d8fe12

On 07.09.2017 08:38, Michel Dänzer wrote: On 07/09/17 04:24 AM, Gert Wollny wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=102565 Add the according flags to link with libunwind. --- src/mesa/state_tracker/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH mesa 1/6] glx: use ARRAY_SIZE macro

On 07/09/2017 11:21, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/glx/driwindows_glx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/driwindows_glx.c b/src/glx/driwindows_glx.c index 02d95e7bfd..85525431bf 100644 ---

Re: [Mesa-dev] [PATCH 1/9] tgsi/scan: add a new pass that analyzes tess factor writes

We can also say if gl_TessLevel* is written multiple times, then one these must be true: - there must not be a barrier between the writes - gl_TessLevel* writes aren't inside conditional blocks I see that these games use a barrier in TCS: - Hitman - Grid Autosport - Tomb Raider All constraints

Re: [Mesa-dev] [PATCH] st/mesa: skip draw calls with pipe_draw_info::count == 0

On Thu, Sep 7, 2017 at 2:27 AM, Timothy Arceri wrote: > On 07/09/17 08:37, Marek Olšák wrote: >> >> Ping. >> >> On Sat, Sep 2, 2017 at 1:34 AM, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> Bugzilla:

Re: [Mesa-dev] [PATCH] radv: use simpler indirect packet 3 if possible.

On 7 Sep. 2017 6:34 pm, "Nicolai Hähnle" wrote: On 07.09.2017 09:58, Bas Nieuwenhuizen wrote: > I'm not really happy with this, what happens if a game actually uses > e.g. indirect count in a secondary cmd buf? > Note that some packets that require fetching data in the CP

Re: [Mesa-dev] [PATCH 1/2] radeonsi: set a per-buffer flag that disables inter-process sharing (v4)

Am 07.09.2017 um 12:14 schrieb Marek Olšák: On Sep 7, 2017 12:08 PM, "Christian König" > wrote: Am 07.09.2017 um 11:23 schrieb Michel Dänzer: On 01/09/17 07:40 PM, Christian König wrote: Am 01.09.2017 um

[Mesa-dev] [PATCH mesa 6/6] gallium/tests: use ARRAY_SIZE macro

Signed-off-by: Eric Engestrom --- src/gallium/tests/graw/fs-fragcoord.c | 4 +++- src/gallium/tests/graw/fs-frontface.c | 4 +++- src/gallium/tests/graw/fs-write-z.c | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH mesa 2/2] mesa: allow user to set MESA_NO_ERROR=0

On Thursday, 2017-09-07 10:13:48 +0100, Emil Velikov wrote: > Hi Eric, can you update the wording in docs/envvars.html to reflect the > change. Yes indeed, I forgot that; done now: 6c2e0527ea7a387d3e19 > > Thanks > Emil ___ mesa-dev mailing list

[Mesa-dev] [PATCH mesa 4/6] swr: use ARRAY_SIZE macro

Signed-off-by: Eric Engestrom --- src/gallium/drivers/swr/rasterizer/memory/StoreTile.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/memory/StoreTile.h

[Mesa-dev] [PATCH mesa 1/6] glx: use ARRAY_SIZE macro

Signed-off-by: Eric Engestrom --- src/glx/driwindows_glx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/driwindows_glx.c b/src/glx/driwindows_glx.c index 02d95e7bfd..85525431bf 100644 --- a/src/glx/driwindows_glx.c +++

  1   2   >