Re: [Mesa-dev] [PATCH 1/7] nir: add bindless to nir data

2018-02-19 Thread Iago Toral
This patch is: Reviewed-by: Iago Toral Quiroga On Tue, 2018-02-20 at 14:42 +1100, Timothy Arceri wrote: > --- > src/compiler/glsl/glsl_to_nir.cpp | 1 + > src/compiler/nir/nir.h| 6 ++ > 2 files changed, 7 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] glsl: Parse 'layout' as a token with advanced blending or bindless

2018-02-19 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2018-02-19 at 21:28 -0800, Kenneth Graunke wrote: > Both KHR_blend_equation_advanced and ARB_bindless_texture provide > layout qualifiers, and are exposed in compatibility contexts. We > need to parse the layout qualifier as a token in

[Mesa-dev] [PATCH] configure.ac: pthread-stubs not present on OpenBSD

2018-02-19 Thread Jonathan Gray
pthread-stubs is no longer required on OpenBSD and has been removed. libpthread parts involved moved to libc. Signed-off-by: Jonathan Gray Cc: 17.3 18.0 --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] ac/radv: remove total_vertices variable

2018-02-19 Thread Dave Airlie
From: Dave Airlie This just removes an unneeded variable. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 6/7] radeonsi/nir: add initial bindless image support

2018-02-19 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 41 +++- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index c2036a1509..e3e71c6eb6 100644 ---

Re: [Mesa-dev] [PATCH 3/3] meson: Only GLX_USE_TLS when glx is in use

2018-02-19 Thread Alexander von Gluck IV
February 19, 2018 3:00 PM, "Emil Velikov" wrote: > On 19 February 2018 at 18:40, Alexander von Gluck IV >> Thanks to Dylan for figuring this one out. >> >> This was discussed previously on the ML >> " >> This can be applied to all GLX implementations, and in autotools

[Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

2018-02-19 Thread Timothy Arceri
We also fix the base_index for bindless by using the driver location. --- src/amd/common/ac_nir_to_llvm.c | 14 +++--- src/amd/common/ac_shader_abi.h | 3 ++- src/gallium/drivers/radeonsi/si_shader_nir.c | 2 +- 3 files changed, 14 insertions(+), 5

[Mesa-dev] radv prep for removing tess specific user sgprs

2018-02-19 Thread Dave Airlie
These are just some cleanups that popped out of a series I was working on to remove all the tcs/tes user sgprs stuff. I've got the full patchset working on VI, just need to test on Vega now. Dave. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 4/5] radv/tess: don't need to look in constant for vertices_per_patch

2018-02-19 Thread Dave Airlie
From: Dave Airlie This just avoids passing this value via user sgprs. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 5 - src/amd/vulkan/radv_pipeline.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] ac/nir: to integer the args to bcsel.

2018-02-19 Thread Dave Airlie
From: Dave Airlie dEQP-VK.tessellation.invariance.outer_edge_symmetry.triangles_equal_spacing_ccw was hitting an llvm assert due to one value being an int and the other a float. This just casts both values to integer and fixes the test. Fixes:

[Mesa-dev] [PATCH 5/5] radv: don't send num_tcs_input_cp to sgprs.

2018-02-19 Thread Dave Airlie
From: Dave Airlie We never use it in the shaders. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH 3/5] ac/radv: cleanup some tcs output values access

2018-02-19 Thread Dave Airlie
From: Dave Airlie Just consolidates some code to make it easier to change. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH] glsl: Parse 'layout' as a token with advanced blending or bindless

2018-02-19 Thread Kenneth Graunke
Both KHR_blend_equation_advanced and ARB_bindless_texture provide layout qualifiers, and are exposed in compatibility contexts. We need to parse the layout qualifier as a token in order for those to work, but forgot to extend this check. ARB_shader_image_load_store would need a similar

[Mesa-dev] [PATCH 4/7] st/glsl_to_nir: set driver location for bindless images and samplers

2018-02-19 Thread Timothy Arceri
--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 760aee1af6..47f369a889 100644 --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp +++

[Mesa-dev] [PATCH 7/7] radeonsi/nir: add initial bindless sampler support

2018-02-19 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index e3e71c6eb6..3294019cea 100644 ---

[Mesa-dev] [PATCH 2/7] radeonsi/nir: set uses_bindless_images for images

2018-02-19 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index ea9f2076da..974068b88f 100644 ---

[Mesa-dev] [PATCH 1/7] nir: add bindless to nir data

2018-02-19 Thread Timothy Arceri
--- src/compiler/glsl/glsl_to_nir.cpp | 1 + src/compiler/nir/nir.h| 6 ++ 2 files changed, 7 insertions(+) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 7a9d15015e..49d66c173c 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++

[Mesa-dev] [PATCH 3/7] radeonsi/nir: set uses_bindless_samplers for samplers

2018-02-19 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 974068b88f..7a5acd3ff1 100644 --- a/src/gallium/drivers/radeonsi/si_shader_nir.c +++

[Mesa-dev] [PATCH 1/5] ac/radv: don't mark tess inner as used if we don't use it.

2018-02-19 Thread Dave Airlie
From: Dave Airlie This just avoids marking it as a used output if we don't actually use it. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

Re: [Mesa-dev] clover: Fix build after llvm r325155 and r325160

2018-02-19 Thread Jan Vesely
On Fri, 2018-02-16 at 05:49 +0100, Dieter Nützel wrote: > Hello Jan, > > something semilar is needed fro libclc, too. > > LLVM-CC nvptx64--nvidiacl/lib/geometric/dot.cl.bc > ./utils/prepare-builtins.cpp:108:3: error: no matching function for call > to 'WriteBitcodeToFile' >

[Mesa-dev] [ANNOUNCE] mesa 17.3.5

2018-02-19 Thread Emil Velikov
Mesa 17.3.5 is now available. This is a emergency release fixing major a issue in the RADV driver. Emil Velikov (3): docs: add sha256 checksums for 17.3.4 Update version to 17.3.5 docs: add release notes for 17.3.5 James Legg (1): ac/nir: Fix conflict resolution typo in

[Mesa-dev] [AppVeyor] mesa 17.3 #6956 completed

2018-02-19 Thread AppVeyor
Build mesa 6956 completed Commit 2529d77179 by Emil Velikov on 2/19/2018 10:01 PM: docs: add release notes for 17.3.5\n\nSigned-off-by: Emil Velikov Configure your notification preferences

Re: [Mesa-dev] [ANNOUNCE] mesa 17.3.4

2018-02-19 Thread Bas Nieuwenhuizen
On Mon, Feb 19, 2018 at 6:28 PM, Emil Velikov wrote: > On 17 February 2018 at 15:04, Bas Nieuwenhuizen > wrote: >> (-mesa-announce + Mark, Dave and James) >> >> Hi Emil, >> >> radv is broken for nearly all commercial games in 17.3.4. The cause

Re: [Mesa-dev] Adding a SPIR-V target to libclc

2018-02-19 Thread Jan Vesely
On Thu, 2018-02-15 at 22:50 -0800, Francisco Jerez wrote: > Jan Vesely writes: > > > On Thu, 2018-02-15 at 20:36 -0800, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > On Thu, 2018-02-08 at 15:56 -0800, Francisco Jerez wrote: > > >

Re: [Mesa-dev] [PATCH 3/3] meson: Only GLX_USE_TLS when glx is in use

2018-02-19 Thread Emil Velikov
On 19 February 2018 at 18:40, Alexander von Gluck IV wrote: > February 19, 2018 12:25 PM, "Alexander von Gluck IV" > wrote: > >> --- >> meson.build | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/meson.build

Re: [Mesa-dev] [PATCH 3/3] meson: Only GLX_USE_TLS when glx is in use

2018-02-19 Thread Alexander von Gluck IV
February 19, 2018 12:25 PM, "Alexander von Gluck IV" wrote: > --- > meson.build | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 6fc7ec7fc9..54572a5bb8 100644 > --- a/meson.build > +++ b/meson.build > @@ -331,7

Re: [Mesa-dev] [PATCH 4/6] i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2

2018-02-19 Thread Chad Versace
On Wed 24 Jan 2018, Jason Ekstrand wrote: > The old code made a new miptree that referenced the same BO as the > renderbuffer and just trusted in the memory aliasing to work. There are > only two ways in which the new miptree is liable to differ from the one > in the renderbuffer and neither of

[Mesa-dev] [PATCH 1/3] hgl: Correct glheader.h context inline with glx

2018-02-19 Thread Alexander von Gluck IV
--- src/hgl/GLDispatcher.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hgl/GLDispatcher.h b/src/hgl/GLDispatcher.h index 8aaf58a623..7a4bcd3329 100644 --- a/src/hgl/GLDispatcher.h +++ b/src/hgl/GLDispatcher.h @@ -15,7 +15,7 @@ #include #include -#include

[Mesa-dev] [PATCH 2/3] haiku-softpipe: Build fix, drop un-needed flip

2018-02-19 Thread Alexander von Gluck IV
--- .../targets/haiku-softpipe/GalliumContext.cpp | 25 -- 1 file changed, 25 deletions(-) diff --git a/src/gallium/targets/haiku-softpipe/GalliumContext.cpp b/src/gallium/targets/haiku-softpipe/GalliumContext.cpp index 0356f65417..3922fa61b2 100644 ---

[Mesa-dev] [PATCH 3/3] meson: Only GLX_USE_TLS when glx is in use

2018-02-19 Thread Alexander von Gluck IV
--- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 6fc7ec7fc9..54572a5bb8 100644 --- a/meson.build +++ b/meson.build @@ -331,7 +331,6 @@ if with_egl and not (with_platform_drm or with_platform_surfaceless) endif endif

Re: [Mesa-dev] [PATCH 1/6] i965/state: Ignore intel_obj->_Format for depth/stencil and ETC2

2018-02-19 Thread Chad Versace
On Wed 24 Jan 2018, Jason Ekstrand wrote: > We're about to start letting the intel_obj->_Format be the "real" > texture format. For depth/stencil textures, this may be a combined > depth stencil format. For ETC2 on gen7 and earlier, this will be the > actual ETC2 format. This makes a bit more

Re: [Mesa-dev] [PATCH] anv/entrypoints: make vkGetDeviceProcAddr return NULL for instance commands

2018-02-19 Thread Jason Ekstrand
On Mon, Feb 19, 2018 at 8:35 AM, Emil Velikov wrote: > On 19 February 2018 at 10:54, Iago Toral Quiroga > wrote: > > The Vulkan working group has recently clarified that this is the intended > > behavior and accepted spec language changes to make

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 Kenneth Graunke changed: What|Removed |Added Status|NEW |ASSIGNED

Re: [Mesa-dev] [ANNOUNCE] mesa 17.3.4

2018-02-19 Thread Emil Velikov
On 17 February 2018 at 15:04, Bas Nieuwenhuizen wrote: > (-mesa-announce + Mark, Dave and James) > > Hi Emil, > > radv is broken for nearly all commercial games in 17.3.4. The cause is > > commit ad764e365beb8a119369b97f5cb95fc7ea8c > Author: Bas Nieuwenhuizen

[Mesa-dev] [AppVeyor] mesa master #6955 failed

2018-02-19 Thread AppVeyor
Build mesa 6955 failed Commit f78fe98fff by Marek Olšák on 2/19/2018 4:55 PM: radeonsi: fix regression from 32-bit pointers on CI\n\nTested-by: Michel Dänzer Configure your notification preferences

Re: [Mesa-dev] [PATCH] anv/entrypoints: make vkGetDeviceProcAddr return NULL for instance commands

2018-02-19 Thread Emil Velikov
On 19 February 2018 at 10:54, Iago Toral Quiroga wrote: > The Vulkan working group has recently clarified that this is the intended > behavior and accepted spec language changes to make this clear. > --- > src/intel/vulkan/anv_entrypoints_gen.py | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] anv/entrypoints: make vkGetDeviceProcAddr return NULL for instance commands

2018-02-19 Thread Jason Ekstrand
Rb On February 19, 2018 02:54:57 Iago Toral Quiroga wrote: The Vulkan working group has recently clarified that this is the intended behavior and accepted spec language changes to make this clear. --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1

[Mesa-dev] [Bug 105132] glxSwapBuffers has no effect

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105132 --- Comment #5 from Michel Dänzer --- (In reply to Julien Isorce from comment #4) > The attached experimental patch builds and runs but > "xcb_poll_for_special_event" does not return any event [...] That's not surprising,

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #4 from Ilia Mirkin --- Specifically, the ext spec says, """ A draw-time error will be generated in the OpenGL API if an application attempts to render using an advanced blending equation without

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #3 from Ilia Mirkin --- The specification is available at https://www.khronos.org/registry/OpenGL/extensions/KHR/KHR_blend_equation_advanced.txt If you find the NVIDIA drivers doing something different than

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v4

2018-02-19 Thread Eric Engestrom
On Monday, 2018-02-19 11:20:37 +, Eric Engestrom wrote: > On Friday, 2018-02-16 14:27:03 -0600, Alexander von Gluck IV wrote: > > --- > > include/meson.build| 8 + > > meson.build| 16 +++--- > > src/egl/meson.build

[Mesa-dev] [Bug 105132] glxSwapBuffers has no effect

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105132 --- Comment #4 from Julien Isorce --- Created attachment 137438 --> https://bugs.freedesktop.org/attachment.cgi?id=137438=edit wip-not-working: poll special dri2 events As Scott also mentioned,

Re: [Mesa-dev] [PATCH] r600/sb: fix rotated register in while loop

2018-02-19 Thread Gert Wollny
Am Montag, den 19.02.2018, 14:06 +1000 schrieb Dave Airlie: > On 15 February 2018 at 01:26, Gert Wollny > wrote: > > Am Mittwoch, den 14.02.2018, 17:18 +1000 schrieb Dave Airlie: > > > From: Dave Airlie > > > > > > A bunch of CTS tests led me to write >

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #2 from Allan Sandfeld Jensen --- Note. I have been unable to get it to work at all in compatibility-mode desktop OpenGL. The following code only works in core mode: #ifdef GL_KHR_blend_equation_advanced

Re: [Mesa-dev] [PATCH 3/3] st/shader_cache: copy nir pointer to gl_program after deserializing

2018-02-19 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Feb 16, 2018 at 1:55 AM, Timothy Arceri wrote: > This fixes a crash when running the arb_get_program_binary-api-errors > piglit test twice. > --- > src/mesa/state_tracker/st_shader_cache.c | 6

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

2018-02-19 Thread James Zhu
On 2018-02-16 01:31 PM, Mark Thompson wrote: On 16/02/18 17:53, James Zhu wrote: Hi Mark, I couldn't reproduce the issue on my Polaris 11 to run mpv / ffmpeg about 1.5 hours. one terminal run: ffmpeg -y -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -hwaccel_output_format vaapi -i

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #1 from Allan Sandfeld Jensen --- I traced the issue to this commit: commit acf57fcf7ff7e60c3550da7b6dda7ad8b69195bd Author: Kenneth Graunke Date: Sat Aug 20 12:51:03 2016 -0700

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 Bug ID: 105161 Summary: Validation of KHR_blend_equation_advanced stricter than NVidia Product: Mesa Version: 17.3 Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v4

2018-02-19 Thread Eric Engestrom
On Friday, 2018-02-16 14:27:03 -0600, Alexander von Gluck IV wrote: > --- > include/meson.build| 8 + > meson.build| 16 +++--- > src/egl/meson.build| 36 +++--- >

Re: [Mesa-dev] [PATCH] anv/entrypoints: make vkGetDeviceProcAddr return NULL for instance commands

2018-02-19 Thread Lionel Landwerlin
Looks good to me : Reviewed-by: Lionel Landwerlin On 19/02/18 10:54, Iago Toral Quiroga wrote: The Vulkan working group has recently clarified that this is the intended behavior and accepted spec language changes to make this clear. ---

[Mesa-dev] [PATCH] anv/entrypoints: make vkGetDeviceProcAddr return NULL for instance commands

2018-02-19 Thread Iago Toral Quiroga
The Vulkan working group has recently clarified that this is the intended behavior and accepted spec language changes to make this clear. --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py