[Mesa-dev] [PATCH 1/5] swr/rast: Remove draw type from event definitions

2018-02-22 Thread George Kyriazis
- Have the draw type sent to DrawInfoEvent in handlers created in archrast.cpp. The draw type no longer needs to be sent during during AR_API_EVENT() call in api.cpp. - Remove draw type from event defintions in events_private.proto, no longer needed ---

[Mesa-dev] [PATCH 5/5] swr/rast: revert clip distance precision

2018-02-22 Thread George Kyriazis
Breaks a whole bunch of piglit tests --- src/gallium/drivers/swr/rasterizer/core/backend_impl.h | 4 +--- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 17 - 2 files changed, 17 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] swr/rast: Faster frustum prim culling

2018-02-22 Thread George Kyriazis
Fix clipper validMask setting. We don't need to run frustum rejected primitives through the clipper. Perform frustum culling with only frustum clip codes. Guardband clip codes cannot be used because they overlap frustum codes. --- src/gallium/drivers/swr/rasterizer/core/clip.h | 10 +++--- 1

[Mesa-dev] [PATCH 3/5] swr/rast: Consolidate TRANSLATE_ADDRESS

2018-02-22 Thread George Kyriazis
Translate is now part of an overloaded LOAD call which required a change to the code gen to skip the load functions in order to handle them manually to make them virtual. --- .../swr/rasterizer/codegen/gen_llvm_ir_macros.py | 3 ++- .../drivers/swr/rasterizer/jitter/builder_mem.cpp| 20

[Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

2018-02-22 Thread Jose Fonseca
The MSVC version we (at VMware) primarily care about from now on is 2015. We can drop support for building with 2013 in a future commit. I'm not aware of significant changes in C99/C11 support from MSVC 2013 to 2015, but there's no point in continuing supporting old MSVC versions when nobody

Re: [Mesa-dev] [PATCH 00/13] RadeonSI: Reduce user SGPR usage

2018-02-22 Thread Marek Olšák
I don't think that adding "uint32_t userdata_XX[16];" would simplify anything. The bottom line is, patches 9-13 are prerequisites for VBO descriptors in user SGPRs, so they block that optimization as long as they sit on the mailing list. Marek On Tue, Feb 20, 2018 at 8:51 PM, Marek Olšák

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

2018-02-22 Thread Emil Velikov
On 22 February 2018 at 15:18, Chuck Atkins wrote: >> On 22 February 2018 at 14:33, Chuck Atkins >> wrote: >> > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is >> > used on an unsupported architecture. >> > >> > v2: re-work

Re: [Mesa-dev] [PATCH 03/17] intel: Disable 64-bit extensions on platforms without 64-bit types

2018-02-22 Thread Iago Toral
On Wed, 2018-02-21 at 09:33 -0800, Matt Turner wrote: > On Wed, Feb 21, 2018 at 2:05 AM, Iago Toral > wrote: > > On Tue, 2018-02-20 at 21:15 -0800, Matt Turner wrote: > > > Gen11 does not support DF, Q, UQ types in hardware. As a result, > > > we > > > have > > > to disable

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

2018-02-22 Thread Chuck Atkins
> > On 22 February 2018 at 14:33, Chuck Atkins > wrote: > > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > > used on an unsupported architecture. > > > > v2: re-work to place logic in xmesa_init_display > > > > Signed-off-by: Chuck Atkins

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

2018-02-22 Thread Thierry Reding
On Thu, Feb 22, 2018 at 02:31:48PM +0100, Erik Faye-Lund wrote: > On Thu, Feb 22, 2018 at 2:23 PM, Thierry Reding > wrote: > > On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: > >> Hi Thierry, > >> > >> On 21 February 2018 at 15:30, Thierry Reding

[Mesa-dev] [PATCH] swr/rast: Fix index buffer overfetch issue for non-indexed draws

2018-02-22 Thread George Kyriazis
Populate pLastIndex, even for the non-indexed case. A zero pLastIndex can cause the index offsets inside the fetcher to have non-sensical values that can be either very large positive or very large negative numbers. cc: mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glx: Properly handle cases where screen creation fails

2018-02-22 Thread Emil Velikov
On 22 February 2018 at 14:33, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > v2: re-work to place logic in xmesa_init_display > > Signed-off-by: Chuck Atkins

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105171 Emil Velikov changed: What|Removed |Added Keywords||bisected,

[Mesa-dev] [PATCH v2] glx: Properly handle cases where screen creation fails

2018-02-22 Thread Chuck Atkins
This fixes a segfault exposed by a29d63ecf7 which occurs when swr is used on an unsupported architecture. v2: re-work to place logic in xmesa_init_display Signed-off-by: Chuck Atkins Cc: mesa-sta...@lists.freedesktop.org Cc: George Kyriazis

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

2018-02-22 Thread Emil Velikov
On 22 February 2018 at 13:23, Thierry Reding wrote: > On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: >> Hi Thierry, >> >> On 21 February 2018 at 15:30, Thierry Reding >> wrote: >> >> > @@ -2595,6 +2596,11 @@ if test -n

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105208 Emil Velikov changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] intel: aubinator_error_decode: fix segfault on missing register

2018-02-22 Thread Lionel Landwerlin
Some register might be missing in our genxmls. Don't try to decode them. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_error_decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator_error_decode.c

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

2018-02-22 Thread Erik Faye-Lund
On Thu, Feb 22, 2018 at 2:23 PM, Thierry Reding wrote: > On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: >> Hi Thierry, >> >> On 21 February 2018 at 15:30, Thierry Reding >> wrote: >> > +static const char * >> >

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

2018-02-22 Thread Thierry Reding
On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: > Hi Thierry, > > On 21 February 2018 at 15:30, Thierry Reding wrote: > > > @@ -2595,6 +2596,11 @@ if test -n "$with_gallium_drivers"; then > > ximx) > > HAVE_GALLIUM_IMX=yes > >

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #9 from Allan Sandfeld Jensen --- The problem is the check in linker.cpp (link_fs_inout_layout_qualifiers): if (linked_shader->Stage != MESA_SHADER_FRAGMENT || (prog->data->Version < 150 &&

Re: [Mesa-dev] [PATCH] nv50,nvc0: fix clear buffer acceleration

2018-02-22 Thread Karol Herbst
Tested-by: Karol Herbst On Wed, Feb 21, 2018 at 5:20 AM, Ilia Mirkin wrote: > Two things were off: > - valid range was not updated, which could affect waiting for future >maps > - fencing was done manually instead of using the *_resource_validate

Re: [Mesa-dev] [PATCH] nv50, nvc0: fix integer MS resolves using 2d engine

2018-02-22 Thread Karol Herbst
Tested-by: Karol Herbst On Thu, Feb 22, 2018 at 5:34 AM, Ilia Mirkin wrote: > We don't want filtering for integer textures, same as depth/stencil. > > Fixes: KHR-GL45.direct_state_access.renderbuffers_storage_multisample > Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] nvc0: fix writing query results into buffer

2018-02-22 Thread Karol Herbst
Tested-by: Karol Herbst On Wed, Feb 21, 2018 at 6:17 AM, Ilia Mirkin wrote: > We need to mark the range as valid, and validate the resource using a > helper to ensure that the buffer status is marked properly. > > Fixes some CTS pipeline stats query

[Mesa-dev] [Bug 105161] Validation of KHR_blend_equation_advanced stricter than NVidia

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 --- Comment #8 from Allan Sandfeld Jensen --- That would fix the parsing in compatibility shaders. It doesn't make it work. I found after digging into mesa code that I needed: #extension GL_ARB_fragment_coord_conventions :

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105208 Daniel Stone changed: What|Removed |Added CC||mar...@gmail.com,

[Mesa-dev] [Bug 105208] [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105208 Bug ID: 105208 Summary: [regression] (e5ff036c67 st/dri: Add support for BGR[A/X]1010102 formats) broke the mouse in mutter/shell Product: Mesa Version:

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.4 release candidate

2018-02-22 Thread Emil Velikov
On 21 February 2018 at 19:14, Kenneth Graunke wrote: > On Thursday, February 8, 2018 8:47:00 PM PST Emil Velikov wrote: >> Rejected (9) >> >> Jason Ekstrand (2): >> e52a9f18d69c94b7cb7f81361cdb9e2582c3d742 i965: Replace >> draw_aux_buffer_disabled with

Re: [Mesa-dev] [PATCH 4/5] nouveau: Add framebuffer modifier support

2018-02-22 Thread Thierry Reding
On Wed, Feb 21, 2018 at 04:37:45PM +, Emil Velikov wrote: > Hi Thierry, > > On 21 February 2018 at 15:30, Thierry Reding wrote: > > > > > struct pipe_resource * > > nouveau_buffer_create(struct pipe_screen *pscreen, > > - const struct

Re: [Mesa-dev] [PATCH 4/5] nouveau: Add framebuffer modifier support

2018-02-22 Thread Thierry Reding
On Wed, Feb 21, 2018 at 11:05:45AM -0500, Ilia Mirkin wrote: > On Wed, Feb 21, 2018 at 10:30 AM, Thierry Reding > wrote: > > From: Thierry Reding > > > > This adds support for framebuffer modifiers to Nouveau. This will be > > used by the Tegra

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105171 Clemens Eisserer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-22 Thread Emil Velikov
On 22 February 2018 at 05:57, Tomasz Figa wrote: > On Thu, Feb 22, 2018 at 7:23 AM, Rob Herring wrote: >> >> On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov >> wrote: >> > On 21 February 2018 at 18:50, Rob Herring

[Mesa-dev] [Bug 105207] The Talos Principle freezes system using radv

2018-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105207 Bug ID: 105207 Summary: The Talos Principle freezes system using radv Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH 2/2] ac/nir: set GLC=1 for load/store of coherent/volatile images

2018-02-22 Thread Samuel Pitoiset
On 02/22/2018 11:45 AM, Bas Nieuwenhuizen wrote: Ideally we find a way to also do it for buffers, but for this series I didn't mention it in the commit message, but yes we should. Reviewed-by: Bas Nieuwenhuizen > On Thu, Feb

Re: [Mesa-dev] [PATCH 2/2] ac/nir: set GLC=1 for load/store of coherent/volatile images

2018-02-22 Thread Bas Nieuwenhuizen
Ideally we find a way to also do it for buffers, but for this series Reviewed-by: Bas Nieuwenhuizen On Thu, Feb 22, 2018 at 10:25 AM, Samuel Pitoiset wrote: > This disables persistence accross wavefronts. > > F1 2017 and Wolfenstein 2

Re: [Mesa-dev] [PATCH v3 09/21] clover: Track flags per module section

2018-02-22 Thread Pierre Moreau
On 2018-02-21 — 20:04, Aaron Watry wrote: > On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau wrote: > > One flag that needs to be tracked is whether a library is allowed to > > received mathematics optimisations or not, as the authorisation is given > > when creating the

Re: [Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

2018-02-22 Thread Pierre Moreau
> I think this can be merged into patches 17 and 18, no? You are right, will do. > On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau wrote: > > Signed-off-by: Pierre Moreau > > --- > > src/gallium/state_trackers/clover/api/device.cpp | 3 +-- > >

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-02-22 Thread Pierre Moreau
> do we already have an upstream version of both dependencies we could > just use? Or do we still need special branches? For both we can use the master branch of the upstream version. SPIRV-Tools validator is still not perfect, but it does already catch issues in OpenCL SPIR-V binaries. And

Re: [Mesa-dev] [PATCH v3 21/21] clover: Use OpenCL 2.1 defines in place of cl_khr_il_program

2018-02-22 Thread Karol Herbst
I think this can be merged into patches 17 and 18, no? On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > src/gallium/state_trackers/clover/api/device.cpp | 3 +-- >

Re: [Mesa-dev] [PATCH v3 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-02-22 Thread Karol Herbst
do we already have an upstream version of both dependencies we could just use? Or do we still need special branches? On Wed, Feb 21, 2018 at 11:50 PM, Pierre Moreau wrote: > Signed-off-by: Pierre Moreau > --- > > Notes: > v3: > * Bump the

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-22 Thread Daniel Stone
Hi Dieter, 2018-02-22 0:57 GMT+00:00 Dieter Nützel : > Making all in vulkan > make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten > make[3]: *** Keine Regel vorhanden, um das Ziel > „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“, > benötigt von

[Mesa-dev] [PATCH 2/2] ac/nir: set GLC=1 for load/store of coherent/volatile images

2018-02-22 Thread Samuel Pitoiset
This disables persistence accross wavefronts. F1 2017 and Wolfenstein 2 appear to use some coherent images but this patch doesn't seem to change anything. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 7 --- 1 file changed, 4 insertions(+),

[Mesa-dev] [PATCH 1/2] spirv: apply memory qualifiers to images

2018-02-22 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/compiler/spirv/vtn_variables.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index ead68b4784..9eb85c24e9 100644 ---

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-22 Thread Chih-Wei Huang
2018-02-21 3:03 GMT+08:00 Rob Herring : > > Perhaps worth revisiting. Given we've failed to progress at all since > then may change opinions some. We already have to handle multiple > opens share the same pipe_screen, so I don't think reusing the fd buys > us anything. > > Maybe

<    1   2