https://bugs.freedesktop.org/show_bug.cgi?id=105464
libgra...@gmail.com changed:
What|Removed |Added
CC||libgra...@gmail.com
--
You are
On 14/03/18 07:36, Mark Janes wrote:
Daniel Vetter writes:
On Tue, Mar 13, 2018 at 4:46 PM, Mark Janes wrote:
Daniel Vetter writes:
On Mon, Mar 12, 2018 at 11:54:45PM -0700, Kenneth Graunke wrote:
On Friday, March 9, 2018
Yes, it does.
Marek
On Mar 13, 2018 10:44 PM, "Dylan Baker" wrote:
> Does meson need the same change?
>
> On March 13, 2018 6:03:18 PM PDT, "Marek Olšák" wrote:
>>
>> From: Marek Olšák
>>
>> Since 2.4.90 might not work, just ask for
From: Dave Airlie
This removes the other geometry specific user sgpr.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 37 +++--
src/amd/vulkan/radv_pipeline.c| 9 -
From: Dave Airlie
This removes the last TES-specifc user sgpr.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 50 ---
src/amd/vulkan/radv_pipeline.c| 18 ++
From: Dave Airlie
This drops one of the geometry specific user sgprs,
we can work this out at compile time.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 15 +++
src/amd/vulkan/radv_pipeline.c| 9 +
2 files
From: Dave Airlie
Instead of recalculating the value, use the shader calculated value.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_pipeline.c | 30 ++
1 file changed, 2 insertions(+), 28 deletions(-)
diff --git
From: Dave Airlie
This moves the lds_size calcs into the shader so we have all
the size stuff in one file.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 33 +
src/amd/vulkan/radv_pipeline.c| 29
From: Dave Airlie
This drops the now unneeded scanning and results in favour
of the ones in the info.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 33 -
src/amd/vulkan/radv_pipeline.c| 7 +++
From: Dave Airlie
TES needs num_patches to do some of the calculations.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 4 +++-
src/amd/vulkan/radv_pipeline.c| 4
src/amd/vulkan/radv_shader.h | 3 ++-
3 files changed, 9
From: Dave Airlie
Inline all calcs at shader creation.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 26 +-
src/amd/vulkan/radv_pipeline.c| 12 ++--
src/amd/vulkan/radv_shader.h | 1 +
3
From: Dave Airlie
Move all calculations to shader generation.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 39 +++
src/amd/vulkan/radv_pipeline.c| 10 ++
2 files changed, 29
From: Dave Airlie
This gathers the ls outputs written by the vertex shader,
and the tcs outputs, these are needed to calculate certain
tcs parameters.
These have to be separate for combined gfx9 shaders.
This is a bit pessimistic compared to the nir pass,
as we don't work
From: Dave Airlie
We can precalculate input_vertex_size at compile time.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 30 --
src/amd/vulkan/radv_pipeline.c| 10 --
From: Dave Airlie
This removes the last TCS specific user sgpr.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 116 +-
src/amd/vulkan/radv_pipeline.c| 9 ---
src/amd/vulkan/radv_shader.c
From: Dave Airlie
Move all calculations to shader generation.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 22 +-
src/amd/vulkan/radv_pipeline.c| 8 ++--
2 files changed, 15 insertions(+), 15
From: Dave Airlie
This just moves this function to an inline so the shader_info
pass can use it.
v2: use inline (Samuel)
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_nir_to_llvm.c | 22 --
src/amd/vulkan/radv_shader.h |
None of the info we were passing from the pipeline into the shaders
via user sgprs for tess/gs was required, this series removes all
user sgprs in favour of calculating the values at compile time.
This is a repost, I've rebased this into radv and hopefully taken
all the comments on board.
Dave.
Am 13.03.2018 um 05:28 schrieb Dave Airlie:
> On 13 March 2018 at 14:24, Dave Airlie wrote:
>> This is the main code for the soft fp64 work. It's mostly Elie's
>> code with a bunch of changes by me.
>>
>
> All the patches are in my tree here, along with some other bits:
>
Am 14.03.2018 um 02:05 schrieb Dave Airlie:
> On 14 March 2018 at 10:46, Roland Scheidegger wrote:
>> Am 13.03.2018 um 05:24 schrieb Dave Airlie:
>>> From: Elie Tournier
>>>
>>> v2: use mix.
>>>
>>> Signed-off-by: Elie Tournier
Am 13.03.2018 um 05:24 schrieb Dave Airlie:
> From: Elie Tournier
>
> This currently uses fp64->fp32, sqrt(fp32), fp32->fp64.
>
> [airlied: The code is include from soft float for doing proper sqrt64
> but it needs to be decided if we need to pursue this and
> how to
Wrap it in parens and it can span multiple lines
On March 13, 2018 5:40:15 PM PDT, Rob Clark wrote:
>On Tue, Mar 13, 2018 at 7:47 PM, Rob Clark wrote:
>> On Tue, Mar 13, 2018 at 7:27 PM, Rob Clark
>wrote:
>>> On Tue, Mar 13, 2018
Does meson need the same change?
On March 13, 2018 6:03:18 PM PDT, "Marek Olšák" wrote:
>From: Marek Olšák
>
>Since 2.4.90 might not work, just ask for the next version.
>---
> configure.ac | 9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
Am 13.03.2018 um 05:24 schrieb Dave Airlie:
> From: Elie Tournier
>
> Signed-off-by: Elie Tournier
> ---
> src/compiler/glsl/builtin_float64.h | 135
>
> src/compiler/glsl/builtin_functions.cpp | 4 +
On Tue, Mar 13, 2018 at 9:15 PM, Mike Lothian wrote:
> Did you mean to remove the blacklist you added in the previous patch?
Yes. The previous patch is for stable releases only, but it has to go
through master.
Marek
___
mesa-dev
I am fine to add ref count for map pointer but then the code looks a
little complex:
We already have ref count for display target, and it seems most other
drivers don't have a
ref count for map pointer. (I checked dri_sw_displaytarget_map /
gdi_sw_displaytarget_map/hgl_winsys_displaytarget_map
Did you mean to remove the blacklist you added in the previous patch?
On Wed, 14 Mar 2018 at 01:03 Marek Olšák wrote:
> From: Marek Olšák
>
> Since 2.4.90 might not work, just ask for the next version.
> ---
> configure.ac | 9 +
> 1 file
Am 13.03.2018 um 05:24 schrieb Dave Airlie:
> From: Elie Tournier
>
> Signed-off-by: Elie Tournier
> ---
> src/compiler/glsl/builtin_float64.h | 104
>
> src/compiler/glsl/builtin_functions.cpp | 4 ++
On 14 March 2018 at 10:46, Roland Scheidegger wrote:
> Am 13.03.2018 um 05:24 schrieb Dave Airlie:
>> From: Elie Tournier
>>
>> v2: use mix.
>>
>> Signed-off-by: Elie Tournier
>> ---
>>
From: Marek Olšák
Cc: 18.0 17.3 17.2
---
configure.ac | 7 +++
1 file changed, 7 insertions(+)
diff --git a/configure.ac b/configure.ac
index 621dc32..e29ce68 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2601,20 +2601,27 @@ if
From: Marek Olšák
Since 2.4.90 might not work, just ask for the next version.
---
configure.ac | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index e29ce68..8ec5b26 100644
--- a/configure.ac
+++ b/configure.ac
@@
Am 13.03.2018 um 05:24 schrieb Dave Airlie:
> From: Elie Tournier
>
> v2: use mix.
>
> Signed-off-by: Elie Tournier
> ---
> src/compiler/glsl/builtin_float64.h | 28
>
On Tue, Mar 13, 2018 at 7:47 PM, Rob Clark wrote:
> On Tue, Mar 13, 2018 at 7:27 PM, Rob Clark wrote:
>> On Tue, Mar 13, 2018 at 7:10 PM, Dylan Baker wrote:
>>> Quoting Rob Clark (2018-03-13 16:04:00)
---
I'm a bit unsure
On 14 March 2018 at 09:47, Gert Wollny wrote:
>
> Am Dienstag, den 13.03.2018, 14:24 +1000 schrieb Dave Airlie:
>> This is the main code for the soft fp64 work. It's mostly Elie's
>> code with a bunch of changes by me.
>
> Many thanks for this work, Elie and Dave. I've
https://bugs.freedesktop.org/show_bug.cgi?id=105464
--- Comment #3 from Dave Airlie ---
https://patchwork.freedesktop.org/series/39918/
Should fix this, thanks for the report and reproducer.
--
You are receiving this mail because:
You are the assignee for the bug.
You
From: Dave Airlie
This seems more correct to me, since if we have an array
of floats they'll be vec4 aligned, and if we do af[2],
we want the const index to increase by 2 slots in the non
compact case.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464
Fixes:
From: Dave Airlie
I was going to have to add another parameter to this monster,
so we should just pass the nir_variable in, I can't find any
reason this would be a bad idea.
This needed for the next fix.
Fixes: 94f9591995 (radv/ac: add support for TCS/TES inputs/outputs.)
From: Dave Airlie
If a shader does a tcs store with an indirect access, we
were only marking the first spot as used. For indirect access
we always now mark all slots used by the variable.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464
Fixes: 94f9591995
On 14 March 2018 at 09:54, Matt Turner wrote:
> On Mon, Mar 12, 2018 at 9:24 PM, Dave Airlie wrote:
>> This is the main code for the soft fp64 work. It's mostly Elie's
>> code with a bunch of changes by me.
>>
>> This patchset has all the glsl lowering
Make sure we don't emit 64 bit types if the hardware doesn't support
them.
Signed-off-by: Rafael Antognolli
Suggested-by: Kenneth Graunke
---
src/intel/compiler/brw_reg_type.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Mon, Mar 12, 2018 at 9:24 PM, Dave Airlie wrote:
> This is the main code for the soft fp64 work. It's mostly Elie's
> code with a bunch of changes by me.
>
> This patchset has all the glsl lowering code. (using float64.glsl,
> yes I know checked in files are bad, but not bad
Am Dienstag, den 13.03.2018, 14:24 +1000 schrieb Dave Airlie:
> This is the main code for the soft fp64 work. It's mostly Elie's
> code with a bunch of changes by me.
Many thanks for this work, Elie and Dave. I've tested the patches on
BARTS with nosb, piglit set all, -t fp64, and I get 2976 of
On Tue, Mar 13, 2018 at 7:27 PM, Rob Clark wrote:
> On Tue, Mar 13, 2018 at 7:10 PM, Dylan Baker wrote:
>> Quoting Rob Clark (2018-03-13 16:04:00)
>>> ---
>>> I'm a bit unsure about the xcb-present version dependency, as that was
>>> added in a different
On Tue, Mar 13, 2018 at 7:05 PM, Dylan Baker wrote:
> with_gallium_omx used to be a boolean, but now it's a string. That means
> it needs to be compared to 'disabled' instead of false.
>
> CC: Rob Clark
> Fixes: 34e852d5b50772199797ea839fc8d6b3805633ff
>
On Tue, Mar 13, 2018 at 7:10 PM, Dylan Baker wrote:
> Quoting Rob Clark (2018-03-13 16:04:00)
>> ---
>> I'm a bit unsure about the xcb-present version dependency, as that was
>> added in a different commit. OTOH I guess Dave is building vulkan with
>> his patch so it is
V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav)
Reviewed-by: Eric Anholt
---
src/util/hash_table.c | 22 ++
src/util/hash_table.h | 2 ++
2 files changed, 24 insertions(+)
diff --git a/src/util/hash_table.c b/src/util/hash_table.c
Sending out a v2 just in case someone has any more comments.
If not I'll probably push these tomorrow, or thursday.
This is a revival of some old patches I had around to improve
the compile times in the glsl compiler by reducing the time
spend inserting items in the hash table in
Walking the whole hash table, inserting entries by hashing them first
is just a really bad idea. We can simply memcpy the whole thing.
While this does not have a major performance impact on average,
as it only helps shaders with a lot of branches, it might help
individual shaders quite a lot. For
Quoting Rob Clark (2018-03-13 16:04:00)
> ---
> I'm a bit unsure about the xcb-present version dependency, as that was
> added in a different commit. OTOH I guess Dave is building vulkan with
> his patch so it is perhaps not a built-time dependency.
>
> meson.build | 11 ---
> 1 file
with_gallium_omx used to be a boolean, but now it's a string. That means
it needs to be compared to 'disabled' instead of false.
CC: Rob Clark
Fixes: 34e852d5b50772199797ea839fc8d6b3805633ff
("meson: Re-add auto option for omx")
Signed-off-by: Dylan Baker
---
I'm a bit unsure about the xcb-present version dependency, as that was
added in a different commit. OTOH I guess Dave is building vulkan with
his patch so it is perhaps not a built-time dependency.
meson.build | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
---
You can squash this, and at your descrition the 2nd one into Dave's
patch[1]
[1] https://patchwork.freedesktop.org/patch/210351/
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 3a00456e7c9..c201644c372 100644
--- a/meson.build
https://bugs.freedesktop.org/show_bug.cgi?id=105494
--- Comment #2 from almos ---
Created attachment 138082
--> https://bugs.freedesktop.org/attachment.cgi?id=138082=edit
shot43.png
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=105494
Bug ID: 105494
Summary: UT2004 cube map reflection problem
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
https://bugs.freedesktop.org/show_bug.cgi?id=105494
--- Comment #1 from almos ---
Created attachment 138081
--> https://bugs.freedesktop.org/attachment.cgi?id=138081=edit
shot42.png
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the
Stateblocks with NINESBT_ALL should track all textures.
For better performance they have a faster path which
copies all the required.
This path was only tracking ps textures.
Fixes: https://github.com/iXit/Mesa-3D/issues/303
Signed-off-by: Axel Davy
CC: "17.3 18.0"
There was a missing absolute value when
checking if the determinant was big enough.
Fixes: https://github.com/iXit/Mesa-3D/issues/292
Signed-off-by: Axel Davy
CC: "17.3 18.0"
---
src/gallium/state_trackers/nine/nine_ff.c | 2 +-
1 file
An incorrect formula was used to compute bound_samplers_mask_vs.
Since s is above always 8 for vs and the variable is encoded on 8 bits,
it was always 0.
This resulted in commiting the samplers every call when
there was at least one texture read in the vs shader.
Signed-off-by: Axel Davy
Makes the conversion explicit.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=102542
Signed-off-by: Axel Davy
CC: "17.3 18.0"
---
src/gallium/state_trackers/nine/nine_ff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Reviewed-by: Jason Ekstrand
On Tue, Mar 13, 2018 at 2:39 PM, Rob Clark wrote:
> Signed-off-by: Rob Clark
> ---
> Now with switch (and also u64<-u64 copy instead of f64<-f64 for 64b)..
>
>
Signed-off-by: Rob Clark
---
Now with switch (and also u64<-u64 copy instead of f64<-f64 for 64b)..
src/compiler/nir/nir_lower_load_const_to_scalar.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git
Quoting Rob Clark (2018-03-13 14:08:46)
> On Tue, Mar 13, 2018 at 4:48 PM, Dylan Baker wrote:
> > Quoting Dave Airlie (2018-03-13 13:06:00)
> >> From: Dave Airlie
> >>
> >> I'm not sure everyone wants to be updating their dri3 in a forced
> >> march
Quoting Rob Clark (2018-03-13 14:08:46)
> On Tue, Mar 13, 2018 at 4:48 PM, Dylan Baker wrote:
> > Quoting Dave Airlie (2018-03-13 13:06:00)
> >> From: Dave Airlie
> >>
> >> I'm not sure everyone wants to be updating their dri3 in a forced
> >> march
On Tue, Mar 13, 2018 at 4:48 PM, Dylan Baker wrote:
> Quoting Dave Airlie (2018-03-13 13:06:00)
>> From: Dave Airlie
>>
>> I'm not sure everyone wants to be updating their dri3 in a forced
>> march setting, this allows a nicer approach, esp when you want
This fixes CTS:
dEQP-VK.api.device_init.create_device_queue2_unmatched_flags
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 23 +--
src/amd/vulkan/radv_private.h | 1 +
2 files changed, 22 insertions(+), 2 deletions(-)
diff
Quoting Dave Airlie (2018-03-13 13:06:00)
> From: Dave Airlie
>
> I'm not sure everyone wants to be updating their dri3 in a forced
> march setting, this allows a nicer approach, esp when you want
> to build on distro that aren't brand new.
>
> I'm sure there are plenty of
Daniel Vetter writes:
> On Tue, Mar 13, 2018 at 4:46 PM, Mark Janes wrote:
>> Daniel Vetter writes:
>>
>>> On Mon, Mar 12, 2018 at 11:54:45PM -0700, Kenneth Graunke wrote:
On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote:
On Tue, Mar 13, 2018 at 11:39 AM, Bas Nieuwenhuizen wrote:
> Thanks a lot!
>
You're welcome. Classic case of writing code is easier than reviewing it.
:-)
> Reviewed-by: Bas Nieuwenhuizen
>
Thanks! Pushed.
> for the series.
>
> On
On Tue, Mar 13, 2018 at 12:45 PM, Rob Clark wrote:
> Signed-off-by: Rob Clark
> ---
> src/compiler/nir/nir_lower_load_const_to_scalar.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git
From: Dave Airlie
I'm not sure everyone wants to be updating their dri3 in a forced
march setting, this allows a nicer approach, esp when you want
to build on distro that aren't brand new.
I'm sure there are plenty of ways this patch could be cleaner,
and I've also not built
2018-03-12 19:48 GMT+01:00 Emil Velikov :
> Hi Thomas,
>
> On 12 March 2018 at 17:55, Thomas Helland wrote:
>> V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav)
>> ---
>> src/util/hash_table.c | 22 ++
Kenneth Graunke writes:
> [ Unknown signature status ]
> On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote:
> [snip]
>> I've been doing this for Intel. Developers are on the hook to fix their
>> bugs, but you can't make them do it. They have many pressures on
Sorry, partially forgot about it. I’ll look at it over the weekend, as I don’t
have time before. :-/
Pierre
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
Signed-off-by: Rob Clark
---
src/compiler/nir/nir_lower_load_const_to_scalar.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/compiler/nir/nir_lower_load_const_to_scalar.c
b/src/compiler/nir/nir_lower_load_const_to_scalar.c
index
From: Dave Airlie
AMDVLK says 16 for pre-GFX9 and 64 for GFX9.
This seems to help fix:
https://bugs.freedesktop.org/show_bug.cgi?id=105464
on Polaris.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464
Signed-off-by: Dave Airlie
---
From: Dave Airlie
This seems more correct to me, since if we have an array
of floats they'll be vec4 aligned, and if we do af[2],
we want the const index to increase by 2 slots in the non
compact case.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464
Fixes:
Quoting Andy Furniss (2018-03-06 15:12:37)
> make[5]: Entering directory
> '/mnt/sdc1/Gits/mesa/src/gallium/state_trackers/omx/tizonia'
>CC h264dprc.lo
> In file included from h264dprc.c:45:0:
> ../../../../../src/egl/drivers/dri2/egl_dri2.h:47:10: fatal error:
>
Quoting Ilia Mirkin (2018-03-13 12:15:08)
> On Tue, Mar 13, 2018 at 3:05 PM, Emil Velikov
> wrote:
> > On 13 March 2018 at 18:52, Dylan Baker wrote:
> >> Currently each driver specifies it's own version, and core libdrm
> >> specifies a version. In
On Tue, Mar 13, 2018 at 3:05 PM, Emil Velikov wrote:
> On 13 March 2018 at 18:52, Dylan Baker wrote:
>> Currently each driver specifies it's own version, and core libdrm
>> specifies a version. In the most common case this is fine, since there
>>
On 13 March 2018 at 01:38, Alex Smith wrote:
> From the spec:
>
> "When copying between compressed and uncompressed formats the
> extent members represent the texel dimensions of the source
> image and not the destination."
>
> However, as per 7b890a36,
On 13 March 2018 at 18:52, Dylan Baker wrote:
> Currently each driver specifies it's own version, and core libdrm
> specifies a version. In the most common case this is fine, since there
> will be exactly one libdrm installed on a system, but if there are more
> than one it's
On 13 March 2018 at 18:23, Dylan Baker wrote:
> Quoting Emil Velikov (2018-03-13 09:41:47)
>> On 7 March 2018 at 23:13, Dylan Baker wrote:
>> > meson got the same fix.
>> >
>> > cc: Emil Veliov
>> > Signed-off-by: Dylan Baker
This corrects pkg-config to use the libdrm version (as computed by the
previous patch) instead of using a hardcoded value that may or may not
(probably not) be right.
Signed-off-by: Dylan Baker
---
src/gallium/targets/d3dadapter9/meson.build | 2 +-
Currently each driver specifies it's own version, and core libdrm
specifies a version. In the most common case this is fine, since there
will be exactly one libdrm installed on a system, but if there are more
than one it's possible that mesa will be linked against different
versions of libdrm.
The reason libdrm is after libdrm_* will be made clear in later patches.
Signed-off-by: Dylan Baker
---
meson.build | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/meson.build b/meson.build
index 51b4702..e747d99
Thanks a lot!
Reviewed-by: Bas Nieuwenhuizen
for the series.
On Sat, Mar 10, 2018 at 7:42 PM, Jason Ekstrand wrote:
> On Sat, Mar 10, 2018 at 10:18 AM, Jason Ekstrand
> wrote:
>>
>> This tiny series moves the pass that Bas
Quoting Emil Velikov (2018-03-13 09:41:47)
> On 7 March 2018 at 23:13, Dylan Baker wrote:
> > meson got the same fix.
> >
> > cc: Emil Veliov
> > Signed-off-by: Dylan Baker
> > ---
> >
> > I don't know hat the "right" fix
On Tue, Mar 13, 2018 at 5:40 AM, Samuel Iglesias Gonsálvez <
sigles...@igalia.com> wrote:
> OpSConvert interprets the MSB of the unsigned value as the sign bit and
> extends it to the new type. If we want to preserve the value, we need
> to use OpUConvert opcode.
>
> v2:
> - No need to check dst
On 13/03/18 17:38, Eric Anholt wrote:
The compiler doesn't notice that the condition for num_layers to be
undefined already defined it above (as our assert checked in a debug
build).
Cc: Jason Ekstrand
---
src/mesa/drivers/dri/i965/brw_blorp.c | 1 +
1 file
Reviewed-by: Jason Ekstrand
On Tue, Mar 13, 2018 at 9:16 AM, Neil Roberts wrote:
> The code to handle mat multipication by a scalar tries to pick either
> imul or fmul depending on whether the matrix is float or integer.
> However it was doing this by
On Tue, Mar 13, 2018 at 4:46 PM, Mark Janes wrote:
> Daniel Vetter writes:
>
>> On Mon, Mar 12, 2018 at 11:54:45PM -0700, Kenneth Graunke wrote:
>>> On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote:
>>> [snip]
>>> > I've been doing this for
On 13/03/18 17:38, Eric Anholt wrote:
We only get VK_SUCCESS if it was initialized, but apparently my compiler
doesn't track that far.
Cc: Jason Ekstrand
I guess it doesn't hurt.
Reviewed-by: Lionel Landwerlin
---
On 13/03/18 17:38, Eric Anholt wrote:
We only have a cfg != NULL if we went through one of the paths that set
it, but my compiler doesn't figure that out.
Cc: Jason Ekstrand
Reviewed-by: Lionel Landwerlin
Fixes: 6411defdcd6f
On 13/03/18 17:38, Eric Anholt wrote:
This is a legitimate warning: if anv's blorp_alloc_binding_table() throws
an error from anv_cmd_buffer_alloc_blorp_binding_table(), we silently
continue to use this undefined value. The rest of this code doesn't seem
very allocation-error-proof, though,
On Tue, 2018-03-13 at 16:53 +, Emil Velikov wrote:
> On 13 March 2018 at 15:40, Marek Olšák wrote:
> > Piglit+CTS+dEQP look good on Polaris12 with Mesa 17.3 and LLVM 6.0.
> >
>
> Thank you very much Marek!
>
> Meanwhile I've gone through the results in the LunarG tool.
We only have a cfg != NULL if we went through one of the paths that set
it, but my compiler doesn't figure that out.
Cc: Jason Ekstrand
Fixes: 6411defdcd6f ("intel/cs: Re-run final NIR optimizations for each SIMD
size")
---
src/intel/compiler/brw_fs.cpp | 2 +-
1 file
We only get VK_SUCCESS if it was initialized, but apparently my compiler
doesn't track that far.
Cc: Jason Ekstrand
---
src/intel/vulkan/anv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c
This is a legitimate warning: if anv's blorp_alloc_binding_table() throws
an error from anv_cmd_buffer_alloc_blorp_binding_table(), we silently
continue to use this undefined value. The rest of this code doesn't seem
very allocation-error-proof, though, either.
Cc: Jason Ekstrand
The compiler doesn't notice that the condition for num_layers to be
undefined already defined it above (as our assert checked in a debug
build).
Cc: Jason Ekstrand
---
src/mesa/drivers/dri/i965/brw_blorp.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 13 March 2018 at 15:40, Marek Olšák wrote:
> Piglit+CTS+dEQP look good on Polaris12 with Mesa 17.3 and LLVM 6.0.
>
Thank you very much Marek!
Meanwhile I've gone through the results in the LunarG tool. Everything
looks good for the 88 games tested.
Feel free to login and
1 - 100 of 149 matches
Mail list logo