On 24/07/18 23:29, Alejandro Piñeiro wrote:
From: Neil Roberts
v2: ignore names on purpose, for consistency with other places where
we are doing the same (Alejandro)
v3: changes proposed by Timothy Arceri, implemented by Alejandro Piñeiro:
* Remove redundant 'struct
On 21/07/18 01:08, Alejandro Piñeiro wrote:
From: Neil Roberts
---
src/mesa/main/glspirv.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
index 8ad6c373914..ba4a8253671 100644
--- a/src/mesa/main/glspirv.c
+++
Reviewed-by: Timothy Arceri
On 21/07/18 01:08, Alejandro Piñeiro wrote:
From: Neil Roberts
This just sets the stream on the nir_variable.
---
src/compiler/spirv/vtn_variables.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/compiler/spirv/vtn_variables.c
https://bugs.freedesktop.org/show_bug.cgi?id=107224
--- Comment #8 from Timothy Arceri ---
(In reply to Alex Smith from comment #7)
> Thanks for confirming.
>
> It looks like we have a bug where we fail to identify Mesa properly as a
> result of compatibility profile support being added, which
On 28/07/18 11:06, Timothy Arceri wrote:
Since we know what side of the branch we ended up on we can just
replace the use with a constant.
All the spill changes in shader-db are from Dolphin uber shaders,
despite some small regressions the change is clearly positive.
V2: insert new constant
Since we know what side of the branch we ended up on we can just
replace the use with a constant.
All the spill changes in shader-db are from Dolphin uber shaders,
despite some small regressions the change is clearly positive.
V2: insert new constant after any phis in the
Chema Casanova writes:
> El 27/07/18 a las 02:44, Francisco Jerez escribió:
>> Chema Casanova writes:
>>
>>> El 26/07/18 a las 20:02, Francisco Jerez escribió:
Chema Casanova writes:
> El 20/07/18 a las 22:10, Francisco Jerez escribió:
>> Chema Casanova writes:
>>
On 28/07/18 07:51, Caio Marcelo de Oliveira Filho wrote:
---
src/compiler/nir/nir_deref.c | 111 +
src/compiler/nir/nir_deref.h | 10 ++
src/compiler/nir/nir_opt_copy_prop_vars.c | 145 ++
3 files changed, 134 insertions(+),
Quoting Brian Paul (2018-07-27 14:19:13)
> We need to pass the new flip_y argument.
> ---
> src/mesa/drivers/x11/xm_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/x11/xm_buffer.c
> b/src/mesa/drivers/x11/xm_buffer.c
> index 97c7814..9c5383b
On 27/07/18 02:00, Jason Ekstrand wrote:
This pass looks for array variables where at least one level of the
array is never indirected and splits it into multiple smaller variables.
---
src/compiler/nir/nir.h| 1 +
src/compiler/nir/nir_split_vars.c | 525
Fix rendering issues on BDW and SKL.
Fixes 0288fe8d0417730bdd5b3477130dd1dc32bdbcd3
("i965/miptree: Use the correct BLT pitch")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107359
Cc:
---
We could probably add an assert when filling out the surface state, but
I think BLORP would need
On Tue, Jul 24, 2018 at 03:28:09PM +0300, Andres Gomez wrote:
> Hi Nanley,
>
> I'm observing regressions for SKL and BDW which doesn't seem to be
> solved with this new patch, in git master. Therefore, I've gone ahead
> and reported:
> https://bugs.freedesktop.org/show_bug.cgi?id=107359
>
Hi
> ---
> src/compiler/Makefile.sources | 1 +
> src/compiler/nir/meson.build | 1 +
> src/compiler/nir/nir.h | 2 +
> src/compiler/nir/nir_opt_copy_prop_vars.c | 67 +---
> src/compiler/nir/nir_opt_dead_write_vars.c | 379 +
Replaces the existing dead write var removal that is done as part of
nir_opt_copy_prop_vars pass. The previous pass was per-block, so
it would not remove the dead write in a program like
int total = gl_VertexIndex * 10;
float r = gl_VertexIndex;
for (int i = 0; i < total; i++) {
---
src/compiler/nir/nir_deref.c | 111 +
src/compiler/nir/nir_deref.h | 10 ++
src/compiler/nir/nir_opt_copy_prop_vars.c | 145 ++
3 files changed, 134 insertions(+), 132 deletions(-)
diff --git a/src/compiler/nir/nir_deref.c
On Thu, May 24, 2018 at 4:16 AM, vadym.shovkoplias
wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104388
> Signed-off-by: Andriy Khulap
> ---
> src/mesa/drivers/dri/i965/genX_state_upload.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git
On Fri, Jul 27, 2018 at 5:08 PM, Eric Anholt wrote:
> Marek Olšák writes:
>
>> From: Marek Olšák
>>
>> v2: need to do MAX{start+count} instead of MAX{count}
>> added piglit tests
>> ---
>> src/gallium/auxiliary/util/u_vbuf.c | 199
>> 1 file changed, 175
We need to pass the new flip_y argument.
---
src/mesa/drivers/x11/xm_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/x11/xm_buffer.c b/src/mesa/drivers/x11/xm_buffer.c
index 97c7814..9c5383b 100644
--- a/src/mesa/drivers/x11/xm_buffer.c
+++
Reviewed-by: Brian Paul
On 07/27/2018 02:20 PM, Alexander von Gluck IV wrote:
Used by C++ code such as Haiku's renderer.
---
src/gallium/auxiliary/driver_ddebug/dd_public.h | 8
src/gallium/auxiliary/driver_noop/noop_public.h | 8
Marek Olšák writes:
> From: Marek Olšák
>
> v2: need to do MAX{start+count} instead of MAX{count}
> added piglit tests
> ---
> src/gallium/auxiliary/util/u_vbuf.c | 199
> 1 file changed, 175 insertions(+), 24 deletions(-)
>
> diff --git
Marek Olšák writes:
> From: Marek Olšák
>
> This will be used by indirect multidraws.
>
> v2: clean up the function further, change return types to unsigned
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing
On Fri, Jul 27, 2018 at 5:16 AM, Bas Nieuwenhuizen
wrote:
> Reviewed-by: Bas Nieuwenhuizen
>
> Does it occur often that they are different?
It depends on the size. FMASK has lower bpp and always 1 sample, so
the tiling is more likely to use 4K than 64K macrotiles.
Marek
>
> On Fri, Jul 27,
Looks good.
For series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, July 27, 2018 12:07:50 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] swrast: fix crash in AA line code when there's no
Used by C++ code such as Haiku's renderer.
---
src/gallium/auxiliary/driver_ddebug/dd_public.h | 8
src/gallium/auxiliary/driver_noop/noop_public.h | 8
.../auxiliary/target-helpers/inline_debug_helper.h | 9 -
3 files changed, 24 insertions(+), 1
Reviewed-by: Bruce Cherniak
> On Jul 27, 2018, at 1:45 PM, Denis Pauk wrote:
>
> Reuse Code from:
> f69bc797e1 gallium/auxiliary: Add helper support for bptc format
> compress/decompress
>
> Signed-off-by: Denis Pauk
> CC: Marek Olšák
> CC: Bruce Cherniak
> CC: Tim Rowley
> ---
>
On Mon 23 Jul 2018, Fritz Koenig wrote:
> Instead of using _mesa_is_winsys_fbo or
> _mesa_is_user_fbo to infer if an fbo is
> flipped use the InvertedY flag.
>
> v2:
> * additional window-system framebuffer checks [for jason]
> v3:
> * s/inverted_y/flip_y/g [for chadv]
> * s/InvertedY/FlipY/g
The xlib/swrast driver only supports GL 2.1. This patch fixes a
crash if the app calls glGetString(GL_SHADING_LANGUAGE_VERSION).
---
src/mesa/main/version.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index 58e68b4..2c5bd77 100644
---
Fixes a crash running the Piglit polygon-mode-facing test (and
probably others).
---
src/mesa/swrast/s_aalinetemp.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/mesa/swrast/s_aalinetemp.h b/src/mesa/swrast/s_aalinetemp.h
index bebb131..64767a3 100644
---
Reuse Code from:
f69bc797e1 gallium/auxiliary: Add helper support for bptc format
compress/decompress
Signed-off-by: Denis Pauk
CC: Marek Olšák
CC: Bruce Cherniak
CC: Tim Rowley
---
src/gallium/drivers/swr/swr_screen.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Hi Thomas,
On Thu, Jul 26, 2018 at 09:59:44PM +0200, Thomas Helland wrote:
> Since we're always going top-down through the
> program there should be no need to "walk backwards",
> so this approach should be enough to get the whole chain
> of assignments in one pass. Neat.
The patch that
> Caio Marcelo de Oliveira Filho (3):
> glsl: teach copy_propagation_elements to deal with whole variables
> glsl: use only copy_propagation_elements
> glsl: propagate full variables eagerly
Landed patches 1 and 2. Turned out patch 3 was not needed.
By Eric suggestion, I'll take a look at
El 27/07/18 a las 02:44, Francisco Jerez escribió:
> Chema Casanova writes:
>
>> El 26/07/18 a las 20:02, Francisco Jerez escribió:
>>> Chema Casanova writes:
>>>
El 20/07/18 a las 22:10, Francisco Jerez escribió:
> Chema Casanova writes:
>
>> El 20/07/18 a las 00:34,
These new methods return for a instruction register source/destination
the read/write byte pattern of the 32-byte GRF as an unsigned int.
The returned pattern takes into account the exec_size of the instruction,
the type bitsize, the register stride and a relative offset inside the
register.
The
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, July 27, 2018 7:21:53 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] mesa: move var decls in texstore_rgba()
Move them closer to where
https://bugs.freedesktop.org/show_bug.cgi?id=107369
--- Comment #12 from Gian-Carlo Pascutto ---
So the bugs are:
1) Debian adding flags even if they don't make sense (i.e. stack protection on
GPU code). Should be filed in Debian against libclc.
2) LLVM respecting that flag even if it
bump. I can add test to Crucible if it will help.
On 20.07.18 12:54, Danylo Piliaiev wrote:
Dual source blending behaviour is undefined when shader doesn't
have second color output.
"If SRC1 is included in a src/dst blend factor and
a DualSource RT Write message is not used, results
Hey Sergii,
Sorry for the late answer.
For the sake of clarity, I would split the changes (4096->PAGE_SIZE) and
the actual bug fix into 2 different patches.
I don't have see a problem with the PAGE_SIZE change.
Thanks a lot,
-
Lionel
On 25/07/18 14:24, Sergii Romantsov wrote:
Sorry,
do we
On 07/27/2018 04:39 PM, Bas Nieuwenhuizen wrote:
Did this pass CTS? If so, woot!
It did.
Reviewed-by: Bas Nieuwenhuizen
btw we can avoid some more, I think literally everything on Vega uses
L2 so the VERTEX_ATTRIBUTE_READ, TRANSFER_READ (this one could use CP
DMA, but not for images,
https://bugs.freedesktop.org/show_bug.cgi?id=107369
--- Comment #11 from Jan Vesely ---
GPUs don't really have a stack (not for data anyway) and AMDGCN backend
currently inlines all function calls anyway.
I'm not sure what kind of checks the flag adds.
If anyone can upload the different libclc
Hi Rafael,
Thanks a lot for reviewing the patch! Hopefully no one will have any
objections to push this.
Thanks,
Vadym
2018-07-26 18:11 GMT+03:00 Rafael Antognolli :
> Hi Vadym,
>
> Ken and Ian explained a bit the situation on this one to me, and it
> looks like neither of them are really
Did this pass CTS? If so, woot!
Reviewed-by: Bas Nieuwenhuizen
btw we can avoid some more, I think literally everything on Vega uses
L2 so the VERTEX_ATTRIBUTE_READ, TRANSFER_READ (this one could use CP
DMA, but not for images, and CP DMA can be configured to go through
L2) and
The pointer will always be NULL since that's what we just tested for.
---
src/mesa/main/texstore.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
index 31163f6..c7a459e 100644
--- a/src/mesa/main/texstore.c
+++ b/src/mesa/main/texstore.c
@@
Move them closer to where they're first used.
---
src/mesa/main/texstore.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
index c7a459e..55f66c5 100644
--- a/src/mesa/main/texstore.c
+++
Hi,
On Thu, 26 Jul 2018 at 19:53, Eric Anholt wrote:
>
> Olivier Fourdan writes:
>
> > get_supported_modifiers() and pixmap_from_buffers() requests both
> > expect a window as drawable, passing a pixmap will fail as the Xserver
> > will fail to match the given drawable to a window.
> >
> > That
Single-sample color and single-sample depth (not stencil)
are coherent with shaders.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c
Hi everyone,
I present to you the mesa 18.1.5 release, available now. The 18.1.5 cycle has
been rather busy, in fact, it's the busiest cycle since 18.1.2! Radv has gotten
the most work this cycle, with intel, nir, and the android build system coming
up
behind it. Also getting various fixes this
On 27 July 2018 at 00:18, David Riley wrote:
> I understand and agree with your comments about kms_swrast requiring KMS and
> not wanting to change those semantics.
>
> I'm not quite sure I follow all the rest of your suggestions (new to this
> entire code base). You're suggesting that
On 26 July 2018 at 18:38, John Stultz wrote:
> On Thu, Jul 26, 2018 at 6:46 AM, Emil Velikov
> wrote:
>> On 25 July 2018 at 20:52, John Stultz wrote:
>>> On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov
>>> wrote:
On 25 July 2018 at 00:21, John Stultz wrote:
> From: Yong Yao
>
On Thu, 2018-07-26 at 11:30 +0200, Chema Casanova wrote:
> Please include:
>
> Fixes: 5a12bdac09496e00 "i965/compiler: handle conversion to smaller
> type in the lowering pass for that"
This is not specifically fixing that commit, the problem has been there
before that
From: Iago Toral Quiroga
---
src/intel/compiler/brw_fs_nir.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/intel/compiler/brw_fs_nir.cpp
b/src/intel/compiler/brw_fs_nir.cpp
index 2c8595b9730..6e9a5829d3b 100644
--- a/src/intel/compiler/brw_fs_nir.cpp
+++
New VK-GL-CTS tests that use VK_KHR_8bit_storage extension use
32-bit constants that are converted to 8-bit and there are stored in a
storage buffer.
Although 8-bit constants are not enabled by VK_KHR_8bit_storage
nir_opt_constant_folding already optimizes the 32 -> 8 integer
conversion to a
From: Iago Toral Quiroga
The hardware doesn't support byte immediates, so similar to setup_imm_df()
for doubles, these helpers work by loading the constant value into a
VGRF.
---
src/intel/compiler/brw_fs.h | 6 ++
src/intel/compiler/brw_fs_nir.cpp | 16
2 files
Reviewed-by: Bas Nieuwenhuizen
for the series
On Fri, Jul 27, 2018 at 11:28 AM, Samuel Pitoiset
wrote:
> This wasn't wrong but it looks better to me like this. It's
> only used for debugging purposes (ie. RADV_TRACE_FILE).
>
> Signed-off-by: Samuel Pitoiset
> ---
>
https://bugs.freedesktop.org/show_bug.cgi?id=107351
--- Comment #13 from Mauro Rossi ---
Hi,
but the sequence of ALOGD customized LOG_TAG RADV log does tell that the line
invoking pAllocator argument was the first not being executed, and thus is
involved in the segfault,
could you please give
Reviewed-by: Bas Nieuwenhuizeh
for the series.
On Fri, Jul 27, 2018 at 11:55 AM, Samuel Pitoiset
wrote:
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 31 +++
> 1 file changed, 23 insertions(+), 8 deletions(-)
>
> diff --git
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 31 +++
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index f9f57a1065..2e65be4f30 100644
---
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/si_cmd_buffer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index e2bdbe889a..2337036c67 100644
--- a/src/amd/vulkan/si_cmd_buffer.c
+++
On 27/07/18 19:10, Bas Nieuwenhuizen wrote:
On Fri, Jul 27, 2018 at 7:32 AM, Timothy Arceri wrote:
Because this was setting image to true we would end up calling
si_load_image_desc() when we sould be calling
si_load_sampler_desc().
Since the descriptor is part of an image, not a sampler,
https://bugs.freedesktop.org/show_bug.cgi?id=107385
Michel Dänzer changed:
What|Removed |Added
Version|unspecified |git
This wasn't wrong but it looks better to me like this. It's
only used for debugging purposes (ie. RADV_TRACE_FILE).
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git
The driver might emit up to 4 dwords when RADV_TRACE_FILE is
used.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 131ea18b15..064eeb1c03 100644
https://bugs.freedesktop.org/show_bug.cgi?id=102315
Denis changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #1 from Denis ---
Hi
Reviewed-by: Bas Nieuwenhuizen
Does it occur often that they are different?
On Fri, Jul 27, 2018 at 5:36 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> a needle in the haystack?
>
> Cc: 18.1
> ---
> src/amd/common/ac_surface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On Fri, Jul 27, 2018 at 7:32 AM, Timothy Arceri wrote:
> Because this was setting image to true we would end up calling
> si_load_image_desc() when we sould be calling
> si_load_sampler_desc().
Since the descriptor is part of an image, not a sampler,
get_image_descriptor looks like the right
Reviewed-by: Bas Nieuwenhuizen
Fixes: 506a07e4e3a "ac/nir: Add deref support to image intrinsics."
On Fri, Jul 27, 2018 at 7:08 AM, Timothy Arceri wrote:
> Looks like a mistake from when the deref stuff landed.
>
> Fixes: 506a07e4e3a4 ("ac/nir: Add deref support to image intrinsics.")
>
> Cc:
Hello, Kenneth and Lionel.
Maybe, could we make a final review?
On Wed, Jul 25, 2018 at 4:24 PM, Sergii Romantsov <
sergii.romant...@globallogic.com> wrote:
> Sorry,
> do we have any objections about PAGE_SIZE usage instead of 4096?
>
> And what do you think if, maybe, some auto Intel-internal
https://bugs.freedesktop.org/show_bug.cgi?id=107224
--- Comment #7 from Alex Smith ---
Thanks for confirming.
It looks like we have a bug where we fail to identify Mesa properly as a result
of compatibility profile support being added, which causes us to go down a path
for a different driver
https://bugs.freedesktop.org/show_bug.cgi?id=107369
Gian-Carlo Pascutto changed:
What|Removed |Added
Summary|"volatile" in OpenCL code |"volatile" in OpenCL code
Series is:
Reviewed-by: Samuel Pitoiset
On 07/27/2018 06:22 AM, Dave Airlie wrote:
From: Dave Airlie
If we have tracing enabled we could do all the tracing emits
and overflow the precalculated cdw_max.
---
src/amd/vulkan/radv_cmd_buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2
This just makes sure we're currently up-to-date with what
virglrenderer has.
---
src/gallium/drivers/virgl/virgl_hw.h | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/virgl/virgl_hw.h
b/src/gallium/drivers/virgl/virgl_hw.h
index
This matches what this field is called in virglrenderer's copy of
this.
While we're at it, fixup the indentation.
This reduces the diff between the two different versions of
virgl_hw.h, and should make it easier to upgrade the file in
the future.
---
src/gallium/drivers/virgl/virgl_context.c |
Here's a few patches to get the delta between our copy of virgl_hw.h and the
copy in the virglrenderer repository as small as possible.
The goal is to make it easier to track this file in the future by simply
copying the new version of the file on top of the old.
Changes since v2:
- Rebased on
On Thu, Jul 26, 2018 at 12:28 PM John Stultz wrote:
>
> From: Sumit Semwal
>
> This is a forward port of a patch from the AOSP/master tree:
> https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/
>
> Since
https://bugs.freedesktop.org/show_bug.cgi?id=107385
Michel Dänzer changed:
What|Removed |Added
Attachment #140844|text/x-log |text/plain
mime type|
https://bugs.freedesktop.org/show_bug.cgi?id=107369
--- Comment #9 from infini...@pwned.gg ---
I guess a third possibility is that stack protectors are actually relevant for
GPUs but Clang/LLVM is not generating correct code for those in this case.
--
You are receiving this mail because:
You
https://bugs.freedesktop.org/show_bug.cgi?id=107369
--- Comment #8 from infini...@pwned.gg ---
For background, this is the CFLAGS that Debian passes when compiling all C
programs. From the GCC man page:
-fstack-protector
Emit extra code to check for buffer overflows, such as stack smashing
76 matches
Mail list logo
