[Mesa-dev] [PATCH] egl: Fix -Wint-to-pointer-cast

main/egldisplay.c: In function '_eglParseX11DisplayAttribList': main/egldisplay.c:491:38: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] display->Options.Platform = (void *)value; The fix: cast to uinptr_t before void*.

Re: [Mesa-dev] [PATCH 3/3] egl/android: Mark surface as lost when dequeueBuffer fails

On Thu, May 4, 2017, at 05:42 AM, Emil Velikov wrote: > Hi Chad, > > On 4 May 2017 at 00:47, Chad Versace <chadvers...@chromium.org> wrote: > > From: Chad Versace <c...@kiwitree.net> > > > > This ensures that future calls to eglSwapBuffe

Re: [Mesa-dev] [PATCH] egl/android: Set EGLSurface.Lost to EGL_TRUE/EGL_FALSE

l/android: Cancel any outstanding ANativeBuffer in > surface destructor") > --- > src/egl/drivers/dri2/platform_android.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> And pushed. __

Re: [Mesa-dev] [PATCH 3/3] egl/android: Mark surface as lost when dequeueBuffer fails

On Thu 04 May 2017, Emil Velikov wrote: > Hi Chad, > > On 4 May 2017 at 00:47, Chad Versace <chadvers...@chromium.org> wrote: > > From: Chad Versace <c...@kiwitree.net> > > > > This ensures that future calls to eglSwapBuffers and eglMakeCurrent emit &

[Mesa-dev] [PATCH 1/3] egl: Emit error when EGLSurface is lost

From: Chad Versace <c...@kiwitree.net> Add a new bool, _EGLSurface::Lost, and check it in eglMakeCurrent and eglSwapBuffers. The EGL 1.5 spec says that those functions emit errors when the native surface is no longer valid. This patch just updates core EGL. No driver sets _EGLSurface::Lo

[Mesa-dev] [PATCH 3/3] egl/android: Mark surface as lost when dequeueBuffer fails

From: Chad Versace <c...@kiwitree.net> This ensures that future calls to eglSwapBuffers and eglMakeCurrent emit an error. This patch is part of a series for fixing android.hardware.camera2.cts.RobustnessTest#testAbandonRepeatingRequestSurface on Chrome OS x86 devices. Cc: Tomasz Fi

[Mesa-dev] [PATCH 2/3] egl/android: Cancel any outstanding ANativeBuffer in surface destructor

From: Chad Versace <c...@kiwitree.net> That is, call ANativeWindow::cancelBuffer in droid_destroy_surface(). This should prevent application deadlock when the app destroys the EGLSurface after EGL has acquired a buffer from SurfaceFlinger (ANativeWindow::dequeueBuffer) but before E

Re: [Mesa-dev] [PATCH 16/21] anv: Implement VK_KHX_external_semaphore_fd

On Wed 03 May 2017, Jason Ekstrand wrote: > On Tue, May 2, 2017 at 5:15 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Fri 14 Apr 2017, Jason Ekstrand wrote: > > This implementation allocates a 4k BO for each semaphore that can be > > exp

Re: [Mesa-dev] [PATCH 18/21] anv: Implement support for exporting semaphores as FENCE_FD

I'm stopping here for today and will resume tomorrow. On Fri 14 Apr 2017, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_batch_chain.c | 96 > -- > src/intel/vulkan/anv_device.c | 25 ++ > src/intel/vulkan/anv_gem.c | 36

Re: [Mesa-dev] [PATCH 17/21] anv/gem: Use EXECBUFFER2_WR when the FENCE_OUT flag is set

+ if (execbuf->flags & I915_EXEC_FENCE_OUT) > + return anv_ioctl(device->fd, DRM_IOCTL_I915_GEM_EXECBUFFER2_WR, > execbuf); > + else > + return anv_ioctl(device->fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, execbuf); > } Reviewed-by: Chad Versace <chadvers...@chromium.org&

Re: [Mesa-dev] [PATCH 15/21] anv: Pull the guts of cmd_buffer_execbuf into a helper

Patches 10-15 are Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 16/21] anv: Implement VK_KHX_external_semaphore_fd

On Fri 14 Apr 2017, Jason Ekstrand wrote: > This implementation allocates a 4k BO for each semaphore that can be > exported using OPAQUE_FD and uses the kernel's already-existing > synchronization mechanism on BOs. > --- > src/intel/vulkan/anv_batch_chain.c | 53 ++-- >

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

On Sat 29 Apr 2017, Xu, Randy wrote: > > -Original Message- > > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > > Sent: Saturday, April 29, 2017 8:36 PM > > To: Chad Versace <chadvers...@chromium.org>; Emil Velikov > > <emil.l.veli...@gmail.com

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

transfer fd ownership to the driver, and therefore no dup is needed. But that's a slightly more invasive change that's not as easily backported to stable. Reviewed-by: Chad Versace <chadvers...@chromium.org> Cc: mesa-sta...@lists.freedesktop.org Emil, how about one of us appends your extended

[Mesa-dev] [PATCH] anv: Drop 'x11' prefix from non-X11 WSI funcs

Drop it from x11_anv_wsi_image_create and x11_anv_wsi_image_free. The functions are used by Wayland WSI too. --- src/intel/vulkan/anv_wsi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/anv_wsi.c

Re: [Mesa-dev] [PATCH 08/21] anv/allocator: Add a BO cache

set(struct anv_cache_bo, bo) == 0. It should really be rewritten to avoid the dereference after lookup failures. > +} Fix those three issues, and this patch will be Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 03/21] anv: Set EXEC_OBJECT_ASYNC when available

On Fri 14 Apr 2017, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_allocator.c | 3 +++ > src/intel/vulkan/anv_device.c| 5 + > src/intel/vulkan/anv_private.h | 1 + > src/intel/vulkan/anv_wsi.c | 1 + > 4 files changed, 10 insertions(+) Patch 3 is Reviewe

Re: [Mesa-dev] [PATCH 02/21] anv/cmd_buffer: Use the device allocator for QueueSubmit

.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 14/18] anv/cmd_buffer: Use the device allocator for QueueSubmit

t;bo, _buffer->surface_relocs, > - _buffer->pool->alloc); > + >alloc); Yep. vkQueueSubmit allows the submitted command buffers to come from different pools. The fix looks good. Reviewed-by: Chad Versace <chadvers...@chromium.org> [...] __

Re: [Mesa-dev] [PATCH v2 12/18] anv: Implement VK_KHX_external_semaphore_capabilities

vulkan/anv_queue.c| 13 + > 3 files changed, 18 insertions(+) That's simple enough. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 11/18] anv: Add a real semaphore struct

could just be a dummy for use Typo s/semaphores0/semaphores/ Other than the type, Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv/allocator: Add a BO cache

size doesn't match the prime fd size as >reported by lseek(). > > v3 (Jason Ekstrand): > - Get rid of the alloc parameter to all of the calls and just use >device->alloc instead. > - Allocate the correct amount of memory for the anv_cached_bo structure. > &g

Re: [Mesa-dev] [PATCH 00/53] i965: Eat libdrm_intel for breakfast

On Tue 04 Apr 2017, Kenneth Graunke wrote: > This series imports libdrm_intel into the i965 driver, hacks and > slashes it down to size, and greatly simplifies our relocation > handling. You did it! IT'S FINALLY HAPPENING!!! Thanks for taking the leap. >

Re: [Mesa-dev] [PATCH] intel/isl: Refactor and clerify gen8 alignment calculations

isl_gen8.c | 64 > > 1 file changed, 49 insertions(+), 15 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freed

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Mon 03 Apr 2017, Jason Ekstrand wrote: > On Mon, Apr 3, 2017 at 3:45 PM, Chad Versace <chadvers...@chromium.org> wrote: > > On Mon 03 Apr 2017, Jason Ekstrand wrote: > > > On Mon, Apr 3, 2017 at 12:31 PM, Chad Versace <chadvers...@chromium.org> > > >

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Mon 03 Apr 2017, Jason Ekstrand wrote: > On Mon, Apr 3, 2017 at 5:19 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > > On Wed 15 Mar 2017, Jason Ekstrand wrote: > > > This cache allows us to easily ensure that we have a unique anv_bo for >

Re: [Mesa-dev] [PATCH v2 10/18] anv: Move queues, events, and semaphores to their own file

WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > +# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > DEALINGS > +# IN THE SOFTWARE. Oops. This patch adds an extra Makefile.sources. Other than the dup'd file, patch 10 is Reviewed-by: Chad Versace <

Re: [Mesa-dev] [PATCH v2 09/18] anv: Implement VK_KHX_external_memory_fd

KHX. Reduces diff in > future dma_buf patches. > > Co-authored-with: Chad Versace <chadvers...@chromium.org> > --- > src/intel/vulkan/anv_device.c | 71 > - > src/intel/vulkan/anv_entrypoints_gen.py | 1 + &g

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Wed 15 Mar 2017, Jason Ekstrand wrote: > This cache allows us to easily ensure that we have a unique anv_bo for > each gem handle. We'll need this in order to support multiple-import of > memory objects and semaphores. > > v2 (Jason Ekstrand): > - Reject BO imports if the size doesn't match

Re: [Mesa-dev] [PATCH v2 08/18] anv: Use the BO cache for DeviceMemory allocations

anv_wsi.c | 6 +++--- > 5 files changed, 29 insertions(+), 24 deletions(-) Patch 8 is Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Wed 15 Mar 2017, Jason Ekstrand wrote: > This cache allows us to easily ensure that we have a unique anv_bo for > each gem handle. We'll need this in order to support multiple-import of > memory objects and semaphores. > > v2 (Jason Ekstrand): > - Reject BO imports if the size doesn't match

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Fri 31 Mar 2017, Chad Versace wrote: > On Wed 15 Mar 2017, Jason Ekstrand wrote: > > This cache allows us to easily ensure that we have a unique anv_bo for > > each gem handle. We'll need this in order to support multiple-import of > > memory objects and semaphores. > &

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Wed 15 Mar 2017, Jason Ekstrand wrote: > This cache allows us to easily ensure that we have a unique anv_bo for > each gem handle. We'll need this in order to support multiple-import of > memory objects and semaphores. > > v2 (Jason Ekstrand): > - Reject BO imports if the size doesn't match

Re: [Mesa-dev] [PATCH v2 06/18] anv: Implement VK_KHX_external_memory

On Thu 30 Mar 2017, Jason Ekstrand wrote: > On Thu, Mar 30, 2017 at 11:27 AM, Chad Versace <chadvers...@chromium.org> > wrote: > > > On Mon 13 Mar 2017, Jason Ekstrand wrote: > > > There's really nothing for us to do here. So long as the user doesn't > > &

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Wed 15 Mar 2017, Jason Ekstrand wrote: > This cache allows us to easily ensure that we have a unique anv_bo for > each gem handle. We'll need this in order to support multiple-import of > memory objects and semaphores. > > v2 (Jason Ekstrand): > - Reject BO imports if the size doesn't match

Re: [Mesa-dev] [PATCH v2 06/18] anv: Implement VK_KHX_external_memory

On Mon 13 Mar 2017, Jason Ekstrand wrote: > There's really nothing for us to do here. So long as the user doesn't > set any crazy environment variables such as INTEL_VK_HIZ=false, all of > the compression formats etc. should "just work" at least for opaque > handle types. I think the commit

Re: [Mesa-dev] [PATCH v2 05/18] anv: Implement VK_KHX_external_memory_capabilities

On Mon 13 Mar 2017, Jason Ekstrand wrote: > From: Chad Versace <chadvers...@chromium.org> > > This is a complete but trivial implementation. It's trivial becasue We > support no external memory capabilities yet. Most of the real work in > this commit is in reworking

Re: [Mesa-dev] [PATCH v2 04/18] util/vk: Add helpers for finding an extension struct

Already upstream. On Mon 13 Mar 2017, Jason Ekstrand wrote: > --- > src/util/vk_util.h | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/util/vk_util.h b/src/util/vk_util.h > index e0b5d0b..0b9cb47 100644 > --- a/src/util/vk_util.h > +++ b/src/util/vk_util.h > @@

Re: [Mesa-dev] [PATCH v2 03/18] anv/physical_device: Rename uuid to pipeline_cache_uuid

ivate.h| 2 +- > 3 files changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 02/18] anv: Refactor device_get_cache_uuid into physical_device_init_uuids

It should be a SHA-1 */ > - return false; > + if (build_id_len < 20) { > + return vk_errorf(VK_ERROR_INITIALIZATION_FAILED, > + "build-id too short. It needs to be a SHA"); In above line, s/SHA/SHA-1/, to distinguish from SHA-2 and SHA-3 Wi

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

On Tue 28 Mar 2017, Emil Velikov wrote: > Hi Chad, > > On 25 March 2017 at 02:28, Chad Versace <chadvers...@chromium.org> wrote: > > genX_bits.h contains the sizes of bitfields in genxml instructions, > > structures, and registers. It also defines some functio

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

On Sat 25 Mar 2017, Dylan Baker wrote: > Oh, for what it's worth (since I wrote part of this), with the one .keys() > thing > changed: > Reviewed-by: Dylan Baker Thanks ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

On Sat 25 Mar 2017, Dylan Baker wrote: > Quoting Chad Versace (2017-03-24 19:28:23) > > genX_bits.h contains the sizes of bitfields in genxml instructions, > > structures, and registers. It also defines some functions to query those > > sizes. > > > > isl_su

Re: [Mesa-dev] [PATCH v5 2/5] isl: Validate the calculated row pitch (v4)

On Sat 25 Mar 2017, Jason Ekstrand wrote: > > > On March 24, 2017 7:29:05 PM Chad Versace <chadvers...@chromium.org> wrote: > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > &

[Mesa-dev] [PATCH v5 4/5] intel: Fix requests for exact surface row pitch (v2)

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. v2: Assert that isl_surf_init() succeeds because the callers assume it.

[Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

__attribute__((pure)) CONTAINER_Field_bits(const struct gen_device_info *devinfo); v2 (Chad Versace): - Parse the XML instead of scraping the generated gen*_pack.h headers. v3 (Dylan Baker): - Port to Mako. v4 (Jason Ekstrand): - Make the _bits functions take a gen_device_info. v5

[Mesa-dev] [PATCH v5 2/5] isl: Validate the calculated row pitch (v4)

Validate that isl_surf::row_pitch fits in the below bitfields, if applicable based on isl_surf::usage. RENDER_SURFACE_STATE::SurfacePitch RENDER_SURFACE_STATE::AuxiliarySurfacePitch 3DSTATE_DEPTH_BUFFER::SurfacePitch 3DSTATE_HIER_DEPTH_BUFFER::SurfacePitch v2: -Add a Makefile

[Mesa-dev] [PATCH v5 5/5] isl: Drop unused isl_surf_init_info::min_pitch

Reviewed-by: Nanley Chery Reviewed-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.c | 13 +++-- src/intel/isl/isl.h | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH v5 3/5] isl: Let isl_surf_init's caller set the exact row pitch (v2)

The caller does so by setting the new field isl_surf_init_info::row_pitch. v2: Validate the requested row_pitch. Reviewed-by: Jason Ekstrand (v2) --- src/intel/isl/isl.c | 14 +- src/intel/isl/isl.h | 6 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v5 0/5] isl: Fix requests for exact row pitch

/android-ia/manifest. - Fixes and cleanups to generator script. See patch's version log. Chad Versace (5): genxml: New generated header genX_bits.h (v5) isl: Validate the calculated row pitch (v4) isl: Let isl_surf_init's caller set the exact row pitch (v2) intel: Fix requests for exact

Re: [Mesa-dev] [PATCH 7/8] genxml: Whitespace fixes

Patches 6 and 7 are Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/8] genxml/gen6: Remove a couple of bogus values

On Fri 24 Mar 2017, Jason Ekstrand wrote: > --- > src/intel/genxml/gen6.xml | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Thanks. I discovered these in writing my patches, but forgot to fix them. Reviewed-by: Chad Versace <chadvers...@

Re: [Mesa-dev] [PATCH 4/8] genxml/gen8: Remove BLACK_LEVEL_CORRECTION_STATE

On Fri 24 Mar 2017, Jason Ekstrand wrote: > We've never used it, it only exists on gen8, and the name of the struct > contains piles of bad characters. > --- > src/intel/genxml/gen8.xml | 6 -- > 1 file changed, 6 deletions(-) > - wtf. Reviewed-by: Chad Versace <cha

Re: [Mesa-dev] [PATCH 2/8] genxml: Fix gen_zipped_file.py dependency

Patches 1 and 2 are pushed, with Emil's r-b. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/8] genxml: Rename two MCS fields to Auxiliary Surface on gen7

tions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue 21 Mar 2017, Matt Turner wrote: > On Tue, Mar 21, 2017 at 10:16 AM, Emil Velikov > wrote: > > On 21 March 2017 at 15:57, Matt Turner wrote: > >> On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov > >> wrote: > >>> On

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue 21 Mar 2017, Matt Turner wrote: > On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov > wrote: > > On 20 March 2017 at 18:30, Matt Turner wrote: > >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov > >> wrote: > >>>

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

On Thu 23 Mar 2017, Jason Ekstrand wrote: > On Wed, Mar 22, 2017 at 6:04 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > >

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

On Fri 24 Mar 2017, Emil Velikov wrote: > Hi Chad, > > On 23 March 2017 at 01:04, Chad Versace <chadvers...@chromium.org> wrote: > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > >

[Mesa-dev] [PATCH 3/9] genxml: New generated header genX_bits.h (v2)

genX_bits.h contains the sizes of bitfields in genxml instructions, structures, and registers. It also defines some functions to query those sizes. isl_surf_init() will use the new header to validate that requested pitches fit in their destination bitfields. What's currently in genX_bits.h: -

[Mesa-dev] [PATCH 7/9] isl: Let isl_surf_init's caller set the exact row pitch (v2)

The caller does so by setting the new field isl_surf_init_info::row_pitch. v2: Validate the requested row_pitch. Reviewed-by: Jason Ekstrand (v2) --- src/intel/isl/isl.c | 14 +- src/intel/isl/isl.h | 6 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 5/9] intel/common: Add func gen_get_version_10x()

It does the obvious. bdw => 80 hsw => 75 ivb => 70 ... g4x => 45 --- src/intel/common/gen_device_info.c | 11 +++ src/intel/common/gen_device_info.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/src/intel/common/gen_device_info.c

[Mesa-dev] [PATCH 8/9] intel: Fix requests for exact surface row pitch (v2)

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. v2: Assert that isl_surf_init() succeeds because the callers assume it.

[Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

Validate that isl_surf::row_pitch fits in the below bitfields, if applicable based on isl_surf::usage. RENDER_SURFACE_STATE::SurfacePitch RENDER_SURFACE_STATE::AuxiliarySurfacePitch 3DSTATE_DEPTH_BUFFER::SurfacePitch 3DSTATE_HIER_DEPTH_BUFFER::SurfacePitch v2: Add a Makefile

[Mesa-dev] [PATCH 9/9] isl: Drop unused isl_surf_init_info::min_pitch

Reviewed-by: Nanley Chery Reviewed-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.c | 13 +++-- src/intel/isl/isl.h | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 2/9] genxml: Fix gen_zipped_file.py dependency

The gen*_xml.h files depend on gen_zipped_file.py, not the gen*_pack.h files. --- src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index eab6ccd208d..01a02b63b44 100644 ---

[Mesa-dev] [PATCH 4/9] genxml: Add 3DSTATE_DEPTH_BUFFER to gen5.xml

isl will use this for validating the depth buffer pitch. --- src/intel/genxml/gen5.xml | 56 +++ 1 file changed, 56 insertions(+) diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml index 39fec3723f6..97c13699673 100644 ---

[Mesa-dev] [PATCH 0/9] isl: Fix requests for exact row pitch (v4)

to view the Jenkins results, because they're behind the Intel firewall. Chad Versace (9): genxml: Define GENXML_XML_FILES in Makefile.sources genxml: Fix gen_zipped_file.py dependency genxml: New generated header genX_bits.h (v2) genxml: Add 3DSTATE_DEPTH_BUFFER to gen5.xml intel/common

[Mesa-dev] [PATCH 1/9] genxml: Define GENXML_XML_FILES in Makefile.sources

The future header genX_bits.h will depend on GENXML_XML_FILES. --- src/intel/Makefile.genxml.am | 9 + src/intel/Makefile.sources | 10 ++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

On Wed 22 Mar 2017, Jason Ekstrand wrote: > On Wed, Mar 22, 2017 at 2:02 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > > On Wed 22 Mar 2017, Jason Ekstrand wrote: > > > Wow... This is an impressive quantity of infastructure just to get the &

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

. > There's a few small requests below, but don't bother if they're too > time consuming. > > On 21 March 2017 at 23:02, Chad Versace <chadvers...@chromium.org> wrote: > > > +genxml/genX_bits.h: genxml/gen_bits_header.py > > +genxml/genX_bits.h: $(GENXML_

Re: [Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

That's why we have the genxml, after all. > On Tue, Mar 21, 2017 at 4:02 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > +REGEX = re.compile('^#define (?PGEN(?P[0- > > 9]+)_(?P\w*Surface(Q?)Pitch)_bits).*$') > > > > Can we please not use XML to gen

Re: [Mesa-dev] [PATCH] i965: Add the Haswell OA generated files to .gitignore

I believe 72c89522c23e54ef19d0a8a7fd85f791727a05d6 already does this. On Tue 21 Mar 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 src/mesa/drivers/dri/i965/.gitignore > > diff --git

Re: [Mesa-dev] [PATCH] anv/image: Return early when unbinding an image

On Tue 21 Mar 2017, Jason Ekstrand wrote: > Found by inspection. > > Cc: "17.0 13.0" <mesa-sta...@lists.freedesktop.org> > --- > src/intel/vulkan/anv_image.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Chad

[Mesa-dev] [PATCH 8/8] isl: Drop unused isl_surf_init_info::min_pitch

Reviewed-by: Nanley Chery Reviewed-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.c | 13 +++-- src/intel/isl/isl.h | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 4/8] intel/common: Add func gen_get_version_10x()

It does the obvious. bdw => 80 hsw => 75 ivb => 70 ... g4x => 45 --- src/intel/common/gen_device_info.c | 11 +++ src/intel/common/gen_device_info.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/src/intel/common/gen_device_info.c

[Mesa-dev] [PATCH 3/8] genxml: Add 3DSTATE_DEPTH_BUFFER to gen5.xml

isl will use this for validating the depth buffer pitch. --- src/intel/genxml/gen5.xml | 56 +++ 1 file changed, 56 insertions(+) diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml index 39fec3723f6..97c13699673 100644 ---

[Mesa-dev] [PATCH 5/8] isl: Validate the calculated row pitch

Validate that isl_surf::row_pitch fits in the below bitfields, if applicable based on isl_surf::usage. RENDER_SURFACE_STATE::SurfacePitch RENDER_SURFACE_STATE::AuxiliarySurfacePitch 3DSTATE_DEPTH_BUFFER::SurfacePitch 3DSTATE_HIER_DEPTH_BUFFER::SurfacePitch --- src/intel/isl/isl.c

[Mesa-dev] [PATCH 2/8] genxml: Generate header genX_bits.h

genX_bits.h contains the sizes of bitfields in genxml instructions, structures, and registers. It also defines some functions to query those sizes. Currently, the bitfields in genX_bits.h are those whose name matches /.*Surface(Q?)Pitch/. isl_surf_init() will use the new header to validate that

[Mesa-dev] [PATCH 1/8] genxml: Add pitch bitfield sizes to gen*_pack.h

For each structure or instruction member in gen*_pack.h whose name matches /.*Surface(Q?)Pitch$", add a macro that defines the member's bitfield size. isl will use these macros to validate requested pitches. Example: Changes to RENDER_SURFACE_STATE in gen9_pack.h: #define

[Mesa-dev] [PATCH 0/8] isl: Fix requests for exact row pitch (v2)

from genX_bits.h. Testing: I'm locally running dEQP-VK on Skylake. One failure in dEQP-VK.memory.*, dEQP-VK.api.*. I also pushed this to my 'jenkins' branch. But I no longer know to view the Jenkins results, because they're behind the Intel firewall. Chad Versace (8): genxml: Add pitch

[Mesa-dev] [PATCH 6/8] isl: Let isl_surf_init's caller set the exact row pitch (v2)

The caller does so by setting the new field isl_surf_init_info::row_pitch. v2: Validate the requested row_pitch. Reviewed-by: Jason Ekstrand (v2) --- src/intel/isl/isl.c | 14 +- src/intel/isl/isl.h | 6 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 7/8] intel: Fix requests for exact surface row pitch (v2)

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. v2: Assert that isl_surf_init() succeeds because the callers assume it.

Re: [Mesa-dev] [PATCH 6/7] intel: Fix requests for exact surface row pitch

On Wed 15 Mar 2017, Jason Ekstrand wrote: > They should probably assert that isl_surf_init succeeds instead. Good point. I'll fix that. > > On Mon, Mar 13, 2017 at 3:28 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > > All callers of isl_surf_init() that

Re: [Mesa-dev] [PATCH 4/7] isl: Validate the calculated row pitch

On Wed 15 Mar 2017, Jason Ekstrand wrote: > Fun story: This will implicitly handle the (invalid) case of trying to > create a MCS for a 16xMSAA surface that's more than 8k wide. :-) We may > want to keep the check in init_mcs for clarity and because it's in the docs > but the extra validation is

Re: [Mesa-dev] [PATCH 4/7] isl: Validate the calculated row pitch

On Wed 15 Mar 2017, Jason Ekstrand wrote: > On Wed, Mar 15, 2017 at 3:34 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > > On Mon, Mar 13, 2017 at 03:28:01PM -0700, Chad Versace wrote: > > > Validate that it fits in RENDER_SURFACE_STATE::SurfacePitch or, i

Re: [Mesa-dev] [PATCH 3/7] isl: Add func isl_tiling_is_aux()

On Wed 15 Mar 2017, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 3:28 PM, Chad Versace <chadvers...@chromium.org> > wrote: > > > --- > > src/intel/isl/isl.h | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/src/intel/isl/isl.

[Mesa-dev] [PATCH 4/7] isl: Validate the calculated row pitch

Validate that it fits in RENDER_SURFACE_STATE::SurfacePitch or, if it's an aux surface, AuxiliarySurfacePitch. --- src/intel/isl/isl.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

[Mesa-dev] [PATCH 1/7] isl: Drop misplaced comment about padding

isl has a giant comment that explains the hardware's padding requirements. (Hint: Cache lines and page faults). But the comment is in the wrong place, in isl_calc_linear_row_pitch(), which is unrelated to padding. The important parts of that comment were copied to isl_apply_surface_padding() long

[Mesa-dev] [PATCH 3/7] isl: Add func isl_tiling_is_aux()

--- src/intel/isl/isl.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 9d92906ca71..b79793b0c93 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -473,6 +473,9 @@ typedef uint32_t isl_tiling_flags_t; /** The Skylake BSpec

[Mesa-dev] [PATCH 5/7] isl: Let isl_surf_init's caller set the exact row pitch (v2)

The caller does so by setting the new field isl_surf_init_info::row_pitch. v2: - Validate the requested row_pitch. --- src/intel/isl/isl.c | 14 +- src/intel/isl/isl.h | 6 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 6/7] intel: Fix requests for exact surface row pitch

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. Reviewed-by: Nanley Chery Reviewed-by: Anuj

[Mesa-dev] [PATCH 7/7] isl: Drop unused isl_surf_init_info::min_pitch

Reviewed-by: Nanley Chery Reviewed-by: Anuj Phogat --- src/intel/isl/isl.c | 13 +++-- src/intel/isl/isl.h | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

[Mesa-dev] [PATCH 2/7] isl: Refactor row pitch calculation (v2)

The calculations of row_pitch, the row pitch's alignment, surface size, and base_alignment were mixed together. This patch moves the calculation of row_pitch and its alignment to occur before the calculation of surface_size and base_alignment. This simplifies a follow-on patch that adds a new

[Mesa-dev] [PATCH 0/6] isl: Fix requests for exact row pitch (v2)

v2: - Validate the requested row pitch. This required more extensive refactors in patch 2. Testing: I'm locally running dEQP-VK. I also pushed this to my 'jenkins' branch. But I no longer know to view the Jenkins results, because they're behind the Intel firewall. Chad Versace (7

Re: [Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

On Mon 13 Mar 2017, Chad Versace wrote: > On Mon 13 Mar 2017, Jason Ekstrand wrote: > > On Mon, Mar 13, 2017 at 2:32 PM, Jason Ekstrand <ja...@jlekstrand.net> > > wrote: > > > > > On Mon, Mar 13, 2017 at 2:23 PM, Chad Versace <chadvers...@chromium.org> &g

Re: [Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

On Mon 13 Mar 2017, Jason Ekstrand wrote: > On Mon, Mar 13, 2017 at 2:32 PM, Jason Ekstrand <ja...@jlekstrand.net> > wrote: > > > On Mon, Mar 13, 2017 at 2:23 PM, Chad Versace <chadvers...@chromium.org> > > wrote: > > > >> No intended change in beh

[Mesa-dev] [PATCH 0/3] anv: Add an vk_outarray_append() macro (v2)

. This patch series lives at: git://git.kiwitree.net/~chadv/mesa refs/tags/chadv/review/anv-outarray-v02 gitweb: http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=chadv/review/anv-outarray-v02 v2: - Rename anv_outarray -> vk_outarray and move it to util/vk_util.h. For Jason. Chad Vers

[Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

No intended change in behavior. Just a refactor. --- src/intel/vulkan/anv_device.c | 32 ++-- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index f04e11e..35c5a4645ff 100644 ---

[Mesa-dev] [PATCH 1/3] util/vulkan: Add vk_outarray

This is a wrapper for a Vulkan output array. A Vulkan output array is one that follows the convention of the parameters to vkGetPhysicalDeviceQueueFamilyProperties(). --- src/util/vk_util.h | 140 + 1 file changed, 140 insertions(+) diff --git

<    1   2   3   4   5   6   7   8   9   10   >