Re: [Mesa-dev] Static thread safety checking with clang

On Tue, Nov 10, 2020 at 8:00 PM Chia-I Wu wrote: > > On Tue, Nov 10, 2020 at 8:09 AM Kristian Høgsberg wrote: > > > > Hi, > > > > I wanted to call attention to > > > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7529 > > > >

[Mesa-dev] Static thread safety checking with clang

Hi, I wanted to call attention to https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7529 which shows how we can use a new clang __attribute__ to statically check locking invariants. It's probably not perfect, but more like static type checking - there will always be cases where you

Re: [Mesa-dev] Rename "master" branch to "main"?

On Mon, Aug 3, 2020 at 10:16 AM Eric Anholt wrote: > > On Mon, Aug 3, 2020 at 8:30 AM Jason Ekstrand wrote: > > > > All, > > > > I'm sure by now you've all seen the articles, LKML mails, and other > > chatter around inclusive language in software. While mesa doesn't > > provide a whole lot of

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

On Mon, Mar 30, 2020, 7:59 AM Adam Jackson wrote: > On Sun, 2020-03-29 at 09:45 -0700, Kristian Høgsberg wrote: > > > As for loading, doesn't glvnd solve that? > > It could. It does not. Right now there's not a (good) way for the DDX > driver to communicate a preferre

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

Ekstrand wrote: > > > > On Sun, Mar 29, 2020 at 11:45 AM Kristian Høgsberg < > hoegsb...@gmail.com> wrote: > > > > > > > > > > As for loading, doesn't glvnd solve that? > > > > > > > > Not really. There are still problems if

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

As for loading, doesn't glvnd solve that? On Sun, Mar 29, 2020, 1:19 AM Marek Olšák wrote: > If you want a complete fork or removal, that's fine with me. It's > technically more challenging for driver loaders and packaging though. > > Marek > > On Sun., Mar. 29, 2020, 02:51 Jason Ekstrand, >

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

On Thu, Feb 27, 2020 at 7:38 PM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: > > > > Hi all, > > > > You might have read the short take in the X.org board meeting minutes > > already, here's the long version. > > > > The good news: gitlab.fd.o has become very popular

Re: [Mesa-dev] Drop scons for 20.1?

ss more platforms, shader a compiler pass, reduce techincal debt etc. Kristian > > Jose > > > From: Kristian Høgsberg > Sent: Wednesday, February 26, 2020 18:37 > To: Jason Ekstrand > Cc: Rob Clark ; mesa-dev > ; Dylan Baker ; Jose > Fonseca ; Brian Paul

Re: [Mesa-dev] Drop scons for 20.1?

er it is worth keeping a dead build system > > after it is removed from CI is an issue that I'm ambivalent about. > > > > BR, > > -R > > > > On Tue, Feb 25, 2020 at 3:42 PM Kristian Høgsberg > > wrote: > >> > >> It's been a while since Dylan di

[Mesa-dev] Drop scons for 20.1?

It's been a while since Dylan did the work to make meson support Windows and there's been plenty of time to provide feedback or improve argue why we still need scons. I haven't seen any such discussion and I think we've waited long enough. Let's drop scons for the next release and move things

Re: [Mesa-dev] Remove classic drivers or fork src/mesa for gallium?

On Wed, Dec 4, 2019 at 10:31 AM Rob Clark wrote: > > On Wed, Dec 4, 2019 at 9:48 AM Eric Anholt wrote: > > > > On Tue, Dec 3, 2019 at 4:39 PM Marek Olšák wrote: > > > > > > Hi, > > > > > > Here are 2 proposals to simplify and better optimize the GL->Gallium > > > translation. > > > > > > 1)

Re: [Mesa-dev] [PATCH] Call shmget() with permission 0600 instead of 0777

Looks good, Reviewed-by: Kristian H. Kristensen On Tue, Nov 12, 2019 at 10:47 AM Brian Paul wrote: > > Ping again. > > > On 10/24/2019 03:25 PM, Brian Paul wrote: > > Ping. Anyone? > > > > -Brian > > > > On Tue, Oct 22, 2019 at 3:52 PM Brian Paul > > wrote: > > > >

Re: [Mesa-dev] [PATCH] s/APIENTRY/GLAPIENTRY/ in teximage.c

On Mon, Nov 11, 2019 at 3:45 PM Brian Paul wrote: > > The later is the right symbol for entrypoint functions. Reviewed-by: Kristian H. Kristensen > --- > src/mesa/main/texgetimage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/texgetimage.c

Re: [Mesa-dev] Switching to Gitlab Issues instead of Bugzilla?

On Wed, Sep 18, 2019 at 8:45 AM Adam Jackson wrote: > > On Thu, 2019-08-29 at 11:52 -0700, Kenneth Graunke wrote: > > > What do people think? If folks are in favor, Daniel can migrate > > everything for us, like he did with the other projects. If not, > > I'd like to hear what people's concerns

Re: [Mesa-dev] Switching to Gitlab Issues instead of Bugzilla?

On Thu, Aug 29, 2019 at 12:44 PM Chris Wilson wrote: > > Quoting Kenneth Graunke (2019-08-29 19:52:51) > > Some cons: > > > > - Moving bug reports between the kernel and Mesa would be harder. > > We would have to open a bug in the other system. (Then again, > > moving bugs between Mesa and X

Re: [Mesa-dev] Switching to Gitlab Issues instead of Bugzilla?

On Thu, Aug 29, 2019 at 12:02 PM Kenneth Graunke wrote: > > Hi all, > > As a lot of you have probably noticed, Bugzilla seems to be getting a > lot of spam these days - several of us have been disabling a bunch of > accounts per day, sweeping new reports under the rug, hiding comments, > etc.

Re: [Mesa-dev] [MR] Update README to recommend MRs instead of `git send-email`

On Tue, Jul 9, 2019 at 12:17 AM Daniel Stone wrote: > > Hi, > > On Sat, 6 Jul 2019 at 18:39, Ilia Mirkin wrote: > > I see this as driving away contributions, esp from new people. MR's > > are annoying to create, since they require dealing with the hosting > > provider, getting it to host clones,

Re: [Mesa-dev] [PATCH] nir: silence three compiler warnings seen with MinGW

Reviewed-by: Kristian H. Kristensen On Thu, May 23, 2019 at 9:52 AM Brian Paul wrote: > > Ping. > > -Brian > > On 05/20/2019 07:36 AM, Brian Paul wrote: > > Silence two unused var warnings. And init elem_size, elem_align to > > zero to silence "maybe uninitialized" warnings. > > --- > >

Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

On Mon, Apr 22, 2019 at 3:11 PM Matt Turner wrote: > > On Mon, Apr 22, 2019 at 1:09 PM Kristian Høgsberg wrote: > > > > On Mon, Apr 22, 2019 at 12:11 PM Jason Ekstrand > > wrote: > > > > > > All, > > > > > > I've seen discussions come

Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

On Mon, Apr 22, 2019 at 12:11 PM Jason Ekstrand wrote: > > All, > > I've seen discussions come up several times lately about whether you should > use MAYBE_UNUSED or UNUSED in what scenario and why do we have two of them > anyway. That got me thinking a bit. Maybe what we actually want

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

On Mon, Mar 4, 2019 at 6:29 PM Dave Airlie wrote: > > On Tue, 5 Mar 2019 at 12:20, Kristian Høgsberg wrote: > > > > On Mon, Mar 4, 2019 at 6:11 PM Alyssa Rosenzweig > > wrote: > > > > > > > Why aren't we using regular dma-buf fences here? Th

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

On Mon, Mar 4, 2019 at 6:11 PM Alyssa Rosenzweig wrote: > > > Why aren't we using regular dma-buf fences here? The submit ioctl > > should be able to take a number of in fences to wait on and return an > > out fence if requested. > > Ah-ha, that sounds like the "proper" approach for mainline.

Re: [Mesa-dev] [PATCH 8/8] panfrost: Add backend targeting the DRM driver

On Mon, Mar 4, 2019 at 4:43 PM Alyssa Rosenzweig wrote: > > Wooo!!! > > Seeing this patch in my inbox has been some of the best news all day! > > Without further ado, my (solicited?) comments: > > > +/* Copyright 2018, Linaro, Ltd., Rob Herring */ > > Please triple check upstream that this

Re: [Mesa-dev] [PATCH] intel: limit urb size for SKL/KBL/CFL GT1

What happened to this patch? We carry it downstream for the deqp fix. Can we get it into 19.0? Thanks, Kristian On Wed, Aug 29, 2018 at 5:39 PM Lionel Landwerlin wrote: > > The documentation puts the URB size for SKL GT1 as "128K - 192K". I > guess this means we can't tell which one it is, so

Re: [Mesa-dev] [PATCH] freedreno: Fix meson build.

On Thu, Feb 7, 2019 at 8:03 AM Daniel Stone wrote: > > On Thu, 7 Feb 2019 at 14:59, Eric Engestrom wrote: > > On Wednesday, 2019-02-06 18:36:09 +, Vinson Lee wrote: > > > ../src/gallium/drivers/freedreno/freedreno_resource.c: In function > > > ‘fd_resource_create_with_modifiers’: > > >

Re: [Mesa-dev] [PATCH] loader: fix the no-modifiers case

On Tue, Jan 22, 2019 at 11:45 AM Rob Clark wrote: > > Normally modifiers take precendence over use flags, as they are more > explicit. But if the driver supports modifiers, but the xserver does > not, then we should fallback to the old mechanism of allocating a buffer > using 'use' flags. > >

Re: [Mesa-dev] [PATCH] st/dri: fix dri2_format_table for argb1555 and rgb565

Reviewed-by: Kristian H. Kristensen On Fri, Jan 11, 2019 at 3:19 PM Marek Olšák wrote: > > From: Marek Olšák > > The bug caused that rgb565 framebuffers used argb1555. > > Fixes: 433ca3127a3b94bfe9a513e7c7ce594e09e1359f > --- > src/gallium/state_trackers/dri/dri2.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

On Fri, Jan 11, 2019 at 2:28 PM Ilia Mirkin wrote: > > On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > > > From: Gert Wollny > > > > Since Meson will eventually be the only build system deprecate autotools > > now. It can still be used by invoking configure with the flag > >

Re: [Mesa-dev] [PATCH] freedreno/drm: sync uapi again

without this for me. > > Cc: Rob Clark > Cc: Kristian Høgsberg > Signed-off-by: Chia-I Wu > --- > src/freedreno/drm/msm_drm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/freedreno/drm/msm_drm.h b/src/freedreno/drm/msm_drm.h > index 09f16fd7be..91a

Re: [Mesa-dev] [PATCH] intel/compiler: move nir_lower_bool_to_int32 before nir_lower_locals_to_regs

This regresses at least dEQP-GLES3.functional.shaders.functions.control_flow.return_in_loop_vertex on freedreno: Test case 'dEQP-GLES3.functional.shaders.functions.control_flow.return_in_loop_vertex'.. deqp-gles3: ../../../mesa/src/compiler/nir/nir_lower_bool_to_int32.c:49: lower_alu_instr:

Re: [Mesa-dev] [PATCH] genxml: Consistently use a numeric "MOCS" field

Reviewed-by: Kristian H. Kristensen On Tue, Dec 11, 2018 at 9:25 PM Jordan Justen wrote: > > Reviewed-by: Jordan Justen > > On 2018-12-11 20:23:06, Kenneth Graunke wrote: > > When we first started using genxml, we decided to represent MOCS as an > > actual structure, and pack values. However,

Re: [Mesa-dev] [PATCH] glapi: Fix DispatchSanity_test

On Tue, Dec 11, 2018 at 3:33 AM Emil Velikov wrote: > > On Mon, 10 Dec 2018 at 18:56, Kristian Høgsberg wrote: > > > > On Mon, Dec 10, 2018 at 7:38 AM Emil Velikov > > wrote: > > > > > > On Fri, 7 Dec 2018 at 23:48, Kristian H. Kristensen > >

Re: [Mesa-dev] [PATCH v2] glapi: fixup EXT_multisampled_render_to_texture dispatch

On Mon, Dec 10, 2018 at 2:12 PM Ian Romanick wrote: > > Reviewed-by: Ian Romanick Thanks Ian. I went ahead and pushed this to appease the CI bots. Kristian > On 12/10/18 10:14 AM, Emil Velikov wrote: > > From: "Kristian H. Kristensen" > > > > There's a few missing and convoluted bits: > > >

Re: [Mesa-dev] [PATCH v2] glapi: fixup EXT_multisampled_render_to_texture dispatch

On Mon, Dec 10, 2018 at 10:17 AM Emil Velikov wrote: > > From: "Kristian H. Kristensen" > > There's a few missing and convoluted bits: > > - FramebufferTexture2DMultisampleEXT > Missing sanity check, should be desktop="false" > > - RenderbufferStorageMultisampleEXT > Missing sanity check, is

Re: [Mesa-dev] [PATCH] glapi: Fix DispatchSanity_test

On Mon, Dec 10, 2018 at 7:38 AM Emil Velikov wrote: > > On Fri, 7 Dec 2018 at 23:48, Kristian H. Kristensen > wrote: > > > > --- > > src/mapi/glapi/gen/EXT_multisampled_render_to_texture.xml | 2 +- > > src/mapi/glapi/gen/es_EXT.xml | 2 ++ > >

Re: [Mesa-dev] Mesa (master): mesa: Add core support for EXT_multisampled_render_to_texture{, 2}

On Fri, Dec 7, 2018 at 1:49 AM Michel Dänzer wrote: > > On 2018-12-07 2:02 a.m., GitLab Mirror wrote: > > Module: Mesa > > Branch: master > > Commit: 1b331ae505e63033634d9f5267ca1949336f75d8 > > URL: > > http://cgit.freedesktop.org/mesa/mesa/commit/?id=1b331ae505e63033634d9f5267ca1949336f75d8

Re: [Mesa-dev] Lets talk about autotools

On Mon, Dec 3, 2018 at 10:28 AM Emil Velikov wrote: > > On Mon, 3 Dec 2018 at 17:49, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-03 07:54:38) > > > Hi all, > > > > > > On Thu, 29 Nov 2018 at 17:44, Emil Velikov > > > wrote: > > > > > > > > Hi all, > > > > > > > > I can see why

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

On Fri, Nov 30, 2018 at 10:17 AM Marek Olšák wrote: > > On Fri, Nov 30, 2018 at 1:13 PM Kristian Høgsberg wrote: >> >> On Fri, Nov 16, 2018 at 7:48 PM Marek Olšák wrote: >> > >> > I think the name PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE is slightly >&

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

On Fri, Nov 16, 2018 at 7:48 PM Marek Olšák wrote: > > I think the name PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE is slightly > misleading, because it doesn't imply anything about the OpenGL ES behavior, > which is that a texture is multisampled in the cache, but single-sampled in > memory. This

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

On Tue, Nov 6, 2018 at 6:26 PM Roland Scheidegger wrote: > > Am 07.11.18 um 00:03 schrieb Kristian Høgsberg: > > On Tue, Nov 6, 2018 at 2:44 PM Axel Davy wrote: > >> > >> Hi, > >> > >> Is there anything to be done in the nine state trackers (or

Re: [Mesa-dev] [PATCH v2 1/5] mesa: Add core support for EXT_multisampled_render_to_texture2

On Tue, Nov 6, 2018 at 3:03 PM Ilia Mirkin wrote: > > On Tue, Nov 6, 2018 at 5:18 PM Kristian H. Kristensen > wrote: > > > > This also turns on EXT_multisampled_render_to_texture which is a > > subset of EXT_multisampled_render_to_texture2, allowing only > > COLOR_ATTACHMENT0. > > You also

Re: [Mesa-dev] [PATCH mesa 1/2] egl: add missing includes

On Fri, Nov 16, 2018 at 9:34 AM Emil Velikov wrote: > > On Fri, 16 Nov 2018 at 10:07, Eric Engestrom wrote: I find that I also need diff --git a/src/egl/main/egldevice.h b/src/egl/main/egldevice.h index ddcdcd17f5a..03988913ecd 100644 --- a/src/egl/main/egldevice.h +++

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

On Tue, Nov 6, 2018 at 2:44 PM Axel Davy wrote: > > Hi, > > Is there anything to be done in the nine state trackers (or other state > trackers). > > Nine uses create_surface. Should it expect the field to be filled > properly by the driver ? Nothing is required from any state tracker, but if

Re: [Mesa-dev] [PATCH 2/4] st/mesa: Add support for EXT_multisampled_render_to_texture

On Tue, Nov 6, 2018 at 12:09 PM Ilia Mirkin wrote: > > On Tue, Nov 6, 2018 at 2:31 PM Kristian H. Kristensen > wrote: > > > > In gallium, we model the attachment sample count as a new nr_samples > > field in pipe_surface. A driver can indicate support for the extension > > using the new pipe

Re: [Mesa-dev] [PATCH] egl/android: Declare droid_load_driver() static

Thanks Tapani! On Wed, Sep 12, 2018 at 9:47 PM Tapani Pälli wrote: > > Reviewed-by: Tapani Pälli > > On 09/13/2018 02:14 AM, Kristian H. Kristensen wrote: > > Signed-off-by: Kristian H. Kristensen > > --- > > src/egl/drivers/dri2/platform_android.c | 2 +- > > 1 file changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH] i965: Workaround the gen9 hw astc5x5 sampler bug

On Thu, Sep 6, 2018 at 11:40 AM Jason Ekstrand wrote: > > On Thu, Sep 6, 2018 at 1:36 PM Kristian Høgsberg wrote: >> >> On Thu, Sep 6, 2018 at 9:35 AM Jason Ekstrand wrote: >> > >> > From: Topi Pohjolainen >> > >> > gen9 hardware h

Re: [Mesa-dev] [PATCH] i965: Workaround the gen9 hw astc5x5 sampler bug

On Thu, Sep 6, 2018 at 9:35 AM Jason Ekstrand wrote: > > From: Topi Pohjolainen > > gen9 hardware has a bug in the sampler cache that can cause GPU hangs > whenever an texture with aux compression enabled is in the sampler cache > together with an ASTC5x5 texture. Because we can't control what

Re: [Mesa-dev] [PATCH 1/3] freedreno: Fix warnings

The remaining two patches are stuck in moderation for being too big. They update the generated headers and adds the a6xx backend. They're in this branch: https://gitlab.freedesktop.org/krh/mesa/commits/wip/a6xx-rebase-3 for reference. Kristian On Wed, Aug 15, 2018 at 9:18 AM Kristian H.

Re: [Mesa-dev] Why are pbuffers backed by a pixmaps (Was Re: [PATCH] egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.)

On Mon, Aug 13, 2018 at 3:53 AM Emil Velikov wrote: > > Hi Adam, > > Thanks for the extensive write-up. > > On 9 August 2018 at 20:30, Adam Jackson wrote: > > On Thu, 2018-08-09 at 18:22 +0100, Emil Velikov wrote: > > > >> In the GLX case, it's required due to server-side rendering. One needs >

Re: [Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

On Thu, Jun 7, 2018 at 6:02 PM Jason Ekstrand wrote: > > On June 7, 2018 16:47:17 Ilia Mirkin wrote: > > > On Thu, Jun 7, 2018 at 7:31 PM, Fritz Koenig wrote: > >> On Thu, Jun 7, 2018 at 4:10 PM Ilia Mirkin wrote: > >>> > >>> It's slightly different than what you've specified, but can't you >

Re: [Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

On Thu, Jun 7, 2018 at 4:02 PM Fritz Koenig wrote: > > Adds an extension to glFramebufferParameteri > that will specify if the framebuffer is vertically > flipped. Historically system framebuffers are > vertically flipped and user framebuffers are not. > Checking to see the state was done by

Re: [Mesa-dev] [PATCH] st/va: Support YUV formats in vaCreateSurfaces

Looks good - I was going to say the C++ comment should be /* */ but I see there's already a // in the file so... ¯\_(ツ)_/¯ Reviewed-by: Kristian H. Kristensen On Fri, Apr 27, 2018 at 8:35 AM Drew Davenport wrote: > diff --git

Re: [Mesa-dev] [PATCH] st/va: Fix potential buffer overread

On Tue, Apr 24, 2018 at 4:02 PM Drew Davenport wrote: > VASurfaceAttribExternalBuffers.pitches is indexed by > plane. Current implementation only supports single plane layout. Reviewed-by: Kristian H. Kristensen > --- >

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

< hoegsb...@google.com> wrote: > >>> On Wed, Dec 20, 2017 at 12:41 PM, Miguel Angel Vico < mvicom...@nvidia.com> wrote: > >>>> On Wed, 20 Dec 2017 11:54:10 -0800 Kristian Høgsberg < hoegsb...@gmail.com> wrote: > >>>>> I'd like to see concret

Re: [Mesa-dev] [PATCH 1/2] i965/bufmgr: Add a create_from_prime_tiled function

On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote: > This new function is an import and a set tiling in one go. > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 41 > ++ > src/mesa/drivers/dri/i965/brw_bufmgr.h | 4 > 2 files

Re: [Mesa-dev] [PATCH 2/2] i965: Set tiling on BOs imported with modifiers

On Mon, Jan 22, 2018 at 10:03 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On January 22, 2018 09:10:52 Kristian Høgsberg <hoegsb...@gmail.com> wrote: > >> On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand <ja...@jlekstrand.net> >> wrote: >>>

Re: [Mesa-dev] [PATCH 2/2] i965: Set tiling on BOs imported with modifiers

On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote: > We need this to ensure that GTT maps work on buffers we get from Vulkan > on the off chance that someone does a readpixels or something. Soon, we > will be removing GTT maps from i965 entirely and this can be

Re: [Mesa-dev] [ANNOUNCE] Wayland/Weston/Mesa HDR support (proof of concept)

On Thu, Dec 21, 2017 at 6:21 AM, Ville Syrjälä wrote: > Here's a quick proof of concept implementation of HDR support > for Wayland/Weston/Mesa. > > I'm not posting this as patches right now because I'm not sure > that would do much good given how rough this is. But

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

On Wed, Dec 20, 2017 at 11:51 AM, Daniel Vetter wrote: > Since this also involves the kernel let's add dri-devel ... > > On Wed, Dec 20, 2017 at 5:51 PM, Miguel Angel Vico > wrote: >> Hi all, >> >> As many of you already know, I've been working with James

Re: [Mesa-dev] [PATCH 3/3] spirv: Allow OpPtrAccessChain for block indices

On Thu, Nov 30, 2017 at 9:15 PM, Jason Ekstrand wrote: > After talking with Kristian a bit on IRC, I think there is a bit more > explanation needed. I would be happy to add something like this to the > commit message or as a comment upon request. > > There is an interesting

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 9:43 AM, Kristian Høgsberg <hoegsb...@gmail.com> wrote: > On Tue, Dec 5, 2017 at 8:49 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> On Tue, Dec 5, 2017 at 8:23 AM, Kristian Høgsberg <hoegsb...@gmail.com> >> wrote: >>> >>

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 8:49 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Tue, Dec 5, 2017 at 8:23 AM, Kristian Høgsberg <hoegsb...@gmail.com> > wrote: >> >> On Tue, Dec 5, 2017 at 7:57 AM, Jason Ekstrand <ja...@jlekstrand.net> >> wrote: >>

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use the tiling from the modifier instead of the BO

On Tue, Dec 5, 2017 at 7:57 AM, Jason Ekstrand wrote: > On Tue, Dec 5, 2017 at 1:22 AM, Daniel Stone wrote: >> >> Hi, >> >> On 18 November 2017 at 00:10, Jason Ekstrand wrote: >> > This fixes a bug where we were taking the tiling

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

On Thu, Oct 19, 2017 at 11:04 AM, Jason Ekstrand wrote: > Not to be confused with variablePointersStorageBuffer which is the > subset of VK_KHR_variable_pointers required to enable the extension. > This gives us "full" support for variable pointers. > > The approach chosen

Re: [Mesa-dev] [PATCH 2/2] anv: flag batch & instruction BOs for capture

On Fri, Nov 17, 2017 at 9:48 AM, Lionel Landwerlin wrote: > When the kernel support flagging our BO, let's mark batch & > instruction BOs for capture so then can be included in the error > state. > > Signed-off-by: Lionel Landwerlin >

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

On Wed, Nov 1, 2017 at 2:25 PM, Lionel Landwerlin wrote: > On 01/11/17 20:30, Dylan Baker wrote: >> >> Quoting Scott D Phillips (2017-11-01 10:30:09) >>> >>> Lionel Landwerlin writes: >>> On 31/10/17 21:11, Scott D Phillips

Re: [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke wrote: > The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2 > registers at context initialization time. Instead, they're inherited > from whatever happened to be running on the GPU prior to first run of

Re: [Mesa-dev] [PATCH 09/10] anv: Implement VK_ANDROID_native_buffer (v9)

On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace wrote: > This implementation is correct (afaict), but takes two shortcuts > regarding the import/export of Android sync fds. > > Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync > fd into a

Re: [Mesa-dev] Testing out Kristian's fast mtx patch

On Mon, Oct 9, 2017 at 7:45 PM, Timothy Arceri wrote: > After a recent discussion about this code from 2015 I was curious > to give it a try. The outstanding review item was that we shouldn't > be replacing the C11 mtx type/functions with our own, so I've renamed > the fast

Re: [Mesa-dev] Why are we using server-side GLX fbconfigs?

On Fri, Jun 30, 2017 at 2:49 AM, Thomas Hellstrom <thellst...@vmware.com> wrote: > On 06/29/2017 07:30 PM, Kristian Høgsberg wrote: >> >> On Thu, Jun 29, 2017 at 7:36 AM, Thomas Hellstrom <thellst...@vmware.com> >> wrote: >>> >>> Hi! >>

Re: [Mesa-dev] [PATCH] intel: genxml: make a couple of enums show up in aubinator

On Fri, Jun 30, 2017 at 9:25 AM, Lionel Landwerlin wrote: > In particular Shader Channel Select & Texture Address Control Mode. > > Signed-off-by: Lionel Landwerlin Nice, Reviewed-by: Kristian H. Kristensen >

Re: [Mesa-dev] Why are we using server-side GLX fbconfigs?

On Thu, Jun 29, 2017 at 7:36 AM, Thomas Hellstrom wrote: > Hi! > > I was spending some time going through the GLX code to try to fix up the > GLX_OML_swap_method extension implementation. > > I then stumbled across the fact that when we, for direct rendering > connections,

Re: [Mesa-dev] [PATCH] i965: Remove spurious mutex frobbing around call to intel_miptree_blit

d now with the new blorp. If I remember correctly, I had to drop the lock there since intel_miptree_blit() could hit the XY blit path that requires a fast clear resolve. The fast resolve being meta, would then try to lock the texture again. Kristian > Signed-off-by: Ian Romanick <ian.d.roma

Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

On Mon, Jun 19, 2017 at 7:07 PM, Lin, Johnson wrote: > Kristian, > > Thanks for the review comments. By my tests, UYVY buffer can be sampled and > rendered correctly. So there is no swap of U/V channel here. Just saying "the test pass, all is fine" isn't good enough. See

Re: [Mesa-dev] [PATCH 18/18] i965: Convert WM_STATE to genxml on gen4-5.

On Mon, Jun 19, 2017 at 11:17 AM, Rafael Antognolli <rafael.antogno...@intel.com> wrote: > On Mon, Jun 19, 2017 at 09:46:30AM -0700, Kristian Høgsberg wrote: >> On Fri, Jun 16, 2017 at 4:31 PM, Rafael Antognolli >> <rafael.antogno...@intel.com> wrote: >> >

Re: [Mesa-dev] [PATCH 18/18] i965: Convert WM_STATE to genxml on gen4-5.

On Fri, Jun 16, 2017 at 4:31 PM, Rafael Antognolli wrote: > The code doesn't get exactly a lot simpler but at least it is in a single > place, and we delete more than we add. Another good point is that you get rid of struct brw_wm_unit_state which was a third

Re: [Mesa-dev] [PATCH 11/11] intel/aubinator_error_decode: Disassemble shader programs

On Mon, May 1, 2017 at 1:54 PM, Matt Turner wrote: > --- > src/intel/Makefile.tools.am | 6 +- > src/intel/tools/aubinator_error_decode.c | 178 > ++- > 2 files changed, 180 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] i965: Drop brw_context::viewport_transform_enable.

Reviewed-by: Kristian H. Kristensen On Wed, May 10, 2017 at 12:01 PM, Kenneth Graunke wrote: > This was used by the meta fast clear code. Now that we've switched > back to BLORP, it's always true. > > We might want it back when we add a RECTLIST

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On Thu, May 4, 2017 at 11:43 AM, Lionel Landwerlin wrote: > On 04/05/17 07:52, Emil Velikov wrote: >> >> On 4 May 2017 at 14:46, Daniel Vetter wrote: >>> >>> On Thu, Apr 27, 2017 at 10:58:42AM -0700, Lionel Landwerlin wrote: On 27/04/17

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On Thu, May 4, 2017 at 7:26 AM, Emil Velikov wrote: > On 27 April 2017 at 16:20, Eric Anholt wrote: >> Emil Velikov writes: >> >>> On 25 April 2017 at 23:56, Lionel Landwerlin >>> wrote:

Re: [Mesa-dev] [PATCH 00/53] i965: Eat libdrm_intel for breakfast

On Wed, Apr 5, 2017 at 11:11 AM, Jason Ekstrand wrote: > On Wed, Apr 5, 2017 at 11:03 AM, Emil Velikov > wrote: >> >> On 5 April 2017 at 18:55, Daniel Vetter wrote: >> > On Wed, Apr 05, 2017 at 04:38:25PM +0100, Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

On Mon, Apr 3, 2017 at 10:13 AM, Rob Clark wrote: > On Mon, Apr 3, 2017 at 12:56 PM, Thomas Hellstrom > wrote: >> Hi, Rob, >> >> On 03/24/2017 10:21 PM, Rob Clark wrote: >>> It's kinda sad that (a) we don't have debug_backtrace support on !X86 >>> and

Re: [Mesa-dev] [PATCH v2] anv: add support for allocating more than 1 block of memory

On Wed, Mar 29, 2017 at 12:06 PM, Jason Ekstrand wrote: > Looking over the patch, I think I've convinced myself that it's correct. (I > honestly wasn't expecting to come to that conclusion without more > iteration.) That said, this raises some interesting questions. I

Re: [Mesa-dev] [PATCH 7/7] intel: tools: add aubinator_error_decode tool

On Thu, Mar 30, 2017 at 1:38 PM, Lionel Landwerlin wrote: > On 30/03/17 20:09, Chris Wilson wrote: >> >> On Thu, Mar 30, 2017 at 11:27:26AM -0700, Matt Turner wrote: >>> >>> I think we should figure out how to make this not just a fork of >>> intel_error_decode.

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca <jfons...@vmware.com> wrote: > On 24/03/17 19:10, Kristian Høgsberg wrote: >> >> On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca <jfons...@vmware.com> wrote: >>> >>> On 23/03/17 01:38, Rob Clark wrote: &

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: > On 23/03/17 01:38, Rob Clark wrote: >> >> On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: >>> >>> On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: On Wed, Mar 22, 2017 at 12:40

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

On Wed, Feb 1, 2017 at 5:44 PM Jason Ekstrand wrote: > In order to get good performance numbers for this, I had to hack up the > driver to whack wm_prog_data::uses_kill to true to emulate a discard and > used the Sascha "shadowmapping" demo. Setting uses_kill to true

Re: [Mesa-dev] [PATCH 0/18] Misc genxml patches

tile mode deserves to > remain inline. I don't care about 17. I didn't really review it for not > breaking things though. The rest are > > Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > > Don't push until you get Jenkins' ok though! > > --Jason > > On Tue, Nov 29

Re: [Mesa-dev] [PATCH 15/18] intel/genxml: Add and use enum for tile mode

On Tue, Nov 29, 2016 at 4:03 PM Jason Ekstrand wrote: > On Tue, Nov 29, 2016 at 12:48 PM, Kristian H. Kristensen < > hoegsb...@gmail.com> wrote: > > Signed-off-by: Kristian H. Kristensen > --- > src/intel/genxml/gen8.xml | 9 - >

Re: [Mesa-dev] [PATCH 11/18] intel/genxml: Use enum 3D_Stencil_Operation where applicable

On Tue, Nov 29, 2016 at 3:37 PM Jason Ekstrand wrote: > On Tue, Nov 29, 2016 at 12:48 PM, Kristian H. Kristensen < > hoegsb...@gmail.com> wrote: > > Signed-off-by: Kristian H. Kristensen > --- > src/intel/genxml/gen6.xml | 39

Re: [Mesa-dev] [PATCH 0/18] Misc genxml patches

On Tue, Nov 29, 2016 at 12:48 PM Kristian H. Kristensen wrote: > Hi, > > Here's a few patches to the genxml files that I've been sitting on. The > main part of the series is about emitting C enums for genxml enums, so > it looks nice and pretty in gdb. It also adds support

Re: [Mesa-dev] [PATCH 1/4] intel/aubinator: Properly handle batch buffer chaining

On Fri, Nov 18, 2016 at 11:54 AM Jason Ekstrand wrote: > From: Jason Ekstrand > > The original aubinator that Kristian wrote had a bug in the handling of > MI_BATCH_BUFFER_START that propagated into the version in upstream mesa. > In particular, it

Re: [Mesa-dev] [PATCH 00/20] anv: Unify pipeline setup across gens

On Sat, Nov 12, 2016 at 1:35 PM Jason Ekstrand wrote: > This series started off as me thinking that we should set the correct > sampler and binding table entry counts because maybe caching those things > would improve performance. Then it turned into spring cleaning. The

Re: [Mesa-dev] [PATCH v4 00/10] anv: Rework relocation handling

e able to get this idea working. I would keep the execbuf bo list around in the VkCmdBuffer structure instead of allocating and freeing the exact same amount on each execbuf, but I know you like to malloc. For the series: Reviewed-by: Kristian H. Kristensen <hoegsb...@google.com> >

Re: [Mesa-dev] [PATCH 1/2] intel: aubinator: generate a standalone binary

On Tue, Oct 4, 2016 at 9:26 AM Ben Widawsky wrote: > On 16-10-04 15:38:52, Lionel Landwerlin wrote: > >Embed the xml files into the binary, so aubinator can be used from any > >location. > > > >Signed-off-by: Lionel Landwerlin > >Cc: Sirisha

Re: [Mesa-dev] [Request for Testing] i965: import prime buffers in the current context, not screen

On Thu, Sep 29, 2016 at 7:33 AM Martin Peres <martin.pe...@linux.intel.com> wrote: > On 02/09/16 10:08, Martin Peres wrote: > > > > > > On 25/08/16 21:49, Kristian Høgsberg wrote: > >> On Thu, Aug 25, 2016 at 11:38 AM, Chad Versace > >> <chadvers.

Re: [Mesa-dev] [PATCH 2/2] aubinator: print_help swap "FILE *file" with "bool critical"

On Mon, Sep 12, 2016 at 4:59 AM, Emil Velikov wrote: > From: Emil Velikov > > Derive file locally and exit() accordingly based on the bool. > Allows us to save a couple lines of code. > If we're nit-picking, I'd rather just pass the exit

Re: [Mesa-dev] [PATCH 0/3] Implement EGL_KHR_no_config_context

ix up the > one corner case, and mark the Mesa extension as superseded. Looks good to me: Reviewed-by: Kristian Høgsberg <k...@bitplanet.net> > - ajax > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://l

Re: [Mesa-dev] [PATCH 07/12] i965/blorp: Instruct vertex fetcher to provide prim instance id

On Thu, Sep 1, 2016 at 8:43 AM, Jason Ekstrand wrote: > On Aug 31, 2016 9:06 AM, "Topi Pohjolainen" > wrote: >> >> This will indicate target layer (Render Target Array Index) needed >> for layered clears. >> >> v2: Use 3DSTATE_VF_SGVS for gen8+

Re: [Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

g.id.au> For the series, Reviewed-by: Kristian Høgsberg <k...@bitplanet.net> > --- > src/intel/tools/aubinator.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c > index df84469.

  1   2   3   4   5   6   7   8   9   10   >