From: Nicolai Hähnle
---
src/amd/common/ac_rtld.c| 9 +
src/amd/common/ac_rtld.h| 9 +
src/gallium/drivers/radeonsi/si_debug_options.h | 1 +
src/gallium/drivers/radeonsi/si_shader.c| 3 +++
4 files changed, 22
On Wed, May 8, 2019 at 1:52 AM Marek Olšák wrote:
> On Fri, May 3, 2019 at 7:19 AM Nicolai Hähnle wrote:
>
>> From: Nicolai Hähnle
>>
>> ---
>> src/amd/common/ac_binary.c| 2 +
>> src/gallium/drivers/radeonsi/si_compute.c | 14
From: Marek Olšák
and clean up
---
src/amd/common/ac_gpu_info.c | 13 --
src/amd/common/ac_gpu_info.h | 1 +
src/amd/vulkan/radv_debug.c | 5 +-
src/gallium/drivers/r600/r600_buffer_common.c | 6 +--
src/gallium/drivers/r600/r600_pipe.c
Pushed, thanks!
Marek
On Fri, Jun 7, 2019 at 7:19 AM wrote:
> From: Rui Salvaterra
>
> This implements GLSL disk shader caching for the R300-R500 series of AMD
> GPUs.
>
> Signed-off-by: Rui Salvaterra
> ---
> src/gallium/drivers/r300/r300_screen.c | 38 +-
>
From: Marek Olšák
---
include/GL/glcorearb.h | 261 +++
include/GL/glext.h | 269 +
include/GLES/gl.h | 21 +---
include/GLES/glext.h | 35 +-
include/GLES2/gl2.h| 6 +-
include/GLES2/gl2ext.h
Reviewed-by: Marek Olšák
Marek
On Wed, Jun 5, 2019 at 6:49 AM Connor Abbott wrote:
> When e9d935ed0e2 added force_dcc_off(), we forced it off for any
> preloaded image descriptor which had stores associated with them, since
> the same preloaded descriptors were used for loads a
From: Marek Olšák
It skipped slab allocators and the buffer cache.
v2: use only 1 domain for texture allocation
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110781
Cc: 19.1
---
src/gallium/drivers/r300/r300_query.c | 3 ++-
src/gallium/drivers/r300/r300_render.c
On Tue, Jun 4, 2019, 1:29 AM Jan Vesely wrote:
> On Tue, 2019-06-04 at 00:20 -0400, Marek Olšák wrote:
> > This series will probably conflict with the new linker, which will
> > also
> > handle relocations and more:
> >
> https://nam02.safelinks.protectio
This series will probably conflict with the new linker, which will also
handle relocations and more:
https://patchwork.freedesktop.org/series/60255/
Marek
On Mon, Jun 3, 2019 at 10:39 PM Jan Vesely wrote:
> Cc: mesa-sta...@lists.freedesktop.org
> Signed-off-by: Jan Vesely
> ---
>
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c
b/src/gallium/drivers/radeonsi/si_state_shaders.c
index c26acbbc927..c4517fcf538 100644
--- a/src/gallium
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 147 +++
1 file changed, 67 insertions(+), 80 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index 3610ec90a89..8c4f4e75653 100644
--- a/src
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c| 5 +++--
src/amd/common/ac_llvm_build.h| 1 +
src/amd/common/ac_nir_to_llvm.c | 2 +-
.../radeonsi/si_compute_prim_discard.c| 21 ---
.../drivers/radeonsi
From: Marek Olšák
---
.../drivers/radeonsi/si_shader_tgsi_mem.c | 38 ---
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
index c5704bc0eae..63184a4f396
From: Marek Olšák
---
.../drivers/radeonsi/si_shader_tgsi_mem.c | 35 ---
1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c
index 63184a4f396..cc634f495ef
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_test_dma_perf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_test_dma_perf.c
b/src/gallium/drivers/radeonsi/si_test_dma_perf.c
index 263187d683f..0b5a4a38ab7 100644
--- a/src/gallium/drivers
From: Marek Olšák
---
src/amd/common/ac_llvm_build.c | 74 +-
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 79058f53b4e..2a1a133c392 100644
--- a/src/amd/common
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.c
index e044e180778..3610ec90a89 100644
--- a/src/gallium/drivers
From: Marek Olšák
Cc: 19.1
---
src/amd/common/ac_llvm_build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index d0e11141b81..79058f53b4e 100644
--- a/src/amd/common/ac_llvm_build.c
+++ b/src/amd/common
wrong driver and crash out.
> >
> > v2: fixup quirky GBM (Mathias)
> >
> > Cc: mesa-sta...@lists.freedesktop.org
> > Cc: Mathias Fröhlich
> > Reviewed-by: Mathias Fröhlich (v1)
> > Reviewed-by: Marek Olšák (v1)
> > Signed-off-by: Emil Velikov
> > ---
&
tbuffer loads and stores should set use_format=true, and the *_xyz variants
are supported. Other than that:
Reviewed-by: Marek Olšák
Marek
On Mon, Jun 3, 2019 at 3:52 PM Samuel Pitoiset
wrote:
> It's unsupported, only load/store format with vec3 are supported.
>
> v2: - allow to
From: Marek Olšák
It skipped slab allocators and the buffer cache.
Cc: 19.1
---
src/gallium/drivers/r300/r300_query.c | 3 ++-
src/gallium/drivers/r300/r300_render.c| 3 ++-
src/gallium/drivers/r300/r300_screen_buffer.c | 6 --
src/gallium/drivers/r300/r300_texture.c
SI doesn't support buffer_load_dwordx3 and buffer_store_dwordx3, but it
supports buffer_load_format_xyz and buffer_store_format_xyz.
Marek
On Mon, Jun 3, 2019 at 9:09 AM Samuel Pitoiset
wrote:
> I thought LLVM was able to handle that itself but actually it
> does not. That means we shouldn't
Reviewed-by: Marek Olšák
Marek
On Fri, May 31, 2019 at 8:55 AM Connor Abbott wrote:
> Bindless handles in GL are 64-bit. This fixes an assert failure in LLVM.
> ---
>
> With this patch, we now have Piglit parity in debug mode.
>
> src/gallium/drivers/radeonsi/si_shader_n
clover is not supported by AMD officially, because AMD has its own OpenCL
driver called ROCm.
Marek
On Sat, Jun 1, 2019, 10:56 PM Jan Vesely wrote:
> Hi,
>
> On Sat, 2019-06-01 at 18:21 -0400, James Harvey wrote:
> > On Sat, Jun 1, 2019 at 6:19 PM James Harvey
> wrote:
> > > On Tue, Feb 19,
From: Marek Olšák
---
src/amd/common/ac_llvm_util.c| 10 ++
src/amd/common/ac_llvm_util.h| 1 +
src/amd/vulkan/radv_nir_to_llvm.c| 7 ++-
src/gallium/drivers/radeonsi/si_shader.c | 7 ++-
4 files changed, 15 insertions(+), 10 deletions(-)
diff
y 2019 at 18:38, Marek Olšák wrote:
> >
> > The first and last hunks look like they shouldn't be there. Other than
> that:
> >
> > Reviewed-by: Marek Olšák
> >
> > Marek
> >
> > On Fri, May 31, 2019 at 11:53 AM Rhys Perry
> wrote:
> >&g
The first and last hunks look like they shouldn't be there. Other than that:
Reviewed-by: Marek Olšák
Marek
On Fri, May 31, 2019 at 11:53 AM Rhys Perry
wrote:
> Otherwise LLVM can sink them and their texture coordinate calculations
> into divergent branches.
>
> v2: simplify th
On Thu, May 30, 2019, 7:08 PM Bas Nieuwenhuizen
wrote:
>
>
> On Fri, May 31, 2019, 12:49 AM Marek Olšák wrote:
>
>>
>>
>> On Thu, May 30, 2019, 6:44 PM Bas Nieuwenhuizen
>> wrote:
>>
>>>
>>>
>>> On Thu, May 30, 2019, 11:45 PM
On Thu, May 30, 2019, 6:44 PM Bas Nieuwenhuizen
wrote:
>
>
> On Thu, May 30, 2019, 11:45 PM Marek Olšák wrote:
>
>>
>>
>> On Thu, May 30, 2019, 3:54 PM Rhys Perry
>> wrote:
>>
>>> Otherwise LLVM can sink them and their texture coordinate c
Hi Emil,
What are your plans for pushing this?
Thanks,
Marek
On Thu, May 16, 2019, 3:23 PM Marek Olšák wrote:
> Acked-by: Marek Olšák
>
> Marek
>
> On Thu, May 16, 2019 at 1:03 PM Emil Velikov
> wrote:
>
>> This new 'platform' is added by default with no guar
On Thu, May 30, 2019, 3:54 PM Rhys Perry wrote:
> Otherwise LLVM can sink them and their texture coordinate calculations
> into divergent branches.
>
> v2: simplify the conditions on which the intrinsic is marked as convergent
>
> Cc:
> Signed-off-by: Rhys Perry
> Reviewed-By: Bas
It doesn't matter if the opcode supplies a lod. The only thing that matters
is if the opcode computes derivatives. It seems that the only opcodes
computing derivatives are tex, tex_bias, and query_lod. This only applies
to fragment shaders. Other stages never compute derivatives. There is an NV
On Mon, May 20, 2019 at 1:04 PM Jan Vesely wrote:
> On Mon, May 13, 2019 at 6:40 PM Marek Olšák wrote:
> >
> > From: Marek Olšák
> >
> > ---
> > src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
> > src/gallium/drivers/radeonsi/si_query.c | 7 ---
&
From: Marek Olšák
Bugzilla: https://bugzilla.freedesktop.org/show_bug.cgi?id=109754
Cc: 19.0 19.1
---
src/gallium/auxiliary/util/u_blitter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_blitter.c
b/src/gallium/auxiliary/util/u_blitter.c
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_fence.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_fence.c
b/src/gallium/drivers/radeonsi/si_fence.c
index 1d67fd87b90..6d914a1b184 100644
--- a/src/gallium/drivers/radeonsi
Ping
On Fri, May 10, 2019 at 1:21 AM Marek Olšák wrote:
> From: Marek Olšák
>
> debugoptimized builds don't define NDEBUG, but they also don't define
> DEBUG. We want to enable cheap debug code for these builds.
> I only chose those occurences that I care about.
> ---
>
Reviewed-by: Marek Olšák
Marek
On Mon, May 27, 2019 at 6:07 AM Timothy Arceri
wrote:
> This reverts commit 55376cb31e2f495a4d872b4ffce2135c3365b873.
>
> It's been over a year and both QT 5.9.5 and 5.11.0 contained a fix for the
> original issue. It seems i965 only ever applied thi
Reviewed-by: Marek Olšák
Marek
On Sun, May 26, 2019 at 9:57 PM Timothy Arceri
wrote:
> Cc: "19.0" "19.1"
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110711
> ---
> src/util/00-mesa-defaults.conf | 3 +++
> 1 file changed, 3 insertions(+
Reviewed-by: Marek Olšák
M.
On Mon, May 27, 2019, 4:17 AM wrote:
> From: Mathias Fröhlich
>
> Hi Emil,
>
> thanks for that hint to look at _mesa_get_incomplete_framebuffer.
> That one seems definitely more appropriate!
>
> Though, I miss a bit the idea how I can
Yes, this looks like a typo.
Reviewed-by: Marek Olšák
Marek
On Wed, May 22, 2019 at 5:10 PM Dave Airlie wrote:
> ping? nha? mareko maybe?
>
> Dave.
>
> On Fri, 17 May 2019 at 12:02, Dave Airlie wrote:
> >
> > mesa-19.1.0-rc2/src/amd/common/ac_llvm_bui
The depth decompress pass needs to know the sample locations.
If shader loads read from compressed depth, the texture hardware will
always use the standard locations for decompression.
Marek
On Tue, May 21, 2019 at 8:17 PM Bas Nieuwenhuizen
wrote:
> So this does not seem to use the sample
Reviewed-by: Marek Olšák
Marek
On Fri, May 17, 2019 at 11:22 AM Connor Abbott wrote:
> At least on vim, indenting doesn't work without this. Copied from
> src/amd/vulkan.
> ---
> src/gallium/drivers/radeonsi/.editorconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> dif
with the fix.
> >
> > Thanks.
> >
> > J.A.
> >
> > > [1] https://bugzilla.freedesktop.org/show_bug.cgi?id=110701
> > >
> > > On Fr, 2019-05-10 at 01:19 -0400, Marek Olšák wrote:
> > > > From: Marek Olšák
> > > &
From: Marek Olšák
Don't update non-buffer images.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110701
Fixes: 78e35df52aa2f7d770f929a0866a0faa89c261a9 "radeonsi: update buffer
descriptors in all contexts after buffer invalidation"
Cc: 19.1
---
src/gallium/driver
ot also part of some OpenGL or
> OpenGL ES version. I think if reviewers had been paying attention to
> features.txt, none of these would have landed in the first place.
> Looking at the logs, it seems that many of these changes were either
> unreviewed or were revie
Thanks. It looks good.
Marek
On Fri, May 17, 2019 at 3:56 AM Juan A. Suarez Romero
wrote:
> On Fri, 2019-05-10 at 01:19 -0400, Marek Olšák wrote:
> > From: Marek Olšák
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108824
> >
> > Cc: 19.1
>
From: Marek Olšák
- unify the code
- choose radeon or amdgpu based on the DRM version, not based on which one
succeeds first
---
.../auxiliary/target-helpers/drm_helper.h | 13 ++---
src/gallium/drivers/radeonsi/si_pipe.c| 27 +--
src/gallium/drivers/radeonsi
There is a fix for queries on the mailing list somewhere.
Marek
Marek
On Thu, May 16, 2019, 7:08 PM Jan Vesely wrote:
> On Tue, 2019-02-12 at 13:12 -0500, Marek Olšák wrote:
> > From: Marek Olšák
> >
> > initialize all non-compute context functions to NUL
Acked-by: Marek Olšák
Marek
On Thu, May 16, 2019 at 1:03 PM Emil Velikov
wrote:
> This new 'platform' is added by default with no guards.
>
> It is effectively a copy of the surfaceless one, with updated function
> names and brand new probe function.
>
> Due to the reuse,
Reviewed-by: Marek Olšák
Marek
On Thu, May 16, 2019 at 1:03 PM Emil Velikov
wrote:
> From: Emil Velikov
>
> By default, the user is likely to pick the first device so it should
> not be the least performant (aka software) one.
>
> v2: Drop odd comment (Marek)
>
> S
Reviewed-by: Marek Olšák
Marek
On Thu, May 16, 2019 at 1:03 PM Emil Velikov
wrote:
> From: Emil Velikov
>
> Wrap the loader->createNewDrawable() dance into a helper and use it
> throughout the codebase.
>
> This addresses a cases like surfaceless (SL) on swrast (SL on
Gert
>
> On Di, 2019-05-14 at 16:07 -0400, Marek Olšák wrote:
> > From: Marek Olšák
> >
> > ---
> > docs/features.txt | 10 --
> > 1 file changed, 10 deletions(-)
> >
> > diff --git a/docs/features.txt b/docs/features.txt
> > index
From: Marek Olšák
it's the same design
---
include/pci_ids/radeonsi_pci_ids.h| 32 +--
src/amd/common/ac_gpu_info.c | 2 --
src/amd/common/ac_llvm_util.c | 2 --
src/amd/common/ac_surface.c | 4 ---
src/amd/common
. code much. Those have nothing
to do with GFXn and they have their own version numbers.
Marek
On Wed, May 15, 2019 at 3:26 AM Dave Airlie wrote:
> > From: Marek Olšák
>
> It would be nice to have a reasoning why, I assume that is what they
> are called internally and in the kerne
From: Marek Olšák
---
src/amd/common/amd_family.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/amd/common/amd_family.h b/src/amd/common/amd_family.h
index 185ba029763..eed6553d44b 100644
--- a/src/amd/common/amd_family.h
+++ b/src/amd/common
From: Marek Olšák
---
docs/features.txt | 10 --
1 file changed, 10 deletions(-)
diff --git a/docs/features.txt b/docs/features.txt
index 38d6186dbe1..b1799550a0c 100644
--- a/docs/features.txt
+++ b/docs/features.txt
@@ -309,30 +309,20 @@ Khronos, ARB, and OES extensions
For the series:
Reviewed-by: Marek Olšák
Marek
On Mon, May 13, 2019 at 5:15 PM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> This dumps disassembly to the pipe_debug_callback together with shader
> stats.
>
> Can be used together with shader-db to get full disassem
Besides my comment on one of the patches, the series is:
Reviewed-by: Marek Olšák
Marek
On Sat, May 4, 2019 at 9:39 AM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> This implies that the memory will always be at address 0, which allows
> LLVM to generate slightly
On Sat, May 4, 2019 at 9:39 AM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Upcoming changes to LLVM will emit LDS objects as symbols in the ELF
> symbol table, with relocations that will be resolved with this change.
>
> Callers will also be able to define LDS symbols that are shared
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
src/gallium/drivers/radeonsi/si_query.c | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index aa7f012f071
From: Marek Olšák
This helps fix:
piglit/bin/ext_image_dma_buf_import-sample_yuv -fmt=NV12 -auto
Fixes: d88f3392fff7c6342f3840c4bd8195a1296c2372
---
src/mesa/main/teximage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main
For the series:
Reviewed-by: Marek Olšák
Marek
On Sun, May 12, 2019 at 9:05 AM wrote:
> From: Mathias Fröhlich
>
> Signed-off-by: Mathias Fröhlich
> ---
> src/mesa/main/state.c | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a
From: Marek Olšák
This reverts commit 7b85b9b8773b119360a31b66b321ae560a77cb6d.
---
src/compiler/nir/nir.h | 8
src/compiler/nir/nir_metadata.c | 2 +-
src/compiler/nir/nir_validate.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/compiler/nir/nir.h
From: Marek Olšák
src/mesa/state_tracker/st_tgsi_lower_yuv.c:68: void reg_dst(struct
tgsi_full_dst_register *, const struct tgsi_full_dst_register *, unsigned
int): assertion "dst->Register.WriteMask" failed
The second crash was due to insufficient allocated size for TGSI
inst
From: Marek Olšák
---
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
index 4a2377f7e09..5b840caf885 100644
--- a/src/gallium/winsys
From: Marek Olšák
just a cleanup
---
src/amd/common/ac_llvm_build.c| 15 ++-
src/amd/common/ac_nir_to_llvm.c | 2 +-
src/amd/vulkan/radv_nir_to_llvm.c | 8 +---
3 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd
From: Marek Olšák
This allows a nice cleanup, because the winsys always handles it.
---
src/amd/common/ac_gpu_info.c | 2 --
src/amd/common/ac_gpu_info.h | 1 -
src/gallium/drivers/r600/r600_pipe_common.c | 16 ++-
src/gallium/drivers/r600
From: Marek Olšák
To make it behave like amdgpu. I'm just trying to move this out of
radeonsi. The radeonsi code will be removed in the next commit.
---
src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 29 +++
src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 5
.../winsys
From: Marek Olšák
This is a prerequisite for the next commit.
Cc: 19.1
---
src/gallium/drivers/radeonsi/si_buffer.c | 7 +--
src/gallium/drivers/radeonsi/si_descriptors.c | 54 ---
src/gallium/drivers/radeonsi/si_state.h | 4 +-
3 files changed, 25 insertions
From: Marek Olšák
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108824
Cc: 19.1
---
src/gallium/drivers/radeonsi/si_descriptors.c | 94 ---
src/gallium/drivers/radeonsi/si_pipe.h| 2 +
src/gallium/drivers/radeonsi/si_state_draw.c | 9 +-
3 files changed, 72
From: Marek Olšák
debugoptimized builds don't define NDEBUG, but they also don't define
DEBUG. We want to enable cheap debug code for these builds.
I only chose those occurences that I care about.
---
src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 +-
src/gallium/drivers/radeonsi
From: Marek Olšák
Useful for dumping shaders.
---
src/mesa/state_tracker/st_debug.c | 4
src/mesa/state_tracker/st_debug.h | 6 --
2 files changed, 10 deletions(-)
diff --git a/src/mesa/state_tracker/st_debug.c
b/src/mesa/state_tracker/st_debug.c
index 27d50a17e5e..7faffb581ef 100644
From: Marek Olšák
---
src/amd/common/ac_binary.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/amd/common/ac_binary.c b/src/amd/common/ac_binary.c
index fabeb15a204..8f4755ebe16 100644
--- a/src/amd/common/ac_binary.c
+++ b/src/amd/common/ac_binary.c
@@ -281,25
The second half of si_shader_create that merges configs is now redundant,
isn't it?
I think the spi_ps_input_* stuff from patch 3 will also impact this patch,
right?
Patches 1-2, 5-9:
Reviewed-by: Marek Olšák
Marek
___
mesa-dev mailing list
mesa-dev
I'd like the beginning of the .c or .h file to describe what this is good
for, as it's not immediately obvious from the code.
See also below.
On Fri, May 3, 2019 at 7:19 AM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Using an explicit linker instead of just concatenating .text
> sections
On Fri, May 3, 2019 at 7:19 AM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> ---
> src/amd/common/ac_binary.c| 2 +
> src/gallium/drivers/radeonsi/si_compute.c | 14 +--
> src/gallium/drivers/radeonsi/si_shader.c | 112 +++---
>
For the series:
Reviewed-by: Marek Olšák
Marek
On Fri, May 3, 2019 at 7:06 AM Haehnle, Nicolai
wrote:
> On 03.05.19 12:36, Nicolai Hähnle wrote:
> > On 25.04.19 13:18, Nicolai Hähnle wrote:
> >> @@ -4618,21 +4648,27 @@ static void si_bind_vertex_elements(struct
> >&
Acked-by: Marek Olšák
Marek
On Mon, May 6, 2019 at 11:02 AM Emil Velikov
wrote:
> This new 'platform' is added by default with no guards.
>
> It is effectively a copy of the surfaceless one, with updated function
> names and brand new probe function.
>
> Due to the reuse,
Reviewed-by: Marek Olšák
Marek
On Thu, May 2, 2019 at 10:12 AM Samuel Pitoiset
wrote:
> This changes requires LLVM r356755.
>
> 32706 shaders in 16744 tests
> Totals:
> SGPRS: 1448848 -> 1455984 (0.49 %)
> VGPRS: 1016684 -> 1016220 (-0.05 %)
> Spilled SGPRs: 25871 -
There is a document about this in docs/, but I think you just need to add
the Cc: stable tag or the Fixes: tag to the commit message of all commits
you wanna nominate.
Mare
On Mon, May 6, 2019 at 12:12 PM Chuck Atkins
wrote:
> When doing an MR via GitLab, is adding the Cc: mesa-stable item
Reviewed-by: Marek Olšák
Marek
On Mon, May 6, 2019 at 8:19 PM Timothy Arceri wrote:
> This brings it inline with the recently added AMD_DEBUG.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109619
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 4
>
On Mon, May 6, 2019 at 11:19 AM Emil Velikov
wrote:
> On Sat, 4 May 2019 at 04:18, Marek Olšák wrote:
> >
> > On Fri, May 3, 2019 at 1:58 AM Mathias Fröhlich <
> mathias.froehl...@gmx.net> wrote:
> >>
> >> Good Morning,
> >>
> >&
On Mon, May 6, 2019 at 11:02 AM Emil Velikov
wrote:
> From: Emil Velikov
>
> By default, the user is likely to pick the first device so it should
> not be the least performant (aka software) one.
>
> Suggested-by: Marek Olšák
> Signed-off-by: Emil Velikov
> ---
>
For patches 1-7:
Reviewed-by: Marek Olšák
Marek
On Mon, May 6, 2019 at 11:02 AM Emil Velikov
wrote:
> From: Emil Velikov
>
> By default, the user is likely to pick the first device so it should
> not be the least performant (aka software) one.
>
> Suggested-by: Marek O
On Fri, May 3, 2019 at 1:58 AM Mathias Fröhlich
wrote:
> Good Morning,
>
> On Wednesday, 1 May 2019 21:43:08 CEST Marek Olšák wrote:
> > BTW, swrast doesn't have to exist on the system. It's not uncommon for me
> > to have no swrast on my development system.
>
> Ok. I
This bug is only on Vega10 and Raven1.
Marek
On Wed, May 1, 2019 at 10:10 AM Samuel Pitoiset
wrote:
> This chip doesn't need the fixup. This fixes a bunch of
> dEQP-VK.tessellation tests and avoid random GPU hangs.
>
> Cc: "19.0"
> Signed-off-by: Samuel Pitoiset
> ---
>
e fix was vs tidy ups. I didn't want to go
> looking over specs either, all the relevant information should have been
> here in the commit message.
>
> Thanks,
> Tim
>
>
> On 2/5/19 11:17 am, Marek Olšák wrote:
> > Ping
> >
> > On Wed, Apr 24, 2019 at 1:30 PM
If there is no other feedback, I'll push this tomorrow.
Marek
On Mon, Apr 29, 2019 at 6:12 PM Marek Olšák wrote:
> This patch might improve performance, because less submitted unfinished
> work means less used memory by the unfinished work.
>
> Marek
>
> On Mon, Apr 29, 2019
Ping
On Wed, Apr 24, 2019 at 1:30 PM Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/compiler/glsl/builtin_functions.cpp | 78 -
> 1 file changed, 24 insertions(+), 54 deletions(-)
>
> diff --git a/src/compiler/glsl/builtin_functions.cpp
r 2019 at 22:50, Marek Olšák wrote:
> > >
> > > On Mon, Apr 29, 2019 at 4:00 AM Pekka Paalanen
> wrote:
> > >>
> > >> On Sat, 27 Apr 2019 09:38:27 -0400
> > >> Marek Olšák wrote:
> > >>
> > >> > Those are all va
Why can we not use tbuffer loads?
Marek
On Thu, Apr 25, 2019 at 7:18 AM Nicolai Hähnle wrote:
> Hi all,
>
> the following patches contain code to implement all vertex fetches
> using plain, non-format loads plus explicit shader arithmetic for
> format conversion.
>
> This allows us to remove
Rb for the series. (I can't type my surname on the phone)
Marek
On Thu, Apr 25, 2019, 3:03 AM Timothy Arceri wrote:
> Some of the opts are not called in the general optimastion loop
> in the state trackers glsl -> nir conversion. We need to call
> the radeonsi specific optimisation once before
It would be better to add a pipe cap for this. I don't think you need
uint64_t here.
Marek
On Tue, Apr 30, 2019, 6:45 AM Sahu, Satyajit wrote:
> Query the uvd handles info. If the used uvd handles are equals to
> max possible handles then return error.
>
> Signed-off-by: Satyajit Sahu
> ---
>
, Apr 30, 2019, 1:25 PM Adam Jackson wrote:
> On Mon, 2019-04-29 at 20:35 -0400, Marek Olšák wrote:
>
> > Yeah that's possible. The thing is that a GL context can have a
> > doublebuffered config and begin with GL_BACK as the draw buffer, but
> > MakeCurrent can set a pbuff
On Tue, Apr 30, 2019 at 5:59 AM Mathias Fröhlich
wrote:
>
> Adam, Marek,
>
> On Monday, 29 April 2019 18:28:21 CEST Adam Jackson wrote:
> > On Fri, 2019-04-26 at 23:31 -0400, Marek Olšák wrote:
> >
> > I don't claim to know what this series is trying to fix, but
On Mon, Apr 29, 2019 at 12:28 PM Adam Jackson wrote:
> On Fri, 2019-04-26 at 23:31 -0400, Marek Olšák wrote:
>
> I don't claim to know what this series is trying to fix, but:
>
> > +* 2) Pbuffers are back buffers from the application point of view,
> > +*bu
, 2019 at 10:23 AM Mathias Fröhlich
wrote:
> Hi Marek,
>
> one comment/failure inline:
>
> On Saturday, 27 April 2019 05:31:45 CEST Marek Olšák wrote:
> > From: Marek Olšák
> >
> > It's needed by the next pbuffer fix, which changes the behavior of
> > draw_buffe
This patch might improve performance, because less submitted unfinished
work means less used memory by the unfinished work.
Marek
On Mon, Apr 29, 2019 at 11:07 AM Michel Dänzer wrote:
> On 2019-04-27 6:13 p.m., Rob Clark wrote:
> > On Thu, Apr 25, 2019 at 7:06 PM Marek Olš
On Mon, Apr 29, 2019 at 4:00 AM Pekka Paalanen wrote:
> On Sat, 27 Apr 2019 09:38:27 -0400
> Marek Olšák wrote:
>
> > Those are all valid reasons, but I don't wanna expose swrast for AMD's
> > customers.
>
> Hi Marek,
>
> is you objection that you will never
Reverting the st/mesa commit would be fine.
Marek
On Mon, Apr 29, 2019 at 3:20 PM Ilia Mirkin wrote:
> On Mon, Apr 29, 2019 at 3:06 PM Viktor Jaegerskuepper
> wrote:
> >
> > Hi Ilia,
> >
> > Ilia Mirkin:
> > > If you can reproduce the issue
> > > at will, could I recommend you try undoing
201 - 300 of 12098 matches
Mail list logo
