Re: [Mesa-dev] [PATCH 04/12] nvc0: bind driver consts on buffer 15 for compute on Fermi

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 12:02 AM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:38 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 13 ++---

Re: [Mesa-dev] [PATCH 2/2] glsl: return cloned signature, not the builtin one

2016-02-07 Thread Timothy Arceri
On Sat, 2016-02-06 at 17:10 -0500, Ilia Mirkin wrote: > The builtin data can get released with a glReleaseShaderCompiler > call. > We're careful everywhere to clone everything that comes out of > builtins > except here, where we accidentally return the signature belonging to > the > builtin

Re: [Mesa-dev] [PATCH v2 3/5] nv50: add PIPE_QUERY_OCCLUSION_PREDICATE support

2016-02-07 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 02/07/2016 02:53 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin v1 -> v2: adjust begin/end methods as well --- Tested this time around. src/gallium/drivers/nouveau/nv50/nv50_query_hw.c | 6 ++ 1 file

Re: [Mesa-dev] [PATCH 06/12] nvc0: bind textures/samplers for compute on Fermi

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 12:04 AM, Ilia Mirkin wrote: Seems like it would make sense to stick these into nvc0_tex along with the existing 3d functions that these are mostly copying. Perhaps refactor so that they share logic? I wasn't not sure about sharing the same code for both 3D and compute, but

Re: [Mesa-dev] [PATCH 11/12] nv50/ir: add atomics support on shared memory for Fermi

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 12:23 AM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:38 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 1 +

Re: [Mesa-dev] [PATCH 01/12] nvc0: allocate an area for compute user constbufs

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 10:38 AM, Michael Schellenberger Costa wrote: Hi, Am 06/02/2016 um 23:38 schrieb Samuel Pitoiset: For compute shaders, we might need to upload uniforms. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 14

Re: [Mesa-dev] [PATCH 02/12] nvc0: allow to push constant buffers for compute on Fermi

2016-02-07 Thread Samuel Pitoiset
On 02/06/2016 11:52 PM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:38 PM, Samuel Pitoiset wrote: Constant buffers must be bound for compute like for 3D. This is done by adding a new 'shader' parameter to nvc0_cb_bo_push() which allows to use the compute channel

Re: [Mesa-dev] [PATCH 1/2] glsl: make sure builtins are initialized before getting the shader

2016-02-07 Thread Timothy Arceri
On Sat, 2016-02-06 at 17:10 -0500, Ilia Mirkin wrote: It would be have been nice to have some reasoning in here, the scenario its fixing etc. > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedesktop.org > --- >  src/compiler/glsl/linker.cpp | 1 + >  1 file changed,

Re: [Mesa-dev] [PATCH 07/12] nvc0: add support for indirect compute on Fermi

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 12:13 AM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:38 PM, Samuel Pitoiset wrote: When indirect compute is used, the size of the grid (in blocks) is stored as three integers inside a buffer. This requires a macro to set up GRIDDIM_YX and GRIDDIM_Z.

Re: [Mesa-dev] [PATCH v2 06/20] gallium: add a new interface for pipe_context::launch_grid()

2016-02-07 Thread Samuel Pitoiset
On 02/06/2016 11:04 PM, Samuel Pitoiset wrote: This introduces pipe_grid_info which contains all information to describe a launch_grid call. This will be used to implement indirect compute in the same fashion as indirect draw. Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 1/2] glsl: make sure builtins are initialized before getting the shader

2016-02-07 Thread Ilia Mirkin
On Sun, Feb 7, 2016 at 3:49 AM, Timothy Arceri wrote: > On Sat, 2016-02-06 at 17:10 -0500, Ilia Mirkin wrote: > > It would be have been nice to have some reasoning in here, > the scenario its fixing etc. > >> Signed-off-by: Ilia Mirkin >> Cc:

Re: [Mesa-dev] [PATCH 3/5] nir: Do opt_algebraic in reverse order.

2016-02-07 Thread Eduardo Lima Mitev
On 02/05/2016 02:47 AM, Matt Turner wrote: > Walking the SSA definitions in order means that we consider the smallest > algebraic optimizations before larger optimizations. So if a smaller > rule is part of a larger rule, the smaller one will happen first, > preventing the larger one from

Re: [Mesa-dev] [PATCH v2 05/20] gallium/cso: add support for compute shaders

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 12:28 AM, Ilia Mirkin wrote: I believe that the previous suggestion was that cso didn't need to know anything about compute shaders... just call the functions directly. It seems like the previous suggestion was to *only* remove cso_{save,restore}_compute_shader() because they

Re: [Mesa-dev] [PATCH] mesa/extensions: Fix NVX_gpu_memory_info lexicographical order.

2016-02-07 Thread Marek Olšák
Reviewed-by: Marek Olšák On Sat, Feb 6, 2016 at 8:30 AM, Vinson Lee wrote: > Fixes MesaExtensionsTest.AlphabeticallySorted. > > Fixes: 1d79b9958090 ("mesa: implement GL_NVX_gpu_memory_info (v2)") > Bugzilla:

Re: [Mesa-dev] [PATCH 3/5] nir: Do opt_algebraic in reverse order.

2016-02-07 Thread Jason Ekstrand
On Feb 4, 2016 5:45 PM, "Matt Turner" wrote: > > Walking the SSA definitions in order means that we consider the smallest > algebraic optimizations before larger optimizations. So if a smaller > rule is part of a larger rule, the smaller one will happen first, > preventing the

Re: [Mesa-dev] [PATCH v2 09/20] tgsi/ureg: add shared variables support for compute shaders

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 12:51 AM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:04 PM, Samuel Pitoiset wrote: This introduces TGSI_FILE_MEMORY for shared, global and local memory. Only shared memory is currently supported. Changes from v2: - introduce TGSI_FILE_MEMORY

Re: [Mesa-dev] [PATCH v2 19/20] st/mesa: expose ARB_compute_shader when compute is supported

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 01:02 AM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:04 PM, Samuel Pitoiset wrote: ARB_compute_shader is only enabled if the underlying driver exposes TGSI through the PIPE_CAP_SHADER_SUPPORTED_IRS cap. Changes from v2: - make use of the new

Re: [Mesa-dev] [PATCH 4/4] tgsi: minor whitespace fixes in tgsi_scan.c

2016-02-07 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Sat, Feb 6, 2016 at 1:56 AM, Brian Paul wrote: > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 08/20] gallium: add PIPE_SHADER_CAP_SUPPORTED_IRS

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 12:50 AM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:04 PM, Samuel Pitoiset wrote: This cap indicates the supported representations of programs. It should be a flag with the pipe_shader_ir enum values. It will allow to enable ARB_compute_shader if

Re: [Mesa-dev] [PATCH v2 05/20] gallium/cso: add support for compute shaders

2016-02-07 Thread Marek Olšák
On Sun, Feb 7, 2016 at 12:02 PM, Samuel Pitoiset wrote: > > > On 02/07/2016 12:28 AM, Ilia Mirkin wrote: >> >> I believe that the previous suggestion was that cso didn't need to >> know anything about compute shaders... just call the functions >> directly. > > > It

Re: [Mesa-dev] [PATCH 07/12] nvc0: add support for indirect compute on Fermi

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 05:56 AM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 6:13 PM, Ilia Mirkin wrote: On Sat, Feb 6, 2016 at 5:38 PM, Samuel Pitoiset wrote: When indirect compute is used, the size of the grid (in blocks) is stored as three integers

Re: [Mesa-dev] [PATCH 3/3] gallium/util: switch over to new u_debug_image.[ch] code

2016-02-07 Thread Marek Olšák
On Sat, Feb 6, 2016 at 1:54 AM, Brian Paul wrote: > --- > src/gallium/auxiliary/Makefile.sources | 4 +- > src/gallium/auxiliary/util/u_debug.c | 313 > + > src/gallium/auxiliary/util/u_debug.h | 39 >

Re: [Mesa-dev] gallium AoA support and indirect sampler fixes

2016-02-07 Thread Laurent Carlier
Le vendredi 5 février 2016, 13:40:26 CET Dave Airlie a écrit : > Hi, > > In fixing some indirect sampler issues with ARB_gpu_shader5, > I realised AoA was mostly fixed as well by the same things. > > Ilia made me fix atomics as well. > > So thise patch set enables AoA support on all gallium

Re: [Mesa-dev] [PATCH] trace: remove useless MALLOC() in trace_context_draw_vbo()

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 10:54 PM, Ilia Mirkin wrote: Reviewed-by: Ilia Mirkin Please double-check that GALLIUM_TRACE=foo and bin/arb_indirect_parameters-tf-count -fbo -auto work together. I have already double-checked with bin/arb_draw_indirect-draw-arrays. Both tests work

Re: [Mesa-dev] [PATCH 2/2] glsl: return cloned signature, not the builtin one

2016-02-07 Thread Rob Herring
On Sat, Feb 6, 2016 at 4:10 PM, Ilia Mirkin wrote: > The builtin data can get released with a glReleaseShaderCompiler call. > We're careful everywhere to clone everything that comes out of builtins > except here, where we accidentally return the signature belonging to the >

Re: [Mesa-dev] [PATCH 1/2] glsl: make sure builtins are initialized before getting the shader

2016-02-07 Thread Rob Herring
On Sat, Feb 6, 2016 at 4:10 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > Cc: mesa-sta...@lists.freedesktop.org Thanks for digging into this. Tested-by: Rob Herring > --- > src/compiler/glsl/linker.cpp | 1 + > 1 file

[Mesa-dev] [PATCH v2 09/11] nv50/ir: make OP_SELP a compare instruction

2016-02-07 Thread Samuel Pitoiset
This OP_SELP insn will be used to handle compare and swap subops. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 8 src/gallium/drivers/nouveau/codegen/nv50_ir_inlines.h | 4 ++-- 2 files changed, 6

[Mesa-dev] [PATCH v2 01/11] nvc0: allocate an area for compute user constbufs

2016-02-07 Thread Samuel Pitoiset
For compute shaders, we might need to upload uniforms. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 14 +++--- src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 12 ++--

[Mesa-dev] [PATCH v2 06/11] nvc0: add support for indirect compute on Fermi

2016-02-07 Thread Samuel Pitoiset
When indirect compute is used, the size of the grid (in blocks) is stored as three integers inside a buffer. This requires a macro to set up GRIDDIM_YX and GRIDDIM_Z. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/mme/Makefile | 2 +-

[Mesa-dev] [PATCH v2 08/11] nv50/ir: add lock/unlock subops for load/store

2016-02-07 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h| 2 ++ .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp| 16 ++-- src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp| 10 ++ 3 files

[Mesa-dev] [PATCH v2 05/11] nvc0: bind textures/samplers for compute on Fermi

2016-02-07 Thread Samuel Pitoiset
Changes from v2: - refactor the code to share (almost) the same logic between 3d and compute Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 38 +++-- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 2 ++

[Mesa-dev] [PATCH v2 02/11] nvc0: bind constant buffers for compute on Fermi

2016-02-07 Thread Samuel Pitoiset
Loosely based on 3D. Changes from v2: - get rid of the 's' param to nvc0_cb_bo_push() because it doesn't matter to upload constbufs for compute using the 3d chan Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 60

[Mesa-dev] [PATCH v2 04/11] nvc0: bind shader buffers for compute on Fermi

2016-02-07 Thread Samuel Pitoiset
Loosely based on 3D. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 34 + src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 12 ++--- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 4 ++-

[Mesa-dev] [PATCH] trace: add missing pipe_context::clear_texture()

2016-02-07 Thread Samuel Pitoiset
This fixes a crash with bin/arb_clear_texture-base-formats and probably some other tests which use clear_texture(). Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/trace/tr_context.c | 30 ++ 1 file changed, 30 insertions(+) diff

Re: [Mesa-dev] [PATCH 3/5] nir: Do opt_algebraic in reverse order.

2016-02-07 Thread Matt Turner
On Sun, Feb 7, 2016 at 6:04 AM, Eduardo Lima Mitev wrote: > On 02/05/2016 02:47 AM, Matt Turner wrote: >> Walking the SSA definitions in order means that we consider the smallest >> algebraic optimizations before larger optimizations. So if a smaller >> rule is part of a larger

Re: [Mesa-dev] [PATCH v2 14/20] st/mesa: keep track of shared memory declarations

2016-02-07 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Feb 6, 2016 at 5:04 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 19 --- > 1 file changed, 16

Re: [Mesa-dev] [PATCH v2 04/20] mesa: add PROGRAM_MEMORY

2016-02-07 Thread Ilia Mirkin
Ugh, with this we're going to end up overflowing gl_register_file when I add images... it ends up getting stored as 4 bits somewhere. Oh well, not your problem. Reviewed-by: Ilia Mirkin On Sat, Feb 6, 2016 at 5:04 PM, Samuel Pitoiset wrote: >

[Mesa-dev] [PATCH] trace: remove useless MALLOC() in trace_context_draw_vbo()

2016-02-07 Thread Samuel Pitoiset
There is no need to allocate memory when unwrapping the indirect buf. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/trace/tr_context.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] trace: remove useless MALLOC() in trace_context_draw_vbo()

2016-02-07 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Please double-check that GALLIUM_TRACE=foo and bin/arb_indirect_parameters-tf-count -fbo -auto work together. On Sun, Feb 7, 2016 at 4:36 PM, Samuel Pitoiset wrote: > There is no need to allocate memory when unwrapping

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-07 Thread Matt Turner
On Sun, Feb 7, 2016 at 1:37 PM, Juha-Pekka Heikkilä wrote: > Hi Iago, > > I know there are lot of places where there is malloc unchecked still > -- and then there is ralloc which is a story of its own. Reason why I > think checking these would be remotely useful in

Re: [Mesa-dev] [PATCH] trace: add missing pipe_context::clear_texture()

2016-02-07 Thread Ilia Mirkin
On Sun, Feb 7, 2016 at 5:32 PM, Samuel Pitoiset wrote: > This fixes a crash with bin/arb_clear_texture-base-formats and > probably some other tests which use clear_texture(). > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] winsys/radeon: fix a wrong NUM_TILE_PIPES value from the kernel

2016-02-07 Thread Nick Sarnie
Hi, This fixes the bug for me. Tested-by: Nick Sarnie Thanks On Sun, Feb 7, 2016 at 2:25 PM, Marek Olšák wrote: > From: Marek Olšák > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94019 > --- >

[Mesa-dev] [PATCH v2 03/11] nvc0: bind driver consts on buffer 15 for compute on Fermi

2016-02-07 Thread Samuel Pitoiset
Changes from v2: - always bind the driver consts even if user params come in via clover Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 12 +--- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 2 ++ 2 files changed, 11

[Mesa-dev] [PATCH v2 10/11] nv50/ir: add atomics support on shared memory for Fermi

2016-02-07 Thread Samuel Pitoiset
Changes from v2: - make sure the op is OP_SELP when emitting the predicate and add one assert - use bld.getSSA() for mkOp2() - add cross edge between tryLockAndSetBB and joinBB Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp

[Mesa-dev] [PATCH v2 11/11] nvc0: enable compute shaders on Fermi

2016-02-07 Thread Samuel Pitoiset
Kepler compute support is really different than Fermi and it's not ready yet. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 07/11] nv50/ir: use s[] addr space for shared buffers

2016-02-07 Thread Samuel Pitoiset
Shared memory address space (FILE_MEMORY_SHARED) must be used instead of global memory when a shared memory area is declared. Changes from v2: - oops, do not remove TGSI_FILE_BUFFER in a switch in nv50_ir_from_tgsi.cpp Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-07 Thread Juha-Pekka Heikkilä
Hi Iago, I know there are lot of places where there is malloc unchecked still -- and then there is ralloc which is a story of its own. Reason why I think checking these would be remotely useful in windows only (or other way around, not under linux kernel) is on Windows one can get the null

Re: [Mesa-dev] [PATCH] trace: add missing pipe_context::clear_texture()

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 11:39 PM, Ilia Mirkin wrote: On Sun, Feb 7, 2016 at 5:32 PM, Samuel Pitoiset wrote: This fixes a crash with bin/arb_clear_texture-base-formats and probably some other tests which use clear_texture(). Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] gallium AoA support and indirect sampler fixes

2016-02-07 Thread Laurent Carlier
2016-02-07 15:13 GMT+01:00 Laurent Carlier : > Le vendredi 5 février 2016, 13:40:26 CET Dave Airlie a écrit : > > Hi, > > > > In fixing some indirect sampler issues with ARB_gpu_shader5, > > I realised AoA was mostly fixed as well by the same things. > > > > Ilia made me fix

Re: [Mesa-dev] [PATCH v2 06/20] gallium: add a new interface for pipe_context::launch_grid()

2016-02-07 Thread Ilia Mirkin
On Sun, Feb 7, 2016 at 5:59 AM, Samuel Pitoiset wrote: > > > On 02/06/2016 11:04 PM, Samuel Pitoiset wrote: >> >> This introduces pipe_grid_info which contains all information to >> describe a launch_grid call. This will be used to implement indirect >> compute in the

Re: [Mesa-dev] [PATCH v2 06/20] gallium: add a new interface for pipe_context::launch_grid()

2016-02-07 Thread Samuel Pitoiset
On 02/07/2016 07:00 PM, Ilia Mirkin wrote: On Sun, Feb 7, 2016 at 5:59 AM, Samuel Pitoiset wrote: On 02/06/2016 11:04 PM, Samuel Pitoiset wrote: This introduces pipe_grid_info which contains all information to describe a launch_grid call. This will be used to

[Mesa-dev] [PATCH] winsys/radeon: fix a wrong NUM_TILE_PIPES value from the kernel

2016-02-07 Thread Marek Olšák
From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94019 --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c

[Mesa-dev] [PATCH 06/12] st/nine: Support ATI1/ATI2 for CubeTexture

2016-02-07 Thread Axel Davy
Texture and CubeTexture use common code, and thus ATI1/ATI2 is already implemented for CubeTexture. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 5 +++-- src/gallium/state_trackers/nine/cubetexture9.c | 4

[Mesa-dev] [PATCH 05/12] st/nine: Clean pSharedHandle Texture ctors checks

2016-02-07 Thread Axel Davy
Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/cubetexture9.c | 7 --- src/gallium/state_trackers/nine/texture9.c | 25 src/gallium/state_trackers/nine/volumetexture9.c | 7 --- 3 files changed, 21 insertions(+), 18

Re: [Mesa-dev] [PATCH 10/12] st/nine: Remove usage of SQRT in ff code

2016-02-07 Thread Ilia Mirkin
On Sun, Feb 7, 2016 at 6:26 PM, Axel Davy wrote: > On 08/02/2016 00:21, Ilia Mirkin wrote: >> >> On Sun, Feb 7, 2016 at 6:13 PM, Axel Davy wrote: >>> >>> SQRT is not supported everywhere, so replace >>> it by RSQ + RCP >>> >>> Signed-off-by: Axel Davy

Re: [Mesa-dev] [PATCH v2 02/11] nvc0: bind constant buffers for compute on Fermi

2016-02-07 Thread Ilia Mirkin
Don't these all overwrite one another? i.e. 3d and compute? So don't you need to adjust the state s.t. everything is dirtied on the "other side" (coincidentally, it seems likely that compute only aliases with frag shaders). On Sun, Feb 7, 2016 at 3:49 PM, Samuel Pitoiset

Re: [Mesa-dev] [android-x86-devel] [PATCH 4/5] android: fix building with new glsl, nir, compiler libraries

2016-02-07 Thread Mauro Rossi
Hi, Just to close this thread, I've checked on both marshamallow-x86 and kitkat-x86 builds and the line $(MESA_TOP)/src/glsl which is now a non-existent path, is not needed anymore and can be removed in LOCAL_C_INCLUDES for all the following android makefiles:

Re: [Mesa-dev] [PATCH 00/12] Some more Nine fixes

2016-02-07 Thread Axel Davy
The last patch awaits moderation because of its size, you can find it here: https://github.com/iXit/Mesa-3D/commit/29e2ccf64273814071655d84aca69b6496fbb4bd On 08/02/2016 00:13, Axel Davy wrote: A few more patches I'd like to get in 11.2. There a few cleanup patches and some fixes. The last

[Mesa-dev] [PATCH 08/12] st/nine: SCRATCH does support all formats

2016-02-07 Thread Axel Davy
Add new argument to d3d9_to_pipe_format_checked to be able to bypass format support checks. This argument is set to TRUE when the requested Pool is SCRATCH. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 21 +++--

[Mesa-dev] [PATCH 07/12] st/nine: Add format checks to create_zs_or_rt_surface

2016-02-07 Thread Axel Davy
Returns INVALIDCALL when trying to create a surface of unsupported format. In practice, apps are supposed to check for format support before trying to create a render target of that format. However some bad behaving apps could just try to create the surface and deduce if it failed that it wasn't

[Mesa-dev] [PATCH 10/12] st/nine: Remove usage of SQRT in ff code

2016-02-07 Thread Axel Davy
SQRT is not supported everywhere, so replace it by RSQ + RCP Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c

[Mesa-dev] [PATCH 09/12] st/nine: Fix stateblocks crashes with lights

2016-02-07 Thread Axel Davy
We had several issues of crashes with it. This should fix it. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/stateblock9.c | 40 +-- 1 file changed, 32 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 04/12] st/nine: Move texture creation checks

2016-02-07 Thread Axel Davy
We were having checks at both Create*Texture functions and in ctors. Move all Create*Texture checks to ctors. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/cubetexture9.c | 2 ++ src/gallium/state_trackers/nine/device9.c| 13 -

[Mesa-dev] [PATCH 01/12] st/nine: Do not set resource usage for SYSTEMMEM

2016-02-07 Thread Axel Davy
We do not create a resource for SYSTEMMEM textures, thus we do not need to set resource usage. The only exception is vertexbuffer SYSTEMMEM, since we do use a pipe resource for them. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 11 ---

[Mesa-dev] [PATCH 00/12] Some more Nine fixes

2016-02-07 Thread Axel Davy
A few more patches I'd like to get in 11.2. There a few cleanup patches and some fixes. The last patch fixes build with llvm 32 bits when it isn't built with -mstackrealign. Basically Apps have a 4 byte aligned stack, and it needs to be converted at some point to 16 byte aligned stack to have

[Mesa-dev] [PATCH 02/12] st/nine: Do not set SHARED flag for shared textures.

2016-02-07 Thread Axel Davy
We do not support shared textures, thus no need to set the shared flag. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/texture9.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/texture9.c

[Mesa-dev] [PATCH 11/12] st/nine: Drop path for ureg_NRM and ureg_CLAMP

2016-02-07 Thread Axel Davy
using MIN/MAX is fine instead of CLAMP. NRM doesn't exist anymore. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c

[Mesa-dev] [PATCH 03/12] st/nine: Clean useless code in texture9.c

2016-02-07 Thread Axel Davy
This->base.base.resource is worth NULL for SYSTEMMEM textures. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/texture9.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/nine/texture9.c

Re: [Mesa-dev] [PATCH 10/12] st/nine: Remove usage of SQRT in ff code

2016-02-07 Thread Ilia Mirkin
On Sun, Feb 7, 2016 at 6:13 PM, Axel Davy wrote: > SQRT is not supported everywhere, so replace > it by RSQ + RCP > > Signed-off-by: Axel Davy > --- > src/gallium/state_trackers/nine/nine_ff.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

[Mesa-dev] [Bug 94016] make check MesaExtensionsTest.AlphabeticallySorted regression

2016-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94016 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 10/12] st/nine: Remove usage of SQRT in ff code

2016-02-07 Thread Axel Davy
On 08/02/2016 00:21, Ilia Mirkin wrote: On Sun, Feb 7, 2016 at 6:13 PM, Axel Davy wrote: SQRT is not supported everywhere, so replace it by RSQ + RCP Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 3 ++- 1 file changed, 2

Re: [Mesa-dev] [llvm] r259796 - [X86][SSE] Add general 32-bit LOAD + VZEXT_MOVL support to EltsFromConsecutiveLoads

2016-02-07 Thread Simon Pilgrim
Michel, thanks for the report, this should be fixed by rL259991. > On 5 Feb 2016, at 10:10, Michel Dänzer wrote: > > > Hi Simon, > > > On 05.02.2016 01:12, Simon Pilgrim via llvm-commits wrote: >> Author: rksimon >> Date: Thu Feb 4 10:12:56 2016 >> New Revision: 259796

Re: [Mesa-dev] [PATCH 01/12] nvc0: allocate an area for compute user constbufs

2016-02-07 Thread Michael Schellenberger Costa
Hi, Am 06/02/2016 um 23:38 schrieb Samuel Pitoiset: > For compute shaders, we might need to upload uniforms. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 14 +++--- >

[Mesa-dev] [PATCH 3/5] mesa: drop unused nonconst sampler functions.

2016-02-07 Thread Dave Airlie
Since we fixed the glsl->tgsi conversion we no longer need this function. Signed-off-by: Dave Airlie --- src/mesa/program/sampler.cpp | 10 -- src/mesa/program/sampler.h | 4 2 files changed, 14 deletions(-) diff --git a/src/mesa/program/sampler.cpp

[Mesa-dev] gallium AoA and indirect samplers fixes (second posting)

2016-02-07 Thread Dave Airlie
Since the last set posted, I've taken Timothy's review on board, discovered the double life of var->data.location and managed to find a balance between base/index issues that doesn't regress. This should work a lot better, despite increasing the side of ir_variable. Dave.

[Mesa-dev] [PATCH 2/5] st/mesa: handle indirect samplers in arrays/structs properly (v4)

2016-02-07 Thread Dave Airlie
From: Dave Airlie The state tracker never handled this properly, and it finally annoyed me for the second time so I decided to fix it properly. This is inspired by the NIR sampler lowering code and I only realised NIR seems to do its deref ordering different to GLSL at the

[Mesa-dev] [PATCH 1/5] glsl/ir: add param index to variable.

2016-02-07 Thread Dave Airlie
From: Dave Airlie We have a requirement to store the index into the mesa parameterlist for uniforms. Up until now we've overwritten var->data.location with this info. However this then stops us accessing UniformStorage, which is needed to do proper dereferencing. Add a new

[Mesa-dev] [PATCH 5/5] st/mesa: enable AoA for gallium drivers reporting GLSL 1.30

2016-02-07 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- docs/GL3.txt | 2 +- docs/relnotes/11.2.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 4/5] st/mesa: add atomic AoA support

2016-02-07 Thread Dave Airlie
reuse the sampler deref handling code to do the same thing for atomics. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH 5/5] st/mesa: enable AoA for gallium drivers reporting GLSL 1.30

2016-02-07 Thread Mike Lothian
Does that also add in AoA for OpenGL ES 3.1 or will that require more work? On Mon, 8 Feb 2016 at 03:46 Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > docs/GL3.txt | 2 +- >

Re: [Mesa-dev] [PATCH 5/5] st/mesa: enable AoA for gallium drivers reporting GLSL 1.30

2016-02-07 Thread Dave Airlie
On 8 February 2016 at 14:26, Mike Lothian wrote: > Does that also add in AoA for OpenGL ES 3.1 or will that require more work? Good question, I've no idea. but I think desktop is > GLES in this case, so I should update GL3.txt for that as well then. Dave.

[Mesa-dev] [PATCH] st/mesa: handle const initialisers better

2016-02-07 Thread Dave Airlie
If we have constant initialisers up until this point, collapse things and set the array size to 1. This fixes tests/spec/arb_arrays_of_arrays/execution/sampler/fs-initializer-const-index.shader_test Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |

Re: [Mesa-dev] gallium AoA support and indirect sampler fixes

2016-02-07 Thread Dave Airlie
On 8 February 2016 at 00:13, Laurent Carlier wrote: > Le vendredi 5 février 2016, 13:40:26 CET Dave Airlie a écrit : >> Hi, >> >> In fixing some indirect sampler issues with ARB_gpu_shader5, >> I realised AoA was mostly fixed as well by the same things. >> >> Ilia made me

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 --- Comment #3 from b...@bob131.so --- Fabian Deutsch The backtrace shows that clover is used. Component: ocl-icd → mesa -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 --- Comment #4 from b...@bob131.so --- I've tried with a variety of different configurations to check whether this bug might be setup-specific. I normally use two GPUs from mixed vendors, but I tried using a single GTX570, HD6870, HD6950, 9800GT

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 --- Comment #2 from b...@bob131.so --- Created attachment 121583 --> https://bugs.freedesktop.org/attachment.cgi?id=121583=edit Blender GDB backtrace -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 --- Comment #5 from b...@bob131.so --- Fabian Deutsch I strongly suspect that it's an issue if clover/mesa's opencl tracker, please file a bug in upstream or retry with the latest release from rawhide. Status: NEW →

Re: [Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

2016-02-07 Thread Michel Dänzer
On 07.02.2016 08:56, Mauro Rossi wrote: > From e33d112be85e86c2537c26622969dea7dfd16186 Mon Sep 17 00:00:00 2001 > From: Mauro Rossi > > Date: Sat, 6 Feb 2016 23:54:24 +0100 > Subject: [PATCH 2/2] android: radeonsi: fix building error in

Re: [Mesa-dev] [llvm] r259796 - [X86][SSE] Add general 32-bit LOAD + VZEXT_MOVL support to EltsFromConsecutiveLoads

2016-02-07 Thread Michel Dänzer
On 07.02.2016 01:51, Simon Pilgrim wrote: > Michel, thanks for the report, this should be fixed by rL259991. Yeah it's fixed, thanks! -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 --- Comment #1 from b...@bob131.so --- User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 Build Identifier: Apologies if I've mischaracterised anything above, I'm going off of my uninformed analysis

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 Bug ID: 94040 Summary: clGetPlatformIDs causes futex race condition Product: Mesa Version: 11.0 Hardware: Other OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

2016-02-07 Thread Michel Dänzer
On 07.02.2016 08:55, Mauro Rossi wrote: > From 8030a6cd9d7bb3320fca94038f1969db56223598 Mon Sep 17 00:00:00 2001 > From: Mauro Rossi > > Date: Sat, 6 Feb 2016 23:52:36 +0100 > Subject: [PATCH 1/2] android: add support for strchrnul > > Android