Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-30 Thread Dylan Baker
Quoting Mike Lothian (2018-03-29 17:49:30) > > > On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > > Quoting Mike Lothian (2018-03-29 16:56:28) > > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > > > Fixes: 2dd4f35c7fc llvm-c: Split Utils out of

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

2018-03-30 Thread Jason Ekstrand
On March 30, 2018 09:40:13 Brian Paul wrote: OK, I'll have some patches soon but I'm stuck on one issue. Around spriv_to_nir.c:2090 we have if (operands & SpvImageOperandsConstOffsetsMask) { gather_offsets = vtn_ssa_value(b, w[idx++]); (*p++) = (nir_tex_src){}; } The

Re: [Mesa-dev] Question about NIR changes since mesa 17.3

2018-03-30 Thread Timothy Arceri
On 31/03/18 00:43, Qiang Yu wrote: Hi guys, I'm rebasing the mesa-lima code from 17.3 to 18.0 and found the NIR changes in 18.0 will always do nir_lower_io_to_scalar_early() for the output of vertex shader and input of fragment shader. My first question is: Is it for the link time

[Mesa-dev] [AppVeyor] mesa master #7342 completed

2018-03-30 Thread AppVeyor
Build mesa 7342 completed Commit bebf758c49 by Brian Paul on 3/27/2018 6:39 PM: docs: document WGL_SWAP_INTERVAL env var\n\nReviewed-by: Charmaine Lee Configure your notification preferences

Re: [Mesa-dev] [PATCH] nir+drivers: add helpers to get # of src/dest components

2018-03-30 Thread Eric Anholt
Rob Clark writes: > Add helpers to get the number of src/dest components for an intrinsic, > and update spots that were open-coding this logic to use the helpers > instead. > > Signed-off-by: Rob Clark > --- > src/compiler/nir/nir.h

[Mesa-dev] [Bug 105817] scons build broken by glSpecializeShaderARB

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105817 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH v3] mesa: readpixels add support for GL_HALF_FLOAT

2018-03-30 Thread Eric Anholt
Lin Johnson writes: > Ext_color_buffer_half_float is using type GL_HALF_FLOAT > and data_type GL_FLOAT. This fix Android CTS test > android.view.cts.PixelCopyTest > v2: remove commtens of Ext_color_buffer_half_float. > As Ext_color_buffer__float can use type GL_HALF_FLOAT

Re: [Mesa-dev] [PATCH 2/6] nir/spirv: fix MSVC warning in vtn_align_u32()

2018-03-30 Thread Neil Roberts
Patches 2-6 are: Reviewed-by: Neil Roberts Thanks a lot for fixing this. Regards, - Neil Brian Paul writes: > Fixes warning that "negation of an unsigned value results in an > unsigned value". > --- > src/compiler/spirv/vtn_private.h | 2 +- > 1 file

Re: [Mesa-dev] [PATCH] nir: add support for 4 constant offsets in tg4

2018-03-30 Thread Karol Herbst
On Fri, Mar 30, 2018 at 9:35 PM, Eric Anholt wrote: > Karol Herbst writes: > >> Nvidia hardware can do that natively so there is no need to lower that to >> four >> TG4s instructions. >> >> Signed-off-by: Karol Herbst >> --- >>

Re: [Mesa-dev] [PATCH] nir: add support for 4 constant offsets in tg4

2018-03-30 Thread Eric Anholt
Karol Herbst writes: > Nvidia hardware can do that natively so there is no need to lower that to four > TG4s instructions. > > Signed-off-by: Karol Herbst > --- > src/compiler/glsl/glsl_to_nir.cpp | 25 ++--- > src/compiler/nir/nir.h

Re: [Mesa-dev] [PATCH] glapi: define GL_API to be KEYWORD1 in glapi_dispatch.c (v2)

2018-03-30 Thread Mathias Fröhlich
Hi Brian, Thanks! Reviewed-by: Mathias Fröhlich best Mathias On Friday, 30 March 2018 20:52:58 CEST Brian Paul wrote: > This fixes a Windows build warning where the prototypes for the ES > function in the header file don't match the prototypes in this file >

[Mesa-dev] [PATCH] glapi: define GL_API to be KEYWORD1 in glapi_dispatch.c (v2)

2018-03-30 Thread Brian Paul
This fixes a Windows build warning where the prototypes for the ES function in the header file don't match the prototypes in this file because the GL_API and GLAPI macros are defined differently. v2: defined GL_API to KEYWORD1 instead of GLAPI, per Mathias. --- src/mapi/glapi/glapi_dispatch.c |

Re: [Mesa-dev] [PATCH] glapi: define GL_API to be GLAPI in glapi_dispatch.c

2018-03-30 Thread Brian Paul
On 03/30/2018 09:39 AM, Mathias Fröhlich wrote: On Friday, 30 March 2018 16:42:43 CEST Brian Paul wrote: This fixes a Windows build warning where the prototypes for the ES function in the header file don't match the prototypes in this file because the GL_API and GLAPI macros are defined

Re: [Mesa-dev] [PATCH] RFC: Externd IMG_context_priority with NV_context_priority_realtime

2018-03-30 Thread Kenneth Graunke
On Friday, March 30, 2018 7:40:13 AM PDT Chris Wilson wrote: > NV_context_priority_realtime > https://www.khronos.org/registry/EGL/extensions/NV/EGL_NV_context_priority_realtime.txt > > "This extension allows an EGLContext to be created with one extra > priority level in addition to three

Re: [Mesa-dev] [PATCH 1/1] gallivm: Fix build after llvm r328839

2018-03-30 Thread Jan Vesely
On Fri, 2018-03-30 at 18:41 +0200, Dieter Nützel wrote: > Hello Jan, > > can you have a look on this one (instead) and commit? > https://lists.freedesktop.org/archives/mesa-dev/2018-March/190535.html > https://patchwork.freedesktop.org/series/40916/ You should probably ask respective maintainers

[Mesa-dev] [PATCH 14/14] i965/blorp: Delete redundant code

2018-03-30 Thread Nanley Chery
--- src/mesa/drivers/dri/i965/brw_blorp.c | 53 +++ 1 file changed, 10 insertions(+), 43 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 244067bfac6..2ec6f841502 100644 ---

[Mesa-dev] [PATCH 08/14] i965: Add and use a getter for depth miptree clear values

2018-03-30 Thread Nanley Chery
Balance the miptree API by having a getter for depth clear values. --- src/mesa/drivers/dri/i965/brw_misc_state.c| 15 --- src/mesa/drivers/dri/i965/gen6_depth_state.c | 4 ++-- src/mesa/drivers/dri/i965/gen7_misc_state.c | 3 +-- src/mesa/drivers/dri/i965/gen8_depth_state.c

[Mesa-dev] [PATCH 12/14] i965/blorp: Also skip the fast clear if the clear color differs

2018-03-30 Thread Nanley Chery
If the aux state is CLEAR and clear color value has changed, only the surface state must be updated. The bit-pattern in the aux buffer is exactly the same. --- src/mesa/drivers/dri/i965/brw_blorp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 07/14] i965/meta_util: Re-enable sRGB-encoded fast-clears on CNL

2018-03-30 Thread Nanley Chery
The paths which sample with the clear color are now using a getter which performs the sRGB decode needed to enable this fast clear. This path can be exercised by fast-clearing a texture, then performing an operation which requires sRGB decoding. Test coverage for this feature is provided with the

[Mesa-dev] [PATCH 04/14] util/srgb: Add a float sRGB -> linear helper

2018-03-30 Thread Nanley Chery
From: Jason Ekstrand Reviewed-by: Nanley Chery --- src/util/format_srgb.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/util/format_srgb.h b/src/util/format_srgb.h index 34b50afe3d1..596af56f4cd 100644 ---

[Mesa-dev] [Bug 105775] SI reaches the maximum IB size in dwords and fail to submit

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 --- Comment #22 from Amarildo --- Thanks, Samuel. Looking forward to the fix. If there's anything I can do to speed testing, let me know. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [PATCH 10/14] i965/brw_clear: Don't resolve to change the depth clear value

2018-03-30 Thread Nanley Chery
Choose to compress the new depth value, instead of doing both a resolve and fast-clear. This should reduce bandwidth consumption. --- src/mesa/drivers/dri/i965/brw_clear.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git

[Mesa-dev] [PATCH 01/14] i965: Use the brw_context for the clear color and value setters

2018-03-30 Thread Nanley Chery
Do what all the other functions in the miptree API do. --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- src/mesa/drivers/dri/i965/brw_clear.c | 2 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 8 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 06/14] i965/miptree: Extend the sRGB-blending WA to future platforms

2018-03-30 Thread Nanley Chery
The blending issue seems to be present on CNL as well. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index

[Mesa-dev] [PATCH 11/14] i965/brw_clear: Delete redundant code

2018-03-30 Thread Nanley Chery
Remove the last external user of intel_miptree::fast_color_clear in favor of the setter function. --- src/mesa/drivers/dri/i965/brw_clear.c | 47 +++ 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c

[Mesa-dev] [PATCH 09/14] i965: Allow failure when setting the depth clear value

2018-03-30 Thread Nanley Chery
We'd like for the caller to use the miptree clear color helper functions. Unfortunately, to fast-clear depth with good performance, you have to know if the current clear color differs from the pending one. Adjust the setter to reject a clear color if doing so would hurt performance by introducing

[Mesa-dev] [PATCH 03/14] i965: Make the miptree clear color setter take a gl_color_union

2018-03-30 Thread Nanley Chery
We want to hide the internal details of how the miptree's clear color is calculated. --- src/mesa/drivers/dri/i965/brw_blorp.c | 5 + src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2 +- 3 files changed, 7 insertions(+), 6

[Mesa-dev] [PATCH 02/14] i965/miptree: Move the clear color and value setter implementations

2018-03-30 Thread Nanley Chery
These will get more complex in later commits. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 26 ++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 25 - 2 files changed, 30 insertions(+), 21 deletions(-) diff --git

[Mesa-dev] [PATCH 05/14] i965/miptree: Add and use a getter for the clear color

2018-03-30 Thread Nanley Chery
Use a getter which allows CNL to sample from sRGB textures correctly. --- src/mesa/drivers/dri/i965/brw_blorp.c| 4 +++- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 4 +++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 25

[Mesa-dev] [PATCH 00/14] Enable sRGB-encoded fast-clears on CannonLake

2018-03-30 Thread Nanley Chery
Starting with CannonLake, the sampler no longer decodes the surface state clear color when using an sRGB-formatted texture. This change requires that our driver perform this decode in software instead. We accounted for this change initially by disabling fast-clears when sRGB encode was enabled.

[Mesa-dev] [PATCH 13/14] i965/miptree: Allow failure when setting the clear color

2018-03-30 Thread Nanley Chery
To balance of the miptree clear color API, make this function behave like the depth clear value setter. --- src/mesa/drivers/dri/i965/brw_blorp.c | 7 +++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 54 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6

[Mesa-dev] [Bug 105817] scons build broken by glSpecializeShaderARB

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105817 --- Comment #2 from Alejandro Piñeiro (freenode IRC: apinheiro) --- Brian Paul has just sent a series, with Neil's patch, plus some extra to get it working on MSVC:

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

2018-03-30 Thread Brian Paul
OK, I just posted a series of patches which seems to fix everything on Windows/MSVC. Neil, I added fixes for the osmesa and libgl-gdi targets to your patch. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 4/6] nir/spirv: fix MSVC syntax error in vtn_handle_texture()

2018-03-30 Thread Brian Paul
--- src/compiler/spirv/spirv_to_nir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 2550ef0..72ab426 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@

[Mesa-dev] [PATCH 5/6] nir/spirv: s/uint32_t/SpvOp/ in various functions

2018-03-30 Thread Brian Paul
The MSVC compiler warns when the function parameter types don't exactly match with respect to enum vs. uint32_t. Use SpvOp everywhere. Alternately, uint32_t could be used everywhere. There doesn't seem to be an advantage to one over the other. --- src/compiler/spirv/vtn_amd.c | 4 ++--

[Mesa-dev] [PATCH 1/6] spirv: Fix building with SCons

2018-03-30 Thread Brian Paul
From: Neil Roberts The SCons build broke with commit ba975140d3c9 because a SPIR-V function is called from Mesa main. This adds a convenience library for SPIR-V and adds it to everything that was including nir. It also adds both nir and spirv to drivers/x11/SConscript. Also

[Mesa-dev] [PATCH 6/6] spirv: s/uint/unsigned/ to fix MSVC build

2018-03-30 Thread Brian Paul
--- src/compiler/spirv/vtn_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 3d5de37..e7d2f9e 100644 --- a/src/compiler/spirv/vtn_cfg.c +++ b/src/compiler/spirv/vtn_cfg.c @@ -513,7 +513,7 @@

[Mesa-dev] [PATCH 2/6] nir/spirv: fix MSVC warning in vtn_align_u32()

2018-03-30 Thread Brian Paul
Fixes warning that "negation of an unsigned value results in an unsigned value". --- src/compiler/spirv/vtn_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_private.h b/src/compiler/spirv/vtn_private.h index d8a00f9..269de92 100644 ---

[Mesa-dev] [PATCH 3/6] nir/spirv: move NORETURN annotation on _vtn_fail() prototype

2018-03-30 Thread Brian Paul
This needs to before the function, not after, to compile with MSVC. This works with gcc too. --- src/compiler/spirv/vtn_private.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/vtn_private.h b/src/compiler/spirv/vtn_private.h index 269de92..982b426

Re: [Mesa-dev] [PATCH 1/5] radeonsi: remove fast color clear for single-sample buffers

2018-03-30 Thread Marek Olšák
Yes. Marek On Fri, Mar 30, 2018, 4:47 AM Dieter Nützel wrote: > Hello Marek, > > 2-3 landed. > Is #1 dead after my findings? ;-) > > Dieter > > Am 11.03.2018 19:11, schrieb Marek Olšák: > > From: Marek Olšák > > > > This should improve the score for

Re: [Mesa-dev] [PATCH 1/1] gallivm: Fix build after llvm r328839

2018-03-30 Thread Dieter Nützel
Hello Jan, can you have a look on this one (instead) and commit? https://lists.freedesktop.org/archives/mesa-dev/2018-March/190535.html https://patchwork.freedesktop.org/series/40916/ It has r-b from Samuel Pitoiset and t-b from me. Thanks, Dieter Am 30.03.2018 18:30, schrieb Jan Vesely:

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

2018-03-30 Thread Ilia Mirkin
On Fri, Mar 30, 2018 at 12:40 PM, Brian Paul wrote: > OK, I'll have some patches soon but I'm stuck on one issue. > > Around spriv_to_nir.c:2090 we have > > if (operands & SpvImageOperandsConstOffsetsMask) { > gather_offsets = vtn_ssa_value(b, w[idx++]); >

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

2018-03-30 Thread Brian Paul
On 03/30/2018 10:40 AM, Brian Paul wrote: OK, I'll have some patches soon but I'm stuck on one issue. Around spriv_to_nir.c:2090 we have   if (operands & SpvImageOperandsConstOffsetsMask) { gather_offsets = vtn_ssa_value(b, w[idx++]); (*p++) = (nir_tex_src){};   }

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

2018-03-30 Thread Brian Paul
OK, I'll have some patches soon but I'm stuck on one issue. Around spriv_to_nir.c:2090 we have if (operands & SpvImageOperandsConstOffsetsMask) { gather_offsets = vtn_ssa_value(b, w[idx++]); (*p++) = (nir_tex_src){}; } The (nir_tex_src){} expression is not valid

[Mesa-dev] [PATCH 1/1] gallivm: Fix build after llvm r328839

2018-03-30 Thread Jan Vesely
LLVM r328839 moved few function declrations to a new Utils.h header. Fixes: gallivm/lp_bld_init.c:145:7: error: implicit declaration of function ‘LLVMAddPromoteMemoryToRegisterPass’; did you mean ‘LLVMAddDemoteMemoryToRegisterPass’? Signed-off-by: Jan Vesely ---

Re: [Mesa-dev] [PATCH] glapi: define GL_API to be GLAPI in glapi_dispatch.c

2018-03-30 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 30, 2018 7:42 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] glapi: define GL_API to be GLAPI in

Re: [Mesa-dev] [PATCH] x11: Only report supported DRI3/Present versions

2018-03-30 Thread Daniel Stone
On 23 March 2018 at 13:03, Emil Velikov wrote: > On 22 March 2018 at 15:27, Daniel Stone wrote: >> The version passed to QueryVersion requests is the version that the >> client supports. We were just passing in whatever version of XCB was >>

[Mesa-dev] [Bug 105775] SI reaches the maximum IB size in dwords and fail to submit

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105775 Samuel Pitoiset changed: What|Removed |Added Summary|F1 2017 crashes on GCN 1.0 |SI reaches

Re: [Mesa-dev] [PATCH] vbo: MaxVertexAttribStride is not always set

2018-03-30 Thread Jakob Bornecrantz
On 2018-03-30 16:49, Mathias Fröhlich wrote: On Friday, 30 March 2018 17:38:39 CEST Jakob Bornecrantz wrote: This assert is hit on hardware which does expose GL 4.4 or GLES 3.1. Uff - sorry! Reviewed-by: Mathias Fröhlich Thanks, tho that should be "which does NOT

[Mesa-dev] [Bug 103999] 4x MSAA with RG32F shows garbage on triangle edges

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103999 --- Comment #9 from Samuel Pitoiset --- Cool, could try again mesa master to confirm the issue is really fixed? Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are the

Re: [Mesa-dev] [PATCH] mesa: fix MSVC bitshift overflow warnings

2018-03-30 Thread Roland Scheidegger
Am 30.03.2018 um 17:09 schrieb Brian Paul: > In the BITFIELD_MASK() macro, if b==32 the expression evaluates to > ~0u, but the compiler still sees the expression (1 << 32) in the > unused part and issues a warning about integer bitshift overflow. > > Fix that by using (b) % 32 to ensure the max

Re: [Mesa-dev] [PATCH] vbo: MaxVertexAttribStride is not always set

2018-03-30 Thread Mathias Fröhlich
On Friday, 30 March 2018 17:38:39 CEST Jakob Bornecrantz wrote: > This assert is hit on hardware which does expose GL 4.4 or GLES 3.1. Uff - sorry! Reviewed-by: Mathias Fröhlich Mathias > > Signed-off-by: Jakob Bornecrantz > --- >

[Mesa-dev] [PATCH] vulkan/wsi/wayland: fix leaks

2018-03-30 Thread James Legg
Fixes: bfa22266cd vulkan/wsi/wayland: Add support for zwp_dmabuf CC: Daniel Stone CC: Jason Ekstrand --- src/vulkan/wsi/wsi_common_wayland.c | 4 1 file changed, 4 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_wayland.c

Re: [Mesa-dev] Status of radeonsi NIR

2018-03-30 Thread Benedikt Schemmer
Hi all, I did some more testing with NIR and wanted to share the results. https://github.com/bendat78/mymesa/tree/mymesa2/testresults Overall it seems nir could be better than tgsi, but there are some shaders with significant regressions and I think that introduces framerate drops that are quite

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

2018-03-30 Thread Mathias Fröhlich
Hi Brian, > Can you just rename 'space' to 'prim' and rm the prim = space assignment > below? > > Also, could you put a comment on this function to explain the draw_count > and space/prim parameters, at least? I'll try my best! > Other than that, the series looks good. > > Reviewed-by: Brian

Re: [Mesa-dev] [PATCH] glapi: define GL_API to be GLAPI in glapi_dispatch.c

2018-03-30 Thread Mathias Fröhlich
On Friday, 30 March 2018 16:42:43 CEST Brian Paul wrote: > This fixes a Windows build warning where the prototypes for the ES > function in the header file don't match the prototypes in this file > because the GL_API and GLAPI macros are defined differently. > --- >

[Mesa-dev] [PATCH] vbo: MaxVertexAttribStride is not always set

2018-03-30 Thread Jakob Bornecrantz
This assert is hit on hardware which does expose GL 4.4 or GLES 3.1. Signed-off-by: Jakob Bornecrantz --- src/mesa/vbo/vbo_save_api.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index

Re: [Mesa-dev] [PATCH] spirv: Fix building with SCons

2018-03-30 Thread Brian Paul
Thanks, Neil. This fixes the SCons build on Linux, but on Windows there's a whole bunch of other issues: c:\users\brian\projects\mesa\src\compiler\spirv\vtn_private.h(232): error C2085: 'vtn_instruction_handler': not in formal parameter list

Re: [Mesa-dev] [PATCH] mesa: fix MSVC bitshift overflow warnings

2018-03-30 Thread Mathias Fröhlich
On Friday, 30 March 2018 17:09:40 CEST Brian Paul wrote: > In the BITFIELD_MASK() macro, if b==32 the expression evaluates to > ~0u, but the compiler still sees the expression (1 << 32) in the > unused part and issues a warning about integer bitshift overflow. > > Fix that by using (b) % 32 to

[Mesa-dev] [Bug 105817] scons build broken by glSpecializeShaderARB

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105817 --- Comment #1 from Neil Roberts --- I posted a patch for this. Any comments from someone experienced with SCons would be much appreciated. https://patchwork.freedesktop.org/patch/214058/ -- You are receiving this mail

[Mesa-dev] [PATCH] spirv: Fix building with SCons

2018-03-30 Thread Neil Roberts
The SCons build broke with commit ba975140d3c9 because a SPIR-V function is called from Mesa main. This adds a convenience library for SPIR-V and adds it to everything that was including nir. It also adds both nir and spirv to drivers/x11/SConscript. --- It would be great if someone who depends

[Mesa-dev] [PATCH] mesa: fix MSVC bitshift overflow warnings

2018-03-30 Thread Brian Paul
In the BITFIELD_MASK() macro, if b==32 the expression evaluates to ~0u, but the compiler still sees the expression (1 << 32) in the unused part and issues a warning about integer bitshift overflow. Fix that by using (b) % 32 to ensure the max shift is 31 bits. This issue has been present for a

Re: [Mesa-dev] [PATCH 00/11 v2] TGSI: improved live range tracking, also including arrays

2018-03-30 Thread Dieter Nützel
Am 30.03.2018 17:01, schrieb Ilia Mirkin: On Fri, Mar 30, 2018 at 10:33 AM, Dieter Nützel wrote: For the series: Tested-by: Dieter Nützel with glmark2, UH, UV, KDE Plasma5 (my desktop) R600_DEBUG=sisched,nir but on radeonsi, Polaris 20 (RX580) not

Re: [Mesa-dev] [PATCH 00/11 v2] TGSI: improved live range tracking, also including arrays

2018-03-30 Thread Ilia Mirkin
On Fri, Mar 30, 2018 at 10:33 AM, Dieter Nützel wrote: > For the series: > > Tested-by: Dieter Nützel > > with glmark2, UH, UV, KDE Plasma5 (my desktop) > R600_DEBUG=sisched,nir > but on radeonsi, Polaris 20 (RX580) not r600 ;-) This series is

Re: [Mesa-dev] [PATCH] st/mesa: add missing GLSL_TYPE_[U]INT8 cases in st_glsl_type_dword_size()

2018-03-30 Thread Mathias Fröhlich
Hi Brian, looks plausible to me. Reviewed-by: Mathias Fröhlich best Mathias On Thursday, 29 March 2018 03:40:29 CEST Brian Paul wrote: > Silences a compiler warning about unhandled enum switch cases. > --- > src/mesa/state_tracker/st_glsl_types.cpp | 3 +++ > 1 file

[Mesa-dev] [PATCH] glapi: define GL_API to be GLAPI in glapi_dispatch.c

2018-03-30 Thread Brian Paul
This fixes a Windows build warning where the prototypes for the ES function in the header file don't match the prototypes in this file because the GL_API and GLAPI macros are defined differently. --- src/mapi/glapi/glapi_dispatch.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7

2018-03-30 Thread Daniel Stone
Hi Andreas, On 30 March 2018 at 15:18, Andreas Müller wrote: > What happened: I build all images cross with Openembedded/Yocto. To > prepare next release there I updated my builds and that moved mesa > 17.1.7 -> 17.3.7. Since then all applications using GL/GLES (e.g >

[Mesa-dev] [PATCH] RFC: Externd IMG_context_priority with NV_context_priority_realtime

2018-03-30 Thread Chris Wilson
NV_context_priority_realtime https://www.khronos.org/registry/EGL/extensions/NV/EGL_NV_context_priority_realtime.txt "This extension allows an EGLContext to be created with one extra priority level in addition to three priority levels that are part of EGL_IMG_context_priority

[Mesa-dev] [PATCH] st/mesa: add missing GLSL_TYPE_[U]INT8 cases in st_glsl_type_dword_size()

2018-03-30 Thread Brian Paul
Silences a compiler warning about unhandled enum switch cases. --- src/mesa/state_tracker/st_glsl_types.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_types.cpp b/src/mesa/state_tracker/st_glsl_types.cpp index baba2d4..42d4e9c 100644 ---

Re: [Mesa-dev] [PATCH 00/11 v2] TGSI: improved live range tracking, also including arrays

2018-03-30 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel with glmark2, UH, UV, KDE Plasma5 (my desktop) R600_DEBUG=sisched,nir but on radeonsi, Polaris 20 (RX580) not r600 ;-) GREAT work Gert! Dieter Am 26.03.2018 11:27, schrieb Gert Wollny: Dear all, this is the merged version of

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7

2018-03-30 Thread Andreas Müller
On Fri, Mar 30, 2018 at 4:18 PM, Andreas Müller wrote: > Hi, > > hope here is the right place for this - my first post. > > What happened: I build all images cross with Openembedded/Yocto. To > prepare next release there I updated my builds and that moved mesa > 17.1.7 ->

[Mesa-dev] [PATCH kmscube 1/2] Rework default modifier handling

2018-03-30 Thread Emil Velikov
From: Emil Velikov Currently the default modifier is MOD_INVALID. At a later stage, if the modifier is the same (the user may have explicit selected MOD_INVALID), we'll fallback to MOD_LINEAR. Simplify things to a) use MOD_LINEAR by default b) use the user modifier -

[Mesa-dev] [PATCH kmscube 2/2] Use weak functions to handle lack of gbm modifiers

2018-03-30 Thread Emil Velikov
From: Emil Velikov Add weak function declaration and check if they're valid prior to calling the functions. This allows us to remove conditional compilation, yet allowing the modifiers codepath to work if API is available. Cc: Christian Gmeiner

[Mesa-dev] VC4 not working for me with mesa 17.3.7

2018-03-30 Thread Andreas Müller
Hi, hope here is the right place for this - my first post. What happened: I build all images cross with Openembedded/Yocto. To prepare next release there I updated my builds and that moved mesa 17.1.7 -> 17.3.7. Since then all applications using GL/GLES (e.g glmark2-es - tried others - same)

[Mesa-dev] Question about NIR changes since mesa 17.3

2018-03-30 Thread Qiang Yu
Hi guys, I'm rebasing the mesa-lima code from 17.3 to 18.0 and found the NIR changes in 18.0 will always do nir_lower_io_to_scalar_early() for the output of vertex shader and input of fragment shader. My first question is: Is it for the link time optimization that we can drop un-used channel in a

[Mesa-dev] [Bug 103999] 4x MSAA with RG32F shows garbage on triangle edges

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103999 --- Comment #8 from mais...@archlinux.us --- Here's a renderdoc 1.0 capture on RX470 for reference: https://drive.google.com/file/d/1e9zIRVhZxtdA5DodASi3FK75fuRBuqxO/view?usp=sharing -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 103999] 4x MSAA with RG32F shows garbage on triangle edges

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103999 --- Comment #7 from mais...@archlinux.us --- This seems to work fine now on 17.3.7. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH] st/mesa: don't draw if the bound element array buffer is not allocated

2018-03-30 Thread Dieter Nützel
Tested-by: Dieter Nützel Dieter Am 21.03.2018 18:41, schrieb Marek Olšák: From: Marek Olšák --- src/mesa/state_tracker/st_draw.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/state_tracker/st_draw.c

Re: [Mesa-dev] [PATCH 0/5] KHR_blend_equation_advanced for RadeonSI

2018-03-30 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel R600_DEBUG=nofmask show nice effects together with Anti-aliasing at least x8 on UH and UV Greetings, Dieter Am 23.03.2018 20:35, schrieb Marek Olšák: Hi, This is the second and fianl version, and it adds MSAA support and

[Mesa-dev] [Bug 103852] Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee)

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103852 --- Comment #7 from Sven Arvidsson --- Absolutely file new bugs for each issue. Much easier to close duplicate bugs than tracking more than one problem in a report (should it turn out be the same problem in the end). The freeze

[Mesa-dev] [Bug 105817] scons build broken by glSpecializeShaderARB

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105817 Bug ID: 105817 Summary: scons build broken by glSpecializeShaderARB Product: Mesa Version: git Hardware: Other OS: All Status: ASSIGNED Keywords:

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-30 Thread Dieter Nützel
Samuel, go for it. Tested-by: Dieter Nützel Thanks Mike! Dieter Am 30.03.2018 11:32, schrieb Samuel Pitoiset: With the Fixes tag removed, this is: Reviewed-by: Samuel Pitoiset On 03/30/2018 01:56 AM, Mike Lothian wrote: Include

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-30 Thread Samuel Pitoiset
With the Fixes tag removed, this is: Reviewed-by: Samuel Pitoiset On 03/30/2018 01:56 AM, Mike Lothian wrote: Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h Signed-of-by: Mike Lothian

Re: [Mesa-dev] [radv] compilation error with 'latest' LLVM (#4e45b963bcd)

2018-03-30 Thread Mike Lothian
I've submitted a patch for this, it was a change in the llvm-c includes On Fri, 30 Mar 2018 at 08:43 Dieter Nützel wrote: > make[4]: Verzeichnis „/opt/mesa/src/amd/vulkan“ wird betreten >CC radv_nir_to_llvm.lo > radv_nir_to_llvm.c: In function

Re: [Mesa-dev] [PATCH 1/5] radeonsi: remove fast color clear for single-sample buffers

2018-03-30 Thread Dieter Nützel
Hello Marek, 2-3 landed. Is #1 dead after my findings? ;-) Dieter Am 11.03.2018 19:11, schrieb Marek Olšák: From: Marek Olšák This should improve the score for the GpuTest Triangle benchmark. Vulkan doesn't use this either. ---

[Mesa-dev] [Bug 103852] Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee)

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103852 --- Comment #6 from Ben Clapp --- Bugs still present in 18.0.0. In addition, there's now a new bug when using the radeonsi driver, where the game will sometimes freeze altogether (not a complete GPU hang, you can kill the

[Mesa-dev] [PATCH v2] radeonsi/nir: gather buffers declared more accurately and use const fast path

2018-03-30 Thread Timothy Arceri
For now we skip SI && HAVE_LLVM < 0x0600 for simplicity. We also skip setting the more accurate masks for some builtin uniforms for now as it causes some piglit regressions. --- src/gallium/drivers/radeonsi/si_shader.c | 7 +++ src/gallium/drivers/radeonsi/si_shader_nir.c | 90

[Mesa-dev] [radv] compilation error with 'latest' LLVM (#4e45b963bcd)

2018-03-30 Thread Dieter Nützel
make[4]: Verzeichnis „/opt/mesa/src/amd/vulkan“ wird betreten CC radv_nir_to_llvm.lo radv_nir_to_llvm.c: In function ‘ac_llvm_finalize_module’: radv_nir_to_llvm.c:2874:2: error: implicit declaration of function ‘LLVMAddPromoteMemoryToRegisterPass’; did you mean

Re: [Mesa-dev] [PATCH v4] i965: initialize SPIR-V capabilities

2018-03-30 Thread Alejandro Piñeiro
On 29/03/18 16:59, Jason Ekstrand wrote: > On March 29, 2018 02:45:36 Alejandro Piñeiro > wrote: > > Needed for ARB_gl_spirv. Those are not the same that the Intel vulkan > driver. From the ARB_spirv_extensions spec: > > "3. If a new GL extension is added that includes

[Mesa-dev] [Bug 105613] Compute shader locks up within nested "for" loop

2018-03-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105613 soredake changed: What|Removed |Added CC||fds...@krutt.org -- You