Re: [Mesa-dev] [PATCH 9.5/17] squash! i965/miptree: Unify aux buffer allocation

On Wed, May 09, 2018 at 10:47:24AM -0700, Nanley Chery wrote: > v2: Inline the switch statement (Jason) > > Reviewed-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 90 --- > 1 file changed, 38 insertions(+), 52 deletions(-) > >

Re: [Mesa-dev] [PATCH 1/3] intel/compiler: make brw_reg_type_from_bit_size usable from other places

El 15/05/18 a las 13:05, Iago Toral Quiroga escribió: > This was private to brw_fs_nir.cpp but we are going to need it soon in > brw_fs.cpp, so move it there and make it available to other files as we > do for other utility functions. > --- > src/intel/compiler/brw_fs.cpp | 59 >

[Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

From: Michel Dänzer Prevents spuriously bumping the upper 32 bits of the SBC, which results in hangs with the modesetting driver from xserver 1.20. Bugzilla: https://bugs.freedesktop.org/106351 Tested-by: Mike Lothian Signed-off-by: Michel Dänzer

[Mesa-dev] [Bug 106351] Freezes with plasmashell and steam client

https://bugs.freedesktop.org/show_bug.cgi?id=106351 Michel Dänzer changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

Hi, Shouldn't this be fixed on the xserver or the ddx side, rather than in Mesa ? Yours, Axel Davy On 16/05/2018 11:10, Michel Dänzer wrote: From: Michel Dänzer Prevents spuriously bumping the upper 32 bits of the SBC, which results in hangs with the modesetting

[Mesa-dev] [Bug 106536] glXWaitVideoSyncSGI blocks forever

https://bugs.freedesktop.org/show_bug.cgi?id=106536 --- Comment #1 from Michel Dänzer --- Please attach a backtrace of the app when it hangs, and the corresponding Xorg log file. -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 106536] glXWaitVideoSyncSGI blocks forever

https://bugs.freedesktop.org/show_bug.cgi?id=106536 Bug ID: 106536 Summary: glXWaitVideoSyncSGI blocks forever Product: Mesa Version: 18.0 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 106351] Freezes with plasmashell and steam client

https://bugs.freedesktop.org/show_bug.cgi?id=106351 Markus Rathgeb changed: What|Removed |Added CC|

[Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

The GLSL ES 1.0 spec made these features optional. With OES_standard_derivatives they are guaranteed to be available but currently the extension must be enabled to use them. Instead this changes the code to check if the driver supports the extension and if so always enables them. This fixes

[Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

In GLES shader versions must match but there is nothing in the ARB_ES*_compatibility specs that say they must match. This fixes some compilation errors in Google Earth VR. --- src/compiler/glsl/linker.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [Bug 106404] Hang in draw function caused by interaction of glutInitWindowPosition, glutFullScreen , glDrawBuffer(GL_FRONT)

https://bugs.freedesktop.org/show_bug.cgi?id=106404 Michel Dänzer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

Tomeu Vizoso writes: > Virgl could save a lot of work converting buffers in the host side > between formats if Mesa supported a bunch of other formats when reading > pixels. > > This commit adds cases to handle specific formats so that the values > reported by the two

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

On 2018-05-16 11:14 AM, Axel Davy wrote: > Hi, > > Shouldn't this be fixed on the xserver or the ddx side, rather than in > Mesa ? No, it's a Mesa bug, the X server is doing what it's asked. (This wasn't noticed earlier because Xorg drivers using the old DRM_IOCTL_WAIT_VBLANK ioctl effectively

[Mesa-dev] [PATCH v2 1/2] cast the "GLenum16" to "GLint" to avoid compile warning on android

force cast the I to GLint to avoid the compile warning when type is GLenum16, in vendor/intel/external/mesa3d-intel/src/mesa/main/get.c:3005:19: warning: comparison of constant -32768 with expression of type 'GLenum16' (aka 'unsigned short') is always false

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

On 2018-05-16 01:39 PM, Mike Lothian wrote: > Can this be added to stable too? Right, I meant add that but forgot, thanks for the reminder. Consider it done. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and

Re: [Mesa-dev] [PATCH v2] st/mesa: only define GLSL 1.4 for compat if driver supports it

On Wed, May 16, 2018 at 5:02 PM, Christian Gmeiner wrote: > Currently GLSL 1.4 is defined for all gallium drivers even only > GLSL 1.2 is supported as seen on etnaviv. > > v1 -> v2: > - use _min(..) as suggested by Lucas Stach and Michel Dänzer > > Fixes 4560aad780b

Re: [Mesa-dev] [PATCH 6/9] intel/blorp: Make blorp_ccs_ambiguate just an internal helper

On Wed, May 16, 2018 at 4:00 AM, Iago Toral wrote: > On Tue, 2018-05-15 at 15:28 -0700, Jason Ekstrand wrote: > > Now that anv uses blorp_ccs_op for everything, we no longer need to > > expose the ccs_ambiguate function directly. It's much better tucked > > away as an

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

On Wed, May 16, 2018 at 09:02:51AM +0300, Pohjolainen, Topi wrote: > On Tue, May 08, 2018 at 02:05:37PM -0700, Nanley Chery wrote: > > On Tue, May 08, 2018 at 08:31:39AM +0300, Pohjolainen, Topi wrote: > > > On Mon, May 07, 2018 at 10:11:39AM -0700, Nanley Chery wrote: > > > > On Mon, May 07, 2018

Re: [Mesa-dev] [PATCH] android: enable VK_ANDROID_native_buffer

On May 15, 2018 22:59:20 Tapani Pälli wrote: On 05/16/2018 08:46 AM, Jason Ekstrand wrote: On Tue, May 15, 2018 at 10:42 PM, Tapani Pälli > wrote: Patch changes entrypoints generator to not skip this extension

[Mesa-dev] [PATCH 2/2] radv: do not emit unnecessary ES output stores

GFX9: Totals from affected shaders: SGPRS: 472 -> 464 (-1.69 %) VGPRS: 576 -> 584 (1.39 %) Code Size: 45432 -> 44324 (-2.44 %) bytes Max Waves: 40 -> 40 (0.00 %) VI: SGPRS: 720 -> 720 (0.00 %) VGPRS: 728 -> 728 (0.00 %) Code Size: 45348 -> 43992 (-2.99 %) bytes Max Waves: 120 -> 120 (0.00 %)

[Mesa-dev] [PATCH 1/2] radv: do not emit unnecessary GS output stores

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 95bc860e66..bfae2a489e 100644 ---

Re: [Mesa-dev] [PATCH v2 1/2] cast the "GLenum16" to "GLint" to avoid compile warning on android

On 05/16/2018 01:02 AM, jenny.q.cao wrote: force cast the I to GLint to avoid the compile warning when type is GLenum16, in vendor/intel/external/mesa3d-intel/src/mesa/main/get.c:3005:19: warning: comparison of constant -32768 with expression of type 'GLenum16' (aka 'unsigned short') is always

Re: [Mesa-dev] [PATCH 2/2] radv: do not emit unnecessary ES output stores

Thanks! Reviewed-by: Bas Nieuwenhuizen for the series. On Wed, May 16, 2018 at 5:43 PM, Samuel Pitoiset wrote: > GFX9: > Totals from affected shaders: > SGPRS: 472 -> 464 (-1.69 %) > VGPRS: 576 -> 584 (1.39 %) > Code Size: 45432 -> 44324

[Mesa-dev] [PATCH 4/5] swr/rast: Whitespace and tab-to-spaces changes

--- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 1 - .../swr/rasterizer/jitter/builder_gfx_mem.cpp | 27 -- .../swr/rasterizer/jitter/builder_gfx_mem.h| 2 +- .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 1 -

[Mesa-dev] [PATCH 5/5] swr/rast: Added FEClipRectangles event

and also added some comments --- src/gallium/drivers/swr/rasterizer/core/rdtsc_core.cpp | 1 + src/gallium/drivers/swr/rasterizer/core/rdtsc_core.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/core/rdtsc_core.cpp

[Mesa-dev] [PATCH 3/5] swr/rast: fix VCVTPD2PS generation for AVX512

--- .../swr/rasterizer/jitter/functionpasses/lower_x86.cpp | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/functionpasses/lower_x86.cpp b/src/gallium/drivers/swr/rasterizer/jitter/functionpasses/lower_x86.cpp

[Mesa-dev] [PATCH] mesa: pipe attachment incomplete debug message to debug output

--- src/mesa/main/fbobject.c | 44 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index a63e8b8de52..82f7d522af9 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@

[Mesa-dev] [PATCH 2/5] swr/rast: Rectlist support for GS

Add rectlist as an option for GS. Needed to support some driver optimizations. --- src/gallium/drivers/swr/rasterizer/core/clip.cpp | 24 src/gallium/drivers/swr/rasterizer/core/clip.h | 6 ++ .../drivers/swr/rasterizer/core/frontend.cpp | 2 +

[Mesa-dev] [PATCH 1/5] swr/rast: Remove unneeded virtual from methods

--- src/gallium/drivers/swr/rasterizer/jitter/JitManager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.h b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.h index 54a25d8..152776a 100644 ---

Re: [Mesa-dev] [PATCH] st/mesa: only define GLSL 1.4 for compat if driver supports it

Am Mittwoch, den 16.05.2018, 15:31 +0200 schrieb Christian Gmeiner: > Currently GLSL 1.4 is defined for all gallium drivers even only > GLSL 1.2 is supported as seen on etnaviv. > > Fixes 4560aad780b ("mesa: add GLSLVersionCompat constant") > > > Signed-off-by: Christian Gmeiner

[Mesa-dev] [PATCH v2] st/mesa: only define GLSL 1.4 for compat if driver supports it

Currently GLSL 1.4 is defined for all gallium drivers even only GLSL 1.2 is supported as seen on etnaviv. v1 -> v2: - use _min(..) as suggested by Lucas Stach and Michel Dänzer Fixes 4560aad780b ("mesa: add GLSLVersionCompat constant") Signed-off-by: Christian Gmeiner

Re: [Mesa-dev] [PATCH] st/mesa: only define GLSL 1.4 for compat if driver supports it

On 2018-05-16 03:31 PM, Christian Gmeiner wrote: > Currently GLSL 1.4 is defined for all gallium drivers even only > GLSL 1.2 is supported as seen on etnaviv. > > Fixes 4560aad780b ("mesa: add GLSLVersionCompat constant") > > Signed-off-by: Christian Gmeiner > --- >

[Mesa-dev] [PATCH] radv: allow to print GPU info with RADV_DEBUG=info

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c | 4 2 files changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h index 9dda9b6b0c2..b6993cee1c8 100644 ---

Re: [Mesa-dev] [PATCH v2] st/mesa: only define GLSL 1.4 for compat if driver supports it

Am Mittwoch, den 16.05.2018, 16:02 +0200 schrieb Christian Gmeiner: > Currently GLSL 1.4 is defined for all gallium drivers even only > GLSL 1.2 is supported as seen on etnaviv. > > v1 -> v2: >  - use _min(..) as suggested by Lucas Stach and Michel Dänzer > > Fixes 4560aad780b ("mesa: add

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by #extension GL_OES_standard_derivatives : enable before being used. """ Sounds like you need an application override? On Wed, May 16, 2018 at 3:04 AM, Timothy Arceri

Re: [Mesa-dev] [PATCH 7/9] i965: Use blorp_ccs_op for CCS fast-clears

On Tue, 2018-05-15 at 15:28 -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c > b/src/mesa/drivers/dri/i965/brw_blorp.c > index dab04f2..b6097f5

Re: [Mesa-dev] [PATCH 8/9] intel/blorp: Handle fast-clear directly in blorp_ccs_op

On Tue, 2018-05-15 at 15:28 -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_clear.c | 199 +++- > -- > 1 file changed, 88 insertions(+), 111 deletions(-) > > diff --git a/src/intel/blorp/blorp_clear.c > b/src/intel/blorp/blorp_clear.c > index

Re: [Mesa-dev] [PATCH 0/9] intel/blorp: Refactors, cleanups, and fixes

I skipped the first two patches in the series. I believe that there is probably someone else more suitable than me to review or verify patch 1 and I don't think we have public gen10 PRMs available yet for patch 2. I dropped a minor comment on patch 6 which you can take or leave. In any case,

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

On 16/05/18 22:09, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: On 16/05/18 21:12, Ilia Mirkin wrote: From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by

Re: [Mesa-dev] [PATCH 6/9] intel/blorp: Make blorp_ccs_ambiguate just an internal helper

On Tue, 2018-05-15 at 15:28 -0700, Jason Ekstrand wrote: > Now that anv uses blorp_ccs_op for everything, we no longer need to > expose the ccs_ambiguate function directly. It's much better tucked > away as an implementation detail. > --- > src/intel/blorp/blorp.h | 5 - >

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

On 16/05/18 22:09, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: On 16/05/18 21:12, Ilia Mirkin wrote: From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

On Wed, May 16, 2018 at 8:26 AM, Timothy Arceri wrote: > > > On 16/05/18 22:09, Ilia Mirkin wrote: >> >> On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri >> wrote: >>> >>> >>> >>> On 16/05/18 21:12, Ilia Mirkin wrote: From the spec,

Re: [Mesa-dev] [PATCH 8/9] intel/blorp: Handle fast-clear directly in blorp_ccs_op

On Wed, 2018-05-16 at 13:34 +0200, Iago Toral wrote: > On Tue, 2018-05-15 at 15:28 -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp_clear.c | 199 +++--- > > -- > > -- > > 1 file changed, 88 insertions(+), 111 deletions(-) > > > > diff --git

[Mesa-dev] [PATCH] st/mesa: only define GLSL 1.4 for compat if driver supports it

Currently GLSL 1.4 is defined for all gallium drivers even only GLSL 1.2 is supported as seen on etnaviv. Fixes 4560aad780b ("mesa: add GLSLVersionCompat constant") Signed-off-by: Christian Gmeiner --- src/mesa/state_tracker/st_extensions.c | 6 +- 1 file

[Mesa-dev] [Bug 106542] osmesa gallium state tracker: Leak of screens and buffers on exit/shared library unload

https://bugs.freedesktop.org/show_bug.cgi?id=106542 --- Comment #1 from Ricardo Barreira --- Patch has been sent here: https://lists.freedesktop.org/archives/mesa-dev/2017-December/180118.html -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 106542] osmesa gallium state tracker: Leak of screens and buffers on exit/shared library unload

https://bugs.freedesktop.org/show_bug.cgi?id=106542 Ricardo Barreira changed: What|Removed |Added Status|NEW |ASSIGNED -- You

Re: [Mesa-dev] [PATCH] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

Tested-by: Jakob Bornecrantz On Mon, May 14, 2018 at 3:14 PM, Tomeu Vizoso wrote: > Virgl could save a lot of work converting buffers in the host side > between formats if Mesa supported a bunch of other formats when reading > pixels. > > This

Re: [Mesa-dev] [PATCH] radeonsi: create .gitignore

Thank you Marek, can someone (you) commit for me, then? ;-) Dieter Am 15.05.2018 18:35, schrieb Marek Olšák: Reviewed-by: Marek Olšák Marek On Tue, May 15, 2018 at 9:55 AM, Dieter Nützel wrote: Hello Marek, sorry I have some trouble with 'git

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: > > > On 16/05/18 21:12, Ilia Mirkin wrote: >> >> From the spec, >> >> """ >> The built-in derivative functions dFdx, dFdy, and fwidth are >> optional, and >> must be enabled by >> >> #extension

[Mesa-dev] [Bug 106542] osmesa gallium state tracker: Leak of screens and buffers on exit/shared library unload

https://bugs.freedesktop.org/show_bug.cgi?id=106542 Ricardo Barreira changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |r...@google.com

Re: [Mesa-dev] [PATCH] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

Tested-By: Gert Wollny Am Montag, den 14.05.2018, 15:14 +0200 schrieb Tomeu Vizoso: > Virgl could save a lot of work converting buffers in the host side > between formats if Mesa supported a bunch of other formats when > reading > pixels. > > This commit adds cases to

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

Can this be added to stable too? On Wed, 16 May 2018 at 10:33 Michel Dänzer wrote: > On 2018-05-16 11:14 AM, Axel Davy wrote: > > Hi, > > > > Shouldn't this be fixed on the xserver or the ddx side, rather than in > > Mesa ? > No, it's a Mesa bug, the X server is doing what

[Mesa-dev] [Bug 106542] osmesa gallium state tracker: Leak of screens and buffers on exit/shared library unload

https://bugs.freedesktop.org/show_bug.cgi?id=106542 Bug ID: 106542 Summary: osmesa gallium state tracker: Leak of screens and buffers on exit/shared library unload Product: Mesa Version: git Hardware: Other

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

On 16/05/18 21:12, Ilia Mirkin wrote: From the spec, """ The built-in derivative functions dFdx, dFdy, and fwidth are optional, and must be enabled by #extension GL_OES_standard_derivatives : enable before being used. """ Sounds like you need an application override?

Re: [Mesa-dev] threading in OSMesa and gallium swr driver

On May 14, 2018, at 8:59 AM, Alexandre > wrote: Hello, Sorry for the inconvenience if this message is not appropriate for this mailing list. The following is a question for developers of the swr driver of

Re: [Mesa-dev] [PATCH 1/2] glsl: always enable OES_standard_derivatives features if supported

On 16/05/18 22:29, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:26 AM, Timothy Arceri wrote: On 16/05/18 22:09, Ilia Mirkin wrote: On Wed, May 16, 2018 at 8:04 AM, Timothy Arceri wrote: On 16/05/18 21:12, Ilia Mirkin wrote: From

Re: [Mesa-dev] [PATCH 9.5/17] squash! i965/miptree: Unify aux buffer allocation

On Wed, May 16, 2018 at 09:11:38AM +0300, Pohjolainen, Topi wrote: > On Wed, May 09, 2018 at 10:47:24AM -0700, Nanley Chery wrote: > > v2: Inline the switch statement (Jason) > > > > Reviewed-by: Jason Ekstrand > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 90

Re: [Mesa-dev] [PATCH] etnaviv: Fix missing rnndb file in tarballs

Am Mi., 16. Mai 2018 um 19:04 Uhr schrieb Stuart Young : > Seems that when the rnndb files for etniviv were updated/included back > in Nov 2017, hw/texdesc_3d.xml.h was missed from Makefile.sources and > meson.build. This was all during the conversion to meson, so it apears > to

Re: [Mesa-dev] [PATCH] virgl: Update virgl_hw.h

Yes, it seems needed for the GLES on GLES work. Still needs to land: Reviewed-by: Gurchetan Singh On Wed, May 9, 2018 at 7:15 PM Dave Airlie wrote: > On 4 April 2018 at 02:06, Jakob Bornecrantz wrote: > > Signed-off-by:

[Mesa-dev] [PATCH] etnaviv: Fix missing rnndb file in tarballs

Seems that when the rnndb files for etniviv were updated/included back in Nov 2017, hw/texdesc_3d.xml.h was missed from Makefile.sources and meson.build. This was all during the conversion to meson, so it apears to have slipped through the cracks. As such, this file has been missing from the

Re: [Mesa-dev] docs: Intel Mesa Drivers infographic

feel free to disregard, considering the target audience, but s/Designed for Intel GPUs/Designed for GPUs/ ? (I mean compared to, say, LLVM, NIR has more passes that are in general useful to GPUs and much of what it misses compared to LLVM seems less useful for GPUs or SIMT processors.. I think

Re: [Mesa-dev] [PATCH] etnaviv: Fix missing rnndb file in tarballs

Am Mi., 16. Mai 2018 um 19:17 Uhr schrieb Christian Gmeiner < christian.gmei...@gmail.com>: > Am Mi., 16. Mai 2018 um 19:04 Uhr schrieb Stuart Young : > > Seems that when the rnndb files for etniviv were updated/included back > > in Nov 2017, hw/texdesc_3d.xml.h was missed

Re: [Mesa-dev] [PATCH] ac/llvm: use amdgcn.tbuffer.store instead of SI.tbuffer.store intrinsic

The new intrinsic is supported since LLVM 5.0. With that fixed: Reviewed-by: Marek Olšák Marek On Tue, May 15, 2018 at 8:24 PM, Dave Airlie wrote: > From: Dave Airlie > > Drop the use of the old intrinsic. > --- >

Re: [Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

ES has all kinds of additional linking rules. I suspect they'll break down if some of the shaders are ES and some are not-ES. This all does sound very odd -- what did you see in practice? On Wed, May 16, 2018 at 3:04 AM, Timothy Arceri wrote: > In GLES shader versions

Re: [Mesa-dev] [PATCH] mesa: add glUniform*ui{v} support to display lists

Reviewed-by: Marek Olšák Marek On Wed, May 9, 2018 at 11:53 PM, Timothy Arceri wrote: > Fixes: a017c7ecb7ae "mesa: display list support for uint uniforms" > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78097 > --- > > Piglit test:

[Mesa-dev] [PATCH 3/6] radeonsi: remove some old gfx 9.x registers

From: Marek Olšák Leftover from bring up. --- src/amd/common/gfx9d.h | 48 -- 1 file changed, 48 deletions(-) diff --git a/src/amd/common/gfx9d.h b/src/amd/common/gfx9d.h index 8c616451849..485fd7d0fed 100644 ---

[Mesa-dev] [PATCH 6/6] radeonsi: set DB_EQAA.MAX_ANCHOR_SAMPLES correctly

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f4e29f68b29..3a7e928df53 100644 ---

[Mesa-dev] [PATCH 4/6] radeonsi: remove redundant ps_iter_samples clamp

From: Marek Olšák si_get_ps_iter_samples already does this. --- src/gallium/drivers/radeonsi/si_state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 675b1adbe65..5bbf134b706

[Mesa-dev] [PATCH 2/6] radeonsi: disable primitive binning for all blitter ops

From: Marek Olšák same as Vulkan. --- src/gallium/drivers/radeonsi/si_blit.c | 10 ++ src/gallium/drivers/radeonsi/si_pipe.h | 2 +- src/gallium/drivers/radeonsi/si_state_binning.c | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 5/6] radeonsi: round ps_iter_samples in set_min_samples

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 6 -- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 1/6] ac/surface/gfx6: don't overallocate mipmapped HTILE

From: Marek Olšák --- src/amd/common/ac_surface.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 9e742dc8a45..47de522d15d 100644 --- a/src/amd/common/ac_surface.c +++

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 4.0

On 17 May 2018 at 12:25, Marek Olšák wrote: > From: Marek Olšák LGTM, Acked-by: Dave Airlie > > It doesn't support GFX9. > --- > .travis.yml | 6 +- > configure.ac

Re: [Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

Reviewed-by: Marek Olšák Marek On Wed, May 16, 2018 at 3:04 AM, Timothy Arceri wrote: > In GLES shader versions must match but there is nothing > in the ARB_ES*_compatibility specs that say they must match. > > This fixes some compilation errors in

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add glsl_external_mode() helper

On Sat, May 12, 2018 at 12:49 AM, Timothy Arceri wrote: > This allows us to get the variable mode as specified by the GLSL > spec. We will use this in the following patch. > --- > src/compiler/glsl/ast_to_hir.cpp | 73 > 1 file changed, 73

Re: [Mesa-dev] [PATCH] r600: fix constant buffer bounds.

On Thu, May 10, 2018 at 10:58 AM, Roland Scheidegger wrote: > Am 10.05.2018 um 16:47 schrieb Ivan Kalvachev: > > On 5/10/18, Roland Scheidegger wrote: > >> Quite a sneaky little bug, can't hurt to make undefined behavior a bit > >> more defined :-). > > >

Re: [Mesa-dev] [PATCH] radeonsi: create .gitignore

Sure. Done. Marek On Wed, May 16, 2018 at 7:54 AM, Dieter Nützel wrote: > Thank you Marek, > > can someone (you) commit for me, then? ;-) > > Dieter > > > Am 15.05.2018 18:35, schrieb Marek Olšák: > >> Reviewed-by: Marek Olšák >> >> Marek >> >> On

[Mesa-dev] [PATCH] amd: remove support for LLVM 4.0

From: Marek Olšák It doesn't support GFX9. --- .travis.yml | 6 +- configure.ac | 4 +- meson.build | 4 +- src/amd/common/ac_llvm_build.c| 282

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add glsl_external_mode() helper

On 17/05/18 10:59, Marek Olšák wrote: On Sat, May 12, 2018 at 12:49 AM, Timothy Arceri > wrote: This allows us to get the variable mode as specified by the GLSL spec. We will use this in the following patch. ---  

Re: [Mesa-dev] [PATCH v2] st/mesa: only define GLSL 1.4 for compat if driver supports it

On 17/05/18 00:17, Grazvydas Ignotas wrote: On Wed, May 16, 2018 at 5:02 PM, Christian Gmeiner wrote: Currently GLSL 1.4 is defined for all gallium drivers even only GLSL 1.2 is supported as seen on etnaviv. v1 -> v2: - use _min(..) as suggested by Lucas Stach

Re: [Mesa-dev] docs: Intel Mesa Drivers infographic

https://drive.google.com/file/d/1D0k3-p88xEame5gepJQfIcCyZhG4CAsW/view?usp=sharing On Mon, May 14, 2018 at 5:44 PM, Jason Ekstrand wrote: > One more comment: NIR is *not* a stable API. > > On Mon, May 14, 2018 at 2:10 PM, Laura Ekstrand > wrote: > >>

[Mesa-dev] [PATCH 3/4] i965/miptree: Remove format assertion in alloc_aux

intel_miptree_supports_{ccs,mcs,hiz} ensures the format is valid for the color or depth miptree before the miptree is assigned an aux_usage. alloc_aux switches on the aux_usage so don't assert that the format is valid. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 - 1 file changed, 5

[Mesa-dev] [PATCH 1/4] i965: Make get_ccs_surf succeed in alloc_aux

Synchronize the requirements listed in isl_surf_get_ccs_surf with intel_miptree_supports_ccs by importing a restriction from ISL. Some implications: * We successfully create every aux_surf in alloc_aux * We only return false from alloc_aux if we run out of memory ---

[Mesa-dev] [PATCH 2/4] i965/miptree: Simplify the switch in supports_ccs

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 0289f4f7e4c..1a797326a82 100644 ---

Re: [Mesa-dev] [PATCH v2] docs: add 18.0.5 in the release calendar

On Mon, 2018-05-14 at 16:18 +0200, Juan A. Suarez Romero wrote: > Mesa 18.1 series has not been released yet, so let's extend 18.0 lifetime. I suppose this also means that the part of the table regarding the 18.1 release should also be updated. In any case, this is: Reviewed-by: Andres Gomez

[Mesa-dev] [PATCH 4/4] i965: isl: Move the MCS gen7+ assertion into ISL

This is useful for every user of ISL. Drop the comment along the way to match similar functions in ISL. --- src/intel/isl/isl.c | 2 ++ src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 0/4] intel: Make get_ccs_surf succeed in alloc_aux

Topi noticed that in intel_miptree_alloc_aux, we allowed CCS surface retrieval to fail, but asserted that HiZ and MCS surface retrieval would succeed. This series gets rid of that inconsistency and modifies some related assertions. This series is on top of "i965: Avoid a redundant color buffer

Re: [Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

On 17/05/18 10:55, Ilia Mirkin wrote: ES has all kinds of additional linking rules. I suspect they'll break down if some of the shaders are ES and some are not-ES. Hmm looking closer there are indeed assumptions in the linker that all shaders are either ES or desktop. But I'm not sure that

[Mesa-dev] [Bug 78097] glUniform1ui and friends not supported by display lists

https://bugs.freedesktop.org/show_bug.cgi?id=78097 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

On 17/05/18 10:55, Ilia Mirkin wrote: ES has all kinds of additional linking rules. I suspect they'll break down if some of the shaders are ES and some are not-ES. This all does sound very odd -- what did you see in practice? Here is a trace is you want to have a look at the various isses

Re: [Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

Was this trace taken with mesa? Looks like the app was subjected to adverse conditions... 60876 glCreateShader(type = GL_VERTEX_SHADER) = 5 60877 glShaderSource(shader = 5, count = 1, string = &"#version 100 uniform mat4 uClipFromEyeMatrix; uniform mat4 uStartFromModelMatrix; uniform mat4

Re: [Mesa-dev] [PATCH v2 3/5] st/mesa: add support for ARB_sample_locations

For the first 3 patches: Reviewed-by: Marek Olšák You can also update relnotes in patch 5. Marek On Thu, May 10, 2018 at 12:28 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- >

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add glsl_external_mode() helper

On Wed, May 16, 2018 at 11:01 PM, Timothy Arceri wrote: > > > On 17/05/18 10:59, Marek Olšák wrote: > > On Sat, May 12, 2018 at 12:49 AM, Timothy Arceri > > wrote: >> >> This allows us to get the variable mode as

Re: [Mesa-dev] [PATCH 9.5/17] squash! i965/miptree: Unify aux buffer allocation

On Wed, May 16, 2018 at 09:33:34AM -0700, Nanley Chery wrote: > On Wed, May 16, 2018 at 09:11:38AM +0300, Pohjolainen, Topi wrote: > > On Wed, May 09, 2018 at 10:47:24AM -0700, Nanley Chery wrote: > > > v2: Inline the switch statement (Jason) > > > > > > Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

On 17/05/18 14:23, Ilia Mirkin wrote: Was this trace taken with mesa? Looks like the app was subjected to adverse conditions... Here is a better trace using mesa master: https://drive.google.com/open?id=1pws2OfCMHBL8QkOZKoVp1NbtgD9zPHh6 60876 glCreateShader(type = GL_VERTEX_SHADER) = 5

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add glsl_external_mode() helper

On 17/05/18 14:59, Marek Olšák wrote: On Thu, May 17, 2018 at 12:50 AM, Timothy Arceri > wrote: On 17/05/18 14:36, Marek Olšák wrote: On Wed, May 16, 2018 at 11:01 PM, Timothy Arceri

Re: [Mesa-dev] [PATCH 2/2] glsl: allow linking ES shaders with desktop shaders in desktop GL

On 17/05/18 14:23, Ilia Mirkin wrote: Was this trace taken with mesa? Looks like the app was subjected to adverse conditions... Oh right I need a fresh trace the GLSL ES 1.10 is not supported issue was cause by a dodgy change I made. 60876 glCreateShader(type = GL_VERTEX_SHADER) = 5 60877

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add glsl_external_mode() helper

On 17/05/18 14:36, Marek Olšák wrote: On Wed, May 16, 2018 at 11:01 PM, Timothy Arceri > wrote: On 17/05/18 10:59, Marek Olšák wrote: On Sat, May 12, 2018 at 12:49 AM, Timothy Arceri

Re: [Mesa-dev] [PATCH v2 1/3] glsl: add glsl_external_mode() helper

On Thu, May 17, 2018 at 12:50 AM, Timothy Arceri wrote: > > > On 17/05/18 14:36, Marek Olšák wrote: > >> On Wed, May 16, 2018 at 11:01 PM, Timothy Arceri > > wrote: >> >> >> >> On 17/05/18 10:59, Marek Olšák wrote:

[Mesa-dev] [PATCH v2] android: enable VK_ANDROID_native_buffer

Patch changes entrypoints generator to not skip this extension even though it is set as disabled in the xml. We also need compilation flag VK_USE_PLATFORM_ANDROID_KHR to be enabled. It looks like this extension got disabled in commit 69f447553c. v2: just remove the whole 'supported' attrib check

Re: [Mesa-dev] [PATCH 13/17] i965: Update the indirect buffer in set_clear_color

On Tue, May 08, 2018 at 02:55:24PM -0700, Nanley Chery wrote: > On Tue, May 08, 2018 at 09:24:19AM +0300, Pohjolainen, Topi wrote: > > On Thu, May 03, 2018 at 12:04:00PM -0700, Nanley Chery wrote: > > > Although BLORP currently does the update when performing a fast clear, > > > it's simpler to do

  1   2   >