[Mesa-dev] [PATCH 2/2] i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings

2016-05-25 Thread Samuel Iglesias Gonsálvez
Data starts at suboffet 3 in 32-bit units (12 bytes), so it is not 64-bit aligned and the current implementation fails to read the data properly. Instead, when there is is a double input varying, read it as vector of floats with twice the number of components. Signed-off-by: Samuel Iglesias

[Mesa-dev] [PATCH 1/2] i965/fs: fix offset when loading double vector input varyings

2016-05-25 Thread Samuel Iglesias Gonsálvez
When we are not packing a double input varying, we might need to read its data in a non-aligned to 64-bit offset, so we read the wrong data. This is happening when using explicit locations in varyings because Mesa disables packing varying for that case. const_index is in 32-bit size units but

[Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

2016-05-25 Thread Samuel Iglesias Gonsálvez
Hello, Timothy found that tests with unpacked double vector input varyings were failing in i965 driver. For example, this is happening when using explicit locations because Mesa disables varying packing for that case. These patches fix the following piglit test:

[Mesa-dev] [Bug 95005] Unreal engine demos segfault after shader compilation error with OpenGL 4.3

2016-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95005 --- Comment #13 from Alexandre Demers --- (In reply to Shawn Starr from comment #12) > neither patch fixes UE4 4.5.1 based games, get a dialog box (with nothing > inside it) and crashes sadly. Which patches are you

Re: [Mesa-dev] [PATCH V2] glsl: add support for doubles in GL 4.4+

2016-05-25 Thread Timothy Arceri
On Tue, 2016-05-24 at 11:34 +1000, Timothy Arceri wrote: > We disable varying packing in GL 4.4+ as we can no longer assume > varying have the same interpolation qualifiers. However doubles used > as fs inputs must always be qualified as "flat" and backends expect > doubles to have been packed as

[Mesa-dev] [PATCH] glsl: re-enable varying packing in GL4.4+

2016-05-25 Thread Timothy Arceri
The i965 backend currently expects doubles to be packed. --- src/compiler/glsl/link_varyings.cpp | 54 + 1 file changed, 24 insertions(+), 30 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

Re: [Mesa-dev] [PATCH 03/11] i965: Use nir to lower cs-derived variables

2016-05-25 Thread Kenneth Graunke
On Tuesday, May 24, 2016 1:37:48 AM PDT Jordan Justen wrote: > We added this support into nir for Mesa's Intel vulkan driver as part > of the SPIR-V support, so we can use it for the i965 driver as well. > > Signed-off-by: Jordan Justen > --- >

[Mesa-dev] [PATCH] swr: [rasterizer] Do not define _mm256_storeu2_m128i with icc.

2016-05-25 Thread Vinson Lee
Fix build error with icc. CXX libswrAVX_la-swr_clear.lo icpc: command line warning #10006: ignoring unknown option '-Wdelete-non-virtual-dtor' In file included from ./rasterizer/jitter/jit_api.h(31), from swr_context.h(30), from swr_clear.cpp(24):

Re: [Mesa-dev] [PATCH 01/10] compiler: Move glsl_to_nir to libglsl.la

2016-05-25 Thread Matt Turner
On Wed, May 25, 2016 at 6:52 PM, Jason Ekstrand wrote: > Right now libglsl.la depends on libnir.la so putting it in libnir.la > adds a dependency on libglsl.la that goes the wrong direction. > --- > src/compiler/Makefile.am |2 + >

[Mesa-dev] [Bug 96221] nir/nir_lower_tex.c:202: error: unknown field ‘f32’ specified in initializer

2016-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96221 Bug ID: 96221 Summary: nir/nir_lower_tex.c:202: error: unknown field ‘f32’ specified in initializer Product: Mesa Version: git Hardware: x86 (IA32) OS:

Re: [Mesa-dev] [PATCH] i965/urb: fixes division by zero

2016-05-25 Thread Ardinartsev Nikita
25.05.2016 00:44, Ben Widawsky пишет: On Tue, May 17, 2016 at 11:50:28AM -0700, Matt Turner wrote: On Mon, May 16, 2016 at 4:27 PM, Ardinartsev Nikita wrote: Fixes regression introduced by af5ca43f2676bff7499f93277f908b681cb821d0 Bugzilla:

[Mesa-dev] [PATCH v2] nvc0: enable 32 textures on kepler+

2016-05-25 Thread Ilia Mirkin
For fermi, this likely will require use of linked tsc mode. However on bindless architectures, we can have as many as we want. As it stands, the AUX_TEX_INFO has 32 teture handles reserved. Signed-off-by: Ilia Mirkin --- v1 -> v2: drop all the 1 -> 1U changes. They don't

[Mesa-dev] [PATCH 2/2] nvc0/ir: handle a load's reg result not being used for locked variants

2016-05-25 Thread Ilia Mirkin
For a load locked, we might not use the first result but the second result is the predicate result of the locking. In that case the load splitting logic doesn't apply (which is designed for splitting 128-bit loads). Instead we take the predicate and move it into the first position (as having a

[Mesa-dev] [PATCH 1/2] nvc0/ir: avoid generating illegal instructions for compute constbuf loads

2016-05-25 Thread Ilia Mirkin
For user-supplied constbufs, fileIndex is 0. In that case, when we subtract 1, we'll end up loading from constbuf offset -16. This is illegal, and there are asserts to avoid it. Normally we'd just DCE it, but no point in generating the instructions if they're not going to be used. Signed-off-by:

Re: [Mesa-dev] [PATCH v3] swr: implement clipPlanes/clipVertex/clipDistance/cullDistance

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 10:03 PM, Tim Rowley wrote: > v2: only load the clip vertex once > > v3: fix clip enable logic, add cullDistance > --- > docs/GL3.txt | 2 +- > src/gallium/drivers/swr/swr_context.h | 2 ++ >

[Mesa-dev] [PATCH v3] swr: implement clipPlanes/clipVertex/clipDistance/cullDistance

2016-05-25 Thread Tim Rowley
v2: only load the clip vertex once v3: fix clip enable logic, add cullDistance --- docs/GL3.txt | 2 +- src/gallium/drivers/swr/swr_context.h | 2 ++ src/gallium/drivers/swr/swr_screen.cpp | 3 +- src/gallium/drivers/swr/swr_shader.cpp | 63

[Mesa-dev] [PATCH 07/10] i965/test: Remove the fragment/vertex_program field from test visitors

2016-05-25 Thread Jason Ekstrand
None of them are actually using it. It's a relic of an older compiler interface that required a gl_program. --- src/mesa/drivers/dri/i965/test_fs_cmod_propagation.cpp | 4 src/mesa/drivers/dri/i965/test_fs_saturate_propagation.cpp | 4

[Mesa-dev] [PATCH 10/10] anv: Stop linking against libmesa.la and libdri_test_stubs.la

2016-05-25 Thread Jason Ekstrand
This brings the final size of an optimized non-debug build of the Vulkan driver down to 2.9 MB as opposed to 8.7 MB for the dri driver. --- src/intel/vulkan/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/Makefile.am

[Mesa-dev] [PATCH 00/10] i965, anv: Stop linking the Vulkan driver to libmesa

2016-05-25 Thread Jason Ekstrand
This little series reworks the build a bit so that we can stop linking the Vulkan driver to libmesa. This lets us substantially cut down on the size of the final binary. The whole series can be found in a branch here: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/anv-no-libmesa Cc:

[Mesa-dev] [PATCH 06/10] i965: Move brw_new_shader to brw_link.cpp

2016-05-25 Thread Jason Ekstrand
That's where brw_link_shader lives and they seem to go together. Also, this gets it out of libi965_compiler. --- src/mesa/drivers/dri/i965/brw_link.cpp | 17 + src/mesa/drivers/dri/i965/brw_shader.cpp | 17 - 2 files changed, 17 insertions(+), 17 deletions(-)

[Mesa-dev] [PATCH 03/10] i965/nir: Move the type_size_*_bytes functions to brw_nir.h

2016-05-25 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_nir.c | 12 src/mesa/drivers/dri/i965/brw_nir.h | 13 + 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/brw_nir.c index 45551a1..62ed0e8 100644 ---

[Mesa-dev] [PATCH 09/10] i965: Don't link libmesa or libdri_test_stubs into tests

2016-05-25 Thread Jason Ekstrand
Now that the compiler has been completely separated from libmesa, we no longer need these. We can make the tests much smaller by not linking them in. This also ensures that anyone who runs make check won't accidentally put in any dependencies from the compiler to the rest of mesa core. ---

[Mesa-dev] [PATCH 08/10] i965: Move compiler debug functions to intel_screen.c

2016-05-25 Thread Jason Ekstrand
They reference the compiler so they shouldn't go in libi965_compiler.la. --- src/mesa/drivers/dri/i965/brw_compiler.c | 42 src/mesa/drivers/dri/i965/intel_screen.c | 42 2 files changed, 42 insertions(+), 42 deletions(-) diff

[Mesa-dev] [PATCH 04/10] i965: Move brw_create_nir to brw_program.c

2016-05-25 Thread Jason Ekstrand
This way it's no longer part of libi965_compiler.la since it depends on GLSL and ARB program stuff. --- src/mesa/drivers/dri/i965/brw_nir.c | 70 - src/mesa/drivers/dri/i965/brw_nir.h | 6 --- src/mesa/drivers/dri/i965/brw_program.c | 68

[Mesa-dev] [PATCH 05/10] i965: Move brw_nir_lower_uniforms.cpp to i965_FILES

2016-05-25 Thread Jason Ekstrand
This gets it out of i965_compiler.la --- src/mesa/drivers/dri/i965/Makefile.sources | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.sources b/src/mesa/drivers/dri/i965/Makefile.sources index 01f2ef6..d8711ed 100644 ---

[Mesa-dev] [PATCH 02/10] ptn: Include nir.h

2016-05-25 Thread Jason Ekstrand
--- src/mesa/program/prog_to_nir.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/program/prog_to_nir.h b/src/mesa/program/prog_to_nir.h index 34e4cd1..09425b5 100644 --- a/src/mesa/program/prog_to_nir.h +++ b/src/mesa/program/prog_to_nir.h @@ -24,6 +24,9 @@ #pragma once

Re: [Mesa-dev] [PATCH] glsl: add unit tests data vertex/expected outcome for uninitialized warning

2016-05-25 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 05/13/2016 01:21 AM, Alejandro Piñeiro wrote: > v2: fix 025 test. Add three more tests (Ian Romanick) > --- > > This patch adds the two tests Ian suggested: > 026-out-function-parameter-shaderout.ver >

Re: [Mesa-dev] [PATCH v3] glsl: do not raise uninitialized warning with out function parameters

2016-05-25 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 05/13/2016 01:16 AM, Alejandro Piñeiro wrote: > It silence by default warnings with function parameters, as the > parameters need to be processed in order to have the actual and the > formal parameter, and the function

Re: [Mesa-dev] [PATCH v2] swr: implement clipPlanes/clipVertex/clipDistance

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 8:32 PM, Tim Rowley wrote: > v2: only load the clip vertex once > --- > src/gallium/drivers/swr/swr_context.h | 2 ++ > src/gallium/drivers/swr/swr_shader.cpp | 65 > ++ > src/gallium/drivers/swr/swr_shader.h

[Mesa-dev] [PATCH v2] swr: implement clipPlanes/clipVertex/clipDistance

2016-05-25 Thread Tim Rowley
v2: only load the clip vertex once --- src/gallium/drivers/swr/swr_context.h | 2 ++ src/gallium/drivers/swr/swr_shader.cpp | 65 ++ src/gallium/drivers/swr/swr_shader.h | 4 +++ src/gallium/drivers/swr/swr_state.cpp | 22 +++- 4 files changed, 92

[Mesa-dev] [PATCH] swr: implement clipPlanes/clipVertex/clipDistance

2016-05-25 Thread Tim Rowley
--- src/gallium/drivers/swr/swr_context.h | 2 ++ src/gallium/drivers/swr/swr_shader.cpp | 64 ++ src/gallium/drivers/swr/swr_shader.h | 4 +++ src/gallium/drivers/swr/swr_state.cpp | 22 +++- 4 files changed, 91 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] gallium: detect avx512 cpu features

2016-05-25 Thread Tim Rowley
--- src/gallium/auxiliary/util/u_cpu_detect.c | 17 + src/gallium/auxiliary/util/u_cpu_detect.h | 10 ++ 2 files changed, 27 insertions(+) diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c b/src/gallium/auxiliary/util/u_cpu_detect.c index aa3c30a..0d4a7c4 100644 ---

Re: [Mesa-dev] [PATCH] glsl/ast: assign explicit_xfb_buffer from correct place

2016-05-25 Thread Timothy Arceri
On Thu, 2016-05-26 at 09:25 +1000, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > GL44- > CTS.tessellation_shader.tessellation_control_to_tessellation_evaluati > on.data_pass_through > > As the OUT_TC interface structures weren't matching because > one of them had

[Mesa-dev] [PATCH] glsl/ast: assign explicit_xfb_buffer from correct place

2016-05-25 Thread Dave Airlie
From: Dave Airlie This fixes: GL44-CTS.tessellation_shader.tessellation_control_to_tessellation_evaluation.data_pass_through As the OUT_TC interface structures weren't matching because one of them had explicit_xfb_buffer set when it shouldn't. Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 2/2] mesa: Move robustness code to main/robustness.c

2016-05-25 Thread Brian Paul
Same here. Thanks. Reviewed-by: Brian Paul On 05/25/2016 04:54 PM, Jason Ekstrand wrote: Both are Reviewed-by: Jason Ekstrand > On Wed, May 25, 2016 at 3:38 PM, Kristian Høgsberg

[Mesa-dev] [PATCH] platform_android: prevent deadlock in droid_swap_buffers

2016-05-25 Thread Haixia Shi
To avoid blocking other EGL calls, release the display mutex before we enqueue buffer to android frameworks and re-acquire the mutex upon return. TEST=verify pinch zoom in Photos app no longer causes hangs Signed-off-by: Haixia Shi --- src/egl/drivers/dri2/platform_android.c

Re: [Mesa-dev] [PATCH 2/2] mesa: Move robustness code to main/robustness.c

2016-05-25 Thread Jason Ekstrand
Both are Reviewed-by: Jason Ekstrand On Wed, May 25, 2016 at 3:38 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > Signed-off-by: Kristian Høgsberg Kristensen > --- >

[Mesa-dev] [PATCH 1/2] docs: Mark GL_KHR_robustness done for GLES3.2 as well

2016-05-25 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen Signed-off-by: Kristian Høgsberg Kristensen --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 555a9be..9258fdf 100644 --- a/docs/GL3.txt +++

[Mesa-dev] [PATCH 2/2] mesa: Move robustness code to main/robustness.c

2016-05-25 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen Signed-off-by: Kristian Høgsberg Kristensen --- src/mesa/Makefile.sources | 1 + src/mesa/main/getstring.c | 136 - src/mesa/main/robustness.c | 165

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

2016-05-25 Thread Emil Velikov
On 25 May 2016 at 15:46, Philipp Zabel wrote: > Am Mittwoch, den 25.05.2016, 16:01 +0200 schrieb Marek Olšák: >> On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel >> wrote: >> > Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel: >> >> To

Re: [Mesa-dev] [PATCH] glsl: fix error message on uniform block mismatch

2016-05-25 Thread Anuj Phogat
On Wed, May 25, 2016 at 2:42 PM, Dave Airlie wrote: > From: Dave Airlie > > This looks like a cut-paste from above. > > Signed-off-by: Dave Airlie > --- > src/compiler/glsl/link_interface_blocks.cpp | 2 +- > 1 file changed, 1

[Mesa-dev] [PATCH] glsl: fix error message on uniform block mismatch

2016-05-25 Thread Dave Airlie
From: Dave Airlie This looks like a cut-paste from above. Signed-off-by: Dave Airlie --- src/compiler/glsl/link_interface_blocks.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_interface_blocks.cpp

Re: [Mesa-dev] [PATCH] nvc0: allow to monitor MP perf counters with compute shaders

2016-05-25 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, May 25, 2016 at 5:36 PM, Samuel Pitoiset wrote: > To read out MP perf counters we use a compute shader and need to upload > input data like a 64-bits addr used to store the values and a sequence > ID for

[Mesa-dev] [PATCH] nvc0: allow to monitor MP perf counters with compute shaders

2016-05-25 Thread Samuel Pitoiset
To read out MP perf counters we use a compute shader and need to upload input data like a 64-bits addr used to store the values and a sequence ID for synchronization. Currently, this input data is uploaded as user uniforms which means that it's sticked to c0[], but if a compute shader from a real

[Mesa-dev] [PATCH 2/2] vc4: Fix doxygen warnings

2016-05-25 Thread Rhys Kidd
Now that vc4 automated code documentation can be generated with doxygen, fix the warnings issued by Doxygen 1.8.11. Signed-off-by: Rhys Kidd --- src/gallium/drivers/vc4/vc4_qir_schedule.c | 4 ++-- src/gallium/drivers/vc4/vc4_tiling.c | 8 2 files changed, 6

[Mesa-dev] [PATCH 0/2] vc4: Add automated code documentation

2016-05-25 Thread Rhys Kidd
Simple patchset to provide doxygen-based automated code documentation of the vc4 driver for developers. By plumbing this through we get the same for all Gallium-based drivers for free. Post review I will need someone with Mesa commit access to push these for me. Rhys Kidd (2): doxygen: Plumb

[Mesa-dev] [PATCH 1/2] doxygen: Plumb through gallium/ to automated documentation

2016-05-25 Thread Rhys Kidd
Add Gallium and the Gallium-based drivers to doxygen's automated code documentation infrastructure. Can be individually created with: cd $MESA_TOP_LEVEL/ make -C doxygen/ gallium.tag Benefits from the existing doxygen Makefile runners to clean up afterwards with 'make clean'.

[Mesa-dev] [Bug 96219] Using glXBindTexImageEXT with a GLXPixmap created out-of-process fails

2016-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96219 Bug ID: 96219 Summary: Using glXBindTexImageEXT with a GLXPixmap created out-of-process fails Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

2016-05-25 Thread Ian Romanick
On 05/25/2016 12:57 PM, Matt Turner wrote: > On Wed, May 25, 2016 at 9:17 AM, Ian Romanick wrote: >> On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: >>> From: Mathias Fröhlich >>> >>> Replaces loops that iterate all lights and test >>>

Re: [Mesa-dev] [PATCH 1/7] i965: Account for MinLayer in CopyImageSubData's blitter/CPU paths.

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 4:15 PM, Kenneth Graunke wrote: > On Friday, May 20, 2016 11:57:32 PM PDT Ilia Mirkin wrote: >> Is the else correct? What if you have, e.g., a cube view of a 2d array, >> starting at later 2? Don't you want to add the min layer in no matter what? > >

Re: [Mesa-dev] [PATCH 1/7] i965: Account for MinLayer in CopyImageSubData's blitter/CPU paths.

2016-05-25 Thread Kenneth Graunke
On Friday, May 20, 2016 11:57:32 PM PDT Ilia Mirkin wrote: > Is the else correct? What if you have, e.g., a cube view of a 2d array, > starting at later 2? Don't you want to add the min layer in no matter what? I believe you're right. TextureView does set up a MinLayer for cube views, and both

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 3:52 PM, Matt Turner wrote: > On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset > wrote: >> This fixes use of compute shaders with some NVIDIA GL 4.3 samples which >> require a compat profile. > > I'm confused. > > The

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

2016-05-25 Thread Samuel Pitoiset
On 05/25/2016 09:52 PM, Matt Turner wrote: On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset wrote: This fixes use of compute shaders with some NVIDIA GL 4.3 samples which require a compat profile. I'm confused. The samples you're talking about... use 4.3

Re: [Mesa-dev] [PATCH] i965: Don't use fast copy blit in case of logical operations other than GL_COPY

2016-05-25 Thread Matt Turner
On Wed, May 25, 2016 at 11:40 AM, Anuj Phogat wrote: > XY_FAST_COPY_BLT command doesn't have a field for raster operation. So, fall > back to using XY_SRC_COPY_BLT to handle those cases. > > Fixes piglit test gl-1.1-xor-copypixels when fast copy blit is enabled > for all

Re: [Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

2016-05-25 Thread Matt Turner
On Wed, May 25, 2016 at 9:17 AM, Ian Romanick wrote: > On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: >> From: Mathias Fröhlich >> >> Replaces loops that iterate all lights and test >> which of them is enabled by a loop only iterating

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

2016-05-25 Thread Matt Turner
On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset wrote: > This fixes use of compute shaders with some NVIDIA GL 4.3 samples which > require a compat profile. I'm confused. The samples you're talking about... use 4.3 compatibility? We already don't support

[Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

2016-05-25 Thread Samuel Pitoiset
This fixes use of compute shaders with some NVIDIA GL 4.3 samples which require a compat profile. Signed-off-by: Samuel Pitoiset --- src/mesa/main/context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/context.h

Re: [Mesa-dev] [PATCH v2] nvc0: add descriptions for hardware perf counters/metrics

2016-05-25 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Of course if these aren't used, you can just have the macro take the extra parameter and do nothing with it. Your call. On Wed, May 25, 2016 at 2:58 PM, Samuel Pitoiset wrote: > The GALLIUM_HUD does not yet expose a

[Mesa-dev] [Bug 96176] Cannot build non-intel drivers without python3.

2016-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96176 --- Comment #2 from Vinson Lee --- Mac OS X and CentOS do not have Python 3. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH v2] nvc0: add descriptions for hardware perf counters/metrics

2016-05-25 Thread Samuel Pitoiset
The GALLIUM_HUD does not yet expose a description for each events, but this might be useful for developers who want to have a long description of hw perf counters directly in the source code. v2: - add static const for the arrays of queries/metrics - add spaces before quotes Signed-off-by:

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

2016-05-25 Thread Jason Ekstrand
On Wed, May 25, 2016 at 11:29 AM, Ilia Mirkin wrote: > On Wed, May 25, 2016 at 2:27 PM, Ilia Mirkin wrote: > > On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: > >> --- > >> docs/install.html | 5 +++-- > >> 1 file changed, 3

Re: [Mesa-dev] [PATCH 1/2] gbm: Enable DRI2 fence extension in the GBM DRI backend

2016-05-25 Thread Marek Olšák
On Wed, May 25, 2016 at 4:46 PM, Philipp Zabel wrote: > Am Mittwoch, den 25.05.2016, 16:01 +0200 schrieb Marek Olšák: >> On Wed, May 25, 2016 at 3:44 PM, Philipp Zabel >> wrote: >> > Am Dienstag, den 10.05.2016, 17:35 +0200 schrieb Philipp Zabel:

Re: [Mesa-dev] [PATCH] nvc0: add descriptions for hardware perf counters/metrics

2016-05-25 Thread Samuel Pitoiset
On 05/25/2016 08:52 PM, Ilia Mirkin wrote: On Wed, May 25, 2016 at 2:49 PM, Samuel Pitoiset wrote: The GALLIUM_HUD does not yet expose a description for each events, but this might be useful for developers who want to have a long description of hw perf counters

Re: [Mesa-dev] [PATCH] nvc0: add descriptions for hardware perf counters/metrics

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 2:49 PM, Samuel Pitoiset wrote: > The GALLIUM_HUD does not yet expose a description for each events, but > this might be useful for developers who want to have a long description > of hw perf counters directly in the source code. > >

[Mesa-dev] [PATCH] nvc0: add descriptions for hardware perf counters/metrics

2016-05-25 Thread Samuel Pitoiset
The GALLIUM_HUD does not yet expose a description for each events, but this might be useful for developers who want to have a long description of hw perf counters directly in the source code. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 2:27 PM, Ilia Mirkin wrote: > On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: >> --- >> docs/install.html | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/docs/install.html b/docs/install.html >>

[Mesa-dev] [PATCH] i965: Don't use fast copy blit in case of logical operations other than GL_COPY

2016-05-25 Thread Anuj Phogat
XY_FAST_COPY_BLT command doesn't have a field for raster operation. So, fall back to using XY_SRC_COPY_BLT to handle those cases. Fixes piglit test gl-1.1-xor-copypixels when fast copy blit is enabled for all tiling formats. Signed-off-by: Anuj Phogat ---

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

2016-05-25 Thread Brian Paul
On 05/25/2016 12:27 PM, Ilia Mirkin wrote: On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: --- docs/install.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/install.html b/docs/install.html index 8b349c4..41a7d79 100644 ---

Re: [Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 2:26 PM, Brian Paul wrote: > --- > docs/install.html | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/docs/install.html b/docs/install.html > index 8b349c4..41a7d79 100644 > --- a/docs/install.html > +++ b/docs/install.html

[Mesa-dev] [PATCH] docs: Python3 needed for Intel driver

2016-05-25 Thread Brian Paul
--- docs/install.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/install.html b/docs/install.html index 8b349c4..41a7d79 100644 --- a/docs/install.html +++ b/docs/install.html @@ -34,8 +34,9 @@ 1.1 General -http://www.python.org/;>Python - Python is

Re: [Mesa-dev] [PATCH 2/2] mesa: 80-column wrapping for _context_lost_GetSynciv()

2016-05-25 Thread Kristian Høgsberg
Ah right. Thanks, both patches R-b. Kristian > On May 25, 2016, at 10:59, Brian Paul wrote: > > --- > src/mesa/main/getstring.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c > index

Re: [Mesa-dev] [PATCH] i965/gen9: Remove the halign/valign field setup code in fast copy blit

2016-05-25 Thread Ben Widawsky
On Wed, May 25, 2016 at 10:52:31AM -0700, Anuj Phogat wrote: > Experimentation with different values of src/dst horizontal/vertical > alignment showed that these fileds are not used on gen9 hardware. > > A recent update in graphics specs has removed these fields from > XY_FAST_COPY_BLT command. >

Re: [Mesa-dev] [PATCHv2 0/2] scons 2.5.0 support

2016-05-25 Thread Brian Paul
Thanks. I'll push these soon. -Brian On 05/25/2016 01:12 AM, Giuseppe Bilotta wrote: Again, the main patch is the second, the first is just a cleanup of EOL whitespace. Changes over v1: * rebased on current master; * documented EOL whitespace cleanup shell command; * direct link to Bugzilla,

[Mesa-dev] [PATCH 1/2] mesa: add GLAPIENTRY to new _context_lost_X functions

2016-05-25 Thread Brian Paul
To fix MSVC build. Any function which goes into the dispatch table needs to have the GLAPIENTRY (__stdcall) tag. --- src/mesa/main/getstring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 125b03a..8989b08

[Mesa-dev] [PATCH 2/2] mesa: 80-column wrapping for _context_lost_GetSynciv()

2016-05-25 Thread Brian Paul
--- src/mesa/main/getstring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 8989b08..1118a44 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstring.c @@ -312,8 +312,8 @@ _mesa_GetError( void ) }

[Mesa-dev] [PATCH 2/3] nir/inline: Break the guts of rewrite_param-derefs into a helper

2016-05-25 Thread Jason Ekstrand
--- src/compiler/nir/nir_inline_functions.c | 49 - 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/src/compiler/nir/nir_inline_functions.c b/src/compiler/nir/nir_inline_functions.c index e124a77..af9a781 100644 ---

[Mesa-dev] [PATCH 1/3] nir/inline: Make the rewrite_param_derefs helper work on instructions

2016-05-25 Thread Jason Ekstrand
Now that we have the better nir_foreach_block macro, there's no reason to use the archaic block version for everything. --- src/compiler/nir/nir_inline_functions.c | 53 - 1 file changed, 25 insertions(+), 28 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] nir/inline: Also rewrite param derefs for texture instructions

2016-05-25 Thread Jason Ekstrand
--- src/compiler/nir/nir_inline_functions.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir_inline_functions.c b/src/compiler/nir/nir_inline_functions.c index af9a781..d1b80f6 100644 ---

[Mesa-dev] [PATCH] i965/gen9: Remove the halign/valign field setup code in fast copy blit

2016-05-25 Thread Anuj Phogat
Experimentation with different values of src/dst horizontal/vertical alignment showed that these fileds are not used on gen9 hardware. A recent update in graphics specs has removed these fields from XY_FAST_COPY_BLT command. Cc: Ben Widawsky Cc: Chad Versace

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

2016-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95346 Jure Repinc changed: What|Removed |Added CC||jlp.b...@gmail.com --

[Mesa-dev] [AppVeyor] mesa master #1366 failed

2016-05-25 Thread AppVeyor
Build mesa 1366 failed Commit 89bb4be91e by Kristian Høgsberg Kristensen on 5/25/2016 4:30 PM: i965: Fix shadowing of 'height' parameter\n\nThe nested declaration of 'height' shadows a parameter and uses\nuninitialized memory. Fix by renaming to 'plane_height'

Re: [Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

2016-05-25 Thread Emil Velikov
On 25 May 2016 at 17:33, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > The nested declaration of 'height' shadows a parameter and uses > uninitialized memory. Fix by renaming to 'plane_height' which also makes > the code clearer. > >

Re: [Mesa-dev] [PATCH] swr: [rasterizer] Correctly select optimized primitive assembly.

2016-05-25 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On May 24, 2016, at 3:00 PM, Bruce Cherniak wrote: > > Indexed primitives were always using cut-aware primitive assembly, > whether primitive_restart was enabled or not. Correctly pass down > primitive_restart and

Re: [Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

2016-05-25 Thread Eric Engestrom
On Wed, May 25, 2016 at 09:33:30AM -0700, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > The nested declaration of 'height' shadows a parameter and uses > uninitialized memory. Fix by renaming to 'plane_height' which also makes > the code clearer. > > This

Re: [Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

2016-05-25 Thread Ian Romanick
Yikes. Reviewed-by: Ian Romanick On 05/25/2016 09:33 AM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > The nested declaration of 'height' shadows a parameter and uses > uninitialized memory. Fix by renaming to 'plane_height'

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-25 Thread Andy Furniss
Christian König wrote: From: Christian König We support 5.1 for a while now. I know (well think) vdpau doesn't really mention 5.2 anywhere, but for ffmpeg I've been making this change for some time to say 5.2. Tonga can easily do 5.2, players don't seem to look at

Re: [Mesa-dev] [PATCH] mesa: Add .gitignore entries for make check binaries

2016-05-25 Thread Kristian Høgsberg
On Tue, May 24, 2016 at 11:02 PM, Matt Turner wrote: > On Tue, May 24, 2016 at 9:07 PM, Kristian Høgsberg wrote: >> From: Kristian Høgsberg Kristensen >> >> Signed-off-by: Kristian Høgsberg Kristensen >> --- >>

[Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

2016-05-25 Thread Kristian Høgsberg
From: Kristian Høgsberg Kristensen The nested declaration of 'height' shadows a parameter and uses uninitialized memory. Fix by renaming to 'plane_height' which also makes the code clearer. This would typically break the bo size computation, but we don't use that except when

Re: [Mesa-dev] [PATCH 00/29] Make more use of bitmasks

2016-05-25 Thread Ian Romanick
On 05/23/2016 11:41 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi all, > > following a series with performance improvements > for cpu/draw bound applications. This part makes > more use of the bitmask/ffs technique for iterating > a set of

Re: [Mesa-dev] [PATCH 05/29] i915: Convert i915 to use CoordsReplaceBits.

2016-05-25 Thread Ian Romanick
On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Switch over to use the CoordsReplaceBits bitmask. > > Signed-off-by: Mathias Fröhlich > --- > src/mesa/drivers/dri/i915/i915_state.c | 17 +++--

[Mesa-dev] [PATCH] egl: Additional attribute validation for eglCreatePbufferSurface

2016-05-25 Thread Plamena Manolova
eglCreatePbufferSurface should generate an EGL_BAD_MATCH error if: 1: The EGL_TEXTURE_FORMAT attribute is EGL_NO_TEXTURE and EGL_TEXTURE_TARGET is something other than EGL_NO_TEXTURE 2: EGL_TEXTURE_FORMAT is something other than EGL_NO_TEXTURE and EGL_TEXTURE_TARGET is EGL_NO_TEXTURE. This fixes

Re: [Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

2016-05-25 Thread Ilia Mirkin
On Wed, May 25, 2016 at 12:17 PM, Ian Romanick wrote: > On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: >> From: Mathias Fröhlich >> >> Replaces loops that iterate all lights and test >> which of them is enabled by a loop only iterating

Re: [Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

2016-05-25 Thread Ian Romanick
On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Replaces loops that iterate all lights and test > which of them is enabled by a loop only iterating over > the bits set in the enabled bitmask. > --- > src/mesa/tnl/t_vb_light.c|

Re: [Mesa-dev] [PATCH] radeon/uvd: fix the H264 level for Tonga

2016-05-25 Thread Alex Deucher
On Wed, May 25, 2016 at 12:08 PM, Emil Velikov wrote: > On 25 May 2016 at 16:56, Alex Deucher wrote: >> On Wed, May 25, 2016 at 10:57 AM, Christian König >> wrote: >>> From: Christian König >>>

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

2016-05-25 Thread Ian Romanick
On 05/25/2016 03:06 AM, Erik Faye-Lund wrote: > On Tue, May 24, 2016 at 8:42 AM, wrote: >> From: Mathias Fröhlich >> >> Replaces a loop that iterates all lights and test >> which of them is enabled by a loop only iterating over >> the bits

Re: [Mesa-dev] [PATCH] glsl: split out libstandalone

2016-05-25 Thread Emil Velikov
On 25 May 2016 at 00:39, Rob Clark wrote: > From: Rob Clark > > Split standalone glsl_compiler into a libstandalone.la and a thin > main.cpp. This way drivers can re-use the glsl standalone frontend in > their own standalone compilers. > >

[Mesa-dev] i965/blorp: Preparing for flat inputs + small optimizations

2016-05-25 Thread Topi Pohjolainen
First three clarify a little how vertex buffers are configured in the command stream. There is a subtle difference between gen8+ and earlier, and I thought it would be clearer to have it documented with bspec quotes. Next four drop some hardcoding in upload logic making the emitters to consult

Re: [Mesa-dev] [PATCH] android: drop build of standalone glsl_compiler

2016-05-25 Thread Emil Velikov
On 25 May 2016 at 15:01, Rob Clark wrote: > From: Rob Clark > > It's only a tool for debugging the glsl compiler, and should not be > installed. > > Signed-off-by: Rob Clark > --- > Untested, but should be correct.. > Yes

Re: [Mesa-dev] [PATCH 10/29] mesa: Use bitmask/ffs to iterate enabled lights

2016-05-25 Thread Ian Romanick
On 05/23/2016 11:42 PM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Replaces loops that iterate all lights and test > which of them is enabled by a loop only iterating over > the bits set in the enabled bitmask. > > Signed-off-by: Mathias Fröhlich

[Mesa-dev] [PATCH 02/14] i965/gen8: Fix the vertex buffer size

2016-05-25 Thread Topi Pohjolainen
And refactor to use the same upload logic with earlier gens. On gen >= 8 one doesn't provide ending address but number of bytes available. This is relative to the given offset. Until now we programmed the full size of the buffer regardless of the used offset. Signed-off-by: Topi Pohjolainen

  1   2   >