[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #16 from andrii simiklit --- (In reply to Ilia Mirkin from comment #14) > (In reply to andrii simiklit from comment #13) > > Thank you) But unfortunately the tests failed so guess I didn't consider > > something. I am going to

Re: [Mesa-dev] last call for autotools

2019-02-05 Thread Tapani Pälli
On 2/5/19 8:20 PM, Marek Olšák wrote: PKG_CONFIG_PATH still seems to be forgotten by meson. Is there an alternative? Maybe this can be worked out since at least for me it seems to complain that 'different PKG_CONFIG_PATH' was used when configuring last time: WARNING: PKG_CONFIG_PATH has

Re: [Mesa-dev] [PATCH 2/2] panfrost: Include glue for out-of-tree legacy code

2019-02-05 Thread Jason Ekstrand
On February 5, 2019 20:56:25 Alyssa Rosenzweig wrote: @@ -39,7 +39,7 @@ files_panfrost = files( 'pan_blending.c', 'pan_blend_shaders.c', 'pan_wallpaper.c', - 'pan_pretty_print.c' + 'pan_pretty_print.c', ) inc_panfrost = [ This hunk seems unrelated... ..Oops, although looking at other

Re: [Mesa-dev] [PATCH 2/2] panfrost: Include glue for out-of-tree legacy code

2019-02-05 Thread Alyssa Rosenzweig
> > @@ -39,7 +39,7 @@ files_panfrost = files( > >'pan_blending.c', > >'pan_blend_shaders.c', > >'pan_wallpaper.c', > > - 'pan_pretty_print.c' > > + 'pan_pretty_print.c', > > ) > > > > inc_panfrost = [ > > This hunk seems unrelated... ..Oops, although looking at other drivers'

[Mesa-dev] [PATCH v2] kmsro: Move DRM entrypoints to shared block

2019-02-05 Thread Alyssa Rosenzweig
As kmsro allows an essentially mix-and-match hodgepodge of display drivers and renderonly GPUs, it doesn't make sense to couple the display driver entrypoint definition with the driver. Instead, we move *all* kmsro entrypoints to a shared kmsro block at the end (avoiding clutter and distraction

[Mesa-dev] [PATCH 2/2] st/mesa: require RGBA2, RGB4, and RGBA4 to be renderable

2019-02-05 Thread Ilia Mirkin
From: Karol Herbst If the driver does not support rendering to these formats but does support texturing, we can end up in incompatibilities between textures and renderbuffers that are then copied to. Fixes KHR-GL45.copy_image.functional on nvc0 Reviewed-by: Ilia Mirkin Cc: 19.0 --- I think

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MAX_VARYINGS

2019-02-05 Thread Ilia Mirkin
From: Karol Herbst Some NVIDIA hardware can accept 128 fragment shader input components, but only have up to 124 varying-interpolated input components. We add a new cap to express this cleanly. For most drivers, this will have the same value as PIPE_SHADER_CAP_MAX_INPUTS for the fragment shader.

Re: [Mesa-dev] [PATCH v2 3/5] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-02-05 Thread Nanley Chery
On Sun, Feb 03, 2019 at 03:07:34PM +0200, Eleni Maria Stea wrote: > GPUs Gen < 8 cannot sample ETC2 formats. So far, they converted the > compressed EAC/ETC2 images to non-compressed RGBA images. When > GetCompressed* functions were called, the pixels were returned in this > RGBA format and not

Re: [Mesa-dev] [PATCH 23/25] radeonsi: factor si_query_buffer logic out of si_query_hw

2019-02-05 Thread Timothy Arceri
On 4/2/19 11:26 pm, Nicolai Hähnle wrote: On 01.02.19 05:25, Timothy Arceri wrote: On 26/1/19 11:56 am, Marek Olšák wrote: Timothy, can you please test the attached fix? I'm having trouble compiling 32bit mesa on my machine at the moment so haven't been able to test Batman. But this commit

Re: [Mesa-dev] [PATCH] panfrost: Use u_pipe_screen_get_param_defaults

2019-02-05 Thread Alyssa Rosenzweig
> This hunk looks out of place in what is otherwise a refactor. Originally, that routine was copied from softpipe; I rather doubt it applies here, so this was part of the refactor/cleanup. It now should work the same as v3d. As an aside, I wonder if we might want that snippet to *become* the

[Mesa-dev] [Bug 109548] Seeing visual corruption in totem after installing amdgpu 18.50 in Ubuntu 18.04.1

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109548 --- Comment #4 from spause+bugzi...@gmail.com --- libva info: VA-API version 1.1.0 libva info: va_getDriverName() returns 0 libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/radeonsi_drv_video.so libva info: Found init function

Re: [Mesa-dev] [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2019-02-05 Thread Rodrigo Vivi
Hi all, restarting a very old thread since Dmitry is interested in tackle the issue that we have to propagate and keep all IDs in sync across the stack. He has few ideas of i915 ioctls in a way that it wouldn't necessarily tie build dependencies etc.. Since I believe this place is the best one

[Mesa-dev] [ANNOUNCE] mesa 19.0.0-rc2

2019-02-05 Thread Dylan Baker
Hi list, This is the announcement for mesa 19.0.0-rc2. It's been a pretty slow first week for 19.0, most of the fixes here are for the tarball itself. There's also a few fixes for vc4, anv, intel shared code, radv, radeonsi, core mesa, v3d, st/mesa, and the dri3 loader. As always, please test

Re: [Mesa-dev] [PATCH 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-02-05 Thread Timothy Arceri
On 6/2/19 1:11 am, Andres Gomez wrote: On Fri, 2019-02-01 at 18:37 -0500, Ilia Mirkin wrote: On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: If there is no Static Use of an input variable, the linker shouldn't fail whenever there is no defined matching output variable in the previous

[Mesa-dev] 10-bit fbconfigs break most video players using VAAPI+GLX

2019-02-05 Thread Marek Olšák
Hi, Video players request fbconfigs with these attributes: GLX_RED_SIZE = 8 GLX_GREEN_SIZE = 8 GLX_BLUE_SIZE = 8 GLX_ALPHA_SIZE = 0 Note that the values specify MINIMUM required component sizes, not exact sizes. 10-10-10-2 satisfies the requirement and therefore glXChooseFBConfig returns it

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #15 from Mark Janes --- (In reply to Ilia Mirkin from comment #14) > Did the test actually pass for you? Or just not crash? When I made my > "naive" change, it fixed the crash, but the test continued to fail. On i965, tests did not

Re: [Mesa-dev] last call for autotools

2019-02-05 Thread Marek Olšák
Another usability issue is that meson doesn't re-run llvm-config when auto-reconfiguring. Marek On Tue, Feb 5, 2019 at 1:20 PM Marek Olšák wrote: > PKG_CONFIG_PATH still seems to be forgotten by meson. Is there an > alternative? > > Thanks, > Marek > > On Sun, Dec 23, 2018 at 9:32 PM Ilia

Re: [Mesa-dev] [PATCH] anv: wire up the state_pool_padding test

2019-02-05 Thread Dylan Baker
Quoting Emil Velikov (2019-02-05 04:09:45) > From: Emil Velikov > > Cc: Rafael Antognolli > Cc: Jason Ekstrand > Cc: Dylan Baker > Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.") > Signed-off-by: Emil Velikov > --- > src/intel/Makefile.vulkan.am | 5 + > 1 file

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #14 from Ilia Mirkin --- (In reply to andrii simiklit from comment #13) > Thank you) But unfortunately the tests failed so guess I didn't consider > something. I am going to continue my investigation) Did the test actually pass for

[Mesa-dev] [PATCH v3 3/4] radv: keep track of the number of remaining user SGPRs

2019-02-05 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index dbeae2aafde..29300aeab9f 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++

[Mesa-dev] [PATCH v3 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Samuel Pitoiset
This removes some scalar loads from shaders, but it increases the number of SET_SH_REG packets. This is currently basic but it could be improved if needed. Inlining dynamic offsets might also help. Original idea from Dave Airlie. 29077 shaders in 15096 tests Totals: SGPRS: 1321325 -> 1357101

[Mesa-dev] [PATCH v3 2/4] radv: gather if shaders load dynamic offsets separately

2019-02-05 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.h | 1 + src/amd/vulkan/radv_shader_info.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_shader.h b/src/amd/vulkan/radv_shader.h index 92886188459..c194401c02d 100644 --- a/src/amd/vulkan/radv_shader.h

[Mesa-dev] [PATCH v3 1/4] radv: gather more info about push constants

2019-02-05 Thread Samuel Pitoiset
This is needed in order to inline some push constants when possible. This also adds a new helper for initializing the pass. v3: - track if shaders only use 32-bit push constants - compute min/max based on offset and number of components v2: - use MIN2/MAX2 - use UINT8_MAX Signed-off-by:

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #13 from andrii simiklit --- (In reply to Mark Janes from comment #12) > (In reply to asimiklit from comment #11) > > https://mesa-ci.01.org/global_logic/builds/ > > > > It will be "Build # 70" > > > > With this build, i965

Re: [Mesa-dev] [PATCH] panfrost: Use u_pipe_screen_get_param_defaults

2019-02-05 Thread Eric Anholt
Alyssa Rosenzweig writes: > Switching to the defaults function cleans up pan_screen.h markedly and > futureproofs for when new PIPE_CAPs are added. > > Signed-off-by: Alyssa Rosenzweig > --- > src/gallium/drivers/panfrost/pan_screen.c | 157 +- > 1 file changed, 6

Re: [Mesa-dev] [PATCH] kmsro: Move DRM entrypoints to shared block

2019-02-05 Thread Eric Anholt
Alyssa Rosenzweig writes: > As kmsro allows an essentially mix-and-match hodgepodge of display > drivers and renderonly GPUs, it doesn't make sense to couple the display > driver entrypoint definition with the driver. Instead, we move *all* > kmsro entrypoints to a shared kmsro block at the end

[Mesa-dev] [PATCH] dri2: Sync i965_pci_ids.h from mesa

2019-02-05 Thread Rodrigo Vivi
Copied from Mesa with no modifications. I brings new IDs and clean-ups for Kaby Lake, Coffee Lake, Amber Lake, Whiskey Lake and Ice Lake. Sync with Mesa up to commit 56c3b4971d44 '(intel: Add more PCI Device IDs for Coffee Lake and Ice Lake.)' Cc: Kenneth Graunke Cc: Anuj Phogat Cc: Lionel

Re: [Mesa-dev] [PATCH] meson: Remove panfrost from default driver list

2019-02-05 Thread Eric Anholt
Alyssa Rosenzweig writes: > Until the kernel side matures and the full driver is upstreamed, to > avoid end-user surprises, Panfrost should only be built for the > adventurous. > > Signed-off-by: Alyssa Rosenzweig Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Mesa-dev] last call for autotools

2019-02-05 Thread Marek Olšák
PKG_CONFIG_PATH still seems to be forgotten by meson. Is there an alternative? Thanks, Marek On Sun, Dec 23, 2018 at 9:32 PM Ilia Mirkin wrote: > On Wed, Dec 19, 2018 at 1:30 PM Dylan Baker wrote: > > > > Quoting Nicolai Hähnle (2018-12-18 09:37:43) > > > On 17.12.18 23:46, Dylan Baker wrote:

Re: [Mesa-dev] [PATCH] anv: wire up the state_pool_padding test

2019-02-05 Thread Dylan Baker
Quoting Emil Velikov (2019-02-05 04:09:45) > From: Emil Velikov > > Cc: Rafael Antognolli > Cc: Jason Ekstrand > Cc: Dylan Baker > Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.") > Signed-off-by: Emil Velikov > --- > src/intel/Makefile.vulkan.am | 5 + > 1 file

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #12 from Mark Janes --- (In reply to asimiklit from comment #11) > https://mesa-ci.01.org/global_logic/builds/ > > It will be "Build # 70" > With this build, i965 reports test failure instead of assertion (the same status as for

[Mesa-dev] [Bug 108900] Non-recoverable GPU hangs with GfxBench v5 Aztec Ruins Vulkan test

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108900 --- Comment #6 from Eero Tamminen --- Ubuntu 18.04 got LLVM 7 so I checked this again with latest Mesa (4f0a3c9f9eda65), and the hangs are still happening: --- [61150.480135] Iteration 1/1: testfw_app

[Mesa-dev] [Bug 109560] Sometimes VLC player process gets stuck in memory after closure if video output used is Auto or OpenGL

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109560 Bug ID: 109560 Summary: Sometimes VLC player process gets stuck in memory after closure if video output used is Auto or OpenGL Product: Mesa Version: 18.3 Hardware:

Re: [Mesa-dev] [PATCH v2] egl/dri2: try to bind old context if bindContext failed

2019-02-05 Thread Eric Engestrom
On Friday, 2019-02-01 13:36:27 +, Luigi Santivetti wrote: > Before this change, if bindContext() failed then dri2_make_current() would > rebind the old EGL context and surfaces and return EGL_BAD_MATCH. However, > it wouldn't rebind the DRI context and surfaces, thus leaving it in an >

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #11 from asimiklit --- The i965 tests is in progress and result will be appear here (in an hour I think): https://mesa-ci.01.org/global_logic/builds/ It will be "Build # 70" The commit which is under test:

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #10 from Ilia Mirkin --- Does your patch make the test pass on i965? If so, I'll have to figure out where in st/mesa or nouveau it dies. -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #9 from asimiklit --- (In reply to Ilia Mirkin from comment #8) > (In reply to asimiklit from comment #7) > > (In reply to Ilia Mirkin from comment #2) > > > Looks like this is happening in link_uniform_blocks. The type gets > > >

Re: [Mesa-dev] [PATCH] anv: wire up the state_pool_padding test

2019-02-05 Thread Rafael Antognolli
On Tue, Feb 05, 2019 at 12:09:45PM +, Emil Velikov wrote: > From: Emil Velikov > > Cc: Rafael Antognolli > Cc: Jason Ekstrand > Cc: Dylan Baker > Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.") > Signed-off-by: Emil Velikov Reviewed-by: Rafael Antognolli >

Re: [Mesa-dev] [PATCH] egl/dri: de-duplicate dri2_load_driver*

2019-02-05 Thread Frank Binns
Emil Velikov writes: > From: Emil Velikov > > The difference between the tree functions is the list of mandatory s/tree/three/ With that fixed: Reviewed-by: Frank Binns > driver extensions. Pass that as an argument to the common helper. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [Bug 109107] gallium/st/va: change va max_profiles when using Radeon VCN Hardware

2019-02-05 Thread Liu, Leo
I'll take a look and update Bugzilla accordingly. Cheers, Leo On 2/1/19 3:59 PM, Mihai wrote: Hi, I am not sure if this is related with regards to what is causing hardware accelerated decoding on my Raven laptop not to work. Fedora repos: che-mesa, rpmfusion, fedora-rawhide-kernel-nodebug

[Mesa-dev] [PATCH 2/3] egl/sl: use drmDevice API to enumerate available devices

2019-02-05 Thread Emil Velikov
From: Emil Velikov This provides for a more comprehensive iteration and a more straight-forward codebase, while minimising the platform specifics. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 73 +++-- 1 file changed, 37 insertions(+), 36

[Mesa-dev] [PATCH 1/3] egl/sl: split out swrast probe into separate function

2019-02-05 Thread Emil Velikov
From: Emil Velikov Make the code a bit easier to read. As a bonus point this makes it obvious that we forgot to call _eglAddDevice() for the device - do so. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 46 - 1 file changed, 27

[Mesa-dev] [PATCH 3/3] egl/sl: use kms_swrast with vgem instead of a random GPU

2019-02-05 Thread Emil Velikov
From: Emil Velikov VGEM and kms_swrast were introduced to work with one another. All we do is CPU rendering to dumb buffers. There is no reason to carve out GPU memory, increasing the memory pressure on a device that could make a better use of it. For kms_swrast to work properly we require the

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #8 from Ilia Mirkin --- (In reply to asimiklit from comment #7) > (In reply to Ilia Mirkin from comment #2) > > Looks like this is happening in link_uniform_blocks. The type gets updated: > > > > if (b->array != NULL && > >

[Mesa-dev] [PATCH] egl/dri: de-duplicate dri2_load_driver*

2019-02-05 Thread Emil Velikov
From: Emil Velikov The difference between the tree functions is the list of mandatory driver extensions. Pass that as an argument to the common helper. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 45 - 1 file changed, 11 insertions(+), 34

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #7 from asimiklit --- (In reply to Ilia Mirkin from comment #2) > Looks like this is happening in link_uniform_blocks. The type gets updated: > > if (b->array != NULL && >

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_INPUT_COMPONENTS

2019-02-05 Thread Ilia Mirkin
Actually Karol had already done this in a way that I think is better -- by introducing a special PIPE_CAP_MAX_VARYINGS. This patch is withdrawn, I'm going to go with his approach (tonight). On Tue, Feb 5, 2019 at 1:06 AM Ilia Mirkin wrote: > > NVIDIA hardware is weird. The fragment shader allows

[Mesa-dev] [PATCH] nir: compute new range when shrinking push constants loads

2019-02-05 Thread Samuel Pitoiset
RADV will rely on that range for inlining push constants. Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir_opt_shrink_load.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir_opt_shrink_load.c b/src/compiler/nir/nir_opt_shrink_load.c index

Re: [Mesa-dev] [PATCH 4/6] glsl/linker: don't fail non static used inputs without matching outputs

2019-02-05 Thread Andres Gomez
On Fri, 2019-02-01 at 18:37 -0500, Ilia Mirkin wrote: > On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: > > If there is no Static Use of an input variable, the linker shouldn't > > fail whenever there is no defined matching output variable in the > > previous stage. > > > > From page 47 (page

Re: [Mesa-dev] [PATCH] anv: wire up the state_pool_padding test

2019-02-05 Thread Eric Engestrom
On Tuesday, 2019-02-05 12:09:45 +, Emil Velikov wrote: > From: Emil Velikov > > Cc: Rafael Antognolli > Cc: Jason Ekstrand > Cc: Dylan Baker > Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.") > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom > --- >

[Mesa-dev] [PATCH] anv: wire up the state_pool_padding test

2019-02-05 Thread Emil Velikov
From: Emil Velikov Cc: Rafael Antognolli Cc: Jason Ekstrand Cc: Dylan Baker Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.") Signed-off-by: Emil Velikov --- src/intel/Makefile.vulkan.am | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 0/2] Initial Panfrost driver

2019-02-05 Thread Emil Velikov
On Tue, 5 Feb 2019 at 06:29, Alyssa Rosenzweig wrote: > > Hi Emil, > > > As you pointed out, the CS of the driver is not included, so I wonder > > if we cannot add link to instructions in panfrost_create_screen() > > Reading the current fprintf is fairly discouraging. > > The command stream

Re: [Mesa-dev] [PATCH 2/2] panfrost: Include glue for out-of-tree legacy code

2019-02-05 Thread Erik Faye-Lund
On Tue, 2019-02-05 at 06:26 +, Alyssa Rosenzweig wrote: > In addition to the DRM interface in active development, for legacy > kernels Panfrost has a small, optional, out-of-tree glue repository. > For > various reasons, this legacy code should not be included in Mesa > proper, > but this

Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Samuel Pitoiset
On 2/5/19 11:29 AM, Bas Nieuwenhuizen wrote: On Tue, Feb 5, 2019 at 11:07 AM Samuel Pitoiset wrote: On 2/5/19 10:58 AM, Bas Nieuwenhuizen wrote: On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset wrote: This removes some scalar loads from shaders, but it increases the number of SET_SH_REG

Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Bas Nieuwenhuizen
On Tue, Feb 5, 2019 at 11:07 AM Samuel Pitoiset wrote: > > > On 2/5/19 10:58 AM, Bas Nieuwenhuizen wrote: > > On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset > > wrote: > >> This removes some scalar loads from shaders, but it increases > >> the number of SET_SH_REG packets. This is currently

[Mesa-dev] [Bug 109550] [regression][amd tahiti xt][vm fault] Rise of the Tomb Raider hangs the system

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109550 Sylvain BERTRAND changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[Mesa-dev] [Bug 109550] [regression][amd tahiti xt][vm fault] Rise of the Tomb Raider hangs the system

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109550 Sylvain BERTRAND changed: What|Removed |Added Product|Mesa|DRI

Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Samuel Pitoiset
On 2/5/19 10:58 AM, Bas Nieuwenhuizen wrote: On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset wrote: This removes some scalar loads from shaders, but it increases the number of SET_SH_REG packets. This is currently basic but it could be improved if needed. Inlining dynamic offsets might also

Re: [Mesa-dev] [RFC PATCH 4/4] radv: add support for push constants inlining when possible

2019-02-05 Thread Bas Nieuwenhuizen
On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset wrote: > > This removes some scalar loads from shaders, but it increases > the number of SET_SH_REG packets. This is currently basic but > it could be improved if needed. Inlining dynamic offsets might > also help. > > Original idea from Dave

[Mesa-dev] [Bug 109548] Seeing visual corruption in totem after installing amdgpu 18.50 in Ubuntu 18.04.1

2019-02-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109548 Michel Dänzer changed: What|Removed |Added Product|DRI |Mesa Component|DRM/AMDgpu

Re: [Mesa-dev] [PATCH 5/5] radeonsi: use local ws variable in si_need_dma_space

2019-02-05 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 31.01.19 19:56, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_dma_cs.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_dma_cs.c

[Mesa-dev] [PATCH] amd/surface: provide firstMipIdInTail for metadata surface calculations

2019-02-05 Thread Nicolai Hähnle
From: Nicolai Hähnle This field was added in a recent addrlib update, and while there currently seems to be no issue with skipping it, we will have to set it correctly in the future. --- src/amd/common/ac_surface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git