Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Fri, Oct 28, 2016 at 9:59 AM, Tapani Pälli wrote: > On 10/27/2016 09:16 PM, Marek Olšák wrote: >> >> On Fri, Oct 21, 2016 at 5:29 PM, Tapani Pälli >> wrote: >>> >>> On 10/21/2016 04:57 PM, Eero Tamminen wrote: Hi, On

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/27/2016 09:16 PM, Marek Olšák wrote: On Fri, Oct 21, 2016 at 5:29 PM, Tapani Pälli wrote: On 10/21/2016 04:57 PM, Eero Tamminen wrote: Hi, On 21.10.2016 14:07, Tapani Pälli wrote: I did run some valgrind comparisons with gfxbench4, your branch against Mesa

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Fri, Oct 21, 2016 at 5:29 PM, Tapani Pälli wrote: > On 10/21/2016 04:57 PM, Eero Tamminen wrote: >> >> Hi, >> >> On 21.10.2016 14:07, Tapani Pälli wrote: >>> >>> I did run some valgrind comparisons with gfxbench4, your branch against >>> Mesa master. I did not spot

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/21/2016 04:57 PM, Eero Tamminen wrote: Hi, On 21.10.2016 14:07, Tapani Pälli wrote: I did run some valgrind comparisons with gfxbench4, your branch against Mesa master. I did not spot anything obvious related to ralloc. On i965 there's a huge load of invalid writes's and read's in

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

Hi, On 21.10.2016 14:07, Tapani Pälli wrote: I did run some valgrind comparisons with gfxbench4, your branch against Mesa master. I did not spot anything obvious related to ralloc. On i965 there's a huge load of invalid writes's and read's in general but this happens on master as well so maybe

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Oct 21, 2016 1:07 PM, "Tapani Pälli" wrote: > > > > On 10/21/2016 12:51 PM, Marek Olšák wrote: >> >> On Fri, Oct 21, 2016 at 6:58 AM, Tapani Pälli wrote: >>> >>> >>> >>> On 10/20/2016 09:24 PM, Marek Olšák wrote: On Thu, Oct 20,

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/21/2016 12:51 PM, Marek Olšák wrote: On Fri, Oct 21, 2016 at 6:58 AM, Tapani Pälli wrote: On 10/20/2016 09:24 PM, Marek Olšák wrote: On Thu, Oct 20, 2016 at 6:31 PM, Tapani Pälli wrote: On 10/20/2016 06:55 PM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Fri, Oct 21, 2016 at 6:58 AM, Tapani Pälli wrote: > > > On 10/20/2016 09:24 PM, Marek Olšák wrote: >> >> On Thu, Oct 20, 2016 at 6:31 PM, Tapani Pälli >> wrote: >>> >>> On 10/20/2016 06:55 PM, Marek Olšák wrote: On Mon, Oct 17,

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/20/2016 09:24 PM, Marek Olšák wrote: On Thu, Oct 20, 2016 at 6:31 PM, Tapani Pälli wrote: On 10/20/2016 06:55 PM, Marek Olšák wrote: On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: Hi, The latest branch:

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Thu, Oct 20, 2016 at 6:31 PM, Tapani Pälli wrote: > On 10/20/2016 06:55 PM, Marek Olšák wrote: >> >> On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: >>> >>> Hi, >>> >>> The latest branch: >>>

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/20/2016 06:55 PM, Marek Olšák wrote: On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: Hi, The latest branch: https://cgit.freedesktop.org/~mareko/mesa/log/?h=glsl-alloc-rework2 It contains: - all review comments resolved - commits from Tapani's jenkins branch

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Mon, Oct 17, 2016 at 9:03 PM, Marek Olšák wrote: > Hi, > > The latest branch: > https://cgit.freedesktop.org/~mareko/mesa/log/?h=glsl-alloc-rework2 > > It contains: > - all review comments resolved > - commits from Tapani's jenkins branch (fixes for glsl, nir, i965) > > My

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

Hi, The latest branch: https://cgit.freedesktop.org/~mareko/mesa/log/?h=glsl-alloc-rework2 It contains: - all review comments resolved - commits from Tapani's jenkins branch (fixes for glsl, nir, i965) My updated patches are also on the list if you wanna review them. Marek On Thu, Oct 13,

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/13/2016 04:20 PM, Juha-Pekka Heikkila wrote: I forgot to reply here on the list, I've just been talking about this with Tapani face to face. My series rebased and fixed on top of mesa master branch from yesterday is here https://github.com/juhapekka/juha_mesaexperimentals/tree/jenkins

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

I forgot to reply here on the list, I've just been talking about this with Tapani face to face. My series rebased and fixed on top of mesa master branch from yesterday is here https://github.com/juhapekka/juha_mesaexperimentals/tree/jenkins Tapani was already taking rebased patches from

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

Nice work! I sent some comments on patches 6 & 7. Patches 1-4 and 7-15 are Reviewed-by: Nicolai Hähnle assuming you checked them with a Piglit run in addition to the shader-db. Something that LLVM does for its intermediate representations is using Recycler objects.

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Tue, Oct 11, 2016 at 6:54 AM, Tapani Pälli wrote: > > > On 10/10/2016 02:52 PM, Marek Olšák wrote: >> >> I prefer some of my GLSL fixes in 1-4 over JP's changes, because they >> seem cleaner to me. > > > Agreed, I was considering following patches from JP: > >

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/10/2016 02:52 PM, Marek Olšák wrote: I prefer some of my GLSL fixes in 1-4 over JP's changes, because they seem cleaner to me. Agreed, I was considering following patches from JP: https://patchwork.freedesktop.org/patch/93266/ https://patchwork.freedesktop.org/patch/93262/

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

I prefer some of my GLSL fixes in 1-4 over JP's changes, because they seem cleaner to me. Marek On Oct 10, 2016 1:38 PM, "Tapani Pälli" wrote: > > > On 10/10/2016 02:27 PM, Marek Olšák wrote: > >> On Mon, Oct 10, 2016 at 1:25 PM, Tapani Pälli >>

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/10/2016 02:27 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 1:25 PM, Tapani Pälli wrote: On 10/10/2016 01:38 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Mon, Oct 10, 2016 at 1:25 PM, Tapani Pälli wrote: > > > On 10/10/2016 01:38 PM, Marek Olšák wrote: >> >> On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: >>> >>> On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli >>> wrote:

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/10/2016 01:38 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli wrote: On 10/08/2016 06:58 PM, Jason Ekstrand wrote: FYI, we use ralloc for a lot more than just the

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Mon, Oct 10, 2016 at 12:33 PM, Marek Olšák wrote: > On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli wrote: >> >> >> On 10/08/2016 06:58 PM, Jason Ekstrand wrote: >>> >>> FYI, we use ralloc for a lot more than just the glsl compiler so the >>> first few

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Mon, Oct 10, 2016 at 7:58 AM, Tapani Pälli wrote: > > > On 10/08/2016 06:58 PM, Jason Ekstrand wrote: >> >> FYI, we use ralloc for a lot more than just the glsl compiler so the >> first few changes make me a bit nervous. There was someone working on >> making our

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/08/2016 06:58 PM, Jason Ekstrand wrote: FYI, we use ralloc for a lot more than just the glsl compiler so the first few changes make me a bit nervous. There was someone working on making our driver more I undefined-memory-friendly but I don't know what happened to those patches.

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

Hi Marek Series is Tested-by: Edmondo Tommasina I've merged your series of patches on top of mesa git master and tested on a Radeon RX 470. No regressions found. OpenGL renderer string: Gallium 0.4 on AMD POLARIS10 (DRM 3.3.0 / 4.8.0-rc6, LLVM 3.9.0) OpenGL core

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Sat, Oct 8, 2016 at 9:30 AM, Marek Olšák wrote: > On Sat, Oct 8, 2016 at 5:58 PM, Jason Ekstrand > wrote: > > FYI, we use ralloc for a lot more than just the glsl compiler so the > first > > few changes make me a bit nervous. There was someone working

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Sat, Oct 8, 2016 at 5:58 PM, Jason Ekstrand wrote: > FYI, we use ralloc for a lot more than just the glsl compiler so the first > few changes make me a bit nervous. There was someone working on making our > driver more I undefined-memory-friendly but I don't know what

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

FYI, we use ralloc for a lot more than just the glsl compiler so the first few changes make me a bit nervous. There was someone working on making our driver more I undefined-memory-friendly but I don't know what happened to those patches. On Oct 8, 2016 3:58 AM, "Marek Olšák"

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/09/2016 12:14 AM, Marek Olšák wrote: > On Sat, Oct 8, 2016 at 2:48 PM, Edward O'Callaghan > wrote: >> Patches 1-5 are, >> Reviewed-by: Edward O'Callaghan >> >> I think it would be reassuring if you could run a before/after

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On Sat, Oct 8, 2016 at 2:48 PM, Edward O'Callaghan wrote: > Patches 1-5 are, > Reviewed-by: Edward O'Callaghan > > I think it would be reassuring if you could run a before/after complete > piglit run also though if you have not already?

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

Patches 1-5 are, Reviewed-by: Edward O'Callaghan I think it would be reassuring if you could run a before/after complete piglit run also though if you have not already? On 10/08/2016 09:58 PM, Marek Olšák wrote: > Hi, > > This patch series reduces the number of

[Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

Hi, This patch series reduces the number of malloc calls in the GLSL compiler by 63%. That leads to better compile times and less heap thrashing. It's done by switching memory allocations in the GLSL compiler to my new linear allocator that allocates out of a fixed-sized buffer with a