Fixes a memory leak defect reported by Coverity.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
src/mesa/drivers/dri/radeon/radeon_screen.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.c
the critical error would use driverName.
Found by internal RH coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glx/dri_glx.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/glx/dri_glx.c b/src/glx/dri_glx.c
index de777fb..f42db79 100644
---
From: Adrian Marius Negreanu adrian.m.negre...@intel.com
Bison -o parameter expects a .c file.
The corresponding .h filename is obtained
by removing the extension of the initial .c.
This was breaking compilation on Ubuntu 12.04
Reported by coverity scan.
v2: fix second case
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/ir_validate.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp
index af0b576..ad57a31 100644
---
Reported by coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/ir_validate.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp
index af0b576..5ac0ad3 100644
--- a/src/glsl/ir_validate.cpp
+++
On Fri, Nov 30, 2012 at 12:34 AM, Dave Airlie airl...@gmail.com wrote:
Reported by coverity scan.
v2: fix second case
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/ir_validate.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On 11/30/2012 09:52 AM, gro...@gmail.com wrote:
From: Adrian Marius Negreanu adrian.m.negre...@intel.com
Bison -o parameter expects a .c file.
The corresponding .h filename is obtained
by removing the extension of the initial .c.
This was breaking compilation on Ubuntu 12.04
coverity pointed out the below as suspect, since num_iterations = 0,
and we do a loop from 0..0
Dave.
if (FALSE ((util_cpu_caps.has_sse type.width == 32
type.length == 4) ||
(util_cpu_caps.has_avx type.width == 32 type.length == 8))){
const unsigned num_iterations = 0;
Coverity pointed out
src/glsl/loop_analysis.cpp
loop_analysis::loop_analysis()
{
this-loops = new loop_state;
This loops is never freed anywhere, probably need a destructor.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
coverity pointed out this field was being used uninitialised.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/opt_constant_propagation.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/opt_constant_propagation.cpp
b/src/glsl/opt_constant_propagation.cpp
index
Coverity pointed out this uninitialised class member.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/ir_function_detect_recursion.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/ir_function_detect_recursion.cpp
b/src/glsl/ir_function_detect_recursion.cpp
index
Andy Furniss wrote:
Andy Furniss wrote:
Tom Stellard wrote:
On Wed, Nov 07, 2012 at 09:24:13PM +, Andy Furniss wrote:
Vincent Lejeune wrote:
git seems to have trouble sending my patch to ML atm, can you
manually apply it ? It fixes lock up here
diff --git
all unsigneds are = 0 :-)
There may be an argument for leaving this in, in case someone
changes min_lod to an integer, so feel free to apply or drop.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/gallium/drivers/svga/svga_sampler_view.c | 1 -
1 file changed, 1 deletion(-)
diff --git
On Don, 2012-11-29 at 21:58 +0100, Vincent Lejeune wrote:
diff --git a/lib/Target/AMDGPU/R600Instructions.td
b/lib/Target/AMDGPU/R600Instructions.td
index b0c1628..9259680 100644
--- a/lib/Target/AMDGPU/R600Instructions.td
+++ b/lib/Target/AMDGPU/R600Instructions.td
@@ -553,8 +553,8 @@ let
On Don, 2012-11-29 at 08:45 -0800, Tom Stellard wrote:
On Tue, Nov 27, 2012 at 07:55:05PM +0100, Michel Dänzer wrote:
diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c
b/src/gallium/drivers/radeonsi/radeonsi_shader.c
index d6e37ac..d5d56c4 100644
---
On 12-11-23 02:21 PM, Benoit Jacob wrote:
On 12-11-21 12:48 PM, Chad Versace wrote:
On 11/20/2012 09:29 AM, Benoit Jacob wrote:
Any questions?
Do you support or oppose me asking FD.o admins to allow hidden bugs on
Mesa's bugzilla?
Benoit
I support this. It seems a sensible proposal for
Hi Dave,
thanks for pointing it out. The conditional should be:
else if (r300-hyperz_time_of_last_flush 200) {
With that, this is:
Reviewed-by: Marek Olšák mar...@gmail.com
Marek
On Fri, Nov 30, 2012 at 9:28 AM, Dave Airlie airl...@gmail.com wrote:
I haven't confirmed this is doing the
I can see that the security test bug is assigned to mesa-dev by
default, so all comments go to the mailing list. I don't thínk that's
desirable.
Marek
On Fri, Nov 30, 2012 at 1:43 PM, Benoit Jacob bja...@mozilla.com wrote:
On 12-11-23 02:21 PM, Benoit Jacob wrote:
On 12-11-21 12:48 PM, Chad
https://bugs.freedesktop.org/show_bug.cgi?id=57733
Priority: medium
Group: Mesa Security
Bug ID: 57733
CC: bri...@vmware.com, jfons...@vmware.com
Assignee: mesa-dev@lists.freedesktop.org
Summary: read-after-free with llvmpipe
Aaargh
On 12-11-30 07:55 AM, Marek Olšák wrote:
I can see that the security test bug is assigned to mesa-dev by
default, so all comments go to the mailing list. I don't thínk that's
desirable.
Marek
On Fri, Nov 30, 2012 at 1:43 PM, Benoit Jacob bja...@mozilla.com wrote:
On
On Fri, Nov 30, 2012 at 2:48 AM, Dave Airlie airl...@gmail.com wrote:
the critical error would use driverName.
Found by internal RH coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
Reviewed-by: Alex Deucher alexander.deuc...@amd.com
---
src/glx/dri_glx.c | 5 -
1 file
On 11/30/2012 07:21 AM, Alex Deucher wrote:
On Fri, Nov 30, 2012 at 2:48 AM, Dave Airlieairl...@gmail.com wrote:
the critical error would use driverName.
Found by internal RH coverity scan.
Signed-off-by: Dave Airlieairl...@redhat.com
Reviewed-by: Alex Deucheralexander.deuc...@amd.com
On 11/30/2012 03:05 AM, Dave Airlie wrote:
all unsigneds are= 0 :-)
There may be an argument for leaving this in, in case someone
changes min_lod to an integer, so feel free to apply or drop.
Signed-off-by: Dave Airlieairl...@redhat.com
---
src/gallium/drivers/svga/svga_sampler_view.c | 1 -
On 11/30/2012 03:10 AM, Dave Airlie wrote:
coverity pointed out the below as suspect, since num_iterations = 0,
and we do a loop from 0..0
Dave.
if (FALSE ((util_cpu_caps.has_sse type.width == 32
type.length == 4) ||
(util_cpu_caps.has_avx type.width == 32 type.length == 8))){
On 11/30/2012 03:25 AM, Dave Airlie wrote:
coverity pointed out this field was being used uninitialised.
Signed-off-by: Dave Airlieairl...@redhat.com
---
src/glsl/opt_constant_propagation.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/opt_constant_propagation.cpp
On 11/30/2012 12:25 AM, Vinson Lee wrote:
Fixes a memory leak defect reported by Coverity.
Signed-off-by: Vinson Leev...@freedesktop.org
---
src/mesa/drivers/dri/radeon/radeon_screen.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
- Original Message -
On 11/30/2012 03:10 AM, Dave Airlie wrote:
coverity pointed out the below as suspect, since num_iterations =
0,
and we do a loop from 0..0
Dave.
if (FALSE ((util_cpu_caps.has_sse type.width == 32
type.length == 4) ||
We used to invalidate the drawable after a call to eglSwapBuffers(),
so that a wl_egl_window_resize() would take effect for the next frame.
However, that leads to calling dri2_get_buffers() when eglMakeCurrent()
is called with the current context and surface, and a later call to
On Fri, Nov 30, 2012 at 05:41:02PM +0200, Ander Conselvan de Oliveira wrote:
We used to invalidate the drawable after a call to eglSwapBuffers(),
so that a wl_egl_window_resize() would take effect for the next frame.
However, that leads to calling dri2_get_buffers() when eglMakeCurrent()
is
On Thu, Nov 29, 2012 at 11:48:39PM +0100, Vincent Lejeune wrote:
---
src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
Reviewed-by: Tom Stellard thomas.stell...@amd.com
diff --git
On Thu, Nov 29, 2012 at 11:50:22PM +0100, Vincent Lejeune wrote:
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 24
++
1 file changed, 24 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c
On Thu, Nov 29, 2012 at 11:50:23PM +0100, Vincent Lejeune wrote:
---
src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Tom Stellard thomas.stell...@amd.com
diff --git
On Thu, Nov 29, 2012 at 11:51:32PM +0100, Vincent Lejeune wrote:
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 31
++
1 file changed, 31 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c
On Thu, Nov 29, 2012 at 11:51:33PM +0100, Vincent Lejeune wrote:
---
src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 4
1 file changed, 4 deletions(-)
I think it would be good to replace the MIN/MAX patterns in
{R600,SI}Instructions.td to match LLVM IR rather than the
old
On Thu, Nov 29, 2012 at 09:58:40PM +0100, Vincent Lejeune wrote:
---
lib/Target/AMDGPU/R600Instructions.td | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Target/AMDGPU/R600Instructions.td
b/lib/Target/AMDGPU/R600Instructions.td
index 9259680..d75c32e 100644
On Fri, Nov 30, 2012 at 7:43 AM, Benoit Jacob bja...@mozilla.com wrote:
On 12-11-23 02:21 PM, Benoit Jacob wrote:
On 12-11-21 12:48 PM, Chad Versace wrote:
On 11/20/2012 09:29 AM, Benoit Jacob wrote:
Any questions?
Do you support or oppose me asking FD.o admins to allow hidden bugs on
On Wed, Nov 28, 2012 at 07:50:02PM +0100, Andreas Boll wrote:
2012/11/28 Michel Dänzer mic...@daenzer.net:
On Fre, 2012-11-23 at 22:23 +0100, Andreas Boll wrote:
Please help Matt and me to test the automake-gallium4 branch [1] !
Here you have a list of things you could test:
[...]
-
From: José Fonseca jfons...@vmware.com
The fs shader now depends on the color buffer formats. The shader key was
extended to accommodate this, but llvmpipe_update_derived needs to be
updated to check the framebuffer dirty flag.
This fixes bug 57674.
---
From: José Fonseca jfons...@vmware.com
Tell LLVM the exact alignment we can guarantee, based on the fs block
dimensions, pixel format, and the alignment of the resource base pointer
and stride.
---
src/gallium/drivers/llvmpipe/lp_state_fs.c | 31 +++-
1 file changed, 21
https://bugs.freedesktop.org/show_bug.cgi?id=57241
--- Comment #8 from Ian Romanick i...@freedesktop.org ---
(In reply to comment #7)
This is not a bug. Failing to create a forward compatible context is allowed
by the specification.
Right... which is why I changed the subject and changed the
On 11/30/2012 12:34 AM, Dave Airlie wrote:
Reported by coverity scan.
v2: fix second case
Signed-off-by: Dave Airlie airl...@redhat.com
This should also go into stable branches. It should only affect debug
builds.
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
On 11/29/2012 11:52 PM, gro...@gmail.com wrote:
From: Adrian Marius Negreanu adrian.m.negre...@intel.com
Bison -o parameter expects a .c file.
The corresponding .h filename is obtained
by removing the extension of the initial .c.
This was breaking compilation on Ubuntu 12.04
On 11/28/2012 04:32 PM, Marek Olšák wrote:
On Thu, Nov 29, 2012 at 1:23 AM, Ian Romanick i...@freedesktop.org wrote:
On 11/28/2012 10:07 AM, Marek Olšák wrote:
It looks reasonable enough, but... why? Is there a follow-up patch that
uses it them in some other file?
Brian suggested it just in
From: Paul Berry stereotype...@gmail.com
Adding this now makes it easier to develop and test GLES3 features, since we
can do initial development and testing using desktop GL. Later GLSL compiler
patches check for either ctx-Extensions.ARB_ES3_compatibility or
_mesa_is_gles3 to allow certain
From: Paul Berry stereotype...@gmail.com
Previously, we stored the GLSL language version in the
glsl_symbol_table struct. But this was unnecessary--all
glsl_symbol_table needs to know is whether functions and variables
have separate namespaces (they do in GLSL 1.10 only).
Reviewed-by: Ian
From: Paul Berry stereotype...@gmail.com
Fixes a bug where version_string would be left uninitialized if no
GLSL #version directive was used.
---
src/glsl/ast_to_hir.cpp | 6 +++---
src/glsl/glsl_parser.yy | 13 +
src/glsl/glsl_parser_extras.h | 11 ++-
3 files
From: Paul Berry stereotype...@gmail.com
This will be useful in generating more helpful error messages,
especially with the addition of GLSL 3.00 ES support.
[v2, idr]: Rename ctx parameter to mem_ctx
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/glsl_parser.yy | 6
From: Paul Berry stereotype...@gmail.com
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/ast_function.cpp | 2 +-
src/glsl/ast_to_hir.cpp | 40 ++--
src/glsl/glsl_lexer.ll| 4 ++--
src/glsl/glsl_parser.yy | 5 +++--
From: Paul Berry stereotype...@gmail.com
Previous to this patch, we were not very consistent about the errors
we generate when a shader tried to use a feature that is prohibited in
the current GLSL version. Some error messages failed to mention the
GLSL version currently in use (or did so
From: Paul Berry stereotype...@gmail.com
This patch expands the lexer KEYWORD macro to take two additional
arguments: the GLSL ES versions in which the given keyword was first
reserved, and supported, respectively. This will allow us to
trivially add support for GLSL 3.00 ES keywords, even
From: Paul Berry stereotype...@gmail.com
GLSL ES 3.00 adds the following keywords over GLSL 1.00: uint,
uvec[2-4], matNxM, centroid, flat, smooth, various samplers, layout,
switch, default, and case.
Additionally, it reserves a large number of keywords, some of which
were already reserved in
From: Paul Berry stereotype...@gmail.com
Version directive handling is going to have to be used within two
parser rules, one for desktop-style version directives (e.g. #version
130) and one for the new ES-style version directive (e.g. #version
300 es), so this patch moves it to a function that
From: Paul Berry stereotype...@gmail.com
This patch turns on the following features for GLSL ES 3.00:
- Array constructors, whole array assignment, and array comparisons.
- Second and third operands of ?: may be arrays.
- Use of in and out qualifiers on globals.
- Bitwise and modulus operators.
From: Paul Berry stereotype...@gmail.com
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/glcpp/glcpp-parse.y | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y
index
From: Paul Berry stereotype...@gmail.com
Version directive handling is going to have to be used within two
parser rules, one for desktop-style version directives (e.g. #version
130) and one for the new ES-style version directive (e.g. #version
300 es), so this patch moves it to a function that
From: Paul Berry stereotype...@gmail.com
Previously we recorded just the GLSL version, with the knowledge that
100 means GLSL 1.00 ES. With the advent of GLSL 3.00 ES, this is
going to get more complex, and eventually will probably become
ambiguous (GLSL 4.00 already exists, and GLSL 4.00 ES is
From: Paul Berry stereotype...@gmail.com
Note that GLSL 1.00 is selected using #version 100, so #version 100
es is prohibited.
v2: Check for GLES3 before allowing '#version 300 es'
Signed-off-by: Paul Berry stereotype...@gmail.com
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
---
From: Paul Berry stereotype...@gmail.com
Previously, we prohibited mixing of shading language versions if
min_version == 100 or max_version = 130. This was technically
correct (since desktop GLSL 1.30 and beyond prohibit mixing of shading
language versions, as does GLSL 1.00 ES), but it was
From: Paul Berry stereotype...@gmail.com
Previously we recorded just the GLSL version (or the max version, if
GLSL 1.10 and GLSL 1.20 programs were linked together).
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/linker.cpp| 1 +
src/mesa/main/mtypes.h | 1 +
2 files
From: Paul Berry stereotype...@gmail.com
With the advent of GLSL 3.00 ES, the version checks we perform in the
GLSL compiler (to determine which language features are present) will
become more complicated. To reduce the complexity, this patch adds
functions check_version() and is_version() to
From: Paul Berry stereotype...@gmail.com
This patch updates the following linker checks to do the right thing
in GLSL 3.00 ES:
- Failing to write to gl_Position is allowed in GLSL 1.40+ as well as
GLSL 3.00 ES.
- It is an error to write to both gl_ClipVertex and gl_ClipDistance in
GLSL
From: Paul Berry stereotype...@gmail.com
These constants need to be made available to shaders in GLSL 3.00 ES.
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/glsl_parser_extras.cpp | 2 ++
src/glsl/glsl_parser_extras.h | 4
2 files changed, 6 insertions(+)
diff --git
From: Paul Berry stereotype...@gmail.com
This patch also adds assertions so that when we add new GLSL versions,
we'll notice that we need to update the builtin variables.
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/builtin_variables.cpp | 193
From: Paul Berry stereotype...@gmail.com
This patch implements all of the built-in types for GLSL 3.00 ES.
This is almost exactly the same as the set of built-in types for GLSL
1.30, except ate 1D samplers are skipped, and samplerCubeShadow is
added.
This patch also addes an assertion so that
From: Paul Berry stereotype...@gmail.com
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/builtins/profiles/100.frag | 6 -
src/glsl/builtins/profiles/100.glsl | 296 ---
src/glsl/builtins/profiles/100.vert | 6 -
From: Paul Berry stereotype...@gmail.com
Nearly all of the builtin functions in GLSL 3.00 ES are already
implemented in Mesa; this patch enables them.
A few functions are not implemented yet; those have been commented
out, with a FIXME comment to act as a reminder of what still needs to
be
From: Paul Berry stereotype...@gmail.com
These functions are defined in GLSL 1.50 and GLES 3.00 ES.
The formulas have been extracted from the existing implementation of
inverse().
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
src/glsl/builtins/glsl/determinant.glsl | 70
From: Kenneth Graunke kenn...@whitecape.org
Fixes es3conform's explicit_attrib_location_integer_constants.
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
Reviewed-by: Eric Anholt e...@anholt.net
---
src/glsl/glsl_parser.yy | 1 +
1 file changed, 1 insertion(+)
diff --git
From: Ian Romanick ian.d.roman...@intel.com
Note that while 'packed' is a reserved word in GLSL ES, row_major is not.
This means that we have to use the string-based matching for that.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
---
From: José Fonseca jfons...@vmware.com
This fixes the Source and destination overlap in memcpy valgrind
warnings.
---
src/gallium/drivers/llvmpipe/lp_state_fs.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c
On 11/30/2012 02:20 AM, Dave Airlie wrote:
Coverity pointed out
src/glsl/loop_analysis.cpp
loop_analysis::loop_analysis()
{
this-loops = new loop_state;
This loops is never freed anywhere, probably need a destructor.
Aw crap. Could you submit a bug for that, and assign it to me?
We sometimes need a rendering context when deleting renderbuffers.
Pass it explicitly instead of trying to grab a current context
(which might be NULL). The next patch will make use of this.
Note: this is a candidate for the stable branches.
---
src/mesa/drivers/dri/intel/intel_fbo.c |4
To fix a pipe_context::surface_destroy() use-after-free problem.
We previously added pipe_sampler_view_release() for similar reasons.
Note: this is a candidate for the stable branches.
---
src/gallium/auxiliary/util/u_inlines.h | 16
1 files changed, 16 insertions(+), 0
The use-after-free happened when the renderbuffer was shared by multiple
contexts and we tried to delete the renderbuffer using a context which
was previously deleted.
Note: this is a candidate for the stable branches.
---
src/mesa/state_tracker/st_cb_fbo.c |8 +---
1 files changed, 5
Am 30.11.2012 18:43, schrieb jfons...@vmware.com:
From: José Fonseca jfons...@vmware.com
Tell LLVM the exact alignment we can guarantee, based on the fs block
dimensions, pixel format, and the alignment of the resource base pointer
and stride.
---
Such as:
#line 23 foo.c
Having a filename here is quite useful and many other OpenGL implementations
allow this.
Note that for GLES we take the hard line and insist on a numeric source string
number as per the specification and which glcpp has always supported:
#line 23 3
---
Am 30.11.2012 19:08, schrieb jfons...@vmware.com:
From: José Fonseca jfons...@vmware.com
This fixes the Source and destination overlap in memcpy valgrind
warnings.
---
src/gallium/drivers/llvmpipe/lp_state_fs.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
On Fri, Nov 30, 2012 at 11:07:09AM -0500, Kristian Høgsberg wrote:
On Fri, Nov 30, 2012 at 05:41:02PM +0200, Ander Conselvan de Oliveira wrote:
We used to invalidate the drawable after a call to eglSwapBuffers(),
so that a wl_egl_window_resize() would take effect for the next frame.
- Original Message -
Am 30.11.2012 18:43, schrieb jfons...@vmware.com:
From: José Fonseca jfons...@vmware.com
Tell LLVM the exact alignment we can guarantee, based on the fs
block
dimensions, pixel format, and the alignment of the resource base
pointer
and stride.
---
Series looks good to me.
Jose
- Original Message -
The use-after-free happened when the renderbuffer was shared by
multiple
contexts and we tried to delete the renderbuffer using a context
which
was previously deleted.
Note: this is a candidate for the stable branches.
---
---
src/mesa/main/teximage.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 347b3e2..6401824 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -1949,7 +1949,8 @@ texture_error_check(
On Fri, Nov 30, 2012 at 11:26 AM, Matt Turner matts...@gmail.com wrote:
---
src/mesa/main/teximage.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 347b3e2..6401824 100644
---
From: Roland Scheidegger srol...@vmware.com
The border clamping code is unnecessary, since we don't care if a wrapped
coord value is -1 or -1 (same for length vs. length), in either case the
border handling code will mask out the offset and replace the texel value with
the border color.
Note that
From: Paul Berry stereotype...@gmail.com
Note that GLSL 1.00 is selected using #version 100, so #version 100
es is prohibited.
v2: Check for GLES3 before allowing '#version 300 es'
v3: Make sure a correct language_version is set in
_mesa_glsl_parse_state::process_version_directive.
On 11/30/2012 12:26 PM, Matt Turner wrote:
---
src/mesa/main/teximage.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 347b3e2..6401824 100644
--- a/src/mesa/main/teximage.c
+++
This represents a rebase of the gles3 branch that moves the completed
GLSL to be first. I'd like to get these bits merged to master sooner
rather than later. Once these bits land, I'll rebase and send out the
next logical block.
I have also pushed this branch to the gles3 branch of my
On 12-11-30 12:13 PM, Jerome Glisse wrote:
On Fri, Nov 30, 2012 at 7:43 AM, Benoit Jacob bja...@mozilla.com wrote:
On 12-11-23 02:21 PM, Benoit Jacob wrote:
On 12-11-21 12:48 PM, Chad Versace wrote:
On 11/20/2012 09:29 AM, Benoit Jacob wrote:
Any questions?
Do you support or oppose me
---
src/mesa/drivers/dri/i965/brw_vec4_emit.cpp |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
index 12694e2..5637b22 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
+++
After walking our IR instructions (Mesa or GLSL), we don't want to also
mark the start of the FB/URB writes or whatever as being that IR. This
can end up being misleading when the end of the IR visit got copy
propagated out to a later instruction in the URB writes.
---
The VP generation doesn't set up the output reg strings, so if you
didn't happen to get these values as 0 on the stack, you'd lose.
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
In the VS case, we were missing the entire compile time in the stall
detection!
---
src/mesa/drivers/dri/i965/brw_fs.cpp |9 ++---
src/mesa/drivers/dri/i965/brw_vec4.cpp | 21 -
2 files changed, 18 insertions(+), 12 deletions(-)
diff --git
For getting values from the new timestamp register, the channels we
load have nothing to do with the pixels dispatched.
---
src/mesa/drivers/dri/i965/brw_fs.h |1 +
src/mesa/drivers/dri/i965/brw_fs_emit.cpp |1 +
src/mesa/drivers/dri/i965/brw_vec4.h|1 +
This can be used for two purposes: Using hand-coded shaders to determine
per-instruction timings, or figuring out which shader to optimize in a
whole application. On the psychonauts trace, we see:
type ID cycles spent % of total
...
fs16 543: 339343898369 ( 339.34
On Sat, Dec 1, 2012 at 3:43 AM, jfons...@vmware.com wrote:
From: José Fonseca jfons...@vmware.com
The fs shader now depends on the color buffer formats. The shader key was
extended to accommodate this, but llvmpipe_update_derived needs to be
updated to check the framebuffer dirty flag.
On 30 November 2012 12:11, Ian Romanick i...@freedesktop.org wrote:
This represents a rebase of the gles3 branch that moves the completed GLSL
to be first. I'd like to get these bits merged to master sooner rather
than later. Once these bits land, I'll rebase and send out the next
logical
https://bugs.freedesktop.org/show_bug.cgi?id=57746
Priority: medium
Bug ID: 57746
Assignee: mesa-dev@lists.freedesktop.org
Summary: build test failure: nouveau_fbo.c:198:3: error: too
few arguments to function
https://bugs.freedesktop.org/show_bug.cgi?id=57746
Darxus dar...@chaosreigns.com changed:
What|Removed |Added
CC||dar...@chaosreigns.com
On 30 November 2012 11:52, Ian Romanick i...@freedesktop.org wrote:
From: Paul Berry stereotype...@gmail.com
Note that GLSL 1.00 is selected using #version 100, so #version 100
es is prohibited.
v2: Check for GLES3 before allowing '#version 300 es'
v3: Make sure a correct language_version
On 11/29/2012 03:44 PM, Carl Worth wrote:
Previously, we were only supporting line-continuation backslash characters
within lines of pre-processor directives, (as per the specification). With
OpenGL 4.3, line continuations are now supported anywhere within a shader.
OpenGL 4.2, actually.
I'm
The mixing of the factoring out of the protocol bits with the flush
change in this commit is irritating, but I'm fine with the overall flush
interface of this series for the current loader implementation.
Long term, I think for what you're working towards you'll want the
dispatch threading that
1 - 100 of 116 matches
Mail list logo
