Re: [Mesa-dev] [PATCH 7/7] i965: Drop non-LLC lunacy in the program cache code.

2017-07-24 Thread Emil Velikov
On 24 July 2017 at 15:51, Kenneth Graunke wrote: > On Monday, July 24, 2017 3:54:11 AM PDT Emil Velikov wrote: >> Hi Ken, >> >> Admittedly I'm not an expert in the area, so perhaps a rather silly question. >> >> On 22 July 2017 at 00:17, Kenneth Graunke

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 Yurii Kolesnykov changed: What|Removed |Added CC|

Re: [Mesa-dev] 10bit output via KMS

2017-07-24 Thread Daniel Stone
Hi Volker, On 24 July 2017 at 14:56, Volker Vogelhuber wrote: > thanks for the feedback. The patch was not meant to be submitted > officially. I'm aware that extending official > EGL extensions is not allowed. It was just for showing what I have > changed to get

[Mesa-dev] [PATCH v2 2/2] st/dri2: Return invalid modifier when no driver support

2017-07-24 Thread Daniel Stone
Always initialise whandle.modifier for DRIImage modifier queries, so if the driver doesn't support it then we return false for the query. Signed-off-by: Daniel Stone Cc: Varad Gautam Fixes: d33fe8b84e45 ("st/dri: enable DRIimage modifier

[Mesa-dev] [PATCH v2 1/2] st/dri: Check get-handle return value in queryImage

2017-07-24 Thread Daniel Stone
In the DRIImage queryImage hook, check if resource_get_handle() failed and return FALSE if so. Signed-off-by: Daniel Stone --- src/gallium/state_trackers/dri/dri2.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] 10bit output via KMS

2017-07-24 Thread Emil Velikov
[dropping dri-devel, adding mesa-dev] Hi Volker, Thanks for giving this a stab. Mesa it has it's own mailing list, take a look at the instruction for more details [1]. On 24 July 2017 at 13:34, Volker Vogelhuber wrote: > I have implemented a display manager

Re: [Mesa-dev] Call for community testing: OpenGL multithreading is ready

2017-07-24 Thread Laurent Carlier
Le mardi 18 juillet 2017, 22:57:13 CEST siyia a écrit : > > > start.sh > > > > ~30% perfomance increase > > name= siyia > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org >

Re: [Mesa-dev] [PATCH] trace: Correct transfer box size calculation.

2017-07-24 Thread Jose Fonseca
> This shouldn't be an issue, since buffers are required to have a 1-byte format Ah OK. I was no longer sure. In that case, I can leave the single code path and put an assert as you suggested. Jose From: Roland Scheidegger Sent: Monday, July 24, 2017 16:22

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

2017-07-24 Thread Jose Fonseca
Hi Bruce, Sorry for the delay. I finally had a bit of time to take a look at your original patch on https://lists.freedesktop.org/archives/mesa-dev/2017-February/142817.html , and it's definitely an improvement. But a more straightforward way to do this is to, rather than adjusting for

Re: [Mesa-dev] [PATCH 2/3] st/dri2: Return invalid modifier when no driver support

2017-07-24 Thread Daniel Stone
On 24 July 2017 at 13:09, Emil Velikov wrote: > On 24 July 2017 at 12:44, Daniel Stone wrote: >>> AFAICT that will make the check in 1/3 unreachable, yet still nice to have. >> >> I don't really see how? 1/3 is for when we have zwp_linux_dmabuf_v1

Re: [Mesa-dev] 10bit output via KMS

2017-07-24 Thread Volker Vogelhuber
Hi Emil, thanks for the feedback. The patch was not meant to be submitted officially. I'm aware that extending official EGL extensions is not allowed. It was just for showing what I have changed to get 10bit FBOs exported from Mesa, otherwise it would probably not possible to have a render

Re: [Mesa-dev] [PATCH 7/7] i965: Drop non-LLC lunacy in the program cache code.

2017-07-24 Thread Kenneth Graunke
On Monday, July 24, 2017 3:54:11 AM PDT Emil Velikov wrote: > Hi Ken, > > Admittedly I'm not an expert in the area, so perhaps a rather silly question. > > On 22 July 2017 at 00:17, Kenneth Graunke wrote: > > > +#ifdef USE_SSE41 > > + if (!cache->bo->cache_coherent

[Mesa-dev] [ANNOUNCE] mesa 17.2.0-rc1

2017-07-24 Thread Emil Velikov
The first release candidate for Mesa 17.2.0 is now available. The plan is to have one release candidate every Friday, until the final release on 5th August 2017. The expectation is that the 17.1 branch will remain alive with bi-weekly releases until the 17.2.1 release. Note: There has been a

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- Comment #6 from James Legg --- Unfortunately, I've been unable to reproduce the bug while replaying a trace captured with apitrace (the bug occurs while capturing however). Capturing traces from builds of recent

Re: [Mesa-dev] [PATCH] trace: Correct transfer box size calculation.

2017-07-24 Thread Roland Scheidegger
Am 24.07.2017 um 15:26 schrieb Jose Fonseca: > In particular: > > 1) For buffers the box expresses bytes, not pixels. This shouldn't be an issue, since buffers are required to have a 1-byte format (usually R8_UINT, but R8_UNORM works too). (llvmpipe_transfer_map, for instance, will still do all

Re: [Mesa-dev] [PATCH] i965: perf: minimize the chances to spread queries across batchbuffers

2017-07-24 Thread Lionel Landwerlin
Hi, I would like to nominate this commit for 17.1. It can be found as commit adafe4b733c0242720ccfe10d391e5d44c0e7401 in the master branch (I believe it's alreadyin 17.2). Thanks, - Lionel On 22/06/17 02:25, Lionel Landwerlin wrote: Counter related to timings will be sensitive to any delay

Re: [Mesa-dev] [PATCH] i965: perf: minimize the chances to spread queries across batchbuffers

2017-07-24 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-06-22 02:25:28) > Counter related to timings will be sensitive to any delay introduced > by the software. In particular if our begin & end of performance > queries end up in different batches, time related counters will > exhibit biffer values caused by the time it

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 Christoph Berliner changed: What|Removed |Added CC|

[Mesa-dev] [Bug 101876] SIGSEGV when launching Steam

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101876 Christoph Berliner changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] trace: Correct transfer box size calculation.

2017-07-24 Thread Cherniak, Bruce
> On Jul 24, 2017, at 10:22 AM, Roland Scheidegger wrote: > > Am 24.07.2017 um 15:26 schrieb Jose Fonseca: >> In particular: >> >> 1) For buffers the box expresses bytes, not pixels. > This shouldn't be an issue, since buffers are required to have a 1-byte > format (usually

Re: [Mesa-dev] [PATCH] i965: perf: minimize the chances to spread queries across batchbuffers

2017-07-24 Thread Lionel Landwerlin
On 24/07/17 16:55, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-06-22 02:25:28) Counter related to timings will be sensitive to any delay introduced by the software. In particular if our begin & end of performance queries end up in different batches, time related counters will exhibit

Re: [Mesa-dev] [PATCH 2/2] svga: implement MSAA alpha_to_one feature

2017-07-24 Thread Brian Paul
On 07/24/2017 11:05 AM, Charmaine Lee wrote: From: Brian Paul Sent: Saturday, July 22, 2017 12:24 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] svga: implement MSAA alpha_to_one feature The device doesn't directly support this

Re: [Mesa-dev] [PATCH] radv: check enabled device features.

2017-07-24 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Jul 24, 2017 at 8:18 AM, Dave Airlie wrote: > From: Dave Airlie > > The spec says we should return VK_ERROR_FEATURE_NOT_PRESENT. > > Ported from anv. > > Fixes CTS test

[Mesa-dev] [PATCH] radv: check enabled device features.

2017-07-24 Thread Dave Airlie
From: Dave Airlie The spec says we should return VK_ERROR_FEATURE_NOT_PRESENT. Ported from anv. Fixes CTS test dEQP-VK.api.device_init.create_device_unsupported_features Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 13 + 1

Re: [Mesa-dev] [PATCH] radv: allow buffers to be shareable as well.

2017-07-24 Thread Bas Nieuwenhuizen
On Mon, Jul 24, 2017 at 5:03 AM, Dave Airlie wrote: > From: Dave Airlie > > Buffers should report dedicated flags as well, so report the > same information for them as for images. > > (alternately we can turn dedicated off for buffers maybe?) > > Fixes CTS

Re: [Mesa-dev] [PATCH] radv: for external memory imports close the fd on import success

2017-07-24 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Jul 24, 2017 at 4:51 AM, Dave Airlie wrote: > From: Dave Airlie > > If we get an fd, we need to close it before returning. > > Fixes CTS test >

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-24 Thread Charmaine Lee
Hi Marek, I have pushed the fix for Steam. Commit bbc29393d3beaf6344c7188547b4ff61b63946ae should fix the problem. Can you please try? -Charmaine From: Marek Olšák Sent: Monday, July 24, 2017 3:16:07 PM To: Charmaine Lee Cc: Christoph

[Mesa-dev] [Bug 101876] SIGSEGV when launching Steam

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101876 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-24 Thread Marek Olšák
Hi Charmaine, Which commits do I need to revert in 17.2 to unbreak Steam on Mesa? I guess it's more than one. Thanks, Marek On Sat, Jul 22, 2017 at 3:05 AM, Charmaine Lee wrote: > > Hi Christoph, > > Can you provide an apitrace of the test that crashes? > > Thanks. >

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-24 Thread Marek Olšák
On Tue, Jul 25, 2017 at 12:20 AM, Charmaine Lee wrote: > > Hi Marek, > > I have pushed the fix for Steam. Commit > bbc29393d3beaf6344c7188547b4ff61b63946ae > should fix the problem. Can you please try? Thanks. Steam is working fine now. Marek

Re: [Mesa-dev] [PATCH 2/2] svga: implement MSAA alpha_to_one feature

2017-07-24 Thread Charmaine Lee
>From: Brian Paul >Sent: Saturday, July 22, 2017 12:24 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende >Subject: [PATCH 2/2] svga: implement MSAA alpha_to_one feature >The device doesn't directly support this feature so we implement it with >additional

Re: [Mesa-dev] AMD Tahiti: A question about PFP firmware

2017-07-24 Thread Nicolai Hähnle
Follow-up question: Could you try to just disable the check and see whether the piglit arb_draw_indirect tests work? Cheers, Nicolai On 24.07.2017 19:03, Nicolai Hähnle wrote: On 22.07.2017 16:57, Gustaw Smolarczyk wrote: Hello, While looking at the extension list on my Tahiti GPU (SI) I

Re: [Mesa-dev] AMD Tahiti: A question about PFP firmware

2017-07-24 Thread Nicolai Hähnle
On 22.07.2017 16:57, Gustaw Smolarczyk wrote: Hello, While looking at the extension list on my Tahiti GPU (SI) I have found that ARB_draw_parameters is missing. Looking at the code, it requires ME firmware version >= 87 and PFP firmware version >= 121. While the first is satisfied, the second

Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

2017-07-24 Thread Nicolai Hähnle
On 23.07.2017 18:24, Mystro256 wrote: --- src/amd/addrlib/core/addrobject.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/addrlib/core/addrobject.cpp b/src/amd/addrlib/core/addrobject.cpp index dcdb1bf..ee2d9a9 100644 ---

Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

2017-07-24 Thread Jeremy Newton
Fair enough. Although from my tests with x86-64 GCC 6.3 (Fedora 25), it did produce a slightly smaller binary with this patch. With that said, I only used whatever the default optimization flags are, and I didn't do a diff on a disasm to see what actually changed. On Mon, Jul 24, 2017 at 1:03

Re: [Mesa-dev] [PATCH 5/6] radeonsi: use slot indexes for bindless handles

2017-07-24 Thread Marek Olšák
Some additional notes: 1) si_release_bindless_descriptors can be inlined. 2) Sampler slots have size = 16*4 and image slots have size = 8*4 in your patch. The addressing is also done with a multiple of the size, which allows creating a sampler and an image in the same slot such that one of them

[Mesa-dev] [PATCH] radeon/vcn: move message buffer to vram for now

2017-07-24 Thread Leo Liu
To workaround an unknown bug. Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers/radeon/radeon_vcn_dec.c index

Re: [Mesa-dev] AMD Tahiti: A question about PFP firmware

2017-07-24 Thread Gustaw Smolarczyk
$ ./piglit run gpu -t arb_draw_indirect results/indirect --dmesg [12/12] pass: 11, fail: 1 Thank you for running Piglit! Results have been written to /home/bigos/src/piglit/results/indirect The only one failing is spec/arb_draw_indirect/arb_draw_indirect-draw-arrays-prim-restart. However, it is

Re: [Mesa-dev] [PATCH] radv: fix buffer views on SI/CIK.

2017-07-24 Thread Bas Nieuwenhuizen
On Mon, Jul 24, 2017 at 12:44 PM, Dave Airlie wrote: > From: Dave Airlie > > Fixes CTS dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.1024 > on SI/CIK with radv. > > Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) >

Re: [Mesa-dev] [PATCH 1/3] gallium/util: fix unused variable warning

2017-07-24 Thread Timothy Arceri
Ping on this series :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 055/101] mesa: add KHR_no_error support to glBindTextures()

2017-07-24 Thread Timothy Arceri
44-55: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101709 Vinson Lee changed: What|Removed |Added Version|git |17.2 -- You are

Re: [Mesa-dev] [PATCH 5/5] i965/clear: Don't perform redundant depth clears

2017-07-24 Thread Kenneth Graunke
On Sunday, July 23, 2017 10:40:42 PM PDT Jason Ekstrand wrote: > I just remembered that we never merged these. IIRC, it's about 3% on > Manhattan. Oh wow, I thought we landed these. I've rebased them, reviewed, and will remeasure and resend soon (in case Topi wants me to rework anything).

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- Comment #7 from Marek Olšák --- Can you try this: diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 834bcc9..ede5439 100644 --- a/src/mesa/state_tracker/st_manager.c +++

Re: [Mesa-dev] [PATCH 2/3] anv: only expose up to 28 vertex attributes

2017-07-24 Thread Lionel Landwerlin
On 21/07/17 09:26, Iago Toral Quiroga wrote: We were exposing 31 because the hardware allows for 33 and we need to reserve one vertex buffer to upload VertexIndex/InstanceIndex and another to upload DrawID when needed, however, there is another restriction in the hardware regarding the size of

Re: [Mesa-dev] [PATCH 1/3] anv/cmd_buffer: fix off by one error in assertion

2017-07-24 Thread Lionel Landwerlin
The spec even put it out clearly : "The sum of|firstBinding|and|bindingCount|*must*be less than or equal to|VkPhysicalDeviceLimits|::|maxVertexInputBindings"| Reviewed-by: Lionel Landwerlin On 21/07/17 09:26, Iago Toral Quiroga wrote: ---

[Mesa-dev] [PATCH] radv: only report external semaphore info for opaque fd.

2017-07-24 Thread Dave Airlie
From: Dave Airlie Until we support sync fd, don't report the info. Fixes CTS dEQP-VK.api.external.semaphore.sync_fd.* from crashing. Fixes: eaa56eab6 (radv: initial support for shared semaphores (v2)) Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

2017-07-24 Thread Zhongmin Wu
Before we queued the buffer with a invalid fence (-1), it will make some benchmarks failed to test such as flatland. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. v2: a) Also implement the fence in cancelBuffer. b) The last

Re: [Mesa-dev] [PATCH 5/5] clover/llvm: Make __OPENCL_VERSION__ dynamic

2017-07-24 Thread Aaron Watry
On Sat, Jul 22, 2017 at 2:59 PM, Jan Vesely wrote: > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote: >> Base it on the active language version >> >> Signed-off-by: Aaron Watry >> --- >> src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 ++-

[Mesa-dev] [PATCH 2/2] svga: implement MSAA alpha_to_one feature

2017-07-24 Thread Brian Paul
The device doesn't directly support this feature so we implement it with additional shader code which sets the color output(s) w component to 1.0 (or max_int or max_uint). Fixes 16 Piglit ext_framebuffer_multisample/*alpha-to-one* tests. v2: only support unorm/float buffers, not int/uint, per

[Mesa-dev] [PATCH] util: fix warning/error on 32bit build

2017-07-24 Thread Tapani Pälli
Add uintptr_t cast to fix 'cast to pointer from integer of different size' warning on 32bit build (build error on Android M). Signed-off-by: Tapani Pälli --- src/util/hash_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-24 Thread Chih-Wei Huang
On Tue 11 Jul 2017, Rob Herring wrote: >> From: Marek Olšák >> >> Add support for 32-bit RGBX/RGBA formats which are required for Android. >> >> The original patch (commit ccdcf91104a5) was reverted (commit >> c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors.

Re: [Mesa-dev] [PATCH 5/5] clover/llvm: Make __OPENCL_VERSION__ dynamic

2017-07-24 Thread Aaron Watry
On Mon, Jul 24, 2017 at 9:41 PM, Aaron Watry wrote: > On Sat, Jul 22, 2017 at 2:59 PM, Jan Vesely wrote: >> On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote: >>> Base it on the active language version >>> >>> Signed-off-by: Aaron Watry

Re: [Mesa-dev] [PATCH] radv: only report external semaphore info for opaque fd.

2017-07-24 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Jul 25, 2017 at 2:21 AM, Dave Airlie wrote: > From: Dave Airlie > > Until we support sync fd, don't report the info. > > Fixes CTS dEQP-VK.api.external.semaphore.sync_fd.* from crashing. > >

[Mesa-dev] [PATCH 1/2] svga: rework the FS white fragments code

2017-07-24 Thread Brian Paul
When we forcibly write white to FS outputs (for XOR mode emulation) we were using a temp register. But that's not really necessary. This also fixes the case of writing white to multiple color buffers. Subsequent changes will build on this. --- src/gallium/drivers/svga/svga_state_fs.c| 11

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 Michel Dänzer changed: What|Removed |Added CC|mic...@daenzer.net | --- Comment #8

[Mesa-dev] [shader-db 3/3] README: Make initial smoke tests steps internally consistent

2017-07-24 Thread Rhys Kidd
No other stage of the suggested initial sanity.py test or other tests uses a folder structure with *.results. Use a consistent naming approach throughout the initial README to make initial setup clearer. Signed-off-by: Rhys Kidd --- README | 4 ++-- 1 file changed, 2

[Mesa-dev] [shader-db 2/3] README: Correct typo deQP -> dEQP

2017-07-24 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index cb49516b7..56ea52b62 100644 --- a/README +++ b/README @@ -414,13 +414,13 @@ deqp_egl.py Support for running dEQP's EGL profile with

[Mesa-dev] [shader-db 1/3] README: Update the list of test profiles

2017-07-24 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- README | 30 ++ 1 file changed, 30 insertions(+) diff --git a/README b/README index 43bdfcae7..cb49516b7 100644 --- a/README +++ b/README @@ -386,6 +386,9 @@ glslparser.py shader.py A subset of all.py which

[Mesa-dev] [shader-db 0/3] Small README clean ups

2017-07-24 Thread Rhys Kidd
Update or fix a few small items that I noticed when running through piglit setup on a new development environment. The first two should be fairly uncontroversial. The third patch is subjective. It came about when I was running through the initial suggested smoke tests as-is. It was apparent

Re: [Mesa-dev] [PATCH 5/5] clover/llvm: Make __OPENCL_VERSION__ dynamic

2017-07-24 Thread Jan Vesely
On Mon, 2017-07-24 at 22:24 -0500, Aaron Watry wrote: > On Mon, Jul 24, 2017 at 9:41 PM, Aaron Watry wrote: > > On Sat, Jul 22, 2017 at 2:59 PM, Jan Vesely wrote: > > > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote: > > > > Base it on the active

Re: [Mesa-dev] [PATCH 1/2] eglut_wayland: Drive event loop by frame events

2017-07-24 Thread Daniel Stone
Hi, On 17 July 2017 at 12:01, Daniel Stone wrote: > Sorry, I have no idea why --subject-prefix didn't actually work. These > two patches are for the demos repo. I'm minded to push these two in the next day or two, unless anyone objects. Cheers, Daniel

Re: [Mesa-dev] [PATCH] gallium/util: s/unsigned/enum tgsi_texture_type/

2017-07-24 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 21.07.2017 um 23:55 schrieb Brian Paul: > --- > src/gallium/auxiliary/util/u_blitter.c| 15 --- > src/gallium/auxiliary/util/u_inlines.h| 2 +- > src/gallium/auxiliary/util/u_simple_shaders.c | 15

Re: [Mesa-dev] [PATCH 2/2] mesa: return GL_OUT_OF_MEMORY if NewSamplerObject fails

2017-07-24 Thread Samuel Pitoiset
On 07/24/2017 03:26 AM, Timothy Arceri wrote: please see the comment in patch 1. Otherwise 1-2 are: Reviewed-by: Timothy Arceri Thanks, I will drop that whitespace fix then. On 21/07/17 22:42, Samuel Pitoiset wrote: This is similar to other functions that create

Re: [Mesa-dev] [PATCH] radv: don't set dedicated bit for buffer external memory.

2017-07-24 Thread Bas Nieuwenhuizen
Not even sure why that bit still exists, but Reviewed-by: Bas Nieuwenhuizen On Mon, Jul 24, 2017 at 9:16 AM, Dave Airlie wrote: > From: Dave Airlie > > This is an alternate fix for the buffer export dedicated interaction. > >

Re: [Mesa-dev] [PATCH 2/2] util: Make CLAMP turn NaN into MIN.

2017-07-24 Thread Michel Dänzer
On 14/07/17 10:01 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > This change broke piglit spec@ext_texture_lod_bias@lodbias for me with radeonsi (but not with llvmpipe). -- Earthling Michel Dänzer |

Re: [Mesa-dev] [PATCH 7/7] i965: Drop non-LLC lunacy in the program cache code.

2017-07-24 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-24 02:03:23) > On Saturday, July 22, 2017 2:28:06 AM PDT Chris Wilson wrote: > > Considering the prevalence of sse4.1, another candidate is > > brw_get_buffer_subdata(), we could use a WC map there as well. > > Your thinking is...avoid polluting the CPU cache,

Re: [Mesa-dev] Mesa 17.2.0 release plan

2017-07-24 Thread Emil Velikov
On 24 July 2017 at 08:52, Marc Di Luzio wrote: > Hi Emil, > > This shouldn't block the RC, but it's something to make sure we have > fixed before the 17.2 final release. > > We're currently tracking a black screen bug hitting most of our game > backlog -

[Mesa-dev] [PATCH] radv: don't set dedicated bit for buffer external memory.

2017-07-24 Thread Dave Airlie
From: Dave Airlie This is an alternate fix for the buffer export dedicated interaction. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_formats.c

Re: [Mesa-dev] [PATCH] radv: fix non-0 based layer clears.

2017-07-24 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Jul 24, 2017 at 9:11 AM, Dave Airlie wrote: > From: Dave Airlie > > If the layer base was > 0, it wasn't getting passed as the start > instance or getting added in the shaders. > > Fixes CTS

Re: [Mesa-dev] [PATCH] radv: allow buffers to be shareable as well.

2017-07-24 Thread Bas Nieuwenhuizen
On Mon, Jul 24, 2017 at 9:13 AM, Dave Airlie wrote: > On 24 July 2017 at 16:49, Bas Nieuwenhuizen wrote: >> On Mon, Jul 24, 2017 at 5:03 AM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> Buffers should

Re: [Mesa-dev] [PATCH] radv: enable sample shading

2017-07-24 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Jul 24, 2017 at 9:31 AM, Dave Airlie wrote: > From: Dave Airlie > > This calculates ps_iter_samples from the minSampleShading input > > Signed-off-by: Dave Airlie > ---

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- Comment #3 from Michel Dänzer --- (In reply to James Legg from comment #1) > glDrawElementsBaseVertex doesn't seem to validate the framebuffer in > the same way as glClear, [...] That sounds like the core of the

[Mesa-dev] [PATCH 0/3] etnaviv: Support large shaders on GC3000

2017-07-24 Thread Wladimir J. van der Laan
This patch adds support for large shaders on GC3000. For example the "terrain" glmark benchmark with a large fragment shader will work after this. If the GPU supports ICACHE, shaders larger than the available state area will be uploaded to a bo of their own and instructed to be loaded from memory

[Mesa-dev] [PATCH] radv: fix non-0 based layer clears.

2017-07-24 Thread Dave Airlie
From: Dave Airlie If the layer base was > 0, it wasn't getting passed as the start instance or getting added in the shaders. Fixes CTS dEQP-VK.api.image_clearing.core.clear_color_attachment.2d_r8_uint_multiple_layers Fixes: 7e0382fb (radv: add support for layered clears

Re: [Mesa-dev] [PATCH] radv: allow buffers to be shareable as well.

2017-07-24 Thread Dave Airlie
On 24 July 2017 at 16:49, Bas Nieuwenhuizen wrote: > On Mon, Jul 24, 2017 at 5:03 AM, Dave Airlie wrote: >> From: Dave Airlie >> >> Buffers should report dedicated flags as well, so report the >> same information for them as for

[Mesa-dev] [PATCH] radv: enable sample shading

2017-07-24 Thread Dave Airlie
From: Dave Airlie This calculates ps_iter_samples from the minSampleShading input Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_pipeline.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] Mesa 17.2.0 release plan

2017-07-24 Thread Marc Di Luzio
Hi Emil, This shouldn't block the RC, but it's something to make sure we have fixed before the 17.2 final release. We're currently tracking a black screen bug hitting most of our game backlog - https://bugs.freedesktop.org/show_bug.cgi?id=101867. Just pinging in to make sure we're aware,

[Mesa-dev] [PATCH 2/3] etnaviv: Unified uniforms support

2017-07-24 Thread Wladimir J. van der Laan
GC3000 has changed from a separate store for VS and PS uniforms to a single, unified one. There is backwards compatibilty functionalty, however this does not work correctly together with ICACHE. This patch adds explicit support, although in the simplest way possible: the PS/VS uniforms split is

[Mesa-dev] [PATCH 1/3] etnaviv: Update headers from rnndb

2017-07-24 Thread Wladimir J. van der Laan
Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/hw/state_3d.xml.h | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/etnaviv/hw/state_3d.xml.h b/src/gallium/drivers/etnaviv/hw/state_3d.xml.h index

[Mesa-dev] [PATCH 3/3] etnaviv: Implement ICACHE

2017-07-24 Thread Wladimir J. van der Laan
This patch adds support for large shaders on GC3000. For example the "terrain" glmark benchmark with a large fragment shader will work after this. If the GPU supports ICACHE, shaders larger than the available state area will be uploaded to a bo of their own and instructed to be loaded from memory

Re: [Mesa-dev] [PATCH 2/3] st/dri2: Return invalid modifier when no driver support

2017-07-24 Thread Emil Velikov
On 24 July 2017 at 12:44, Daniel Stone wrote: > Hi, > > On 24 July 2017 at 12:30, Emil Velikov wrote: >> On 22 July 2017 at 09:00, Daniel Stone wrote: >>> We can address that as well, but not instead. Drivers which aren't >>>

Re: [Mesa-dev] [PATCH 1/2] egl: fix whitespace issues from eglimage code

2017-07-24 Thread Emil Velikov
Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

2017-07-24 Thread Luke A. Guest
master currently fails when enabling egl because drivers/dri2/linux-dmabuf-unstable-v1-protocol.c doesn't exist, should it? Luke. On 19/07/17 23:44, Andres Gomez wrote: > This fixes `make distcheck` > >> make[3]: *** No rule to make target >> 'drivers/dri2/linux-dmabuf-unstable-v1-protocol.c',

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

2017-07-24 Thread Tapani Pälli
I sent attempt to fix this here: https://patchwork.freedesktop.org/patch/168609/ On 07/24/2017 03:25 PM, Luke A. Guest wrote: master currently fails when enabling egl because drivers/dri2/linux-dmabuf-unstable-v1-protocol.c doesn't exist, should it? Luke. On 19/07/17 23:44, Andres Gomez

[Mesa-dev] [PATCH] egl: guard wayland header dep. tracking behind HAVE_PLATFORM_WAYLAND

2017-07-24 Thread Emil Velikov
From: Emil Velikov Otherwise we'll attemt to generate the header even we don't need to. In that case the dependencies may not be met, leading to build failure. Cc: Tapani Pälli Fixes: 166852e "configure.ac: rework wayland-protocols handling"

Re: [Mesa-dev] [PATCH] egl: guard wayland header dep. tracking behind HAVE_PLATFORM_WAYLAND

2017-07-24 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 07/24/2017 03:27 PM, Emil Velikov wrote: From: Emil Velikov Otherwise we'll attemt to generate the header even we don't need to. In that case the dependencies may not be met, leading to build failure. Cc:

[Mesa-dev] [PATCH] radv: fix buffer views on SI/CIK.

2017-07-24 Thread Dave Airlie
From: Dave Airlie Fixes CTS dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.1024 on SI/CIK with radv. Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 5

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101867 Johan Gardhage changed: What|Removed |Added CC|

[Mesa-dev] [Bug 101876] SIGSEGV when launching Steam

2017-07-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101876 Johan Gardhage changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] radv: fix buffer views on SI/CIK.

2017-07-24 Thread Alex Smith
On 24 July 2017 at 11:44, Dave Airlie wrote: > From: Dave Airlie > > Fixes CTS dEQP-VK.memory.pipeline_barrier.host_write_uniform_ > texel_buffer.1024 > on SI/CIK with radv. > > Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) >

[Mesa-dev] [PATCH] radv: Change a linking order of AMDGPU_LIBS

2017-07-24 Thread Gwan-gyeong Mun
Because of "libvulkan_common.la" directly links libdrm_amdgpu api prior to "libvulkan_radeon.la", it change a linking order of AMDGPU_LIBS from "libvulkan_radeon.la" to "libvulkan_common.la". Signed-off-by: Mun Gwan-gyeong --- src/amd/vulkan/Makefile.am | 2 +- 1 file

Re: [Mesa-dev] [PATCH 1/3] egl/wayland: Ignore invalid modifiers

2017-07-24 Thread Daniel Stone
Hi Emil, On 24 July 2017 at 12:18, Emil Velikov wrote: > On 21 July 2017 at 14:34, Daniel Stone wrote: >> @@ -370,6 +370,9 @@ get_back_bo(struct dri2_egl_surface *dri2_surf) >>return -1; >> } >> >> + if (num_modifiers == 0) >> +

Re: [Mesa-dev] [PATCH 2/3] st/dri2: Return invalid modifier when no driver support

2017-07-24 Thread Daniel Stone
Hi, On 24 July 2017 at 12:30, Emil Velikov wrote: > On 22 July 2017 at 09:00, Daniel Stone wrote: >> We can address that as well, but not instead. Drivers which aren't >> aware of modifiers will return success (as they know how to export >>

Re: [Mesa-dev] [PATCH 1/3] egl/wayland: Ignore invalid modifiers

2017-07-24 Thread Emil Velikov
On 24 July 2017 at 12:22, Daniel Stone wrote: > Hi Emil, > > On 24 July 2017 at 12:18, Emil Velikov wrote: >> On 21 July 2017 at 14:34, Daniel Stone wrote: >>> @@ -370,6 +370,9 @@ get_back_bo(struct dri2_egl_surface

Re: [Mesa-dev] [PATCH 7/7] i965: Drop non-LLC lunacy in the program cache code.

2017-07-24 Thread Emil Velikov
Hi Ken, Admittedly I'm not an expert in the area, so perhaps a rather silly question. On 22 July 2017 at 00:17, Kenneth Graunke wrote: > +#ifdef USE_SSE41 > + if (!cache->bo->cache_coherent && cpu_has_sse4_1) > + _mesa_streaming_load_memcpy(map, cache->map,

[Mesa-dev] [PATCH 2/2] egl: guard wayland specific bits with HAVE_PLATFORM_WAYLAND

2017-07-24 Thread Tapani Pälli
Fixes: 166852e "configure.ac: rework wayland-protocols handling" Signed-off-by: Tapani Pälli --- This fixes following build error for me: make[4]: *** No rule to make target '/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml', needed by

[Mesa-dev] [PATCH 1/2] egl: fix whitespace issues from eglimage code

2017-07-24 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/egl/main/eglimage.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c index 72a556e..46bf0c5 100644 --- a/src/egl/main/eglimage.c +++

Re: [Mesa-dev] [PATCH 1/3] egl/wayland: Ignore invalid modifiers

2017-07-24 Thread Emil Velikov
On 21 July 2017 at 14:34, Daniel Stone wrote: > If the underlying driver does not support modifiers, dmabuf will still > advertise formats through the 'modifier' event, but send them with an > invalid modifier. Ignore them if this is the case, rather than passing > them

Re: [Mesa-dev] [PATCH 2/3] st/dri2: Return invalid modifier when no driver support

2017-07-24 Thread Emil Velikov
Hi Dan, On 22 July 2017 at 09:00, Daniel Stone wrote: > Hi Emil, > > On 21 July 2017 at 15:23, Emil Velikov wrote: >> I think the key issue is that the resource_get_handle() calls lack >> proper error handling. >> >> There's a single case, that

  1   2   >