Re: [Mesa-dev] [PATCH 13/18] anv/pipeline: Compile to NIR in compile_graphics

2018-07-25 Thread Jason Ekstrand
On Wed, Jul 25, 2018 at 5:19 PM Timothy Arceri wrote: > On 12/07/18 07:18, Jason Ekstrand wrote: > > This pulls the SPIR-V to NIR step out into common code. > > --- > > src/intel/vulkan/anv_pipeline.c | 278 +--- > > 1 file changed, 116 insertions(+), 162

Re: [Mesa-dev] [PATCH v2 1/8] nir: evaluate if condition uses inside the if branches

2018-07-25 Thread Timothy Arceri
On 23/07/18 18:02, Timothy Arceri wrote: Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is clearly positive. shader-db results IVB:

Re: [Mesa-dev] [PATCH] i965: Expose ARB_base_instance extension

2018-07-25 Thread Anuj Phogat
On Wed, Jul 25, 2018 at 10:49 AM Sagar Ghuge wrote: > > The extension requires at least OpenGL 3.0 and > OpenGL ES 3.0. > > Fixes two ext_base_instance tests: > > arb_base_instance-baseinstance-doesnt-affect-gl-instance-id_gles3 > arb_base_instance-drawarrays_gles3 > > Signed-off-by: Sagar Ghuge

Re: [Mesa-dev] [PATCH v2] docs: fix incorrect placement of the ARB_sample_locations release notes

2018-07-25 Thread Marek Olšák
Reviewed-by: Marek OIšák Marek On Wed, Jul 25, 2018 at 9:18 AM, Rhys Perry wrote: > Seems something went wrong somehow when it was pushed. > > v2: combine into one list > > Signed-off-by: Rhys Perry > --- > docs/relnotes/18.2.0.html | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-)

Re: [Mesa-dev] [PATCH 13/18] anv/pipeline: Compile to NIR in compile_graphics

2018-07-25 Thread Timothy Arceri
On 12/07/18 07:18, Jason Ekstrand wrote: This pulls the SPIR-V to NIR step out into common code. --- src/intel/vulkan/anv_pipeline.c | 278 +--- 1 file changed, 116 insertions(+), 162 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android

2018-07-25 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jul 24, 2018 at 8:54 PM, Chad Versace wrote: > u_debug_stack_android.cpp transitively included "pipe/p_compiler.h", but > src/gallium/include was missing from the C++ include path. > > Cc: Gurchetan Singh > Cc: Eric Engestrom > --- >

[Mesa-dev] [PATCH 2/2] intel/compiler: Add brw_get_compiler_config_value for disk cache

2018-07-25 Thread Jordan Justen
During code review, Jason pointed out that: 2b3064c0731 "i965, anv: Use INTEL_DEBUG for disk_cache driver flags" Didn't account for INTEL_SCALER_* environment variables. To fix this, let the compiler return the disk_cache driver flags. Another possible fix would be to pull the INTEL_SCALER_*

[Mesa-dev] [PATCH 1/2] i965: Disable shader cache with INTEL_DEBUG=shader_time

2018-07-25 Thread Jordan Justen
Shader time hard codes an index of the shader time buffer within the gen program. In order to support shader time in the disk shader cache, we'd need to add the shader time index into the program key. This should work, but probably is not worth it for this particular debug feature. Therefore,

Re: [Mesa-dev] [PATCH 17/18] anv/pipeline: Do cross-stage linking optimizations

2018-07-25 Thread Timothy Arceri
It would be good if you could reply to my comment in patch 13 otherwise 1-17 are: Reviewed-by: Timothy Arceri As mentioned before you really need the varying vector and array splitting passes to get the most from these linking opts. Patch 18 seems ok but you might want to get someone else

[Mesa-dev] [Bug 107224] Incorrect Rendering in Deus Ex: Mankind Divided in-game menu

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107224 --- Comment #3 from Timothy Arceri --- I also gave the Mesa 13.0-branchpoint with ca76e6b5213c92432b applied a try and still see the issue there. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [PATCH v2 0/2] Add DRMless surfaceless fallback path.

2018-07-25 Thread David Riley
Ping for this patch set. On Tue, Jul 17, 2018 at 5:12 PM David Riley wrote: > Allow platform_surfaceless to use swrast even if DRM is not available. > To be used to allow a fuzzer for virgl to be run on a jailed VM without > hardware GL or DRM support. > > v2: Comment style fixes and remove

Re: [Mesa-dev] [PATCH 0/7] ASTC texture compression for all Gallium drivers

2018-07-25 Thread Gert Wollny
Am Montag, den 23.07.2018, 19:52 -0400 schrieb Marek Olšák: > Hi, > > This series enables ASTC texture compression for all Gallium drivers > that don't support it in hardware. The works the same as the ETC2 > fallback, i.e. it decompresses ASTC inside glCompressedTexImage to > a supported

Re: [Mesa-dev] [PATCH mesa] docs: trivial html fix

2018-07-25 Thread Jordan Justen
You might as well add something like ">" => "" to the subject. Reviewed-by: Jordan Justen On 2018-07-25 12:18:34, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > docs/releasing.html | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 08/18] anv/pipeline: Hash the entire pipeline in one go

2018-07-25 Thread Timothy Arceri
1-8 look fine to me and are: Reviewed-by: Timothy Arceri I'll try to finish looking over the rest later tonight or tomorrow. On 12/07/18 07:18, Jason Ekstrand wrote: Instead of hashing each stage separately (and TES and TCS together), we hash the entire pipeline. This means we'll get fewer

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

2018-07-25 Thread Dylan Baker
Quoting Emil Velikov (2018-07-24 08:56:55) > On 24 July 2018 at 11:29, Eric Engestrom wrote: > > On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: > >> Until now, the needed bits were wrongly included in linux/memfd.h > >> > >> Since Travis' sys/syscall.h doesn't provide the

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Hello, here is a backtrace: Core was generated by `glretrace ./DyingLightGame.trace'. Program terminated with signal SIGABRT, Aborted. #0 0x7f2852895428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 54 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 Bug ID: 107369 Summary: "volatile" in OpenCL code not recognized by POLARIS10 and KABINI Product: Mesa Version: 18.0 Hardware: x86-64 (AMD64) OS: Linux

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Chris Wilson
Quoting Sergii Romantsov (2018-07-25 08:42:55) > Hello, > here is a backtrace: ... Please try: diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 09d45e30ecc..8274c2e0b2f 100644 --- a/src/mesa/drivers/dri/i965/brw_bufmgr.c +++

Re: [Mesa-dev] [PATCH] intel: tools: dump: only store device id on success

2018-07-25 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 07/24/2018 11:11 PM, Lionel Landwerlin wrote: We might fail on master node drm fd because we won't have the right permissions. Signed-off-by: Lionel Landwerlin --- src/intel/tools/intel_dump_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-25 Thread Danylo Piliaiev
Hi Eric, On 24.07.18 18:43, Eric Engestrom wrote: On Friday, 2018-07-13 16:57:34 +0300, Danylo Piliaiev wrote: Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for

Re: [Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-25 Thread Danylo Piliaiev
Hi Emil, On 24.07.18 19:23, Emil Velikov wrote: Hi Danylo, Having a closer look inspired by Eric's comments On 24 July 2018 at 15:37, Danylo Piliaiev wrote: Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. As you bump the libdrm version: - drop the existing

Re: [Mesa-dev] [PATCH] st/nir: Fix st_nir_opts() prototype.

2018-07-25 Thread Christian Gmeiner
Reviewed-by: Christian Gmeiner -- Christian Gmeiner, MSc https://christian-gmeiner.info Kenneth Graunke schrieb am Di., 24. Juli 2018, 23:55: > This wasn't updated for the new scalar ISA parameter. It worked anyway > because all the function's callers live in the same file, so it found >

[Mesa-dev] [Bug 106283] Shader replacements works only for limited use cases

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106283 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Hello, Chris. Your variant also works. But i wonder about comment: /* If we don't have caching at this size, don't actually round the * allocation up. */ if (bucket == NULL) { Has it any sense now? If 'no' - will delete it in next patch update. Was trying to get commit where and

Re: [Mesa-dev] [PATCH v2] intel/ppgtt: memory address alignment

2018-07-25 Thread Chris Wilson
Quoting Sergii Romantsov (2018-07-25 10:37:29) > Hello, Chris. > Your variant also works. > But i wonder about comment: >    /* If we don't have caching at this size, don't actually round the >     * allocation up. >     */ >    if (bucket == NULL) { > > Has it any sense now? If 'no' - will

[Mesa-dev] [PATCH v3 10/26] python: Use explicit integer divisions

2018-07-25 Thread Mathieu Bridon
In Python 2, divisions of integers return an integer: >>> 32 / 4 8 In Python 3 though, they return floats: >>> 32 / 4 8.0 However, Python 3 has an explicit integer division operator: >>> 32 // 4 8 That operator exists on Python >= 2.2, so let's use it everywhere to

[Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Kernel (for ppgtt) requires memory address to be aligned to page size (4096). -v2: added marking that also fixes initial commit 01058a552294. -v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned instead of alignment of offsets (Chris Wilson). Bugzilla:

[Mesa-dev] [Bug 106411] Invalid gl_InstanceID value with combination of gl_DrawIDARB under OpenGL

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106411 --- Comment #1 from Tapani Pälli --- I've tried your example app with current Mesa (b3b170ade9) and for me the end result visually is the same whether or not I comment out line that adds gl_VertexID usage. Could you comment on what is the

[Mesa-dev] [PATCH] meson: enable -fmerge-all-constants by default

2018-07-25 Thread Konstantin Kharlamov
This is a standard non-conforming optimization, which, quoting, "…considers e.g. even constant initialized arrays or initialized constant variables with integral or floating-point types. Languages like C or C++ require each variable, including multiple instances of the same variable in recursive

[Mesa-dev] [PATCH] anv: add more swapchain formats

2018-07-25 Thread Tapani Pälli
This change helps with some of the dEQP-VK.wsi.android.* tests that try to create swapchain with using such formats. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_android.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [RFC 0/6] VK_ANDROID_external_memory_android_hardware_buffer

2018-07-25 Thread Tapani Pälli
Any comments? I'm planning to rebase this and try to investigate what is missing from CTS perspective. On 05/29/2018 10:08 AM, Tapani Pälli wrote: Hi; Here's RFC for the extension. I've tested the import/export functionality with RGBA images on Android Celadon with a custom NDK app that draws

Re: [Mesa-dev] [PATCH] meson: enable -fmerge-all-constants by default

2018-07-25 Thread Konstantin Kharlamov
FWIW I just realized it also enables -fmerge-constants which is enabled at all optimize levels, and built/compared it with fmerge-all-constants. The difference is still noticeable. If anybody interested, I can pretty-format it, and send here. On 25.07.2018 14:03, Konstantin Kharlamov wrote:

[Mesa-dev] [Bug 106922] Tangrams demo: LLVM ERROR: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106922 --- Comment #5 from Samuel Pitoiset --- Missing 16-bit integer support. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

Re: [Mesa-dev] [PATCH 0/7] ASTC texture compression for all Gallium drivers

2018-07-25 Thread Mike Lothian
Hi Glxinfo reporting things correctly, as does es2info and my GLES apps continue to work Are there any apps that explicitly use GLES3.2 that I can test for you? Extended renderer info (GLX_MESA_query_renderer): Vendor: X.Org (0x1002) Device: AMD Radeon R9 M295X (TONGA, DRM 3.27.0,

[Mesa-dev] Reminder, 18.2 branching on Wednesday, the 1st of August

2018-07-25 Thread Andres Gomez
I just wanted to remind everyone that the plan is to branch for 18.2 on Wednesday, the 1st of August. I plan to take the head of master around 10:00 am EEST, and assuming that all of our CI testing is good that will become the 18.2 branch point with RC1 to follow after that. The status of the

[Mesa-dev] [PATCH] nir: remove wrong assertion in print_var_decl()

2018-07-25 Thread Samuel Pitoiset
This breaks printing input/output variables with more than 4 components like mat4. Fixes: 1beef89ad8 ("nir: prepare for bumping up max components to 16") Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir_print.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Mesa-dev] [RFC][PATCH 2/5] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-25 Thread Emil Velikov
On 25 July 2018 at 00:21, John Stultz wrote: > From: Sumit Semwal > > This is a forward port of a patch from the AOSP/master tree: > https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ > > Since

Re: [Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-25 Thread Emil Velikov
On 25 July 2018 at 00:21, John Stultz wrote: > From: Dan Willemsen > > This is a forward port of a patch from the AOSP/master tree: > https://android.googlesource.com/platform/external/mesa3d/+/bd633f11de0c6ac1ed333a28344c74fd9898df9e%5E%21/ > > Which replaces HOST_OUT_release with HOST_OUT >

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread Emil Velikov
On 25 July 2018 at 00:21, John Stultz wrote: > From: Yong Yao > > This is a forward port of a patch from the AOSP/master branch: > https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51c7ae3a033b100a8429ae5415%5E%21/ > > Which allows boards to provide their own custom copy

Re: [Mesa-dev] [RFC][PATCH 5/5] Android.mk: Fix checkbuild on Mac builders.

2018-07-25 Thread Emil Velikov
On 25 July 2018 at 00:21, John Stultz wrote: > From: Alistair Strachan > > This is a forward port of a patch in the AOSP/master tree: > https://android.googlesource.com/platform/external/mesa3d/+/d7f894a7d39e66ca5a832c19edaf175400041aff%5E%21/ > > The libmesa_dri_common target depends on

Re: [Mesa-dev] [RFC][PATCH 0/5] Trying to align mesa upstream w/ AOSP/master

2018-07-25 Thread Emil Velikov
Hi John, On 25 July 2018 at 00:21, John Stultz wrote: > In trying to keep the upstream mesa aligned with AOSP, I wanted > to submit a few changes that seemed reasonable to upstream. > > The first two are build fixes that are required to get mesa master > building with AOSP. The last three are

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread Harish Krupo
Emil, Emil Velikov writes: > On 25 July 2018 at 00:21, John Stultz wrote: >> From: Yong Yao >> >> This is a forward port of a patch from the AOSP/master branch: >> https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51c7ae3a033b100a8429ae5415%5E%21/ >> >> Which allows

[Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Samuel Pitoiset
Move the integer conversion after the fixup. This fixes some regressions with dEQP-VK.pipeline.vertex_input.single_attribute.mat4.as_a2r10g10b10* Fixes: b722b29f10 ("radv: add support for 16bit input/output") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 7 --- 1

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Bas Nieuwenhuizen
hmm, not sure why that did not fail on my CTS runs ... Reviewed-by: Bas Nieuwenhuizen On Wed, Jul 25, 2018 at 2:55 PM, Samuel Pitoiset wrote: > Move the integer conversion after the fixup. > > This fixes some regressions with >

[Mesa-dev] [PATCH] docs: fix incorrect placement of the ARB_sample_locations release notes

2018-07-25 Thread Rhys Perry
Seems something went wrong somehow when it was pushed. Signed-off-by: Rhys Perry --- docs/relnotes/18.2.0.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/relnotes/18.2.0.html b/docs/relnotes/18.2.0.html index f757f4148a..eeb0bbaf07 100644 ---

Re: [Mesa-dev] [PATCH] docs: fix incorrect placement of the ARB_sample_locations release notes

2018-07-25 Thread Ilia Mirkin
On Wed, Jul 25, 2018 at 8:54 AM, Rhys Perry wrote: > Seems something went wrong somehow when it was pushed. > > Signed-off-by: Rhys Perry > --- > docs/relnotes/18.2.0.html | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/relnotes/18.2.0.html

Re: [Mesa-dev] [PATCH] docs: fix incorrect placement of the ARB_sample_locations release notes

2018-07-25 Thread Rhys Perry
yeah, I think that's right. On Wed, Jul 25, 2018 at 1:59 PM, Ilia Mirkin wrote: > On Wed, Jul 25, 2018 at 8:54 AM, Rhys Perry wrote: >> Seems something went wrong somehow when it was pushed. >> >> Signed-off-by: Rhys Perry >> --- >> docs/relnotes/18.2.0.html | 4 ++-- >> 1 file changed, 2

[Mesa-dev] [PATCH] nvc0: serialize before updating some constant buffer bindings

2018-07-25 Thread Rhys Perry
To avoid serializing, this has the user constant buffer always be 65536 bytes and enabled unless it's required that something else is used for constant buffer 0. Fixes artifacts with at least XCOM: Enemy Within, 0 A.D. and Unigine Valley, Heaven and Superposition. v2: changed

[Mesa-dev] [PATCH v2] docs: fix incorrect placement of the ARB_sample_locations release notes

2018-07-25 Thread Rhys Perry
Seems something went wrong somehow when it was pushed. v2: combine into one list Signed-off-by: Rhys Perry --- docs/relnotes/18.2.0.html | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/relnotes/18.2.0.html b/docs/relnotes/18.2.0.html index f757f4148a..8cdf6ac7d7

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Samuel Pitoiset
On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: hmm, not sure why that did not fail on my CTS runs ... Because 16bit is only enabled on Polaris? Reviewed-by: Bas Nieuwenhuizen On Wed, Jul 25, 2018 at 2:55 PM, Samuel Pitoiset wrote: Move the integer conversion after the fixup. This

Re: [Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Sorry, do we have any objections about PAGE_SIZE usage instead of 4096? And what do you think if, maybe, some auto Intel-internal tests to run with that patch? On Wed, Jul 25, 2018 at 1:21 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Kernel (for ppgtt) requires memory address to

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Bas Nieuwenhuizen
On Wed, Jul 25, 2018 at 3:25 PM, Samuel Pitoiset wrote: > > > On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: >> >> hmm, not sure why that did not fail on my CTS runs ... > > > Because 16bit is only enabled on Polaris? Wait what, it should be enabled on Vega too right? > > >> >> Reviewed-by:

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Samuel Pitoiset
On 07/25/2018 03:26 PM, Bas Nieuwenhuizen wrote: On Wed, Jul 25, 2018 at 3:25 PM, Samuel Pitoiset wrote: On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: hmm, not sure why that did not fail on my CTS runs ... Because 16bit is only enabled on Polaris? Wait what, it should be enabled

Re: [Mesa-dev] [PATCH] nir: remove wrong assertion in print_var_decl()

2018-07-25 Thread Bas Nieuwenhuizen
On Wed, Jul 25, 2018 at 2:30 PM, Samuel Pitoiset wrote: > This breaks printing input/output variables with more than > 4 components like mat4. > > Fixes: 1beef89ad8 ("nir: prepare for bumping up max components to 16") > Signed-off-by: Samuel Pitoiset > --- > src/compiler/nir/nir_print.c | 1 - >

Re: [Mesa-dev] [PATCH] radv: fix adjusting vertex fetches since 16bit support

2018-07-25 Thread Bas Nieuwenhuizen
On Wed, Jul 25, 2018 at 3:28 PM, Samuel Pitoiset wrote: > > > On 07/25/2018 03:26 PM, Bas Nieuwenhuizen wrote: >> >> On Wed, Jul 25, 2018 at 3:25 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 07/25/2018 02:55 PM, Bas Nieuwenhuizen wrote: hmm, not sure why that did not fail on

Re: [Mesa-dev] [PATCH] nir: remove wrong assertion in print_var_decl()

2018-07-25 Thread Samuel Pitoiset
On 07/25/2018 03:28 PM, Bas Nieuwenhuizen wrote: On Wed, Jul 25, 2018 at 2:30 PM, Samuel Pitoiset wrote: This breaks printing input/output variables with more than 4 components like mat4. Fixes: 1beef89ad8 ("nir: prepare for bumping up max components to 16") Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread Rob Herring
On Tue, Jul 24, 2018 at 5:21 PM John Stultz wrote: > > From: Yong Yao > > This is a forward port of a patch from the AOSP/master branch: > https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51c7ae3a033b100a8429ae5415%5E%21/ > > Which allows boards to provide their own

[Mesa-dev] [Bug 106411] Invalid gl_InstanceID value with combination of gl_DrawIDARB under OpenGL

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106411 --- Comment #2 from Alexander --- I'm still on Ubuntu 16.04 and the latest available Mesa version is 18.0.5 (from x-swat). I have main_instance_draw.png without dependency on gl_VertexID. With artificial dependency rendering is correct

Re: [Mesa-dev] [PATCH] nvc0: serialize before updating some constant buffer bindings

2018-07-25 Thread Ilia Mirkin
On Wed, Jul 25, 2018 at 9:13 AM, Rhys Perry wrote: > To avoid serializing, this has the user constant buffer always be 65536 > bytes and enabled unless it's required that something else is used for > constant buffer 0. > > Fixes artifacts with at least XCOM: Enemy Within, 0 A.D. and Unigine >

[Mesa-dev] [PATCH] dri3: Do not get supported modifiers on pixmaps

2018-07-25 Thread Olivier Fourdan
get_supported_modifiers() expects a window as drawable, passing a pixmap will fail as the Xserver will fail to match the id to a window. That leads to dri3_alloc_render_buffer() to return NULL and breaks rendering when using GLX_DOUBLEBUFFER. Check if dealing with pixmap in

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 Jan Vesely changed: What|Removed |Added Blocks||99553 --- Comment #1 from Jan Vesely ---

[Mesa-dev] [PATCH] gallium: initialize ureg_dst::Invariant bit

2018-07-25 Thread Erik Faye-Lund
When this bit was added, it seems the some initialization code was omitted by mistake. Since stack-variables have kinda random contents, and we don't zero initialize the whole struct in these code-paths, we end up getting random-ish values for this bit. Spotted by Coverity in the following CIDs:

Re: [Mesa-dev] [PATCH] nir: remove wrong assertion in print_var_decl()

2018-07-25 Thread Bas Nieuwenhuizen
On Wed, Jul 25, 2018 at 3:38 PM, Samuel Pitoiset wrote: > > > On 07/25/2018 03:28 PM, Bas Nieuwenhuizen wrote: >> >> On Wed, Jul 25, 2018 at 2:30 PM, Samuel Pitoiset >> wrote: >>> >>> This breaks printing input/output variables with more than >>> 4 components like mat4. >>> >>> Fixes: 1beef89ad8

Re: [Mesa-dev] [PATCH v2] intel: Make the decoder handle STATE_BASE_ADDRESS not being a buffer.

2018-07-25 Thread Lionel Landwerlin
Hey Ken, Looks all good to me. Just one suggestion which I think might matter in your prototype : The handle_state_base_address() function tries to get BOs when the instruction is parsed. But as you seem to imply those base addresses might not be backed by actual buffers. I would turn the

Re: [Mesa-dev] [Mesa-stable] [PATCH] gallium/tests: Don't ignore S3TC errors.

2018-07-25 Thread Dylan Baker
Quoting Emil Velikov (2018-07-24 09:52:13) > On 24 July 2018 at 13:58, Jose Fonseca wrote: > > Now we do full S3TC decompression they should no longer fail. > > --- > > src/gallium/tests/unit/u_format_test.c | 5 - > > 1 file changed, 5 deletions(-) > > > > diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-25 Thread Dylan Baker
Quoting Jason Ekstrand (2018-07-24 16:51:26) > On July 24, 2018 09:05:05 Dylan Baker wrote: > > > Quoting Jason Ekstrand (2018-07-23 10:46:31) > >> The original pass only looked for load_uniform intrinsics but there are > >> a number of other places that could end up loading a push constant.

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-25 Thread Jason Ekstrand
On Wed, Jul 25, 2018 at 9:30 AM Dylan Baker wrote: > Quoting Jason Ekstrand (2018-07-24 16:51:26) > > On July 24, 2018 09:05:05 Dylan Baker wrote: > > > > > Quoting Jason Ekstrand (2018-07-23 10:46:31) > > >> The original pass only looked for load_uniform intrinsics but there > are > > >> a

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/compiler: Account for built-in uniforms in analyze_ubo_ranges

2018-07-25 Thread Dylan Baker
Quoting Jason Ekstrand (2018-07-25 09:38:15) > On Wed, Jul 25, 2018 at 9:30 AM Dylan Baker wrote: > > Quoting Jason Ekstrand (2018-07-24 16:51:26) > > On July 24, 2018 09:05:05 Dylan Baker wrote: > > > > > Quoting Jason Ekstrand (2018-07-23 10:46:31) > > >> The original pass

Re: [Mesa-dev] [PATCH v2] clover: Reduce wait_count in abort path.

2018-07-25 Thread Aaron Watry
I can confirm that all 28 CTS 'events' tests pass now on my BARTS (6850) instead of hanging after an intentionally failing event. I'll let Francisco give his say to whether it looks correct, but for this version you can have: Tested-By: Aaron Watry --Aaron On Tue, Jul 24, 2018 at 10:28 PM,

Re: [Mesa-dev] [PATCH] gallium: initialize ureg_dst::Invariant bit

2018-07-25 Thread Emil Velikov
On 25 July 2018 at 16:28, Erik Faye-Lund wrote: > When this bit was added, it seems the some initialization code > was omitted by mistake. > > Since stack-variables have kinda random contents, and we don't > zero initialize the whole struct in these code-paths, we end up > getting random-ish

Re: [Mesa-dev] [PATCH] dri3: Do not get supported modifiers on pixmaps

2018-07-25 Thread Eric Anholt
Olivier Fourdan writes: > get_supported_modifiers() expects a window as drawable, passing a pixmap > will fail as the Xserver will fail to match the id to a window. > > That leads to dri3_alloc_render_buffer() to return NULL and breaks > rendering when using GLX_DOUBLEBUFFER. > > Check if

[Mesa-dev] [PATCH] i965: Expose ARB_base_instance extension

2018-07-25 Thread Sagar Ghuge
The extension requires at least OpenGL 3.0 and OpenGL ES 3.0. Fixes two ext_base_instance tests: arb_base_instance-baseinstance-doesnt-affect-gl-instance-id_gles3 arb_base_instance-drawarrays_gles3 Signed-off-by: Sagar Ghuge --- src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- 1 file

[Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-25 Thread Eric Engestrom
CovID: 1438132 Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 04fd6a829ed60081abc4..3664f80c24dc34955196 100644 ---

[Mesa-dev] [ANNOUNCE] Mesa 18.1.5 Candidate

2018-07-25 Thread Dylan Baker
Greetings, Mesa the staging/18.1 branch is currently slushed for 18.1.5, and assuming that there are no regressions or patches critically necessary this will be merged to the 18.1 branch for a release Friday morning, July 27th around 10 AM PDT. Currently the branch has the following changes

[Mesa-dev] [PATCH mesa] vulkan/wsi: fix assignment in assert()

2018-07-25 Thread Eric Engestrom
CovID: 1438121 Fixes: dc1d10b396179766227df "anv,radv: Add support for VK_KHR_get_display_properties2" Cc: Jason Ekstrand Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH mesa v2] vulkan/wsi: fix assignment in assert()

2018-07-25 Thread Eric Engestrom
CovID: 1438113, 1438118, 1438119, 1438121 Fixes: dc1d10b396179766227df "anv,radv: Add support for VK_KHR_get_display_properties2" Cc: Jason Ekstrand Signed-off-by: Eric Engestrom --- src/vulkan/wsi/wsi_common_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH mesa] anv: remove incorrect `UNUSED` flag

2018-07-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 5d9becf51723b8a4ca47..36d4ac13c75d8a22e7ee 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH mesa] anv: drop unused local vars

2018-07-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_descriptor_set.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index 8f7f1f3ba386de438887..66ed28292b01897fc1d1 100644 ---

[Mesa-dev] [PATCH mesa 3/3] anv: fix python whitespace warning

2018-07-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_icd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_icd.py b/src/intel/vulkan/anv_icd.py index fafec34f677e4572..73cc6453d51d0fbc2eec 100644 --- a/src/intel/vulkan/anv_icd.py +++

[Mesa-dev] [PATCH mesa 1/3] anv: remove unnecessary semicolons in python

2018-07-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_extensions.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index ea837744b4352845b0d5..cffc3e700cb0ccb7fa8f 100644 ---

[Mesa-dev] [PATCH mesa 2/3] anv: cleanup python imports

2018-07-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_entrypoints_gen.py | 3 +-- src/intel/vulkan/anv_icd.py | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [PATCH mesa] docs: trivial html fix

2018-07-25 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/releasing.html | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/releasing.html b/docs/releasing.html index a022d0c484bc0f635b61..69d8656e59d567033087 100644 --- a/docs/releasing.html +++ b/docs/releasing.html @@ -492,10

Re: [Mesa-dev] [PATCH mesa v2] vulkan/wsi: fix assignment in assert()

2018-07-25 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Jul 25, 2018 at 12:04 PM Eric Engestrom wrote: > CovID: 1438113, 1438118, 1438119, 1438121 > Fixes: dc1d10b396179766227df "anv,radv: Add support for > VK_KHR_get_display_properties2" > Cc: Jason Ekstrand > Signed-off-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH] i965: Expose ARB_base_instance extension

2018-07-25 Thread Jordan Justen
I think the subject should include gles3: i965: Expose ARB_base_instance extension in OpenGL ES 3.0 Reviewed-by: Jordan Justen On 2018-07-25 10:48:31, Sagar Ghuge wrote: > The extension requires at least OpenGL 3.0 and > OpenGL ES 3.0. > > Fixes two ext_base_instance tests: > >

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-25 Thread Eric Engestrom
On Wednesday, 2018-07-25 19:45:56 +0100, Eric Engestrom wrote: > CovID: 1438132 > Signed-off-by: Eric Engestrom Forgot to check before sending: Fixes: a99c9e63a07477634ab73 "anv: finish the binding_table_pool on destroyDevice when use_softpin" Cc: Jose Maria

Re: [Mesa-dev] [PATCH] i965: Expose ARB_base_instance extension

2018-07-25 Thread Ilia Mirkin
Presumably EXT_base_instance (or OES_? I forget, definitely not ARB though) On Wed, Jul 25, 2018 at 3:24 PM, Jordan Justen wrote: > I think the subject should include gles3: > > i965: Expose ARB_base_instance extension in OpenGL ES 3.0 > > Reviewed-by: Jordan Justen > > On 2018-07-25 10:48:31,

Re: [Mesa-dev] [RFC][PATCH 2/5] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 5:34 AM, Emil Velikov wrote: > On 25 July 2018 at 00:21, John Stultz wrote: >> From: Sumit Semwal >> >> This is a forward port of a patch from the AOSP/master tree: >>

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 --- Comment #2 from Aaron Watry --- My home system has an RX580 (Polaris10). I just cloned/built CLBlast and it appears to be running ./clblast_tuner_xgemm (mentioned as the specific failing case in

Re: [Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 5:36 AM, Emil Velikov wrote: > On 25 July 2018 at 00:21, John Stultz wrote: >> From: Dan Willemsen >> >> This is a forward port of a patch from the AOSP/master tree: >>

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 --- Comment #3 from Gian-Carlo Pascutto --- You can see in my original comment that there are passes with LLVM 6.0.0 and failures for LLVM 6.0.1. So indeed, it can't be LLVM either. I'm not sure if it's possible for libclc to be different

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov wrote: > On 25 July 2018 at 00:21, John Stultz wrote: >> From: Yong Yao >> >> This is a forward port of a patch from the AOSP/master branch: >>

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-25 Thread Chema Casanova
Reviewed-by: Jose Maria Casanova Crespo El 25/07/18 a las 21:25, Eric Engestrom escribió: > On Wednesday, 2018-07-25 19:45:56 +0100, Eric Engestrom wrote: >> CovID: 1438132 >> Signed-off-by: Eric Engestrom > > Forgot to check before sending: > > Fixes: a99c9e63a07477634ab73 "anv: finish the

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 6:50 AM, Rob Herring wrote: > On Tue, Jul 24, 2018 at 5:21 PM John Stultz wrote: >> >> From: Yong Yao >> >> This is a forward port of a patch from the AOSP/master branch: >>

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.5 Candidate

2018-07-25 Thread Nanley Chery
On Wed, Jul 25, 2018 at 11:47:59AM -0700, Dylan Baker wrote: > Greetings, > > Mesa the staging/18.1 branch is currently slushed for 18.1.5, and assuming > that > there are no regressions or patches critically necessary this will be merged > to > the 18.1 branch for a release Friday morning,

Re: [Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 1:06 PM, Dan Willemsen wrote: > On Wed, Jul 25, 2018 at 12:35 PM John Stultz wrote: >> >> On Wed, Jul 25, 2018 at 5:36 AM, Emil Velikov >> wrote: >> > On 25 July 2018 at 00:21, John Stultz wrote: >> >> From: Dan Willemsen >> >> >> >> This is a forward port of a patch

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.5 Candidate

2018-07-25 Thread Dylan Baker
Quoting Nanley Chery (2018-07-25 13:17:47) > On Wed, Jul 25, 2018 at 11:47:59AM -0700, Dylan Baker wrote: > > Greetings, > > > > Mesa the staging/18.1 branch is currently slushed for 18.1.5, and assuming > > that > > there are no regressions or patches critically necessary this will be > >

Re: [Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-25 Thread Dan Willemsen
On Wed, Jul 25, 2018 at 12:35 PM John Stultz wrote: > > On Wed, Jul 25, 2018 at 5:36 AM, Emil Velikov > wrote: > > On 25 July 2018 at 00:21, John Stultz wrote: > >> From: Dan Willemsen > >> > >> This is a forward port of a patch from the AOSP/master tree: > >>

Re: [Mesa-dev] [RFC][PATCH 5/5] Android.mk: Fix checkbuild on Mac builders.

2018-07-25 Thread Alistair Strachan
On Wed, Jul 25, 2018 at 5:48 AM Emil Velikov wrote: > > On 25 July 2018 at 00:21, John Stultz wrote: > > From: Alistair Strachan > > > > This is a forward port of a patch in the AOSP/master tree: > >

Re: [Mesa-dev] [PATCH mesa 1/3] anv: remove unnecessary semicolons in python

2018-07-25 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-07-25 12:14:50) > Signed-off-by: Eric Engestrom > --- > src/intel/vulkan/anv_extensions.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/intel/vulkan/anv_extensions.py >

Re: [Mesa-dev] [RFC][PATCH 5/5] Android.mk: Fix checkbuild on Mac builders.

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 12:33 PM, Alistair Strachan wrote: > On Wed, Jul 25, 2018 at 5:48 AM Emil Velikov wrote: >> >> On 25 July 2018 at 00:21, John Stultz wrote: >> > From: Alistair Strachan >> > >> > This is a forward port of a patch in the AOSP/master tree: >> >

  1   2   >