Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Wed, Mar 7, 2018 at 4:42 PM, Dylan Baker wrote: > Quoting Jason Ekstrand (2018-03-07 06:34:52) > > The original string map assumed that the mapping from strings to > > entrypoints was a bijection. This will not be true the moment we > > add entrypoint aliasing. This reworks things to be an a

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Fri, Mar 9, 2018 at 11:59 AM, Dave Airlie wrote: > Working under embargoes does suck and quite a lot of people had seen > this code but I think the process falls down a bit when Jason wrote > (even tongue-in-cheek) > "You're 4.5 hours too late, I'm afraid. I'd be happy to take some > patches

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Working under embargoes does suck and quite a lot of people had seen this code but I think the process falls down a bit when Jason wrote (even tongue-in-cheek) "You're 4.5 hours too late, I'm afraid. I'd be happy to take some patches though. :-)" I know in this case Dylan writing patches is proba

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Fri, Mar 9, 2018 at 8:57 AM, Alex Deucher wrote: > On Fri, Mar 9, 2018 at 11:04 AM, Jason Ekstrand > wrote: > > On March 9, 2018 00:35:06 Michel Dänzer wrote: > > > >> On 2018-03-08 07:53 PM, Jason Ekstrand wrote: > >>> > >>> On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker >>>

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Fri, Mar 9, 2018 at 11:04 AM, Jason Ekstrand wrote: > On March 9, 2018 00:35:06 Michel Dänzer wrote: > >> On 2018-03-08 07:53 PM, Jason Ekstrand wrote: >>> >>> On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker >> > wrote: >>> >>> > I know we've always given a lot of f

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On March 9, 2018 00:35:06 Michel Dänzer wrote: On 2018-03-08 07:53 PM, Jason Ekstrand wrote: On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker mailto:dy...@pnwbakers.com>> wrote: > I know we've always given a lot of flexibility to vendor specific code > (i965 or nouveau), but you hope every

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On 2018-03-08 07:53 PM, Jason Ekstrand wrote: > On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker > wrote: > > > I know we've always given a lot of flexibility to vendor specific code > > (i965 or nouveau), but you hope everyone can understand my frustration > >

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Thu, Mar 8, 2018 at 11:58 AM, Eric Anholt wrote: > Jason Ekstrand writes: > > > On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker wrote: > > > >> Quoting Jason Ekstrand (2018-03-07 20:22:51) > >> > Yes, that is what happened. That said, wrote that patch in September > and > >> > you've had about

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Jason Ekstrand writes: > On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker wrote: > >> Quoting Jason Ekstrand (2018-03-07 20:22:51) >> > Yes, that is what happened. That said, wrote that patch in September and >> > you've had about 6 months to look at it. The only particularly active >> Mesa >> > co

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker wrote: > Quoting Jason Ekstrand (2018-03-07 20:22:51) > > Yes, that is what happened. That said, wrote that patch in September and > > you've had about 6 months to look at it. The only particularly active > Mesa > > contributor who hasn't had access i

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On 2018-03-08 06:10 PM, Dylan Baker wrote: > > When I was given commit access I was told that I should wait 24 hours > after sending patches unless they were trivial or fixed something > critical, ie, without them you can't compile or nothing works. FWIW, I think that's a good rule, and I follow

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On 7 March 2018 at 14:34, Jason Ekstrand wrote: > The original string map assumed that the mapping from strings to > entrypoints was a bijection. This will not be true the moment we > add entrypoint aliasing. This reworks things to be an arbitrary map > from strings to non-negative signed intege

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Quoting Ilia Mirkin (2018-03-08 08:59:12) > On Thu, Mar 8, 2018 at 11:45 AM, Dylan Baker wrote: > > Quoting Jason Ekstrand (2018-03-07 20:22:51) > >> Yes, that is what happened. That said, wrote that patch in September and > >> you've had about 6 months to look at it. The only particularly activ

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Thu, Mar 8, 2018 at 11:45 AM, Dylan Baker wrote: > Quoting Jason Ekstrand (2018-03-07 20:22:51) >> Yes, that is what happened. That said, wrote that patch in September and >> you've had about 6 months to look at it. The only particularly active Mesa >> contributor who hasn't had access is Ili

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Quoting Jason Ekstrand (2018-03-07 20:22:51) > Yes, that is what happened. That said, wrote that patch in September and > you've had about 6 months to look at it. The only particularly active Mesa > contributor who hasn't had access is Ilia. No, just no. Having a patch in a branch does not cou

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Yes, that is what happened. That said, wrote that patch in September and you've had about 6 months to look at it. The only particularly active Mesa contributor who hasn't had access is Ilia. On March 7, 2018 20:13:28 Dylan Baker wrote: You sent out a 56 patch series and didn't even wait 1

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

You sent out a 56 patch series and didn't even wait 12 hours before pushing it? Quoting Jason Ekstrand (2018-03-07 19:56:21) > You're 4.5 hours too late, I'm afraid.  I'd be happy to take some patches > though. :-) > > On Wed, Mar 7, 2018 at 4:42 PM, Dylan Baker wrote: > > Quoting Jason Eks

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

You're 4.5 hours too late, I'm afraid. I'd be happy to take some patches though. :-) On Wed, Mar 7, 2018 at 4:42 PM, Dylan Baker wrote: > Quoting Jason Ekstrand (2018-03-07 06:34:52) > > The original string map assumed that the mapping from strings to > > entrypoints was a bijection. This will

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Quoting Jason Ekstrand (2018-03-07 06:34:52) > The original string map assumed that the mapping from strings to > entrypoints was a bijection. This will not be true the moment we > add entrypoint aliasing. This reworks things to be an arbitrary map > from strings to non-negative signed integers.