Yes, from the text you quoted it seems it was indeed incorrect.
However, it almost surely ran on any common platform, and the added
assert introduced a bug because it would trip for valid usage.
My point is that the incorrectness of the patch (and the fact that the
if above that place checking for
> -Original Message-
>
> BTW, I just looked at one of the assert commits, and found it actually
> _introduces_ a bug.
> Look at the assert(attrib_list) added in
> 706fffbff59be0dc884e1938f1bdf731af1efa3e.
>
> This ends up asserting that the attrib_list in glXCreatePixmap is not
> NULL.
>
Just noticed that has already been fixed in
5f40a7aed12500fd6792e2453f49c3b5c54d with an if(attrib_list).
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proa
still not working/not plugged in..
What i need to do about lack of
->new_state and ->current_primitive in ctx ?
From 50c585a409efdce367aabffa6192bd98d4e9da28 Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu
Date: Thu, 4 Mar 2010 17:54:20 +
Subject: [PATCH 1/5] Add WAR_ONCE macro loca
> For static analysis with Coverity Prevent, the added assert will clear a
> defect report and/or allow it to continue parsing to the next possible defect.
Are these being checked manually and determined to be false positives?
If not, then it would be beneficial to not shut up static analysis,
si
Vinson Lee wrote:
>> -Original Message-
>>
>>> mesa: Remove pointless comparison of unsigned integer with a negative
>> constant.
>>> ---
>>>
>>> src/mesa/shader/prog_execute.c | 13 -
>>> 1 files changed, 4 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/src/mesa/shader/p
> -Original Message-
>
> >
> > mesa: Remove pointless comparison of unsigned integer with a negative
> constant.
> >
> > ---
> >
> > src/mesa/shader/prog_execute.c | 13 -
> > 1 files changed, 4 insertions(+), 9 deletions(-)
> >
> > diff --git a/src/mesa/shader/prog_execute.
Ian, maybe there's a better way to do this?
We need to enable OML_sync_control only if supported, now that we can
actually support it, otherwise old userspace depending on the somewhat
broken old behavior will break.
diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
index 29d589c..d69bb32 1006
> -Original Message-
> From: Ian Romanick [mailto:i...@freedesktop.org]
> Sent: Thursday, March 04, 2010 3:17 PM
> To: mesa3d-dev
> Subject: Re: [Mesa3d-dev] Mesa (master): glsl/pp: Add asserts to check for
> null pointer deferences.
>
>
> What is the benefit of adding all these NULL poin
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Vinson Lee wrote:
> Module: Mesa
> Branch: master
> Commit: a05fdbcb719ac64e6be842372813f0f4ca2f4f93
> URL:
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=a05fdbcb719ac64e6be842372813f0f4ca2f4f93
>
> Author: Vinson Lee
> Date: Mon Feb 15 02
On Fri, 05 Mar 2010 00:16:45 +0100
Michel Dänzer wrote:
> On Thu, 2010-03-04 at 16:09 -0700, Brian Paul wrote:
> > Jesse Barnes wrote:
> > > Would anyone have objections if these lists moved to freedesktop.org?
> > > The recent thread with Linus about the drm pull request highlights the
> > > po
On Thu, 2010-03-04 at 13:56 -0700, Brian Paul wrote:
> Michel Dänzer wrote:
> > On Thu, 2010-03-04 at 02:00 -0800, Vinson Lee wrote:
> >> Michel, thanks for spotting this.
> >>
> >> I've reverted the bad commit. Please go ahead and submit your correct fix.
> >
> > Actually, I wonder if something
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
What is the benefit of adding all these NULL pointer assertions? I
don't see a big benefit of an assertion failure vs. a segfault.
I'm just curious.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla -
On Thu, Mar 4, 2010 at 15:09, Brian Paul wrote:
> Jesse Barnes wrote:
>> Would anyone have objections if these lists moved to freedesktop.org?
>> The recent thread with Linus about the drm pull request highlights the
>> post lag and non-subscriber aspect of the current lists, and that
>> leaves as
On Thu, 2010-03-04 at 16:09 -0700, Brian Paul wrote:
> Jesse Barnes wrote:
> > Would anyone have objections if these lists moved to freedesktop.org?
> > The recent thread with Linus about the drm pull request highlights the
> > post lag and non-subscriber aspect of the current lists, and that
> >
Jesse Barnes wrote:
> Would anyone have objections if these lists moved to freedesktop.org?
> The recent thread with Linus about the drm pull request highlights the
> post lag and non-subscriber aspect of the current lists, and that
> leaves aside sf.net's horrible mail archive interface and poor
>
On Thu, 4 Mar 2010 14:55:29 -0800
Dan Nicholson wrote:
> On Thu, Mar 4, 2010 at 2:42 PM, Eric Anholt wrote:
> > On Thu, 4 Mar 2010 12:37:23 -0800, Jesse Barnes
> > wrote:
> >> Would anyone have objections if these lists moved to freedesktop.org?
> >> The recent thread with Linus about the drm
On Thu, Mar 4, 2010 at 2:42 PM, Eric Anholt wrote:
> On Thu, 4 Mar 2010 12:37:23 -0800, Jesse Barnes
> wrote:
>> Would anyone have objections if these lists moved to freedesktop.org?
>> The recent thread with Linus about the drm pull request highlights the
>> post lag and non-subscriber aspect o
On Thu, 4 Mar 2010 12:37:23 -0800, Jesse Barnes
wrote:
> Would anyone have objections if these lists moved to freedesktop.org?
> The recent thread with Linus about the drm pull request highlights the
> post lag and non-subscriber aspect of the current lists, and that
> leaves aside sf.net's horri
On Thu, Mar 4, 2010 at 3:37 PM, Jesse Barnes wrote:
> Would anyone have objections if these lists moved to freedesktop.org?
Yes please!
> The recent thread with Linus about the drm pull request highlights the
> post lag and non-subscriber aspect of the current lists, and that
> leaves aside sf.n
Moving seems like a good idea. The delays here have been very troubling.
--
Mike Stroyan - Software Architect
LunarG, Inc. - The Graphics Experts
Cell: (970) 219-7905
Email: m...@lunarg.com
Website: http://www.lunarg.com
--
On Thu, Mar 4, 2010 at 3:37 PM, Jesse Barnes wrote:
> Would anyone have objections if these lists moved to freedesktop.org?
> The recent thread with Linus about the drm pull request highlights the
> post lag and non-subscriber aspect of the current lists, and that
> leaves aside sf.net's horrible
Would anyone have objections if these lists moved to freedesktop.org?
The recent thread with Linus about the drm pull request highlights the
post lag and non-subscriber aspect of the current lists, and that
leaves aside sf.net's horrible mail archive interface and poor
performance.
If spam is an i
Michel Dänzer wrote:
> On Thu, 2010-03-04 at 02:00 -0800, Vinson Lee wrote:
>> Michel, thanks for spotting this.
>>
>> I've reverted the bad commit. Please go ahead and submit your correct fix.
>
> Actually, I wonder if something like the below isn't needed to avoid any
> undesired effects from i
On Thu, 2010-03-04 at 02:00 -0800, Vinson Lee wrote:
> Michel, thanks for spotting this.
>
> I've reverted the bad commit. Please go ahead and submit your correct fix.
Actually, I wonder if something like the below isn't needed to avoid any
undesired effects from integer overflows.
diff --git
Mesa commit 93115c4b235896df097b91edec7458a8a4488c4e deleted some
interesting
code i want to resurrect.
Mostly code from old src/mesa/drivers/dri/nouveau/nv04_swtcl.c
I tried to include #include "tnl_dd/t_dd_tritmp.h" directly into nv04_render.c
and after this compilation fail (with gcc 4.
Hi George.
I've pulled that last commit and did a rebuild with the same
variables,and progs/tests compiles successfully!
Thank you very much.
Regards,
STEVE555
STEVE555 wrote:
>
> Here is some additional information when I was trying to build Mesa with
> the latest co
This branch is hopefully ready for broader testing ahead of a merge.
Can people, especially nv people, pull this down and try it out. Jakob
has made a best effort to get this right, but neither of us have
hardware.
The branch itself is the start of a significant cleanup of some of the
uglier bit
should be fixed now in master
On Thu, Mar 4, 2010 at 4:21 PM, STEVE555 wrote:
>
> I've got closer in solving my problem to get progs/tests to build.Here's what
> I did:
> I edited my ld.so.conf and and put just one space under the code in there
> /usr and /usr/lib directly underneath.
> I then r
I've got closer in solving my problem to get progs/tests to build.Here's what
I did:
I edited my ld.so.conf and and put just one space under the code in there
/usr and /usr/lib directly underneath.
I then ran ldconfig.Then I opened up Konsole as root on the Mesa folder and
I ran these commands:
e
Michel, thanks for spotting this.
I've reverted the bad commit. Please go ahead and submit your correct fix.
From: Michel Dänzer [mic...@daenzer.net]
Sent: Thursday, March 04, 2010 1:41 AM
To: Vinson Lee
Cc: mesa3d-...@lists.sf.net
Subject: Re: Mesa (maste
On Thu, 2010-03-04 at 01:27 -0800, Vinson Lee wrote:
> Module: Mesa
> Branch: master
> Commit: f9504e75f02586a8561733e0e2711c65efa2979d
> URL:
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9504e75f02586a8561733e0e2711c65efa2979d
>
> Author: Vinson Lee
> Date: Thu Mar 4 01:24:44 2010
32 matches
Mail list logo
