Re: [Mesa3d-dev] Importing real strtod code

2009-10-09 Thread Chris Rankin
--- On Thu, 8/10/09, Brian Paul bri...@vmware.com wrote: I think that we could just bracket the call to _slang_compile() with the set/restore-locale calls. I'd hate to make an obvious suggestion, but... can't you just copy strtod() code (without the locale support) from GLIBC? My basic

Re: [Mesa3d-dev] Importing real strtod code

2009-10-09 Thread Robert Noland
On Fri, 2009-10-09 at 01:03 -0700, Chris Rankin wrote: --- On Thu, 8/10/09, Brian Paul bri...@vmware.com wrote: I think that we could just bracket the call to _slang_compile() with the set/restore-locale calls. I'd hate to make an obvious suggestion, but... can't you just copy strtod()

Re: [Mesa3d-dev] Importing real strtod code

2009-10-09 Thread Chris Rankin
--- On Fri, 9/10/09, Robert Noland rnol...@2hip.net wrote: You can't include GPL code into an MIT project without poluting the license. Ah. So that means Mesa would need the GLIBC copyright holder's explicit permission ... That would be Uli Drepper, presumably. Cheers, Chris

[Mesa3d-dev] drawing with elements out of range

2009-10-09 Thread michal
I've been able to crash my app that uses a gallium driver by feeding the draw module an index buffer with garbage contents. Is there a desire to add out-of-bounds checking of every index element, or is it being ignored on purpose for performance reasons? Thanks.

Re: [Mesa3d-dev] drawing with elements out of range

2009-10-09 Thread Keith Whitwell
On Fri, 2009-10-09 at 04:10 -0700, michal wrote: I've been able to crash my app that uses a gallium driver by feeding the draw module an index buffer with garbage contents. Is there a desire to add out-of-bounds checking of every index element, or is it being ignored on purpose for

Re: [Mesa3d-dev] drawing with elements out of range

2009-10-09 Thread michal
Keith Whitwell pisze: On Fri, 2009-10-09 at 04:10 -0700, michal wrote: I've been able to crash my app that uses a gallium driver by feeding the draw module an index buffer with garbage contents. Is there a desire to add out-of-bounds checking of every index element, or is it being

[Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread michal
From 5ebc14fc47a5e31b3c6be54142550bdf2ac093df Mon Sep 17 00:00:00 2001 From: Michal Krol mic...@vmware.com Date: Fri, 9 Oct 2009 13:30:52 +0100 Subject: [PATCH] draw: Do an out-of-bounds check on array elements. Do not draw a reduced primitive if any of its vertices reaches outside of the vertex

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread Keith Whitwell
Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less overhead by validating the incoming index list. We normally do that in Mesa or the state tracker, if that helps. Keith On Fri, 2009-10-09 at 06:01 -0700, michal wrote:

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread michal
Keith Whitwell pisze: Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less overhead by validating the incoming index list. OK, so we scan the whole element array beforehand, and if any element is out of range, we

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread Keith Whitwell
On Fri, 2009-10-09 at 06:19 -0700, michal wrote: Keith Whitwell pisze: Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less overhead by validating the incoming index list. OK, so we scan the whole element

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread Keith Whitwell
On Fri, 2009-10-09 at 06:19 -0700, michal wrote: Keith Whitwell pisze: Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less overhead by validating the incoming index list. OK, so we scan the whole element

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread Brian Paul
Keith Whitwell wrote: On Fri, 2009-10-09 at 06:19 -0700, michal wrote: Keith Whitwell pisze: Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less overhead by validating the incoming index list. OK, so we scan the

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread Keith Whitwell
On Fri, 2009-10-09 at 07:10 -0700, Brian Paul wrote: Keith Whitwell wrote: On Fri, 2009-10-09 at 06:19 -0700, michal wrote: Keith Whitwell pisze: Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less overhead by

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread michal
Keith Whitwell pisze: On Fri, 2009-10-09 at 06:19 -0700, michal wrote: Keith Whitwell pisze: Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less overhead by validating the incoming index list.

Re: [Mesa3d-dev] [PATCH] draw: Do an out-of-bounds check on array elements.

2009-10-09 Thread Keith Whitwell
On Fri, 2009-10-09 at 08:01 -0700, michal wrote: Keith Whitwell pisze: On Fri, 2009-10-09 at 06:19 -0700, michal wrote: Keith Whitwell pisze: Michal, Sorry, this isn't a great way to do this. This can usually be caught much earlier in the pipeline and with much less

[Mesa3d-dev] [Bug 24425] New: rv770 hangs when trying to play mesa (bisected)

2009-10-09 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=24425 Summary: rv770 hangs when trying to play mesa (bisected) Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal

Re: [Mesa3d-dev] Importing real strtod code

2009-10-09 Thread Kristian Høgsberg
On Thu, Oct 8, 2009 at 5:47 PM, Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The root cause of bug #23308 has been determined to be the use of strtod in our assembly and GLSL parsers.  When LANG is set to a locale that changes the radix from . to,

[Mesa3d-dev] [Bug 24425] rv770 hangs when trying to play nexuiz (mesa bisected)

2009-10-09 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=24425 Asbjørn Sannes a...@sannes.org changed: What|Removed |Added Summary|rv770 hangs when trying to |rv770 hangs when trying

Re: [Mesa3d-dev] Importing real strtod code

2009-10-09 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chris Rankin wrote: --- On Thu, 8/10/09, Brian Paul bri...@vmware.com wrote: I think that we could just bracket the call to _slang_compile() with the set/restore-locale calls. I'd hate to make an obvious suggestion, but... can't you just copy

Re: [Mesa3d-dev] drawing with elements out of range

2009-10-09 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 michal wrote: Is there a desire to add out-of-bounds checking of every index element, or is it being ignored on purpose for performance reasons? The later. The OpenGL spec allows implementations to crash buggy applications anytime that